happyskills 0.30.0 → 0.31.0

package/src/integration/cli.test.js

@@ -688,3 +688,264 @@ describe('CLI — delete command', () => {
 		}
 	})
 })
+
+// ---------------------------------------------------------------------------
+// Enable / Disable
+// ---------------------------------------------------------------------------
+
+/**
+ * Helper: scaffold a project directory with a lock file and skill dirs that
+ * mimic a real HappySkills install. Returns { project_root, cleanup }.
+ *
+ * Structure:
+ *   <tmp>/
+ *   ├── skills-lock.json
+ *   ├── .agents/skills/<skill_name>/SKILL.md   (canonical)
+ *   └── .claude/skills/<skill_name> → symlink  (agent link)
+ */
+const scaffold_project = (skills) => {
+	const root = make_tmp()
+	const lock_skills = {}
+
+	for (const s of skills) {
+		const canonical = path.join(root, '.agents', 'skills', s.short)
+		fs.mkdirSync(canonical, { recursive: true })
+		fs.writeFileSync(path.join(canonical, 'SKILL.md'), `---\nname: ${s.short}\ndescription: test skill\n---\nTest`)
+
+		if (s.enabled !== false) {
+			const agent_dir = path.join(root, '.claude', 'skills')
+			fs.mkdirSync(agent_dir, { recursive: true })
+			fs.symlinkSync(canonical, path.join(agent_dir, s.short), 'junction')
+		}
+
+		lock_skills[s.full] = {
+			version: s.version || '1.0.0',
+			type: 'skill',
+			ref: `refs/tags/v${s.version || '1.0.0'}`,
+			commit: 'abc123',
+			integrity: null,
+			base_commit: 'abc123',
+			base_integrity: null,
+			requested_by: ['__root__'],
+			dependencies: {}
+		}
+	}
+
+	fs.writeFileSync(path.join(root, 'skills-lock.json'), JSON.stringify({
+		lockVersion: 2,
+		generatedAt: new Date().toISOString(),
+		skills: lock_skills
+	}, null, '\t'))
+
+	return { root, cleanup: () => fs.rmSync(root, { recursive: true, force: true }) }
+}
+
+describe('enable / disable commands', () => {
+	it('enable --help exits 0', () => {
+		const { code, stdout } = run(['enable', '--help'])
+		assert.strictEqual(code, 0)
+		assert.ok(stdout.includes('Usage: happyskills enable'))
+	})
+
+	it('disable --help exits 0', () => {
+		const { code, stdout } = run(['disable', '--help'])
+		assert.strictEqual(code, 0)
+		assert.ok(stdout.includes('Usage: happyskills disable'))
+	})
+
+	it('"on" alias resolves to enable', () => {
+		const { code, stdout } = run(['on', '--help'])
+		assert.strictEqual(code, 0)
+		assert.ok(stdout.includes('Usage: happyskills enable'))
+	})
+
+	it('"off" alias resolves to disable', () => {
+		const { code, stdout } = run(['off', '--help'])
+		assert.strictEqual(code, 0)
+		assert.ok(stdout.includes('Usage: happyskills disable'))
+	})
+
+	it('disable without arguments exits with usage error', () => {
+		const { code, stderr } = run(['disable', '--json'])
+		assert.strictEqual(code, 2)
+	})
+
+	it('enable without arguments exits with usage error', () => {
+		const { code, stderr } = run(['enable', '--json'])
+		assert.strictEqual(code, 2)
+	})
+
+	it('disable removes agent symlink, enable restores it', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws' }
+		])
+		try {
+			const link_path = path.join(root, '.claude', 'skills', 'deploy-aws')
+
+			// Verify symlink exists before disable
+			assert.ok(fs.lstatSync(link_path).isSymbolicLink())
+
+			// Disable — force agents to claude only (auto-detect won't find .claude in tmp)
+			const d = run(['disable', 'acme/deploy-aws', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(d.code, 0, `disable failed: ${d.stderr}`)
+			assert.ok(!fs.existsSync(link_path), 'symlink should be removed after disable')
+
+			// Canonical dir must still exist
+			assert.ok(fs.existsSync(path.join(root, '.agents', 'skills', 'deploy-aws')))
+
+			// Enable
+			const e = run(['enable', 'acme/deploy-aws', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(e.code, 0, `enable failed: ${e.stderr}`)
+			assert.ok(fs.lstatSync(link_path).isSymbolicLink(), 'symlink should be restored after enable')
+		} finally {
+			clean()
+		}
+	})
+
+	it('disable an already-disabled skill warns but does not fail', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws', enabled: false }
+		])
+		try {
+			const { code, stderr } = run(['disable', 'acme/deploy-aws', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			assert.ok(stderr.includes('already disabled'))
+		} finally {
+			clean()
+		}
+	})
+
+	it('enable an already-enabled skill warns but does not fail', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws', enabled: true }
+		])
+		try {
+			const { code, stderr } = run(['enable', 'acme/deploy-aws', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			assert.ok(stderr.includes('already enabled'))
+		} finally {
+			clean()
+		}
+	})
+
+	it('disable multiple skills at once', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws' },
+			{ full: 'acme/monitoring', short: 'monitoring' }
+		])
+		try {
+			const { code } = run(['disable', 'acme/deploy-aws', 'acme/monitoring', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+
+			assert.ok(!fs.existsSync(path.join(root, '.claude', 'skills', 'deploy-aws')))
+			assert.ok(!fs.existsSync(path.join(root, '.claude', 'skills', 'monitoring')))
+		} finally {
+			clean()
+		}
+	})
+
+	it('disable accepts short names', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws' }
+		])
+		try {
+			const { code } = run(['disable', 'deploy-aws', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			assert.ok(!fs.existsSync(path.join(root, '.claude', 'skills', 'deploy-aws')))
+		} finally {
+			clean()
+		}
+	})
+
+	it('enable accepts short names', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws', enabled: false }
+		])
+		try {
+			const { code } = run(['enable', 'deploy-aws', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			assert.ok(fs.lstatSync(path.join(root, '.claude', 'skills', 'deploy-aws')).isSymbolicLink())
+		} finally {
+			clean()
+		}
+	})
+
+	it('disable a non-existent skill warns but does not fail', () => {
+		const { root, cleanup: clean } = scaffold_project([])
+		try {
+			const { code, stderr } = run(['disable', 'acme/nope', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			assert.ok(stderr.includes('not a HappySkills-managed skill'))
+		} finally {
+			clean()
+		}
+	})
+
+	it('disable --json returns structured results', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws' }
+		])
+		try {
+			const { code, stdout } = run(['disable', 'acme/deploy-aws', '--agents', 'claude', '--json'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			const out = parse_json_output(stdout, 'disable --json')
+			assert.ok(out.data)
+			assert.ok(Array.isArray(out.data.results))
+			assert.strictEqual(out.data.results[0].skill, 'acme/deploy-aws')
+			assert.strictEqual(out.data.results[0].status, 'disabled')
+		} finally {
+			clean()
+		}
+	})
+
+	it('enable --json returns structured results', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws', enabled: false }
+		])
+		try {
+			const { code, stdout } = run(['enable', 'acme/deploy-aws', '--agents', 'claude', '--json'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			const out = parse_json_output(stdout, 'enable --json')
+			assert.ok(out.data)
+			assert.ok(Array.isArray(out.data.results))
+			assert.strictEqual(out.data.results[0].skill, 'acme/deploy-aws')
+			assert.strictEqual(out.data.results[0].status, 'enabled')
+		} finally {
+			clean()
+		}
+	})
+})
+
+describe('list — enabled column', () => {
+	it('list --json includes enabled field for managed skills', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws', enabled: true },
+			{ full: 'acme/monitoring', short: 'monitoring', enabled: false }
+		])
+		try {
+			const { code, stdout } = run(['list', '--json', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			const out = parse_json_output(stdout, 'list --json')
+			assert.strictEqual(out.data.skills['acme/deploy-aws'].enabled, true)
+			assert.strictEqual(out.data.skills['acme/monitoring'].enabled, false)
+		} finally {
+			clean()
+		}
+	})
+
+	it('list table output shows enabled/disabled labels', () => {
+		const { root, cleanup: clean } = scaffold_project([
+			{ full: 'acme/deploy-aws', short: 'deploy-aws', enabled: true },
+			{ full: 'acme/monitoring', short: 'monitoring', enabled: false }
+		])
+		try {
+			const { code, stdout } = run(['list', '--agents', 'claude'], {}, { cwd: root })
+			assert.strictEqual(code, 0)
+			assert.ok(stdout.includes('Enabled'), 'table should have Enabled header')
+			assert.ok(stdout.includes('enabled'), 'should show enabled label')
+			assert.ok(stdout.includes('disabled'), 'should show disabled label')
+		} finally {
+			clean()
+		}
+	})
+})