happy-stacks 0.3.0 → 0.5.0

package/scripts/utils/dev/daemon.mjs

@@ -1,4 +1,5 @@
-import { resolve } from 'node:path';
+import { join, resolve } from 'node:path';
+import { existsSync } from 'node:fs';
 
 import { ensureCliBuilt, ensureDepsInstalled } from '../proc/pm.mjs';
 import { watchDebounced } from '../proc/watch.mjs';
@@ -7,7 +8,26 @@ import { startLocalDaemonWithAuth } from '../../daemon.mjs';
 
 export async function ensureDevCliReady({ cliDir, buildCli }) {
   await ensureDepsInstalled(cliDir, 'happy-cli');
-  return await ensureCliBuilt(cliDir, { buildCli });
+  const res = await ensureCliBuilt(cliDir, { buildCli });
+
+  // Fail closed: dev mode must never start the daemon without a usable happy-cli build output.
+  // Even if the user disabled CLI builds globally (or build mode is "never"), missing dist will
+  // cause an immediate MODULE_NOT_FOUND crash when spawning the daemon.
+  const distEntrypoint = join(cliDir, 'dist', 'index.mjs');
+  if (!existsSync(distEntrypoint)) {
+    // Last-chance recovery: force a build once.
+    await ensureCliBuilt(cliDir, { buildCli: true });
+    if (!existsSync(distEntrypoint)) {
+      throw new Error(
+        `[local] happy-cli build output is missing.\n` +
+          `Expected: ${distEntrypoint}\n` +
+          `Fix: run the component build directly and inspect its output:\n` +
+          `  cd "${cliDir}" && yarn build`
+      );
+    }
+  }
+
+  return res;
 }
 
 export async function prepareDaemonAuthSeed({
@@ -77,8 +97,25 @@ export function watchHappyCliAndRestartDaemon({
   if (!enabled || !startDaemon) return null;
 
   let inFlight = false;
+
+  // IMPORTANT:
+  // Watch only source/config paths, not build outputs. Watching the whole repo can
+  // trigger rebuild loops because `yarn build` writes to `dist/` (and may touch other
+  // generated files), which then retriggers the watcher.
+  const watchPaths = [
+    join(cliDir, 'src'),
+    join(cliDir, 'bin'),
+    join(cliDir, 'codex'),
+    join(cliDir, 'package.json'),
+    join(cliDir, 'tsconfig.json'),
+    join(cliDir, 'tsconfig.build.json'),
+    join(cliDir, 'pkgroll.config.mjs'),
+    join(cliDir, 'yarn.lock'),
+    join(cliDir, 'pnpm-lock.yaml'),
+  ].filter((p) => existsSync(p));
+
   return watchDebounced({
-    paths: [resolve(cliDir)],
+    paths: (watchPaths.length ? watchPaths : [cliDir]).map((p) => resolve(p)),
     debounceMs: 500,
     onChange: async () => {
       if (isShuttingDown?.()) return;
@@ -87,7 +124,27 @@ export function watchHappyCliAndRestartDaemon({
       try {
         // eslint-disable-next-line no-console
         console.log('[local] watch: happy-cli changed → rebuilding + restarting daemon...');
-        await ensureCliBuilt(cliDir, { buildCli });
+        try {
+          await ensureCliBuilt(cliDir, { buildCli });
+        } catch (e) {
+          // IMPORTANT:
+          // - A rebuild can legitimately fail while an agent is mid-edit (e.g. TS errors).
+          // - In that case we must NOT restart the daemon (we'd just restart into a broken build),
+          //   and we must NOT crash the parent dev process. Keep watching for the next change.
+          const msg = e instanceof Error ? e.stack || e.message : String(e);
+          // eslint-disable-next-line no-console
+          console.error('[local] watch: happy-cli rebuild failed; keeping daemon running (will retry on next change).');
+          // eslint-disable-next-line no-console
+          console.error(msg);
+          return;
+        }
+        const distEntrypoint = join(cliDir, 'dist', 'index.mjs');
+        if (!existsSync(distEntrypoint)) {
+          console.warn(
+            `[local] watch: happy-cli build did not produce ${distEntrypoint}; refusing to restart daemon to avoid downtime.`
+          );
+          return;
+        }
         await startLocalDaemonWithAuth({
           cliBin,
           cliHomeDir,

package/scripts/utils/dev/expo_dev.mjs

@@ -0,0 +1,430 @@
+import { fork } from 'node:child_process';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+import net from 'node:net';
+import {
+  ensureExpoIsolationEnv,
+  getExpoStatePaths,
+  isStateProcessRunning,
+  wantsExpoClearCache,
+  writePidState,
+} from '../expo/expo.mjs';
+import { pickExpoDevMetroPort } from '../expo/metro_ports.mjs';
+import { recordStackRuntimeUpdate } from '../stack/runtime_state.mjs';
+import { killProcessGroupOwnedByStack } from '../proc/ownership.mjs';
+import { expoSpawn } from '../expo/command.mjs';
+import { resolveMobileExpoConfig } from '../mobile/config.mjs';
+import { resolveMobileReachableServerUrl } from '../server/mobile_api_url.mjs';
+import { getTailscaleStatus } from '../tailscale/ip.mjs';
+import { pickLanIpv4 } from '../net/lan_ip.mjs';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+function normalizeExpoHost(raw) {
+  const v = String(raw ?? '').trim().toLowerCase();
+  if (v === 'localhost' || v === 'lan' || v === 'tunnel') return v;
+  return 'lan';
+}
+
+/**
+ * Resolve whether Tailscale forwarding for Expo is enabled.
+ *
+ * Can be enabled via:
+ * - --expo-tailscale flag (passed as expoTailscale option)
+ * - HAPPY_STACKS_EXPO_TAILSCALE=1 env var
+ * - HAPPY_LOCAL_EXPO_TAILSCALE=1 env var (legacy)
+ */
+export function resolveExpoTailscaleEnabled({ env = process.env, expoTailscale = false } = {}) {
+  if (expoTailscale) return true;
+  const envVal = (env.HAPPY_STACKS_EXPO_TAILSCALE ?? env.HAPPY_LOCAL_EXPO_TAILSCALE ?? '').toString().trim();
+  return envVal === '1' || envVal.toLowerCase() === 'true';
+}
+
+/**
+ * Start a TCP forwarder process for Expo Tailscale access.
+ *
+ * Forwards from Tailscale IP:port to the LAN IP:port where Expo actually binds.
+ *
+ * @param {Object} options
+ * @param {number} options.metroPort - The Metro bundler port
+ * @param {Object} options.baseEnv - Base environment variables
+ * @param {string} options.stackName - Stack name for logging
+ * @param {Array} options.children - Array to track child processes
+ * @returns {Promise<{ ok: boolean, pid?: number, tailscaleIp?: string, lanIp?: string, error?: string }>}
+ */
+export async function startExpoTailscaleForwarder({ metroPort, baseEnv, stackName, children }) {
+  const ts = await getTailscaleStatus();
+  if (!ts.available || !ts.ip) {
+    // Common case: Tailscale app installed but toggle is off / not connected.
+    // This must never fail stack startup; just skip with a clear message.
+    return { ok: false, error: ts.error || 'Tailscale is not connected' };
+  }
+  const tailscaleIp = ts.ip;
+
+  // Some platforms / Tailscale variants report an IP but do not allow binding to it (EADDRNOTAVAIL).
+  // If we can't bind *at all*, don't spawn the forwarder process (it will just error noisily).
+  const canBind = await new Promise((resolve) => {
+    const srv = net.createServer();
+    const done = (ok, err) => {
+      try {
+        srv.close(() => resolve({ ok, err }));
+      } catch {
+        resolve({ ok, err });
+      }
+    };
+    srv.once('error', (err) => done(false, err));
+    srv.listen(0, tailscaleIp, () => done(true, null));
+  });
+  if (!canBind.ok) {
+    const code = canBind.err && typeof canBind.err === 'object' ? canBind.err.code : '';
+    const msg = canBind.err instanceof Error ? canBind.err.message : String(canBind.err ?? '');
+    const hint =
+      code === 'EADDRNOTAVAIL'
+        ? `Tailscale IP ${tailscaleIp} is not bindable on this machine (EADDRNOTAVAIL).`
+        : `Tailscale IP ${tailscaleIp} is not bindable (${code || 'error'}).`;
+    return { ok: false, error: `${hint}${msg ? ` ${msg}` : ''}`.trim() };
+  }
+
+  // Determine where Expo binds (LAN IP when host=lan, localhost otherwise)
+  const host = resolveExpoDevHost({ env: baseEnv });
+  let targetHost = '127.0.0.1';
+  if (host === 'lan') {
+    const lanIp = pickLanIpv4();
+    if (lanIp) targetHost = lanIp;
+  }
+
+  const label = `expo-ts-fwd${stackName ? `-${stackName}` : ''}`;
+  const forwarderScript = join(__dirname, '..', 'net', 'tcp_forward.mjs');
+
+  // Fork the forwarder as a child process
+  // Note: fork() requires 'ipc' in stdio array
+  const forwarderProc = fork(forwarderScript, [
+    `--listen-host=${tailscaleIp}`,
+    `--listen-port=${metroPort}`,
+    `--target-host=${targetHost}`,
+    `--target-port=${metroPort}`,
+    `--label=${label}`,
+  ], {
+    env: { ...baseEnv },
+    stdio: ['ignore', 'pipe', 'pipe', 'ipc'],
+    detached: process.platform !== 'win32',
+  });
+
+  // Prefix forwarder output
+  const outPrefix = `[${label}] `;
+  forwarderProc.stdout?.on('data', (d) => process.stdout.write(outPrefix + d.toString()));
+  forwarderProc.stderr?.on('data', (d) => process.stderr.write(outPrefix + d.toString()));
+
+  // Wait until the forwarder actually starts listening (or fails) before declaring success.
+  const ready = await new Promise((resolve) => {
+    const t = setTimeout(() => resolve({ ok: false, error: 'forwarder startup timed out' }), 2000);
+    const done = (res) => {
+      clearTimeout(t);
+      resolve(res);
+    };
+    forwarderProc.once('message', (m) => {
+      if (m && typeof m === 'object' && m.type === 'ready') {
+        done({ ok: true });
+      } else if (m && typeof m === 'object' && m.type === 'error') {
+        done({ ok: false, error: m.message ? String(m.message) : 'failed to start' });
+      }
+    });
+    forwarderProc.once('exit', (code, sig) => {
+      done({ ok: false, error: `exited (code=${code}, sig=${sig})` });
+    });
+    forwarderProc.once('error', (e) => {
+      done({ ok: false, error: e instanceof Error ? e.message : String(e) });
+    });
+  });
+
+  if (!ready.ok) {
+    try {
+      forwarderProc.kill('SIGKILL');
+    } catch {
+      // ignore
+    }
+    return { ok: false, error: ready.error || 'failed to start forwarder' };
+  }
+
+  children.push(forwarderProc);
+
+  // eslint-disable-next-line no-console
+  console.log(`[local] expo: Tailscale forwarder started (${tailscaleIp}:${metroPort} -> ${targetHost}:${metroPort})`);
+
+  return {
+    ok: true,
+    pid: forwarderProc.pid,
+    tailscaleIp,
+    lanIp: targetHost,
+    proc: forwarderProc,
+  };
+}
+
+export function resolveExpoDevHost({ env = process.env } = {}) {
+  // Always prefer LAN by default so phones can reach Metro.
+  const raw = (env.HAPPY_STACKS_EXPO_HOST ?? env.HAPPY_LOCAL_EXPO_HOST ?? '').toString();
+  return normalizeExpoHost(raw || 'lan');
+}
+
+export function buildExpoStartArgs({ port, host, wantWeb, wantDevClient, scheme, clearCache }) {
+  const metroPort = Number(port);
+  if (!Number.isFinite(metroPort) || metroPort <= 0) {
+    throw new Error(`[expo] invalid Metro port: ${String(port)}`);
+  }
+  if (!wantWeb && !wantDevClient) {
+    throw new Error('[expo] cannot build Expo args: neither web nor dev-client requested');
+  }
+
+  // IMPORTANT:
+  // - We must only run one Expo per stack.
+  // - Expo dev-client mode is known to still serve web when accessed locally, so when mobile is
+  //   requested we prefer `--dev-client` as the single shared process (no second `--web` process).
+  const args = wantDevClient
+    ? ['start', '--dev-client', '--host', host, '--port', String(metroPort)]
+    : ['start', '--web', '--host', host, '--port', String(metroPort)];
+
+  if (wantDevClient) {
+    const s = String(scheme ?? '').trim();
+    if (s) {
+      args.push('--scheme', s);
+    }
+  }
+
+  if (clearCache && !args.includes('--clear')) {
+    args.push('--clear');
+  }
+
+  return args;
+}
+
+function expoModeLabel({ wantWeb, wantDevClient }) {
+  if (wantWeb && wantDevClient) return 'dev-client+web';
+  if (wantDevClient) return 'dev-client';
+  if (wantWeb) return 'web';
+  return 'disabled';
+}
+
+export async function ensureDevExpoServer({
+  startUi,
+  startMobile,
+  uiDir,
+  autostart,
+  baseEnv,
+  apiServerUrl,
+  restart,
+  stackMode,
+  runtimeStatePath,
+  stackName,
+  envPath,
+  children,
+  spawnOptions = {},
+  expoTailscale = false,
+} = {}) {
+  const wantWeb = Boolean(startUi);
+  const wantDevClient = Boolean(startMobile);
+  if (!wantWeb && !wantDevClient) {
+    return { ok: true, skipped: true, reason: 'disabled' };
+  }
+
+  const env = { ...(baseEnv || process.env) };
+  delete env.CI;
+  // Expo app config: this is what both web + native app use to reach the Happy server.
+  // When dev-client is enabled, `localhost` / `*.localhost` are not reachable from the phone,
+  // so rewrite to LAN IP here (centralized) to avoid relying on call sites.
+  const serverPortFromEnvRaw = (env.HAPPY_STACKS_SERVER_PORT ?? env.HAPPY_LOCAL_SERVER_PORT ?? '').toString().trim();
+  const serverPortFromEnv = serverPortFromEnvRaw ? Number(serverPortFromEnvRaw) : null;
+  const effectiveApiServerUrl = wantDevClient
+    ? resolveMobileReachableServerUrl({
+        env,
+        serverUrl: apiServerUrl,
+        serverPort: Number.isFinite(serverPortFromEnv) ? serverPortFromEnv : null,
+      })
+    : apiServerUrl;
+  env.EXPO_PUBLIC_HAPPY_SERVER_URL = effectiveApiServerUrl;
+  env.EXPO_PUBLIC_DEBUG = env.EXPO_PUBLIC_DEBUG ?? '1';
+
+  // Optional: allow per-stack storage isolation inside a single dev-client build by
+  // scoping app persistence (MMKV / SecureStore) to a stack-specific namespace.
+  //
+  // This stays upstream-safe because the app behavior is unchanged unless the Expo public
+  // env var is explicitly set. Happy Stacks sets it automatically for stack-mode dev-client.
+  if (wantDevClient) {
+    const explicitScope = (
+      env.HAPPY_STACKS_STORAGE_SCOPE ??
+      env.HAPPY_LOCAL_STORAGE_SCOPE ??
+      env.EXPO_PUBLIC_HAPPY_STORAGE_SCOPE ??
+      ''
+    )
+      .toString()
+      .trim();
+    const defaultScope = stackMode && stackName ? String(stackName).trim() : '';
+    const scope = explicitScope || defaultScope;
+    if (scope && !env.EXPO_PUBLIC_HAPPY_STORAGE_SCOPE) {
+      env.EXPO_PUBLIC_HAPPY_STORAGE_SCOPE = scope;
+    }
+  }
+
+  // We own the browser opening behavior in Happy Stacks so we can reliably open the correct origin.
+  env.EXPO_NO_BROWSER = '1';
+  env.BROWSER = 'none';
+
+  // Mobile config is needed for `--scheme` and for the app's environment.
+  let scheme = '';
+  if (wantDevClient) {
+    const cfg = resolveMobileExpoConfig({ env });
+    env.APP_ENV = cfg.appEnv;
+    scheme = cfg.scheme;
+  }
+
+  const paths = getExpoStatePaths({
+    baseDir: autostart.baseDir,
+    kind: 'expo-dev',
+    projectDir: uiDir,
+    stateFileName: 'expo.state.json',
+  });
+  await ensureExpoIsolationEnv({ env, stateDir: paths.stateDir, expoHomeDir: paths.expoHomeDir, tmpDir: paths.tmpDir });
+
+  const running = await isStateProcessRunning(paths.statePath);
+  const alreadyRunning = Boolean(running.running);
+
+  // Resolve Tailscale forwarding preference
+  const wantTailscale = resolveExpoTailscaleEnabled({ env: baseEnv, expoTailscale });
+
+  // Always publish runtime metadata when we can.
+  const publishRuntime = async ({ pid, port, tailscaleForwarderPid = null, tailscaleIp = null }) => {
+    if (!stackMode || !runtimeStatePath) return;
+    const nPid = Number(pid);
+    const nPort = Number(port);
+    const nTsPid = Number(tailscaleForwarderPid);
+    await recordStackRuntimeUpdate(runtimeStatePath, {
+      processes: {
+        expoPid: Number.isFinite(nPid) && nPid > 1 ? nPid : null,
+        expoTailscaleForwarderPid: Number.isFinite(nTsPid) && nTsPid > 1 ? nTsPid : null,
+      },
+      expo: {
+        port: Number.isFinite(nPort) && nPort > 0 ? nPort : null,
+        // For now keep these populated for callers that still expect webPort/mobilePort.
+        webPort: wantWeb && Number.isFinite(nPort) && nPort > 0 ? nPort : null,
+        mobilePort: wantDevClient && Number.isFinite(nPort) && nPort > 0 ? nPort : null,
+        webEnabled: wantWeb,
+        devClientEnabled: wantDevClient,
+        host: resolveExpoDevHost({ env }),
+        scheme: wantDevClient ? scheme : null,
+        tailscaleEnabled: wantTailscale,
+        tailscaleIp: tailscaleIp ?? null,
+      },
+    }).catch(() => {});
+  };
+
+  if (alreadyRunning && !restart) {
+    const pid = Number(running.state?.pid);
+    const port = Number(running.state?.port);
+
+    // Capability check: refuse to spawn a second Expo, so if the existing process doesn't match the
+    // requested capabilities we fail closed and instruct a restart with the superset.
+    const stateWeb = Boolean(running.state?.webEnabled);
+    const stateDevClient = Boolean(running.state?.devClientEnabled);
+    const stateHasCaps = 'webEnabled' in (running.state ?? {}) || 'devClientEnabled' in (running.state ?? {});
+    const missingWeb = wantWeb && stateHasCaps && !stateWeb;
+    const missingDevClient = wantDevClient && stateHasCaps && !stateDevClient;
+    if (missingWeb || missingDevClient) {
+      throw new Error(
+        `[expo] Expo already running for stack=${stackName}, but it does not match the requested mode.\n` +
+          `- running: ${expoModeLabel({ wantWeb: stateWeb, wantDevClient: stateDevClient })}\n` +
+          `- wanted:  ${expoModeLabel({ wantWeb, wantDevClient })}\n` +
+          `Fix: re-run with --restart (and include --mobile if you need dev-client).`
+      );
+    }
+
+    await publishRuntime({ pid, port });
+    return {
+      ok: true,
+      skipped: true,
+      reason: 'already_running',
+      pid: Number.isFinite(pid) ? pid : null,
+      port: Number.isFinite(port) ? port : null,
+      mode: expoModeLabel({ wantWeb, wantDevClient }),
+    };
+  }
+
+  const metroPort = await pickExpoDevMetroPort({ env: baseEnv, stackMode, stackName });
+  env.RCT_METRO_PORT = String(metroPort);
+  const host = resolveExpoDevHost({ env });
+  const args = buildExpoStartArgs({
+    port: metroPort,
+    host,
+    wantWeb,
+    wantDevClient,
+    scheme,
+    clearCache: wantsExpoClearCache({ env: baseEnv || process.env }),
+  });
+
+  if (restart && running.state?.pid) {
+    const prevPid = Number(running.state.pid);
+    const res = await killProcessGroupOwnedByStack(prevPid, { stackName, envPath, label: 'expo', json: true });
+    if (!res.killed) {
+      // eslint-disable-next-line no-console
+      console.warn(
+        `[local] expo: not stopping existing Expo pid=${prevPid} because it does not look stack-owned.\n` +
+          `[local] expo: continuing by starting a new Expo process on a free port.`
+      );
+    }
+  }
+
+  // eslint-disable-next-line no-console
+  console.log(`[local] expo: starting Expo (${expoModeLabel({ wantWeb, wantDevClient })}, metro port=${metroPort}, host=${host})`);
+  const proc = await expoSpawn({ label: 'expo', dir: uiDir, args, env, options: spawnOptions });
+  children.push(proc);
+
+  // Start Tailscale forwarder if enabled
+  let tailscaleResult = null;
+  if (wantTailscale) {
+    tailscaleResult = await startExpoTailscaleForwarder({
+      metroPort,
+      baseEnv,
+      stackName,
+      children,
+    });
+    if (!tailscaleResult.ok) {
+      // eslint-disable-next-line no-console
+      console.warn(`[local] expo: Tailscale forwarder not started: ${tailscaleResult.error}`);
+    }
+  }
+
+  await publishRuntime({
+    pid: proc.pid,
+    port: metroPort,
+    tailscaleForwarderPid: tailscaleResult?.pid ?? null,
+    tailscaleIp: tailscaleResult?.tailscaleIp ?? null,
+  });
+
+  try {
+    await writePidState(paths.statePath, {
+      pid: proc.pid,
+      port: metroPort,
+      uiDir,
+      startedAt: new Date().toISOString(),
+      webEnabled: wantWeb,
+      devClientEnabled: wantDevClient,
+      host,
+      scheme: wantDevClient ? scheme : null,
+      tailscaleEnabled: wantTailscale,
+      tailscaleForwarderPid: tailscaleResult?.pid ?? null,
+      tailscaleIp: tailscaleResult?.tailscaleIp ?? null,
+    });
+  } catch {
+    // ignore
+  }
+
+  return {
+    ok: true,
+    skipped: false,
+    pid: proc.pid,
+    port: metroPort,
+    proc,
+    mode: expoModeLabel({ wantWeb, wantDevClient }),
+    tailscale: tailscaleResult ?? null,
+  };
+}
+

package/scripts/utils/dev/expo_dev.test.mjs

@@ -0,0 +1,76 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+
+import { buildExpoStartArgs, resolveExpoDevHost } from './expo_dev.mjs';
+
+test('resolveExpoDevHost defaults to lan and normalizes values', () => {
+  assert.equal(resolveExpoDevHost({ env: {} }), 'lan');
+  assert.equal(resolveExpoDevHost({ env: { HAPPY_STACKS_EXPO_HOST: 'LAN' } }), 'lan');
+  assert.equal(resolveExpoDevHost({ env: { HAPPY_STACKS_EXPO_HOST: 'localhost' } }), 'localhost');
+  assert.equal(resolveExpoDevHost({ env: { HAPPY_STACKS_EXPO_HOST: 'tunnel' } }), 'tunnel');
+  assert.equal(resolveExpoDevHost({ env: { HAPPY_STACKS_EXPO_HOST: 'nope' } }), 'lan');
+});
+
+test('buildExpoStartArgs builds dev-client args (preferred when mobile enabled)', () => {
+  const args = buildExpoStartArgs({
+    port: 8081,
+    host: 'lan',
+    wantWeb: true,
+    wantDevClient: true,
+    scheme: 'happy',
+    clearCache: true,
+  });
+  assert.deepEqual(args, ['start', '--dev-client', '--host', 'lan', '--port', '8081', '--scheme', 'happy', '--clear']);
+});
+
+test('buildExpoStartArgs builds web args when dev-client is not requested', () => {
+  const args = buildExpoStartArgs({
+    port: 8081,
+    host: 'lan',
+    wantWeb: true,
+    wantDevClient: false,
+    scheme: '',
+    clearCache: false,
+  });
+  assert.deepEqual(args, ['start', '--web', '--host', 'lan', '--port', '8081']);
+});
+
+test('buildExpoStartArgs omits --scheme when empty', () => {
+  const args = buildExpoStartArgs({
+    port: 8081,
+    host: 'lan',
+    wantWeb: false,
+    wantDevClient: true,
+    scheme: '',
+    clearCache: false,
+  });
+  assert.deepEqual(args, ['start', '--dev-client', '--host', 'lan', '--port', '8081']);
+});
+
+test('buildExpoStartArgs throws on invalid requests', () => {
+  assert.throws(
+    () =>
+      buildExpoStartArgs({
+        port: 0,
+        host: 'lan',
+        wantWeb: true,
+        wantDevClient: false,
+        scheme: '',
+        clearCache: false,
+      }),
+    /invalid Metro port/i
+  );
+  assert.throws(
+    () =>
+      buildExpoStartArgs({
+        port: 8081,
+        host: 'lan',
+        wantWeb: false,
+        wantDevClient: false,
+        scheme: '',
+        clearCache: false,
+      }),
+    /neither web nor dev-client requested/i
+  );
+});
+