happy-stacks 0.2.0 → 0.4.0

package/scripts/stop.mjs

@@ -1,11 +1,11 @@
-import './utils/env.mjs';
+import './utils/env/env.mjs';
 import { join } from 'node:path';
 import { existsSync } from 'node:fs';
 
 import { parseArgs } from './utils/cli/args.mjs';
 import { printResult, wantsHelp, wantsJson } from './utils/cli/cli.mjs';
-import { run, runCapture } from './utils/proc.mjs';
-import { getRootDir, resolveStackEnvPath } from './utils/paths.mjs';
+import { run, runCapture } from './utils/proc/proc.mjs';
+import { getRootDir, resolveStackEnvPath } from './utils/paths/paths.mjs';
 
 function usage() {
   return [

package/scripts/tailscale.mjs

@@ -1,8 +1,10 @@
-import './utils/env.mjs';
+import './utils/env/env.mjs';
 import { parseArgs } from './utils/cli/args.mjs';
-import { run, runCapture } from './utils/proc.mjs';
+import { run, runCapture } from './utils/proc/proc.mjs';
 import { printResult, wantsHelp, wantsJson } from './utils/cli/cli.mjs';
-import { isSandboxed, sandboxAllowsGlobalSideEffects } from './utils/sandbox.mjs';
+import { isSandboxed, sandboxAllowsGlobalSideEffects } from './utils/env/sandbox.mjs';
+import { getInternalServerUrl } from './utils/server/urls.mjs';
+import { resolveCommandPath } from './utils/proc/commands.mjs';
 import { constants } from 'node:fs';
 import { access } from 'node:fs/promises';
 
@@ -21,11 +23,6 @@ import { access } from 'node:fs/promises';
  * - url (print the first https:// URL from status output)
  */
 
-function getInternalServerUrl() {
-  const port = process.env.HAPPY_LOCAL_SERVER_PORT?.trim() ? Number(process.env.HAPPY_LOCAL_SERVER_PORT) : 3005;
-  return `http://127.0.0.1:${port}`;
-}
-
 function getServeConfig(internalServerUrl) {
   const upstream = process.env.HAPPY_LOCAL_TAILSCALE_UPSTREAM?.trim()
     ? process.env.HAPPY_LOCAL_TAILSCALE_UPSTREAM.trim()
@@ -43,7 +40,9 @@ function extractHttpsUrl(serveStatusText) {
     .find((l) => l.toLowerCase().includes('https://'));
   if (!line) return null;
   const m = line.match(/https:\/\/\S+/i);
-  return m ? m[0] : null;
+  if (!m) return null;
+  // Avoid trailing slash for base URLs (some consumers treat it as a path prefix).
+  return m[0].replace(/\/+$/, '');
 }
 
 function tailscaleStatusMatchesInternalServerUrl(status, internalServerUrl) {
@@ -83,6 +82,16 @@ function extractServeEnableUrl(text) {
   return m ? m[0] : null;
 }
 
+function assertTailscaleAllowed(action) {
+  if (isSandboxed() && !sandboxAllowsGlobalSideEffects()) {
+    throw new Error(
+      `[local] tailscale ${action} is disabled in sandbox mode.\n` +
+        `Reason: Tailscale Serve is global machine state and sandbox runs must be isolated.\n` +
+        `If you really want this, set: HAPPY_STACKS_SANDBOX_ALLOW_GLOBAL=1`
+    );
+  }
+}
+
 function parseTimeoutMs(raw, defaultMs) {
   const s = (raw ?? '').trim();
   if (!s) return defaultMs;
@@ -134,7 +143,7 @@ async function resolveTailscaleCmd() {
 
   // Try PATH first (without executing `tailscale`, which can hang in some environments).
   try {
-    const found = (await runCapture('sh', ['-lc', 'command -v tailscale 2>/dev/null || true'], { env: tailscaleEnv(), timeoutMs: tailscaleProbeTimeoutMs() })).trim();
+    const found = await resolveCommandPath('tailscale', { env: tailscaleEnv(), timeoutMs: tailscaleProbeTimeoutMs() });
     if (found) {
       return found;
     }
@@ -176,11 +185,13 @@ export async function tailscaleServeHttpsUrl() {
 }
 
 export async function tailscaleServeStatus() {
+  assertTailscaleAllowed('status');
   const cmd = await resolveTailscaleCmd();
   return await runCapture(cmd, ['serve', 'status'], { env: tailscaleEnv(), timeoutMs: tailscaleProbeTimeoutMs() });
 }
 
 export async function tailscaleServeEnable({ internalServerUrl, timeoutMs } = {}) {
+  assertTailscaleAllowed('enable');
   const cmd = await resolveTailscaleCmd();
   const { upstream, servePath } = getServeConfig(internalServerUrl);
   const args = ['serve', '--bg'];
@@ -218,12 +229,16 @@ export async function tailscaleServeEnable({ internalServerUrl, timeoutMs } = {}
 }
 
 export async function tailscaleServeReset({ timeoutMs } = {}) {
+  assertTailscaleAllowed('reset');
   const cmd = await resolveTailscaleCmd();
   const timeout = Number.isFinite(timeoutMs) ? (timeoutMs > 0 ? timeoutMs : 0) : tailscaleUserResetTimeoutMs();
   await run(cmd, ['serve', 'reset'], { env: tailscaleEnv(), timeoutMs: timeout });
 }
 
 export async function maybeEnableTailscaleServe({ internalServerUrl }) {
+  if (isSandboxed() && !sandboxAllowsGlobalSideEffects()) {
+    return null;
+  }
   const enabled = (process.env.HAPPY_LOCAL_TAILSCALE_SERVE ?? '0') === '1';
   if (!enabled) {
     return null;
@@ -237,6 +252,9 @@ export async function maybeEnableTailscaleServe({ internalServerUrl }) {
 }
 
 export async function maybeResetTailscaleServe() {
+  if (isSandboxed() && !sandboxAllowsGlobalSideEffects()) {
+    return;
+  }
   const enabled = (process.env.HAPPY_LOCAL_TAILSCALE_SERVE ?? '0') === '1';
   const resetOnExit = (process.env.HAPPY_LOCAL_TAILSCALE_RESET_ON_EXIT ?? '0') === '1';
   if (!enabled || !resetOnExit) {
@@ -269,6 +287,7 @@ export async function resolvePublicServerUrl({
   defaultPublicUrl,
   envPublicUrl,
   allowEnable = true,
+  stackName = 'main',
 }) {
   const preferTailscalePublicUrl = (process.env.HAPPY_LOCAL_TAILSCALE_PREFER_PUBLIC_URL ?? '1') !== '0';
   const userExplicitlySetPublicUrl =
@@ -278,6 +297,20 @@ export async function resolvePublicServerUrl({
     return { publicServerUrl: envPublicUrl || defaultPublicUrl, source: 'env' };
   }
 
+  // Non-main stacks:
+  // - Never auto-enable (global machine state) by default.
+  // - If the caller explicitly allows it AND Tailscale Serve is already configured for this stack's
+  //   internal URL, prefer the HTTPS URL (safe: status must match the internal URL).
+  if (stackName && stackName !== 'main') {
+    if (allowEnable) {
+      const existing = await tailscaleServeHttpsUrlForInternalServerUrl(internalServerUrl);
+      if (existing) {
+        return { publicServerUrl: existing, source: 'tailscale-status' };
+      }
+    }
+    return { publicServerUrl: envPublicUrl || defaultPublicUrl, source: envPublicUrl ? 'env' : 'default' };
+  }
+
   // If serve is already configured, use its HTTPS URL if present.
   const existing = await tailscaleServeHttpsUrlForInternalServerUrl(internalServerUrl);
   if (existing) {
@@ -342,7 +375,7 @@ async function main() {
     return;
   }
 
-  const internalServerUrl = getInternalServerUrl();
+  const internalServerUrl = getInternalServerUrl({ env: process.env, defaultPort: 3005 }).internalServerUrl;
   if (flags.has('--upstream') || kv.get('--upstream')) {
     process.env.HAPPY_LOCAL_TAILSCALE_UPSTREAM = kv.get('--upstream') ?? internalServerUrl;
   }

package/scripts/test.mjs

@@ -1,36 +1,18 @@
-import './utils/env.mjs';
+import './utils/env/env.mjs';
 import { parseArgs } from './utils/cli/args.mjs';
 import { printResult, wantsHelp, wantsJson } from './utils/cli/cli.mjs';
-import { getComponentDir, getRootDir } from './utils/paths.mjs';
-import { ensureDepsInstalled, requirePnpm } from './utils/pm.mjs';
-import { pathExists } from './utils/fs.mjs';
-import { run } from './utils/proc.mjs';
-import { join } from 'node:path';
-import { readFile } from 'node:fs/promises';
+import { componentDirEnvKey, getComponentDir, getRootDir } from './utils/paths/paths.mjs';
+import { ensureDepsInstalled } from './utils/proc/pm.mjs';
+import { pathExists } from './utils/fs/fs.mjs';
+import { run } from './utils/proc/proc.mjs';
+import { detectPackageManagerCmd, pickFirstScript, readPackageJsonScripts } from './utils/proc/package_scripts.mjs';
+import { getInvokedCwd, inferComponentFromCwd } from './utils/cli/cwd_scope.mjs';
 
 const DEFAULT_COMPONENTS = ['happy', 'happy-cli', 'happy-server-light', 'happy-server'];
-
-async function detectPackageManagerCmd(dir) {
-  if (await pathExists(join(dir, 'yarn.lock'))) {
-    return { name: 'yarn', cmd: 'yarn', argsForScript: (script) => ['-s', script] };
-  }
-  await requirePnpm();
-  return { name: 'pnpm', cmd: 'pnpm', argsForScript: (script) => ['--silent', script] };
-}
-
-async function readScripts(dir) {
-  try {
-    const raw = await readFile(join(dir, 'package.json'), 'utf-8');
-    const pkg = JSON.parse(raw);
-    const scripts = pkg?.scripts && typeof pkg.scripts === 'object' ? pkg.scripts : {};
-    return scripts;
-  } catch {
-    return null;
-  }
-}
+const EXTRA_COMPONENTS = ['stacks'];
+const VALID_COMPONENTS = [...DEFAULT_COMPONENTS, ...EXTRA_COMPONENTS];
 
 function pickTestScript(scripts) {
-  if (!scripts) return null;
   const candidates = [
     'test',
     'tst',
@@ -38,7 +20,7 @@ function pickTestScript(scripts) {
     'test:unit',
     'check:test',
   ];
-  return candidates.find((k) => typeof scripts[k] === 'string' && scripts[k].trim()) ?? null;
+  return pickFirstScript(scripts, candidates);
 }
 
 async function main() {
@@ -49,33 +31,67 @@ async function main() {
   if (wantsHelp(argv, { flags })) {
     printResult({
       json,
-      data: { components: DEFAULT_COMPONENTS, flags: ['--json'] },
+      data: { components: VALID_COMPONENTS, flags: ['--json'] },
       text: [
         '[test] usage:',
         '  happys test [component...] [--json]',
         '',
         'components:',
-        `  ${DEFAULT_COMPONENTS.join(' | ')}`,
+        `  ${VALID_COMPONENTS.join(' | ')}`,
         '',
         'examples:',
         '  happys test',
+        '  happys test stacks',
         '  happys test happy happy-cli',
+        '',
+        'note:',
+        '  If run from inside a component checkout/worktree and no components are provided, defaults to that component.',
       ].join('\n'),
     });
     return;
   }
 
+  const rootDir = getRootDir(import.meta.url);
+
   const positionals = argv.filter((a) => !a.startsWith('--'));
-  const requested = positionals.length ? positionals : ['all'];
+  const inferred =
+    positionals.length === 0
+      ? inferComponentFromCwd({
+          rootDir,
+          invokedCwd: getInvokedCwd(process.env),
+          components: DEFAULT_COMPONENTS,
+        })
+      : null;
+  if (inferred) {
+    const stacksKey = componentDirEnvKey(inferred.component);
+    const legacyKey = stacksKey.replace(/^HAPPY_STACKS_/, 'HAPPY_LOCAL_');
+    if (!(process.env[stacksKey] ?? '').toString().trim() && !(process.env[legacyKey] ?? '').toString().trim()) {
+      process.env[stacksKey] = inferred.repoDir;
+    }
+  }
+
+  const requested = positionals.length ? positionals : inferred ? [inferred.component] : ['all'];
   const wantAll = requested.includes('all');
+  // Default `all` excludes "stacks" to avoid coupling to component repos and their test baselines.
   const components = wantAll ? DEFAULT_COMPONENTS : requested;
 
-  const rootDir = getRootDir(import.meta.url);
-
   const results = [];
   for (const component of components) {
-    if (!DEFAULT_COMPONENTS.includes(component)) {
-      results.push({ component, ok: false, skipped: false, error: `unknown component (expected one of: ${DEFAULT_COMPONENTS.join(', ')})` });
+    if (!VALID_COMPONENTS.includes(component)) {
+      results.push({ component, ok: false, skipped: false, error: `unknown component (expected one of: ${VALID_COMPONENTS.join(', ')})` });
+      continue;
+    }
+
+    if (component === 'stacks') {
+      try {
+        // eslint-disable-next-line no-console
+        console.log('[test] stacks: running node --test (happy-stacks unit tests)');
+        // Restrict to explicit *.test.mjs files to avoid accidentally executing scripts/test.mjs.
+        await run('sh', ['-lc', 'node --test "scripts/**/*.test.mjs"'], { cwd: rootDir, env: process.env });
+        results.push({ component, ok: true, skipped: false, dir: rootDir, pm: 'node', script: '--test' });
+      } catch (e) {
+        results.push({ component, ok: false, skipped: false, dir: rootDir, pm: 'node', script: '--test', error: String(e?.message ?? e) });
+      }
       continue;
     }
 
@@ -85,7 +101,7 @@ async function main() {
       continue;
     }
 
-    const scripts = await readScripts(dir);
+    const scripts = await readPackageJsonScripts(dir);
     if (!scripts) {
       results.push({ component, ok: true, skipped: true, dir, reason: 'no package.json' });
       continue;