handsontable 14.0.0-next-bdc44e7-20231115 → 14.0.0-next-0a2e56a-20231116

package/editors/textEditor/textEditor.js

@@ -388,6 +388,7 @@ class TextEditor extends _baseEditor.BaseEditor {
   registerShortcuts() {
     const shortcutManager = this.hot.getShortcutManager();
     const editorContext = shortcutManager.getContext('editor');
+    const gridContext = shortcutManager.getContext('grid');
     const contextConfig = {
       runOnlyIf: () => (0, _mixed.isDefined)(this.hot.getSelected()),
       group: SHORTCUTS_GROUP
@@ -396,21 +397,9 @@ class TextEditor extends _baseEditor.BaseEditor {
       this.hot.rootDocument.execCommand('insertText', false, '\n');
     };
     editorContext.addShortcuts([{
-      keys: [['Tab']],
-      // TODO: Duplicated part of code (callback to shortcut).
-      callback: event => {
-        const tableMeta = this.hot.getSettings();
-        const tabMoves = typeof tableMeta.tabMoves === 'function' ? tableMeta.tabMoves(event) : tableMeta.tabMoves;
-        this.hot.selection.transformStart(tabMoves.row, tabMoves.col, true);
-      }
-    }, {
-      keys: [['Shift', 'Tab']],
-      // TODO: Duplicated part of code (callback to shortcut).
-      callback: event => {
-        const tableMeta = this.hot.getSettings();
-        const tabMoves = typeof tableMeta.tabMoves === 'function' ? tableMeta.tabMoves(event) : tableMeta.tabMoves;
-        this.hot.selection.transformStart(-tabMoves.row, -tabMoves.col);
-      }
+      keys: [['Tab'], ['Shift', 'Tab'], ['PageUp'], ['PageDown']],
+      forwardToContext: gridContext,
+      callback: () => {}
     }, {
       keys: [['Control', 'Enter']],
       callback: () => {
@@ -436,18 +425,6 @@ class TextEditor extends _baseEditor.BaseEditor {
         insertNewLine();
         return false; // Will block closing editor.
       }
-    }, {
-      // TODO: Duplicated part of code (callback to shortcut)
-      keys: [['PageUp']],
-      callback: () => {
-        this.hot.selection.transformStart(-this.hot.countVisibleRows(), 0);
-      }
-    }, {
-      // TODO: Duplicated part of code (callback to shortcut)
-      keys: [['PageDown']],
-      callback: () => {
-        this.hot.selection.transformStart(this.hot.countVisibleRows(), 0);
-      }
     }, {
       keys: [['Home']],
       callback: (event, _ref) => {

package/editors/textEditor/textEditor.mjs

@@ -384,6 +384,7 @@ export class TextEditor extends BaseEditor {
   registerShortcuts() {
     const shortcutManager = this.hot.getShortcutManager();
     const editorContext = shortcutManager.getContext('editor');
+    const gridContext = shortcutManager.getContext('grid');
     const contextConfig = {
       runOnlyIf: () => isDefined(this.hot.getSelected()),
       group: SHORTCUTS_GROUP
@@ -392,21 +393,9 @@ export class TextEditor extends BaseEditor {
       this.hot.rootDocument.execCommand('insertText', false, '\n');
     };
     editorContext.addShortcuts([{
-      keys: [['Tab']],
-      // TODO: Duplicated part of code (callback to shortcut).
-      callback: event => {
-        const tableMeta = this.hot.getSettings();
-        const tabMoves = typeof tableMeta.tabMoves === 'function' ? tableMeta.tabMoves(event) : tableMeta.tabMoves;
-        this.hot.selection.transformStart(tabMoves.row, tabMoves.col, true);
-      }
-    }, {
-      keys: [['Shift', 'Tab']],
-      // TODO: Duplicated part of code (callback to shortcut).
-      callback: event => {
-        const tableMeta = this.hot.getSettings();
-        const tabMoves = typeof tableMeta.tabMoves === 'function' ? tableMeta.tabMoves(event) : tableMeta.tabMoves;
-        this.hot.selection.transformStart(-tabMoves.row, -tabMoves.col);
-      }
+      keys: [['Tab'], ['Shift', 'Tab'], ['PageUp'], ['PageDown']],
+      forwardToContext: gridContext,
+      callback: () => {}
     }, {
       keys: [['Control', 'Enter']],
       callback: () => {
@@ -432,18 +421,6 @@ export class TextEditor extends BaseEditor {
         insertNewLine();
         return false; // Will block closing editor.
       }
-    }, {
-      // TODO: Duplicated part of code (callback to shortcut)
-      keys: [['PageUp']],
-      callback: () => {
-        this.hot.selection.transformStart(-this.hot.countVisibleRows(), 0);
-      }
-    }, {
-      // TODO: Duplicated part of code (callback to shortcut)
-      keys: [['PageDown']],
-      callback: () => {
-        this.hot.selection.transformStart(this.hot.countVisibleRows(), 0);
-      }
     }, {
       keys: [['Home']],
       callback: (event, _ref) => {

package/helpers/mixed.js

@@ -134,7 +134,7 @@ const domMessages = {
 function _injectProductInfo(key, element) {
   const hasValidType = !isEmpty(key);
   const isNonCommercial = typeof key === 'string' && key.toLowerCase() === 'non-commercial-and-evaluation';
-  const hotVersion = "14.0.0-next-bdc44e7-20231115";
+  const hotVersion = "14.0.0-next-0a2e56a-20231116";
   let keyValidityDate;
   let consoleMessageState = 'invalid';
   let domMessageState = 'invalid';

package/helpers/mixed.mjs

@@ -124,7 +124,7 @@ const domMessages = {
 export function _injectProductInfo(key, element) {
   const hasValidType = !isEmpty(key);
   const isNonCommercial = typeof key === 'string' && key.toLowerCase() === 'non-commercial-and-evaluation';
-  const hotVersion = "14.0.0-next-bdc44e7-20231115";
+  const hotVersion = "14.0.0-next-0a2e56a-20231116";
   let keyValidityDate;
   let consoleMessageState = 'invalid';
   let domMessageState = 'invalid';

package/package.json

@@ -10,7 +10,7 @@
     "url": "https://github.com/handsontable/handsontable/issues"
   },
   "author": "Handsoncode <hello@handsontable.com>",
-  "version": "14.0.0-next-bdc44e7-20231115",
+  "version": "14.0.0-next-0a2e56a-20231116",
   "main": "index",
   "module": "index.mjs",
   "jsnext:main": "index.mjs",

package/pluginHooks.d.ts

@@ -166,7 +166,7 @@ export interface Events {
   beforeColumnMove?: (movedColumns: number[], finalIndex: number, dropIndex: number | undefined, movePossible: boolean) => void | boolean;
   beforeColumnResize?: (newSize: number, column: number, isDoubleClick: boolean) => void | number;
   beforeColumnSort?: (currentSortConfig: ColumnSortingConfig[], destinationSortConfigs: ColumnSortingConfig[]) => void | boolean;
-  beforeColumnWrap?: (isAutoWrapEnabled: boolean, newCoords: CellCoords, isColumnFlipped: boolean) => void;
+  beforeColumnWrap?: (isActionInterrupted: { value: boolean }, newCoords: CellCoords, isColumnFlipped: boolean) => void;
   beforeColumnUnfreeze?: (columnIndex: number, isUnfreezingPerformed: boolean) => void | boolean;
   beforeContextMenuSetItems?: (menuItems: ContextMenuMenuItemConfig[]) => void;
   beforeContextMenuShow?: (context: ContextMenu) => void;
@@ -207,7 +207,7 @@ export interface Events {
   beforeRenderer?: (TD: HTMLTableCellElement, row: number, column: number, prop: string | number, value: CellValue, cellProperties: CellProperties) => void;
   beforeRowMove?: (movedRows: number[], finalIndex: number, dropIndex: number | undefined, movePossible: boolean) => void;
   beforeRowResize?: (newSize: number, row: number, isDoubleClick: boolean) => number | void;
-  beforeRowWrap?: (isAutoWrapEnabled: boolean, newCoords: CellCoords, isRowFlipped: boolean) => void;
+  beforeRowWrap?: (isActionInterrupted: { value: boolean }, newCoords: CellCoords, isRowFlipped: boolean) => void;
   beforeSelectColumns?: (from: CellCoords, to: CellCoords, highlight: CellCoords) => void;
   beforeSelectionHighlightSet?: () => void;
   beforeSelectRows?: (from: CellCoords, to: CellCoords, highlight: CellCoords) => void;

package/selection/transformation.js

@@ -147,39 +147,39 @@ class Transformation {
       const autoWrapCol = _classPrivateFieldGet(this, _options).autoWrapCol();
       const zeroBasedCoords = _classPrivateFieldGet(this, _options).createCellCoords(row + delta.row, col + delta.col);
       if (zeroBasedCoords.row >= height) {
-        const autoInsertingMode = createMissingRecords && minSpareRows > 0 && fixedRowsBottom === 0;
-        const isWrapEnabled = !autoInsertingMode && autoWrapCol;
+        const isActionInterrupted = (0, _object.createObjectPropListener)(createMissingRecords && minSpareRows > 0 && fixedRowsBottom === 0);
         const nextColumn = zeroBasedCoords.col + 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(zeroBasedCoords.row - height, nextColumn >= width ? nextColumn - width : nextColumn);
-        this.runLocalHooks('beforeColumnWrap', isWrapEnabled, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextColumn >= width);
-        if (autoInsertingMode) {
+        this.runLocalHooks('beforeColumnWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextColumn >= width);
+        if (isActionInterrupted.value) {
           this.runLocalHooks('insertRowRequire', _classPrivateFieldGet(this, _options).countRenderableRows());
-        } else if (isWrapEnabled) {
+        } else if (autoWrapCol) {
           zeroBasedCoords.assign(newCoords);
         }
       } else if (zeroBasedCoords.row < 0) {
+        const isActionInterrupted = (0, _object.createObjectPropListener)(autoWrapCol);
         const previousColumn = zeroBasedCoords.col - 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(height + zeroBasedCoords.row, previousColumn < 0 ? width + previousColumn : previousColumn);
-        this.runLocalHooks('beforeColumnWrap', autoWrapCol, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousColumn < 0);
+        this.runLocalHooks('beforeColumnWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousColumn < 0);
         if (autoWrapCol) {
           zeroBasedCoords.assign(newCoords);
         }
       }
       if (zeroBasedCoords.col >= width) {
-        const autoInsertingMode = createMissingRecords && minSpareCols > 0;
-        const isWrapEnabled = !autoInsertingMode && autoWrapRow;
+        const isActionInterrupted = (0, _object.createObjectPropListener)(createMissingRecords && minSpareCols > 0);
         const nextRow = zeroBasedCoords.row + 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(nextRow >= height ? nextRow - height : nextRow, zeroBasedCoords.col - width);
-        this.runLocalHooks('beforeRowWrap', isWrapEnabled, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextRow >= height);
-        if (autoInsertingMode) {
+        this.runLocalHooks('beforeRowWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextRow >= height);
+        if (isActionInterrupted.value) {
           this.runLocalHooks('insertColRequire', _classPrivateFieldGet(this, _options).countRenderableColumns());
-        } else if (isWrapEnabled) {
+        } else if (autoWrapRow) {
           zeroBasedCoords.assign(newCoords);
         }
       } else if (zeroBasedCoords.col < 0) {
+        const isActionInterrupted = (0, _object.createObjectPropListener)(autoWrapRow);
         const previousRow = zeroBasedCoords.row - 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(previousRow < 0 ? height + previousRow : previousRow, width + zeroBasedCoords.col);
-        this.runLocalHooks('beforeRowWrap', autoWrapRow, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousRow < 0);
+        this.runLocalHooks('beforeRowWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousRow < 0);
         if (autoWrapRow) {
           zeroBasedCoords.assign(newCoords);
         }

package/selection/transformation.mjs

@@ -8,7 +8,7 @@ function _classPrivateMethodGet(receiver, privateSet, fn) { if (!privateSet.has(
 function _classPrivateFieldSet(receiver, privateMap, value) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "set"); _classApplyDescriptorSet(receiver, descriptor, value); return value; }
 function _classExtractFieldDescriptor(receiver, privateMap, action) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to " + action + " private field on non-instance"); } return privateMap.get(receiver); }
 function _classApplyDescriptorSet(receiver, descriptor, value) { if (descriptor.set) { descriptor.set.call(receiver, value); } else { if (!descriptor.writable) { throw new TypeError("attempted to set read only private field"); } descriptor.value = value; } }
-import { mixin } from "../helpers/object.mjs";
+import { mixin, createObjectPropListener } from "../helpers/object.mjs";
 import localHooks from "./../mixins/localHooks.mjs";
 /**
  * The Transformation class implements algorithms for transforming coordinates based on current settings
@@ -143,39 +143,39 @@ class Transformation {
       const autoWrapCol = _classPrivateFieldGet(this, _options).autoWrapCol();
       const zeroBasedCoords = _classPrivateFieldGet(this, _options).createCellCoords(row + delta.row, col + delta.col);
       if (zeroBasedCoords.row >= height) {
-        const autoInsertingMode = createMissingRecords && minSpareRows > 0 && fixedRowsBottom === 0;
-        const isWrapEnabled = !autoInsertingMode && autoWrapCol;
+        const isActionInterrupted = createObjectPropListener(createMissingRecords && minSpareRows > 0 && fixedRowsBottom === 0);
         const nextColumn = zeroBasedCoords.col + 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(zeroBasedCoords.row - height, nextColumn >= width ? nextColumn - width : nextColumn);
-        this.runLocalHooks('beforeColumnWrap', isWrapEnabled, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextColumn >= width);
-        if (autoInsertingMode) {
+        this.runLocalHooks('beforeColumnWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextColumn >= width);
+        if (isActionInterrupted.value) {
           this.runLocalHooks('insertRowRequire', _classPrivateFieldGet(this, _options).countRenderableRows());
-        } else if (isWrapEnabled) {
+        } else if (autoWrapCol) {
           zeroBasedCoords.assign(newCoords);
         }
       } else if (zeroBasedCoords.row < 0) {
+        const isActionInterrupted = createObjectPropListener(autoWrapCol);
         const previousColumn = zeroBasedCoords.col - 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(height + zeroBasedCoords.row, previousColumn < 0 ? width + previousColumn : previousColumn);
-        this.runLocalHooks('beforeColumnWrap', autoWrapCol, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousColumn < 0);
+        this.runLocalHooks('beforeColumnWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousColumn < 0);
         if (autoWrapCol) {
           zeroBasedCoords.assign(newCoords);
         }
       }
       if (zeroBasedCoords.col >= width) {
-        const autoInsertingMode = createMissingRecords && minSpareCols > 0;
-        const isWrapEnabled = !autoInsertingMode && autoWrapRow;
+        const isActionInterrupted = createObjectPropListener(createMissingRecords && minSpareCols > 0);
         const nextRow = zeroBasedCoords.row + 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(nextRow >= height ? nextRow - height : nextRow, zeroBasedCoords.col - width);
-        this.runLocalHooks('beforeRowWrap', isWrapEnabled, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextRow >= height);
-        if (autoInsertingMode) {
+        this.runLocalHooks('beforeRowWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), nextRow >= height);
+        if (isActionInterrupted.value) {
           this.runLocalHooks('insertColRequire', _classPrivateFieldGet(this, _options).countRenderableColumns());
-        } else if (isWrapEnabled) {
+        } else if (autoWrapRow) {
           zeroBasedCoords.assign(newCoords);
         }
       } else if (zeroBasedCoords.col < 0) {
+        const isActionInterrupted = createObjectPropListener(autoWrapRow);
         const previousRow = zeroBasedCoords.row - 1;
         const newCoords = _classPrivateFieldGet(this, _options).createCellCoords(previousRow < 0 ? height + previousRow : previousRow, width + zeroBasedCoords.col);
-        this.runLocalHooks('beforeRowWrap', autoWrapRow, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousRow < 0);
+        this.runLocalHooks('beforeRowWrap', isActionInterrupted, _classPrivateMethodGet(this, _zeroBasedToVisualCoords, _zeroBasedToVisualCoords2).call(this, newCoords), previousRow < 0);
         if (autoWrapRow) {
           zeroBasedCoords.assign(newCoords);
         }

package/shortcutContexts/commands/moveCellSelection/inlineStart.js

@@ -6,6 +6,6 @@ const command = exports.command = {
   callback(hot, event) {
     const settings = hot.getSettings();
     const tabMoves = typeof settings.tabMoves === 'function' ? settings.tabMoves(event) : settings.tabMoves;
-    hot.selection.transformStart(tabMoves.row, tabMoves.col, true);
+    hot.selection.transformStart(tabMoves.row, tabMoves.col);
   }
 };

package/shortcutContexts/commands/moveCellSelection/inlineStart.mjs

@@ -3,6 +3,6 @@ export const command = {
   callback(hot, event) {
     const settings = hot.getSettings();
     const tabMoves = typeof settings.tabMoves === 'function' ? settings.tabMoves(event) : settings.tabMoves;
-    hot.selection.transformStart(tabMoves.row, tabMoves.col, true);
+    hot.selection.transformStart(tabMoves.row, tabMoves.col);
   }
 };