handsontable 13.1.0 → 14.0.0-next-d97b156-20231027

package/plugins/customBorders/customBorders.js

@@ -11,14 +11,13 @@ var C = _interopRequireWildcard(require("../../i18n/constants"));
 var _contextMenuItem = require("./contextMenuItem");
 var _utils = require("./utils");
 var _selection = require("../../selection");
-function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function (nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
-function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 function _defineProperty(obj, key, value) { key = _toPropertyKey(key); if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 function _toPropertyKey(arg) { var key = _toPrimitive(arg, "string"); return typeof key === "symbol" ? key : String(key); }
 function _toPrimitive(input, hint) { if (typeof input !== "object" || input === null) return input; var prim = input[Symbol.toPrimitive]; if (prim !== undefined) { var res = prim.call(input, hint || "default"); if (typeof res !== "object") return res; throw new TypeError("@@toPrimitive must return a primitive value."); } return (hint === "string" ? String : Number)(input); }
-const PLUGIN_KEY = 'customBorders';
-exports.PLUGIN_KEY = PLUGIN_KEY;
-const PLUGIN_PRIORITY = 90;
+const PLUGIN_KEY = exports.PLUGIN_KEY = 'customBorders';
+const PLUGIN_PRIORITY = exports.PLUGIN_PRIORITY = 90;
 
 /* eslint-disable jsdoc/require-description-complete-sentence */
 
@@ -75,7 +74,6 @@ const PLUGIN_PRIORITY = 90;
  * ],
  * ```
  */
-exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
 class CustomBorders extends _base.BasePlugin {
   constructor() {
     super(...arguments);
@@ -167,14 +165,11 @@ class CustomBorders extends _base.BasePlugin {
     const selectionType = (0, _selection.detectSelectionType)(selectionRanges);
     const selectionSchemaNormalizer = (0, _selection.normalizeSelectionFactory)(selectionType);
     (0, _array.arrayEach)(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          (0, _array.arrayEach)(borderKeys, borderKey => {
-            this.prepareBorderFromCustomAdded(row, col, normBorder, (0, _utils.toInlinePropName)(borderKey));
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        (0, _array.arrayEach)(borderKeys, borderKey => {
+          this.prepareBorderFromCustomAdded(row, col, normBorder, (0, _utils.toInlinePropName)(borderKey));
+        });
+      });
     });
 
     /*
@@ -214,16 +209,13 @@ class CustomBorders extends _base.BasePlugin {
     const selectionSchemaNormalizer = (0, _selection.normalizeSelectionFactory)(selectionType);
     const selectedBorders = [];
     (0, _array.arrayEach)(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          (0, _array.arrayEach)(this.savedBorders, border => {
-            if (border.row === row && border.col === col) {
-              selectedBorders.push((0, _utils.denormalizeBorder)(border));
-            }
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        (0, _array.arrayEach)(this.savedBorders, border => {
+          if (border.row === row && border.col === col) {
+            selectedBorders.push((0, _utils.denormalizeBorder)(border));
+          }
+        });
+      });
     });
     return selectedBorders;
   }
@@ -614,7 +606,8 @@ class CustomBorders extends _base.BasePlugin {
     let check = false;
     (0, _array.arrayEach)(this.hot.selection.highlight.customSelections, customSelection => {
       if (border.id === customSelection.settings.id) {
-        (0, _object.objectEach)(customSelection.instanceBorders, borderObject => {
+        const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+        (0, _array.arrayEach)(borders, borderObject => {
           borderObject.toggleHiddenClass(place, remove); // TODO this also bad?
         });
 
@@ -648,7 +641,8 @@ class CustomBorders extends _base.BasePlugin {
           customSelection.visualCellRange = cellRange;
           customSelection.commit();
           if (place) {
-            (0, _object.objectEach)(customSelection.instanceBorders, borderObject => {
+            const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+            (0, _array.arrayEach)(borders, borderObject => {
               borderObject.changeBorderStyle(place, border);
             });
           }
@@ -716,6 +710,13 @@ class CustomBorders extends _base.BasePlugin {
         return this.getTranslatedPhrase(C.CONTEXTMENU_ITEMS_BORDERS);
       },
       disabled() {
+        const range = this.getSelectedRangeLast();
+        if (!range) {
+          return true;
+        }
+        if (range.isSingleHeader()) {
+          return true;
+        }
         return this.selection.isSelectedByCorner();
       },
       submenu: {

package/plugins/customBorders/customBorders.mjs

@@ -4,7 +4,7 @@ function _defineProperty(obj, key, value) { key = _toPropertyKey(key); if (key i
 function _toPropertyKey(arg) { var key = _toPrimitive(arg, "string"); return typeof key === "symbol" ? key : String(key); }
 function _toPrimitive(input, hint) { if (typeof input !== "object" || input === null) return input; var prim = input[Symbol.toPrimitive]; if (prim !== undefined) { var res = prim.call(input, hint || "default"); if (typeof res !== "object") return res; throw new TypeError("@@toPrimitive must return a primitive value."); } return (hint === "string" ? String : Number)(input); }
 import { BasePlugin } from "../base/index.mjs";
-import { hasOwnProperty, objectEach, deepClone } from "../../helpers/object.mjs";
+import { hasOwnProperty, deepClone } from "../../helpers/object.mjs";
 import { rangeEach } from "../../helpers/number.mjs";
 import { arrayEach, arrayReduce, arrayMap } from "../../helpers/array.mjs";
 import * as C from "../../i18n/constants.mjs";
@@ -160,14 +160,11 @@ export class CustomBorders extends BasePlugin {
     const selectionType = detectSelectionType(selectionRanges);
     const selectionSchemaNormalizer = normalizeSelectionFactory(selectionType);
     arrayEach(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          arrayEach(borderKeys, borderKey => {
-            this.prepareBorderFromCustomAdded(row, col, normBorder, toInlinePropName(borderKey));
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        arrayEach(borderKeys, borderKey => {
+          this.prepareBorderFromCustomAdded(row, col, normBorder, toInlinePropName(borderKey));
+        });
+      });
     });
 
     /*
@@ -207,16 +204,13 @@ export class CustomBorders extends BasePlugin {
     const selectionSchemaNormalizer = normalizeSelectionFactory(selectionType);
     const selectedBorders = [];
     arrayEach(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          arrayEach(this.savedBorders, border => {
-            if (border.row === row && border.col === col) {
-              selectedBorders.push(denormalizeBorder(border));
-            }
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        arrayEach(this.savedBorders, border => {
+          if (border.row === row && border.col === col) {
+            selectedBorders.push(denormalizeBorder(border));
+          }
+        });
+      });
     });
     return selectedBorders;
   }
@@ -607,7 +601,8 @@ export class CustomBorders extends BasePlugin {
     let check = false;
     arrayEach(this.hot.selection.highlight.customSelections, customSelection => {
       if (border.id === customSelection.settings.id) {
-        objectEach(customSelection.instanceBorders, borderObject => {
+        const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+        arrayEach(borders, borderObject => {
           borderObject.toggleHiddenClass(place, remove); // TODO this also bad?
         });
 
@@ -641,7 +636,8 @@ export class CustomBorders extends BasePlugin {
           customSelection.visualCellRange = cellRange;
           customSelection.commit();
           if (place) {
-            objectEach(customSelection.instanceBorders, borderObject => {
+            const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+            arrayEach(borders, borderObject => {
               borderObject.changeBorderStyle(place, border);
             });
           }
@@ -709,6 +705,13 @@ export class CustomBorders extends BasePlugin {
         return this.getTranslatedPhrase(C.CONTEXTMENU_ITEMS_BORDERS);
       },
       disabled() {
+        const range = this.getSelectedRangeLast();
+        if (!range) {
+          return true;
+        }
+        if (range.isSingleHeader()) {
+          return true;
+        }
         return this.selection.isSelectedByCorner();
       },
       submenu: {

package/plugins/dragToScroll/dragToScroll.js

@@ -6,9 +6,8 @@ var _eventManager = _interopRequireDefault(require("../../eventManager"));
 var _event = require("../../helpers/dom/event");
 var _element = require("../../helpers/dom/element");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-const PLUGIN_KEY = 'dragToScroll';
-exports.PLUGIN_KEY = PLUGIN_KEY;
-const PLUGIN_PRIORITY = 100;
+const PLUGIN_KEY = exports.PLUGIN_KEY = 'dragToScroll';
+const PLUGIN_PRIORITY = exports.PLUGIN_PRIORITY = 100;
 
 /* eslint-disable jsdoc/require-description-complete-sentence */
 
@@ -20,7 +19,6 @@ const PLUGIN_PRIORITY = 100;
  * @class DragToScroll
  * @plugin DragToScroll
  */
-exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
 class DragToScroll extends _base.BasePlugin {
   static get PLUGIN_KEY() {
     return PLUGIN_KEY;

package/plugins/dropdownMenu/dropdownMenu.d.ts

@@ -18,7 +18,7 @@ export class DropdownMenu extends BasePlugin {
 
   constructor(hotInstance: Core);
   isEnabled(): boolean;
-  open(event: Event): void;
+  open(position: { left: number, top: number } | Event, offset?: { above?: number, below?: number, left?: number, right?: number }): void;
   close(): void;
   executeCommand(commandName: string, ...params: any): void;
 }

package/plugins/dropdownMenu/dropdownMenu.js

@@ -1,26 +1,33 @@
 "use strict";
 
 exports.__esModule = true;
+require("core-js/modules/es.error.cause.js");
 var _base = require("../base");
 var _array = require("../../helpers/array");
-var _commandExecutor = _interopRequireDefault(require("../contextMenu/commandExecutor"));
+var _object = require("../../helpers/object");
+var _commandExecutor = require("../contextMenu/commandExecutor");
+var _utils = require("../contextMenu/utils");
 var _eventManager = _interopRequireDefault(require("../../eventManager"));
 var _element = require("../../helpers/dom/element");
-var _itemsFactory = _interopRequireDefault(require("../contextMenu/itemsFactory"));
-var _menu = _interopRequireDefault(require("../contextMenu/menu"));
+var _itemsFactory = require("../contextMenu/itemsFactory");
+var _menu = require("../contextMenu/menu");
 var _pluginHooks = _interopRequireDefault(require("../../pluginHooks"));
 var _predefinedItems = require("../contextMenu/predefinedItems");
+var _constants = require("../../i18n/constants");
+var _a11y = require("../../helpers/a11y");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+function _classPrivateMethodInitSpec(obj, privateSet) { _checkPrivateRedeclaration(obj, privateSet); privateSet.add(obj); }
+function _checkPrivateRedeclaration(obj, privateCollection) { if (privateCollection.has(obj)) { throw new TypeError("Cannot initialize the same private elements twice on an object"); } }
+function _classPrivateMethodGet(receiver, privateSet, fn) { if (!privateSet.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return fn; }
 _pluginHooks.default.getSingleton().register('afterDropdownMenuDefaultOptions');
 _pluginHooks.default.getSingleton().register('beforeDropdownMenuShow');
 _pluginHooks.default.getSingleton().register('afterDropdownMenuShow');
 _pluginHooks.default.getSingleton().register('afterDropdownMenuHide');
 _pluginHooks.default.getSingleton().register('afterDropdownMenuExecute');
-const PLUGIN_KEY = 'dropdownMenu';
-exports.PLUGIN_KEY = PLUGIN_KEY;
-const PLUGIN_PRIORITY = 230;
-exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
+const PLUGIN_KEY = exports.PLUGIN_KEY = 'dropdownMenu';
+const PLUGIN_PRIORITY = exports.PLUGIN_PRIORITY = 230;
 const BUTTON_CLASS_NAME = 'changeType';
+const SHORTCUTS_GROUP = PLUGIN_KEY;
 
 /* eslint-disable jsdoc/require-description-complete-sentence */
 /**
@@ -72,7 +79,7 @@ const BUTTON_CLASS_NAME = 'changeType';
  * ```
  * :::
  */
-
+var _addCustomShortcuts = /*#__PURE__*/new WeakSet();
 class DropdownMenu extends _base.BasePlugin {
   static get PLUGIN_KEY() {
     return PLUGIN_KEY;
@@ -100,6 +107,12 @@ class DropdownMenu extends _base.BasePlugin {
      * @private
      * @type {EventManager}
      */
+    /**
+     * Add custom shortcuts to the provided menu instance.
+     *
+     * @param {Menu} menuInstance The menu instance.
+     */
+    _classPrivateMethodInitSpec(this, _addCustomShortcuts);
     this.eventManager = new _eventManager.default(this);
     /**
      * Instance of {@link CommandExecutor}.
@@ -107,7 +120,7 @@ class DropdownMenu extends _base.BasePlugin {
      * @private
      * @type {CommandExecutor}
      */
-    this.commandExecutor = new _commandExecutor.default(this.hot);
+    this.commandExecutor = new _commandExecutor.CommandExecutor(this.hot);
     /**
      * Instance of {@link ItemsFactory}.
      *
@@ -148,7 +161,7 @@ class DropdownMenu extends _base.BasePlugin {
     if (this.enabled) {
       return;
     }
-    this.itemsFactory = new _itemsFactory.default(this.hot, DropdownMenu.DEFAULT_ITEMS);
+    this.itemsFactory = new _itemsFactory.ItemsFactory(this.hot, DropdownMenu.DEFAULT_ITEMS);
     const settings = this.hot.getSettings()[PLUGIN_KEY];
     const predefinedItems = {
       items: this.itemsFactory.getItems(settings)
@@ -157,6 +170,7 @@ class DropdownMenu extends _base.BasePlugin {
     if (typeof settings.callback === 'function') {
       this.commandExecutor.setCommonCallback(settings.callback);
     }
+    this.registerShortcuts();
     super.enablePlugin();
     this.callOnPluginsReady(() => {
       this.hot.runHooks('afterDropdownMenuDefaultOptions', predefinedItems);
@@ -165,7 +179,7 @@ class DropdownMenu extends _base.BasePlugin {
       if (this.menu) {
         this.menu.destroy();
       }
-      this.menu = new _menu.default(this.hot, {
+      this.menu = new _menu.Menu(this.hot, {
         className: 'htDropdownMenu',
         keepInViewport: true,
         container: settings.uiContainer || this.hot.rootDocument.body
@@ -174,6 +188,7 @@ class DropdownMenu extends _base.BasePlugin {
       this.menu.setMenuItems(menuItems);
       this.menu.addLocalHook('beforeOpen', () => this.onMenuBeforeOpen());
       this.menu.addLocalHook('afterOpen', () => this.onMenuAfterOpen());
+      this.menu.addLocalHook('afterSubmenuOpen', subMenuInstance => this.onSubMenuAfterOpen(subMenuInstance));
       this.menu.addLocalHook('afterClose', () => this.onMenuAfterClose());
       this.menu.addLocalHook('executeCommand', function () {
         for (var _len = arguments.length, params = new Array(_len), _key = 0; _key < _len; _key++) {
@@ -207,9 +222,66 @@ class DropdownMenu extends _base.BasePlugin {
     if (this.menu) {
       this.menu.destroy();
     }
+    this.unregisterShortcuts();
     super.disablePlugin();
   }
 
+  /**
+   * Register shortcuts responsible for toggling dropdown menu.
+   *
+   * @private
+   */
+  registerShortcuts() {
+    const gridContext = this.hot.getShortcutManager().getContext('grid');
+    const callback = () => {
+      const {
+        highlight
+      } = this.hot.getSelectedRangeLast();
+      if ((highlight.isHeader() && highlight.row === -1 || highlight.isCell()) && highlight.col >= 0) {
+        this.hot.selectColumns(highlight.col, highlight.col, -1);
+        const {
+          from
+        } = this.hot.getSelectedRangeLast();
+        const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
+        const target = this.hot.getCell(-1, from.col, true);
+        const rect = target.getBoundingClientRect();
+        this.open({
+          left: rect.left + offset.left,
+          top: rect.top + target.offsetHeight + offset.top
+        }, {
+          left: rect.width
+        });
+      }
+    };
+    gridContext.addShortcuts([{
+      keys: [['Shift', 'Alt', 'ArrowDown'], ['Control/Meta', 'Enter']],
+      callback,
+      runOnlyIf: () => {
+        var _this$hot$getSelected;
+        return ((_this$hot$getSelected = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected === void 0 ? void 0 : _this$hot$getSelected.highlight.isHeader()) && !this.menu.isOpened();
+      },
+      captureCtrl: true,
+      group: SHORTCUTS_GROUP
+    }, {
+      keys: [['Shift', 'Alt', 'ArrowDown']],
+      callback,
+      runOnlyIf: () => {
+        var _this$hot$getSelected2;
+        return ((_this$hot$getSelected2 = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected2 === void 0 ? void 0 : _this$hot$getSelected2.highlight.isCell()) && !this.menu.isOpened();
+      },
+      group: SHORTCUTS_GROUP
+    }]);
+  }
+
+  /**
+   * Unregister shortcuts responsible for toggling dropdown menu.
+   *
+   * @private
+   */
+  unregisterShortcuts() {
+    this.hot.getShortcutManager().getContext('grid').removeShortcutsByGroup(SHORTCUTS_GROUP);
+  }
+
   /**
    * Registers the DOM listeners.
    *
@@ -222,23 +294,30 @@ class DropdownMenu extends _base.BasePlugin {
   /**
    * Opens menu and re-position it based on the passed coordinates.
    *
-   * @param {object|Event} position An object with `pageX` and `pageY` properties which contains values relative to
-   *                                the top left of the fully rendered content area in the browser or with `clientX`
-   *                                and `clientY`  properties which contains values relative to the upper left edge
-   *                                of the content area (the viewport) of the browser window. This object is structurally
-   *                                compatible with native mouse event so it can be used either.
+   * @param {{ top: number, left: number }|Event} position An object with `top` and `left` properties
+   * which contains coordinates relative to the browsers viewport (without included scroll offsets).
+   * Or if the native event is passed the menu will be positioned based on the `pageX` and `pageY`
+   * coordinates.
+   * @param {{ above: number, below: number, left: number, right: number }} offset An object allows applying
+   * the offset to the menu position.
    * @fires Hooks#beforeDropdownMenuShow
    * @fires Hooks#afterDropdownMenuShow
    */
-
   open(position) {
-    if (!this.menu) {
+    var _this$menu;
+    let offset = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {
+      above: 0,
+      below: 0,
+      left: 0,
+      right: 0
+    };
+    if ((_this$menu = this.menu) !== null && _this$menu !== void 0 && _this$menu.isOpened()) {
       return;
     }
     this.menu.open();
-    if (position.width) {
-      this.menu.setOffset('left', position.width);
-    }
+    (0, _object.objectEach)(offset, (value, key) => {
+      this.menu.setOffset(key, value);
+    });
     this.menu.setPosition(position);
   }
 
@@ -246,10 +325,8 @@ class DropdownMenu extends _base.BasePlugin {
    * Closes dropdown menu.
    */
   close() {
-    if (!this.menu) {
-      return;
-    }
-    this.menu.close();
+    var _this$menu2;
+    (_this$menu2 = this.menu) === null || _this$menu2 === void 0 || _this$menu2.close();
   }
 
   /**
@@ -305,7 +382,6 @@ class DropdownMenu extends _base.BasePlugin {
       }
     }
   }
-
   /**
    * Table click listener.
    *
@@ -314,26 +390,14 @@ class DropdownMenu extends _base.BasePlugin {
    */
   onTableClick(event) {
     event.stopPropagation();
-    if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME) && !this.menu.isOpened()) {
-      let offsetTop = 0;
-      let offsetLeft = 0;
-      if (this.hot.rootDocument !== this.menu.container.ownerDocument) {
-        const {
-          frameElement
-        } = this.hot.rootWindow;
-        const {
-          top,
-          left
-        } = frameElement.getBoundingClientRect();
-        offsetTop = top;
-        offsetLeft = left;
-      }
+    if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME)) {
+      const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
       const rect = event.target.getBoundingClientRect();
       this.open({
-        left: rect.left + offsetLeft,
-        top: rect.top + event.target.offsetHeight + 3 + offsetTop,
-        width: rect.width,
-        height: rect.height
+        left: rect.left + offset.left,
+        top: rect.top + event.target.offsetHeight + 3 + offset.top
+      }, {
+        left: rect.width
       });
     }
   }
@@ -372,6 +436,11 @@ class DropdownMenu extends _base.BasePlugin {
     const button = this.hot.rootDocument.createElement('button');
     button.className = BUTTON_CLASS_NAME;
     button.type = 'button';
+    button.tabIndex = -1;
+    if (this.hot.getSettings().ariaTags) {
+      (0, _element.setAttribute)(button, [(0, _a11y.A11Y_LABEL)(this.hot.getTranslatedPhrase(_constants.COLUMN_HEADER_LABEL_OPEN_MENU))]);
+      (0, _element.setAttribute)(TH, [(0, _a11y.A11Y_HASPOPUP)('menu')]);
+    }
 
     // prevent page reload on button click
     button.onclick = function () {
@@ -398,6 +467,17 @@ class DropdownMenu extends _base.BasePlugin {
    */
   onMenuAfterOpen() {
     this.hot.runHooks('afterDropdownMenuShow', this);
+    _classPrivateMethodGet(this, _addCustomShortcuts, _addCustomShortcuts2).call(this, this.menu);
+  }
+
+  /**
+   * Listener for the `afterSubmenuOpen` hook.
+   *
+   * @private
+   * @param {Menu} subMenuInstance The opened sub menu instance.
+   */
+  onSubMenuAfterOpen(subMenuInstance) {
+    _classPrivateMethodGet(this, _addCustomShortcuts, _addCustomShortcuts2).call(this, subMenuInstance);
   }
 
   /**
@@ -423,6 +503,12 @@ class DropdownMenu extends _base.BasePlugin {
   }
 }
 exports.DropdownMenu = DropdownMenu;
+function _addCustomShortcuts2(menuInstance) {
+  menuInstance.getKeyboardShortcutsCtrl().addCustomShortcuts([{
+    keys: [['Control/Meta', 'A']],
+    callback: () => false
+  }]);
+}
 DropdownMenu.SEPARATOR = {
   name: _predefinedItems.SEPARATOR
 };