handsontable 0.0.0-next-eaf150e-20240823 → 0.0.0-next-0306a1a-20240826

package/plugins/filters/conditionCollection.mjs

@@ -41,13 +41,6 @@ class ConditionCollection {
      * @type {LinkedPhysicalIndexToValueMap}
      */
     _defineProperty(this, "filteringStates", new IndexToValueMap());
-    /**
-     * Stores the previous state of the condition stack before the latest filter operation.
-     * This is used in the `beforeFilter` plugin to allow performing the undo operation.
-     *
-     * @type {null|Array}
-     */
-    _defineProperty(this, "previousConditionStack", null);
     this.hot = hot;
     this.isMapRegistrable = isMapRegistrable;
     if (this.isMapRegistrable === true) {
@@ -116,13 +109,6 @@ class ConditionCollection {
     const localeForColumn = this.hot.getCellMeta(0, column).locale;
     const args = arrayMap(conditionDefinition.args, v => typeof v === 'string' ? v.toLocaleLowerCase(localeForColumn) : v);
     const name = conditionDefinition.name || conditionDefinition.command.key;
-
-    // If there's no previous condition stack defined (which means the condition stack was not cleared after the
-    // previous filter operation or that there was no filter operation performed yet), store the current conditions as
-    // the previous condition stack.
-    if (this.previousConditionStack === null) {
-      this.setPreviousConditionStack(this.exportAllConditions());
-    }
     this.runLocalHooks('beforeAdd', column);
     const columnType = this.getOperation(column);
     if (columnType) {
@@ -251,8 +237,6 @@ class ConditionCollection {
    * @fires ConditionCollection#afterRemove
    */
   removeConditions(column) {
-    // Store the current conditions as the previous condition stack before it's cleared.
-    this.setPreviousConditionStack(this.exportAllConditions());
     this.runLocalHooks('beforeRemove', column);
     this.filteringStates.clearValue(column);
     this.runLocalHooks('afterRemove', column);
@@ -286,16 +270,6 @@ class ConditionCollection {
     return conditions.length > 0;
   }
 
-  /**
-   * Updates the `previousConditionStack` property with the provided stack.
-   * It is used to store the current conditions before they are modified, allowing for undo operations.
-   *
-   * @param {Array|null} previousConditionStack The stack of previous conditions.
-   */
-  setPreviousConditionStack(previousConditionStack) {
-    this.previousConditionStack = previousConditionStack;
-  }
-
   /**
    * Destroy object.
    */

package/plugins/filters/filters.js

@@ -483,7 +483,7 @@ class Filters extends _base.BasePlugin {
     const needToFilter = !this.conditionCollection.isEmpty();
     let visibleVisualRows = [];
     const conditions = this.conditionCollection.exportAllConditions();
-    const allowFiltering = this.hot.runHooks('beforeFilter', conditions, this.conditionCollection.previousConditionStack);
+    const allowFiltering = this.hot.runHooks('beforeFilter', conditions);
     if (allowFiltering !== false) {
       if (needToFilter) {
         const trimmedRows = [];
@@ -508,7 +508,6 @@ class Filters extends _base.BasePlugin {
       }
     }
     this.hot.runHooks('afterFilter', conditions);
-    this.conditionCollection.setPreviousConditionStack(null);
     this.hot.view.adjustElementsSize();
     this.hot.render();
     if (this.hot.selection.isSelected()) {

package/plugins/filters/filters.mjs

@@ -477,7 +477,7 @@ export class Filters extends BasePlugin {
     const needToFilter = !this.conditionCollection.isEmpty();
     let visibleVisualRows = [];
     const conditions = this.conditionCollection.exportAllConditions();
-    const allowFiltering = this.hot.runHooks('beforeFilter', conditions, this.conditionCollection.previousConditionStack);
+    const allowFiltering = this.hot.runHooks('beforeFilter', conditions);
     if (allowFiltering !== false) {
       if (needToFilter) {
         const trimmedRows = [];
@@ -502,7 +502,6 @@ export class Filters extends BasePlugin {
       }
     }
     this.hot.runHooks('afterFilter', conditions);
-    this.conditionCollection.setPreviousConditionStack(null);
     this.hot.view.adjustElementsSize();
     this.hot.render();
     if (this.hot.selection.isSelected()) {

package/plugins/filters/ui/multipleSelect.js

@@ -128,9 +128,10 @@ class MultipleSelectUI extends _base.BaseUI {
    * @param {Array} items Array of objects with `checked` and `label` property.
    */
   setItems(items) {
-    var _classPrivateFieldGet2;
     _classPrivateFieldSet(_items, this, items);
-    (_classPrivateFieldGet2 = _classPrivateFieldGet(_itemsBox, this)) === null || _classPrivateFieldGet2 === void 0 || _classPrivateFieldGet2.loadData(_classPrivateFieldGet(_items, this));
+    if (_classPrivateFieldGet(_itemsBox, this)) {
+      _classPrivateFieldGet(_itemsBox, this).loadData(_classPrivateFieldGet(_items, this));
+    }
   }
 
   /**
@@ -222,13 +223,13 @@ class MultipleSelectUI extends _base.BaseUI {
     this._element.appendChild(selectionControl.element);
     this._element.appendChild(itemsBoxWrapper);
     const hotInitializer = wrapper => {
-      var _classPrivateFieldGet3;
       if (!this._element) {
         return;
       }
-      (_classPrivateFieldGet3 = _classPrivateFieldGet(_itemsBox, this)) === null || _classPrivateFieldGet3 === void 0 || _classPrivateFieldGet3.destroy();
+      if (_classPrivateFieldGet(_itemsBox, this)) {
+        _classPrivateFieldGet(_itemsBox, this).destroy();
+      }
       (0, _element.addClass)(wrapper, 'htUIMultipleSelectHot');
-
       // Constructs and initializes a new Handsontable instance
       _classPrivateFieldSet(_itemsBox, this, new this.hot.constructor(wrapper, {
         data: _classPrivateFieldGet(_items, this),
@@ -322,8 +323,9 @@ class MultipleSelectUI extends _base.BaseUI {
    * Destroy instance.
    */
   destroy() {
-    var _classPrivateFieldGet4;
-    (_classPrivateFieldGet4 = _classPrivateFieldGet(_itemsBox, this)) === null || _classPrivateFieldGet4 === void 0 || _classPrivateFieldGet4.destroy();
+    if (_classPrivateFieldGet(_itemsBox, this)) {
+      _classPrivateFieldGet(_itemsBox, this).destroy();
+    }
     _classPrivateFieldGet(_searchInput, this).destroy();
     _classPrivateFieldGet(_clearAllUI, this).destroy();
     _classPrivateFieldGet(_selectAllUI, this).destroy();

package/plugins/filters/ui/multipleSelect.mjs

@@ -123,9 +123,10 @@ export class MultipleSelectUI extends BaseUI {
    * @param {Array} items Array of objects with `checked` and `label` property.
    */
   setItems(items) {
-    var _classPrivateFieldGet2;
     _classPrivateFieldSet(_items, this, items);
-    (_classPrivateFieldGet2 = _classPrivateFieldGet(_itemsBox, this)) === null || _classPrivateFieldGet2 === void 0 || _classPrivateFieldGet2.loadData(_classPrivateFieldGet(_items, this));
+    if (_classPrivateFieldGet(_itemsBox, this)) {
+      _classPrivateFieldGet(_itemsBox, this).loadData(_classPrivateFieldGet(_items, this));
+    }
   }
 
   /**
@@ -217,13 +218,13 @@ export class MultipleSelectUI extends BaseUI {
     this._element.appendChild(selectionControl.element);
     this._element.appendChild(itemsBoxWrapper);
     const hotInitializer = wrapper => {
-      var _classPrivateFieldGet3;
       if (!this._element) {
         return;
       }
-      (_classPrivateFieldGet3 = _classPrivateFieldGet(_itemsBox, this)) === null || _classPrivateFieldGet3 === void 0 || _classPrivateFieldGet3.destroy();
+      if (_classPrivateFieldGet(_itemsBox, this)) {
+        _classPrivateFieldGet(_itemsBox, this).destroy();
+      }
       addClass(wrapper, 'htUIMultipleSelectHot');
-
       // Constructs and initializes a new Handsontable instance
       _classPrivateFieldSet(_itemsBox, this, new this.hot.constructor(wrapper, {
         data: _classPrivateFieldGet(_items, this),
@@ -317,8 +318,9 @@ export class MultipleSelectUI extends BaseUI {
    * Destroy instance.
    */
   destroy() {
-    var _classPrivateFieldGet4;
-    (_classPrivateFieldGet4 = _classPrivateFieldGet(_itemsBox, this)) === null || _classPrivateFieldGet4 === void 0 || _classPrivateFieldGet4.destroy();
+    if (_classPrivateFieldGet(_itemsBox, this)) {
+      _classPrivateFieldGet(_itemsBox, this).destroy();
+    }
     _classPrivateFieldGet(_searchInput, this).destroy();
     _classPrivateFieldGet(_clearAllUI, this).destroy();
     _classPrivateFieldGet(_selectAllUI, this).destroy();

package/plugins/manualRowResize/manualRowResize.js

@@ -227,7 +227,7 @@ class ManualRowResize extends _base.BasePlugin {
    */
   setManualSize(row, height) {
     const physicalRow = this.hot.toPhysicalRow(row);
-    const newHeight = Math.max(height, _src.DEFAULT_ROW_HEIGHT);
+    const newHeight = Math.max(height, _src.ViewportRowsCalculator.DEFAULT_HEIGHT);
     _classPrivateFieldGet(_rowHeightsMap, this).setValueAtIndex(physicalRow, newHeight);
     return newHeight;
   }

package/plugins/manualRowResize/manualRowResize.mjs

@@ -11,7 +11,7 @@ import { addClass, closest, hasClass, removeClass, outerWidth, isDetached } from
 import { arrayEach } from "../../helpers/array.mjs";
 import { rangeEach } from "../../helpers/number.mjs";
 import { PhysicalIndexToValueMap as IndexToValueMap } from "../../translations/index.mjs";
-import { DEFAULT_ROW_HEIGHT } from "../../3rdparty/walkontable/src/index.mjs"; // Developer note! Whenever you make a change in this file, make an analogous change in manualColumnResize.js
+import { ViewportRowsCalculator } from "../../3rdparty/walkontable/src/index.mjs"; // Developer note! Whenever you make a change in this file, make an analogous change in manualColumnResize.js
 export const PLUGIN_KEY = 'manualRowResize';
 export const PLUGIN_PRIORITY = 30;
 const PERSISTENT_STATE_KEY = 'manualRowHeights';
@@ -222,7 +222,7 @@ export class ManualRowResize extends BasePlugin {
    */
   setManualSize(row, height) {
     const physicalRow = this.hot.toPhysicalRow(row);
-    const newHeight = Math.max(height, DEFAULT_ROW_HEIGHT);
+    const newHeight = Math.max(height, ViewportRowsCalculator.DEFAULT_HEIGHT);
     _classPrivateFieldGet(_rowHeightsMap, this).setValueAtIndex(physicalRow, newHeight);
     return newHeight;
   }

package/plugins/mergeCells/cellsCollection.js

@@ -424,20 +424,18 @@ class MergedCellsCollection {
         break;
       default:
     }
-    const removedMergedCells = [];
-    this.mergedCells.forEach(currentMerge => {
+    (0, _array.arrayEach)(this.mergedCells, currentMerge => {
+      _assertClassBrand(_MergedCellsCollection_brand, this, _removeMergedCellFromMatrix).call(this, currentMerge);
       currentMerge.shift(shiftVector, index);
-      if (currentMerge.removed) {
-        removedMergedCells.push(currentMerge);
-      }
-    });
-    removedMergedCells.forEach(removedMerge => {
-      this.mergedCells.splice(this.mergedCells.indexOf(removedMerge), 1);
-    });
-    this.mergedCellsMatrix.clear();
-    this.mergedCells.forEach(currentMerge => {
       _assertClassBrand(_MergedCellsCollection_brand, this, _addMergedCellToMatrix).call(this, currentMerge);
     });
+    (0, _number.rangeEachReverse)(this.mergedCells.length - 1, 0, i => {
+      const currentMerge = this.mergedCells[i];
+      if (currentMerge && currentMerge.removed) {
+        this.mergedCells.splice(this.mergedCells.indexOf(currentMerge), 1);
+        _assertClassBrand(_MergedCellsCollection_brand, this, _removeMergedCellFromMatrix).call(this, currentMerge);
+      }
+    });
   }
 
   /**

package/plugins/mergeCells/cellsCollection.mjs

@@ -15,7 +15,7 @@ function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol"
 function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
 function _assertClassBrand(e, t, n) { if ("function" == typeof e ? e === t : e.has(t)) return arguments.length < 3 ? t : n; throw new TypeError("Private element is not present on this object"); }
 import MergedCellCoords from "./cellCoords.mjs";
-import { rangeEach } from "../../helpers/number.mjs";
+import { rangeEach, rangeEachReverse } from "../../helpers/number.mjs";
 import { warn } from "../../helpers/console.mjs";
 import { arrayEach } from "../../helpers/array.mjs";
 import { toSingleLine } from "../../helpers/templateLiteralTag.mjs";
@@ -420,20 +420,18 @@ class MergedCellsCollection {
         break;
       default:
     }
-    const removedMergedCells = [];
-    this.mergedCells.forEach(currentMerge => {
+    arrayEach(this.mergedCells, currentMerge => {
+      _assertClassBrand(_MergedCellsCollection_brand, this, _removeMergedCellFromMatrix).call(this, currentMerge);
       currentMerge.shift(shiftVector, index);
-      if (currentMerge.removed) {
-        removedMergedCells.push(currentMerge);
-      }
-    });
-    removedMergedCells.forEach(removedMerge => {
-      this.mergedCells.splice(this.mergedCells.indexOf(removedMerge), 1);
-    });
-    this.mergedCellsMatrix.clear();
-    this.mergedCells.forEach(currentMerge => {
       _assertClassBrand(_MergedCellsCollection_brand, this, _addMergedCellToMatrix).call(this, currentMerge);
     });
+    rangeEachReverse(this.mergedCells.length - 1, 0, i => {
+      const currentMerge = this.mergedCells[i];
+      if (currentMerge && currentMerge.removed) {
+        this.mergedCells.splice(this.mergedCells.indexOf(currentMerge), 1);
+        _assertClassBrand(_MergedCellsCollection_brand, this, _removeMergedCellFromMatrix).call(this, currentMerge);
+      }
+    });
   }
 
   /**

package/plugins/undoRedo/undoRedo.js

@@ -124,8 +124,8 @@ function UndoRedo(instance) {
   instance.addHook('beforeCellAlignment', (stateBefore, range, type, alignment) => {
     plugin.done(() => new UndoRedo.CellAlignmentAction(stateBefore, range, type, alignment));
   });
-  instance.addHook('beforeFilter', (conditionsStack, previousConditionsStack) => {
-    plugin.done(() => new UndoRedo.FiltersAction(conditionsStack, previousConditionsStack));
+  instance.addHook('beforeFilter', conditionsStack => {
+    plugin.done(() => new UndoRedo.FiltersAction(conditionsStack));
   });
   instance.addHook('beforeRowMove', (rows, finalIndex) => {
     if (rows === false) {
@@ -645,11 +645,9 @@ UndoRedo.CellAlignmentAction.prototype.redo = function (instance, undoneCallback
  * Filters action.
  *
  * @private
- * @param {Array} conditionsStack An array of the filter conditions.
- * @param {Array} previousConditionsStack An array of the previous filter conditions.
+ * @param {Array} conditionsStack An array of the filter condition.
  */
-UndoRedo.FiltersAction = function (conditionsStack, previousConditionsStack) {
-  this.previousConditionsStack = previousConditionsStack;
+UndoRedo.FiltersAction = function (conditionsStack) {
   this.conditionsStack = conditionsStack;
   this.actionType = 'filter';
 };
@@ -657,9 +655,7 @@ UndoRedo.FiltersAction = function (conditionsStack, previousConditionsStack) {
 UndoRedo.FiltersAction.prototype.undo = function (instance, undoneCallback) {
   const filters = instance.getPlugin('filters');
   instance.addHookOnce('afterViewRender', undoneCallback);
-  if (this.previousConditionsStack) {
-    filters.conditionCollection.importAllConditions(this.previousConditionsStack);
-  }
+  filters.conditionCollection.importAllConditions(this.conditionsStack.slice(0, this.conditionsStack.length - 1));
   filters.filter();
 };
 UndoRedo.FiltersAction.prototype.redo = function (instance, redoneCallback) {

package/plugins/undoRedo/undoRedo.mjs

@@ -120,8 +120,8 @@ function UndoRedo(instance) {
   instance.addHook('beforeCellAlignment', (stateBefore, range, type, alignment) => {
     plugin.done(() => new UndoRedo.CellAlignmentAction(stateBefore, range, type, alignment));
   });
-  instance.addHook('beforeFilter', (conditionsStack, previousConditionsStack) => {
-    plugin.done(() => new UndoRedo.FiltersAction(conditionsStack, previousConditionsStack));
+  instance.addHook('beforeFilter', conditionsStack => {
+    plugin.done(() => new UndoRedo.FiltersAction(conditionsStack));
   });
   instance.addHook('beforeRowMove', (rows, finalIndex) => {
     if (rows === false) {
@@ -641,11 +641,9 @@ UndoRedo.CellAlignmentAction.prototype.redo = function (instance, undoneCallback
  * Filters action.
  *
  * @private
- * @param {Array} conditionsStack An array of the filter conditions.
- * @param {Array} previousConditionsStack An array of the previous filter conditions.
+ * @param {Array} conditionsStack An array of the filter condition.
  */
-UndoRedo.FiltersAction = function (conditionsStack, previousConditionsStack) {
-  this.previousConditionsStack = previousConditionsStack;
+UndoRedo.FiltersAction = function (conditionsStack) {
   this.conditionsStack = conditionsStack;
   this.actionType = 'filter';
 };
@@ -653,9 +651,7 @@ inherit(UndoRedo.FiltersAction, UndoRedo.Action);
 UndoRedo.FiltersAction.prototype.undo = function (instance, undoneCallback) {
   const filters = instance.getPlugin('filters');
   instance.addHookOnce('afterViewRender', undoneCallback);
-  if (this.previousConditionsStack) {
-    filters.conditionCollection.importAllConditions(this.previousConditionsStack);
-  }
+  filters.conditionCollection.importAllConditions(this.conditionsStack.slice(0, this.conditionsStack.length - 1));
   filters.filter();
 };
 UndoRedo.FiltersAction.prototype.redo = function (instance, redoneCallback) {

package/shortcuts/utils.js

@@ -36,9 +36,7 @@ const getKeysList = normalizedKeys => {
   return normalizedKeys.split('+');
 };
 exports.getKeysList = getKeysList;
-const specialCharactersSet = new Map([[96, 'numpad0'], [97, 'numpad1'], [98, 'numpad2'], [99, 'numpad3'], [100, 'numpad4'], [101, 'numpad5'], [102, 'numpad6'], [103, 'numpad7'], [104, 'numpad8'], [105, 'numpad9'], [106, 'multiply'], [107, 'add'], [108, 'decimal'],
-// firefox
-[109, 'subtract'], [110, 'decimal'], [111, 'divide'], [112, 'f1'], [113, 'f2'], [114, 'f3'], [115, 'f4'], [116, 'f5'], [117, 'f6'], [118, 'f7'], [119, 'f8'], [120, 'f9'], [121, 'f10'], [122, 'f11'], [123, 'f12'], [186, 'semicolon'], [187, 'equal'], [188, 'comma'], [189, 'minus'], [190, 'period'], [191, 'slash'], [192, 'backquote'], [219, 'bracketleft'], [220, 'backslash'], [221, 'bracketright'], [222, 'quote']]);
+const specialCharactersSet = new Map([[186, 'semicolon'], [187, 'equal'], [188, 'comma'], [189, 'minus'], [190, 'period'], [191, 'slash'], [192, 'backquote'], [219, 'bracketleft'], [220, 'backslash'], [221, 'bracketright'], [222, 'quote']]);
 
 /**
  * Normalizes a keyboard event key value to a key before its modification.

package/shortcuts/utils.mjs

@@ -31,9 +31,7 @@ export const normalizeKeys = keys => {
 export const getKeysList = normalizedKeys => {
   return normalizedKeys.split('+');
 };
-const specialCharactersSet = new Map([[96, 'numpad0'], [97, 'numpad1'], [98, 'numpad2'], [99, 'numpad3'], [100, 'numpad4'], [101, 'numpad5'], [102, 'numpad6'], [103, 'numpad7'], [104, 'numpad8'], [105, 'numpad9'], [106, 'multiply'], [107, 'add'], [108, 'decimal'],
-// firefox
-[109, 'subtract'], [110, 'decimal'], [111, 'divide'], [112, 'f1'], [113, 'f2'], [114, 'f3'], [115, 'f4'], [116, 'f5'], [117, 'f6'], [118, 'f7'], [119, 'f8'], [120, 'f9'], [121, 'f10'], [122, 'f11'], [123, 'f12'], [186, 'semicolon'], [187, 'equal'], [188, 'comma'], [189, 'minus'], [190, 'period'], [191, 'slash'], [192, 'backquote'], [219, 'bracketleft'], [220, 'backslash'], [221, 'bracketright'], [222, 'quote']]);
+const specialCharactersSet = new Map([[186, 'semicolon'], [187, 'equal'], [188, 'comma'], [189, 'minus'], [190, 'period'], [191, 'slash'], [192, 'backquote'], [219, 'bracketleft'], [220, 'backslash'], [221, 'bracketright'], [222, 'quote']]);
 
 /**
  * Normalizes a keyboard event key value to a key before its modification.

package/utils/ghostTable.js

@@ -148,15 +148,8 @@ class GhostTable {
       this.injectTable();
     }
     (0, _array.arrayEach)(this.rows, row => {
-      // In cases when the cell's content produces the height with a decimal point, the height
-      // needs to be rounded up to make sure that there will be a space for the cell's content.
-      // The `.offsetHeight` always returns the rounded number (floored), so it's not suitable for this case.
-      const {
-        height
-      } = row.table.getBoundingClientRect();
-
       // -1 <- reduce border-top from table
-      callback(row.row, Math.ceil(height) - 1);
+      callback(row.row, (0, _element.outerHeight)(row.table) - 1);
     });
   }
 
@@ -170,9 +163,14 @@ class GhostTable {
       this.injectTable();
     }
     (0, _array.arrayEach)(this.columns, column => {
-      // In cases when the cell's content produces the width with a decimal point, the width
-      // needs to be rounded up to make sure that there will be a space for the cell's content.
-      // The `.offsetWidth` always returns the rounded number (floored), so it's not suitable for this case.
+      // The GhostTable class is responsible for calculating the columns' width based on the
+      // contents rendered in the cells. In some cases, when the column's width calculated by
+      // the browser is a decimal point with a fractional component. For example, 35.32px.
+      // The usage of the `.offsetWidth` (or our helper `outerWidth`) is incorrect.
+      // The `outerWidth` in the mentioned example (35.32px) would return 35 pixels that
+      // would cause the text to not fit in the cell, thus increasing the row height.
+      // That's why the `getBoundingClientRect` method is used. The method returns the number
+      // that is rounded up to make sure that there will be a space for the cell's content.
       const {
         width
       } = column.table.getBoundingClientRect();

package/utils/ghostTable.mjs

@@ -3,7 +3,7 @@ import "core-js/modules/es.array.push.js";
 function _defineProperty(e, r, t) { return (r = _toPropertyKey(r)) in e ? Object.defineProperty(e, r, { value: t, enumerable: !0, configurable: !0, writable: !0 }) : e[r] = t, e; }
 function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == typeof i ? i : i + ""; }
 function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
-import { addClass } from "./../helpers/dom/element.mjs";
+import { addClass, outerHeight } from "./../helpers/dom/element.mjs";
 import { arrayEach } from "./../helpers/array.mjs";
 /**
  * @class GhostTable
@@ -145,15 +145,8 @@ class GhostTable {
       this.injectTable();
     }
     arrayEach(this.rows, row => {
-      // In cases when the cell's content produces the height with a decimal point, the height
-      // needs to be rounded up to make sure that there will be a space for the cell's content.
-      // The `.offsetHeight` always returns the rounded number (floored), so it's not suitable for this case.
-      const {
-        height
-      } = row.table.getBoundingClientRect();
-
       // -1 <- reduce border-top from table
-      callback(row.row, Math.ceil(height) - 1);
+      callback(row.row, outerHeight(row.table) - 1);
     });
   }
 
@@ -167,9 +160,14 @@ class GhostTable {
       this.injectTable();
     }
     arrayEach(this.columns, column => {
-      // In cases when the cell's content produces the width with a decimal point, the width
-      // needs to be rounded up to make sure that there will be a space for the cell's content.
-      // The `.offsetWidth` always returns the rounded number (floored), so it's not suitable for this case.
+      // The GhostTable class is responsible for calculating the columns' width based on the
+      // contents rendered in the cells. In some cases, when the column's width calculated by
+      // the browser is a decimal point with a fractional component. For example, 35.32px.
+      // The usage of the `.offsetWidth` (or our helper `outerWidth`) is incorrect.
+      // The `outerWidth` in the mentioned example (35.32px) would return 35 pixels that
+      // would cause the text to not fit in the cell, thus increasing the row height.
+      // That's why the `getBoundingClientRect` method is used. The method returns the number
+      // that is rounded up to make sure that there will be a space for the cell's content.
       const {
         width
       } = column.table.getBoundingClientRect();

package/3rdparty/walkontable/src/calculator/calculationType/fullyVisibleColumns.js

@@ -1,126 +0,0 @@
-"use strict";
-
-exports.__esModule = true;
-require("core-js/modules/es.error.cause.js");
-require("core-js/modules/es.array.at.js");
-require("core-js/modules/es.string.at-alternative.js");
-function _defineProperty(e, r, t) { return (r = _toPropertyKey(r)) in e ? Object.defineProperty(e, r, { value: t, enumerable: !0, configurable: !0, writable: !0 }) : e[r] = t, e; }
-function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == typeof i ? i : i + ""; }
-function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
-/**
- * @class FullyVisibleColumnsCalculationType
- */
-class FullyVisibleColumnsCalculationType {
-  constructor() {
-    /**
-     * Total number of fully visible columns in the viewport.
-     *
-     * @type {number}
-     */
-    _defineProperty(this, "count", 0);
-    /**
-     * The column index of the first fully visible column in the viewport.
-     *
-     * @type {number|null}
-     */
-    _defineProperty(this, "startColumn", null);
-    /**
-     * The column index of the last fully visible column in the viewport.
-     *
-     * @type {number|null}
-     */
-    _defineProperty(this, "endColumn", null);
-    /**
-     * Position of the first fully visible column (in px).
-     *
-     * @type {number|null}
-     */
-    _defineProperty(this, "startPosition", null);
-    /**
-     * Determines if the viewport is visible in the trimming container.
-     *
-     * @type {boolean}
-     */
-    _defineProperty(this, "isVisibleInTrimmingContainer", false);
-  }
-  /**
-   * Initializes the calculation.
-   */
-  initialize() {}
-
-  /**
-   * Processes the column.
-   *
-   * @param {number} column The column index.
-   * @param {ViewportColumnsCalculator} viewportCalculator The viewport calculator object.
-   */
-  process(column, viewportCalculator) {
-    const {
-      totalCalculatedWidth,
-      zeroBasedScrollOffset,
-      viewportWidth,
-      columnWidth
-    } = viewportCalculator;
-    const compensatedViewportWidth = zeroBasedScrollOffset > 0 ? viewportWidth + 1 : viewportWidth;
-    if (totalCalculatedWidth >= zeroBasedScrollOffset && totalCalculatedWidth + columnWidth <= zeroBasedScrollOffset + compensatedViewportWidth) {
-      if (this.startColumn === null || this.startColumn === undefined) {
-        this.startColumn = column;
-      }
-      this.endColumn = column;
-    }
-  }
-
-  /**
-   * Finalizes the calculation.
-   *
-   * @param {ViewportColumnsCalculator} viewportCalculator The viewport calculator object.
-   */
-  finalize(viewportCalculator) {
-    var _startPositions$this$;
-    const {
-      scrollOffset,
-      viewportWidth,
-      inlineStartOffset,
-      zeroBasedScrollOffset,
-      totalColumns,
-      needReverse,
-      startPositions,
-      columnWidth
-    } = viewportCalculator;
-
-    // If the estimation has reached the last column and there is still some space available in the viewport,
-    // we need to render in reverse in order to fill the whole viewport with columns
-    if (this.endColumn === totalColumns - 1 && needReverse) {
-      this.startColumn = this.endColumn;
-      while (this.startColumn > 0) {
-        const calculatedViewportHeight = startPositions[this.endColumn] + columnWidth - startPositions[this.startColumn - 1];
-        if (calculatedViewportHeight <= viewportWidth) {
-          this.startColumn -= 1;
-        }
-        if (calculatedViewportHeight >= viewportWidth) {
-          break;
-        }
-      }
-    }
-    this.startPosition = (_startPositions$this$ = startPositions[this.startColumn]) !== null && _startPositions$this$ !== void 0 ? _startPositions$this$ : null;
-    const compensatedViewportWidth = zeroBasedScrollOffset > 0 ? viewportWidth + 1 : viewportWidth;
-    const mostRightScrollOffset = scrollOffset + viewportWidth - compensatedViewportWidth;
-    const inlineStartColumnOffset = this.startColumn === null ? 0 : viewportCalculator.getColumnWidth(this.startColumn);
-    if (
-    // the table is to the left of the viewport
-    mostRightScrollOffset < -1 * inlineStartOffset || scrollOffset > startPositions.at(-1) ||
-    // the table is to the right of the viewport
-    -1 * scrollOffset - viewportWidth > -1 * inlineStartColumnOffset) {
-      this.isVisibleInTrimmingContainer = false;
-    } else {
-      this.isVisibleInTrimmingContainer = true;
-    }
-    if (totalColumns < this.endColumn) {
-      this.endColumn = totalColumns - 1;
-    }
-    if (this.startColumn !== null) {
-      this.count = this.endColumn - this.startColumn + 1;
-    }
-  }
-}
-exports.FullyVisibleColumnsCalculationType = FullyVisibleColumnsCalculationType;