handsontable 0.0.0-next-baf2fcf-20230809 → 0.0.0-next-08765b9-20230809

package/plugins/copyPaste/copyPaste.js

@@ -168,10 +168,10 @@ class CopyPaste extends _base.BasePlugin {
      * Defines the data range to copy. Possible values:
      *  * `'cells-only'` Copy selected cells only;
      *  * `'column-headers-only'` Copy column headers only;
-     *  * `'with-column-group-headers'` Copy cells with all column headers;
+     *  * `'with-all-column-headers'` Copy cells with all column headers;
      *  * `'with-column-headers'` Copy cells with column headers;
      *
-     * @type {'cells-only' | 'column-headers-only' | 'with-column-group-headers' | 'with-column-headers'}
+     * @type {'cells-only' | 'column-headers-only' | 'with-all-column-headers' | 'with-column-headers'}
      */
     _classPrivateFieldInitSpec(this, _copyMode, {
       writable: true,
@@ -306,12 +306,12 @@ class CopyPaste extends _base.BasePlugin {
    *
    * Takes an optional parameter (`copyMode`) that defines the scope of copying:
    *
-   * | `copyMode` value              | Description                                                     |
-   * | ----------------------------- | --------------------------------------------------------------- |
-   * | `'cells-only'` (default)      | Copy the selected cells                                         |
-   * | `'with-column-headers'`       | - Copy the selected cells<br>- Copy the nearest column headers  |
-   * | `'with-column-group-headers'` | - Copy the selected cells<br>- Copy all related columns headers |
-   * | `'column-headers-only'`       | Copy the nearest column headers (without copying cells)         |
+   * | `copyMode` value            | Description                                                     |
+   * | --------------------------- | --------------------------------------------------------------- |
+   * | `'cells-only'` (default)    | Copy the selected cells                                         |
+   * | `'with-column-headers'`     | - Copy the selected cells<br>- Copy the nearest column headers  |
+   * | `'with-all-column-headers'` | - Copy the selected cells<br>- Copy all related columns headers |
+   * | `'column-headers-only'`     | Copy the nearest column headers (without copying cells)         |
    *
    * @param {string} [copyMode='cells-only'] Copy mode.
    */
@@ -431,6 +431,10 @@ class CopyPaste extends _base.BasePlugin {
     if (!selectionRange) {
       return;
     }
+    if (selectionRange.isSingleHeader()) {
+      this.copyableRanges = [];
+      return;
+    }
     _classPrivateFieldGet(this, _copyableRangesFactory).setSelectedRange(selectionRange);
     const groupedRanges = new Map([['headers', null], ['cells', null]]);
     if (_classPrivateFieldGet(this, _copyMode) === 'column-headers-only') {
@@ -627,7 +631,7 @@ class CopyPaste extends _base.BasePlugin {
    * @private
    */
   onPaste(event) {
-    if (!this.hot.isListening() || this.isEditorOpened()) {
+    if (!this.hot.isListening() || this.isEditorOpened() || !this.hot.getSelected()) {
       return;
     }
     if (event && event.preventDefault) {
@@ -652,7 +656,7 @@ class CopyPaste extends _base.BasePlugin {
     if (typeof pastedData === 'string') {
       pastedData = (0, _SheetClip.parse)(pastedData);
     }
-    if (pastedData && pastedData.length === 0) {
+    if (pastedData === void 0 || pastedData && pastedData.length === 0) {
       return;
     }
     if (this.hot.runHooks('beforePaste', pastedData, this.copyableRanges) === false) {

package/plugins/copyPaste/copyPaste.mjs

@@ -162,10 +162,10 @@ export class CopyPaste extends BasePlugin {
      * Defines the data range to copy. Possible values:
      *  * `'cells-only'` Copy selected cells only;
      *  * `'column-headers-only'` Copy column headers only;
-     *  * `'with-column-group-headers'` Copy cells with all column headers;
+     *  * `'with-all-column-headers'` Copy cells with all column headers;
      *  * `'with-column-headers'` Copy cells with column headers;
      *
-     * @type {'cells-only' | 'column-headers-only' | 'with-column-group-headers' | 'with-column-headers'}
+     * @type {'cells-only' | 'column-headers-only' | 'with-all-column-headers' | 'with-column-headers'}
      */
     _classPrivateFieldInitSpec(this, _copyMode, {
       writable: true,
@@ -300,12 +300,12 @@ export class CopyPaste extends BasePlugin {
    *
    * Takes an optional parameter (`copyMode`) that defines the scope of copying:
    *
-   * | `copyMode` value              | Description                                                     |
-   * | ----------------------------- | --------------------------------------------------------------- |
-   * | `'cells-only'` (default)      | Copy the selected cells                                         |
-   * | `'with-column-headers'`       | - Copy the selected cells<br>- Copy the nearest column headers  |
-   * | `'with-column-group-headers'` | - Copy the selected cells<br>- Copy all related columns headers |
-   * | `'column-headers-only'`       | Copy the nearest column headers (without copying cells)         |
+   * | `copyMode` value            | Description                                                     |
+   * | --------------------------- | --------------------------------------------------------------- |
+   * | `'cells-only'` (default)    | Copy the selected cells                                         |
+   * | `'with-column-headers'`     | - Copy the selected cells<br>- Copy the nearest column headers  |
+   * | `'with-all-column-headers'` | - Copy the selected cells<br>- Copy all related columns headers |
+   * | `'column-headers-only'`     | Copy the nearest column headers (without copying cells)         |
    *
    * @param {string} [copyMode='cells-only'] Copy mode.
    */
@@ -425,6 +425,10 @@ export class CopyPaste extends BasePlugin {
     if (!selectionRange) {
       return;
     }
+    if (selectionRange.isSingleHeader()) {
+      this.copyableRanges = [];
+      return;
+    }
     _classPrivateFieldGet(this, _copyableRangesFactory).setSelectedRange(selectionRange);
     const groupedRanges = new Map([['headers', null], ['cells', null]]);
     if (_classPrivateFieldGet(this, _copyMode) === 'column-headers-only') {
@@ -621,7 +625,7 @@ export class CopyPaste extends BasePlugin {
    * @private
    */
   onPaste(event) {
-    if (!this.hot.isListening() || this.isEditorOpened()) {
+    if (!this.hot.isListening() || this.isEditorOpened() || !this.hot.getSelected()) {
       return;
     }
     if (event && event.preventDefault) {
@@ -646,7 +650,7 @@ export class CopyPaste extends BasePlugin {
     if (typeof pastedData === 'string') {
       pastedData = parse(pastedData);
     }
-    if (pastedData && pastedData.length === 0) {
+    if (pastedData === void 0 || pastedData && pastedData.length === 0) {
       return;
     }
     if (this.hot.runHooks('beforePaste', pastedData, this.copyableRanges) === false) {

package/plugins/customBorders/customBorders.js

@@ -167,14 +167,11 @@ class CustomBorders extends _base.BasePlugin {
     const selectionType = (0, _selection.detectSelectionType)(selectionRanges);
     const selectionSchemaNormalizer = (0, _selection.normalizeSelectionFactory)(selectionType);
     (0, _array.arrayEach)(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          (0, _array.arrayEach)(borderKeys, borderKey => {
-            this.prepareBorderFromCustomAdded(row, col, normBorder, (0, _utils.toInlinePropName)(borderKey));
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        (0, _array.arrayEach)(borderKeys, borderKey => {
+          this.prepareBorderFromCustomAdded(row, col, normBorder, (0, _utils.toInlinePropName)(borderKey));
+        });
+      });
     });
 
     /*
@@ -214,16 +211,13 @@ class CustomBorders extends _base.BasePlugin {
     const selectionSchemaNormalizer = (0, _selection.normalizeSelectionFactory)(selectionType);
     const selectedBorders = [];
     (0, _array.arrayEach)(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          (0, _array.arrayEach)(this.savedBorders, border => {
-            if (border.row === row && border.col === col) {
-              selectedBorders.push((0, _utils.denormalizeBorder)(border));
-            }
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        (0, _array.arrayEach)(this.savedBorders, border => {
+          if (border.row === row && border.col === col) {
+            selectedBorders.push((0, _utils.denormalizeBorder)(border));
+          }
+        });
+      });
     });
     return selectedBorders;
   }
@@ -614,7 +608,8 @@ class CustomBorders extends _base.BasePlugin {
     let check = false;
     (0, _array.arrayEach)(this.hot.selection.highlight.customSelections, customSelection => {
       if (border.id === customSelection.settings.id) {
-        (0, _object.objectEach)(customSelection.instanceBorders, borderObject => {
+        const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+        (0, _array.arrayEach)(borders, borderObject => {
           borderObject.toggleHiddenClass(place, remove); // TODO this also bad?
         });
 
@@ -648,7 +643,8 @@ class CustomBorders extends _base.BasePlugin {
           customSelection.visualCellRange = cellRange;
           customSelection.commit();
           if (place) {
-            (0, _object.objectEach)(customSelection.instanceBorders, borderObject => {
+            const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+            (0, _array.arrayEach)(borders, borderObject => {
               borderObject.changeBorderStyle(place, border);
             });
           }
@@ -716,6 +712,13 @@ class CustomBorders extends _base.BasePlugin {
         return this.getTranslatedPhrase(C.CONTEXTMENU_ITEMS_BORDERS);
       },
       disabled() {
+        const range = this.getSelectedRangeLast();
+        if (!range) {
+          return true;
+        }
+        if (range.isSingleHeader()) {
+          return true;
+        }
         return this.selection.isSelectedByCorner();
       },
       submenu: {

package/plugins/customBorders/customBorders.mjs

@@ -4,7 +4,7 @@ function _defineProperty(obj, key, value) { key = _toPropertyKey(key); if (key i
 function _toPropertyKey(arg) { var key = _toPrimitive(arg, "string"); return typeof key === "symbol" ? key : String(key); }
 function _toPrimitive(input, hint) { if (typeof input !== "object" || input === null) return input; var prim = input[Symbol.toPrimitive]; if (prim !== undefined) { var res = prim.call(input, hint || "default"); if (typeof res !== "object") return res; throw new TypeError("@@toPrimitive must return a primitive value."); } return (hint === "string" ? String : Number)(input); }
 import { BasePlugin } from "../base/index.mjs";
-import { hasOwnProperty, objectEach, deepClone } from "../../helpers/object.mjs";
+import { hasOwnProperty, deepClone } from "../../helpers/object.mjs";
 import { rangeEach } from "../../helpers/number.mjs";
 import { arrayEach, arrayReduce, arrayMap } from "../../helpers/array.mjs";
 import * as C from "../../i18n/constants.mjs";
@@ -160,14 +160,11 @@ export class CustomBorders extends BasePlugin {
     const selectionType = detectSelectionType(selectionRanges);
     const selectionSchemaNormalizer = normalizeSelectionFactory(selectionType);
     arrayEach(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          arrayEach(borderKeys, borderKey => {
-            this.prepareBorderFromCustomAdded(row, col, normBorder, toInlinePropName(borderKey));
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        arrayEach(borderKeys, borderKey => {
+          this.prepareBorderFromCustomAdded(row, col, normBorder, toInlinePropName(borderKey));
+        });
+      });
     });
 
     /*
@@ -207,16 +204,13 @@ export class CustomBorders extends BasePlugin {
     const selectionSchemaNormalizer = normalizeSelectionFactory(selectionType);
     const selectedBorders = [];
     arrayEach(selectionRanges, selection => {
-      const [rowStart, columnStart, rowEnd, columnEnd] = selectionSchemaNormalizer(selection);
-      for (let row = rowStart; row <= rowEnd; row += 1) {
-        for (let col = columnStart; col <= columnEnd; col += 1) {
-          arrayEach(this.savedBorders, border => {
-            if (border.row === row && border.col === col) {
-              selectedBorders.push(denormalizeBorder(border));
-            }
-          });
-        }
-      }
+      selectionSchemaNormalizer(selection).forAll((row, col) => {
+        arrayEach(this.savedBorders, border => {
+          if (border.row === row && border.col === col) {
+            selectedBorders.push(denormalizeBorder(border));
+          }
+        });
+      });
     });
     return selectedBorders;
   }
@@ -607,7 +601,8 @@ export class CustomBorders extends BasePlugin {
     let check = false;
     arrayEach(this.hot.selection.highlight.customSelections, customSelection => {
       if (border.id === customSelection.settings.id) {
-        objectEach(customSelection.instanceBorders, borderObject => {
+        const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+        arrayEach(borders, borderObject => {
           borderObject.toggleHiddenClass(place, remove); // TODO this also bad?
         });
 
@@ -641,7 +636,8 @@ export class CustomBorders extends BasePlugin {
           customSelection.visualCellRange = cellRange;
           customSelection.commit();
           if (place) {
-            objectEach(customSelection.instanceBorders, borderObject => {
+            const borders = this.hot.view._wt.selectionManager.getBorderInstances(customSelection);
+            arrayEach(borders, borderObject => {
               borderObject.changeBorderStyle(place, border);
             });
           }
@@ -709,6 +705,13 @@ export class CustomBorders extends BasePlugin {
         return this.getTranslatedPhrase(C.CONTEXTMENU_ITEMS_BORDERS);
       },
       disabled() {
+        const range = this.getSelectedRangeLast();
+        if (!range) {
+          return true;
+        }
+        if (range.isSingleHeader()) {
+          return true;
+        }
         return this.selection.isSelectedByCorner();
       },
       submenu: {

package/plugins/dropdownMenu/dropdownMenu.d.ts

@@ -18,7 +18,7 @@ export class DropdownMenu extends BasePlugin {
 
   constructor(hotInstance: Core);
   isEnabled(): boolean;
-  open(event: Event): void;
+  open(position: { left: number, top: number } | Event, offset?: { above?: number, below?: number, left?: number, right?: number }): void;
   close(): void;
   executeCommand(commandName: string, ...params: any): void;
 }

package/plugins/dropdownMenu/dropdownMenu.js

@@ -3,7 +3,9 @@
 exports.__esModule = true;
 var _base = require("../base");
 var _array = require("../../helpers/array");
+var _object = require("../../helpers/object");
 var _commandExecutor = _interopRequireDefault(require("../contextMenu/commandExecutor"));
+var _utils = require("../contextMenu/utils");
 var _eventManager = _interopRequireDefault(require("../../eventManager"));
 var _element = require("../../helpers/dom/element");
 var _itemsFactory = _interopRequireDefault(require("../contextMenu/itemsFactory"));
@@ -21,6 +23,7 @@ exports.PLUGIN_KEY = PLUGIN_KEY;
 const PLUGIN_PRIORITY = 230;
 exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
 const BUTTON_CLASS_NAME = 'changeType';
+const SHORTCUTS_GROUP = PLUGIN_KEY;
 
 /* eslint-disable jsdoc/require-description-complete-sentence */
 /**
@@ -157,6 +160,7 @@ class DropdownMenu extends _base.BasePlugin {
     if (typeof settings.callback === 'function') {
       this.commandExecutor.setCommonCallback(settings.callback);
     }
+    this.registerShortcuts();
     super.enablePlugin();
     this.callOnPluginsReady(() => {
       this.hot.runHooks('afterDropdownMenuDefaultOptions', predefinedItems);
@@ -207,9 +211,68 @@ class DropdownMenu extends _base.BasePlugin {
     if (this.menu) {
       this.menu.destroy();
     }
+    this.unregisterShortcuts();
     super.disablePlugin();
   }
 
+  /**
+   * Register shortcuts responsible for toggling dropdown menu.
+   *
+   * @private
+   */
+  registerShortcuts() {
+    const context = this.hot.getShortcutManager().getContext('grid');
+    const callback = () => {
+      const {
+        highlight
+      } = this.hot.getSelectedRangeLast();
+      if ((highlight.isHeader() && highlight.row === -1 || highlight.isCell()) && highlight.col >= 0) {
+        this.hot.selectColumns(highlight.col, highlight.col, -1);
+        const {
+          from
+        } = this.hot.getSelectedRangeLast();
+        const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
+        const target = this.hot.getCell(-1, from.col, true);
+        const rect = target.getBoundingClientRect();
+        this.open({
+          left: rect.left + offset.left,
+          top: rect.top + target.offsetHeight + offset.top
+        }, {
+          left: rect.width
+        });
+        this.hot._registerTimeout(() => {
+          this.menu.selectFirstCell();
+        });
+      }
+    };
+    context.addShortcuts([{
+      keys: [['Shift', 'Alt', 'ArrowDown'], ['Shift', 'Enter']],
+      callback,
+      runOnlyIf: () => {
+        var _this$hot$getSelected;
+        return ((_this$hot$getSelected = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected === void 0 ? void 0 : _this$hot$getSelected.highlight.isHeader()) && !this.menu.isOpened();
+      },
+      group: SHORTCUTS_GROUP
+    }, {
+      keys: [['Shift', 'Alt', 'ArrowDown']],
+      callback,
+      runOnlyIf: () => {
+        var _this$hot$getSelected2;
+        return ((_this$hot$getSelected2 = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected2 === void 0 ? void 0 : _this$hot$getSelected2.highlight.isCell()) && !this.menu.isOpened();
+      },
+      group: SHORTCUTS_GROUP
+    }]);
+  }
+
+  /**
+   * Unregister shortcuts responsible for toggling dropdown menu.
+   *
+   * @private
+   */
+  unregisterShortcuts() {
+    this.hot.getShortcutManager().getContext('grid').removeShortcutsByGroup(SHORTCUTS_GROUP);
+  }
+
   /**
    * Registers the DOM listeners.
    *
@@ -222,23 +285,30 @@ class DropdownMenu extends _base.BasePlugin {
   /**
    * Opens menu and re-position it based on the passed coordinates.
    *
-   * @param {object|Event} position An object with `pageX` and `pageY` properties which contains values relative to
-   *                                the top left of the fully rendered content area in the browser or with `clientX`
-   *                                and `clientY`  properties which contains values relative to the upper left edge
-   *                                of the content area (the viewport) of the browser window. This object is structurally
-   *                                compatible with native mouse event so it can be used either.
+   * @param {{ top: number, left: number }|Event} position An object with `top` and `left` properties
+   * which contains coordinates relative to the browsers viewport (without included scroll offsets).
+   * Or if the native event is passed the menu will be positioned based on the `pageX` and `pageY`
+   * coordinates.
+   * @param {{ above: number, below: number, left: number, right: number }} offset An object allows applying
+   * the offset to the menu position.
    * @fires Hooks#beforeDropdownMenuShow
    * @fires Hooks#afterDropdownMenuShow
    */
-
   open(position) {
-    if (!this.menu) {
+    var _this$menu;
+    let offset = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {
+      above: 0,
+      below: 0,
+      left: 0,
+      right: 0
+    };
+    if ((_this$menu = this.menu) !== null && _this$menu !== void 0 && _this$menu.isOpened()) {
       return;
     }
     this.menu.open();
-    if (position.width) {
-      this.menu.setOffset('left', position.width);
-    }
+    (0, _object.objectEach)(offset, (value, key) => {
+      this.menu.setOffset(key, value);
+    });
     this.menu.setPosition(position);
   }
 
@@ -246,10 +316,8 @@ class DropdownMenu extends _base.BasePlugin {
    * Closes dropdown menu.
    */
   close() {
-    if (!this.menu) {
-      return;
-    }
-    this.menu.close();
+    var _this$menu2;
+    (_this$menu2 = this.menu) === null || _this$menu2 === void 0 ? void 0 : _this$menu2.close();
   }
 
   /**
@@ -314,26 +382,14 @@ class DropdownMenu extends _base.BasePlugin {
    */
   onTableClick(event) {
     event.stopPropagation();
-    if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME) && !this.menu.isOpened()) {
-      let offsetTop = 0;
-      let offsetLeft = 0;
-      if (this.hot.rootDocument !== this.menu.container.ownerDocument) {
-        const {
-          frameElement
-        } = this.hot.rootWindow;
-        const {
-          top,
-          left
-        } = frameElement.getBoundingClientRect();
-        offsetTop = top;
-        offsetLeft = left;
-      }
+    if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME)) {
+      const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
       const rect = event.target.getBoundingClientRect();
       this.open({
-        left: rect.left + offsetLeft,
-        top: rect.top + event.target.offsetHeight + 3 + offsetTop,
-        width: rect.width,
-        height: rect.height
+        left: rect.left + offset.left,
+        top: rect.top + event.target.offsetHeight + 3 + offset.top
+      }, {
+        left: rect.width
       });
     }
   }
@@ -372,6 +428,7 @@ class DropdownMenu extends _base.BasePlugin {
     const button = this.hot.rootDocument.createElement('button');
     button.className = BUTTON_CLASS_NAME;
     button.type = 'button';
+    button.tabIndex = -1;
 
     // prevent page reload on button click
     button.onclick = function () {