handsontable 0.0.0-next-a2cc849-20240208 → 0.0.0-next-fd66c90-20240209

package/plugins/nestedRows/nestedRows.mjs

@@ -20,7 +20,6 @@ import ContextMenuUI from "./ui/contextMenu.mjs";
 import { error } from "../../helpers/console.mjs";
 import { isArrayOfObjects } from "../../helpers/data.mjs";
 import { TrimmingMap } from "../../translations/index.mjs";
-import { EDITOR_EDIT_GROUP as SHORTCUTS_GROUP_EDITOR } from "../../shortcutContexts/index.mjs";
 import RowMoveController from "./utils/rowMoveController.mjs";
 export const PLUGIN_KEY = 'nestedRows';
 export const PLUGIN_PRIORITY = 300;
@@ -397,18 +396,13 @@ export class NestedRows extends BasePlugin {
             this.collapsingUI.collapseChildren(row);
           }
         }
-
-        // prevent default Enter behavior (move to the next row within a selection range)
-        return false;
       },
       runOnlyIf: () => {
         var _this$hot$getSelected;
         const highlight = (_this$hot$getSelected = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected === void 0 ? void 0 : _this$hot$getSelected.highlight;
         return highlight && this.hot.selection.isCellVisible(highlight) && highlight.isHeader();
       },
-      group: SHORTCUTS_GROUP,
-      relativeToGroup: SHORTCUTS_GROUP_EDITOR,
-      position: 'before'
+      group: SHORTCUTS_GROUP
     });
   }
 

package/renderers/checkboxRenderer/checkboxRenderer.js

@@ -139,9 +139,7 @@ function checkboxRenderer(hotInstance, TD, row, col, prop, value, cellProperties
     const shortcutManager = hotInstance.getShortcutManager();
     const gridContext = shortcutManager.getContext('grid');
     const config = {
-      group: SHORTCUTS_GROUP,
-      relativeToGroup: _shortcutContexts.EDITOR_EDIT_GROUP,
-      position: 'before'
+      group: SHORTCUTS_GROUP
     };
     gridContext.addShortcuts([{
       keys: [['space']],
@@ -161,7 +159,9 @@ function checkboxRenderer(hotInstance, TD, row, col, prop, value, cellProperties
       callback: () => {
         changeSelectedCheckboxesState(true);
         return !areSelectedCheckboxCells(); // False blocks next action associated with the keyboard shortcut.
-      }
+      },
+      relativeToGroup: _shortcutContexts.EDITOR_EDIT_GROUP,
+      position: 'before'
     }], config);
   }
 

package/renderers/checkboxRenderer/checkboxRenderer.mjs

@@ -134,9 +134,7 @@ export function checkboxRenderer(hotInstance, TD, row, col, prop, value, cellPro
     const shortcutManager = hotInstance.getShortcutManager();
     const gridContext = shortcutManager.getContext('grid');
     const config = {
-      group: SHORTCUTS_GROUP,
-      relativeToGroup: SHORTCUTS_GROUP_EDITOR,
-      position: 'before'
+      group: SHORTCUTS_GROUP
     };
     gridContext.addShortcuts([{
       keys: [['space']],
@@ -156,7 +154,9 @@ export function checkboxRenderer(hotInstance, TD, row, col, prop, value, cellPro
       callback: () => {
         changeSelectedCheckboxesState(true);
         return !areSelectedCheckboxCells(); // False blocks next action associated with the keyboard shortcut.
-      }
+      },
+      relativeToGroup: SHORTCUTS_GROUP_EDITOR,
+      position: 'before'
     }], config);
   }
 

package/selection/selection.js

@@ -9,7 +9,7 @@ var _mixed = require("./../helpers/mixed");
 var _number = require("./../helpers/number");
 var _array = require("./../helpers/array");
 var _localHooks = _interopRequireDefault(require("./../mixins/localHooks"));
-var _transformation2 = _interopRequireDefault(require("./transformation"));
+var _transformation = _interopRequireDefault(require("./transformation"));
 var _utils = require("./utils");
 var _templateLiteralTag = require("./../helpers/templateLiteralTag");
 var _a11y = require("../helpers/a11y");
@@ -30,9 +30,6 @@ function _classApplyDescriptorSet(receiver, descriptor, value) { if (descriptor.
  * @class Selection
  * @util
  */
-var _transformation = /*#__PURE__*/new WeakMap();
-var _focusTransformation = /*#__PURE__*/new WeakMap();
-var _isFocusSelectionChanged = /*#__PURE__*/new WeakMap();
 var _disableHeadersHighlight = /*#__PURE__*/new WeakMap();
 var _selectionSource = /*#__PURE__*/new WeakMap();
 var _expectedLayersCount = /*#__PURE__*/new WeakMap();
@@ -72,23 +69,11 @@ class Selection {
      */
     _defineProperty(this, "highlight", void 0);
     /**
-     * The module for modifying coordinates of the start and end selection.
+     * The module for modifying coordinates.
      *
      * @type {Transformation}
      */
-    _classPrivateFieldInitSpec(this, _transformation, {
-      writable: true,
-      value: void 0
-    });
-    /**
-     * The module for modifying coordinates of the focus selection.
-     *
-     * @type {Transformation}
-     */
-    _classPrivateFieldInitSpec(this, _focusTransformation, {
-      writable: true,
-      value: void 0
-    });
+    _defineProperty(this, "transformation", void 0);
     /**
      * The collection of the selection layer levels where the whole row was selected using the row header or
      * the corner header.
@@ -103,15 +88,6 @@ class Selection {
      * @type {Set<number>}
      */
     _defineProperty(this, "selectedByColumnHeader", new Set());
-    /**
-     * The flag which determines if the focus selection was changed.
-     *
-     * @type {boolean}
-     */
-    _classPrivateFieldInitSpec(this, _isFocusSelectionChanged, {
-      writable: true,
-      value: false
-    });
     /**
      * When sets disable highlighting the headers even when the logical coordinates points on them.
      *
@@ -162,100 +138,71 @@ class Selection {
       createCellCoords: (row, column) => this.tableProps.createCellCoords(row, column),
       createCellRange: (highlight, from, to) => this.tableProps.createCellRange(highlight, from, to)
     });
-    _classPrivateFieldSet(this, _transformation, new _transformation2.default(this.selectedRange, {
+    this.transformation = new _transformation.default(this.selectedRange, {
       rowIndexMapper: this.tableProps.rowIndexMapper,
       columnIndexMapper: this.tableProps.columnIndexMapper,
       countRenderableRows: () => this.tableProps.countRenderableRows(),
       countRenderableColumns: () => this.tableProps.countRenderableColumns(),
+      countRowHeaders: () => this.tableProps.countRowHeaders(),
+      countColHeaders: () => this.tableProps.countColHeaders(),
       visualToRenderableCoords: coords => this.tableProps.visualToRenderableCoords(coords),
       renderableToVisualCoords: coords => this.tableProps.renderableToVisualCoords(coords),
       createCellCoords: (row, column) => this.tableProps.createCellCoords(row, column),
+      navigableHeaders: () => settings.navigableHeaders,
       fixedRowsBottom: () => settings.fixedRowsBottom,
       minSpareRows: () => settings.minSpareRows,
       minSpareCols: () => settings.minSpareCols,
       autoWrapRow: () => settings.autoWrapRow,
       autoWrapCol: () => settings.autoWrapCol
-    }));
-    _classPrivateFieldSet(this, _focusTransformation, new _transformation2.default(this.selectedRange, {
-      rowIndexMapper: this.tableProps.rowIndexMapper,
-      columnIndexMapper: this.tableProps.columnIndexMapper,
-      countRenderableRows: () => {
-        const range = this.selectedRange.current();
-        return this.tableProps.countRenderableRowsInRange(0, range.getOuterBottomEndCorner().row);
-      },
-      countRenderableColumns: () => {
-        const range = this.selectedRange.current();
-        return this.tableProps.countRenderableColumnsInRange(0, range.getOuterBottomEndCorner().col);
-      },
-      visualToRenderableCoords: coords => this.tableProps.visualToRenderableCoords(coords),
-      renderableToVisualCoords: coords => this.tableProps.renderableToVisualCoords(coords),
-      createCellCoords: (row, column) => this.tableProps.createCellCoords(row, column),
-      fixedRowsBottom: () => 0,
-      minSpareRows: () => 0,
-      minSpareCols: () => 0,
-      autoWrapRow: () => true,
-      autoWrapCol: () => true
-    }));
-    _classPrivateFieldGet(this, _transformation).addLocalHook('beforeTransformStart', function () {
+    });
+    this.transformation.addLocalHook('beforeTransformStart', function () {
       for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
         args[_key] = arguments[_key];
       }
       return _this.runLocalHooks('beforeModifyTransformStart', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('afterTransformStart', function () {
+    this.transformation.addLocalHook('afterTransformStart', function () {
       for (var _len2 = arguments.length, args = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
         args[_key2] = arguments[_key2];
       }
       return _this.runLocalHooks('afterModifyTransformStart', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('beforeTransformEnd', function () {
+    this.transformation.addLocalHook('beforeTransformEnd', function () {
       for (var _len3 = arguments.length, args = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
         args[_key3] = arguments[_key3];
       }
       return _this.runLocalHooks('beforeModifyTransformEnd', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('afterTransformEnd', function () {
+    this.transformation.addLocalHook('afterTransformEnd', function () {
       for (var _len4 = arguments.length, args = new Array(_len4), _key4 = 0; _key4 < _len4; _key4++) {
         args[_key4] = arguments[_key4];
       }
       return _this.runLocalHooks('afterModifyTransformEnd', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('insertRowRequire', function () {
+    this.transformation.addLocalHook('insertRowRequire', function () {
       for (var _len5 = arguments.length, args = new Array(_len5), _key5 = 0; _key5 < _len5; _key5++) {
         args[_key5] = arguments[_key5];
       }
       return _this.runLocalHooks('insertRowRequire', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('insertColRequire', function () {
+    this.transformation.addLocalHook('insertColRequire', function () {
       for (var _len6 = arguments.length, args = new Array(_len6), _key6 = 0; _key6 < _len6; _key6++) {
         args[_key6] = arguments[_key6];
       }
       return _this.runLocalHooks('insertColRequire', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('beforeRowWrap', function () {
+    this.transformation.addLocalHook('beforeRowWrap', function () {
       for (var _len7 = arguments.length, args = new Array(_len7), _key7 = 0; _key7 < _len7; _key7++) {
         args[_key7] = arguments[_key7];
       }
       return _this.runLocalHooks('beforeRowWrap', ...args);
     });
-    _classPrivateFieldGet(this, _transformation).addLocalHook('beforeColumnWrap', function () {
+    this.transformation.addLocalHook('beforeColumnWrap', function () {
       for (var _len8 = arguments.length, args = new Array(_len8), _key8 = 0; _key8 < _len8; _key8++) {
         args[_key8] = arguments[_key8];
       }
       return _this.runLocalHooks('beforeColumnWrap', ...args);
     });
-    _classPrivateFieldGet(this, _focusTransformation).addLocalHook('beforeTransformStart', function () {
-      for (var _len9 = arguments.length, args = new Array(_len9), _key9 = 0; _key9 < _len9; _key9++) {
-        args[_key9] = arguments[_key9];
-      }
-      return _this.runLocalHooks('beforeModifyTransformStart', ...args);
-    });
-    _classPrivateFieldGet(this, _focusTransformation).addLocalHook('afterTransformStart', function () {
-      for (var _len10 = arguments.length, args = new Array(_len10), _key10 = 0; _key10 < _len10; _key10++) {
-        args[_key10] = arguments[_key10];
-      }
-      return _this.runLocalHooks('afterModifyTransformStart', ...args);
-    });
   }
 
   /**
@@ -346,7 +293,6 @@ class Selection {
     // We are creating copy. We would like to modify just the start of the selection by below hook. Then original coords
     // should be handled by next methods.
     const coordsClone = coords.clone();
-    _classPrivateFieldSet(this, _isFocusSelectionChanged, false);
     this.runLocalHooks(`beforeSetRangeStart${fragment ? 'Only' : ''}`, coordsClone);
     if (!isMultipleMode || isMultipleMode && !isMultipleSelection && (0, _mixed.isUndefined)(multipleSelection)) {
       this.selectedRange.clear();
@@ -414,7 +360,11 @@ class Selection {
       }
     }
     this.runLocalHooks('beforeHighlightSet');
-    this.setRangeFocus(this.selectedRange.current().highlight);
+    const focusHighlight = this.highlight.getFocus();
+    focusHighlight.clear();
+    if (this.highlight.isEnabledFor(_highlight.FOCUS_TYPE, cellRange.highlight)) {
+      focusHighlight.add(this.selectedRange.current().highlight).commit().syncWith(cellRange);
+    }
     const layerLevel = this.getLayerLevel();
 
     // If the next layer level is lower than previous then clear all area and header highlights. This is the
@@ -502,24 +452,15 @@ class Selection {
   }
 
   /**
-   * Sets the selection focus position at the specified coordinates.
+   * Returns information if we have a multiselection. This method check multiselection only on the latest layer of
+   * the selection.
    *
-   * @param {CellCoords} coords The CellCoords instance with defined visual coordinates.
+   * @returns {boolean}
    */
-  setRangeFocus(coords) {
-    if (this.selectedRange.isEmpty()) {
-      return;
-    }
-    const cellRange = this.selectedRange.current();
-    const focusHighlight = this.highlight.getFocus();
-    focusHighlight.clear();
-    if (this.highlight.isEnabledFor(_highlight.FOCUS_TYPE, cellRange.highlight)) {
-      focusHighlight.add(coords).commit().syncWith(cellRange);
-    }
-    if (!this.inProgress) {
-      _classPrivateFieldSet(this, _isFocusSelectionChanged, true);
-      this.runLocalHooks('afterSetFocus', coords);
-    }
+  isMultiple() {
+    const isMultipleListener = (0, _object.createObjectPropListener)(!this.selectedRange.current().isSingle());
+    this.runLocalHooks('afterIsMultipleSelection', isMultipleListener);
+    return isMultipleListener.value;
   }
 
   /**
@@ -532,13 +473,7 @@ class Selection {
    */
   transformStart(rowDelta, colDelta) {
     let createMissingRecords = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : false;
-    if (this.settings.navigableHeaders) {
-      _classPrivateFieldGet(this, _transformation).setOffsetSize({
-        x: this.tableProps.countRowHeaders(),
-        y: this.tableProps.countColHeaders()
-      });
-    }
-    this.setRangeStart(_classPrivateFieldGet(this, _transformation).transformStart(rowDelta, colDelta, createMissingRecords));
+    this.setRangeStart(this.transformation.transformStart(rowDelta, colDelta, createMissingRecords));
   }
 
   /**
@@ -548,44 +483,7 @@ class Selection {
    * @param {number} colDelta Columns number to move, value can be passed as negative number.
    */
   transformEnd(rowDelta, colDelta) {
-    if (this.settings.navigableHeaders) {
-      _classPrivateFieldGet(this, _transformation).setOffsetSize({
-        x: this.tableProps.countRowHeaders(),
-        y: this.tableProps.countColHeaders()
-      });
-    }
-    this.setRangeEnd(_classPrivateFieldGet(this, _transformation).transformEnd(rowDelta, colDelta));
-  }
-
-  /**
-   * Transforms the focus cell selection relative to the current focus position.
-   *
-   * @param {number} rowDelta Rows number to move, value can be passed as negative number.
-   * @param {number} colDelta Columns number to move, value can be passed as negative number.
-   */
-  transformFocus(rowDelta, colDelta) {
-    const range = this.selectedRange.current();
-    const {
-      row,
-      col
-    } = range.getOuterTopStartCorner();
-    const columnsInRange = this.tableProps.countRenderableColumnsInRange(0, col - 1);
-    const rowsInRange = this.tableProps.countRenderableRowsInRange(0, row - 1);
-    if (range.highlight.isHeader()) {
-      // for header focus selection calculate the new coords based on the selection including headers
-      _classPrivateFieldGet(this, _focusTransformation).setOffsetSize({
-        x: col < 0 ? Math.abs(col) : -columnsInRange,
-        y: row < 0 ? Math.abs(row) : -rowsInRange
-      });
-    } else {
-      // for focus selection in cells calculate the new coords only based on the selected cells
-      _classPrivateFieldGet(this, _focusTransformation).setOffsetSize({
-        x: col < 0 ? 0 : -columnsInRange,
-        y: row < 0 ? 0 : -rowsInRange
-      });
-    }
-    const focusCoords = _classPrivateFieldGet(this, _focusTransformation).transformStart(rowDelta, colDelta);
-    this.setRangeFocus(focusCoords.normalize());
+    this.setRangeEnd(this.transformation.transformEnd(rowDelta, colDelta));
   }
 
   /**
@@ -606,30 +504,6 @@ class Selection {
     return !this.selectedRange.isEmpty();
   }
 
-  /**
-   * Returns information if we have a multi-selection. This method check multi-selection only on the latest layer of
-   * the selection.
-   *
-   * @returns {boolean}
-   */
-  isMultiple() {
-    if (!this.isSelected()) {
-      return false;
-    }
-    const isMultipleListener = (0, _object.createObjectPropListener)(!this.selectedRange.current().isSingle());
-    this.runLocalHooks('afterIsMultipleSelection', isMultipleListener);
-    return isMultipleListener.value;
-  }
-
-  /**
-   * Checks if the last selection involves changing the focus cell position only.
-   *
-   * @returns {boolean}
-   */
-  isFocusSelectionChanged() {
-    return this.isSelected() && _classPrivateFieldGet(this, _isFocusSelectionChanged);
-  }
-
   /**
    * Returns `true` if the selection was applied by clicking to the row header. If the `layerLevel`
    * argument is passed then only that layer will be checked. Otherwise, it checks if any row header