handsontable 0.0.0-next-9379dd1-20231020 → 0.0.0-next-9059914-20231025

package/editorManager.js

@@ -3,12 +3,15 @@
 exports.__esModule = true;
 var _unicode = require("./helpers/unicode");
 var _event = require("./helpers/dom/event");
+var _element = require("./helpers/dom/element");
 var _registry = require("./editors/registry");
 var _eventManager = _interopRequireDefault(require("./eventManager"));
 var _mixed = require("./helpers/mixed");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 const SHORTCUTS_GROUP_NAVIGATION = 'editorManager.navigation';
 exports.SHORTCUTS_GROUP_NAVIGATION = SHORTCUTS_GROUP_NAVIGATION;
+const SHORTCUTS_GROUP_EDITOR = 'editorManager.handlingEditor';
+exports.SHORTCUTS_GROUP_EDITOR = SHORTCUTS_GROUP_EDITOR;
 class EditorManager {
   /**
    * @param {Core} instance The Handsontable instance.
@@ -71,6 +74,9 @@ class EditorManager {
      * @type {object}
      */
     this.cellProperties = void 0;
+    const shortcutManager = this.instance.getShortcutManager();
+    shortcutManager.addContext('editor');
+    this.registerShortcuts();
     this.instance.addHook('afterDocumentKeyDown', event => this.onAfterDocumentKeyDown(event));
 
     // Open editor when text composition is started (IME editor)
@@ -82,6 +88,62 @@ class EditorManager {
     this.instance.view._wt.update('onCellDblClick', (event, coords, elem) => this.onCellDblClick(event, coords, elem));
   }
 
+  /**
+   * Register shortcuts responsible for handling some actions related to an editor.
+   *
+   * @private
+   */
+  registerShortcuts() {
+    const shortcutManager = this.instance.getShortcutManager();
+    const gridContext = shortcutManager.getContext('grid');
+    const editorContext = shortcutManager.getContext('editor');
+    const config = {
+      group: SHORTCUTS_GROUP_EDITOR
+    };
+    editorContext.addShortcuts([{
+      keys: [['Enter'], ['Enter', 'Shift'], ['Enter', 'Control/Meta'], ['Enter', 'Control/Meta', 'Shift']],
+      callback: (event, keys) => {
+        this.closeEditorAndSaveChanges(shortcutManager.isCtrlPressed());
+        this.moveSelectionAfterEnter(keys.includes('shift'));
+      }
+    }, {
+      keys: [['Escape'], ['Escape', 'Control/Meta']],
+      callback: () => {
+        this.closeEditorAndRestoreOriginalValue(shortcutManager.isCtrlPressed());
+        this.activeEditor.focus();
+      }
+    }], config);
+    gridContext.addShortcuts([{
+      keys: [['F2']],
+      callback: event => {
+        this.openEditor(null, event, true);
+      }
+    }, {
+      keys: [['Backspace'], ['Delete']],
+      callback: () => {
+        this.instance.emptySelectedCells();
+        this.prepareEditor();
+      }
+    }, {
+      keys: [['Enter'], ['Enter', 'Shift']],
+      callback: (event, keys) => {
+        if (this.instance.getSettings().enterBeginsEditing) {
+          if (this.cellProperties.readOnly) {
+            this.moveSelectionAfterEnter();
+          } else {
+            this.openEditor(null, event, true);
+          }
+        } else {
+          this.moveSelectionAfterEnter(keys.includes('shift'));
+        }
+        (0, _event.stopImmediatePropagation)(event); // required by HandsontableEditor
+      }
+    }], {
+      ...config,
+      runOnlyIf: () => (0, _mixed.isDefined)(this.instance.getSelected())
+    });
+  }
+
   /**
    * Lock the editor from being prepared and closed. Locking the editor prevents its closing and
    * reinitialized after selecting the new cell. This feature is necessary for a mobile editor.
@@ -134,16 +196,10 @@ class EditorManager {
       });
       return;
     }
-    const {
-      highlight
-    } = this.instance.getSelectedRangeLast();
-    if (highlight.isHeader()) {
-      return;
-    }
     const {
       row,
       col
-    } = highlight;
+    } = this.instance.getSelectedRangeLast().highlight;
     const modifiedCellCoords = this.instance.runHooks('modifyGetCellCoords', row, col);
     let visualRowToCheck = row;
     let visualColumnToCheck = col;
@@ -153,6 +209,17 @@ class EditorManager {
 
     // Getting values using the modified coordinates.
     this.cellProperties = this.instance.getCellMeta(visualRowToCheck, visualColumnToCheck);
+    const {
+      activeElement
+    } = this.instance.rootDocument;
+
+    // Blurring the `activeElement` removes the unwanted border around the focusable element (#6877)
+    // and resets the `document.activeElement` property. The blurring should happen only when the
+    // previously selected input element has not belonged to the Handsontable editor. If blurring is
+    // triggered for all elements, there is a problem with the disappearing IME editor (#9672).
+    if (activeElement && (0, _element.isOutsideInput)(activeElement)) {
+      activeElement.blur();
+    }
     if (!this.isCellEditable()) {
       this.clearActiveEditor();
       return;
@@ -196,7 +263,14 @@ class EditorManager {
       return;
     }
     if (!this.activeEditor) {
-      this.instance.scrollToFocusedCell();
+      const {
+        row,
+        col
+      } = this.instance.getSelectedRangeLast().highlight;
+      const renderableRowIndex = this.instance.rowIndexMapper.getRenderableFromVisualIndex(row);
+      const renderableColumnIndex = this.instance.columnIndexMapper.getRenderableFromVisualIndex(col);
+      this.instance.view.scrollViewport(this.instance._createCellCoords(renderableRowIndex, renderableColumnIndex));
+      this.instance.view.render();
       this.prepareEditor();
     }
     if (this.activeEditor) {
@@ -260,15 +334,11 @@ class EditorManager {
    * @returns {boolean}
    */
   isCellEditable() {
-    const selection = this.instance.getSelectedRangeLast();
-    if (!selection) {
-      return false;
-    }
     const editorClass = this.instance.getCellEditor(this.cellProperties);
     const {
       row,
       col
-    } = selection.highlight;
+    } = this.instance.getSelectedRangeLast().highlight;
     const {
       rowIndexMapper,
       columnIndexMapper
@@ -304,13 +374,15 @@ class EditorManager {
    * @param {KeyboardEvent} event The keyboard event object.
    */
   onAfterDocumentKeyDown(event) {
-    const selection = this.instance.getSelectedRangeLast();
-    if (!this.instance.isListening() || !selection || selection.highlight.isHeader() || (0, _event.isImmediatePropagationStopped)(event)) {
+    if (!this.instance.isListening()) {
       return;
     }
     const {
       keyCode
     } = event;
+    if (!this.selection.isSelected()) {
+      return;
+    }
 
     // catch CTRL but not right ALT (which in some systems triggers ALT+CTRL)
     const isCtrlPressed = (event.ctrlKey || event.metaKey) && !event.altKey;

package/editorManager.mjs

@@ -1,9 +1,11 @@
 import { isFunctionKey, isCtrlMetaKey } from "./helpers/unicode.mjs";
-import { isImmediatePropagationStopped } from "./helpers/dom/event.mjs";
+import { stopImmediatePropagation } from "./helpers/dom/event.mjs";
+import { isOutsideInput } from "./helpers/dom/element.mjs";
 import { getEditorInstance } from "./editors/registry.mjs";
 import EventManager from "./eventManager.mjs";
 import { isDefined } from "./helpers/mixed.mjs";
 export const SHORTCUTS_GROUP_NAVIGATION = 'editorManager.navigation';
+export const SHORTCUTS_GROUP_EDITOR = 'editorManager.handlingEditor';
 class EditorManager {
   /**
    * @param {Core} instance The Handsontable instance.
@@ -66,6 +68,9 @@ class EditorManager {
      * @type {object}
      */
     this.cellProperties = void 0;
+    const shortcutManager = this.instance.getShortcutManager();
+    shortcutManager.addContext('editor');
+    this.registerShortcuts();
     this.instance.addHook('afterDocumentKeyDown', event => this.onAfterDocumentKeyDown(event));
 
     // Open editor when text composition is started (IME editor)
@@ -77,6 +82,62 @@ class EditorManager {
     this.instance.view._wt.update('onCellDblClick', (event, coords, elem) => this.onCellDblClick(event, coords, elem));
   }
 
+  /**
+   * Register shortcuts responsible for handling some actions related to an editor.
+   *
+   * @private
+   */
+  registerShortcuts() {
+    const shortcutManager = this.instance.getShortcutManager();
+    const gridContext = shortcutManager.getContext('grid');
+    const editorContext = shortcutManager.getContext('editor');
+    const config = {
+      group: SHORTCUTS_GROUP_EDITOR
+    };
+    editorContext.addShortcuts([{
+      keys: [['Enter'], ['Enter', 'Shift'], ['Enter', 'Control/Meta'], ['Enter', 'Control/Meta', 'Shift']],
+      callback: (event, keys) => {
+        this.closeEditorAndSaveChanges(shortcutManager.isCtrlPressed());
+        this.moveSelectionAfterEnter(keys.includes('shift'));
+      }
+    }, {
+      keys: [['Escape'], ['Escape', 'Control/Meta']],
+      callback: () => {
+        this.closeEditorAndRestoreOriginalValue(shortcutManager.isCtrlPressed());
+        this.activeEditor.focus();
+      }
+    }], config);
+    gridContext.addShortcuts([{
+      keys: [['F2']],
+      callback: event => {
+        this.openEditor(null, event, true);
+      }
+    }, {
+      keys: [['Backspace'], ['Delete']],
+      callback: () => {
+        this.instance.emptySelectedCells();
+        this.prepareEditor();
+      }
+    }, {
+      keys: [['Enter'], ['Enter', 'Shift']],
+      callback: (event, keys) => {
+        if (this.instance.getSettings().enterBeginsEditing) {
+          if (this.cellProperties.readOnly) {
+            this.moveSelectionAfterEnter();
+          } else {
+            this.openEditor(null, event, true);
+          }
+        } else {
+          this.moveSelectionAfterEnter(keys.includes('shift'));
+        }
+        stopImmediatePropagation(event); // required by HandsontableEditor
+      }
+    }], {
+      ...config,
+      runOnlyIf: () => isDefined(this.instance.getSelected())
+    });
+  }
+
   /**
    * Lock the editor from being prepared and closed. Locking the editor prevents its closing and
    * reinitialized after selecting the new cell. This feature is necessary for a mobile editor.
@@ -129,16 +190,10 @@ class EditorManager {
       });
       return;
     }
-    const {
-      highlight
-    } = this.instance.getSelectedRangeLast();
-    if (highlight.isHeader()) {
-      return;
-    }
     const {
       row,
       col
-    } = highlight;
+    } = this.instance.getSelectedRangeLast().highlight;
     const modifiedCellCoords = this.instance.runHooks('modifyGetCellCoords', row, col);
     let visualRowToCheck = row;
     let visualColumnToCheck = col;
@@ -148,6 +203,17 @@ class EditorManager {
 
     // Getting values using the modified coordinates.
     this.cellProperties = this.instance.getCellMeta(visualRowToCheck, visualColumnToCheck);
+    const {
+      activeElement
+    } = this.instance.rootDocument;
+
+    // Blurring the `activeElement` removes the unwanted border around the focusable element (#6877)
+    // and resets the `document.activeElement` property. The blurring should happen only when the
+    // previously selected input element has not belonged to the Handsontable editor. If blurring is
+    // triggered for all elements, there is a problem with the disappearing IME editor (#9672).
+    if (activeElement && isOutsideInput(activeElement)) {
+      activeElement.blur();
+    }
     if (!this.isCellEditable()) {
       this.clearActiveEditor();
       return;
@@ -191,7 +257,14 @@ class EditorManager {
       return;
     }
     if (!this.activeEditor) {
-      this.instance.scrollToFocusedCell();
+      const {
+        row,
+        col
+      } = this.instance.getSelectedRangeLast().highlight;
+      const renderableRowIndex = this.instance.rowIndexMapper.getRenderableFromVisualIndex(row);
+      const renderableColumnIndex = this.instance.columnIndexMapper.getRenderableFromVisualIndex(col);
+      this.instance.view.scrollViewport(this.instance._createCellCoords(renderableRowIndex, renderableColumnIndex));
+      this.instance.view.render();
       this.prepareEditor();
     }
     if (this.activeEditor) {
@@ -255,15 +328,11 @@ class EditorManager {
    * @returns {boolean}
    */
   isCellEditable() {
-    const selection = this.instance.getSelectedRangeLast();
-    if (!selection) {
-      return false;
-    }
     const editorClass = this.instance.getCellEditor(this.cellProperties);
     const {
       row,
       col
-    } = selection.highlight;
+    } = this.instance.getSelectedRangeLast().highlight;
     const {
       rowIndexMapper,
       columnIndexMapper
@@ -299,13 +368,15 @@ class EditorManager {
    * @param {KeyboardEvent} event The keyboard event object.
    */
   onAfterDocumentKeyDown(event) {
-    const selection = this.instance.getSelectedRangeLast();
-    if (!this.instance.isListening() || !selection || selection.highlight.isHeader() || isImmediatePropagationStopped(event)) {
+    if (!this.instance.isListening()) {
       return;
     }
     const {
       keyCode
     } = event;
+    if (!this.selection.isSelected()) {
+      return;
+    }
 
     // catch CTRL but not right ALT (which in some systems triggers ALT+CTRL)
     const isCtrlPressed = (event.ctrlKey || event.metaKey) && !event.altKey;

package/editors/autocompleteEditor/autocompleteEditor.js

@@ -10,7 +10,6 @@ var _mixed = require("../../helpers/mixed");
 var _string = require("../../helpers/string");
 var _unicode = require("../../helpers/unicode");
 var _textRenderer = require("../../renderers/textRenderer");
-var _a11y = require("../../helpers/a11y");
 function _defineProperty(obj, key, value) { key = _toPropertyKey(key); if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 function _toPropertyKey(arg) { var key = _toPrimitive(arg, "string"); return typeof key === "symbol" ? key : String(key); }
 function _toPrimitive(input, hint) { if (typeof input !== "object" || input === null) return input; var prim = input[Symbol.toPrimitive]; if (prim !== undefined) { var res = prim.call(input, hint || "default"); if (typeof res !== "object") return res; throw new TypeError("@@toPrimitive must return a primitive value."); } return (hint === "string" ? String : Number)(input); }
@@ -114,8 +113,7 @@ class AutocompleteEditor extends _handsontableEditor.HandsontableEditor {
     this.rawChoices = [];
     privatePool.set(this, {
       skipOne: false,
-      isMacOS: this.hot.rootWindow.navigator.platform.indexOf('Mac') > -1,
-      idPrefix: instance.guid.slice(0, 9)
+      isMacOS: this.hot.rootWindow.navigator.platform.indexOf('Mac') > -1
     });
   }
 
@@ -142,27 +140,6 @@ class AutocompleteEditor extends _handsontableEditor.HandsontableEditor {
     super.createElements();
     (0, _element.addClass)(this.htContainer, 'autocompleteEditor');
     (0, _element.addClass)(this.htContainer, this.hot.rootWindow.navigator.platform.indexOf('Mac') === -1 ? '' : 'htMacScroll');
-    if (this.hot.getSettings().ariaTags) {
-      (0, _element.setAttribute)(this.TEXTAREA, [(0, _a11y.A11Y_TEXT)(), (0, _a11y.A11Y_COMBOBOX)(), (0, _a11y.A11Y_HASPOPUP)('listbox'), (0, _a11y.A11Y_AUTOCOMPLETE)()]);
-    }
-  }
-
-  /**
-   * Prepares editor's metadata and configuration of the internal Handsontable's instance.
-   *
-   * @param {number} row The visual row index.
-   * @param {number} col The visual column index.
-   * @param {number|string} prop The column property (passed when datasource is an array of objects).
-   * @param {HTMLTableCellElement} td The rendered cell element.
-   * @param {*} value The rendered value.
-   * @param {object} cellProperties The cell meta object ({@see Core#getCellMeta}).
-   */
-  prepare(row, col, prop, td, value, cellProperties) {
-    const priv = privatePool.get(this);
-    super.prepare(row, col, prop, td, value, cellProperties);
-    if (this.hot.getSettings().ariaTags) {
-      (0, _element.setAttribute)(this.TEXTAREA, [(0, _a11y.A11Y_EXPANDED)('false'), (0, _a11y.A11Y_CONTROLS)(`${priv.idPrefix}-listbox-${row}-${col}`)]);
-    }
   }
 
   /**
@@ -172,13 +149,6 @@ class AutocompleteEditor extends _handsontableEditor.HandsontableEditor {
     const priv = privatePool.get(this);
     super.open();
     const trimDropdown = this.cellProperties.trimDropdown === void 0 ? true : this.cellProperties.trimDropdown;
-    const rootInstanceAriaTagsEnabled = this.hot.getSettings().ariaTags;
-    const sourceArray = Array.isArray(this.cellProperties.source) ? this.cellProperties.source : null;
-    const sourceSize = sourceArray === null || sourceArray === void 0 ? void 0 : sourceArray.length;
-    const {
-      row: rowIndex,
-      col: colIndex
-    } = this;
     this.showEditableElement();
     this.focus();
     let scrollbarWidth = (0, _element.getScrollbarWidth)();
@@ -190,7 +160,6 @@ class AutocompleteEditor extends _handsontableEditor.HandsontableEditor {
     this.htEditor.updateSettings({
       colWidths: trimDropdown ? [(0, _element.outerWidth)(this.TEXTAREA) - 2] : void 0,
       width: trimDropdown ? (0, _element.outerWidth)(this.TEXTAREA) + scrollbarWidth : void 0,
-      autoColumnSize: true,
       renderer: (instance, TD, row, col, prop, value, cellProperties) => {
         (0, _textRenderer.textRenderer)(instance, TD, row, col, prop, value, cellProperties);
         const {
@@ -209,27 +178,10 @@ class AutocompleteEditor extends _handsontableEditor.HandsontableEditor {
             cellValue = cellValue.replace(match, `<strong>${match}</strong>`);
           }
         }
-        if (rootInstanceAriaTagsEnabled) {
-          (0, _element.setAttribute)(TD, [(0, _a11y.A11Y_OPTION)(),
-          // Add `setsize` and `posinset` only if the source is an array.
-          ...(sourceArray ? [(0, _a11y.A11Y_SETSIZE)(sourceSize)] : []), ...(sourceArray ? [(0, _a11y.A11Y_POSINSET)(sourceArray.indexOf(value) + 1)] : []), ['id', `${this.htEditor.rootElement.id}_${row}-${col}`]]);
-        }
         TD.innerHTML = cellValue;
       },
-      afterSelection: (startRow, startCol) => {
-        if (rootInstanceAriaTagsEnabled) {
-          const TD = this.htEditor.getCell(startRow, startCol, true);
-          (0, _element.setAttribute)(TD, [(0, _a11y.A11Y_SELECTED)()]);
-          (0, _element.setAttribute)(this.TEXTAREA, ...(0, _a11y.A11Y_ACTIVEDESCENDANT)(TD.id));
-        }
-      }
+      autoColumnSize: true
     });
-    if (rootInstanceAriaTagsEnabled) {
-      // Add `role=presentation` to the main table to prevent the readers from treating the option list as a table.
-      (0, _element.setAttribute)(this.htEditor.view._wt.wtOverlays.wtTable.TABLE, ...(0, _a11y.A11Y_PRESENTATION)());
-      (0, _element.setAttribute)(this.htEditor.rootElement, [(0, _a11y.A11Y_LISTBOX)(), (0, _a11y.A11Y_LIVE)('polite'), (0, _a11y.A11Y_RELEVANT)('text'), ['id', `${priv.idPrefix}-listbox-${rowIndex}-${colIndex}`]]);
-      (0, _element.setAttribute)(this.TEXTAREA, ...(0, _a11y.A11Y_EXPANDED)('true'));
-    }
     if (priv.skipOne) {
       priv.skipOne = false;
     }
@@ -244,9 +196,6 @@ class AutocompleteEditor extends _handsontableEditor.HandsontableEditor {
   close() {
     this.removeHooksByKey('beforeKeyDown');
     super.close();
-    if (this.hot.getSettings().ariaTags) {
-      (0, _element.setAttribute)(this.TEXTAREA, [(0, _a11y.A11Y_EXPANDED)('false')]);
-    }
   }
 
   /**

package/editors/autocompleteEditor/autocompleteEditor.mjs

@@ -5,12 +5,11 @@ function _toPropertyKey(arg) { var key = _toPrimitive(arg, "string"); return typ
 function _toPrimitive(input, hint) { if (typeof input !== "object" || input === null) return input; var prim = input[Symbol.toPrimitive]; if (prim !== undefined) { var res = prim.call(input, hint || "default"); if (typeof res !== "object") return res; throw new TypeError("@@toPrimitive must return a primitive value."); } return (hint === "string" ? String : Number)(input); }
 import { HandsontableEditor } from "../handsontableEditor/index.mjs";
 import { arrayMap, pivot } from "../../helpers/array.mjs";
-import { addClass, getCaretPosition, getScrollbarWidth, getSelectionEndPosition, getTrimmingContainer, offset, outerHeight, outerWidth, setAttribute, setCaretPosition } from "../../helpers/dom/element.mjs";
+import { addClass, getCaretPosition, getScrollbarWidth, getSelectionEndPosition, getTrimmingContainer, offset, outerHeight, outerWidth, setCaretPosition } from "../../helpers/dom/element.mjs";
 import { isDefined, stringify } from "../../helpers/mixed.mjs";
 import { stripTags } from "../../helpers/string.mjs";
 import { KEY_CODES, isPrintableChar } from "../../helpers/unicode.mjs";
 import { textRenderer } from "../../renderers/textRenderer/index.mjs";
-import { A11Y_ACTIVEDESCENDANT, A11Y_AUTOCOMPLETE, A11Y_COMBOBOX, A11Y_CONTROLS, A11Y_EXPANDED, A11Y_HASPOPUP, A11Y_LISTBOX, A11Y_LIVE, A11Y_OPTION, A11Y_POSINSET, A11Y_PRESENTATION, A11Y_RELEVANT, A11Y_SELECTED, A11Y_SETSIZE, A11Y_TEXT } from "../../helpers/a11y.mjs";
 const privatePool = new WeakMap();
 export const EDITOR_TYPE = 'autocomplete';
 
@@ -110,8 +109,7 @@ export class AutocompleteEditor extends HandsontableEditor {
     this.rawChoices = [];
     privatePool.set(this, {
       skipOne: false,
-      isMacOS: this.hot.rootWindow.navigator.platform.indexOf('Mac') > -1,
-      idPrefix: instance.guid.slice(0, 9)
+      isMacOS: this.hot.rootWindow.navigator.platform.indexOf('Mac') > -1
     });
   }
 
@@ -138,27 +136,6 @@ export class AutocompleteEditor extends HandsontableEditor {
     super.createElements();
     addClass(this.htContainer, 'autocompleteEditor');
     addClass(this.htContainer, this.hot.rootWindow.navigator.platform.indexOf('Mac') === -1 ? '' : 'htMacScroll');
-    if (this.hot.getSettings().ariaTags) {
-      setAttribute(this.TEXTAREA, [A11Y_TEXT(), A11Y_COMBOBOX(), A11Y_HASPOPUP('listbox'), A11Y_AUTOCOMPLETE()]);
-    }
-  }
-
-  /**
-   * Prepares editor's metadata and configuration of the internal Handsontable's instance.
-   *
-   * @param {number} row The visual row index.
-   * @param {number} col The visual column index.
-   * @param {number|string} prop The column property (passed when datasource is an array of objects).
-   * @param {HTMLTableCellElement} td The rendered cell element.
-   * @param {*} value The rendered value.
-   * @param {object} cellProperties The cell meta object ({@see Core#getCellMeta}).
-   */
-  prepare(row, col, prop, td, value, cellProperties) {
-    const priv = privatePool.get(this);
-    super.prepare(row, col, prop, td, value, cellProperties);
-    if (this.hot.getSettings().ariaTags) {
-      setAttribute(this.TEXTAREA, [A11Y_EXPANDED('false'), A11Y_CONTROLS(`${priv.idPrefix}-listbox-${row}-${col}`)]);
-    }
   }
 
   /**
@@ -168,13 +145,6 @@ export class AutocompleteEditor extends HandsontableEditor {
     const priv = privatePool.get(this);
     super.open();
     const trimDropdown = this.cellProperties.trimDropdown === void 0 ? true : this.cellProperties.trimDropdown;
-    const rootInstanceAriaTagsEnabled = this.hot.getSettings().ariaTags;
-    const sourceArray = Array.isArray(this.cellProperties.source) ? this.cellProperties.source : null;
-    const sourceSize = sourceArray === null || sourceArray === void 0 ? void 0 : sourceArray.length;
-    const {
-      row: rowIndex,
-      col: colIndex
-    } = this;
     this.showEditableElement();
     this.focus();
     let scrollbarWidth = getScrollbarWidth();
@@ -186,7 +156,6 @@ export class AutocompleteEditor extends HandsontableEditor {
     this.htEditor.updateSettings({
       colWidths: trimDropdown ? [outerWidth(this.TEXTAREA) - 2] : void 0,
       width: trimDropdown ? outerWidth(this.TEXTAREA) + scrollbarWidth : void 0,
-      autoColumnSize: true,
       renderer: (instance, TD, row, col, prop, value, cellProperties) => {
         textRenderer(instance, TD, row, col, prop, value, cellProperties);
         const {
@@ -205,27 +174,10 @@ export class AutocompleteEditor extends HandsontableEditor {
             cellValue = cellValue.replace(match, `<strong>${match}</strong>`);
           }
         }
-        if (rootInstanceAriaTagsEnabled) {
-          setAttribute(TD, [A11Y_OPTION(),
-          // Add `setsize` and `posinset` only if the source is an array.
-          ...(sourceArray ? [A11Y_SETSIZE(sourceSize)] : []), ...(sourceArray ? [A11Y_POSINSET(sourceArray.indexOf(value) + 1)] : []), ['id', `${this.htEditor.rootElement.id}_${row}-${col}`]]);
-        }
         TD.innerHTML = cellValue;
       },
-      afterSelection: (startRow, startCol) => {
-        if (rootInstanceAriaTagsEnabled) {
-          const TD = this.htEditor.getCell(startRow, startCol, true);
-          setAttribute(TD, [A11Y_SELECTED()]);
-          setAttribute(this.TEXTAREA, ...A11Y_ACTIVEDESCENDANT(TD.id));
-        }
-      }
+      autoColumnSize: true
     });
-    if (rootInstanceAriaTagsEnabled) {
-      // Add `role=presentation` to the main table to prevent the readers from treating the option list as a table.
-      setAttribute(this.htEditor.view._wt.wtOverlays.wtTable.TABLE, ...A11Y_PRESENTATION());
-      setAttribute(this.htEditor.rootElement, [A11Y_LISTBOX(), A11Y_LIVE('polite'), A11Y_RELEVANT('text'), ['id', `${priv.idPrefix}-listbox-${rowIndex}-${colIndex}`]]);
-      setAttribute(this.TEXTAREA, ...A11Y_EXPANDED('true'));
-    }
     if (priv.skipOne) {
       priv.skipOne = false;
     }
@@ -240,9 +192,6 @@ export class AutocompleteEditor extends HandsontableEditor {
   close() {
     this.removeHooksByKey('beforeKeyDown');
     super.close();
-    if (this.hot.getSettings().ariaTags) {
-      setAttribute(this.TEXTAREA, [A11Y_EXPANDED('false')]);
-    }
   }
 
   /**

package/editors/dateEditor/dateEditor.js

@@ -7,7 +7,6 @@ var _pikaday = _interopRequireDefault(require("pikaday"));
 var _textEditor = require("../textEditor");
 var _eventManager = _interopRequireDefault(require("../../eventManager"));
 var _element = require("../../helpers/dom/element");
-var _a11y = require("../../helpers/a11y");
 var _object = require("../../helpers/object");
 var _unicode = require("../../helpers/unicode");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -45,7 +44,7 @@ class DateEditor extends _textEditor.TextEditor {
       throw new Error('You need to include Pikaday to your project.');
     }
     super.init();
-    this.hot.addHook('afterDestroy', () => {
+    this.instance.addHook('afterDestroy', () => {
       this.parentDestroyed = true;
       this.destroyElements();
     });
@@ -70,21 +69,7 @@ class DateEditor extends _textEditor.TextEditor {
     /**
      * Prevent recognizing clicking on datepicker as clicking outside of table.
      */
-    eventManager.addEventListener(this.datePicker, 'mousedown', event => {
-      if ((0, _element.hasClass)(event.target, 'pika-day')) {
-        this.hideDatepicker();
-      }
-      event.stopPropagation();
-    });
-
-    /**
-     * Prevent caret movement in the TEXTAREA when navigating over the date picker.
-     */
-    eventManager.addEventListener(this.TEXTAREA, 'keydown', event => {
-      if (['ArrowUp', 'ArrowDown', 'ArrowLeft', 'ArrowRight'].includes(event.code)) {
-        event.preventDefault();
-      }
-    });
+    eventManager.addEventListener(this.datePicker, 'mousedown', event => event.stopPropagation());
   }
 
   /**
@@ -125,9 +110,6 @@ class DateEditor extends _textEditor.TextEditor {
     const editorContext = shortcutManager.getContext('editor');
     super.open();
     this.showDatepicker(event);
-    if (this.hot.getSettings().ariaTags) {
-      (0, _element.setAttribute)(this.TD, [(0, _a11y.A11Y_EXPANDED)('true')]);
-    }
     editorContext.addShortcut({
       keys: [['Enter']],
       callback: keyboardEvent => {
@@ -150,12 +132,9 @@ class DateEditor extends _textEditor.TextEditor {
     if ((_this$$datePicker = this.$datePicker) !== null && _this$$datePicker !== void 0 && _this$$datePicker.destroy) {
       this.$datePicker.destroy();
     }
-    this.hot._registerTimeout(() => {
-      this.hot._refreshBorders();
+    this.instance._registerTimeout(() => {
+      this.instance._refreshBorders();
     });
-    if (this.TD && this.hot.getSettings().ariaTags) {
-      (0, _element.setAttribute)(this.TD, [(0, _a11y.A11Y_EXPANDED)('false')]);
-    }
     const shortcutManager = this.hot.getShortcutManager();
     const editorContext = shortcutManager.getContext('editor');
     editorContext.removeShortcutsByGroup(SHORTCUTS_GROUP_EDITOR);
@@ -173,6 +152,7 @@ class DateEditor extends _textEditor.TextEditor {
     let ctrlDown = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
     if (restoreOriginalValue) {
       // pressed ESC, restore original value
+      // var value = this.instance.getDataAtCell(this.row, this.col);
       const value = this.originalValue;
       if (value !== void 0) {
         this.setValue(value);
@@ -189,7 +169,7 @@ class DateEditor extends _textEditor.TextEditor {
   showDatepicker(event) {
     const offset = this.TD.getBoundingClientRect();
     const dateFormat = this.cellProperties.dateFormat || this.defaultDateFormat;
-    const isMouseDown = this.hot.view.isMouseDown();
+    const isMouseDown = this.instance.view.isMouseDown();
     const isMeta = event ? (0, _unicode.isFunctionKey)(event.keyCode) : false;
     let dateStr;
     this.datePicker.style.display = 'block';
@@ -268,6 +248,7 @@ class DateEditor extends _textEditor.TextEditor {
         dateStr = (0, _moment.default)(dateStr).format(this.cellProperties.dateFormat || this.defaultDateFormat);
       }
       this.setValue(dateStr);
+      this.hideDatepicker();
       if (origOnSelect) {
         origOnSelect();
       }