handsontable 0.0.0-next-662a118-20241017 → 0.0.0-next-802f59c-20241024

package/3rdparty/walkontable/src/viewport.mjs

@@ -1,4 +1,4 @@
-import { getScrollbarWidth, getStyle, offset, outerHeight, outerWidth } from "../../../helpers/dom/element.mjs";
+import { getScrollbarWidth, offset, outerHeight, outerWidth } from "../../../helpers/dom/element.mjs";
 import { objectEach } from "../../../helpers/object.mjs";
 import { FullyVisibleColumnsCalculationType, FullyVisibleRowsCalculationType, PartiallyVisibleColumnsCalculationType, PartiallyVisibleRowsCalculationType, RenderedAllColumnsCalculationType, RenderedAllRowsCalculationType, RenderedColumnsCalculationType, RenderedRowsCalculationType, ViewportColumnsCalculator, ViewportRowsCalculator } from "./calculator/index.mjs";
 /**
@@ -24,7 +24,6 @@ class Viewport {
     this.oversizedColumnHeaders = [];
     this.hasOversizedColumnHeadersMarked = {};
     this.clientHeight = 0;
-    this.containerWidth = NaN;
     this.rowHeaderWidth = NaN;
     this.rowsVisibleCalculator = null;
     this.columnsVisibleCalculator = null;
@@ -53,55 +52,65 @@ class Viewport {
     }
     return height;
   }
+
+  /**
+   * @returns {number}
+   */
+  getViewportHeight() {
+    let containerHeight = this.getWorkspaceHeight();
+    if (containerHeight === Infinity) {
+      return containerHeight;
+    }
+    const columnHeaderHeight = this.getColumnHeaderHeight();
+    if (columnHeaderHeight > 0) {
+      containerHeight -= columnHeaderHeight;
+    }
+    return containerHeight;
+  }
+
+  /**
+   * Gets the width of the table workspace (in pixels). The workspace size in the current
+   * implementation returns the width of the table holder element including scrollbar width when
+   * the table has defined size and the width of the window excluding scrollbar width when
+   * the table has no defined size (the window is a scrollable container).
+   *
+   * This is a bug, as the method should always return stable values, always without scrollbar width.
+   * Changing this behavior would break the column calculators, which would also need to be adjusted.
+   *
+   * @returns {number}
+   */
   getWorkspaceWidth() {
-    const {
-      wtSettings
-    } = this;
     const {
       rootDocument,
       rootWindow
     } = this.domBindings;
     const trimmingContainer = this.dataAccessObject.inlineStartOverlayTrimmingContainer;
-    const docOffsetWidth = rootDocument.documentElement.offsetWidth;
-    const totalColumns = wtSettings.getSetting('totalColumns');
-    const preventOverflow = wtSettings.getSetting('preventOverflow');
-    const isRtl = wtSettings.getSetting('rtlMode');
-    const tableRect = this.wtTable.TABLE.getBoundingClientRect();
-    const inlineStart = isRtl ? tableRect.right - docOffsetWidth : tableRect.left;
-    const tableOffset = docOffsetWidth - inlineStart;
     let width;
-    let overflow;
-    if (preventOverflow) {
-      return outerWidth(this.wtTable.wtRootElement);
-    }
-    if (wtSettings.getSetting('freezeOverlays')) {
-      width = Math.min(tableOffset, docOffsetWidth);
+    if (trimmingContainer === rootWindow) {
+      const totalColumns = this.wtSettings.getSetting('totalColumns');
+      width = this.wtTable.holder.offsetWidth;
+      if (this.getRowHeaderWidth() + this.sumColumnWidths(0, totalColumns) > width) {
+        width = rootDocument.documentElement.clientWidth;
+      }
     } else {
-      width = Math.min(this.getContainerFillWidth(), tableOffset, docOffsetWidth);
+      width = trimmingContainer.clientWidth;
     }
-    if (trimmingContainer === rootWindow && totalColumns > 0 && this.sumColumnWidths(0, totalColumns - 1) > width) {
-      // in case sum of column widths is higher than available stylesheet width, let's assume using the whole window
-      // otherwise continue below, which will allow stretching
-      // this is used in `scroll_window.html`
-      // TODO test me
-      return rootDocument.documentElement.clientWidth;
-    }
-    if (trimmingContainer !== rootWindow) {
-      overflow = getStyle(this.dataAccessObject.inlineStartOverlayTrimmingContainer, 'overflow', rootWindow);
-      if (overflow === 'scroll' || overflow === 'hidden' || overflow === 'auto') {
-        // this is used in `scroll.html`
-        // TODO test me
-        return Math.max(width, trimmingContainer.clientWidth);
-      }
+    return width;
+  }
+
+  /**
+   * @returns {number}
+   */
+  getViewportWidth() {
+    const containerWidth = this.getWorkspaceWidth();
+    if (containerWidth === Infinity) {
+      return containerWidth;
     }
-    const stretchSetting = wtSettings.getSetting('stretchH');
-    if (stretchSetting === 'none' || !stretchSetting) {
-      // if no stretching is used, return the maximum used workspace width
-      return Math.max(width, outerWidth(this.wtTable.TABLE));
+    const rowHeaderWidth = this.getRowHeaderWidth();
+    if (rowHeaderWidth > 0) {
+      return containerWidth - rowHeaderWidth;
     }
-
-    // if stretching is used, return the actual container width, so the columns can fit inside it
-    return width;
+    return containerWidth;
   }
 
   /**
@@ -122,6 +131,24 @@ class Viewport {
     return this.wtTable.hider.offsetWidth > this.getWorkspaceWidth();
   }
 
+  /**
+   * Checks if the table uses the window as a viewport and if there is a vertical scrollbar.
+   *
+   * @returns {boolean}
+   */
+  isVerticallyScrollableByWindow() {
+    return this.dataAccessObject.topOverlayTrimmingContainer === this.domBindings.rootWindow;
+  }
+
+  /**
+   * Checks if the table uses the window as a viewport and if there is a horizontal scrollbar.
+   *
+   * @returns {boolean}
+   */
+  isHorizontallyScrollableByWindow() {
+    return this.dataAccessObject.inlineStartOverlayTrimmingContainer === this.domBindings.rootWindow;
+  }
+
   /**
    * @param {number} from The visual column index from the width sum is start calculated.
    * @param {number} length The length of the column to traverse.
@@ -137,24 +164,6 @@ class Viewport {
     return sum;
   }
 
-  /**
-   * @returns {number}
-   */
-  getContainerFillWidth() {
-    if (this.containerWidth) {
-      return this.containerWidth;
-    }
-    const mainContainer = this.wtTable.holder;
-    const dummyElement = this.domBindings.rootDocument.createElement('div');
-    dummyElement.style.width = '100%';
-    dummyElement.style.height = '1px';
-    mainContainer.appendChild(dummyElement);
-    const fillWidth = dummyElement.offsetWidth;
-    this.containerWidth = fillWidth;
-    mainContainer.removeChild(dummyElement);
-    return fillWidth;
-  }
-
   /**
    * @returns {number}
    */
@@ -175,21 +184,6 @@ class Viewport {
     return this.columnHeaderHeight;
   }
 
-  /**
-   * @returns {number}
-   */
-  getViewportHeight() {
-    let containerHeight = this.getWorkspaceHeight();
-    if (containerHeight === Infinity) {
-      return containerHeight;
-    }
-    const columnHeaderHeight = this.getColumnHeaderHeight();
-    if (columnHeaderHeight > 0) {
-      containerHeight -= columnHeaderHeight;
-    }
-    return containerHeight;
-  }
-
   /**
    * @returns {number}
    */
@@ -224,21 +218,6 @@ class Viewport {
     return this.rowHeaderWidth;
   }
 
-  /**
-   * @returns {number}
-   */
-  getViewportWidth() {
-    const containerWidth = this.getWorkspaceWidth();
-    if (containerWidth === Infinity) {
-      return containerWidth;
-    }
-    const rowHeaderWidth = this.getRowHeaderWidth();
-    if (rowHeaderWidth > 0) {
-      return containerWidth - rowHeaderWidth;
-    }
-    return containerWidth;
-  }
-
   /**
    * Creates rows calculators. The type of the calculations can be chosen from the list:
    *  - 'rendered' Calculates rows that should be rendered within the current table's viewport;

package/base.js

@@ -45,8 +45,8 @@ Handsontable.hooks = _hooks.Hooks.getSingleton();
 Handsontable.CellCoords = _src.CellCoords;
 Handsontable.CellRange = _src.CellRange;
 Handsontable.packageName = 'handsontable';
-Handsontable.buildDate = "17/10/2024 07:41:53";
-Handsontable.version = "0.0.0-next-662a118-20241017";
+Handsontable.buildDate = "24/10/2024 07:23:05";
+Handsontable.version = "0.0.0-next-802f59c-20241024";
 Handsontable.languages = {
   dictionaryKeys: _registry.dictionaryKeys,
   getLanguageDictionary: _registry.getLanguageDictionary,

package/base.mjs

@@ -35,8 +35,8 @@ Handsontable.hooks = Hooks.getSingleton();
 Handsontable.CellCoords = CellCoords;
 Handsontable.CellRange = CellRange;
 Handsontable.packageName = 'handsontable';
-Handsontable.buildDate = "17/10/2024 07:41:58";
-Handsontable.version = "0.0.0-next-662a118-20241017";
+Handsontable.buildDate = "24/10/2024 07:23:11";
+Handsontable.version = "0.0.0-next-802f59c-20241024";
 Handsontable.languages = {
   dictionaryKeys,
   getLanguageDictionary,

package/core/hooks/constants.js

@@ -1368,6 +1368,7 @@ const REGISTERED_HOOKS = exports.REGISTERED_HOOKS = [/* eslint-disable jsdoc/req
  * @event Hooks#modifyColWidth
  * @param {number} width Current column width.
  * @param {number} column Visual column index.
+ * @param {string} [source] String that identifies source of hook call.
  */
 'modifyColWidth',
 /**
@@ -1404,6 +1405,7 @@ const REGISTERED_HOOKS = exports.REGISTERED_HOOKS = [/* eslint-disable jsdoc/req
  * @event Hooks#modifyRowHeight
  * @param {number} height Row height.
  * @param {number} row Visual row index.
+ * @param {string} [source] String that identifies source of hook call.
  */
 'modifyRowHeight',
 /**

package/core/hooks/constants.mjs

@@ -1365,6 +1365,7 @@ export const REGISTERED_HOOKS = [/* eslint-disable jsdoc/require-description-com
  * @event Hooks#modifyColWidth
  * @param {number} width Current column width.
  * @param {number} column Visual column index.
+ * @param {string} [source] String that identifies source of hook call.
  */
 'modifyColWidth',
 /**
@@ -1401,6 +1402,7 @@ export const REGISTERED_HOOKS = [/* eslint-disable jsdoc/require-description-com
  * @event Hooks#modifyRowHeight
  * @param {number} height Row height.
  * @param {number} row Visual row index.
+ * @param {string} [source] String that identifies source of hook call.
  */
 'modifyRowHeight',
 /**

package/core/hooks/index.d.ts

@@ -237,7 +237,7 @@ export interface Events {
   modifyColHeader?: (column: number) => void;
   modifyColumnHeaderHeight?: () => void;
   modifyColumnHeaderValue?: (headerValue: string, visualColumnIndex: number, headerLevel: number) => void | string;
-  modifyColWidth?: (width: number, column: number) => void;
+  modifyColWidth?: (width: number, column: number, source?: string) => void;
   modifyCopyableRange?: (copyableRanges: RangeType[]) => void;
   modifyFiltersMultiSelectValue?: (value: string, meta: CellProperties) => void | CellValue;
   modifyFocusedElement?: (row: number, column: number, focusedElement: HTMLElement) => void | HTMLElement;
@@ -248,7 +248,7 @@ export interface Events {
   modifyRowData?: (row: number) => void;
   modifyRowHeader?: (row: number) => void;
   modifyRowHeaderWidth?: (rowHeaderWidth: number) => void;
-  modifyRowHeight?: (height: number, row: number) => void | number;
+  modifyRowHeight?: (height: number, row: number, source?: string) => void | number;
   modifyRowHeightByOverlayName?: (height: number, row: number, overlayType: OverlayType) => void | number;
   modifySourceData?: (row: number, column: number, valueHolder: { value: CellValue }, ioMode: 'get' | 'set') => void;
   modifyTransformEnd?: (delta: CellCoords) => void;

package/core.d.ts

@@ -69,7 +69,7 @@ export default class Core {
   getColHeader(): Array<number | string>;
   getColHeader(column: number, headerLevel?: number): number | string;
   getColumnMeta(column: number): ColumnSettings;
-  getColWidth(column: number): number;
+  getColWidth(column: number, source?: string): number;
   getCoords(element: Element | null): CellCoords;
   getCopyableData(row: number, column: number): string;
   getCopyableText(startRow: number, startColumn: number, endRow: number, endColumn: number): string;
@@ -99,7 +99,7 @@ export default class Core {
   getPlugin(pluginName: string): Plugins['basePlugin'];
   getRowHeader(): Array<string | number>;
   getRowHeader(row: number): string | number;
-  getRowHeight(row: number): number;
+  getRowHeight(row: number, source?: string): number;
   getSchema(): RowObject;
   getSelected(): Array<[number, number, number, number]> | undefined;
   getSelectedLast(): number[] | undefined;

package/core.js

@@ -3494,12 +3494,13 @@ function Core(rootElement, userSettings) {
    * @memberof Core#
    * @function getColWidth
    * @param {number} column Visual column index.
+   * @param {string} [source] The source of the call.
    * @returns {number} Column width.
    * @fires Hooks#modifyColWidth
    */
-  this.getColWidth = function (column) {
+  this.getColWidth = function (column, source) {
     let width = instance._getColWidthFromSettings(column);
-    width = instance.runHooks('modifyColWidth', width, column);
+    width = instance.runHooks('modifyColWidth', width, column, source);
     if (width === undefined) {
       width = _src.DEFAULT_COLUMN_WIDTH;
     }
@@ -3559,12 +3560,13 @@ function Core(rootElement, userSettings) {
    * @memberof Core#
    * @function getRowHeight
    * @param {number} row A visual row index.
+   * @param {string} [source] The source of the call.
    * @returns {number|undefined} The height of the specified row, in pixels.
    * @fires Hooks#modifyRowHeight
    */
-  this.getRowHeight = function (row) {
+  this.getRowHeight = function (row, source) {
     let height = instance._getRowHeightFromSettings(row);
-    height = instance.runHooks('modifyRowHeight', height, row);
+    height = instance.runHooks('modifyRowHeight', height, row, source);
     return height;
   };
 

package/core.mjs

@@ -3489,12 +3489,13 @@ export default function Core(rootElement, userSettings) {
    * @memberof Core#
    * @function getColWidth
    * @param {number} column Visual column index.
+   * @param {string} [source] The source of the call.
    * @returns {number} Column width.
    * @fires Hooks#modifyColWidth
    */
-  this.getColWidth = function (column) {
+  this.getColWidth = function (column, source) {
     let width = instance._getColWidthFromSettings(column);
-    width = instance.runHooks('modifyColWidth', width, column);
+    width = instance.runHooks('modifyColWidth', width, column, source);
     if (width === undefined) {
       width = DEFAULT_COLUMN_WIDTH;
     }
@@ -3554,12 +3555,13 @@ export default function Core(rootElement, userSettings) {
    * @memberof Core#
    * @function getRowHeight
    * @param {number} row A visual row index.
+   * @param {string} [source] The source of the call.
    * @returns {number|undefined} The height of the specified row, in pixels.
    * @fires Hooks#modifyRowHeight
    */
-  this.getRowHeight = function (row) {
+  this.getRowHeight = function (row, source) {
     let height = instance._getRowHeightFromSettings(row);
-    height = instance.runHooks('modifyRowHeight', height, row);
+    height = instance.runHooks('modifyRowHeight', height, row, source);
     return height;
   };
 

package/dist/handsontable.css

@@ -25,8 +25,8 @@
  * INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES OF ANY CHARACTER ARISING FROM
  * USE OR INABILITY TO USE THIS SOFTWARE.
  *
- * Version: 0.0.0-next-662a118-20241017
- * Release date: 17/10/2024 (built at 17/10/2024 07:42:03)
+ * Version: 0.0.0-next-802f59c-20241024
+ * Release date: 17/10/2024 (built at 24/10/2024 07:23:15)
  */
 /**
  * Fix for bootstrap styles

package/dist/handsontable.full.css

@@ -25,8 +25,8 @@
  * INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES OF ANY CHARACTER ARISING FROM
  * USE OR INABILITY TO USE THIS SOFTWARE.
  *
- * Version: 0.0.0-next-662a118-20241017
- * Release date: 17/10/2024 (built at 17/10/2024 07:42:03)
+ * Version: 0.0.0-next-802f59c-20241024
+ * Release date: 17/10/2024 (built at 24/10/2024 07:23:15)
  */
 /**
  * Fix for bootstrap styles