handsontable 0.0.0-next-40cdda4-20240118 → 0.0.0-next-ff99030-20240119

package/helpers/mixed.js

@@ -134,7 +134,7 @@ const domMessages = {
 function _injectProductInfo(key, element) {
   const hasValidType = !isEmpty(key);
   const isNonCommercial = typeof key === 'string' && key.toLowerCase() === 'non-commercial-and-evaluation';
-  const hotVersion = "0.0.0-next-40cdda4-20240118";
+  const hotVersion = "0.0.0-next-ff99030-20240119";
   let keyValidityDate;
   let consoleMessageState = 'invalid';
   let domMessageState = 'invalid';

package/helpers/mixed.mjs

@@ -124,7 +124,7 @@ const domMessages = {
 export function _injectProductInfo(key, element) {
   const hasValidType = !isEmpty(key);
   const isNonCommercial = typeof key === 'string' && key.toLowerCase() === 'non-commercial-and-evaluation';
-  const hotVersion = "0.0.0-next-40cdda4-20240118";
+  const hotVersion = "0.0.0-next-ff99030-20240119";
   let keyValidityDate;
   let consoleMessageState = 'invalid';
   let domMessageState = 'invalid';

package/package.json

@@ -10,7 +10,7 @@
     "url": "https://github.com/handsontable/handsontable/issues"
   },
   "author": "Handsoncode <hello@handsontable.com>",
-  "version": "0.0.0-next-40cdda4-20240118",
+  "version": "0.0.0-next-ff99030-20240119",
   "main": "index",
   "module": "index.mjs",
   "jsnext:main": "index.mjs",

package/pluginHooks.d.ts

@@ -229,8 +229,8 @@ export interface Events {
   beforeUpdateData?: (sourceData: CellValue[], initialLoad: boolean, source: string | undefined) => void;
   beforeValidate?: (value: CellValue, row: number, prop: string | number, source?: ChangeSource) => void;
   beforeValueRender?: (value: CellValue, cellProperties: CellProperties) => void;
-  beforeViewportScrollVertically?: (visualRow: number) => number;
-  beforeViewportScrollHorizontally?: (visualColumn: number) => number;
+  beforeViewportScrollVertically?: (visualRow: number) => number | boolean;
+  beforeViewportScrollHorizontally?: (visualColumn: number) => number | boolean;
   beforeViewportScroll?: () => void;
   beforeViewRender?: (isForced: boolean, skipRender: { skipRender?: boolean }) => void;
   construct?: () => void;

package/pluginHooks.js

@@ -555,7 +555,8 @@ const REGISTERED_HOOKS = [/* eslint-disable jsdoc/require-description-complete-s
  * @since 14.0.0
  * @event Hooks#beforeViewportScrollVertically
  * @param {number} visualRow Visual row index.
- * @returns {number} Returns modified row index (or the same as passed in the method argument) to which the viewport will be scrolled.
+ * @returns {number | boolean} Returns modified row index (or the same as passed in the method argument) to which
+ * the viewport will be scrolled. If the returned value is `false`, the scrolling will be canceled.
  */
 'beforeViewportScrollVertically',
 /**
@@ -565,7 +566,8 @@ const REGISTERED_HOOKS = [/* eslint-disable jsdoc/require-description-complete-s
  * @since 14.0.0
  * @event Hooks#beforeViewportScrollHorizontally
  * @param {number} visualColumn Visual column index.
- * @returns {number} Returns modified column index (or the same as passed in the method argument) to which the viewport will be scrolled.
+ * @returns {number | boolean} Returns modified column index (or the same as passed in the method argument) to which
+ * the viewport will be scrolled. If the returned value is `false`, the scrolling will be canceled.
  */
 'beforeViewportScrollHorizontally',
 /**

package/pluginHooks.mjs

@@ -551,7 +551,8 @@ const REGISTERED_HOOKS = [/* eslint-disable jsdoc/require-description-complete-s
  * @since 14.0.0
  * @event Hooks#beforeViewportScrollVertically
  * @param {number} visualRow Visual row index.
- * @returns {number} Returns modified row index (or the same as passed in the method argument) to which the viewport will be scrolled.
+ * @returns {number | boolean} Returns modified row index (or the same as passed in the method argument) to which
+ * the viewport will be scrolled. If the returned value is `false`, the scrolling will be canceled.
  */
 'beforeViewportScrollVertically',
 /**
@@ -561,7 +562,8 @@ const REGISTERED_HOOKS = [/* eslint-disable jsdoc/require-description-complete-s
  * @since 14.0.0
  * @event Hooks#beforeViewportScrollHorizontally
  * @param {number} visualColumn Visual column index.
- * @returns {number} Returns modified column index (or the same as passed in the method argument) to which the viewport will be scrolled.
+ * @returns {number | boolean} Returns modified column index (or the same as passed in the method argument) to which
+ * the viewport will be scrolled. If the returned value is `false`, the scrolling will be canceled.
  */
 'beforeViewportScrollHorizontally',
 /**

package/plugins/dropdownMenu/dropdownMenu.js

@@ -15,10 +15,16 @@ var _predefinedItems = require("../contextMenu/predefinedItems");
 var _a11y = require("../../helpers/a11y");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 function _classPrivateMethodInitSpec(obj, privateSet) { _checkPrivateRedeclaration(obj, privateSet); privateSet.add(obj); }
+function _classPrivateFieldInitSpec(obj, privateMap, value) { _checkPrivateRedeclaration(obj, privateMap); privateMap.set(obj, value); }
 function _checkPrivateRedeclaration(obj, privateCollection) { if (privateCollection.has(obj)) { throw new TypeError("Cannot initialize the same private elements twice on an object"); } }
 function _defineProperty(obj, key, value) { key = _toPropertyKey(key); if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == typeof i ? i : String(i); }
 function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
+function _classPrivateFieldGet(receiver, privateMap) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "get"); return _classApplyDescriptorGet(receiver, descriptor); }
+function _classApplyDescriptorGet(receiver, descriptor) { if (descriptor.get) { return descriptor.get.call(receiver); } return descriptor.value; }
+function _classPrivateFieldSet(receiver, privateMap, value) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "set"); _classApplyDescriptorSet(receiver, descriptor, value); return value; }
+function _classExtractFieldDescriptor(receiver, privateMap, action) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to " + action + " private field on non-instance"); } return privateMap.get(receiver); }
+function _classApplyDescriptorSet(receiver, descriptor, value) { if (descriptor.set) { descriptor.set.call(receiver, value); } else { if (!descriptor.writable) { throw new TypeError("attempted to set read only private field"); } descriptor.value = value; } }
 function _classPrivateMethodGet(receiver, privateSet, fn) { if (!privateSet.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return fn; }
 _pluginHooks.default.getSingleton().register('afterDropdownMenuDefaultOptions');
 _pluginHooks.default.getSingleton().register('beforeDropdownMenuShow');
@@ -80,6 +86,7 @@ const SHORTCUTS_GROUP = PLUGIN_KEY;
  * ```
  * :::
  */
+var _isButtonClicked = /*#__PURE__*/new WeakMap();
 var _addCustomShortcuts = /*#__PURE__*/new WeakSet();
 var _onTableClick = /*#__PURE__*/new WeakSet();
 var _onAfterGetColHeader = /*#__PURE__*/new WeakSet();
@@ -87,6 +94,8 @@ var _onMenuBeforeOpen = /*#__PURE__*/new WeakSet();
 var _onMenuAfterOpen = /*#__PURE__*/new WeakSet();
 var _onSubMenuAfterOpen = /*#__PURE__*/new WeakSet();
 var _onMenuAfterClose = /*#__PURE__*/new WeakSet();
+var _onBeforeViewportScrollHorizontally = /*#__PURE__*/new WeakSet();
+var _onBeforeOnCellMouseDown = /*#__PURE__*/new WeakSet();
 class DropdownMenu extends _base.BasePlugin {
   static get PLUGIN_KEY() {
     return PLUGIN_KEY;
@@ -118,6 +127,21 @@ class DropdownMenu extends _base.BasePlugin {
     super(hotInstance);
 
     // One listener for enable/disable functionality
+    /**
+     * Hook sets the internal flag to `true` when the button is clicked.
+     *
+     * @param {MouseEvent} event The mouse event object.
+     */
+    _classPrivateMethodInitSpec(this, _onBeforeOnCellMouseDown);
+    /**
+     * Hook allows blocking horizontal scroll when the menu is opened by clicking on
+     * the column header button. This prevents from scrolling the viewport (jump effect) when
+     * the button is clicked.
+     *
+     * @param {number} visualColumn Visual column index.
+     * @returns {number | null}
+     */
+    _classPrivateMethodInitSpec(this, _onBeforeViewportScrollHorizontally);
     /**
      * On menu after close listener.
      *
@@ -182,6 +206,15 @@ class DropdownMenu extends _base.BasePlugin {
      * @type {Menu}
      */
     _defineProperty(this, "menu", null);
+    /**
+     * Flag which determines if the button that opens the menu was clicked.
+     *
+     * @type {boolean}
+     */
+    _classPrivateFieldInitSpec(this, _isButtonClicked, {
+      writable: true,
+      value: false
+    });
     this.hot.addHook('afterGetColHeader', (col, TH) => _classPrivateMethodGet(this, _onAfterGetColHeader, _onAfterGetColHeader2).call(this, col, TH));
   }
 
@@ -207,6 +240,18 @@ class DropdownMenu extends _base.BasePlugin {
       return;
     }
     this.itemsFactory = new _itemsFactory.ItemsFactory(this.hot, DropdownMenu.DEFAULT_ITEMS);
+    this.addHook('beforeOnCellMouseDown', function () {
+      for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+        args[_key] = arguments[_key];
+      }
+      return _classPrivateMethodGet(_this, _onBeforeOnCellMouseDown, _onBeforeOnCellMouseDown2).call(_this, ...args);
+    });
+    this.addHook('beforeViewportScrollHorizontally', function () {
+      for (var _len2 = arguments.length, args = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+        args[_key2] = arguments[_key2];
+      }
+      return _classPrivateMethodGet(_this, _onBeforeViewportScrollHorizontally, _onBeforeViewportScrollHorizontally2).call(_this, ...args);
+    });
     const settings = this.hot.getSettings()[PLUGIN_KEY];
     const predefinedItems = {
       items: this.itemsFactory.getItems(settings)
@@ -236,8 +281,8 @@ class DropdownMenu extends _base.BasePlugin {
       this.menu.addLocalHook('afterSubmenuOpen', subMenuInstance => _classPrivateMethodGet(this, _onSubMenuAfterOpen, _onSubMenuAfterOpen2).call(this, subMenuInstance));
       this.menu.addLocalHook('afterClose', () => _classPrivateMethodGet(this, _onMenuAfterClose, _onMenuAfterClose2).call(this));
       this.menu.addLocalHook('executeCommand', function () {
-        for (var _len = arguments.length, params = new Array(_len), _key = 0; _key < _len; _key++) {
-          params[_key] = arguments[_key];
+        for (var _len3 = arguments.length, params = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+          params[_key3] = arguments[_key3];
         }
         return _this.executeCommand.call(_this, ...params);
       });
@@ -410,8 +455,8 @@ class DropdownMenu extends _base.BasePlugin {
    * @param {*} params Additional parameters passed to the command executor.
    */
   executeCommand(commandName) {
-    for (var _len2 = arguments.length, params = new Array(_len2 > 1 ? _len2 - 1 : 0), _key2 = 1; _key2 < _len2; _key2++) {
-      params[_key2 - 1] = arguments[_key2];
+    for (var _len4 = arguments.length, params = new Array(_len4 > 1 ? _len4 - 1 : 0), _key4 = 1; _key4 < _len4; _key4++) {
+      params[_key4 - 1] = arguments[_key4];
     }
     this.commandExecutor.execute(commandName, ...params);
   }
@@ -455,6 +500,7 @@ function _onTableClick2(event) {
   if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME)) {
     const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
     const rect = event.target.getBoundingClientRect();
+    _classPrivateFieldSet(this, _isButtonClicked, false);
     this.open({
       left: rect.left + offset.left,
       top: rect.top + event.target.offsetHeight + 3 + offset.top
@@ -516,6 +562,14 @@ function _onMenuAfterClose2() {
   this.hot.listen();
   this.hot.runHooks('afterDropdownMenuHide', this);
 }
+function _onBeforeViewportScrollHorizontally2(visualColumn) {
+  return _classPrivateFieldGet(this, _isButtonClicked) ? null : visualColumn;
+}
+function _onBeforeOnCellMouseDown2(event) {
+  if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME)) {
+    _classPrivateFieldSet(this, _isButtonClicked, true);
+  }
+}
 DropdownMenu.SEPARATOR = {
   name: _predefinedItems.SEPARATOR
 };

package/plugins/dropdownMenu/dropdownMenu.mjs

@@ -1,9 +1,15 @@
 import "core-js/modules/es.error.cause.js";
 function _classPrivateMethodInitSpec(obj, privateSet) { _checkPrivateRedeclaration(obj, privateSet); privateSet.add(obj); }
+function _classPrivateFieldInitSpec(obj, privateMap, value) { _checkPrivateRedeclaration(obj, privateMap); privateMap.set(obj, value); }
 function _checkPrivateRedeclaration(obj, privateCollection) { if (privateCollection.has(obj)) { throw new TypeError("Cannot initialize the same private elements twice on an object"); } }
 function _defineProperty(obj, key, value) { key = _toPropertyKey(key); if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == typeof i ? i : String(i); }
 function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
+function _classPrivateFieldGet(receiver, privateMap) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "get"); return _classApplyDescriptorGet(receiver, descriptor); }
+function _classApplyDescriptorGet(receiver, descriptor) { if (descriptor.get) { return descriptor.get.call(receiver); } return descriptor.value; }
+function _classPrivateFieldSet(receiver, privateMap, value) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "set"); _classApplyDescriptorSet(receiver, descriptor, value); return value; }
+function _classExtractFieldDescriptor(receiver, privateMap, action) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to " + action + " private field on non-instance"); } return privateMap.get(receiver); }
+function _classApplyDescriptorSet(receiver, descriptor, value) { if (descriptor.set) { descriptor.set.call(receiver, value); } else { if (!descriptor.writable) { throw new TypeError("attempted to set read only private field"); } descriptor.value = value; } }
 function _classPrivateMethodGet(receiver, privateSet, fn) { if (!privateSet.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return fn; }
 import { BasePlugin } from "../base/index.mjs";
 import { arrayEach } from "../../helpers/array.mjs";
@@ -76,6 +82,7 @@ const SHORTCUTS_GROUP = PLUGIN_KEY;
  * ```
  * :::
  */
+var _isButtonClicked = /*#__PURE__*/new WeakMap();
 var _addCustomShortcuts = /*#__PURE__*/new WeakSet();
 var _onTableClick = /*#__PURE__*/new WeakSet();
 var _onAfterGetColHeader = /*#__PURE__*/new WeakSet();
@@ -83,6 +90,8 @@ var _onMenuBeforeOpen = /*#__PURE__*/new WeakSet();
 var _onMenuAfterOpen = /*#__PURE__*/new WeakSet();
 var _onSubMenuAfterOpen = /*#__PURE__*/new WeakSet();
 var _onMenuAfterClose = /*#__PURE__*/new WeakSet();
+var _onBeforeViewportScrollHorizontally = /*#__PURE__*/new WeakSet();
+var _onBeforeOnCellMouseDown = /*#__PURE__*/new WeakSet();
 export class DropdownMenu extends BasePlugin {
   static get PLUGIN_KEY() {
     return PLUGIN_KEY;
@@ -114,6 +123,21 @@ export class DropdownMenu extends BasePlugin {
     super(hotInstance);
 
     // One listener for enable/disable functionality
+    /**
+     * Hook sets the internal flag to `true` when the button is clicked.
+     *
+     * @param {MouseEvent} event The mouse event object.
+     */
+    _classPrivateMethodInitSpec(this, _onBeforeOnCellMouseDown);
+    /**
+     * Hook allows blocking horizontal scroll when the menu is opened by clicking on
+     * the column header button. This prevents from scrolling the viewport (jump effect) when
+     * the button is clicked.
+     *
+     * @param {number} visualColumn Visual column index.
+     * @returns {number | null}
+     */
+    _classPrivateMethodInitSpec(this, _onBeforeViewportScrollHorizontally);
     /**
      * On menu after close listener.
      *
@@ -178,6 +202,15 @@ export class DropdownMenu extends BasePlugin {
      * @type {Menu}
      */
     _defineProperty(this, "menu", null);
+    /**
+     * Flag which determines if the button that opens the menu was clicked.
+     *
+     * @type {boolean}
+     */
+    _classPrivateFieldInitSpec(this, _isButtonClicked, {
+      writable: true,
+      value: false
+    });
     this.hot.addHook('afterGetColHeader', (col, TH) => _classPrivateMethodGet(this, _onAfterGetColHeader, _onAfterGetColHeader2).call(this, col, TH));
   }
 
@@ -203,6 +236,18 @@ export class DropdownMenu extends BasePlugin {
       return;
     }
     this.itemsFactory = new ItemsFactory(this.hot, DropdownMenu.DEFAULT_ITEMS);
+    this.addHook('beforeOnCellMouseDown', function () {
+      for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+        args[_key] = arguments[_key];
+      }
+      return _classPrivateMethodGet(_this, _onBeforeOnCellMouseDown, _onBeforeOnCellMouseDown2).call(_this, ...args);
+    });
+    this.addHook('beforeViewportScrollHorizontally', function () {
+      for (var _len2 = arguments.length, args = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+        args[_key2] = arguments[_key2];
+      }
+      return _classPrivateMethodGet(_this, _onBeforeViewportScrollHorizontally, _onBeforeViewportScrollHorizontally2).call(_this, ...args);
+    });
     const settings = this.hot.getSettings()[PLUGIN_KEY];
     const predefinedItems = {
       items: this.itemsFactory.getItems(settings)
@@ -232,8 +277,8 @@ export class DropdownMenu extends BasePlugin {
       this.menu.addLocalHook('afterSubmenuOpen', subMenuInstance => _classPrivateMethodGet(this, _onSubMenuAfterOpen, _onSubMenuAfterOpen2).call(this, subMenuInstance));
       this.menu.addLocalHook('afterClose', () => _classPrivateMethodGet(this, _onMenuAfterClose, _onMenuAfterClose2).call(this));
       this.menu.addLocalHook('executeCommand', function () {
-        for (var _len = arguments.length, params = new Array(_len), _key = 0; _key < _len; _key++) {
-          params[_key] = arguments[_key];
+        for (var _len3 = arguments.length, params = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+          params[_key3] = arguments[_key3];
         }
         return _this.executeCommand.call(_this, ...params);
       });
@@ -406,8 +451,8 @@ export class DropdownMenu extends BasePlugin {
    * @param {*} params Additional parameters passed to the command executor.
    */
   executeCommand(commandName) {
-    for (var _len2 = arguments.length, params = new Array(_len2 > 1 ? _len2 - 1 : 0), _key2 = 1; _key2 < _len2; _key2++) {
-      params[_key2 - 1] = arguments[_key2];
+    for (var _len4 = arguments.length, params = new Array(_len4 > 1 ? _len4 - 1 : 0), _key4 = 1; _key4 < _len4; _key4++) {
+      params[_key4 - 1] = arguments[_key4];
     }
     this.commandExecutor.execute(commandName, ...params);
   }
@@ -450,6 +495,7 @@ function _onTableClick2(event) {
   if (hasClass(event.target, BUTTON_CLASS_NAME)) {
     const offset = getDocumentOffsetByElement(this.menu.container, this.hot.rootDocument);
     const rect = event.target.getBoundingClientRect();
+    _classPrivateFieldSet(this, _isButtonClicked, false);
     this.open({
       left: rect.left + offset.left,
       top: rect.top + event.target.offsetHeight + 3 + offset.top
@@ -511,6 +557,14 @@ function _onMenuAfterClose2() {
   this.hot.listen();
   this.hot.runHooks('afterDropdownMenuHide', this);
 }
+function _onBeforeViewportScrollHorizontally2(visualColumn) {
+  return _classPrivateFieldGet(this, _isButtonClicked) ? null : visualColumn;
+}
+function _onBeforeOnCellMouseDown2(event) {
+  if (hasClass(event.target, BUTTON_CLASS_NAME)) {
+    _classPrivateFieldSet(this, _isButtonClicked, true);
+  }
+}
 DropdownMenu.SEPARATOR = {
   name: SEPARATOR
 };

package/selection/selection.js

@@ -774,8 +774,8 @@ class Selection {
         } = selectionSchemaNormalizer(selection);
         this.setRangeStartOnly(from.clone(), false);
         this.setRangeEnd(to.clone());
-        this.finish();
       });
+      this.finish();
     }
     return isValid;
   }

package/selection/selection.mjs

@@ -768,8 +768,8 @@ class Selection {
         } = selectionSchemaNormalizer(selection);
         this.setRangeStartOnly(from.clone(), false);
         this.setRangeEnd(to.clone());
-        this.finish();
       });
+      this.finish();
     }
     return isValid;
   }