handsontable 0.0.0-next-08765b9-20230714 → 0.0.0-next-6b996e8-20230714

package/plugins/dropdownMenu/dropdownMenu.js

@@ -3,9 +3,7 @@
 exports.__esModule = true;
 var _base = require("../base");
 var _array = require("../../helpers/array");
-var _object = require("../../helpers/object");
 var _commandExecutor = _interopRequireDefault(require("../contextMenu/commandExecutor"));
-var _utils = require("../contextMenu/utils");
 var _eventManager = _interopRequireDefault(require("../../eventManager"));
 var _element = require("../../helpers/dom/element");
 var _itemsFactory = _interopRequireDefault(require("../contextMenu/itemsFactory"));
@@ -23,7 +21,6 @@ exports.PLUGIN_KEY = PLUGIN_KEY;
 const PLUGIN_PRIORITY = 230;
 exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
 const BUTTON_CLASS_NAME = 'changeType';
-const SHORTCUTS_GROUP = PLUGIN_KEY;
 
 /* eslint-disable jsdoc/require-description-complete-sentence */
 /**
@@ -160,7 +157,6 @@ class DropdownMenu extends _base.BasePlugin {
     if (typeof settings.callback === 'function') {
       this.commandExecutor.setCommonCallback(settings.callback);
     }
-    this.registerShortcuts();
     super.enablePlugin();
     this.callOnPluginsReady(() => {
       this.hot.runHooks('afterDropdownMenuDefaultOptions', predefinedItems);
@@ -211,68 +207,9 @@ class DropdownMenu extends _base.BasePlugin {
     if (this.menu) {
       this.menu.destroy();
     }
-    this.unregisterShortcuts();
     super.disablePlugin();
   }
 
-  /**
-   * Register shortcuts responsible for toggling dropdown menu.
-   *
-   * @private
-   */
-  registerShortcuts() {
-    const context = this.hot.getShortcutManager().getContext('grid');
-    const callback = () => {
-      const {
-        highlight
-      } = this.hot.getSelectedRangeLast();
-      if ((highlight.isHeader() && highlight.row === -1 || highlight.isCell()) && highlight.col >= 0) {
-        this.hot.selectColumns(highlight.col, highlight.col, -1);
-        const {
-          from
-        } = this.hot.getSelectedRangeLast();
-        const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
-        const target = this.hot.getCell(-1, from.col, true);
-        const rect = target.getBoundingClientRect();
-        this.open({
-          left: rect.left + offset.left,
-          top: rect.top + target.offsetHeight + offset.top
-        }, {
-          left: rect.width
-        });
-        this.hot._registerTimeout(() => {
-          this.menu.selectFirstCell();
-        });
-      }
-    };
-    context.addShortcuts([{
-      keys: [['Shift', 'Alt', 'ArrowDown'], ['Shift', 'Enter']],
-      callback,
-      runOnlyIf: () => {
-        var _this$hot$getSelected;
-        return ((_this$hot$getSelected = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected === void 0 ? void 0 : _this$hot$getSelected.highlight.isHeader()) && !this.menu.isOpened();
-      },
-      group: SHORTCUTS_GROUP
-    }, {
-      keys: [['Shift', 'Alt', 'ArrowDown']],
-      callback,
-      runOnlyIf: () => {
-        var _this$hot$getSelected2;
-        return ((_this$hot$getSelected2 = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected2 === void 0 ? void 0 : _this$hot$getSelected2.highlight.isCell()) && !this.menu.isOpened();
-      },
-      group: SHORTCUTS_GROUP
-    }]);
-  }
-
-  /**
-   * Unregister shortcuts responsible for toggling dropdown menu.
-   *
-   * @private
-   */
-  unregisterShortcuts() {
-    this.hot.getShortcutManager().getContext('grid').removeShortcutsByGroup(SHORTCUTS_GROUP);
-  }
-
   /**
    * Registers the DOM listeners.
    *
@@ -285,30 +222,23 @@ class DropdownMenu extends _base.BasePlugin {
   /**
    * Opens menu and re-position it based on the passed coordinates.
    *
-   * @param {{ top: number, left: number }|Event} position An object with `top` and `left` properties
-   * which contains coordinates relative to the browsers viewport (without included scroll offsets).
-   * Or if the native event is passed the menu will be positioned based on the `pageX` and `pageY`
-   * coordinates.
-   * @param {{ above: number, below: number, left: number, right: number }} offset An object allows applying
-   * the offset to the menu position.
+   * @param {object|Event} position An object with `pageX` and `pageY` properties which contains values relative to
+   *                                the top left of the fully rendered content area in the browser or with `clientX`
+   *                                and `clientY`  properties which contains values relative to the upper left edge
+   *                                of the content area (the viewport) of the browser window. This object is structurally
+   *                                compatible with native mouse event so it can be used either.
    * @fires Hooks#beforeDropdownMenuShow
    * @fires Hooks#afterDropdownMenuShow
    */
+
   open(position) {
-    var _this$menu;
-    let offset = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {
-      above: 0,
-      below: 0,
-      left: 0,
-      right: 0
-    };
-    if ((_this$menu = this.menu) !== null && _this$menu !== void 0 && _this$menu.isOpened()) {
+    if (!this.menu) {
       return;
     }
     this.menu.open();
-    (0, _object.objectEach)(offset, (value, key) => {
-      this.menu.setOffset(key, value);
-    });
+    if (position.width) {
+      this.menu.setOffset('left', position.width);
+    }
     this.menu.setPosition(position);
   }
 
@@ -316,8 +246,10 @@ class DropdownMenu extends _base.BasePlugin {
    * Closes dropdown menu.
    */
   close() {
-    var _this$menu2;
-    (_this$menu2 = this.menu) === null || _this$menu2 === void 0 ? void 0 : _this$menu2.close();
+    if (!this.menu) {
+      return;
+    }
+    this.menu.close();
   }
 
   /**
@@ -382,14 +314,26 @@ class DropdownMenu extends _base.BasePlugin {
    */
   onTableClick(event) {
     event.stopPropagation();
-    if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME)) {
-      const offset = (0, _utils.getDocumentOffsetByElement)(this.menu.container, this.hot.rootDocument);
+    if ((0, _element.hasClass)(event.target, BUTTON_CLASS_NAME) && !this.menu.isOpened()) {
+      let offsetTop = 0;
+      let offsetLeft = 0;
+      if (this.hot.rootDocument !== this.menu.container.ownerDocument) {
+        const {
+          frameElement
+        } = this.hot.rootWindow;
+        const {
+          top,
+          left
+        } = frameElement.getBoundingClientRect();
+        offsetTop = top;
+        offsetLeft = left;
+      }
       const rect = event.target.getBoundingClientRect();
       this.open({
-        left: rect.left + offset.left,
-        top: rect.top + event.target.offsetHeight + 3 + offset.top
-      }, {
-        left: rect.width
+        left: rect.left + offsetLeft,
+        top: rect.top + event.target.offsetHeight + 3 + offsetTop,
+        width: rect.width,
+        height: rect.height
       });
     }
   }
@@ -428,7 +372,6 @@ class DropdownMenu extends _base.BasePlugin {
     const button = this.hot.rootDocument.createElement('button');
     button.className = BUTTON_CLASS_NAME;
     button.type = 'button';
-    button.tabIndex = -1;
 
     // prevent page reload on button click
     button.onclick = function () {

package/plugins/dropdownMenu/dropdownMenu.mjs

@@ -1,8 +1,6 @@
 import { BasePlugin } from "../base/index.mjs";
 import { arrayEach } from "../../helpers/array.mjs";
-import { objectEach } from "../../helpers/object.mjs";
 import CommandExecutor from "../contextMenu/commandExecutor.mjs";
-import { getDocumentOffsetByElement } from "../contextMenu/utils.mjs";
 import EventManager from "../../eventManager.mjs";
 import { hasClass } from "../../helpers/dom/element.mjs";
 import ItemsFactory from "../contextMenu/itemsFactory.mjs";
@@ -17,7 +15,6 @@ Hooks.getSingleton().register('afterDropdownMenuExecute');
 export const PLUGIN_KEY = 'dropdownMenu';
 export const PLUGIN_PRIORITY = 230;
 const BUTTON_CLASS_NAME = 'changeType';
-const SHORTCUTS_GROUP = PLUGIN_KEY;
 
 /* eslint-disable jsdoc/require-description-complete-sentence */
 /**
@@ -154,7 +151,6 @@ export class DropdownMenu extends BasePlugin {
     if (typeof settings.callback === 'function') {
       this.commandExecutor.setCommonCallback(settings.callback);
     }
-    this.registerShortcuts();
     super.enablePlugin();
     this.callOnPluginsReady(() => {
       this.hot.runHooks('afterDropdownMenuDefaultOptions', predefinedItems);
@@ -205,68 +201,9 @@ export class DropdownMenu extends BasePlugin {
     if (this.menu) {
       this.menu.destroy();
     }
-    this.unregisterShortcuts();
     super.disablePlugin();
   }
 
-  /**
-   * Register shortcuts responsible for toggling dropdown menu.
-   *
-   * @private
-   */
-  registerShortcuts() {
-    const context = this.hot.getShortcutManager().getContext('grid');
-    const callback = () => {
-      const {
-        highlight
-      } = this.hot.getSelectedRangeLast();
-      if ((highlight.isHeader() && highlight.row === -1 || highlight.isCell()) && highlight.col >= 0) {
-        this.hot.selectColumns(highlight.col, highlight.col, -1);
-        const {
-          from
-        } = this.hot.getSelectedRangeLast();
-        const offset = getDocumentOffsetByElement(this.menu.container, this.hot.rootDocument);
-        const target = this.hot.getCell(-1, from.col, true);
-        const rect = target.getBoundingClientRect();
-        this.open({
-          left: rect.left + offset.left,
-          top: rect.top + target.offsetHeight + offset.top
-        }, {
-          left: rect.width
-        });
-        this.hot._registerTimeout(() => {
-          this.menu.selectFirstCell();
-        });
-      }
-    };
-    context.addShortcuts([{
-      keys: [['Shift', 'Alt', 'ArrowDown'], ['Shift', 'Enter']],
-      callback,
-      runOnlyIf: () => {
-        var _this$hot$getSelected;
-        return ((_this$hot$getSelected = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected === void 0 ? void 0 : _this$hot$getSelected.highlight.isHeader()) && !this.menu.isOpened();
-      },
-      group: SHORTCUTS_GROUP
-    }, {
-      keys: [['Shift', 'Alt', 'ArrowDown']],
-      callback,
-      runOnlyIf: () => {
-        var _this$hot$getSelected2;
-        return ((_this$hot$getSelected2 = this.hot.getSelectedRangeLast()) === null || _this$hot$getSelected2 === void 0 ? void 0 : _this$hot$getSelected2.highlight.isCell()) && !this.menu.isOpened();
-      },
-      group: SHORTCUTS_GROUP
-    }]);
-  }
-
-  /**
-   * Unregister shortcuts responsible for toggling dropdown menu.
-   *
-   * @private
-   */
-  unregisterShortcuts() {
-    this.hot.getShortcutManager().getContext('grid').removeShortcutsByGroup(SHORTCUTS_GROUP);
-  }
-
   /**
    * Registers the DOM listeners.
    *
@@ -279,30 +216,23 @@ export class DropdownMenu extends BasePlugin {
   /**
    * Opens menu and re-position it based on the passed coordinates.
    *
-   * @param {{ top: number, left: number }|Event} position An object with `top` and `left` properties
-   * which contains coordinates relative to the browsers viewport (without included scroll offsets).
-   * Or if the native event is passed the menu will be positioned based on the `pageX` and `pageY`
-   * coordinates.
-   * @param {{ above: number, below: number, left: number, right: number }} offset An object allows applying
-   * the offset to the menu position.
+   * @param {object|Event} position An object with `pageX` and `pageY` properties which contains values relative to
+   *                                the top left of the fully rendered content area in the browser or with `clientX`
+   *                                and `clientY`  properties which contains values relative to the upper left edge
+   *                                of the content area (the viewport) of the browser window. This object is structurally
+   *                                compatible with native mouse event so it can be used either.
    * @fires Hooks#beforeDropdownMenuShow
    * @fires Hooks#afterDropdownMenuShow
    */
+
   open(position) {
-    var _this$menu;
-    let offset = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {
-      above: 0,
-      below: 0,
-      left: 0,
-      right: 0
-    };
-    if ((_this$menu = this.menu) !== null && _this$menu !== void 0 && _this$menu.isOpened()) {
+    if (!this.menu) {
       return;
     }
     this.menu.open();
-    objectEach(offset, (value, key) => {
-      this.menu.setOffset(key, value);
-    });
+    if (position.width) {
+      this.menu.setOffset('left', position.width);
+    }
     this.menu.setPosition(position);
   }
 
@@ -310,8 +240,10 @@ export class DropdownMenu extends BasePlugin {
    * Closes dropdown menu.
    */
   close() {
-    var _this$menu2;
-    (_this$menu2 = this.menu) === null || _this$menu2 === void 0 ? void 0 : _this$menu2.close();
+    if (!this.menu) {
+      return;
+    }
+    this.menu.close();
   }
 
   /**
@@ -376,14 +308,26 @@ export class DropdownMenu extends BasePlugin {
    */
   onTableClick(event) {
     event.stopPropagation();
-    if (hasClass(event.target, BUTTON_CLASS_NAME)) {
-      const offset = getDocumentOffsetByElement(this.menu.container, this.hot.rootDocument);
+    if (hasClass(event.target, BUTTON_CLASS_NAME) && !this.menu.isOpened()) {
+      let offsetTop = 0;
+      let offsetLeft = 0;
+      if (this.hot.rootDocument !== this.menu.container.ownerDocument) {
+        const {
+          frameElement
+        } = this.hot.rootWindow;
+        const {
+          top,
+          left
+        } = frameElement.getBoundingClientRect();
+        offsetTop = top;
+        offsetLeft = left;
+      }
       const rect = event.target.getBoundingClientRect();
       this.open({
-        left: rect.left + offset.left,
-        top: rect.top + event.target.offsetHeight + 3 + offset.top
-      }, {
-        left: rect.width
+        left: rect.left + offsetLeft,
+        top: rect.top + event.target.offsetHeight + 3 + offsetTop,
+        width: rect.width,
+        height: rect.height
       });
     }
   }
@@ -422,7 +366,6 @@ export class DropdownMenu extends BasePlugin {
     const button = this.hot.rootDocument.createElement('button');
     button.className = BUTTON_CLASS_NAME;
     button.type = 'button';
-    button.tabIndex = -1;
 
     // prevent page reload on button click
     button.onclick = function () {

package/plugins/filters/filters.js

@@ -27,8 +27,6 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 const PLUGIN_KEY = 'filters';
 exports.PLUGIN_KEY = PLUGIN_KEY;
 const PLUGIN_PRIORITY = 250;
-exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
-const SHORTCUTS_GROUP = PLUGIN_KEY;
 
 /**
  * @plugin Filters
@@ -65,6 +63,7 @@ const SHORTCUTS_GROUP = PLUGIN_KEY;
  * ```
  * :::
  */
+exports.PLUGIN_PRIORITY = PLUGIN_PRIORITY;
 class Filters extends _base.BasePlugin {
   static get PLUGIN_KEY() {
     return PLUGIN_KEY;
@@ -211,7 +210,6 @@ class Filters extends _base.BasePlugin {
       this.dropdownMenuPlugin.disablePlugin();
       this.dropdownMenuPlugin.enablePlugin();
     }
-    this.registerShortcuts();
     super.enablePlugin();
   }
 
@@ -232,36 +230,9 @@ class Filters extends _base.BasePlugin {
       this.conditionCollection = null;
       this.hot.rowIndexMapper.unregisterMap(this.pluginName);
     }
-    this.unregisterShortcuts();
     super.disablePlugin();
   }
 
-  /**
-   * Register shortcuts responsible for clearing the filters.
-   *
-   * @private
-   */
-  registerShortcuts() {
-    this.hot.getShortcutManager().getContext('grid').addShortcut({
-      keys: [['Alt', 'A']],
-      stopPropagation: true,
-      callback: () => {
-        this.clearConditions();
-        this.filter();
-      },
-      group: SHORTCUTS_GROUP
-    });
-  }
-
-  /**
-   * Unregister shortcuts responsible for clearing the filters.
-   *
-   * @private
-   */
-  unregisterShortcuts() {
-    this.hot.getShortcutManager().getContext('grid').removeShortcutsByGroup(SHORTCUTS_GROUP);
-  }
-
   /* eslint-disable jsdoc/require-description-complete-sentence */
   /**
    * @memberof Filters#
@@ -451,6 +422,7 @@ class Filters extends _base.BasePlugin {
     this.hot.runHooks('afterFilter', conditions);
     this.hot.view.adjustElementsSize(true);
     this.hot.render();
+    this.clearColumnSelection();
   }
 
   /**
@@ -472,6 +444,18 @@ class Filters extends _base.BasePlugin {
     };
   }
 
+  /**
+   * Clears column selection.
+   *
+   * @private
+   */
+  clearColumnSelection() {
+    const selectedColumn = this.getSelectedColumn();
+    if (selectedColumn !== null) {
+      this.hot.selectCell(0, selectedColumn.visualIndex);
+    }
+  }
+
   /**
    * Returns handsontable source data with cell meta based on current selection.
    *
@@ -671,7 +655,6 @@ class Filters extends _base.BasePlugin {
       this.components.forEach(component => component.saveState(physicalIndex));
       this.filtersRowsMap.clear();
       this.filter();
-      this.hot.selectCell(0, selectedColumn.visualIndex);
     }
     (_this$dropdownMenuPlu3 = this.dropdownMenuPlugin) === null || _this$dropdownMenuPlu3 === void 0 ? void 0 : _this$dropdownMenuPlu3.close();
   }

package/plugins/filters/filters.mjs

@@ -20,7 +20,6 @@ import { CONDITION_NONE, CONDITION_BY_VALUE, OPERATION_AND, OPERATION_OR, OPERAT
 import { TrimmingMap } from "../../translations/index.mjs";
 export const PLUGIN_KEY = 'filters';
 export const PLUGIN_PRIORITY = 250;
-const SHORTCUTS_GROUP = PLUGIN_KEY;
 
 /**
  * @plugin Filters
@@ -203,7 +202,6 @@ export class Filters extends BasePlugin {
       this.dropdownMenuPlugin.disablePlugin();
       this.dropdownMenuPlugin.enablePlugin();
     }
-    this.registerShortcuts();
     super.enablePlugin();
   }
 
@@ -224,36 +222,9 @@ export class Filters extends BasePlugin {
       this.conditionCollection = null;
       this.hot.rowIndexMapper.unregisterMap(this.pluginName);
     }
-    this.unregisterShortcuts();
     super.disablePlugin();
   }
 
-  /**
-   * Register shortcuts responsible for clearing the filters.
-   *
-   * @private
-   */
-  registerShortcuts() {
-    this.hot.getShortcutManager().getContext('grid').addShortcut({
-      keys: [['Alt', 'A']],
-      stopPropagation: true,
-      callback: () => {
-        this.clearConditions();
-        this.filter();
-      },
-      group: SHORTCUTS_GROUP
-    });
-  }
-
-  /**
-   * Unregister shortcuts responsible for clearing the filters.
-   *
-   * @private
-   */
-  unregisterShortcuts() {
-    this.hot.getShortcutManager().getContext('grid').removeShortcutsByGroup(SHORTCUTS_GROUP);
-  }
-
   /* eslint-disable jsdoc/require-description-complete-sentence */
   /**
    * @memberof Filters#
@@ -443,6 +414,7 @@ export class Filters extends BasePlugin {
     this.hot.runHooks('afterFilter', conditions);
     this.hot.view.adjustElementsSize(true);
     this.hot.render();
+    this.clearColumnSelection();
   }
 
   /**
@@ -464,6 +436,18 @@ export class Filters extends BasePlugin {
     };
   }
 
+  /**
+   * Clears column selection.
+   *
+   * @private
+   */
+  clearColumnSelection() {
+    const selectedColumn = this.getSelectedColumn();
+    if (selectedColumn !== null) {
+      this.hot.selectCell(0, selectedColumn.visualIndex);
+    }
+  }
+
   /**
    * Returns handsontable source data with cell meta based on current selection.
    *
@@ -663,7 +647,6 @@ export class Filters extends BasePlugin {
       this.components.forEach(component => component.saveState(physicalIndex));
       this.filtersRowsMap.clear();
       this.filter();
-      this.hot.selectCell(0, selectedColumn.visualIndex);
     }
     (_this$dropdownMenuPlu3 = this.dropdownMenuPlugin) === null || _this$dropdownMenuPlu3 === void 0 ? void 0 : _this$dropdownMenuPlu3.close();
   }

package/plugins/mergeCells/mergeCells.js

@@ -188,6 +188,9 @@ class MergeCells extends _base.BasePlugin {
     this.addHook('afterDrawSelection', function () {
       return _this.onAfterDrawSelection(...arguments);
     });
+    this.addHook('beforeRemoveCellClassNames', function () {
+      return _this.onBeforeRemoveCellClassNames(...arguments);
+    });
     this.addHook('beforeUndoStackChange', (action, source) => {
       if (source === 'MergeCells') {
         return false;
@@ -571,11 +574,8 @@ class MergeCells extends _base.BasePlugin {
     gridContext.addShortcut({
       keys: [['Control', 'm']],
       callback: () => {
-        const range = this.hot.getSelectedRangeLast();
-        if (range && !range.isSingleHeader()) {
-          this.toggleMerge(range);
-          this.hot.render();
-        }
+        this.toggleMerge(this.hot.getSelectedRangeLast());
+        this.hot.render();
       },
       runOnlyIf: event => !event.altKey,
       // right ALT in some systems triggers ALT+CTRL
@@ -1198,5 +1198,16 @@ class MergeCells extends _base.BasePlugin {
     }
     return this.selectionCalculations.getSelectedMergedCellClassName(currentRow, currentColumn, cornersOfSelection, layerLevel);
   }
+
+  /**
+   * `beforeRemoveCellClassNames` hook callback. Used to remove additional class name from all cells in the table.
+   *
+   * @private
+   * @returns {string[]} An `Array` of `String`s. Each of these strings will act like class names to be removed from
+   *   all the cells in the table.
+   */
+  onBeforeRemoveCellClassNames() {
+    return this.selectionCalculations.getSelectedMergedCellClassNameToRemove();
+  }
 }
 exports.MergeCells = MergeCells;

package/plugins/mergeCells/mergeCells.mjs

@@ -182,6 +182,9 @@ export class MergeCells extends BasePlugin {
     this.addHook('afterDrawSelection', function () {
       return _this.onAfterDrawSelection(...arguments);
     });
+    this.addHook('beforeRemoveCellClassNames', function () {
+      return _this.onBeforeRemoveCellClassNames(...arguments);
+    });
     this.addHook('beforeUndoStackChange', (action, source) => {
       if (source === 'MergeCells') {
         return false;
@@ -565,11 +568,8 @@ export class MergeCells extends BasePlugin {
     gridContext.addShortcut({
       keys: [['Control', 'm']],
       callback: () => {
-        const range = this.hot.getSelectedRangeLast();
-        if (range && !range.isSingleHeader()) {
-          this.toggleMerge(range);
-          this.hot.render();
-        }
+        this.toggleMerge(this.hot.getSelectedRangeLast());
+        this.hot.render();
       },
       runOnlyIf: event => !event.altKey,
       // right ALT in some systems triggers ALT+CTRL
@@ -1192,4 +1192,15 @@ export class MergeCells extends BasePlugin {
     }
     return this.selectionCalculations.getSelectedMergedCellClassName(currentRow, currentColumn, cornersOfSelection, layerLevel);
   }
+
+  /**
+   * `beforeRemoveCellClassNames` hook callback. Used to remove additional class name from all cells in the table.
+   *
+   * @private
+   * @returns {string[]} An `Array` of `String`s. Each of these strings will act like class names to be removed from
+   *   all the cells in the table.
+   */
+  onBeforeRemoveCellClassNames() {
+    return this.selectionCalculations.getSelectedMergedCellClassNameToRemove();
+  }
 }