haltija 1.5.0 → 1.5.1

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## 1.5.1
+
+Low-risk follow-ups from the 1.5.0 pre-release review — the two new "instrument must not lie"
+warnings now reach more of the surfaces where they matter.
+
+### Fixed
+
+- **The hidden-tab / focus-ambiguity warning is no longer dropped on the paths where it's most
+  useful.** It's now attached on the **timeout** path — a hidden tab whose rAF-driven `eval` never
+  resolves now returns a `Timeout` that *explains* it may be asleep, instead of a bare timeout —
+  and preserved by the `hj find` / `hj form` handlers, which previously reshaped the response and
+  lost it. (`hj screenshot` already carried it; `hj call` intentionally still returns the raw value
+  with no envelope.)
+
+### Internal
+
+- Extracted the `hj --window <id>` argument handling into a pure, unit-tested helper
+  (`bin/arg-utils.mjs`), covering both the leading and trailing positions — the leading form was
+  the escape hatch that broke in 1.4.0, and it now has a regression test.
+- A private-app startup that fails to learn its ephemeral port no longer leaves its temp port-files
+  behind.
+
 ## 1.5.0
 
 Completes the **private-automation** feature (`--private`) begun in 1.4.1 — now for the Electron

package/apps/desktop/main.js

@@ -1350,7 +1350,12 @@ async function startEmbeddedServer() {
     }
     const pubPort = await readPort(pubFile)
     const intPort = await readPort(intFile)
-    if (!pubPort) { console.error('[Haltija Desktop] Private public server did not report its port'); return false }
+    if (!pubPort) {
+      // Don't leak the pid-scoped tmp port-files on the failure path (the success path cleans below).
+      try { fs.rmSync(pubFile, { force: true }); fs.rmSync(intFile, { force: true }) } catch {}
+      console.error('[Haltija Desktop] Private public server did not report its port')
+      return false
+    }
 
     HALTIJA_PORT = pubPort
     HALTIJA_SERVER = `http://localhost:${pubPort}`

package/apps/desktop/package.json

@@ -1,6 +1,6 @@
 {
   "name": "haltija-desktop",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "private": true,
   "description": "Haltija Desktop - God Mode Browser for AI Agents",
   "homepage": "https://github.com/tonioloewald/haltija",

package/apps/desktop/resources/component.js

@@ -46,7 +46,7 @@
   });
 
   // src/version.ts
-  var VERSION = "1.5.0";
+  var VERSION = "1.5.1";
 
   // src/text-selector.ts
   var TEXT_PSEUDO_RE = /:(?:text-is|has-text|text)\(/;

package/bin/arg-utils.mjs

@@ -0,0 +1,21 @@
+/**
+ * Pure arg helpers for the `hj` CLI, extracted so they can be unit-tested (see
+ * src/hj-args.test.ts) — the leading-`--window` form was fully broken and shipped without a test.
+ */
+
+/**
+ * Pull a `--window <id>` flag out of `args` from ANY position, returning the id and the remaining
+ * args (input is not mutated). Mirrors how `--port`/`--name`/`--token` are pre-parsed, so both
+ * `hj --window <id> <cmd>` (leading) and `hj <cmd> --window <id>` (trailing) resolve the same tab.
+ * A `--window` with no following value is left in place (treated as not-a-target) so it surfaces as
+ * a normal unknown-flag rather than silently swallowing the next real arg.
+ */
+export function extractWindowTarget(args) {
+  const i = args.indexOf('--window')
+  if (i === -1 || args[i + 1] === undefined) {
+    return { windowTarget: null, args: [...args] }
+  }
+  const rest = [...args]
+  rest.splice(i, 2)
+  return { windowTarget: args[i + 1], args: rest }
+}

package/bin/hj.mjs

@@ -11,6 +11,7 @@
  */
 
 import { runSubcommand, isSubcommand, getSuggestion, listSubcommands, COMMAND_HINTS } from './cli-subcommand.mjs'
+import { extractWindowTarget } from './arg-utils.mjs'
 import { HJ_VERSION } from './version.mjs'
 import { differsBeyondPatch } from './semver.mjs'
 import { existsSync, readFileSync, readdirSync } from 'node:fs'
@@ -313,12 +314,11 @@ if (noLaunchIdx !== -1) {
 // died with "Unknown command: '--window'" — i.e. the escape hatch we tell people to use for a
 // hidden/wrong tab didn't work in the shape the docs gave. Pulled out here and re-appended to
 // the subcommand args below, so BOTH positions work.
-let windowTarget = null
-const windowIdx = args.indexOf('--window')
-if (windowIdx !== -1 && args[windowIdx + 1]) {
-  windowTarget = args[windowIdx + 1]
-  args.splice(windowIdx, 2)
-}
+const { windowTarget, args: argsWithoutWindow } = extractWindowTarget(args)
+// Preserve the `const args` reference (downstream code mutates it in place) while dropping the
+// consumed --window <id> pair.
+args.length = 0
+args.push(...argsWithoutWindow)
 
 // Did the shell explicitly target a private instance (--port / --name /
 // HALTIJA_PORT / HALTIJA_NAME / DEV_CHANNEL_PORT)? If so, this is a

package/bin/version.mjs

@@ -3,4 +3,4 @@
  * ⚠️  To change the version, update package.json and run: bun run build
  */
 
-export const HJ_VERSION = '1.5.0'
+export const HJ_VERSION = '1.5.1'

package/dist/api-handlers.d.ts

@@ -16,6 +16,8 @@ export interface DevResponse {
     data?: any;
     error?: string;
     timestamp: number;
+    /** Hidden-tab / focus-ambiguity caveat attached by the server (see requestFromBrowser). */
+    warning?: string;
 }
 /** Function to send request to browser widget */
 export type RequestFromBrowserFn = (channel: string, action: string, payload: any, timeoutMs?: number, windowId?: string) => Promise<DevResponse>;

package/dist/component.d.ts

@@ -20,7 +20,7 @@
  * - Option+Tab toggles visibility (but active state always shows briefly)
  * - Localhost only by default
  */
-export declare const VERSION = "1.5.0";
+export declare const VERSION = "1.5.1";
 export declare class DevChannel extends HTMLElement {
     static get tagName(): string;
     static elementCreator(): () => DevChannel;

package/dist/component.esm.js

@@ -1,5 +1,5 @@
 // src/version.ts
-var VERSION = "1.5.0";
+var VERSION = "1.5.1";
 
 // src/text-selector.ts
 var TEXT_PSEUDO_RE = /:(?:text-is|has-text|text)\(/;

package/dist/component.js

@@ -46,7 +46,7 @@
   });
 
   // src/version.ts
-  var VERSION = "1.5.0";
+  var VERSION = "1.5.1";
 
   // src/text-selector.ts
   var TEXT_PSEUDO_RE = /:(?:text-is|has-text|text)\(/;

package/dist/hj.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env bun
-// haltija-cli:do-not-edit v1.5.0
+// haltija-cli:do-not-edit v1.5.1
 import { createRequire } from "node:module";
 var __require = /* @__PURE__ */ createRequire(import.meta.url);
 
@@ -756,7 +756,7 @@ function substituteGeneratedVars(text, seed) {
 }
 
 // bin/version.mjs
-var HJ_VERSION = "1.5.0";
+var HJ_VERSION = "1.5.1";
 
 // bin/semver.mjs
 function parseVersion(v) {
@@ -1906,6 +1906,17 @@ function dim2(s) {
   return `\x1B[2m${s}\x1B[0m`;
 }
 
+// bin/arg-utils.mjs
+function extractWindowTarget(args) {
+  const i = args.indexOf("--window");
+  if (i === -1 || args[i + 1] === undefined) {
+    return { windowTarget: null, args: [...args] };
+  }
+  const rest = [...args];
+  rest.splice(i, 2);
+  return { windowTarget: args[i + 1], args: rest };
+}
+
 // bin/hj.mjs
 import { existsSync as existsSync2, readFileSync as readFileSync2, readdirSync as readdirSync2 } from "node:fs";
 import { homedir as homedir2 } from "node:os";
@@ -2137,12 +2148,9 @@ if (noLaunchIdx !== -1) {
   noLaunch = true;
   args.splice(noLaunchIdx, 1);
 }
-var windowTarget = null;
-var windowIdx = args.indexOf("--window");
-if (windowIdx !== -1 && args[windowIdx + 1]) {
-  windowTarget = args[windowIdx + 1];
-  args.splice(windowIdx, 2);
-}
+var { windowTarget, args: argsWithoutWindow } = extractWindowTarget(args);
+args.length = 0;
+args.push(...argsWithoutWindow);
 var explicitTarget = portSource !== "8700 (default)";
 if (args.length >= 2 && isSubcommand(`${args[0]}-${args[1]}`)) {
   args.splice(0, 2, `${args[0]}-${args[1]}`);

package/dist/index.js

@@ -674,7 +674,7 @@ var injectorCode = `
 `;
 
 // src/version.ts
-var VERSION = "1.5.0";
+var VERSION = "1.5.1";
 
 // src/embedded-assets.ts
 var APP_MD = `# Haltija App
@@ -3097,7 +3097,7 @@ var COMPONENT_JS = `(() => {
   });
 
   // src/version.ts
-  var VERSION = "1.5.0";
+  var VERSION = "1.5.1";
 
   // src/text-selector.ts
   var TEXT_PSEUDO_RE = /:(?:text-is|has-text|text)\\(/;
@@ -13727,6 +13727,9 @@ function inferSuggestion(step, pageContext) {
 }
 
 // src/api-handlers.ts
+function withWarning(body, response) {
+  return response.warning ? { ...body, warning: response.warning } : body;
+}
 var handlers = new Map;
 function registerHandler(endpoint2, handler) {
   handlers.set(endpoint2.path, handler);
@@ -14557,7 +14560,7 @@ registerHandler(find, async (body, ctx) => {
   })()`;
   const response = await ctx.requestFromBrowser("eval", "exec", { code: findCode }, 5000, windowId);
   if (response.success && response.data) {
-    return Response.json({ success: true, ...response.data }, { headers: ctx.headers });
+    return Response.json(withWarning({ success: true, ...response.data }, response), { headers: ctx.headers });
   }
   return Response.json(response, { headers: ctx.headers });
 });
@@ -14663,7 +14666,7 @@ registerHandler(formData, async (body, ctx) => {
   })()`;
   const response = await ctx.requestFromBrowser("eval", "exec", { code: formCode }, 5000, windowId);
   if (response.success && response.data) {
-    return Response.json(response.data, { headers: ctx.headers });
+    return Response.json(withWarning(response.data, response), { headers: ctx.headers });
   }
   return Response.json(response, { headers: ctx.headers });
 });
@@ -16438,12 +16441,8 @@ async function requestFromBrowser(channel, action, payload, timeoutMs = 5000, wi
     source: "agent"
   };
   return new Promise((resolve) => {
-    const timeout = setTimeout(() => {
-      pendingResponses.delete(id);
-      resolve({ id, success: false, error: "Timeout", timestamp: Date.now() });
-    }, timeoutMs);
     let sentTo = null;
-    const resolveWithLiveness = (res) => {
+    const attachWarning = (res) => {
       const hidden = hiddenTabWarning(sentTo);
       const ambiguous = ambiguousFocusWarning({
         windows: Array.from(windows2.values()),
@@ -16453,8 +16452,13 @@ async function requestFromBrowser(channel, action, payload, timeoutMs = 5000, wi
       const warning = [hidden, ambiguous].filter(Boolean).join(`
 
 `);
-      resolve(warning ? { ...res, warning } : res);
+      return warning ? { ...res, warning } : res;
     };
+    const timeout = setTimeout(() => {
+      pendingResponses.delete(id);
+      resolve(attachWarning({ id, success: false, error: "Timeout", timestamp: Date.now() }));
+    }, timeoutMs);
+    const resolveWithLiveness = (res) => resolve(attachWarning(res));
     pendingResponses.set(id, { resolve: resolveWithLiveness, timeout });
     if (windowId) {
       const win = windows2.get(windowId);

package/dist/server.js

@@ -674,7 +674,7 @@ var injectorCode = `
 `;
 
 // src/version.ts
-var VERSION = "1.5.0";
+var VERSION = "1.5.1";
 
 // src/embedded-assets.ts
 var APP_MD = `# Haltija App
@@ -3097,7 +3097,7 @@ var COMPONENT_JS = `(() => {
   });
 
   // src/version.ts
-  var VERSION = "1.5.0";
+  var VERSION = "1.5.1";
 
   // src/text-selector.ts
   var TEXT_PSEUDO_RE = /:(?:text-is|has-text|text)\\(/;
@@ -13727,6 +13727,9 @@ function inferSuggestion(step, pageContext) {
 }
 
 // src/api-handlers.ts
+function withWarning(body, response) {
+  return response.warning ? { ...body, warning: response.warning } : body;
+}
 var handlers = new Map;
 function registerHandler(endpoint2, handler) {
   handlers.set(endpoint2.path, handler);
@@ -14557,7 +14560,7 @@ registerHandler(find, async (body, ctx) => {
   })()`;
   const response = await ctx.requestFromBrowser("eval", "exec", { code: findCode }, 5000, windowId);
   if (response.success && response.data) {
-    return Response.json({ success: true, ...response.data }, { headers: ctx.headers });
+    return Response.json(withWarning({ success: true, ...response.data }, response), { headers: ctx.headers });
   }
   return Response.json(response, { headers: ctx.headers });
 });
@@ -14663,7 +14666,7 @@ registerHandler(formData, async (body, ctx) => {
   })()`;
   const response = await ctx.requestFromBrowser("eval", "exec", { code: formCode }, 5000, windowId);
   if (response.success && response.data) {
-    return Response.json(response.data, { headers: ctx.headers });
+    return Response.json(withWarning(response.data, response), { headers: ctx.headers });
   }
   return Response.json(response, { headers: ctx.headers });
 });
@@ -16438,12 +16441,8 @@ async function requestFromBrowser(channel, action, payload, timeoutMs = 5000, wi
     source: "agent"
   };
   return new Promise((resolve) => {
-    const timeout = setTimeout(() => {
-      pendingResponses.delete(id);
-      resolve({ id, success: false, error: "Timeout", timestamp: Date.now() });
-    }, timeoutMs);
     let sentTo = null;
-    const resolveWithLiveness = (res) => {
+    const attachWarning = (res) => {
       const hidden = hiddenTabWarning(sentTo);
       const ambiguous = ambiguousFocusWarning({
         windows: Array.from(windows2.values()),
@@ -16453,8 +16452,13 @@ async function requestFromBrowser(channel, action, payload, timeoutMs = 5000, wi
       const warning = [hidden, ambiguous].filter(Boolean).join(`
 
 `);
-      resolve(warning ? { ...res, warning } : res);
+      return warning ? { ...res, warning } : res;
     };
+    const timeout = setTimeout(() => {
+      pendingResponses.delete(id);
+      resolve(attachWarning({ id, success: false, error: "Timeout", timestamp: Date.now() }));
+    }, timeoutMs);
+    const resolveWithLiveness = (res) => resolve(attachWarning(res));
     pendingResponses.set(id, { resolve: resolveWithLiveness, timeout });
     if (windowId) {
       const win = windows2.get(windowId);

package/dist/version.d.ts

@@ -8,4 +8,4 @@
  * ⚠️  AUTO-GENERATED FROM package.json - DO NOT EDIT THIS FILE
  * ⚠️  To change the version, update package.json and run: bun run build
  */
-export declare const VERSION = "1.5.0";
+export declare const VERSION = "1.5.1";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "haltija",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "Browser control for AI agents - query DOM, click, type, run JS, watch mutations",
   "type": "module",
   "main": "dist/index.js",