halo-agent 2.5.0 → 2.6.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "2.5.0",
+  "version": "2.6.1",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {

package/scanAccessibility.js

@@ -76,6 +76,12 @@ async function injectMmid(page) {
       '[role="option"]',
       '[role="menuitem"]',
       'button[type="submit"]',
+      // ATS toggle-button pairs (Ashby "Yes"/"No", some Greenhouse choice
+      // chips) are rendered as plain `<button>` elements without an explicit
+      // role attribute. Without this, the scan misses every required Yes/No
+      // question on Ashby and the planner silently leaves them blank.
+      // Downstream filters drop nav/close/submit buttons by label heuristic.
+      'button',
       'a[href]',
     ].join(',');
     const all = document.querySelectorAll(sel);
@@ -496,7 +502,7 @@ async function scanFrameDom(frame, frameUrl) {
     const seen = new Set();
     let n = Math.floor(Math.random() * 800000) + 200000; // high offset, no main-frame collision
 
-    const sel = 'input,textarea,select,[contenteditable="true"],[role="textbox"],[role="combobox"],[role="listbox"],[role="radio"],[role="checkbox"],[role="switch"],[role="button"],button[type="submit"]';
+    const sel = 'input,textarea,select,[contenteditable="true"],[role="textbox"],[role="combobox"],[role="listbox"],[role="radio"],[role="checkbox"],[role="switch"],[role="button"],button[type="submit"],button';
     document.querySelectorAll(sel).forEach((el) => {
       const tag = el.tagName.toLowerCase();
       const type = (el.type || '').toLowerCase();
@@ -567,6 +573,7 @@ async function scanFrameDom(frame, frameUrl) {
   return raw.map((f) => ({
     mmid: f.mmid,
     role: f.forceRole || normalizeRole(f),
+    tag: f.tag, // needed by main-frame filter to distinguish <button> from [role=button]
     label: f.label || f.textContent || '',
     description: '',
     required: false,
@@ -651,6 +658,21 @@ async function scanAccessibility(page) {
     if (f.frameUrl) {
       const fl = (f.label || '').trim();
       if (f.role === 'button' && (/^remove\s+\S/i.test(fl) || /^clear\s+selection/i.test(fl) || fl === '×' || fl === '✕' || fl === 'x')) continue;
+      // Apply the same nav-button filter for in-frame buttons.
+      if (f.role === 'button' && f.tag === 'button') {
+        const ll = fl.toLowerCase().trim();
+        const navWords = [
+          'back', 'cancel', 'close', 'menu', 'open menu', 'dismiss',
+          'submit', 'submit application', 'apply', 'apply now',
+          'sign in', 'sign up', 'log in', 'login', 'logout',
+          'next', 'previous', 'continue', 'edit', 'save',
+          'save and continue', 'save & continue',
+          'toggle theme', 'change theme', 'show password', 'hide password',
+        ];
+        if (navWords.includes(ll)) continue;
+        if (f.inputType === 'submit') continue;
+        if (fl.length > 80) continue;
+      }
       if (!fl && !['button', 'link'].includes(f.role)) continue;
       out.push(f); // already in public shape, carries frameUrl
       continue;
@@ -673,6 +695,29 @@ async function scanAccessibility(page) {
     )) {
       continue;
     }
+    // Filter out navigation / submit / close buttons surfaced by the
+    // broader generic-button selector. Answer-choice buttons (Yes / No /
+    // short option text) stay — they're what powers Ashby's toggle pairs.
+    if (normalizeRole(f) === 'button' && f.tag === 'button') {
+      const ll = label.toLowerCase().trim();
+      // Drop common nav buttons by exact-ish label
+      const navWords = [
+        'back', 'cancel', 'close', 'menu', 'open menu', 'dismiss',
+        'submit', 'submit application', 'apply', 'apply now',
+        'sign in', 'sign up', 'log in', 'login', 'logout',
+        'next', 'previous', 'continue',  // multi-step nav — filter; the form's own pagination handles
+        'edit', 'save', 'save and continue', 'save & continue',
+        'toggle theme', 'change theme', 'show password', 'hide password',
+        'view jd', 'view job', 'open application',
+      ];
+      if (navWords.includes(ll)) continue;
+      // Drop submit-type buttons even without a matching label
+      if (f.inputType === 'submit') continue;
+      // Drop very long labels — answer choices are short. >80 chars is
+      // almost certainly help text, fineprint, or accidentally-captured
+      // descendant content.
+      if (label.length > 80) continue;
+    }
     out.push({
       mmid: f.mmid,
       role: normalizeRole(f),