halo-agent 2.4.8 → 2.5.0

package/orchestrator.js

@@ -272,6 +272,15 @@ async function runJob(queueItem, chromeConn, config, reportStatus) {
       const retryResult = await fillFields(page, aep, { speed: typingSpeed, ctx, ats: ats_type, config, jobId });
       fillResult.filled += retryResult.filled;
       fillResult.skipped = retryResult.skipped;
+      // Preserve sticky upload flags. If pass 1 uploaded resume / cover letter,
+      // pass 2's smartFill won't redo it (the file slot is already filled and
+      // smartFill skips), so retryResult.resumeUploaded reads false — but the
+      // file IS in the slot. ORing keeps the truth across passes; without this
+      // the orchestrator's blanket fallback uploader (below) re-uploads resume
+      // into whatever file input it finds next, which on Greenhouse is the
+      // cover-letter slot. That's the Robinhood corruption bug.
+      fillResult.resumeUploaded = fillResult.resumeUploaded || retryResult.resumeUploaded;
+      fillResult.coverLetterUploaded = fillResult.coverLetterUploaded || retryResult.coverLetterUploaded;
       console.log(`[orchestrator] Retry fill: +${retryResult.filled} fields filled`);
     }
 
@@ -292,9 +301,33 @@ async function runJob(queueItem, chromeConn, config, reportStatus) {
     // the cover-letter slot too. smartFill now reports resumeUploaded, so we
     // only fall back when the planner genuinely missed the resume field.
     if (tempResumeFile && !fillResult.resumeUploaded) {
-      console.log('[orchestrator] smartFill did not upload a resume — running fallback uploader.');
-      const uploaded = await uploadFile(page, 'input[type="file"], [data-testid*="resume"], button:has-text("Upload")', tempResumeFile);
-      if (uploaded) fillResult.filled = (fillResult.filled || 0) + 1;
+      console.log('[orchestrator] smartFill did not upload a resume — running fallback uploader (resume-scoped).');
+      // Scoped selectors. Only match file inputs that are CLEARLY resume slots:
+      // - aria-label / name / id mentions "resume" or "cv"
+      // - dedicated [data-testid*="resume"]
+      // - inputs inside a section/fieldset/div whose nearest heading text
+      //   contains "Resume" or "CV" (Greenhouse pattern — uses a sibling
+      //   <h3>Resume/CV*</h3>). We use Playwright's :has() to chain.
+      //
+      // Critically we EXCLUDE selectors that would match the cover-letter slot.
+      // If no resume-scoped match exists, we don't upload anywhere — better to
+      // surface a real failure than silently corrupt the cover-letter slot.
+      const resumeOnlySelectors = [
+        'input[type="file"][aria-label*="resume" i]',
+        'input[type="file"][aria-label*="cv" i]',
+        'input[type="file"][name*="resume" i]',
+        'input[type="file"][id*="resume" i]',
+        '[data-testid*="resume" i]',
+      ].join(', ');
+      const uploaded = await uploadFile(page, resumeOnlySelectors, tempResumeFile);
+      if (uploaded) {
+        fillResult.filled = (fillResult.filled || 0) + 1;
+        fillResult.resumeUploaded = true;
+      } else {
+        console.warn('[orchestrator] Fallback uploader found no resume-scoped slot. Refusing to upload to generic file inputs to avoid cover-letter corruption.');
+      }
+    } else if (tempResumeFile && fillResult.resumeUploaded) {
+      console.log('[orchestrator] Skipping fallback uploader — smartFill already uploaded resume.');
     }
 
     await reportStatus('IN_PROGRESS', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "2.4.8",
+  "version": "2.5.0",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {

package/scanAccessibility.js

@@ -311,6 +311,48 @@ async function enrichFromDom(page, axFields) {
         }
       } catch {}
 
+      // Group-heading disambiguation for file inputs with generic labels.
+      // Greenhouse renders two `<input type="file">` inputs both labeled
+      // "Attach" — one under a `<h3>Resume/CV*</h3>` heading, one under
+      // `<h3>Cover Letter</h3>`. The AX name only sees "Attach" for both,
+      // so the planner can't route resume vs cover_letter deterministically.
+      // Walk up to the nearest heading and capture its text as groupLabel.
+      let groupLabel = '';
+      try {
+        const isFile = (el.tagName === 'INPUT' && String(el.type || '').toLowerCase() === 'file');
+        if (isFile) {
+          // Use the resolved AX/placeholder label if present; else fall back
+          // to the input's textContent / aria-label.
+          const lblForCheck = (el.getAttribute('aria-label') || el.placeholder || '').trim();
+          // Conservative: only fire when the immediate label is a generic
+          // upload verb. We don't want to clobber a real label like "Resume".
+          const generic = /^(attach|attach\s*file|upload|upload\s*file|choose file|select file|browse|add file|file)$/i;
+          // The visible button label is often on a sibling <button>; check that too.
+          let buttonText = '';
+          try {
+            const wrapper = el.closest('div, section, fieldset, [class*="field"], [class*="upload"]');
+            const btn = wrapper && wrapper.querySelector('button, [role="button"]');
+            if (btn) buttonText = safeText(btn.innerText || btn.textContent || '').trim();
+          } catch {}
+          const labelLooksGeneric = !lblForCheck || generic.test(lblForCheck) || generic.test(buttonText || '');
+          if (labelLooksGeneric) {
+            // Walk up to 8 ancestors and look for a heading inside that ancestor.
+            let p = el.parentElement, hops = 0;
+            while (p && hops < 8) {
+              const heading = p.querySelector('h1, h2, h3, h4, h5, h6, legend, [role="heading"]');
+              if (heading && !heading.contains(el)) {
+                const t = safeText(heading.textContent || '').replace(/\s*\*\s*$/, '').trim();
+                if (t && t.length > 0 && t.length < 150) {
+                  groupLabel = t;
+                  break;
+                }
+              }
+              p = p.parentElement; hops++;
+            }
+          }
+        }
+      } catch {}
+
       return {
         mmid,
         tag,
@@ -321,6 +363,7 @@ async function enrichFromDom(page, axFields) {
         ariaLabel: el.getAttribute('aria-label') || '',
         placeholder: el.placeholder || '',
         recoveredLabel,
+        groupLabel,
         selectorHint,
         currentValue,
         options,