halo-agent 2.4.5 → 2.4.8

package/orchestrator.js

@@ -727,31 +727,53 @@ async function runJob(queueItem, chromeConn, config, reportStatus) {
       console.warn(`[orchestrator] verify-submit unavailable: ${e.message}`);
     }
 
-    // Three-way verdict:
-    //   submitted: true  → real success, mark DONE
-    //   submitted: false → real failure, NEEDS_ATTENTION with the error
-    //   submitted: null  → could not verify (Firecrawl down/missing).
-    //                     Bounce to REVIEWING so the user eyeballs the
-    //                     screenshot — never silently mark DONE on
-    //                     unverified submits (that was the Chalk bug).
+    // Firecrawl is ADVISORY, not authoritative. The DOM-error pass above is
+    // the ground truth: if `errorsAfter.hasErrors === false` (no validation
+    // banner, no aria-invalid, no "is required" text), the form was accepted.
+    //
+    // Firecrawl false-positives we've seen in the wild:
+    //   - Ashby keeps the reCAPTCHA badge DOM-mounted on the thank-you page;
+    //     Firecrawl's extract reads it as "Recaptcha requires verification."
+    //   - Greenhouse thank-you pages include apologetic copy ("we'll be in
+    //     touch if it didn't go through") that the LLM reads as failure.
+    //   - URL doesn't always change on success (embed=js Ashby just swaps
+    //     the panel to a "Thanks for applying" state).
+    //
+    // So we no longer throw NEEDS_ATTENTION on `verdict.submitted === false`
+    // when local signals say success. Local truth comes from:
+    //   - errorsAfter.hasErrors === false (no DOM validation errors)
+    //   - findSubmitButton(page) returns null (submit button replaced by
+    //     confirmation UI), OR
+    //   - URL matched /thank|confirm|success|applied|submitted/ during the
+    //     wait above, OR
+    //   - No required fields still empty.
+    //
+    // Only when local signals ALSO look suspicious do we route to REVIEWING
+    // (NOT NEEDS_ATTENTION-throw — REVIEWING keeps tab open + parks).
     if (verdict.submitted === false) {
-      // The DOM-error pass above already retried + short-circuited if errors
-      // remained. If we got here AND Firecrawl is saying false, the DOM was
-      // clean (no aria-invalid / no banner / no "is required" text) but
-      // Firecrawl still detected something wrong — probably a thank-you
-      // page that includes some apologetic text the LLM misread. Surface
-      // it gently rather than throwing; user can audit the screenshot.
-      const reason = verdict.error_message || 'Firecrawl could not confirm submission';
-      console.warn(`[orchestrator] Firecrawl says NOT submitted (DOM looked clean): ${reason}`);
-      await reportStatus('NEEDS_ATTENTION', {
-        review_screenshot_r2_key: confirmKey || null,
-        needs_attention_reason: `Verifier flagged this submit: ${reason}. Page DOM looked clean — please eyeball.`,
-        intervention_type: 'submit_failed',
-        step: 'VERIFY',
-        step_detail: reason.slice(0, 200),
-        fields_filled: cumulativeFilled,
-      });
-      throw new Error(`Submission failed verification: ${reason}`);
+      const reason = verdict.error_message || 'verifier said not submitted';
+      // Local re-check: is the form gone / page in a confirmation state?
+      const submitStillThere = await findSubmitButton(page).then((b) => !!b).catch(() => false);
+      const urlLooksConfirmed = /thank|confirm|success|applied|submitted/i.test(page.url());
+      const postSkipped2 = (ctx.skippedFields || []).map((s) => s.label);
+      const reqCheck = await detectRequiredEmpties(page, { excludeLabels: postSkipped2, resumeUploaded: !!fillResult.resumeUploaded }).catch(() => ({ hasEmptyRequired: false, emptyFields: [] }));
+
+      // If submit button gone OR URL changed OR no validation errors AND
+      // no empty required fields → trust the DOM, treat as DONE.
+      const domSaysClean = !errorsAfter.hasErrors && !reqCheck.hasEmptyRequired;
+      const looksSubmitted = !submitStillThere || urlLooksConfirmed;
+      if (domSaysClean && (looksSubmitted || true /* DOM clean is enough */)) {
+        console.log(`[orchestrator] Verifier said "${reason}" but DOM is clean (no errors, no empties, submit ${submitStillThere ? 'still present' : 'gone'}, url ${urlLooksConfirmed ? 'confirmed' : 'unchanged'}). Treating as submitted.`);
+        // Fall through into the success-decision block below by overriding the verdict.
+        verdict.submitted = true;
+        verdict.source = verdict.source || 'dom-clean-override';
+      } else {
+        // DOM also looks off → real ambiguity. REVIEWING, not NEEDS_ATTENTION.
+        // Keep tab open so the user can finish manually. No throw.
+        console.warn(`[orchestrator] Verifier said "${reason}" and DOM is ambiguous (errors=${errorsAfter.hasErrors}, empties=${reqCheck.hasEmptyRequired}). Parking REVIEWING.`);
+        verdict.submitted = null;
+        verdict.source = 'dom-ambiguous';
+      }
     }
 
     // Decide final state (DONE / REVIEWING) based on verifier verdict +

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "2.4.5",
+  "version": "2.4.8",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {

package/scanAccessibility.js

@@ -292,6 +292,25 @@ async function enrichFromDom(page, axFields) {
       const ownerFrame = window.frameElement;
       const iframeSrc = ownerFrame ? ownerFrame.src || ownerFrame.name || '' : '';
 
+      // Disjoint label-for recovery. When the input has no matching
+      // <label for=id> partner (e.g. Ashby puts data-field-path on a
+      // wrapper <div> while the input itself has no id), Chrome's AX
+      // algorithm bottoms out at placeholder. We pre-compute a label
+      // from a known ATS field-group wrapper here so pickLabel() can
+      // prefer it when rawName turns out to be the placeholder.
+      let recoveredLabel = '';
+      try {
+        const wrapperSel = '[data-field-path], [class*="_fieldEntry_"], .ashby-application-form-field-entry, .application-question, [data-question-id]';
+        const wrapper = el.closest && el.closest(wrapperSel);
+        if (wrapper) {
+          const lbl = wrapper.querySelector('label');
+          if (lbl) {
+            const t = safeText(lbl.textContent || '').replace(/\s*\*\s*$/, '').trim();
+            if (t && t.length < 200) recoveredLabel = t;
+          }
+        }
+      } catch {}
+
       return {
         mmid,
         tag,
@@ -301,6 +320,7 @@ async function enrichFromDom(page, axFields) {
         id: el.id || '',
         ariaLabel: el.getAttribute('aria-label') || '',
         placeholder: el.placeholder || '',
+        recoveredLabel,
         selectorHint,
         currentValue,
         options,
@@ -349,7 +369,20 @@ function pickLabel(f) {
   // Priority: AX name → aria-label → placeholder → text content → field id.
   // (AX name already merges <label for>, aria-labelledby, fieldset/legend
   //  walks — we get them all for free.)
-  return (f.rawName || f.ariaLabel || f.placeholder || f.textContent || f.id || f.name || '').trim();
+  //
+  // Disjoint label-for recovery: when Chrome's AX algorithm bottoms out at
+  // the placeholder (because <label for=X> points at a wrapper id and the
+  // input itself has no id — Ashby's Location pattern, also any
+  // CSS-modules form library), rawName === placeholder. In that case
+  // prefer the label we walked from the field-group wrapper.
+  const rawName = (f.rawName || '').trim();
+  const placeholder = (f.placeholder || '').trim();
+  const recovered = (f.recoveredLabel || '').trim();
+  if (rawName && placeholder && rawName.toLowerCase() === placeholder.toLowerCase() && recovered) {
+    console.log(`[scanAx] recovered label "${recovered}" for placeholder-only field (was: "${rawName}")`);
+    return recovered;
+  }
+  return (rawName || f.ariaLabel || recovered || placeholder || f.textContent || f.id || f.name || '').trim();
 }
 
 function pickDescription(f) {
@@ -394,6 +427,19 @@ async function scanFrameDom(frame, frameUrl) {
         const t = alb.split(/\s+/).map((id) => document.getElementById(id)).filter(Boolean).map((e) => safeText(e.textContent)).join(' ').trim();
         if (t) return t;
       }
+      // Disjoint label-for recovery via ATS field-group wrapper.
+      // Mirrors the recoveredLabel walk in the main-frame DOM evaluator.
+      try {
+        const wrapperSel = '[data-field-path], [class*="_fieldEntry_"], .ashby-application-form-field-entry, .application-question, [data-question-id]';
+        const wrapper = el.closest && el.closest(wrapperSel);
+        if (wrapper) {
+          const lbl = wrapper.querySelector('label');
+          if (lbl && !lbl.contains(el)) {
+            const t = safeText(lbl.textContent).replace(/\*$/, '').trim();
+            if (t && t.length < 200) return t;
+          }
+        }
+      } catch {}
       let p = el.parentElement, hops = 0;
       while (p && hops < 8) {
         const lbl = p.querySelector('label, legend, h2, h3, h4');

package/smartFill.js

@@ -125,6 +125,10 @@ async function executePlanItem(page, item, fieldByMmid, ctx) {
         const result = await openAndPickOption(root, locator, item.value, {
           config: ctx.config, jobId: ctx.jobId, label: field.label, field,
         });
+        // Always dismiss any lingering portal/option-list before the next
+        // field so stale overlays don't intercept the next click.
+        const pageRef = (root && typeof root.page === 'function') ? root.page() : root;
+        await pageRef.keyboard.press('Escape').catch(() => {});
         if (result.ok) return result;
         // Fall through to text-fill if no option matched at all
         // (some Greenhouse comboboxes accept free-text in addition to options).
@@ -150,9 +154,14 @@ async function executePlanItem(page, item, fieldByMmid, ctx) {
     }
 
     case 'click_option': {
-      return await openAndPickOption(root, locator, item.value, {
+      const result = await openAndPickOption(root, locator, item.value, {
         config: ctx.config, jobId: ctx.jobId, label: field.label, field,
       });
+      // Always dismiss any lingering portal/option-list before the next
+      // field so stale overlays don't intercept the next click.
+      const pageRef = (root && typeof root.page === 'function') ? root.page() : root;
+      await pageRef.keyboard.press('Escape').catch(() => {});
+      return result;
     }
 
     case 'set_checkbox': {
@@ -656,7 +665,22 @@ async function openAndPickOption(root, triggerLocator, value, llmCtx) {
   //   - Ashby's emotion-hashed _input_ class inside a _fieldEntry_ group
   try {
     const fieldIsTypeahead = !!(llmCtx && llmCtx.field && llmCtx.field.isTypeahead);
-    const domIsTypeahead = await triggerLocator.evaluate((el) => {
+    // React-select disqualifier. Greenhouse, Lever, and many other ATSs ship
+    // react-select-styled dropdowns that carry `aria-autocomplete="list"` but
+    // are NOT async typeaheads — their options are pre-loaded and rendered as
+    // `.select__option` under a portal. If we type into them, react-select
+    // clears the input on blur because the typed text doesn't match any
+    // selectable option. The result is a silently-empty required field.
+    // Route those straight to tryReactSelect instead.
+    const isReactSelect = await triggerLocator.evaluate((el) => {
+      const matchSel = '.select__input, [class*="select__input"], .select__control, [class*="select__control"], [class*="-control"][class*="select"]';
+      if (el.matches?.(matchSel)) return true;
+      if (el.closest?.('.select__control, [class*="select__control"], .select, [class*="-container"][class*="select"]')) return true;
+      // Descendant check (when locator climbed to a wrapper)
+      if (el.querySelector?.('.select__input, [class*="select__input"], .select__control, [class*="select__control"]')) return true;
+      return false;
+    }).catch(() => false);
+    const domIsTypeahead = isReactSelect ? false : await triggerLocator.evaluate((el) => {
       const probe = (n) => {
         if (!n || n.nodeType !== 1) return false;
         const role = n.getAttribute('role');
@@ -685,12 +709,15 @@ async function openAndPickOption(root, triggerLocator, value, llmCtx) {
       return false;
     }).catch(() => false);
 
-    if (fieldIsTypeahead || domIsTypeahead) {
+    if (isReactSelect) {
+      console.log('[smartFill] openAndPickOption: react-select detected → skipping typeahead path, routing to tryReactSelect');
+    }
+    if ((fieldIsTypeahead || domIsTypeahead) && !isReactSelect) {
       const why = [];
       if (fieldIsTypeahead) why.push('field.isTypeahead');
       if (domIsTypeahead) why.push('dom signals');
       console.log(`[smartFill] openAndPickOption: detected typeahead (${why.join(', ')}) → typeAndPickSuggestion first`);
-      const r = await typeAndPickSuggestion(root, triggerLocator, value);
+      const r = await typeAndPickSuggestion(root, triggerLocator, value, { strict: true });
       if (r && r.ok) return r;
       // Fall through to specialized + generic paths on no-match.
       console.log(`[smartFill] typeahead path did not land (${r && r.reason}); falling through to generic dispatch.`);
@@ -907,8 +934,14 @@ async function reactSafeType(root, locator, value) {
 
 /**
  * Type-and-pick for typeahead inputs (Greenhouse Location etc).
+ *
+ * opts.strict: when true, "no suggestion appeared" is reported as failure
+ * instead of silently accepting the typed value as free text. Pass this
+ * for known-listbox combobox fields where accepting free text would be
+ * silently cleared by the framework on blur (react-select, etc.).
  */
-async function typeAndPickSuggestion(root, locator, value) {
+async function typeAndPickSuggestion(root, locator, value, opts) {
+  const strict = !!(opts && opts.strict);
   // root: Page or Frame. Option lists for an in-frame field render inside
   // that frame, so they must be located via root, not the top page.
   const page = (root && typeof root.page === 'function') ? root.page() : root;
@@ -941,15 +974,15 @@ async function typeAndPickSuggestion(root, locator, value) {
       await root.locator(optionSel).first().waitFor({ state: 'visible', timeout: 1500 });
     } catch {
       const got = await locator.inputValue({ timeout: 800 }).catch(() => null);
-      if (got && got.trim()) return { ok: true, reason: `typeahead (no suggestion, accepted): "${value.slice(0, 30)}"` };
-      return { ok: false, reason: 'typeahead opened no suggestions' };
+      if (got && got.trim() && !strict) return { ok: true, reason: `typeahead (no suggestion, accepted): "${value.slice(0, 30)}"` };
+      return { ok: false, reason: strict && got && got.trim() ? 'no_match (strict: free text not allowed)' : 'typeahead opened no suggestions' };
     }
     const opts = root.locator(optionSel);
     const count = await opts.count().catch(() => 0);
     if (count === 0) {
       const got = await locator.inputValue({ timeout: 800 }).catch(() => null);
-      if (got && got.trim()) return { ok: true, reason: `typeahead (no suggestion, accepted): "${value.slice(0, 30)}"` };
-      return { ok: false, reason: 'typeahead opened no suggestions' };
+      if (got && got.trim() && !strict) return { ok: true, reason: `typeahead (no suggestion, accepted): "${value.slice(0, 30)}"` };
+      return { ok: false, reason: strict && got && got.trim() ? 'no_match (strict: free text not allowed)' : 'typeahead opened no suggestions' };
     }
     const texts = await opts.allTextContents().catch(() => []);
     const v = firstChunk.toLowerCase();