halo-agent 2.4.4 → 2.4.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "2.4.4",
+  "version": "2.4.6",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {

package/scanAccessibility.js

@@ -292,6 +292,25 @@ async function enrichFromDom(page, axFields) {
       const ownerFrame = window.frameElement;
       const iframeSrc = ownerFrame ? ownerFrame.src || ownerFrame.name || '' : '';
 
+      // Disjoint label-for recovery. When the input has no matching
+      // <label for=id> partner (e.g. Ashby puts data-field-path on a
+      // wrapper <div> while the input itself has no id), Chrome's AX
+      // algorithm bottoms out at placeholder. We pre-compute a label
+      // from a known ATS field-group wrapper here so pickLabel() can
+      // prefer it when rawName turns out to be the placeholder.
+      let recoveredLabel = '';
+      try {
+        const wrapperSel = '[data-field-path], [class*="_fieldEntry_"], .ashby-application-form-field-entry, .application-question, [data-question-id]';
+        const wrapper = el.closest && el.closest(wrapperSel);
+        if (wrapper) {
+          const lbl = wrapper.querySelector('label');
+          if (lbl) {
+            const t = safeText(lbl.textContent || '').replace(/\s*\*\s*$/, '').trim();
+            if (t && t.length < 200) recoveredLabel = t;
+          }
+        }
+      } catch {}
+
       return {
         mmid,
         tag,
@@ -301,6 +320,7 @@ async function enrichFromDom(page, axFields) {
         id: el.id || '',
         ariaLabel: el.getAttribute('aria-label') || '',
         placeholder: el.placeholder || '',
+        recoveredLabel,
         selectorHint,
         currentValue,
         options,
@@ -349,7 +369,20 @@ function pickLabel(f) {
   // Priority: AX name → aria-label → placeholder → text content → field id.
   // (AX name already merges <label for>, aria-labelledby, fieldset/legend
   //  walks — we get them all for free.)
-  return (f.rawName || f.ariaLabel || f.placeholder || f.textContent || f.id || f.name || '').trim();
+  //
+  // Disjoint label-for recovery: when Chrome's AX algorithm bottoms out at
+  // the placeholder (because <label for=X> points at a wrapper id and the
+  // input itself has no id — Ashby's Location pattern, also any
+  // CSS-modules form library), rawName === placeholder. In that case
+  // prefer the label we walked from the field-group wrapper.
+  const rawName = (f.rawName || '').trim();
+  const placeholder = (f.placeholder || '').trim();
+  const recovered = (f.recoveredLabel || '').trim();
+  if (rawName && placeholder && rawName.toLowerCase() === placeholder.toLowerCase() && recovered) {
+    console.log(`[scanAx] recovered label "${recovered}" for placeholder-only field (was: "${rawName}")`);
+    return recovered;
+  }
+  return (rawName || f.ariaLabel || recovered || placeholder || f.textContent || f.id || f.name || '').trim();
 }
 
 function pickDescription(f) {
@@ -394,6 +427,19 @@ async function scanFrameDom(frame, frameUrl) {
         const t = alb.split(/\s+/).map((id) => document.getElementById(id)).filter(Boolean).map((e) => safeText(e.textContent)).join(' ').trim();
         if (t) return t;
       }
+      // Disjoint label-for recovery via ATS field-group wrapper.
+      // Mirrors the recoveredLabel walk in the main-frame DOM evaluator.
+      try {
+        const wrapperSel = '[data-field-path], [class*="_fieldEntry_"], .ashby-application-form-field-entry, .application-question, [data-question-id]';
+        const wrapper = el.closest && el.closest(wrapperSel);
+        if (wrapper) {
+          const lbl = wrapper.querySelector('label');
+          if (lbl && !lbl.contains(el)) {
+            const t = safeText(lbl.textContent).replace(/\*$/, '').trim();
+            if (t && t.length < 200) return t;
+          }
+        }
+      } catch {}
       let p = el.parentElement, hops = 0;
       while (p && hops < 8) {
         const lbl = p.querySelector('label, legend, h2, h3, h4');

package/smartFill.js

@@ -123,7 +123,7 @@ async function executePlanItem(page, item, fieldByMmid, ctx) {
       // it as click_option.
       if (field.role === 'combobox' || field.role === 'listbox') {
         const result = await openAndPickOption(root, locator, item.value, {
-          config: ctx.config, jobId: ctx.jobId, label: field.label,
+          config: ctx.config, jobId: ctx.jobId, label: field.label, field,
         });
         if (result.ok) return result;
         // Fall through to text-fill if no option matched at all
@@ -151,7 +151,7 @@ async function executePlanItem(page, item, fieldByMmid, ctx) {
 
     case 'click_option': {
       return await openAndPickOption(root, locator, item.value, {
-        config: ctx.config, jobId: ctx.jobId, label: field.label,
+        config: ctx.config, jobId: ctx.jobId, label: field.label, field,
       });
     }
 
@@ -636,6 +636,67 @@ async function openAndPickOption(root, triggerLocator, value, llmCtx) {
   // need the Page. For in-frame fields, option menus render inside the
   // frame so root.locator finds them.
   const page = (root && typeof root.page === 'function') ? root.page() : root;
+
+  // ── Async-listbox typeahead (shape-agnostic): try FIRST. ─────────────
+  // Any combobox where options are NOT pre-rendered — Ashby Location,
+  // Greenhouse Google Places, Workday city pickers, school/company
+  // autocompletes — must be typed into BEFORE options can appear. The
+  // generic "click and snapshot" path below opens the menu, waits 350ms,
+  // and bails on empty — but Ashby's geo fetch alone takes ~700ms.
+  //
+  // We probe DOM signals on the located element AND on its descendants AND
+  // on its closest field-group, because the planner's mmid may resolve to
+  // the hidden input, the wrapper div, or the toggle button — and Ashby's
+  // wrapper has no role/aria attrs of its own.
+  //
+  // Triggers:
+  //   - role=combobox + (aria-haspopup=listbox | aria-autocomplete=list)
+  //   - aria-autocomplete=list (canonical ARIA for async listbox)
+  //   - scanAccessibility-tagged field.isTypeahead === true
+  //   - Ashby's emotion-hashed _input_ class inside a _fieldEntry_ group
+  try {
+    const fieldIsTypeahead = !!(llmCtx && llmCtx.field && llmCtx.field.isTypeahead);
+    const domIsTypeahead = await triggerLocator.evaluate((el) => {
+      const probe = (n) => {
+        if (!n || n.nodeType !== 1) return false;
+        const role = n.getAttribute('role');
+        const ac = n.getAttribute('aria-autocomplete');
+        const hp = n.getAttribute('aria-haspopup');
+        if (ac === 'list' || ac === 'both') return true;
+        if (role === 'combobox' && (hp === 'listbox' || hp === 'true')) return true;
+        return false;
+      };
+      // 1. element itself
+      if (probe(el)) return true;
+      // 2. descendant input/combobox (when locator is wrapper or toggle button)
+      const innerSelectors = 'input[role="combobox"], [aria-autocomplete="list"], [aria-autocomplete="both"], [role="combobox"][aria-haspopup="listbox"]';
+      const inner = el.querySelector?.(innerSelectors);
+      if (probe(inner)) return true;
+      // 3. closest field-group, then re-descend (handles ATS-specific wrappers)
+      const groupSel = '[class*="_fieldEntry_"], .ashby-application-form-field-entry, .application-question, [data-question-id], [class*="formField"], .field';
+      const group = el.closest?.(groupSel);
+      if (group) {
+        const groupInner = group.querySelector(innerSelectors);
+        if (probe(groupInner)) return true;
+      }
+      // 4. Ashby's emotion-hashed input class as a supplementary signal
+      const cls = String(el.className || '');
+      if (/_input_/.test(cls) && el.closest?.('[class*="_fieldEntry_"], .ashby-application-form-field-entry')) return true;
+      return false;
+    }).catch(() => false);
+
+    if (fieldIsTypeahead || domIsTypeahead) {
+      const why = [];
+      if (fieldIsTypeahead) why.push('field.isTypeahead');
+      if (domIsTypeahead) why.push('dom signals');
+      console.log(`[smartFill] openAndPickOption: detected typeahead (${why.join(', ')}) → typeAndPickSuggestion first`);
+      const r = await typeAndPickSuggestion(root, triggerLocator, value);
+      if (r && r.ok) return r;
+      // Fall through to specialized + generic paths on no-match.
+      console.log(`[smartFill] typeahead path did not land (${r && r.reason}); falling through to generic dispatch.`);
+    }
+  } catch {}
+
   try {
     const rs = await tryReactSelect(root, triggerLocator, value);
     if (rs !== null) {
@@ -652,29 +713,6 @@ async function openAndPickOption(root, triggerLocator, value, llmCtx) {
     if (itlResult !== null && itlResult.ok) return itlResult;
   } catch {}
 
-  try {
-    // Ashby async typeahead. Ashby's Location field is role="combobox" with
-    // aria-haspopup="listbox" and an input class like `_input_v5ami_28`. It
-    // renders NO options until you type, then fetches matches over the
-    // network (~700ms) and shows them as [role="option"]. The generic
-    // open-and-look path opened it, saw an empty menu, and bailed — that's
-    // the Gen Digital "dropdown opened but no visible options found" failure.
-    // Detect Ashby's widget and route to type-then-wait-for-async-options.
-    const isAshbyCombo = await triggerLocator.evaluate((el) => {
-      const role = el.getAttribute('role');
-      const hasPopup = el.getAttribute('aria-haspopup');
-      const cls = String(el.className || '');
-      // Ashby's emotion-hashed input class, or the generic combobox+listbox shape.
-      const ashbyClass = /_input_/.test(cls) && !!el.closest('[class*="_fieldEntry_"], .ashby-application-form-field-entry');
-      return (role === 'combobox' && (hasPopup === 'listbox' || hasPopup === 'true')) || ashbyClass;
-    }).catch(() => false);
-    if (isAshbyCombo) {
-      const r = await typeAndPickSuggestion(root, triggerLocator, value);
-      if (r.ok) return r;
-      // If typeahead didn't land, fall through to the generic path below.
-    }
-  } catch {}
-
   try {
     // Workday combobox / multi-select. Workday wraps every form widget in a
     // [data-automation-id^="formField-"] container and its dropdowns mount a