halo-agent 2.0.5 → 2.0.6

package/detectFormErrors.js

@@ -143,14 +143,37 @@ async function detectFormErrors(page) {
       if (type === 'file') return !el.files || el.files.length === 0;
       // contenteditable: empty when innerText is whitespace.
       if (el.isContentEditable) return !(el.innerText || '').trim();
-      // Combobox role with no inner input (custom dropdown trigger): look
-      // for the displayed value via aria-activedescendant or innerText.
-      if (el.getAttribute('role') === 'combobox') {
+      // Combobox / custom-select: React-Select (which Greenhouse uses for
+      // ALL its dropdowns) renders the selected value as a
+      // .select__single-value or .select__multi-value chip INSIDE the
+      // control wrapper, NOT as the input's .value. We must look there or
+      // we falsely flag every filled dropdown as empty (the bug that made
+      // the retry re-pick Gender + Ethnicity).
+      if (el.getAttribute('role') === 'combobox' || tag === 'select') {
+        // Walk up to the React-Select control wrapper (a few class variants).
+        const wrap = el.closest(
+          '[class*="select__control"], [class*="select-control"], ' +
+          '[class*="select__value-container"], [class*="select"], ' +
+          '[class*="combobox"], [class*="Select"]'
+        ) || el.parentElement;
+        if (wrap) {
+          // Any rendered value chip → NOT empty.
+          const valueEl = wrap.querySelector(
+            '[class*="single-value"], [class*="multi-value"], ' +
+            '[class*="multiValue"], [class*="singleValue"], ' +
+            '[class*="chip"], [class*="tag"], [class*="__value"]'
+          );
+          if (valueEl && (valueEl.innerText || valueEl.textContent || '').trim()) return false;
+          // Also: the control's own text, minus the placeholder. If the
+          // control shows "Male" it's filled; if it shows "Select..." it's empty.
+          const wrapText = (wrap.innerText || '').trim();
+          const placeholderEl = wrap.querySelector('[class*="placeholder"]');
+          const placeholderText = placeholderEl ? (placeholderEl.innerText || '').trim() : '';
+          if (wrapText && wrapText !== placeholderText && !/^select\b|^choose\b|^\.\.\./i.test(wrapText)) {
+            return false;
+          }
+        }
         const v = (el.value || el.innerText || '').trim();
-        // Empty AND no chip/pill rendered as a sibling means truly empty.
-        const wrap = el.closest('[class*="select"], [class*="combobox"]');
-        const chip = wrap?.querySelector('[class*="chip"], [class*="multi-value"], [class*="tag"]');
-        if (chip && (chip.innerText || '').trim()) return false;
         return !v;
       }
       // Plain inputs / textareas

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "2.0.5",
+  "version": "2.0.6",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {

package/smartFill.js

@@ -362,6 +362,21 @@ async function openAndPickOption(page, triggerLocator, value, llmCtx) {
     }
 
     if (candidates.length === 0) {
+      // DIAGNOSTIC: dump the field's actual DOM so we can see what widget
+      // this really is (intl-tel? react-select? custom?). One-line summary
+      // of the element + its 2 nearest ancestors' classes + any sibling
+      // input/button. This is how we stop guessing selectors.
+      const diag = await triggerLocator.evaluate((el) => {
+        const summ = (n) => n ? `<${n.tagName.toLowerCase()} class="${(n.className || '').toString().slice(0, 120)}" role="${n.getAttribute?.('role') || ''}" aria-haspopup="${n.getAttribute?.('aria-haspopup') || ''}">` : 'null';
+        const p1 = el.parentElement;
+        const p2 = p1?.parentElement;
+        const siblingInputs = Array.from((p2 || p1 || el).querySelectorAll('input, button, [role="combobox"], [role="button"]'))
+          .slice(0, 5)
+          .map((s) => `${s.tagName.toLowerCase()}.${(s.className || '').toString().split(' ')[0]}`)
+          .join(', ');
+        return `self=${summ(el)} | p1=${summ(p1)} | p2=${summ(p2)} | nearby=[${siblingInputs}]`;
+      }).catch(() => 'diag failed');
+      console.warn(`[smartFill] DROPDOWN-DIAG: ${diag}`);
       await page.keyboard.press('Escape').catch(() => {});
       return { ok: false, reason: 'dropdown opened but no visible options found' };
     }