halo-agent 2.0.0 → 2.0.1

package/orchestrator.js

@@ -369,15 +369,46 @@ async function runJob(queueItem, chromeConn, config, reportStatus) {
       });
 
       if (visionResult.submitted) {
-        // Vision already submitted — we're done
+        // Vision THINKS it submitted, but we shouldn't trust that without
+        // verifying — vision can confuse "review page rendered" with
+        // "application accepted." Route through the same verify-submit
+        // gate everything else uses. Worst case → REVIEWING, user clicks
+        // Submit. Better than a false-positive DONE.
         const confirmShot = await page.screenshot({ type: 'jpeg', quality: 70 }).catch(() => null);
         const confirmKey = confirmShot ? await uploadScreenshot(config, confirmShot, `confirm_${queueId}.jpg`) : null;
-        await reportStatus('DONE', {
-          confirmation_screenshot_r2_key: confirmKey || null,
+        const verdictUrl = page.url();
+        let vVerdict = { submitted: null, error_message: null, source: 'unavailable' };
+        try {
+          const vRes = await fetch(`${config.apiUrl}/agent/verify-submit`, {
+            method: 'POST',
+            headers: { 'Content-Type': 'application/json', Authorization: `Bearer ${config.token}` },
+            body: JSON.stringify({ queue_id: queueId, page_url: verdictUrl }),
+          });
+          if (vRes.ok) vVerdict = await vRes.json();
+        } catch {}
+        if (vVerdict.submitted === true) {
+          await reportStatus('DONE', { confirmation_screenshot_r2_key: confirmKey || null, fields_filled: cumulativeFilled });
+          await clearCheckpoint(config, queueId);
+          console.log(`[orchestrator] Done via vision (verified): ${queueItem.company} - ${queueItem.title}`);
+          return;
+        }
+        if (vVerdict.submitted === false) {
+          await reportStatus('NEEDS_ATTENTION', {
+            review_screenshot_r2_key: confirmKey || null,
+            needs_attention_reason: `Vision submitted but ATS rejected: ${vVerdict.error_message || 'unknown'}`,
+            intervention_type: 'submit_failed',
+            step: 'VERIFY',
+            step_detail: (vVerdict.error_message || '').slice(0, 200),
+            fields_filled: cumulativeFilled,
+          });
+          throw new Error(`Vision-submit failed verification: ${vVerdict.error_message || 'unknown'}`);
+        }
+        await reportStatus('REVIEWING', {
+          review_screenshot_r2_key: confirmKey || null,
+          step: 'REVIEWING',
+          step_detail: 'Vision attempted submit — verifier unavailable, please eyeball',
           fields_filled: cumulativeFilled,
         });
-        await clearCheckpoint(config, queueId);
-        console.log(`[orchestrator] Done via vision: ${queueItem.company} - ${queueItem.title}`);
         return;
       }
 
@@ -474,31 +505,22 @@ async function runJob(queueItem, chromeConn, config, reportStatus) {
     }
 
     if (verdict.submitted === null) {
-      // Auto-submit mode means "don't ask me, just submit." If we can't
-      // verify but the user opted into hands-off, trust the click and
-      // mark DONE (the screenshot is the receipt; user can audit later).
-      // Without this, autoSubmit was silently being ignored every time
-      // Firecrawl was slow/down — exactly the case user hit.
-      const autoSubmit = config.autoSubmit || aep.agent_config?.auto_submit;
-      if (autoSubmit) {
-        console.log(`[orchestrator] Could not verify (source: ${verdict.source}) — auto-submit ON, trusting click.`);
-        await reportStatus('DONE', {
-          confirmation_screenshot_r2_key: confirmKey || null,
-          fields_filled: cumulativeFilled,
-        });
-        await clearCheckpoint(config, queueId);
-        console.log(`[orchestrator] Done (auto-submit, unverified): ${queueItem.company} - ${queueItem.title}`);
-        return;
-      }
-      console.warn(`[orchestrator] Could not verify submission (source: ${verdict.source}). Sending to REVIEWING for your eyeball.`);
+      // EARLIER VERSION: when auto-submit was ON, we trusted the click and
+      // marked DONE. That was wrong — it produced false-positive submissions
+      // (applied=true in DB, no actual application sent). Auto-submit means
+      // "don't make me click Submit on the dashboard" — it does NOT mean
+      // "lie about delivery."
+      //
+      // Honest behavior: unverified == REVIEWING regardless of auto-submit.
+      // The screenshot is right there in the dashboard, one click confirms.
+      // Better to over-ask than to ghost-apply.
+      console.warn(`[orchestrator] Could not verify submission (source: ${verdict.source}). REVIEWING — please eyeball the screenshot + click Submit.`);
       await reportStatus('REVIEWING', {
         review_screenshot_r2_key: confirmKey || null,
         step: 'REVIEWING',
-        step_detail: 'Could not auto-verify — please confirm the submit',
+        step_detail: `Submit clicked at ${verdictUrl.slice(0, 100)} — verifier unavailable, please confirm`,
         fields_filled: cumulativeFilled,
       });
-      // Stop here; user clicks Submit on dashboard → /apply-queue/submit/:id
-      // will flip to DONE. Don't return — let the function return naturally.
       return;
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {