halo-agent 1.3.3 → 1.3.4

package/filler.js

@@ -17,22 +17,11 @@ function jitter(base) {
  * Fires the full event sequence that frameworks listen for.
  */
 async function setFieldValue(page, selector, value) {
+  // Wrapper that delegates to the React-aware locator variant.
   try {
-    await page.locator(selector).first().waitFor({ timeout: 3000 });
-    await page.evaluate(({ sel, val }) => {
-      const el = document.querySelector(sel);
-      if (!el) return;
-      el.focus();
-      // React's synthetic event system requires using the native setter
-      const nativeInputValueSetter = Object.getOwnPropertyDescriptor(HTMLInputElement.prototype, 'value')?.set
-        || Object.getOwnPropertyDescriptor(HTMLTextAreaElement.prototype, 'value')?.set;
-      if (nativeInputValueSetter) nativeInputValueSetter.call(el, val);
-      el.dispatchEvent(new Event('focus', { bubbles: true }));
-      el.dispatchEvent(new Event('input', { bubbles: true }));
-      el.dispatchEvent(new Event('change', { bubbles: true }));
-      el.dispatchEvent(new Event('blur', { bubbles: true }));
-    }, { sel: selector, val: value });
-    return true;
+    const loc = page.locator(selector).first();
+    await loc.waitFor({ timeout: 3000 });
+    return await setFieldValueByHandle(page, loc, value);
   } catch {
     return false;
   }
@@ -41,23 +30,53 @@ async function setFieldValue(page, selector, value) {
 /**
  * Set a field value by Playwright element handle (used after semantic matching).
  */
-async function setFieldValueByHandle(page, elementHandle, value) {
+async function setFieldValueByHandle(page, elementOrLocator, value) {
+  // Strategy ladder, hardest-React-friendly first.
+  // The Reddit-Greenhouse run proved everything below the FIRST strategy
+  // fired but the field still appeared empty: React's controlled-input
+  // validator rejects programmatic value writes that don't go through a
+  // real event pipeline. Playwright's locator.fill() simulates a real
+  // user typing (pointerdown → focus → keystroke events → blur) and IS
+  // the only thing modern React forms (Greenhouse, Ashby, Lever, Workday)
+  // reliably accept. We try it first and fall back to native-setter only
+  // if Playwright's path fails (rare; mostly when the element isn't a
+  // standard input).
+
+  // 1. Playwright native fill — works for >99% of React forms
+  try {
+    await elementOrLocator.fill(String(value), { timeout: 5000 });
+    // Verify the value actually stuck (React might have rejected it)
+    const got = await elementOrLocator.inputValue({ timeout: 1000 }).catch(() => null);
+    if (got && got.trim()) return true;
+    // If empty after fill, React rejected it — fall through to manual setter
+  } catch {
+    // Locator may not support .fill() (custom div pretending to be input).
+    // Fall through.
+  }
+
+  // 2. Click + keyboard.type — slower but bullets through React harder
   try {
-    await page.evaluate(({ val }) => {
-      const el = arguments[0]; // handled via elementHandle approach below
-    }, { val: value });
-    // Use evaluate with the handle directly
-    await elementHandle.evaluate((el, val) => {
+    await elementOrLocator.click({ timeout: 2000 });
+    await elementOrLocator.fill('', { timeout: 2000 }).catch(() => {});
+    await page.keyboard.type(String(value), { delay: 20 });
+    const got = await elementOrLocator.inputValue({ timeout: 1000 }).catch(() => null);
+    if (got && got.trim()) return true;
+  } catch {}
+
+  // 3. Native setter dance — last resort for non-standard elements
+  try {
+    await elementOrLocator.evaluate((el, val) => {
       el.focus();
-      const nativeInputValueSetter = Object.getOwnPropertyDescriptor(HTMLInputElement.prototype, 'value')?.set
-        || Object.getOwnPropertyDescriptor(HTMLTextAreaElement.prototype, 'value')?.set;
-      if (nativeInputValueSetter) nativeInputValueSetter.call(el, val);
-      el.dispatchEvent(new Event('focus', { bubbles: true }));
+      const proto = el.tagName === 'TEXTAREA' ? HTMLTextAreaElement.prototype : HTMLInputElement.prototype;
+      const setter = Object.getOwnPropertyDescriptor(proto, 'value')?.set;
+      if (setter) setter.call(el, val); else el.value = val;
       el.dispatchEvent(new Event('input', { bubbles: true }));
       el.dispatchEvent(new Event('change', { bubbles: true }));
-      el.dispatchEvent(new Event('blur', { bubbles: true }));
-    }, value);
-    return true;
+      el.blur();
+    }, String(value));
+    // Verify
+    const got = await elementOrLocator.inputValue({ timeout: 1000 }).catch(() => null);
+    return !!(got && got.trim());
   } catch {
     return false;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {