halo-agent 1.2.2 → 1.3.0

package/browser.js

@@ -3,10 +3,19 @@
 const { chromium } = require('playwright');
 const { execSync, spawnSync, spawn } = require('child_process');
 const fs = require('fs');
+const path = require('path');
+const os = require('os');
 
 const CDP_PORT = 9222;
 const CDP_URL = `http://localhost:${CDP_PORT}`;
 
+// Dedicated user-data-dir for the agent's Chrome. Fully isolated from the
+// user's real Chrome so it can run side-by-side without profile-lock
+// collisions (which silently disable --remote-debugging-port). The
+// user logs into Workday / LinkedIn here ONCE on first run and the
+// session persists across runs because this dir is on disk, not /tmp.
+const AGENT_PROFILE_DIR = path.join(os.homedir(), '.halo-agent', 'chrome-profile');
+
 /**
  * Check if Chrome is already running with remote debugging on CDP_PORT.
  */
@@ -42,12 +51,22 @@ function findChromeMac() {
  */
 function launchChrome() {
   const platform = process.platform;
-  const flags = [
+
+  // Ensure the dedicated profile dir exists. Chrome will populate it on
+  // first launch (and persist cookies/logins there across runs).
+  try { fs.mkdirSync(AGENT_PROFILE_DIR, { recursive: true }); } catch {}
+
+  // Note: we use --user-data-dir (a full isolated dir), NOT --profile-directory
+  // (which is a sub-profile name inside the default user-data-dir and would
+  // still collide with the user's running Chrome and silently drop the
+  // --remote-debugging-port flag).
+  const baseFlags = [
     `--remote-debugging-port=${CDP_PORT}`,
-    '--profile-directory=Default',
+    `--user-data-dir=${AGENT_PROFILE_DIR}`,
     '--no-first-run',
     '--no-default-browser-check',
-  ].join(' ');
+    '--no-default-browser-check',
+  ];
 
   if (platform === 'darwin') {
     const chromePath = findChromeMac();
@@ -55,22 +74,11 @@ function launchChrome() {
       console.error('[halo-agent] Chrome not found. Install Google Chrome from https://www.google.com/chrome/');
       return;
     }
-    // CRITICAL: on macOS, spawning the Chrome executable directly while
-    // LaunchServices still has a Chrome instance registered (recent quit,
-    // dock icon still showing, etc.) causes the new launch to REACTIVATE
-    // the existing instance and silently DROP all --flags. Symptom: Chrome
-    // opens but without --remote-debugging-port, so the agent can never
-    // see it. `open -na` forces a fresh app instance and `--args` passes
-    // flags through reliably — this is the only correct way to launch
-    // Chrome with custom flags on macOS.
-    const splitFlags = [
-      `--remote-debugging-port=${CDP_PORT}`,
-      '--profile-directory=Default',
-      '--no-first-run',
-      '--no-default-browser-check',
-      '--restore-last-session',  // bring back the windows the user just had
-    ];
-    spawn('open', ['-na', chromePath, '--args', ...splitFlags], {
+    // `open -na` forces a fresh app instance (LaunchServices would otherwise
+    // reactivate the existing Chrome and drop our flags). Because we point
+    // at a dedicated --user-data-dir, this instance does NOT collide with
+    // the user's everyday Chrome — they can run side-by-side cleanly.
+    spawn('open', ['-na', chromePath, '--args', ...baseFlags], {
       detached: true,
       stdio: 'ignore',
     }).unref();
@@ -82,10 +90,12 @@ function launchChrome() {
     ];
     const chromePath = chromePaths.find(p => { try { fs.accessSync(p); return true; } catch { return false; } });
     if (!chromePath) { console.error('[halo-agent] Chrome not found on Windows.'); return; }
-    spawn(`"${chromePath}" ${flags}`, [], { shell: true, detached: true, stdio: 'ignore' }).unref();
+    const winFlags = baseFlags.map(f => f.includes(' ') ? `"${f}"` : f).join(' ');
+    spawn(`"${chromePath}" ${winFlags}`, [], { shell: true, detached: true, stdio: 'ignore' }).unref();
   } else {
     // Linux
-    spawn(`google-chrome ${flags}`, [], { shell: true, detached: true, stdio: 'ignore' }).unref();
+    const linuxFlags = baseFlags.map(f => f.includes(' ') ? `"${f}"` : f).join(' ');
+    spawn(`google-chrome ${linuxFlags}`, [], { shell: true, detached: true, stdio: 'ignore' }).unref();
   }
 }
 
@@ -166,11 +176,11 @@ async function connectToChrome(retries = 10, opts = {}) {
 
   console.log(''); // newline after dots
   throw new Error(
-    `Could not connect to Chrome after ${retries} attempts.\n` +
-    `Chrome may have launched without the --remote-debugging-port=9222 flag\n` +
-    `(macOS reactivates an existing Chrome instance and drops flags).\n` +
-    `Try: fully quit Chrome (Cmd+Q in every window + check the dock), then run:\n\n` +
-    `  halo-agent start\n`
+    `Could not connect to the agent's Chrome on port ${CDP_PORT} after ${retries} attempts.\n` +
+    `The agent uses an isolated Chrome profile at ${AGENT_PROFILE_DIR}.\n` +
+    `If a previous run is still alive, kill it:\n\n` +
+    `  pkill -f "user-data-dir=${AGENT_PROFILE_DIR}"\n\n` +
+    `Then run \`halo-agent start\` again.\n`
   );
 }
 

package/index.js

@@ -453,34 +453,16 @@ async function runStart() {
   console.log('\nHALO Agent starting...');
   console.log('Connecting to your Chrome browser...\n');
 
-  // Pre-check: Chrome must be running with --remote-debugging-port=9222 for
-  // CDP to work. If it's running WITHOUT that flag, Chrome can't have it
-  // added retroactively — it's a Chrome architecture limit. We offer to
-  // restart Chrome gracefully (preserves tabs via Chrome's "Continue where
-  // you left off" setting) and relaunch with the flag.
-  const { isChromeDebuggable } = require('./browser');
-  // weRestartedIt: tracks whether THIS process launched/restarted Chrome.
-  // When true, connectToChrome must NOT launch again — that's the double-
-  // launch bug that was spawning extra Chrome windows.
-  let weRestartedIt = false;
-  const alreadyDebuggable = await isChromeDebuggable();
-  if (!alreadyDebuggable) {
-    const needsRestart = await detectChromeRunningWithoutDebug();
-    if (needsRestart) {
-      const ok = await offerChromeRestart();
-      if (!ok) {
-        console.error('\nOK — leaving Chrome alone. Run `halo-agent start` again after you’ve quit Chrome.');
-        process.exit(1);
-      }
-      await restartChromeWithDebugFlag();
-      weRestartedIt = true;
-    }
-  }
-
+  // The agent runs its own isolated Chrome instance (separate --user-data-dir
+  // at ~/.halo-agent/chrome-profile) so it never collides with the user's
+  // everyday Chrome. First launch will be a blank profile — the user logs
+  // into Workday / LinkedIn ONCE in the agent's Chrome and those sessions
+  // persist across runs. No need to detect or restart the user's Chrome.
   let chromeConn;
   try {
-    chromeConn = await connectToChrome(10, { skipLaunch: weRestartedIt });
+    chromeConn = await connectToChrome(10);
     console.log('\nConnected to Chrome. Polling for queued jobs...');
+    console.log('First time? Log into Workday/LinkedIn in this Chrome window — sessions persist.');
     console.log('Go to your HALO dashboard and click "Auto-Apply" on any job.\n');
   } catch (err) {
     console.error('\nCould not connect to Chrome:', err.message);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "halo-agent",
-  "version": "1.2.2",
+  "version": "1.3.0",
   "description": "HALO local apply agent — auto-fills job applications using your real Chrome session",
   "main": "index.js",
   "bin": {