halfcycle 0.4.3 → 0.4.4

package/dist/confirm-identity.d.ts

@@ -235,27 +235,37 @@ export declare function describeAccount(serviceUrl: string, credential: string,
  * scrollback — and `--verbose` puts this run's id back on screen for the run that
  * wants it.
  *
- * WITH NO EMAIL the id is all there is, and it is printed: an unnamed account named by
- * its row is better than an unnamed account.
+ * WITH NO EMAIL BUT AN ANSWERED ACCOUNT the id is all there is, and it is printed —
+ * ONLY when `identity` itself is defined: an unnamed account named by its row is better
+ * than an unnamed account, but that is a claim about what `GET /account` just said, not
+ * about a credential this run merely holds. `(no email on record for it)` is the
+ * accepted exception to the "no internal words" scan precisely because it is scoped to
+ * this one case.
  *
- * WHEN NOTHING IS KNOWN IT SAYS SO, and does not invent. `'the account this machine
- * signed in as'` is a true sentence about an unnamed account; `'unknown'` printed where
- * a name goes reads as a name.
+ * **`identity === undefined` MEANS THE SAME THING EVERYWHERE THIS FUNCTION IS CALLED,
+ * AND IT MEANS "SAY NOTHING THAT CLAIMS AN ANSWER" (onboarding fix wave 2, F-01, the
+ * review's ruling on RW-02/RW-03 F-2, 2026-10-18).** `storedAccountId` is a credential
+ * this machine holds, not a fact the service stated — printing it, or printing
+ * "(no email on record for it)" beside it, asserts an answer this run never got.
+ * EVERY CALLER funnels through this one branch rather than deciding per-caller: `bin.ts`'s
+ * final report never reaches it (guarded by `identity !== undefined` before the call), and
+ * `confirm-identity.ts`'s own preamble (`accountLine`, gated the same way) and its stop
+ * remedy both go through it. The first cut of this fix gated only the preamble and left the
+ * stop remedy printing `account <id> (no email on record for it)` offline — the review's
+ * finding that fixing one caller and not the function itself reproduces the defect at the
+ * next call site.
  *
- * THE CALLER DECIDES WHETHER TO PRINT AT ALL, not this function. `bin.ts`'s final
- * report (E8, the wording batch, onboarding fix wave 2) only calls this when `GET
- * /account` actually answered with an account — a network error, a timeout, a 5xx
- * and a reached-but-unidentifiable answer (a 401/403) are all withheld there, rather
- * than printed through a `confirmed` flag here (onboarding fix wave T-16, #1567's
- * original shape, since removed: the flag's one caller was that same report line,
- * and the line it produced — "this run could not reach the service to confirm who
- * that is" — is now simply never printed, which is the more honest of the two). A
- * `storedAccountId` with no `identity` can still reach the "no email" branch below
- * through `confirm-identity.ts`'s OWN prompt line, a different surface with a
- * different, still-true claim: a stored or environment credential's cached id,
- * named while this run's own fresh identity read is still pending.
+ * **RETURNS `undefined` FOR THAT CASE RATHER THAN A SPLICED-IN NOUN PHRASE (round 2 of the
+ * same review, 2026-10-18).** A first attempt here returned a generic phrase ("the account
+ * this machine's saved sign-in belongs to" / "this credential's account") for every caller
+ * to interpolate — which reads naturally nowhere it is actually interpolated ("This
+ * machine's saved sign-in is for the account this machine's saved sign-in belongs to" / "is
+ * the credential for this credential's account"). Pushing the UNKNOWN case out to
+ * `undefined` keeps the one rule here (no id, no email claim, when `identity` is absent)
+ * while leaving each caller free to write its own grammatically whole sentence for that
+ * case — `armScript` below is the one caller that needs to, and does.
  */
-export declare function accountLabel(identity: AccountIdentity | undefined, storedAccountId: string | undefined, verbose?: boolean): string;
+export declare function accountLabel(identity: AccountIdentity | undefined, storedAccountId: string | undefined, verbose?: boolean): string | undefined;
 /**
  * Read one line from the terminal. Kept out of the decision so the decision is testable.
  * Also the Git for Windows offer's prompt (`pre-create-checks.ts`), so the terminal is

package/dist/confirm-identity.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"confirm-identity.d.ts","sourceRoot":"","sources":["../src/confirm-identity.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAoGG;AAGH,OAAO,EAAmD,KAAK,eAAe,EAAE,MAAM,mBAAmB,CAAC;AAI1G,OAAO,EAAiB,KAAK,cAAc,EAAE,KAAK,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAKtG,uFAAuF;AACvF,eAAO,MAAM,iBAAiB,sBAAsB,CAAC;AAErD,6CAA6C;AAC7C,MAAM,MAAM,gBAAgB,GAAG,SAAS,GAAG,gBAAgB,GAAG,MAAM,CAAC;AAErE,6FAA6F;AAC7F,MAAM,MAAM,UAAU,GAClB;IAAE,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;IAAC,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAA;CAAE,GACxD;IAAE,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,YAAY,EAAE,MAAM,CAAA;CAAE,CAAC;AAE1F,MAAM,WAAW,mBAAoB,SAAQ,cAAc;IACzD,8DAA8D;IAC9D,KAAK,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IAC/B,gFAAgF;IAChF,GAAG,CAAC,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,CAAC,CAAC;IAC5C;;;OAGG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,iEAAiE;IACjE,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB;;;;;;;;;;OAUG;IACH,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB;;;;;OAKG;IACH,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,oFAAoF;IACpF,SAAS,CAAC,EAAE,OAAO,KAAK,CAAC;CAC1B;AAeD;;;;;;;;;;GAUG;AACH,MAAM,WAAW,aAAa;IAC5B;;;OAGG;IACH,QAAQ,CAAC,QAAQ,EAAE,eAAe,GAAG,SAAS,CAAC;IAC/C;;;;;;;;OAQG;IACH,QAAQ,CAAC,OAAO,EAAE,OAAO,CAAC;IAC1B;;;;;;;;;;;OAWG;IACH,QAAQ,CAAC,OAAO,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAsB,UAAU,CAC9B,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,MAAM,EAClB,SAAS,GAAE,OAAO,KAAa,GAC9B,OAAO,CAAC,aAAa,CAAC,CAiBxB;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAsB,eAAe,CACnC,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,MAAM,EAClB,SAAS,GAAE,OAAO,KAAa,GAC9B,OAAO,CAAC,eAAe,GAAG,SAAS,CAAC,CAEtC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAiCG;AACH,wBAAgB,YAAY,CAC1B,QAAQ,EAAE,eAAe,GAAG,SAAS,EACrC,eAAe,EAAE,MAAM,GAAG,SAAS,EACnC,OAAO,UAAQ,GACd,MAAM,CASR;AAsCD;;;;GAIG;AACH,wBAAsB,OAAO,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAiB/D;AAED;;;;;;;;;GASG;AACH,wBAAgB,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,gBAAgB,CAK7D;AAoKD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAwCG;AACH,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,EAAE,WAAW,EAAE,OAAO,GAAG,MAAM,CAO3F;AAED;;;;;;;;;;GAUG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,kBAAkB,EAC9B,GAAG,EAAE,UAAU,EACf,IAAI,GAAE,mBAAwB,GAC7B,OAAO,CAAC,kBAAkB,CAAC,CAsD7B"}
+{"version":3,"file":"confirm-identity.d.ts","sourceRoot":"","sources":["../src/confirm-identity.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAoGG;AAGH,OAAO,EAAmD,KAAK,eAAe,EAAE,MAAM,mBAAmB,CAAC;AAI1G,OAAO,EAAiB,KAAK,cAAc,EAAE,KAAK,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAKtG,uFAAuF;AACvF,eAAO,MAAM,iBAAiB,sBAAsB,CAAC;AAErD,6CAA6C;AAC7C,MAAM,MAAM,gBAAgB,GAAG,SAAS,GAAG,gBAAgB,GAAG,MAAM,CAAC;AAErE,6FAA6F;AAC7F,MAAM,MAAM,UAAU,GAClB;IAAE,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;IAAC,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAA;CAAE,GACxD;IAAE,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,YAAY,EAAE,MAAM,CAAA;CAAE,CAAC;AAE1F,MAAM,WAAW,mBAAoB,SAAQ,cAAc;IACzD,8DAA8D;IAC9D,KAAK,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IAC/B,gFAAgF;IAChF,GAAG,CAAC,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,CAAC,CAAC;IAC5C;;;OAGG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,iEAAiE;IACjE,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB;;;;;;;;;;OAUG;IACH,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB;;;;;OAKG;IACH,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,oFAAoF;IACpF,SAAS,CAAC,EAAE,OAAO,KAAK,CAAC;CAC1B;AAeD;;;;;;;;;;GAUG;AACH,MAAM,WAAW,aAAa;IAC5B;;;OAGG;IACH,QAAQ,CAAC,QAAQ,EAAE,eAAe,GAAG,SAAS,CAAC;IAC/C;;;;;;;;OAQG;IACH,QAAQ,CAAC,OAAO,EAAE,OAAO,CAAC;IAC1B;;;;;;;;;;;OAWG;IACH,QAAQ,CAAC,OAAO,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAsB,UAAU,CAC9B,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,MAAM,EAClB,SAAS,GAAE,OAAO,KAAa,GAC9B,OAAO,CAAC,aAAa,CAAC,CAiBxB;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAsB,eAAe,CACnC,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,MAAM,EAClB,SAAS,GAAE,OAAO,KAAa,GAC9B,OAAO,CAAC,eAAe,GAAG,SAAS,CAAC,CAEtC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA2CG;AACH,wBAAgB,YAAY,CAC1B,QAAQ,EAAE,eAAe,GAAG,SAAS,EACrC,eAAe,EAAE,MAAM,GAAG,SAAS,EACnC,OAAO,UAAQ,GACd,MAAM,GAAG,SAAS,CAMpB;AAsCD;;;;GAIG;AACH,wBAAsB,OAAO,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAiB/D;AAED;;;;;;;;;GASG;AACH,wBAAgB,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,gBAAgB,CAK7D;AA0MD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAwCG;AACH,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,EAAE,WAAW,EAAE,OAAO,GAAG,MAAM,CAO3F;AAED;;;;;;;;;;GAUG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,kBAAkB,EAC9B,GAAG,EAAE,UAAU,EACf,IAAI,GAAE,mBAAwB,GAC7B,OAAO,CAAC,kBAAkB,CAAC,CAwD7B"}

package/dist/index.js

@@ -1356,12 +1356,20 @@ function createProjectIdentityFile(targetRepoRoot) {
 }
 
 // dist/install-manifest.js
+import { Buffer } from "node:buffer";
 import { createHash } from "node:crypto";
 var INSTALL_MANIFEST_REL = ".halfcycle/install-manifest.json";
 var INSTALL_MANIFEST_FORMAT = "halfcycle-install-manifest/v1";
 function sha256Hex(bytes) {
   return createHash("sha256").update(bytes).digest("hex");
 }
+function lineKey(line) {
+  return line.endsWith("\r") ? line.slice(0, -1) : line;
+}
+function fileSha256(bytes) {
+  const text = typeof bytes === "string" ? bytes : Buffer.from(bytes).toString("utf-8");
+  return sha256Hex(text.split("\n").map(lineKey).join("\n"));
+}
 function canonicalJson(value) {
   if (Array.isArray(value))
     return value.map(canonicalJson);
@@ -1544,7 +1552,7 @@ function startManifest(previous, isMember, isMemberDir) {
   };
 }
 function recordInstalledFile(draft, path, bytes) {
-  draft.files.set(path, { path, sha256: sha256Hex(bytes) });
+  draft.files.set(path, { path, sha256: fileSha256(bytes) });
 }
 function recordRemovedFile(draft, path) {
   draft.files.delete(path);
@@ -1871,17 +1879,17 @@ function sha256OfWhatThisVersionWrites(commands) {
   const out = /* @__PURE__ */ new Map();
   const fromFile = (rel, src) => {
     if (existsSync3(src))
-      out.set(rel, sha256Hex(readFileSync4(src)));
+      out.set(rel, fileSha256(readFileSync4(src)));
   };
   for (const cmd of commands)
     fromFile(commandStubRel(cmd.name), join5(BUNDLE_ROOT, ".claude-plugin", cmd.path));
   for (const [rel, content] of hookScriptsThisVersionWrites())
-    out.set(rel, sha256Hex(content));
+    out.set(rel, fileSha256(content));
   fromFile(CAPTURED_INDEX_REL, capturedIndexScaffold());
   return out;
 }
 function bytesAreOurs(path, bytes, recorded, writeSet) {
-  const hash = sha256Hex(bytes);
+  const hash = fileSha256(bytes);
   const recordedHash = recorded !== void 0 && "sha256" in recorded ? recorded.sha256 : void 0;
   return hash === recordedHash || hash === writeSet.generatedSha256.get(path);
 }
@@ -2069,16 +2077,17 @@ function writeCollisionSafe(targetAbsPath, targetRepoRoot, content, isOurs) {
     throw new Error(`[halfcycle] Write-allowlist violation: attempted to write "${rel}". Only the method surface and scaffolding paths are writable.`);
   }
   let replacedExisting = false;
-  if (existsSync3(targetAbsPath)) {
-    const current = readFileSync4(targetAbsPath);
-    if (current.toString("utf-8") === content)
+  const current = existsSync3(targetAbsPath) ? readFileSync4(targetAbsPath) : null;
+  const text = inLineEndingOf(current?.toString("utf-8") ?? null, content);
+  if (current !== null) {
+    if (current.toString("utf-8") === text)
       return { outcome: "skipped", replacedExisting: false };
     if (!isOurs(current))
       return { outcome: "collided", replacedExisting: false };
     replacedExisting = true;
   }
   mkdirSync4(dirname3(targetAbsPath), { recursive: true });
-  writeFileSync4(targetAbsPath, content, "utf-8");
+  writeFileSync4(targetAbsPath, text, "utf-8");
   return { outcome: "written", replacedExisting };
 }
 var INSTALLER_OWNED_DIR = ".halfcycle/";
@@ -2090,11 +2099,12 @@ function writeOwned(targetAbsPath, targetRepoRoot, content) {
   if (!rel.startsWith(INSTALLER_OWNED_DIR)) {
     throw new Error(`[halfcycle] Path-ownership violation: attempted to claim "${rel}" by path. Only ${INSTALLER_OWNED_DIR} is owned outright by this installer; everywhere else a differing file may be a developer's, so ownership must be proved from the file's own contents (writeOwnedGenerated) rather than assumed from where it sits.`);
   }
-  if (existsSync3(targetAbsPath) && readFileSync4(targetAbsPath, "utf-8") === content) {
+  const current = readFileOrNull(targetAbsPath);
+  const text = inLineEndingOf(current, content);
+  if (current === text)
     return "skipped";
-  }
   mkdirSync4(dirname3(targetAbsPath), { recursive: true });
-  writeFileSync4(targetAbsPath, content, "utf-8");
+  writeFileSync4(targetAbsPath, text, "utf-8");
   return "written";
 }
 var GENERATED_HEADER_LINE_INDEX = 1;
@@ -2496,13 +2506,13 @@ function adoptBlockUnderHeader(before, header, claimable) {
   }
   return claimed.length > 0 ? claimed.join("\n") + "\n" : "";
 }
-function lineKey(line) {
-  return line.endsWith("\r") ? line.slice(0, -1) : line;
-}
 function lineEndingOf(text) {
   const at = text.indexOf("\n");
   return at > 0 && text[at - 1] === "\r" ? "\r\n" : "\n";
 }
+function inLineEndingOf(existing, generated) {
+  return existing === null ? generated : generated.split("\n").join(lineEndingOf(existing));
+}
 function gitignoreCovers(content) {
   const lines = new Set(content.split("\n").map((l) => l.trim()));
   return REQUIRED_GITIGNORE_ENTRIES.every((entry) => lines.has(entry));
@@ -2595,7 +2605,8 @@ function writeBundlePin(targetRepoRoot, version, engagementId, engagementType, c
     ...projectPage !== void 0 ? { projectPage } : {}
   };
   const pinPath = join5(targetRepoRoot, BUNDLE_PIN_REL);
-  writeAllowlisted(pinPath, targetRepoRoot, JSON.stringify(pin, null, 2) + "\n", writtenPaths);
+  const pinText = inLineEndingOf(readFileOrNull(pinPath), JSON.stringify(pin, null, 2) + "\n");
+  writeAllowlisted(pinPath, targetRepoRoot, pinText, writtenPaths);
 }
 function writeCrewRoster(targetRepoRoot, report) {
   const doc = {
@@ -2743,7 +2754,7 @@ async function install(options) {
   }
   recordSettingsMerge(draft, existingSettings, generatedSettings, settingsPreexisted);
   const mergedSettings = mergeSettings(existingSettings, generatedSettings);
-  const mergedSettingsText = JSON.stringify(mergedSettings, null, 2) + "\n";
+  const mergedSettingsText = inLineEndingOf(readFileOrNull(settingsPath), JSON.stringify(mergedSettings, null, 2) + "\n");
   mkdirSync4(dirname3(settingsPath), { recursive: true });
   writeFileSync4(settingsPath, mergedSettingsText, "utf-8");
   (settingsPreexisted ? report.mergedPaths : report.writtenPaths).push(".claude/settings.json");
@@ -2771,7 +2782,7 @@ async function install(options) {
   if (credential) {
     const mcpPath = join5(targetRepo, MCP_REGISTRATION_REL);
     const existingMcp = existsSync3(mcpPath) ? readFileSync4(mcpPath, "utf-8") : null;
-    const mcpContent = generateMcpRegistration(existingMcp, credential.mcpUrl);
+    const mcpContent = inLineEndingOf(existingMcp, generateMcpRegistration(existingMcp, credential.mcpUrl));
     recordMcpMerge(draft, existingMcp, mcpContent);
     if (existingMcp === null) {
       writeAllowlisted(mcpPath, targetRepo, mcpContent, report.writtenPaths);