halfcycle 0.4.17 → 0.4.18

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "halfcycle",
-  "version": "0.4.17",
+  "version": "0.4.18",
   "description": "Halfcycle Method bundle — resolution-stub slash commands, remote method-delivery registration, and governance-hook wiring for a Halfcycle engagement repo. It ships NO worker role files: a project's roles are authored from that project's own recorded decisions at orchestration kickoff (FX-2, W3-F-27).",
   "commands": [
     {

package/bin/bin.bundle.mjs

@@ -18295,7 +18295,8 @@ var chatReviewAcceptRequestSchema = external_exports.object({
   act: external_exports.literal("accept"),
   reference: phaseIdentitySchema,
   reviewVersion: external_exports.number().int().min(0),
-  parts: external_exports.array(systemPartIdSchema).max(REVIEW_PARTS_MAX)
+  parts: external_exports.array(systemPartIdSchema).max(REVIEW_PARTS_MAX),
+  waitingClaims: external_exports.literal(true).optional()
 }).strict();
 function notedRequest(act) {
   return external_exports.object({
@@ -18310,12 +18311,20 @@ var chatReviewQuestionRequestSchema = notedRequest("question");
 var chatReviewSendBackRequestSchema = notedRequest("send-back");
 var chatReviewCarryRequestSchema = notedRequest("carry");
 var chatReviewDropRequestSchema = notedRequest("drop");
+var chatReviewRejectRequestSchema = external_exports.object({
+  act: external_exports.literal("reject"),
+  reference: phaseIdentitySchema,
+  reviewVersion: external_exports.number().int().min(0),
+  task: buildTaskIdSchema,
+  note: reviewNoteWireSchema
+}).strict();
 var chatReviewRequestSchema = external_exports.discriminatedUnion("act", [
   chatReviewAcceptRequestSchema,
   chatReviewQuestionRequestSchema,
   chatReviewSendBackRequestSchema,
   chatReviewCarryRequestSchema,
-  chatReviewDropRequestSchema
+  chatReviewDropRequestSchema,
+  chatReviewRejectRequestSchema
 ]);
 function bareOutcome2(outcome) {
   return external_exports.object({ outcome: external_exports.literal(outcome) }).strict();
@@ -18328,7 +18337,8 @@ var chatReviewResultSchema = external_exports.discriminatedUnion("outcome", [
   ...reviewDecisionResultSchema.options.filter(notTheConsoleNotDecidable),
   bareOutcome2("show-first"),
   bareOutcome2("not-offered"),
-  chatAmbiguousSchema
+  chatAmbiguousSchema,
+  bareOutcome2("nothing-waiting")
 ]);
 var reviewAnswerRequestSchema = external_exports.object({
   part: systemPartIdSchema,
@@ -30429,6 +30439,9 @@ function reviewPhraseShape(prompt) {
   const line2 = prompt.trim();
   if (LINE_BREAK.test(line2))
     return null;
+  const reject = REJECT_VERB.exec(line2);
+  if (reject !== null)
+    return rejectShape(line2.slice(reject[0].length));
   for (const [prefix, act] of VERBS) {
     const verb = prefix.exec(line2);
     if (verb === null)
@@ -30446,6 +30459,21 @@ function reviewPhraseShape(prompt) {
   }
   return null;
 }
+var REJECT_VERB = /^reject /i;
+function rejectShape(rest) {
+  const colon = rest.indexOf(":");
+  if (colon === -1)
+    return null;
+  const head = rest.slice(0, colon);
+  const slash = head.indexOf("/");
+  if (slash === -1)
+    return null;
+  const reference = head.slice(0, slash);
+  const task = head.slice(slash + 1);
+  if (!isValidPhaseIdentity(reference) || /\s/.test(task) || !buildTaskIdSchema.safeParse(task).success)
+    return null;
+  return { kind: "reject", reference, task, words: rest.slice(colon + 1).trim() };
+}
 function partShape(act, head, words) {
   const slash = head.indexOf("/");
   if (slash === -1)
@@ -30458,10 +30486,15 @@ function partShape(act, head, words) {
 }
 function matchReviewPhraseShape(shape, reviews) {
   const resolved = resolvePhaseReference(shape.reference, reviews);
-  const act = shape.kind === "phase" ? "accept" : shape.act;
+  const act = shape.kind === "phase" ? "accept" : shape.kind === "reject" ? "reject" : shape.act;
   if (resolved.kind === "ambiguous")
     return { kind: "ambiguous", act, entries: resolved.entries };
   const entry = resolved.kind === "found" ? resolved.entry : null;
+  if (shape.kind === "reject") {
+    if (entry === null)
+      return { kind: "show-first", act: "reject" };
+    return { kind: "reject", entry, reference: shape.reference, task: shape.task, words: shape.words };
+  }
   if (shape.kind === "phase") {
     if (entry === null)
       return { kind: "nothing" };
@@ -30650,6 +30683,8 @@ function reviewWrongActLine(name, built) {
 }
 function wordsActNoun(act) {
   switch (act) {
+    case "reject":
+      return "a rejection";
     case "question":
       return "a question";
     case "send-back":
@@ -30686,7 +30721,10 @@ function reviewPartNotListedLine(part, phase) {
   return line(`${NOTHING_RECORDED}: "${part}" is not a part of the review of ${namedPhase(phase)} as it was listed here.`);
 }
 function reviewNothingToAcceptLine(phase) {
-  return line(`${NOTHING_RECORDED}: no built part of ${namedPhase(phase)} waits for your decision.`);
+  return line(`${NOTHING_RECORDED}: no built part and no check nobody ran of ${namedPhase(phase)} waits for your decision.`);
+}
+function reviewNoClaimWaitingLine(task, phase) {
+  return line(`${NOTHING_RECORDED}: no check nobody ran on task "${task}" of ${namedPhase(phase)} waits for your answer. ${LIST_AGAIN} and copy the task from its reject line.`);
 }
 function reviewListedTooLongAgoLine(phase) {
   return line(`${NOTHING_RECORDED}: ${namedPhase(phase)} was listed an hour or more ago. ${LIST_AGAIN}, then type the line again within the hour.`);
@@ -30762,9 +30800,12 @@ function reviewRecordedLine(decided, phase, waiting) {
 }
 function reviewBulkRecordedLine(accepted, phase, waiting) {
   const named = namedPhase(phase);
-  const first = accepted === 1 ? `Recorded in your session: 1 part of ${named} accepted.` : `Recorded in your session: ${accepted} parts of ${named} accepted.`;
+  const first = accepted === 0 ? `Recorded in your session: any check nobody ran of ${named} that waited is accepted.` : accepted === 1 ? `Recorded in your session: 1 part of ${named} accepted, with any check nobody ran that waited.` : `Recorded in your session: ${accepted} parts of ${named} accepted, with any check nobody ran that waited.`;
   return line(`${first} ${stillWaiting(waiting)}`);
 }
+function reviewClaimsRejectedLine(task, phase, waiting) {
+  return line(`Recorded in your session: the checks nobody ran on task "${task}" are rejected, with your words. ${stillWaitingOf(phase, waiting)}`);
+}
 function reviewClosedLine(phase) {
   return `Recorded in your session. That was the last decision: phase ${namedPhase(phase)} is closed. Run its close step now, then tell the person what it says.`;
 }
@@ -30791,12 +30832,16 @@ function reviewLineForAnswer(context, answer) {
   switch (answer.outcome) {
     case "recorded": {
       if (answer.closed) {
-        return answer.decided.length === 0 ? reviewNoPartsClosedLine(phase) : reviewClosedLine(phase);
+        return context.listedParts === 0 ? reviewNoPartsClosedLine(phase) : reviewClosedLine(phase);
       }
+      if (context.task !== null)
+        return reviewClaimsRejectedLine(context.task, phase, answer.waiting);
       if (context.bulk)
         return reviewBulkRecordedLine(answer.decided.length, phase, answer.waiting);
       return reviewRecordedLine(answer.decided[0], phase, answer.waiting);
     }
+    case "nothing-waiting":
+      return context.task !== null ? reviewNoClaimWaitingLine(context.task, phase) : reviewNothingToAcceptLine(phase);
     case "review-changed":
       return reviewChangedLine(phase);
     case "no-review":
@@ -30977,14 +31022,22 @@ async function checkAndSendReview(match, engagementId, credential, env, opts) {
     return reviewListedTooLongAgoLine(entry.phase);
   let candidate;
   if (match.kind === "accept") {
-    if (entry.parts.length > 0 && match.parts.length === 0)
-      return reviewNothingToAcceptLine(entry.phase);
     candidate = {
       act: "accept",
       reference: match.reference,
       reviewVersion: entry.reviewVersion,
-      parts: match.parts.map((p) => p.part)
+      parts: match.parts.map((p) => p.part),
+      waitingClaims: true
     };
+  } else if (match.kind === "reject") {
+    const words = match.words;
+    if (words === "")
+      return reviewNoWordsLine("reject");
+    if (!reviewNoteWireSchema.safeParse(words).success)
+      return reviewWordsTooLongLine();
+    if (looksLikeSecret(words))
+      return reviewWordsLookSecretLine();
+    candidate = { act: "reject", reference: match.reference, reviewVersion: entry.reviewVersion, task: match.task, note: words };
   } else {
     const { act, part } = match;
     if (!reviewActsFor(part.built).includes(act))
@@ -31037,7 +31090,14 @@ async function postReview(bulk, entry, request, engagementId, credential, env, o
         return reviewCannotReachLine();
       moveListedReviewForward(engagementId, opts.home, entry, answer.reviewVersion, answer.decided);
     }
-    return reviewLineForAnswer({ act: request.act, bulk, phase: entry.phase, number: entry.number }, answer);
+    return reviewLineForAnswer({
+      act: request.act,
+      bulk,
+      phase: entry.phase,
+      number: entry.number,
+      listedParts: entry.parts.length,
+      task: request.act === "reject" ? request.task : null
+    }, answer);
   } catch {
     return reviewCannotReachLine();
   } finally {

package/dist/cli.js

@@ -4851,7 +4851,8 @@ var chatReviewAcceptRequestSchema = z30.object({
   act: z30.literal("accept"),
   reference: phaseIdentitySchema,
   reviewVersion: z30.number().int().min(0),
-  parts: z30.array(systemPartIdSchema).max(REVIEW_PARTS_MAX)
+  parts: z30.array(systemPartIdSchema).max(REVIEW_PARTS_MAX),
+  waitingClaims: z30.literal(true).optional()
 }).strict();
 function notedRequest(act) {
   return z30.object({
@@ -4866,12 +4867,20 @@ var chatReviewQuestionRequestSchema = notedRequest("question");
 var chatReviewSendBackRequestSchema = notedRequest("send-back");
 var chatReviewCarryRequestSchema = notedRequest("carry");
 var chatReviewDropRequestSchema = notedRequest("drop");
+var chatReviewRejectRequestSchema = z30.object({
+  act: z30.literal("reject"),
+  reference: phaseIdentitySchema,
+  reviewVersion: z30.number().int().min(0),
+  task: buildTaskIdSchema,
+  note: reviewNoteWireSchema
+}).strict();
 var chatReviewRequestSchema = z30.discriminatedUnion("act", [
   chatReviewAcceptRequestSchema,
   chatReviewQuestionRequestSchema,
   chatReviewSendBackRequestSchema,
   chatReviewCarryRequestSchema,
-  chatReviewDropRequestSchema
+  chatReviewDropRequestSchema,
+  chatReviewRejectRequestSchema
 ]);
 function bareOutcome2(outcome) {
   return z30.object({ outcome: z30.literal(outcome) }).strict();
@@ -4884,7 +4893,8 @@ var chatReviewResultSchema = z30.discriminatedUnion("outcome", [
   ...reviewDecisionResultSchema.options.filter(notTheConsoleNotDecidable),
   bareOutcome2("show-first"),
   bareOutcome2("not-offered"),
-  chatAmbiguousSchema
+  chatAmbiguousSchema,
+  bareOutcome2("nothing-waiting")
 ]);
 var reviewAnswerRequestSchema = z30.object({
   part: systemPartIdSchema,
@@ -5348,8 +5358,8 @@ function autonomyA13(accepted, carried) {
   return `Your autonomy setting accepted the ${String(accepted)} built parts and carried ${String(carried)} unbuilt parts forward. The phase is closed.`;
 }
 function autonomyA14(count, parts, acceptLine) {
-  const typed = acceptLine === null ? 'say "review what was built" and type the lines it gives.' : `say "review what was built", then type ${acceptLine}.`;
-  return `The phase waits for you: ${String(count)} tests the agents said pass were not run by Halfcycle, so ${namesOf(parts)} wait for you too. Only you can accept or reject those tests, in the console's review; that cannot be done by typing in chat. Then decide those parts there, or in your own Claude Code session: ` + typed;
+  const typed = acceptLine === null ? 'say "review what was built" and type the lines it gives.' : `say "review what was built", then type ${acceptLine} to accept them with those parts, or type the reject line it gives for a task's tests.`;
+  return `The phase waits for you: ${String(count)} tests the agents said pass were not run by Halfcycle, so ${namesOf(parts)} wait for you too. Only you can accept or reject those tests. In your own Claude Code session, ` + typed;
 }
 function autonomyA15(count) {
   return `The phase waits for you: ${String(count)} parts were built without an approved scope, and only you can decide them.`;
@@ -7413,12 +7423,13 @@ ${GENERATED_USER_PROMPT_SCOPE_HEADER} the Halfcycle installer, now also for the
 # own on or off, by typing one line as the whole prompt in their own Claude
 # Code session: "approve <phase>", "send back <phase>: <note>", "accept
 # <phase>/<part>", "question <phase>/<part>: <words>", "carry <phase>/<part>:
-# <words>", "drop <phase>/<part>: <words>", "autonomy on" or "autonomy off".
+# <words>", "drop <phase>/<part>: <words>", "reject <phase>/<task>: <words>",
+# "autonomy on" or "autonomy off".
 #
 # AN ORDINARY PROMPT STARTS NOTHING. This script reads the hook input once and
 # looks only at the start of the prompt's value. Unless the prompt begins, after
 # any whitespace (typed, or escaped in the input), with "approve ", "send back ",
-# "accept ", "question ", "carry ", "drop " or "autonomy ", in any case, it exits
+# "accept ", "question ", "carry ", "drop ", "reject " or "autonomy ", in any case, it exits
 # 0 with no output, and Node never starts. A quote inside any other field arrives
 # escaped, so no other field (the folder the session is in, for one) can read as
 # the start of the prompt.
@@ -7442,7 +7453,7 @@ IFS= read -r -d '' HC_INPUT || true
 # \\u escape, or as the UTF-8 bytes of a Unicode space. Compared byte for byte.
 HC_LEAD='[[:space:]]|\\\\[nrtf]|\\\\u(000[9a-d]|0020|00a0|1680|200[0-9a]|202[89f]|205f|3000|feff)'
 HC_LEAD="$HC_LEAD|"$'\\xc2\\xa0|\\xe1\\x9a\\x80|\\xe2\\x80[\\x80-\\x8a\\xa8\\xa9\\xaf]|\\xe2\\x81\\x9f|\\xe3\\x80\\x80|\\xef\\xbb\\xbf'
-if ! printf '%s' "$HC_INPUT" | LC_ALL=C grep -Eiq "\\"prompt\\"[[:space:]]*:[[:space:]]*\\"($HC_LEAD)*(approve|send back|accept|question|carry|drop|autonomy) "; then
+if ! printf '%s' "$HC_INPUT" | LC_ALL=C grep -Eiq "\\"prompt\\"[[:space:]]*:[[:space:]]*\\"($HC_LEAD)*(approve|send back|accept|question|carry|drop|reject|autonomy) "; then
   exit 0
 fi
 
@@ -12927,23 +12938,36 @@ function typedLine(act, reference, part) {
       return `drop ${reference}/${part}: <why>`;
   }
 }
-function rv7Lines(view) {
+function rv7aLine(reference) {
+  return `The line accept ${reference} also accepts every check nobody ran that is listed below. Reject a task's checks first if you do not accept them.`;
+}
+function tasksWithWaitingClaims(claims) {
+  return [...new Set(claims.filter((c) => c.answer === null).map((c) => c.task))];
+}
+function rv7Lines(view, claims) {
   const reference = typedPhaseReference(view.phase, view.number);
-  if (view.parts.length === 0)
-    return [`This phase has no parts to review. To close it, type: accept ${reference}`];
+  const claimTasks = tasksWithWaitingClaims(claims);
   const decidable = view.parts.filter((p) => p.decidable);
-  if (decidable.length === 0)
-    return ["No part waits for your decision now."];
+  if (claimTasks.length === 0) {
+    if (view.parts.length === 0)
+      return [`This phase has no parts to review. To close it, type: accept ${reference}`];
+    if (decidable.length === 0)
+      return ["No part waits for your decision now."];
+  }
   const lines = ["To decide, type one of these lines in your own Claude Code session:"];
   for (const part of decidable) {
     for (const act of reviewActsFor(part.built))
       lines.push(`  ${typedLine(act, reference, part.part)}`);
   }
-  if (decidable.some((p) => p.built))
+  for (const task of claimTasks)
+    lines.push(`  reject ${reference}/${task}: <why>`);
+  if (decidable.some((p) => p.built) || claimTasks.length > 0)
     lines.push(`  accept ${reference}`);
+  if (claimTasks.length > 0)
+    lines.push(rv7aLine(reference));
   return lines;
 }
-function reviewListingLines(view) {
+function reviewListingLines(view, claims = []) {
   const lines = [rv1Line(view)];
   if (!view.counted)
     lines.push(RV1A_LINE);
@@ -12951,7 +12975,7 @@ function reviewListingLines(view) {
     lines.push(...observedPhaseLines(view.observed));
   for (const part of view.parts)
     lines.push(...partLines(part, view));
-  lines.push(...rv7Lines(view));
+  lines.push(...rv7Lines(view, claims));
   return lines;
 }
 var CALLS_HEADING2 = "Calls made without asking you";
@@ -12976,21 +13000,17 @@ var CHECKS_SUBHEADING = "An agent says these pass and Halfcycle never ran them.
 function uncheckedClaimLine(test) {
   return `Unchecked: ${test.claimedBy} says "${test.label}" passes. Halfcycle never ran it.`;
 }
-function answerClaimsInSystemViewLine(engagementId, phase) {
-  const address = systemViewUrl(engagementId, phase);
-  const only = "Accept or reject each one in the System view; this cannot be done by typing in chat";
-  return address === void 0 ? `${only}.` : `${only}: ${address}`;
-}
-function checksSectionLines(work, engagementId) {
+var ANSWER_CLAIMS_BY_TYPING_LINE = "To answer them, type the reject or accept line listed above in your own Claude Code session.";
+function checksSectionLines(work) {
   const unchecked = work.tasks.flatMap((task) => task.tests.filter((t) => t.state === "unchecked"));
   if (unchecked.length === 0)
     return [];
-  return [CHECKS_HEADING, CHECKS_SUBHEADING, ...unchecked.map(uncheckedClaimLine), answerClaimsInSystemViewLine(engagementId, work.phase)];
+  return [CHECKS_HEADING, CHECKS_SUBHEADING, ...unchecked.map(uncheckedClaimLine), ANSWER_CLAIMS_BY_TYPING_LINE];
 }
-function workSectionLines(work, engagementId) {
+function workSectionLines(work, _engagementId) {
   if (work === null)
     return [];
-  return [...callsSectionLines(work.calls), ...checksSectionLines(work, engagementId)];
+  return [...callsSectionLines(work.calls), ...checksSectionLines(work)];
 }
 function rv8Line(view) {
   if (view.state === "closed") {
@@ -13132,7 +13152,8 @@ async function runReviewShow(repoRoot, phase, deps) {
   if (view.state !== "open")
     return refused(rv8Line(view));
   const work = await deps.readWork(credential, phase);
-  const stdout = `${[...reviewListingLines(view), ...workSectionLines(work.kind === "work" ? work.work : null, credential.engagementId)].join("\n")}
+  const phaseWork = work.kind === "work" ? work.work : null;
+  const stdout = `${[...reviewListingLines(view, phaseWork?.uncheckedClaims ?? []), ...workSectionLines(phaseWork, credential.engagementId)].join("\n")}
 `;
   const written = deps.recordShown(credential.engagementId, shownReviewEntry(view, deps.now().toISOString()));
   if (!written.ok)