halfcycle 0.4.10 → 0.4.11

package/dist/index.js

@@ -2082,11 +2082,16 @@ var phaseReviewViewSchema = z13.discriminatedUnion("state", [
 
 // ../events/dist/build-record-v3.js
 var BUILD_RECORD_V3_FORMAT = "halfcycle-build-record/v3";
+var recordRoundStatedSchema = z14.object({
+  actor: attestedCloseSchema.shape.actor,
+  statements: attestedStatementsSchema
+}).strict();
 var recordReviewRoundSchema = z14.object({
   round: z14.number().int().min(1),
   openedAt: utcIso8601,
   verdict: walkVerdictSchema,
-  findings: z14.number().int().min(0)
+  findings: z14.number().int().min(0),
+  stated: recordRoundStatedSchema.optional()
 }).strict();
 var recordReviewApprovalSchema = z14.discriminatedUnion("kind", [
   z14.object({
@@ -2148,6 +2153,9 @@ var recordReviewSchema = z14.object({
     if (r.round !== i + 1) {
       ctx.addIssue({ code: "custom", path: ["rounds", i, "round"], message: "rounds must be numbered 1, 2, 3 \u2026 in order with no gap" });
     }
+    if (i === v.rounds.length - 1 && r.stated !== void 0) {
+      ctx.addIssue({ code: "custom", path: ["rounds", i, "stated"], message: "the last round's words are the close's own, so the round does not repeat them" });
+    }
   });
   const seen = /* @__PURE__ */ new Set();
   v.parts.forEach((p, i) => {
@@ -5226,12 +5234,13 @@ function machines(coverage, checks) {
   const line = `${label}${String(coverage.enrolled)}. Of these, ${String(coverage.conformant)} had reported Halfcycle's checks as fully set up.`;
   return checks === "not-observed" && coverage.conformant > 0 ? `${line} Set up is not the same as running: Halfcycle has no record of any check running during this phase.` : line;
 }
-function walkLines(walk, p) {
+function walkLines(walk, p, closingRound = false) {
   const label = "> - Acceptance walk (the finished work tried as a user would, by someone other than its builder): ";
   if (walk === null)
     return [`${label}the person closing the phase reported none.`];
+  const it = closingRound ? "the round that closed the phase" : "it";
   const lines = [
-    `${label}${walk.verdict === "clean" ? "the person closing the phase said it found no problems." : "the person closing the phase said it found problems."}`
+    `${label}${walk.verdict === "clean" ? `the person closing the phase said ${it} found no problems.` : `the person closing the phase said ${it} found problems.`}`
   ];
   walk.findings.forEach((finding, i) => {
     lines.push(`>   - Finding ${String(i + 1)}: ${p.text(finding)}`);
@@ -5250,12 +5259,12 @@ function decisionLine(attested) {
   }
   return attested.walk !== null && attested.walk.verdict === "defects" ? "> - Decision: close the phase as it stood, with the problems its acceptance walk found." : "> - Decision: the phase's agreed finish conditions were met.";
 }
-function renderStated(attested, p) {
+function renderStated(attested, p, closingRound = false) {
   const lines = [
     decisionLine(attested),
     `> - Name given: ${attested.actor === null ? "removed with the account that made this close" : p.text(attested.actor)}`,
     `> - Reason given: ${attested.reason === null ? "none." : p.text(attested.reason)}`,
-    ...walkLines(attested.walk, p),
+    ...walkLines(attested.walk, p, closingRound),
     `> - Code closed at (commit): ${statedOrNot(attested.closeCommit, p)}`,
     `> - What the phase set out to prove: ${statedOrNot(attested.statements.thesis, p)}`,
     `> - What came out of it: ${statedOrNot(attested.statements.outcome, p)}`
@@ -5271,7 +5280,7 @@ function renderStated(attested, p) {
   }
   return lines.join("\n");
 }
-function renderClose(heading, observed, attested, checks, p) {
+function renderClose(heading, observed, attested, checks, p, closingRound = false) {
   return [
     heading,
     headline(observed, attested, checks),
@@ -5283,7 +5292,7 @@ function renderClose(heading, observed, attested, checks, p) {
       machines(observed.seatCoverage, checks)
     ].join("\n"),
     STATED_LABEL,
-    renderStated(attested, p)
+    renderStated(attested, p, closingRound)
   ];
 }
 var REVIEW_LABEL = "**Recorded by Halfcycle from the owner's review.** Each part the review held, and how the project's owner decided it. A line marked as the agent's is the agent's own answer, not Halfcycle's.";
@@ -5332,6 +5341,37 @@ function renderReview(record2, p) {
     blocks.push(removals);
   return blocks;
 }
+var EARLIER_ROUNDS_LABEL = `${STATED_LABEL} What was said each time the owner's review was asked for, before the round that closed the phase. What was said for that last round is under the close above. If the account that asked for a round is later deleted, the name given for that round is removed.`;
+function renderRoundStated(round, stated, p) {
+  const label = "> - Acceptance walk (the finished work tried as a user would, by someone other than its builder): ";
+  const walk = round.verdict === "clean" ? "the person asking for this round said it found no problems." : round.findings === 0 ? "the person asking for this round said it found problems." : `the person asking for this round said it found ${counted(round.findings, "problem", "problems")}.`;
+  const lines = [
+    `> - Name given: ${stated.actor === null ? "removed with the account that asked for this round" : p.text(stated.actor)}`,
+    `${label}${walk}`,
+    `> - What the phase set out to prove: ${statedOrNot(stated.statements.thesis, p)}`,
+    `> - What came out of it: ${statedOrNot(stated.statements.outcome, p)}`
+  ];
+  const deviations = stated.statements.deviations;
+  if (deviations.length === 0) {
+    lines.push("> - Changes from the plan: None stated by the client.");
+  } else {
+    lines.push("> - Changes from the plan:");
+    deviations.forEach((deviation, i) => {
+      lines.push(`>   - Change ${String(i + 1)}: ${p.text(deviation)}`);
+    });
+  }
+  return lines.join("\n");
+}
+function renderEarlierRounds(record2, p) {
+  const rounds = record2.review.rounds;
+  const blocks = [];
+  for (const round of rounds) {
+    if (round.stated === void 0)
+      continue;
+    blocks.push(`### Round ${String(round.round)} of ${String(rounds.length)}`, renderRoundStated(round, round.stated, p));
+  }
+  return blocks.length === 0 ? [] : ["## Earlier rounds of the review", EARLIER_ROUNDS_LABEL, ...blocks];
+}
 function renderBuildRecordV2Markdown(record2) {
   const p = makePrinter();
   const attestedBySequence = /* @__PURE__ */ new Map();
@@ -5345,6 +5385,8 @@ function renderBuildRecordV2Markdown(record2) {
   const closes = [...record2.observed.closes].sort((a, b) => a.sequence - b.sequence);
   const total = closes.length;
   const latest = closes[total - 1];
+  const rounds = record2.format === "halfcycle-build-record/v3" ? record2.review.rounds : [];
+  const roundsAfter = rounds.length <= 1 ? null : `after ${String(rounds.length)} rounds of the owner's review.${rounds.some((r) => r.stated !== void 0) ? ' What was said for each earlier round is under "Earlier rounds of the review".' : ""}`;
   const body = [
     `Phase: ${phase} (the name the client gave it)`,
     OBSERVED_LABEL,
@@ -5353,12 +5395,12 @@ function renderBuildRecordV2Markdown(record2) {
       `- Project identifier: ${p.text(record2.observed.engagementId)}. Halfcycle keeps this project's records under this identifier.`,
       `- Record format: ${p.text(record2.format)}. This names the layout this file and the .json file beside it follow, for software that reads them.`
     ].join("\n"),
-    total === 1 ? "This phase was closed once." : `This phase was closed ${String(total)} times. The latest close is described first; each earlier close follows, as it was recorded when it was made.`,
+    total === 1 ? roundsAfter === null ? "This phase was closed once." : `This phase was closed once, ${roundsAfter}` : `This phase was closed ${String(total)} times. The latest close is described first; each earlier close follows, as it was recorded when it was made.${roundsAfter === null ? "" : ` The latest close came ${roundsAfter}`}`,
     ...renderChecks(record2.observed.checks, p),
-    ...renderClose(total === 1 ? "## The close" : `## The latest close (close ${String(latest.sequence)} of ${String(total)})`, latest, attestedBySequence.get(latest.sequence), record2.observed.checks.state, p)
+    ...renderClose(total === 1 ? "## The close" : `## The latest close (close ${String(latest.sequence)} of ${String(total)})`, latest, attestedBySequence.get(latest.sequence), record2.observed.checks.state, p, rounds.length > 1)
   ];
   if (record2.format === "halfcycle-build-record/v3")
-    body.push(...renderReview(record2, p));
+    body.push(...renderReview(record2, p), ...renderEarlierRounds(record2, p));
   if (total > 1) {
     body.push("## Earlier closes");
     for (const close of closes.slice(0, -1)) {