hackmud-script-manager 0.20.4-52a588b → 0.20.4-66e0e13

package/processScript/transform.js

@@ -22,7 +22,8 @@ const { default: traverse } = babelTraverse,
 		"BigInt"
 	]
 function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scriptName, seclevel = 4 }) {
-	const topFunctionName = `_${uniqueId}_SCRIPT_`
+	const warnings = [],
+		topFunctionName = `_${uniqueId}_SCRIPT_`
 	let program
 	traverse(file, {
 		Program(path) {
@@ -44,9 +45,17 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 				referencePath.replaceWith(t.identifier(`_${uniqueId}_SCRIPT_USER_`))
 			} else
 				referencePath.replaceWith(t.stringLiteral(1 == scriptUser ? `$${uniqueId}$SCRIPT_USER$` : scriptUser))
-	if (program.scope.hasGlobal("_SCRIPT_NAME"))
+	if (program.scope.hasGlobal("_SCRIPT_NAME")) {
+		warnings.push({
+			message:
+				"Global _SCRIPT_NAME is deprecated and will be removed in the next minor release of HSM, use _SCRIPT_SUBNAME instead"
+		})
 		for (const referencePath of getReferencePathsToGlobal("_SCRIPT_NAME", program))
 			referencePath.replaceWith(t.stringLiteral(1 == scriptName ? `$${uniqueId}$SCRIPT_NAME$` : scriptName))
+	}
+	if (program.scope.hasGlobal("_SCRIPT_SUBNAME"))
+		for (const referencePath of getReferencePathsToGlobal("_SCRIPT_SUBNAME", program))
+			referencePath.replaceWith(t.stringLiteral(1 == scriptName ? `$${uniqueId}$SCRIPT_NAME$` : scriptName))
 	if (program.scope.hasGlobal("_FULL_SCRIPT_NAME"))
 		for (const referencePath of getReferencePathsToGlobal("_FULL_SCRIPT_NAME", program))
 			if (1 == scriptUser || 1 == scriptName)
@@ -68,30 +77,30 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 			const referencePath = FunctionReferencePaths[0]
 			assert(
 				"MemberExpression" == referencePath.parent.type,
-				"src/processScript/transform.ts:103:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+				"src/processScript/transform.ts:111:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 			)
 			assert(
 				"Identifier" == referencePath.parent.property.type,
-				"src/processScript/transform.ts:108:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+				"src/processScript/transform.ts:116:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 			)
 			assert(
 				"prototype" == referencePath.parent.property.name,
-				"src/processScript/transform.ts:113:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+				"src/processScript/transform.ts:121:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 			)
 			referencePath.parentPath.replaceWith(createGetFunctionPrototypeNode())
 		} else {
 			for (const referencePath of FunctionReferencePaths) {
 				assert(
 					"MemberExpression" == referencePath.parent.type,
-					"src/processScript/transform.ts:121:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+					"src/processScript/transform.ts:129:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 				)
 				assert(
 					"Identifier" == referencePath.parent.property.type,
-					"src/processScript/transform.ts:126:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+					"src/processScript/transform.ts:134:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 				)
 				assert(
 					"prototype" == referencePath.parent.property.name,
-					"src/processScript/transform.ts:131:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+					"src/processScript/transform.ts:139:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 				)
 				functionDotPrototypeIsReferencedMultipleTimes = !0
 				referencePath.parentPath.replaceWith(t.identifier(`_${uniqueId}_FUNCTION_DOT_PROTOTYPE_`))
@@ -127,12 +136,12 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	const neededDbMethodLets = new Set()
 	if (program.scope.hasGlobal("$db"))
 		for (const referencePath of getReferencePathsToGlobal("$db", program)) {
-			assert("MemberExpression" == referencePath.parentPath.node.type, "src/processScript/transform.ts:185:69")
-			assert("Identifier" == referencePath.parentPath.node.property.type, "src/processScript/transform.ts:186:72")
+			assert("MemberExpression" == referencePath.parentPath.node.type, "src/processScript/transform.ts:193:69")
+			assert("Identifier" == referencePath.parentPath.node.property.type, "src/processScript/transform.ts:194:72")
 			const databaseOpMethodName = referencePath.parentPath.node.property.name
 			assert(
 				validDBMethods.includes(databaseOpMethodName),
-				`src/processScript/transform.ts:192:8 invalid db method "${databaseOpMethodName}", valid db methods are "${validDBMethods.join('", "')}"`
+				`src/processScript/transform.ts:200:8 invalid db method "${databaseOpMethodName}", valid db methods are "${validDBMethods.join('", "')}"`
 			)
 			if ("CallExpression" == referencePath.parentPath.parentPath?.type)
 				referencePath.parentPath.replaceWith(t.identifier(`$${uniqueId}$DB$${databaseOpMethodName}$`))
@@ -162,21 +171,25 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	if (program.scope.hasGlobal("_SECLEVEL"))
 		for (const referencePath of getReferencePathsToGlobal("_SECLEVEL", program))
 			referencePath.replaceWith(t.numericLiteral(seclevel))
-	let needGetPrototypeOf = !1
+	let needGetPrototypeOf = !1,
+		needHasOwn = !1
 	if (program.scope.hasGlobal("Object"))
 		for (const referencePath of getReferencePathsToGlobal("Object", program))
 			if ("MemberExpression" == referencePath.parent.type && !referencePath.parent.computed) {
-				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:241:64")
+				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:250:64")
 				if ("getPrototypeOf" == referencePath.parent.property.name) {
 					referencePath.parentPath.replaceWith(t.identifier(`_${uniqueId}_GET_PROTOTYPE_OF_`))
 					needGetPrototypeOf = !0
+				} else if ("hasOwn" == referencePath.parent.property.name) {
+					referencePath.parentPath.replaceWith(t.identifier(`_${uniqueId}_HAS_OWN_`))
+					needHasOwn = !0
 				}
 			}
 	const consoleMethodsReferenced = new Set()
 	if (program.scope.hasGlobal("console"))
 		for (const referencePath of getReferencePathsToGlobal("console", program))
 			if ("MemberExpression" == referencePath.parent.type && !referencePath.parent.computed) {
-				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:256:64")
+				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:268:64")
 				referencePath.parentPath.replaceWith(
 					t.identifier(`_${uniqueId}_CONSOLE_METHOD_${referencePath.parent.property.name}_`)
 				)
@@ -184,13 +197,13 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 			}
 	const lastStatement = program.node.body.at(-1)
 	let exportDefaultName
-	assert(lastStatement, "src/processScript/transform.ts:270:27 program is empty")
+	assert(lastStatement, "src/processScript/transform.ts:282:27 program is empty")
 	if ("ExportNamedDeclaration" == lastStatement.type) {
 		program.node.body.pop()
 		for (const specifier of lastStatement.specifiers) {
 			assert(
 				"ExportSpecifier" == specifier.type,
-				`src/processScript/transform.ts:276:51 ${specifier.type} is currently unsupported`
+				`src/processScript/transform.ts:288:51 ${specifier.type} is currently unsupported`
 			)
 			if (
 				"default" !=
@@ -292,11 +305,11 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 		let hoistedGlobalBlockFunctions = 0
 		for (const [globalBlockIndex, globalBlockStatement] of [...globalBlock.body.entries()].reverse())
 			if ("VariableDeclaration" == globalBlockStatement.type) {
-				assert(1 == globalBlockStatement.declarations.length, "src/processScript/transform.ts:390:59")
+				assert(1 == globalBlockStatement.declarations.length, "src/processScript/transform.ts:402:59")
 				const declarator = globalBlockStatement.declarations[0]
 				assert(
 					"Identifier" == declarator.id.type,
-					`src/processScript/transform.ts:394:51 declarator.id.type was "${declarator.id.type}"`
+					`src/processScript/transform.ts:406:51 declarator.id.type was "${declarator.id.type}"`
 				)
 				program.scope.crawl()
 				if (program.scope.hasGlobal(declarator.id.name)) {
@@ -311,9 +324,9 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 						Object.keys(program.scope.globals).some(global => globalBlockVariables.has(global))
 					) {
 						const binding = program.scope.getBinding(declarator.id.name)
-						assert(binding, "src/processScript/transform.ts:413:23")
+						assert(binding, "src/processScript/transform.ts:425:23")
 						for (const referencePath of binding.referencePaths) {
-							assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:416:56")
+							assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:428:56")
 							referencePath.replaceWith(
 								t.memberExpression(
 									t.identifier(`_${uniqueId}_G_`),
@@ -361,16 +374,16 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 				} else globalBlockVariables.add(declarator.id.name)
 			} else if ("ClassDeclaration" == globalBlockStatement.type) {
 				program.scope.crawl()
-				assert(globalBlockStatement.id, "src/processScript/transform.ts:473:37")
+				assert(globalBlockStatement.id, "src/processScript/transform.ts:485:37")
 				if (program.scope.hasGlobal(globalBlockStatement.id.name)) {
 					globalBlock.body.splice(globalBlockIndex, 1)
 					const [globalBlockPath] = program.unshiftContainer("body", globalBlock),
 						[globalBlockStatementPath] = program.unshiftContainer("body", globalBlockStatement)
 					program.scope.crawl()
 					const binding = program.scope.getBinding(globalBlockStatement.id.name)
-					assert(binding, "src/processScript/transform.ts:485:22")
+					assert(binding, "src/processScript/transform.ts:497:22")
 					for (const referencePath of binding.referencePaths) {
-						assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:488:55")
+						assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:500:55")
 						referencePath.replaceWith(
 							t.memberExpression(t.identifier(`_${uniqueId}_G_`), t.identifier(referencePath.node.name))
 						)
@@ -448,6 +461,31 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 				)
 			])
 		)
+	needHasOwn &&
+		mainFunction.body.body.unshift(
+			t.variableDeclaration("let", [
+				t.variableDeclarator(
+					t.identifier(`_${uniqueId}_HAS_OWN_`),
+					t.callExpression(
+						t.memberExpression(
+							t.memberExpression(
+								t.identifier(
+									globalFunctionsUnder7Characters.find(name => !program.scope.hasOwnBinding(name))
+								),
+								t.identifier("call")
+							),
+							t.identifier("bind")
+						),
+						[
+							t.memberExpression(
+								t.memberExpression(t.identifier("Object"), t.identifier("prototype")),
+								t.identifier("hasOwnProperty")
+							)
+						]
+					)
+				)
+			])
+		)
 	consoleMethodsReferenced.size &&
 		mainFunction.body.body.unshift(
 			t.variableDeclaration(
@@ -537,7 +575,7 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 				}
 		},
 		ClassBody({ node: classBody, scope, parent }) {
-			assert(t.isClass(parent), "src/processScript/transform.ts:658:30")
+			assert(t.isClass(parent), "src/processScript/transform.ts:695:30")
 			let thisIsReferenced = !1
 			for (const classMethod of classBody.body) {
 				if ("ClassMethod" != classMethod.type) continue
@@ -627,7 +665,7 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 			)
 		}
 	})
-	return { file, seclevel }
+	return { file, seclevel, warnings }
 	function createGetFunctionPrototypeNode() {
 		const name = globalFunctionsUnder7Characters.find(name => !program.scope.hasOwnBinding(name))
 		return t.memberExpression(
@@ -637,23 +675,23 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	}
 	function processFakeSubscriptObject(fakeSubscriptObjectName, seclevel) {
 		for (const referencePath of getReferencePathsToGlobal(fakeSubscriptObjectName, program)) {
-			assert("MemberExpression" == referencePath.parent.type, "src/processScript/transform.ts:764:60")
+			assert("MemberExpression" == referencePath.parent.type, "src/processScript/transform.ts:801:60")
 			assert("Identifier" == referencePath.parent.property.type)
 			assert(
 				"MemberExpression" == referencePath.parentPath.parentPath?.node.type,
-				"src/processScript/transform.ts:766:81"
+				"src/processScript/transform.ts:803:81"
 			)
 			assert(
 				"Identifier" == referencePath.parentPath.parentPath.node.property.type,
-				"src/processScript/transform.ts:767:83"
+				"src/processScript/transform.ts:804:83"
 			)
 			assert(
 				/^[_a-z][\d_a-z]{0,24}$/.test(referencePath.parent.property.name),
-				`src/processScript/transform.ts:771:8 invalid user "${referencePath.parent.property.name}" in subscript`
+				`src/processScript/transform.ts:808:8 invalid user "${referencePath.parent.property.name}" in subscript`
 			)
 			assert(
 				/^[_a-z][\d_a-z]{0,24}$/.test(referencePath.parentPath.parentPath.node.property.name),
-				`src/processScript/transform.ts:776:8 invalid script name "${referencePath.parentPath.parentPath.node.property.name}" in subscript`
+				`src/processScript/transform.ts:813:8 invalid script name "${referencePath.parentPath.parentPath.node.property.name}" in subscript`
 			)
 			if ("CallExpression" == referencePath.parentPath.parentPath.parentPath?.type)
 				referencePath.parentPath.parentPath.replaceWith(

package/push.js

@@ -4,7 +4,7 @@ import { countHackmudCharacters } from "@samual/lib/countHackmudCharacters"
 import { readDirectoryWithStats } from "@samual/lib/readDirectoryWithStats"
 import { writeFilePersistent } from "@samual/lib/writeFilePersistent"
 import { readFile } from "fs/promises"
-import { basename, resolve } from "path"
+import { resolve, basename } from "path"
 import { processScript } from "./processScript/index.js"
 import "@babel/generator"
 import "@babel/parser"
@@ -25,6 +25,7 @@ import "@babel/plugin-transform-private-property-in-object"
 import "@babel/plugin-transform-unicode-sets-regex"
 import "@babel/traverse"
 import "@babel/types"
+import "@rollup/plugin-alias"
 import "@rollup/plugin-babel"
 import "@rollup/plugin-commonjs"
 import "@rollup/plugin-json"
@@ -124,23 +125,25 @@ async function push(
 	const pathsToUsers = new AutoMap(_path => new Set())
 	for (const [user, scriptsToPush] of usersToScriptsToPush)
 		for (const path of scriptsToPush.values()) pathsToUsers.get(path).add(user)
-	const allInfo = []
+	const allInfo = [],
+		sourcePathResolved = resolve(sourcePath)
 	await Promise.all(
 		[...pathsToUsers].map(async ([path, [...users]]) => {
 			const scriptName = basename(path.slice(0, -3)),
 				uniqueId = Math.floor(Math.random() * 2 ** 52)
 					.toString(36)
 					.padStart(11, "0"),
-				{ script: minifiedCode } = await processScript(await readFile(path, { encoding: "utf8" }), {
+				{ script: minifiedCode, warnings } = await processScript(await readFile(path, { encoding: "utf8" }), {
 					minify,
 					scriptUser: !0,
 					scriptName,
 					uniqueId,
 					filePath: path,
 					mangleNames,
-					forceQuineCheats
+					forceQuineCheats,
+					rootFolderPath: sourcePathResolved
 				}),
-				info = { path, users, characterCount: countHackmudCharacters(minifiedCode), error: void 0 }
+				info = { path, users, characterCount: countHackmudCharacters(minifiedCode), error: void 0, warnings }
 			await Promise.all(
 				users.map(user =>
 					writeFilePersistent(

package/watch.js

@@ -29,6 +29,7 @@ import "@babel/plugin-transform-private-property-in-object"
 import "@babel/plugin-transform-unicode-sets-regex"
 import "@babel/traverse"
 import "@babel/types"
+import "@rollup/plugin-alias"
 import "@rollup/plugin-babel"
 import "@rollup/plugin-commonjs"
 import "@rollup/plugin-json"
@@ -73,10 +74,11 @@ async function watch(
 		: scriptName && "*" != scriptName ? wildUserScripts.add(scriptName)
 		: (pushEverything = !0)
 	}
-	const watcher = watch$1(["*.ts", "*.js", "*/*.ts", "*/*.js"], {
+	const watcher = watch$1(".", {
 		cwd: sourceDirectory,
 		awaitWriteFinish: { stabilityThreshold: 100 },
-		ignored: "*.d.ts"
+		ignored: (path, stats) =>
+			!!stats?.isFile() && !(path.endsWith(".js") || (path.endsWith(".ts") && !path.endsWith(".d.ts")))
 	}).on("change", async path => {
 		if (path.endsWith(".d.ts")) return
 		const extension = extname(path)
@@ -118,27 +120,22 @@ async function watch(
 			for (const user of scriptNamesToUsers.get(scriptName)) usersToPushToSet.add(user)
 			const usersToPushTo = [...usersToPushToSet].filter(user => !scriptNamesToUsersToSkip.has(user))
 			if (!usersToPushTo.length) {
-				onPush?.({ path, users: [], characterCount: 0, error: Error("no users to push to") })
+				onPush?.({ path, users: [], characterCount: 0, error: Error("no users to push to"), warnings: [] })
 				return
 			}
 			const uniqueId = Math.floor(Math.random() * 2 ** 52)
 					.toString(36)
 					.padStart(11, "0"),
 				filePath = resolve(sourceDirectory, path)
-			let minifiedCode
+			let minifiedCode, warnings
 			try {
-				;({ script: minifiedCode } = await processScript(await readFile(filePath, { encoding: "utf8" }), {
-					minify,
-					scriptUser: !0,
-					scriptName,
-					uniqueId,
-					filePath,
-					mangleNames,
-					forceQuineCheats
-				}))
+				;({ script: minifiedCode, warnings } = await processScript(
+					await readFile(filePath, { encoding: "utf8" }),
+					{ minify, scriptUser: !0, scriptName, uniqueId, filePath, mangleNames, forceQuineCheats }
+				))
 			} catch (error) {
-				assert(error instanceof Error, "src/watch.ts:146:36")
-				onPush?.({ path, users: [], characterCount: 0, error })
+				assert(error instanceof Error, "src/watch.ts:149:36")
+				onPush?.({ path, users: [], characterCount: 0, error, warnings: [] })
 				return
 			}
 			await Promise.all(
@@ -155,7 +152,8 @@ async function watch(
 				path,
 				users: usersToPushTo,
 				characterCount: countHackmudCharacters(minifiedCode),
-				error: void 0
+				error: void 0,
+				warnings
 			})
 			return
 		}
@@ -169,25 +167,27 @@ async function watch(
 			)
 		)
 			return
-		const filePath = resolve(sourceDirectory, path),
+		const sourceDirectoryResolved = resolve(sourceDirectory),
+			filePath = resolve(sourceDirectoryResolved, path),
 			sourceCode = await readFile(filePath, { encoding: "utf8" })
-		let script
+		let script, warnings
 		try {
-			;({ script } = await processScript(sourceCode, {
+			;({ script, warnings } = await processScript(sourceCode, {
 				minify,
 				scriptUser: user,
 				scriptName,
 				filePath,
 				mangleNames,
-				forceQuineCheats
+				forceQuineCheats,
+				rootFolderPath: sourceDirectoryResolved
 			}))
 		} catch (error) {
-			assert(error instanceof Error, "src/watch.ts:182:35")
-			onPush?.({ path, users: [], characterCount: 0, error })
+			assert(error instanceof Error, "src/watch.ts:196:35")
+			onPush?.({ path, users: [], characterCount: 0, error, warnings: [] })
 			return
 		}
 		await writeFilePersistent(resolve(hackmudDirectory, user, "scripts", scriptName + ".js"), script)
-		onPush?.({ path, users: [user], characterCount: countHackmudCharacters(script), error: void 0 })
+		onPush?.({ path, users: [user], characterCount: countHackmudCharacters(script), error: void 0, warnings })
 	})
 	onReady && watcher.on("ready", onReady)
 	if (!typeDeclarationPath_) return
@@ -197,7 +197,7 @@ async function watch(
 		try {
 			await writeFile(typeDeclarationPath, typeDeclaration)
 		} catch (error) {
-			assert(error instanceof Error, "src/watch.ts:215:35")
+			assert(error instanceof Error, "src/watch.ts:229:35")
 			if ("EISDIR" != error.code) throw error
 			typeDeclarationPath = resolve(typeDeclarationPath, "player.d.ts")
 			await writeFile(typeDeclarationPath, typeDeclaration)