hackmud-script-manager 0.20.4-03d5600 → 0.20.4-0dd1d9b

package/README.md

@@ -20,6 +20,10 @@ You can read about how HSM works [in my blog post](https://samual.uk/blog/js-cod
 > ```
 > You will need to run `Set-ExecutionPolicy -ExecutionPolicy Unrestricted -Scope CurrentUser` in PowerShell as an administrator. For more information, see [Microsoft's page about Execution Policies](https://learn.microsoft.com/en-gb/powershell/module/microsoft.powershell.core/about/about_execution_policies?view=powershell-7.4).
 
+![image](https://github.com/samualtnorman/hackmud-script-manager/assets/18307063/69a371fe-f8c8-43fe-b3c7-39f3735ce6fb)
+![image](https://github.com/samualtnorman/hackmud-script-manager/assets/18307063/08103f9e-74fa-4a56-a739-94858ba8c139)
+![image](https://github.com/samualtnorman/hackmud-script-manager/assets/18307063/25ccb86d-1fe3-4632-b703-ac47f5b32c9c)
+
 ## Features
 - Minification
     - This includes auto quine cheating.

package/bin/hsm.js

@@ -13,7 +13,8 @@ import { syncMacros } from "../syncMacros.js"
 import "@samual/lib/readDirectoryWithStats"
 import "path/posix"
 import "@samual/lib/copyFilePersistent"
-const version = "0.20.4-03d5600",
+const version = "0.20.4-0dd1d9b",
+	formatOption = name => colourN(`-${1 == name.length ? "" : "-"}${name}`),
 	options = new Map(),
 	commands = [],
 	userColours = new Cache(user => {
@@ -46,6 +47,7 @@ const pushModule = import("../push.js"),
 	colourB = chalk.rgb(202, 202, 202),
 	colourC = chalk.rgb(155, 155, 155),
 	colourD = chalk.rgb(255, 0, 0),
+	colourF = chalk.rgb(255, 128, 0),
 	colourJ = chalk.rgb(255, 244, 4),
 	colourK = chalk.rgb(243, 249, 152),
 	colourL = chalk.rgb(30, 255, 0),
@@ -54,6 +56,12 @@ const pushModule = import("../push.js"),
 	colourS = chalk.rgb(122, 178, 244),
 	colourV = chalk.rgb(255, 0, 236),
 	colourW = chalk.rgb(255, 150, 224)
+process.version.startsWith("v21.") &&
+	console.warn(
+		colourF(
+			"Warning: Support for Node.js 21 will be dropped in the next minor version of HSM\n         You should update your version of Node.js\n         https://nodejs.org/en/download/package-manager"
+		)
+	)
 if ("v" == commands[0] || "version" == commands[0] || popOption("version", "v")?.value) {
 	console.log(version)
 	process.exit()
@@ -76,7 +84,7 @@ switch (commands[0]) {
 				noMinifyIncompatibleOption = mangleNamesOption || forceQuineCheatsOption
 			if (noMinifyOption && noMinifyIncompatibleOption) {
 				logError(
-					`Options ${colourN(noMinifyOption.name)} and ${colourN(noMinifyIncompatibleOption.name)} are incompatible\n`
+					`Options ${formatOption(noMinifyOption.name)} and ${formatOption(noMinifyIncompatibleOption.name)} are incompatible\n`
 				)
 				logHelp()
 				process.exit(1)
@@ -99,6 +107,7 @@ switch (commands[0]) {
 					)
 					process.exit(1)
 				}
+				complainAboutUnrecognisedOptions()
 				const { processScript } = await processScriptModule,
 					fileBaseName = basename(target, fileExtension),
 					fileBaseNameEndsWithDotSrc = fileBaseName.endsWith(".src"),
@@ -171,15 +180,15 @@ switch (commands[0]) {
 					}
 				} else scripts.push("*.*")
 				if ("push" == commands[0]) {
-					const { push, MissingSourceFolderError, MissingHackmudFolderError, NoUsersError } =
-							await pushModule,
-						infos = await push(sourcePath, hackmudPath, {
-							scripts,
-							onPush: info => logInfo(info, hackmudPath),
-							minify: noMinifyOption && !noMinifyOption.value,
-							mangleNames: mangleNamesOption?.value,
-							forceQuineCheats: forceQuineCheatsOption?.value
-						})
+					const { push, MissingSourceFolderError, MissingHackmudFolderError, NoUsersError } = await pushModule
+					complainAboutUnrecognisedOptions()
+					const infos = await push(sourcePath, hackmudPath, {
+						scripts,
+						onPush: info => logInfo(info, hackmudPath),
+						minify: noMinifyOption && !noMinifyOption.value,
+						mangleNames: mangleNamesOption?.value,
+						forceQuineCheats: forceQuineCheatsOption?.value
+					})
 					if (infos instanceof Error) {
 						logError(infos.message)
 						if (infos instanceof MissingSourceFolderError || infos instanceof NoUsersError) {
@@ -193,12 +202,13 @@ switch (commands[0]) {
 					} else infos.length || logError("Could not find any scripts to push")
 				} else {
 					const typeDeclarationPathOption = popOption(
-							"type-declaration-path",
-							"type-declaration",
-							"dts",
-							"gen-types"
-						),
-						{ watch } = await watchModule
+						"type-declaration-path",
+						"type-declaration",
+						"dts",
+						"gen-types"
+					)
+					complainAboutUnrecognisedOptions()
+					const { watch } = await watchModule
 					watch(sourcePath, hackmudPath, {
 						scripts,
 						onPush: info => logInfo(info, hackmudPath),
@@ -222,6 +232,7 @@ switch (commands[0]) {
 				logHelp()
 				process.exit(1)
 			}
+			complainAboutUnrecognisedOptions()
 			const sourcePath = commands[2] || "."
 			await pull(sourcePath, hackmudPath, script).catch(error => {
 				console.error(error)
@@ -231,8 +242,9 @@ switch (commands[0]) {
 		break
 	case "sync-macros":
 		{
-			const hackmudPath = getHackmudPath(),
-				{ macrosSynced, usersSynced } = await syncMacros(hackmudPath)
+			const hackmudPath = getHackmudPath()
+			complainAboutUnrecognisedOptions()
+			const { macrosSynced, usersSynced } = await syncMacros(hackmudPath)
 			log(`Synced ${macrosSynced} macros to ${usersSynced} users`)
 		}
 		break
@@ -248,12 +260,13 @@ switch (commands[0]) {
 				logHelp()
 				process.exit(1)
 			}
+			complainAboutUnrecognisedOptions()
 			const sourcePath = resolve(target),
 				outputPath = commands[2] || "./player.d.ts",
 				typeDeclaration = await generateTypeDeclaration(sourcePath, hackmudPath)
 			let typeDeclarationPath = resolve(outputPath)
 			await writeFile(typeDeclarationPath, typeDeclaration).catch(error => {
-				assert(error instanceof Error, "src/bin/hsm.ts:321:35")
+				assert(error instanceof Error, "src/bin/hsm.ts:343:35")
 				if ("EISDIR" != error.code) throw error
 				typeDeclarationPath = resolve(typeDeclarationPath, "player.d.ts")
 				return writeFile(typeDeclarationPath, typeDeclaration)
@@ -352,7 +365,7 @@ function getHackmudPath() {
 }
 function assertOptionIsBoolean(option) {
 	if ("boolean" != typeof option.value) {
-		logError(`The value for ${colourN(option.name)} must be ${colourV("true")} or ${colourV("false")}\n`)
+		logError(`The value for ${formatOption(option.name)} must be ${colourV("true")} or ${colourV("false")}\n`)
 		logHelp()
 		process.exit(1)
 	}
@@ -360,9 +373,7 @@ function assertOptionIsBoolean(option) {
 function popOption(...names) {
 	const presentOptionNames = names.filter(name => options.has(name))
 	if (!presentOptionNames.length) return
-	const presentOptionNamesWithDashDash = presentOptionNames.map(name =>
-		colourN(`-${1 == name.length ? "" : "-"}${name}`)
-	)
+	const presentOptionNamesWithDashDash = presentOptionNames.map(formatOption)
 	if (presentOptionNames.length > 1) {
 		logError(
 			`The options ${presentOptionNamesWithDashDash.join(", ")} are aliases for each other. Please only specify one`
@@ -373,3 +384,11 @@ function popOption(...names) {
 	options.delete(presentOptionNames[0])
 	return { name: presentOptionNamesWithDashDash[0], value }
 }
+function complainAboutUnrecognisedOptions() {
+	if (options.size) {
+		logError(
+			`Unrecognised option${options.size > 1 ? "s" : ""}: ${[...options.keys()].map(formatOption).join(", ")}`
+		)
+		process.exit(1)
+	}
+}

package/env.d.ts

@@ -3,13 +3,7 @@ type ScriptSuccess<T = object> = { ok: true } & T
 type ScriptFailure = { ok: false, msg?: string }
 type ScriptResponse<T = object> = ScriptSuccess<T> | ScriptFailure
 type ErrorScripts = Record<string, () => ScriptFailure>
-
-type AllOptional<T> = { [K in keyof T]-?: {} extends Pick<T, K> ? true : false }[keyof T]
-
-type Scriptor<Args = unknown, Ret = unknown> = {
-	name: string
-	call: AllOptional<Args> extends true ? (args?: Args) => Ret : (args: Args) => Ret
-}
+type Scriptor<TArgs extends any[] = any[]> = { name: string, call: (...args: TArgs) => unknown }
 
 type Subscripts = Record<string, Record<string, (...args: any) => any>> & {
 	accts: ErrorScripts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hackmud-script-manager",
-  "version": "0.20.4-03d5600",
+  "version": "0.20.4-0dd1d9b",
   "description": "Script manager for game hackmud, with minification, TypeScript support, and player script type definition generation.",
   "keywords": [
     "api",

package/processScript/index.js

@@ -204,6 +204,7 @@ async function processScript(
 	const bundle = await rollup({
 			input: filePathResolved,
 			plugins: [
+				rollupPluginJSON({ preferConst: !0 }),
 				{
 					name: "hackmud-script-manager",
 					async transform(code, id) {
@@ -227,8 +228,7 @@ async function processScript(
 				},
 				babel({ babelHelpers: "bundled", plugins, configFile: !1, extensions: supportedExtensions }),
 				rollupPluginCommonJS(),
-				rollupPluginNodeResolve({ extensions: supportedExtensions }),
-				rollupPluginJSON()
+				rollupPluginNodeResolve({ extensions: supportedExtensions })
 			],
 			treeshake: { moduleSideEffects: !1 }
 		}),

package/processScript/preprocess.js

@@ -98,8 +98,10 @@ async function preprocess(code, { uniqueId = "00000000000" } = {}) {
 				t.stringLiteral(resolve("proxy-polyfill/src/proxy.js", import.meta.url).slice(7))
 			)
 		)
-	return 1 == program.node.body.length && "FunctionDeclaration" == program.node.body[0].type ?
-			{ code: "export default " + generate(file).code }
-		:	{ code: generate(file).code }
+	if (1 == program.node.body.length && "FunctionDeclaration" == program.node.body[0].type)
+		throw Error(
+			"Scripts that only contain a single function declaration are no longer supported.\nPrefix the function declaration with `export default`."
+		)
+	return { code: generate(file).code }
 }
 export { preprocess }

package/processScript/transform.js

@@ -22,9 +22,7 @@ const { default: traverse } = babelTraverse,
 		"BigInt"
 	]
 function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scriptName, seclevel = 4 }) {
-	const topFunctionName = `_${uniqueId}_SCRIPT_`,
-		exports = new Map(),
-		liveExports = new Map()
+	const topFunctionName = `_${uniqueId}_SCRIPT_`
 	let program
 	traverse(file, {
 		Program(path) {
@@ -70,30 +68,30 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 			const referencePath = FunctionReferencePaths[0]
 			assert(
 				"MemberExpression" == referencePath.parent.type,
-				"src/processScript/transform.ts:105:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+				"src/processScript/transform.ts:103:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 			)
 			assert(
 				"Identifier" == referencePath.parent.property.type,
-				"src/processScript/transform.ts:110:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+				"src/processScript/transform.ts:108:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 			)
 			assert(
 				"prototype" == referencePath.parent.property.name,
-				"src/processScript/transform.ts:115:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+				"src/processScript/transform.ts:113:8 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 			)
 			referencePath.parentPath.replaceWith(createGetFunctionPrototypeNode())
 		} else {
 			for (const referencePath of FunctionReferencePaths) {
 				assert(
 					"MemberExpression" == referencePath.parent.type,
-					"src/processScript/transform.ts:123:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+					"src/processScript/transform.ts:121:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 				)
 				assert(
 					"Identifier" == referencePath.parent.property.type,
-					"src/processScript/transform.ts:128:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+					"src/processScript/transform.ts:126:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 				)
 				assert(
 					"prototype" == referencePath.parent.property.name,
-					"src/processScript/transform.ts:133:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
+					"src/processScript/transform.ts:131:9 `Function` isn't available in hackmud, only `Function.prototype` is accessible"
 				)
 				functionDotPrototypeIsReferencedMultipleTimes = !0
 				referencePath.parentPath.replaceWith(t.identifier(`_${uniqueId}_FUNCTION_DOT_PROTOTYPE_`))
@@ -129,12 +127,12 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	const neededDbMethodLets = new Set()
 	if (program.scope.hasGlobal("$db"))
 		for (const referencePath of getReferencePathsToGlobal("$db", program)) {
-			assert("MemberExpression" == referencePath.parentPath.node.type, "src/processScript/transform.ts:187:69")
-			assert("Identifier" == referencePath.parentPath.node.property.type, "src/processScript/transform.ts:188:72")
+			assert("MemberExpression" == referencePath.parentPath.node.type, "src/processScript/transform.ts:185:69")
+			assert("Identifier" == referencePath.parentPath.node.property.type, "src/processScript/transform.ts:186:72")
 			const databaseOpMethodName = referencePath.parentPath.node.property.name
 			assert(
 				validDBMethods.includes(databaseOpMethodName),
-				`src/processScript/transform.ts:194:8 invalid db method "${databaseOpMethodName}", valid db methods are "${validDBMethods.join('", "')}"`
+				`src/processScript/transform.ts:192:8 invalid db method "${databaseOpMethodName}", valid db methods are "${validDBMethods.join('", "')}"`
 			)
 			if ("CallExpression" == referencePath.parentPath.parentPath?.type)
 				referencePath.parentPath.replaceWith(t.identifier(`$${uniqueId}$DB$${databaseOpMethodName}$`))
@@ -168,7 +166,7 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	if (program.scope.hasGlobal("Object"))
 		for (const referencePath of getReferencePathsToGlobal("Object", program))
 			if ("MemberExpression" == referencePath.parent.type && !referencePath.parent.computed) {
-				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:243:64")
+				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:241:64")
 				if ("getPrototypeOf" == referencePath.parent.property.name) {
 					referencePath.parentPath.replaceWith(t.identifier(`_${uniqueId}_GET_PROTOTYPE_OF_`))
 					needGetPrototypeOf = !0
@@ -178,7 +176,7 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	if (program.scope.hasGlobal("console"))
 		for (const referencePath of getReferencePathsToGlobal("console", program))
 			if ("MemberExpression" == referencePath.parent.type && !referencePath.parent.computed) {
-				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:258:64")
+				assert("Identifier" == referencePath.parent.property.type, "src/processScript/transform.ts:256:64")
 				referencePath.parentPath.replaceWith(
 					t.identifier(`_${uniqueId}_CONSOLE_METHOD_${referencePath.parent.property.name}_`)
 				)
@@ -186,19 +184,20 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 			}
 	const lastStatement = program.node.body.at(-1)
 	let exportDefaultName
-	assert(lastStatement, "src/processScript/transform.ts:272:27 program is empty")
+	assert(lastStatement, "src/processScript/transform.ts:270:27 program is empty")
 	if ("ExportNamedDeclaration" == lastStatement.type) {
 		program.node.body.pop()
 		for (const specifier of lastStatement.specifiers) {
 			assert(
 				"ExportSpecifier" == specifier.type,
-				`src/processScript/transform.ts:278:51 ${specifier.type} is currently unsupported`
+				`src/processScript/transform.ts:276:51 ${specifier.type} is currently unsupported`
 			)
-			const exportedName =
-				"Identifier" == specifier.exported.type ? specifier.exported.name : specifier.exported.value
-			"default" == exportedName ?
-				(exportDefaultName = specifier.local.name)
-			:	exports.set(specifier.local.name, exportedName)
+			if (
+				"default" !=
+				("Identifier" == specifier.exported.type ? specifier.exported.name : specifier.exported.value)
+			)
+				throw Error("Only default exports are supported")
+			exportDefaultName = specifier.local.name
 		}
 	}
 	const globalBlock = t.blockStatement([])
@@ -224,10 +223,6 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 									t.returnStatement(t.callExpression(t.identifier(exportDefaultName), []))
 								])
 							))
-						if ("const" != statement.kind && exports.has(identifierName)) {
-							liveExports.set(identifierName, exports.get(identifierName))
-							exports.delete(identifierName)
-						}
 						globalBlock.body.push(
 							t.variableDeclaration("let", [t.variableDeclarator(t.identifier(identifierName))])
 						)
@@ -292,34 +287,16 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	}
 	program.node.body = [mainFunction]
 	if (globalBlock.body.length) {
-		;(exports.size || liveExports.size) &&
-			mainFunction.body.body.push(
-				t.returnStatement(
-					t.objectExpression([
-						...[...exports].map(([local, exported]) =>
-							t.objectProperty(t.identifier(exported), t.identifier(local))
-						),
-						...[...liveExports].map(([local, exported]) =>
-							t.objectMethod(
-								"get",
-								t.identifier(exported),
-								[],
-								t.blockStatement([t.returnStatement(t.identifier(local))])
-							)
-						)
-					])
-				)
-			)
 		program.scope.crawl()
 		const globalBlockVariables = new Set()
 		let hoistedGlobalBlockFunctions = 0
 		for (const [globalBlockIndex, globalBlockStatement] of [...globalBlock.body.entries()].reverse())
 			if ("VariableDeclaration" == globalBlockStatement.type) {
-				assert(1 == globalBlockStatement.declarations.length, "src/processScript/transform.ts:412:59")
+				assert(1 == globalBlockStatement.declarations.length, "src/processScript/transform.ts:390:59")
 				const declarator = globalBlockStatement.declarations[0]
 				assert(
 					"Identifier" == declarator.id.type,
-					`src/processScript/transform.ts:416:51 declarator.id.type was "${declarator.id.type}"`
+					`src/processScript/transform.ts:394:51 declarator.id.type was "${declarator.id.type}"`
 				)
 				program.scope.crawl()
 				if (program.scope.hasGlobal(declarator.id.name)) {
@@ -334,9 +311,9 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 						Object.keys(program.scope.globals).some(global => globalBlockVariables.has(global))
 					) {
 						const binding = program.scope.getBinding(declarator.id.name)
-						assert(binding, "src/processScript/transform.ts:435:23")
+						assert(binding, "src/processScript/transform.ts:413:23")
 						for (const referencePath of binding.referencePaths) {
-							assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:438:56")
+							assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:416:56")
 							referencePath.replaceWith(
 								t.memberExpression(
 									t.identifier(`_${uniqueId}_G_`),
@@ -384,16 +361,16 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 				} else globalBlockVariables.add(declarator.id.name)
 			} else if ("ClassDeclaration" == globalBlockStatement.type) {
 				program.scope.crawl()
-				assert(globalBlockStatement.id, "src/processScript/transform.ts:495:37")
+				assert(globalBlockStatement.id, "src/processScript/transform.ts:473:37")
 				if (program.scope.hasGlobal(globalBlockStatement.id.name)) {
 					globalBlock.body.splice(globalBlockIndex, 1)
 					const [globalBlockPath] = program.unshiftContainer("body", globalBlock),
 						[globalBlockStatementPath] = program.unshiftContainer("body", globalBlockStatement)
 					program.scope.crawl()
 					const binding = program.scope.getBinding(globalBlockStatement.id.name)
-					assert(binding, "src/processScript/transform.ts:507:22")
+					assert(binding, "src/processScript/transform.ts:485:22")
 					for (const referencePath of binding.referencePaths) {
-						assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:510:55")
+						assert("Identifier" == referencePath.node.type, "src/processScript/transform.ts:488:55")
 						referencePath.replaceWith(
 							t.memberExpression(t.identifier(`_${uniqueId}_G_`), t.identifier(referencePath.node.name))
 						)
@@ -423,11 +400,6 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 					needG = !0
 				}
 			}
-		if (program.scope.hasGlobal("_EXPORTS"))
-			for (const referencePath of getReferencePathsToGlobal("_EXPORTS", program))
-				referencePath.replaceWith(
-					t.arrayExpression([...exports.keys(), ...liveExports.keys()].map(name => t.stringLiteral(name)))
-				)
 		globalBlock.body.length &&
 			mainFunction.body.body.splice(
 				hoistedGlobalBlockFunctions,
@@ -565,7 +537,7 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 				}
 		},
 		ClassBody({ node: classBody, scope, parent }) {
-			assert(t.isClass(parent), "src/processScript/transform.ts:688:30")
+			assert(t.isClass(parent), "src/processScript/transform.ts:658:30")
 			let thisIsReferenced = !1
 			for (const classMethod of classBody.body) {
 				if ("ClassMethod" != classMethod.type) continue
@@ -657,39 +629,31 @@ function transform(file, sourceCode, { uniqueId = "00000000000", scriptUser, scr
 	})
 	return { file, seclevel }
 	function createGetFunctionPrototypeNode() {
-		for (const globalFunction of globalFunctionsUnder7Characters)
-			if (!program.scope.hasOwnBinding(globalFunction))
-				return t.memberExpression(
-					t.memberExpression(t.identifier(globalFunction), t.identifier("constructor")),
-					t.identifier("prototype")
-				)
+		const name = globalFunctionsUnder7Characters.find(name => !program.scope.hasOwnBinding(name))
 		return t.memberExpression(
-			t.memberExpression(
-				t.arrowFunctionExpression([t.identifier("_")], t.identifier("_")),
-				t.identifier("constructor")
-			),
-			t.identifier("prototype")
+			name ? t.identifier(name) : t.arrowFunctionExpression([t.identifier("_")], t.identifier("_")),
+			t.identifier("__proto__")
 		)
 	}
 	function processFakeSubscriptObject(fakeSubscriptObjectName, seclevel) {
 		for (const referencePath of getReferencePathsToGlobal(fakeSubscriptObjectName, program)) {
-			assert("MemberExpression" == referencePath.parent.type, "src/processScript/transform.ts:804:60")
+			assert("MemberExpression" == referencePath.parent.type, "src/processScript/transform.ts:764:60")
 			assert("Identifier" == referencePath.parent.property.type)
 			assert(
 				"MemberExpression" == referencePath.parentPath.parentPath?.node.type,
-				"src/processScript/transform.ts:806:81"
+				"src/processScript/transform.ts:766:81"
 			)
 			assert(
 				"Identifier" == referencePath.parentPath.parentPath.node.property.type,
-				"src/processScript/transform.ts:807:83"
+				"src/processScript/transform.ts:767:83"
 			)
 			assert(
 				/^[_a-z][\d_a-z]{0,24}$/.test(referencePath.parent.property.name),
-				`src/processScript/transform.ts:811:8 invalid user "${referencePath.parent.property.name}" in subscript`
+				`src/processScript/transform.ts:771:8 invalid user "${referencePath.parent.property.name}" in subscript`
 			)
 			assert(
 				/^[_a-z][\d_a-z]{0,24}$/.test(referencePath.parentPath.parentPath.node.property.name),
-				`src/processScript/transform.ts:816:8 invalid script name "${referencePath.parentPath.parentPath.node.property.name}" in subscript`
+				`src/processScript/transform.ts:776:8 invalid script name "${referencePath.parentPath.parentPath.node.property.name}" in subscript`
 			)
 			if ("CallExpression" == referencePath.parentPath.parentPath.parentPath?.type)
 				referencePath.parentPath.parentPath.replaceWith(

package/watch.js

@@ -4,7 +4,7 @@ import { countHackmudCharacters } from "@samual/lib/countHackmudCharacters"
 import { readDirectoryWithStats } from "@samual/lib/readDirectoryWithStats"
 import { writeFilePersistent } from "@samual/lib/writeFilePersistent"
 import { watch as watch$1 } from "chokidar"
-import { readFile, writeFile } from "fs/promises"
+import { stat, readFile, writeFile } from "fs/promises"
 import { extname, basename, resolve } from "path"
 import { supportedExtensions } from "./constants.js"
 import { generateTypeDeclaration } from "./generateTypeDeclaration.js"
@@ -59,6 +59,7 @@ async function watch(
 	} = {}
 ) {
 	if (!scripts.length) throw Error("scripts option was an empty array")
+	if (!(await stat(sourceDirectory)).isDirectory()) throw Error("Target folder must be a folder")
 	const scriptNamesToUsers = new Cache(_scriptName => new Set()),
 		wildScriptUsers = new Set(),
 		wildUserScripts = new Set()
@@ -136,7 +137,7 @@ async function watch(
 					forceQuineCheats
 				}))
 			} catch (error) {
-				assert(error instanceof Error, "src/watch.ts:141:36")
+				assert(error instanceof Error, "src/watch.ts:146:36")
 				onPush?.({ path, users: [], characterCount: 0, error })
 				return
 			}
@@ -181,7 +182,7 @@ async function watch(
 				forceQuineCheats
 			}))
 		} catch (error) {
-			assert(error instanceof Error, "src/watch.ts:177:35")
+			assert(error instanceof Error, "src/watch.ts:182:35")
 			onPush?.({ path, users: [], characterCount: 0, error })
 			return
 		}
@@ -196,7 +197,7 @@ async function watch(
 		try {
 			await writeFile(typeDeclarationPath, typeDeclaration)
 		} catch (error) {
-			assert(error instanceof Error, "src/watch.ts:210:35")
+			assert(error instanceof Error, "src/watch.ts:215:35")
 			if ("EISDIR" != error.code) throw error
 			typeDeclarationPath = resolve(typeDeclarationPath, "player.d.ts")
 			await writeFile(typeDeclarationPath, typeDeclaration)