h56-github-scrapper 1.0.4 → 1.0.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "h56-github-scrapper",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "GitHub user scraper",
   "type": "module",
   "main": "main-scrapping.js",

package/script/ensure-external-deps.js

@@ -2,45 +2,74 @@
 /**
  * scripts/ensure-external-deps.js (ESM)
  *
- * Postinstall helper (ESM). Attempts to install optional dependencies if missing.**/
+ * Postinstall helper: idempotent installer for optional external deps.
+ * - Implemented as a full ESM module using top-level await.
+ * - Detects missing packages using dynamic `import()` (avoids createRequire / CJS).
+ * - Skips automatic install in CI by default; set H56_FORCE_POSTINSTALL=1 to override.
+ * - Uses spawnSync to run npm install and keeps the script resilient (won't throw on failure).
+ *
+ */
 
 import { spawnSync } from "child_process";
-import { createRequire } from "module";
+import path from "path";
+import { fileURLToPath } from "url";
 
-const require = createRequire(import.meta.url);
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
 
 const optionalDeps = ["h56-translator"];
 
-function isInstalled(name) {
+/**
+ * Check whether a package is resolvable via dynamic import.
+ * Uses import() which will attempt to load the package; this is the most portable
+ * ESM-compatible way to test presence without using CJS helpers.
+ *
+ * We deliberately avoid `require.resolve` / createRequire to keep file pure ESM.
+ */
+async function isInstalled(name) {
   try {
-    require.resolve(name);
+    // dynamic import of a bare specifier will resolve via Node's resolver
+    await import(name);
     return true;
-  } catch (_) {
+  } catch (err) {
+    // import failed => treat as missing
     return false;
   }
 }
 
+/**
+ * Run npm install for the given list of packages (synchronous to keep postinstall simple).
+ */
 function installDeps(deps) {
-  if (!deps.length) return;
+  if (!deps || deps.length === 0) return;
   const npmCmd = process.platform === "win32" ? "npm.cmd" : "npm";
   const args = ["install", "--no-audit", "--no-fund", "--save", ...deps];
-  console.log("Installing optional dependencies:", deps.join(", "));
-  const res = spawnSync(npmCmd, args, { stdio: "inherit" });
+  console.log(`Installing optional dependencies: ${deps.join(", ")}`);
+  const res = spawnSync(npmCmd, args, { stdio: "inherit", shell: false, cwd: process.cwd() });
   if (res.error || res.status !== 0) {
-    console.error("Failed to install optional dependencies. You can run manually:");
+    console.error("Failed to install optional dependencies automatically. Please run manually:");
     console.error("  npm install " + deps.join(" "));
-    // do not throw to keep npm install resilient
+    // keep postinstall resilient: do not throw/exit non-zero to avoid breaking npm install
   } else {
     console.log("Optional dependencies installed.");
   }
 }
 
-(function main() {
+async function main() {
   try {
-    const toInstall = optionalDeps.filter((d) => !isInstalled(d));
-    if (toInstall.length === 0) return;
+    const toInstall = [];
+    for (const dep of optionalDeps) {
+      const present = await isInstalled(dep);
+      if (!present) toInstall.push(dep);
+    }
 
-    // Skip auto-install in CI by default to avoid surprises; allow override.
+    if (toInstall.length === 0) {
+      // nothing to do
+      // console.log("All optional dependencies present.");
+      return;
+    }
+
+    // Safety: skip auto-install in CI unless explicitly forced
     if (process.env.CI && !process.env.H56_FORCE_POSTINSTALL) {
       console.log(
         "CI environment detected — skipping automatic installation of optional dependencies.",
@@ -51,7 +80,9 @@ function installDeps(deps) {
 
     installDeps(toInstall);
   } catch (err) {
+    // Keep postinstall resilient; log error but don't fail the install process.
     console.error("Postinstall check encountered an error:", err && err.message ? err.message : err);
-    // do not exit non-zero; keep postinstall resilient
   }
-})();
+}
+
+await main();