gulp-jlto 1.3.0 → 1.3.1

package/README.md

@@ -29,3 +29,15 @@ gulp.task('jlto', () => {
     .pipe(gulp.dest('build'));
 });
 ```
+
+## Tests
+
+Tests are written using Node's `assert` module. To run them, invoke `npm test`.
+
+## Further Reading
+
+[Why You Should Write Open Source Code and How It Helps Your Career](https://explainme.online/article/why-you-should-write-open-source-code-and-how-it-helps-your-career)
+
+## License
+
+JLTO is available under the [MIT license](https://opensource.org/licenses/MIT), see the LICENSE file for more information.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gulp-jlto",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Gulp tool for optimizing Jinja like templates",
   "keywords": [
     "jinja",
@@ -37,7 +37,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "jlto": "^1.5.0"
+    "jlto": "^1.5.4"
   },
   "devDependencies": {
     "@eslint/js": "^9.39.3",

package/test/gulp-task.test.js

@@ -57,21 +57,34 @@ let runTest = async (name, fn) => {
   }
 };
 
+let buildPaths = (tempRoot) => {
+  let sourceDir = path.join(tempRoot, 'src');
+  let outputDir = path.join(tempRoot, 'dist');
+  let sourceFilePath = path.join(sourceDir, 'template.html');
+  let outputFilePath = path.join(outputDir, 'template.html');
+
+  return {
+    sourceDir,
+    outputDir,
+    sourceFilePath,
+    outputFilePath,
+  };
+};
+
 let testOptimizedOutput = async () => {
   await withTempDirectory('gulp-jlto-', async (tempRoot) => {
-    let sourceDir = path.join(tempRoot, 'src');
-    let outputDir = path.join(tempRoot, 'dist');
-    let sourceFilePath = path.join(sourceDir, 'template.html');
-    let outputFilePath = path.join(outputDir, 'template.html');
+    let sourceString = '{% if user %}\n  <div> Hello </div>\n{% endif %}';
+    let expectedString = '{% if user %}<div>Hello</div>{% endif %}';
+    let {sourceDir, outputDir, sourceFilePath, outputFilePath} = buildPaths(tempRoot);
 
     await fsp.mkdir(sourceDir, {recursive: true});
-    await fsp.writeFile(sourceFilePath, 'SOURCE', 'utf8');
+    await fsp.writeFile(sourceFilePath, sourceString, 'utf8');
 
     jlto.optimizeString = async (source, options) => {
-      assert.strictEqual(source, 'SOURCE');
+      assert.strictEqual(source, sourceString);
       assert.deepStrictEqual(options, {strip: true});
 
-      return 'OPTIMIZED';
+      return expectedString;
     };
 
     let optimizeTask = () => {
@@ -87,21 +100,23 @@ let testOptimizedOutput = async () => {
 
     let output = await fsp.readFile(outputFilePath, 'utf8');
 
-    assert.strictEqual(output, 'OPTIMIZED');
+    assert.strictEqual(output, expectedString);
   });
 };
 
 let testFallbackOnOptimizeFailure = async () => {
   await withTempDirectory('gulp-jlto-', async (tempRoot) => {
-    let sourceDir = path.join(tempRoot, 'src');
-    let outputDir = path.join(tempRoot, 'dist');
-    let sourceFilePath = path.join(sourceDir, 'template.html');
-    let outputFilePath = path.join(outputDir, 'template.html');
+    let sourceString = '{% if user %}\n  <div> Hello </div>\n{% endif %}';
+    let called = false;
+    let {sourceDir, outputDir, sourceFilePath, outputFilePath} = buildPaths(tempRoot);
 
     await fsp.mkdir(sourceDir, {recursive: true});
-    await fsp.writeFile(sourceFilePath, 'SOURCE', 'utf8');
+    await fsp.writeFile(sourceFilePath, sourceString, 'utf8');
 
-    jlto.optimizeString = async () => {
+    jlto.optimizeString = async (source, options) => {
+      called = true;
+      assert.strictEqual(source, sourceString);
+      assert.strictEqual(options, undefined);
       throw new Error('optimizer failed');
     };
 
@@ -118,7 +133,8 @@ let testFallbackOnOptimizeFailure = async () => {
 
     let output = await fsp.readFile(outputFilePath, 'utf8');
 
-    assert.strictEqual(output, 'SOURCE');
+    assert.strictEqual(called, true);
+    assert.strictEqual(output, sourceString);
   });
 };
 

package/test/main.test.js

@@ -17,6 +17,13 @@ let runPlugin = (file, options) => {
   });
 };
 
+let createFile = (contents) => {
+  return {
+    isNull: () => false,
+    contents: Buffer.from(contents),
+  };
+};
+
 let testCases = [
   {
     name: 'passes null files through unchanged',
@@ -43,35 +50,38 @@ let testCases = [
   {
     name: 'optimizes non-null files when optimizer resolves',
     run: async () => {
+      let sourceString = '{% if user %}\n  <div> Hello </div>\n{% endif %}';
+      let expectedString = '{% if user %}<div>Hello</div>{% endif %}';
+
       jlto.optimizeString = async (source, options) => {
-        assert.strictEqual(source, 'source');
+        assert.strictEqual(source, sourceString);
         assert.deepStrictEqual(options, {keepComments: false});
 
-        return 'optimized';
+        return expectedString;
       };
 
-      let file = {
-        isNull: () => false,
-        contents: Buffer.from('source'),
-      };
+      let file = createFile(sourceString);
       let result = await runPlugin(file, {keepComments: false});
 
-      assert.strictEqual(result.contents.toString(), 'optimized');
+      assert.strictEqual(result, file);
+      assert.strictEqual(result.contents.toString(), expectedString);
     },
   },
   {
     name: 'keeps original contents when optimizer throws',
     run: async () => {
+      let called = false;
+
       jlto.optimizeString = async () => {
+        called = true;
         throw new Error('boom');
       };
 
-      let file = {
-        isNull: () => false,
-        contents: Buffer.from('source'),
-      };
+      let file = createFile('source');
       let result = await runPlugin(file);
 
+      assert.strictEqual(result, file);
+      assert.strictEqual(called, true);
       assert.strictEqual(result.contents.toString(), 'source');
     },
   },