gtx-cli 2.4.8 → 2.4.10

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # gtx-cli
 
+## 2.4.10
+
+### Patch Changes
+
+- [#778](https://github.com/generaltranslation/gt/pull/778) [`0d8f414`](https://github.com/generaltranslation/gt/commit/0d8f4144696873b15f0aaa6744bdb7390d472279) Thanks [@SamEggert](https://github.com/SamEggert)! - skip dynamic expressions for HTML content props in parseJSX
+
+## 2.4.9
+
+### Patch Changes
+
+- [#774](https://github.com/generaltranslation/gt/pull/774) [`87dab40`](https://github.com/generaltranslation/gt/commit/87dab40efc9469d6ba3b3dc143d7d7a27422f7b0) Thanks [@fernando-aviles](https://github.com/fernando-aviles)! - Hiding saving local translations behind the --save-local flag
+
 ## 2.4.8
 
 ### Patch Changes

package/dist/api/sendFiles.js

@@ -86,18 +86,20 @@ export async function sendFiles(files, options, settings) {
                 setupSpinner.stop(chalk.yellow(`Setup ${setupFailedMessage ? 'failed' : 'timed out'} — proceeding without setup${setupFailedMessage ? ` (${setupFailedMessage})` : ''}`));
             }
         }
-        // Step 3: Prior to enqueue, detect and submit user edit diffs (minimal UX)
-        const prepSpinner = createSpinner('dots');
-        currentSpinner = prepSpinner;
-        prepSpinner.start('Updating translations...');
-        try {
-            await collectAndSendUserEditDiffs(upload.uploadedFiles, settings);
-        }
-        catch {
-            // Non-fatal; keep going to enqueue
-        }
-        finally {
-            prepSpinner.stop('Updated translations');
+        // Step 3 (optional): Prior to enqueue, detect and submit user edit diffs
+        if (options?.saveLocal) {
+            const prepSpinner = createSpinner('dots');
+            currentSpinner = prepSpinner;
+            prepSpinner.start('Updating translations...');
+            try {
+                await collectAndSendUserEditDiffs(upload.uploadedFiles, settings);
+            }
+            catch {
+                // Non-fatal; keep going to enqueue
+            }
+            finally {
+                prepSpinner.stop('Updated translations');
+            }
         }
         // Step 4: Enqueue translations by reference
         const enqueueSpinner = createSpinner('dots');

package/dist/cli/flags.js

@@ -20,6 +20,7 @@ export function attachTranslateFlags(command) {
         }
         return parsedValue;
     }, DEFAULT_TIMEOUT)
+        .option('--save-local', 'Detect and save local edits before enqueuing translations', false)
         .option('--publish', 'Publish translations to the CDN', false)
         .option('--experimental-localize-static-urls', 'Triggering this will run a script after the cli tool that localizes all urls in content files. Currently only supported for md and mdx files.', false)
         .option('--experimental-hide-default-locale', 'When localizing static locales, hide the default locale from the path', false)

package/dist/react/jsx/utils/parseJsx.js

@@ -8,6 +8,7 @@ import { isAcceptedPluralForm } from 'generaltranslation/internal';
 import { handleChildrenWhitespace } from '../trimJsxStringChildren.js';
 import { isStaticExpression } from '../evaluateJsx.js';
 import { GT_ATTRIBUTES, mapAttributeName, VARIABLE_COMPONENTS, } from './constants.js';
+import { HTML_CONTENT_PROPS } from 'generaltranslation/types';
 /**
  * Builds a JSX tree from a given node, recursively handling children.
  * @param node - The node to build the tree from
@@ -80,15 +81,29 @@ export function buildJSXTree(importAliases, node, unwrappedExpressions, updates,
                         attrValue = attr.value.value;
                     }
                     else if (t.isJSXExpressionContainer(attr.value)) {
-                        if ((elementIsPlural && isAcceptedPluralForm(attrName)) ||
-                            (elementIsBranch && attrName !== 'branch')) {
-                            // Make sure that variable strings like {`I have ${count} book`} are invalid!
-                            if (t.isTemplateLiteral(attr.value.expression) &&
-                                !isStaticExpression(attr.value.expression).isStatic) {
-                                unwrappedExpressions.push(generate(attr.value).code);
+                        // Check if this is an HTML content prop (title, placeholder, alt, etc.)
+                        const isHtmlContentProp = Object.values(HTML_CONTENT_PROPS).includes(attrName);
+                        if (isHtmlContentProp) {
+                            // For HTML content props, only accept static string expressions
+                            const staticAnalysis = isStaticExpression(attr.value.expression);
+                            if (staticAnalysis.isStatic &&
+                                staticAnalysis.value !== undefined) {
+                                attrValue = staticAnalysis.value;
                             }
+                            // Otherwise attrValue stays null and won't be included
+                        }
+                        else {
+                            // For non-HTML-content props, validate plural/branch then build tree
+                            if ((elementIsPlural && isAcceptedPluralForm(attrName)) ||
+                                (elementIsBranch && attrName !== 'branch')) {
+                                // Make sure that variable strings like {`I have ${count} book`} are invalid!
+                                if (t.isTemplateLiteral(attr.value.expression) &&
+                                    !isStaticExpression(attr.value.expression).isStatic) {
+                                    unwrappedExpressions.push(generate(attr.value).code);
+                                }
+                            }
+                            attrValue = buildJSXTree(importAliases, attr.value.expression, unwrappedExpressions, updates, errors, warnings, file, true);
                         }
-                        attrValue = buildJSXTree(importAliases, attr.value.expression, unwrappedExpressions, updates, errors, warnings, file, true);
                     }
                 }
                 props[attrName] = attrValue;

package/dist/types/index.d.ts

@@ -39,6 +39,7 @@ export type TranslateFlags = {
     src?: string[];
     timeout: number;
     dryRun: boolean;
+    saveLocal?: boolean;
     stageTranslations?: boolean;
     publish?: boolean;
     force?: boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gtx-cli",
-  "version": "2.4.8",
+  "version": "2.4.10",
   "main": "dist/index.js",
   "bin": "dist/main.js",
   "files": [