gtfs-to-html 2.12.8 → 2.12.10

package/README.md

@@ -61,6 +61,7 @@ Many transit agencies use `gtfs-to-html` to generate the schedule pages used on
 
 | Agency                                                                        | Location                            |
 | ----------------------------------------------------------------------------- | ----------------------------------- |
+| [Asheville Rides Transit (ART)](https://www.ridetheart.com)                   | Asheville, North Carolina           |
 | [Basin Transit](https://basin-transit.com)                                    | Morongo Basin, California           |
 | [Bayway Transit](https://www.baywaytransit.org)                               | Panama City, Florida                |
 | [Brockton Area Transit Authority](https://ridebat.com)                        | Brockton, Massachusetts             |
@@ -120,6 +121,13 @@ Are you using `gtfs-to-html`? Let us know via email [gtfs@blinktag.com](mailto:g
 
 Pull requests are welcome, as well as [feedback and reporting issues](https://github.com/blinktaginc/gtfs-to-html/issues).
 
+### Development Setup
+
+    pnpm install
+    pnpm run build
+
+`pnpm install` installs dependencies. `pnpm run build` compiles TypeScript and vendors browser-compatible libraries (maplibre-gl, pbf, anchorme, etc.) from devDependencies into `dist/browser` via `scripts/copy-browser-assets.js`. These vendored files are included in the published npm package so consumers don't need to run any postinstall steps.
+
 ## Tests
 
     npm test

package/dist/app/index.js

@@ -188,7 +188,7 @@ import {
 import { homedir } from "os";
 import * as _ from "lodash-es";
 import { uniqBy } from "lodash-es";
-import archiver from "archiver";
+import { ZipArchive } from "archiver";
 import beautify from "js-beautify";
 import sanitizeHtml from "sanitize-html";
 import { renderFile } from "pug";
@@ -330,27 +330,6 @@ function isGtfsToHtmlError(error) {
   return candidate.name === "GtfsToHtmlError" && typeof candidate.message === "string" && typeof candidate.code === "string" && typeof candidate.category === "string" && typeof candidate.isOperational === "boolean";
 }
 
-// src/lib/log-utils.ts
-import { clearLine, cursorTo } from "readline";
-import { noop } from "lodash-es";
-import * as colors from "yoctocolors";
-import { getAgencies, getFeedInfo, isGtfsError as isGtfsError2, formatGtfsError } from "gtfs";
-import Table from "cli-table";
-function logWarning(config2) {
-  if (config2.logFunction) {
-    return config2.logFunction;
-  }
-  return (text) => {
-    process.stdout.write(`
-${formatWarning(text)}
-`);
-  };
-}
-function formatWarning(text) {
-  const warningMessage = `${colors.underline("Warning")}: ${text}`;
-  return colors.yellow(warningMessage);
-}
-
 // src/lib/file-utils.ts
 var homeDirectory = homedir();
 function getPathToThisModuleFolder() {
@@ -426,6 +405,27 @@ import { getShapesAsGeoJSON, getStopsAsGeoJSON } from "gtfs";
 import simplify from "@turf/simplify";
 import { featureCollection, round } from "@turf/helpers";
 
+// src/lib/log-utils.ts
+import { clearLine, cursorTo } from "readline";
+import { noop } from "lodash-es";
+import * as colors from "yoctocolors";
+import { getAgencies, getFeedInfo, isGtfsError as isGtfsError2, formatGtfsError } from "gtfs";
+import Table from "cli-table";
+function logWarning(config2) {
+  if (config2.logFunction) {
+    return config2.logFunction;
+  }
+  return (text) => {
+    process.stdout.write(`
+${formatWarning(text)}
+`);
+  };
+}
+function formatWarning(text) {
+  const warningMessage = `${colors.underline("Warning")}: ${text}`;
+  return colors.yellow(warningMessage);
+}
+
 // src/lib/trip-id-utils.ts
 var getBaseTripId = (tripId) => tripId.replace(/_freq_\d+$/, "");
 var getBaseTripIds = (trips) => Array.from(new Set(trips.map((trip) => getBaseTripId(trip.trip_id))));
@@ -509,7 +509,7 @@ function getAgencyGeoJSON(config2) {
 // package.json
 var package_default = {
   name: "gtfs-to-html",
-  version: "2.12.8",
+  version: "2.12.10",
   private: false,
   description: "Build human readable transit timetables as HTML, PDF or CSV from GTFS",
   keywords: [
@@ -552,41 +552,36 @@ var package_default = {
     "gtfs-to-html": "dist/bin/gtfs-to-html.js"
   },
   scripts: {
-    build: "tsup",
-    postbuild: "node scripts/postinstall.js",
+    build: "tsup && node scripts/copy-browser-assets.js",
     start: "node ./dist/app",
-    prepare: "husky && npm run build",
-    postinstall: "node scripts/postinstall.js"
+    prepare: "husky && pnpm run build",
+    prepack: "husky && pnpm run build"
   },
   dependencies: {
-    "@maplibre/maplibre-gl-geocoder": "^1.9.4",
-    "@turf/helpers": "^7.3.4",
-    "@turf/simplify": "^7.3.4",
-    anchorme: "^3.0.8",
-    archiver: "^7.0.1",
+    "@turf/helpers": "^7.3.5",
+    "@turf/simplify": "^7.3.5",
+    archiver: "^8.0.0",
     "cli-table": "^0.3.11",
     "css.escape": "^1.5.1",
     "csv-stringify": "^6.7.0",
     express: "^5.2.1",
     gtfs: "^4.18.5",
-    "gtfs-realtime-pbf-js-module": "^1.0.0",
     "js-beautify": "^1.15.4",
     "lodash-es": "^4.18.1",
-    "maplibre-gl": "^5.23.0",
-    marked: "^18.0.0",
+    marked: "^18.0.3",
     moment: "^2.30.1",
-    pbf: "^4.0.1",
     "pretty-error": "^4.0.0",
     pug: "^3.0.4",
-    puppeteer: "^24.40.0",
+    puppeteer: "^24.43.1",
     "sanitize-filename": "^1.6.4",
-    "sanitize-html": "^2.17.2",
+    "sanitize-html": "^2.17.4",
     sqlstring: "^2.3.3",
     toposort: "^2.0.2",
     yargs: "^18.0.0",
     yoctocolors: "^2.1.2"
   },
   devDependencies: {
+    "@maplibre/maplibre-gl-geocoder": "^1.9.4",
     "@types/archiver": "^7.0.0",
     "@types/cli-table": "^0.3.4",
     "@types/express": "^5.0.6",
@@ -598,15 +593,20 @@ var package_default = {
     "@types/sqlstring": "^2.3.2",
     "@types/toposort": "^2.0.7",
     "@types/yargs": "^17.0.35",
+    anchorme: "^3.0.8",
+    "gtfs-realtime-pbf-js-module": "^1.0.0",
     husky: "^9.1.7",
-    "lint-staged": "^16.4.0",
-    prettier: "^3.8.2",
+    "lint-staged": "^17.0.5",
+    "maplibre-gl": "^5.24.0",
+    pbf: "^4.0.1",
+    prettier: "^3.8.3",
     tsup: "^8.5.1",
-    typescript: "^6.0.2"
+    typescript: "^6.0.3"
   },
   engines: {
     node: ">= 22"
   },
+  packageManager: "pnpm@11.1.3",
   "release-it": {
     github: {
       release: true
@@ -617,7 +617,7 @@ var package_default = {
       }
     },
     hooks: {
-      "after:bump": "npm run build"
+      "after:bump": "pnpm run build"
     }
   },
   prettier: {
@@ -625,12 +625,6 @@ var package_default = {
   },
   "lint-staged": {
     "*.{js,ts,json}": "prettier --write"
-  },
-  pnpm: {
-    onlyBuiltDependencies: [
-      "better-sqlite3",
-      "puppeteer"
-    ]
   }
 };
 
@@ -1451,6 +1445,46 @@ var filterTrips = (timetable, calendars, config2) => {
   if (config2.showDuplicateTrips === false) {
     filteredTrips = deduplicateTrips(filteredTrips);
   }
+  const dayNames = [
+    "monday",
+    "tuesday",
+    "wednesday",
+    "thursday",
+    "friday",
+    "saturday",
+    "sunday"
+  ];
+  const timetableDays = dayNames.filter((day) => timetable[day] === 1);
+  if (timetableDays.length > 1) {
+    const warnedServiceIds = /* @__PURE__ */ new Set();
+    for (const trip of filteredTrips) {
+      const tripServiceIds = [
+        trip.service_id,
+        ...trip.additional_service_ids ?? []
+      ];
+      const tripCalendars = calendars.filter(
+        (c) => tripServiceIds.includes(c.service_id)
+      );
+      if (tripCalendars.length === 0) {
+        continue;
+      }
+      const tripDays = getDaysFromCalendars(tripCalendars);
+      const missingDays = timetableDays.filter(
+        (day) => (tripDays[day] ?? 0) !== 1
+      );
+      if (missingDays.length > 0) {
+        const serviceIdKey = tripServiceIds.sort().join("|");
+        if (!warnedServiceIds.has(serviceIdKey)) {
+          warnedServiceIds.add(serviceIdKey);
+          const tripDayList = formatDays(tripDays, config2);
+          const timetableDayList = formatDays(timetable, config2);
+          timetable.warnings.push(
+            `Timetable ${timetable.timetable_id} (Routes: ${timetable.routes.map((route) => route.route_short_name).join(", ")}) covers ${timetableDayList} but some trips (service_id=${tripServiceIds.join(", ")}) only run on ${tripDayList}. This may indicate a data issue in the GTFS or that you should generate separate timetables for different days of the week.`
+          );
+        }
+      }
+    }
+  }
   const formattedTrips = filteredTrips.map((trip) => {
     const tripCalendars = calendars.filter((calendar) => {
       return [
@@ -2411,30 +2445,12 @@ app.use((req, res, next) => {
 });
 var staticAssetPath = config.templatePath === void 0 ? getPathToViewsFolder(config) : untildify(config.templatePath);
 app.use(express.static(staticAssetPath));
-var frontendLibraryPaths = [
-  { route: "/js", package: "pbf", subPath: "dist" },
-  { route: "/js", package: "gtfs-realtime-pbf-js-module", subPath: "" },
-  { route: "/js", package: "anchorme", subPath: "../../dist/browser" },
-  { route: "/js", package: "maplibre-gl", subPath: "../dist" },
-  {
-    route: "/js",
-    package: "@maplibre/maplibre-gl-geocoder",
-    subPath: "../dist"
-  },
-  { route: "/css", package: "maplibre-gl", subPath: "../dist" },
-  {
-    route: "/css",
-    package: "@maplibre/maplibre-gl-geocoder",
-    subPath: "../dist"
-  }
-];
-var resolvePackagePath = (packageName, subPath) => {
-  const packagePath = dirname2(fileURLToPath2(import.meta.resolve(packageName)));
-  return subPath ? join2(packagePath, subPath) : packagePath;
-};
-for (const { route, package: pkg, subPath } of frontendLibraryPaths) {
-  app.use(route, express.static(resolvePackagePath(pkg, subPath)));
-}
+var browserAssetsPath = join2(
+  dirname2(fileURLToPath2(import.meta.url)),
+  "../browser"
+);
+app.use("/js", express.static(browserAssetsPath));
+app.use("/css", express.static(browserAssetsPath));
 app.get("/", async (req, res, next) => {
   try {
     const timetablePages = [];