gsd-pi 2.82.0 → 3.0.0-dev.8b8d129d7

package/src/resources/extensions/gsd/tests/doctor-forensics-db-open-regression.test.ts

@@ -0,0 +1,50 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+
+import { closeDatabase } from "../gsd-db.ts";
+import { buildForensicReport } from "../forensics.ts";
+import { handleDoctor } from "../commands-handlers.ts";
+import { withCommandCwd } from "../commands/context.ts";
+
+test("#5194 forensics opens DB before computing completion counts", async (t) => {
+  const base = mkdtempSync(join(tmpdir(), "gsd-forensics-db-open-"));
+  t.after(() => rmSync(base, { recursive: true, force: true }));
+
+  mkdirSync(join(base, ".gsd"), { recursive: true });
+  closeDatabase();
+
+  const report = await buildForensicReport(base);
+  assert.ok(report.dbCompletionCounts, "forensics should expose DB completion counts when .gsd exists");
+  assert.equal(report.dbCompletionCounts?.milestonesTotal, 0);
+  assert.equal(report.dbCompletionCounts?.slicesTotal, 0);
+  assert.equal(report.dbCompletionCounts?.tasksTotal, 0);
+});
+
+test("#5194 doctor command does not emit false db_unavailable when gsd.db exists", async (t) => {
+  const base = mkdtempSync(join(tmpdir(), "gsd-doctor-db-open-"));
+  t.after(() => rmSync(base, { recursive: true, force: true }));
+
+  const gsdDir = join(base, ".gsd");
+  mkdirSync(gsdDir, { recursive: true });
+  writeFileSync(join(gsdDir, "gsd.db"), "");
+  closeDatabase();
+
+  const notifications: string[] = [];
+  const ctx = { ui: { notify: (msg: string) => notifications.push(msg) } } as any;
+  const pi = {} as any;
+
+  await withCommandCwd(base, async () => {
+    await handleDoctor("--json", ctx, pi);
+  });
+
+  const jsonReport = notifications.find((entry) => entry.trim().startsWith("{"));
+  assert.ok(jsonReport, "doctor --json should emit a JSON report");
+  assert.doesNotMatch(
+    jsonReport!,
+    /"code"\s*:\s*"db_unavailable"/,
+    "doctor should not report db_unavailable when it can open project DB",
+  );
+});

package/src/resources/extensions/gsd/tests/evidence-cross-ref.test.ts

@@ -0,0 +1,97 @@
+// Project/App: GSD-2
+// File Purpose: Tests for verification evidence cross-reference mismatch policy.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+
+import { crossReferenceEvidence } from "../safety/evidence-cross-ref.ts";
+import type { EvidenceEntry } from "../safety/evidence-collector.ts";
+
+test("claims of passing verification become errors when recorded bash evidence failed", () => {
+  const mismatches = crossReferenceEvidence(
+    [{ command: "npm test", exitCode: 0, verdict: "passed" }],
+    [
+      {
+        kind: "bash",
+        toolCallId: "call-1",
+        command: "npm test",
+        exitCode: 1,
+        outputSnippet: "failed",
+        timestamp: Date.now(),
+      },
+    ] as EvidenceEntry[],
+  );
+
+  assert.equal(mismatches.length, 1);
+  assert.equal(mismatches[0].severity, "error");
+  assert.match(mismatches[0].reason, /Claimed exitCode=0/);
+});
+
+test("passing retry evidence is not invalidated by an earlier failed run of the same command", () => {
+  const command = "node todo.js add 'Task A' && node todo.js add 'Task B' && node todo.js done 1";
+  const mismatches = crossReferenceEvidence(
+    [{ command, exitCode: 0, verdict: "passed after retry" }],
+    [
+      {
+        kind: "bash",
+        toolCallId: "call-1",
+        command,
+        exitCode: 1,
+        outputSnippet: "Task #1 not found",
+        timestamp: 1,
+      },
+      {
+        kind: "bash",
+        toolCallId: "call-2",
+        command,
+        exitCode: 0,
+        outputSnippet: "Marked #1 done.",
+        timestamp: 2,
+      },
+    ] as EvidenceEntry[],
+  );
+
+  assert.deepEqual(mismatches, []);
+});
+
+test("stale verification evidence batches are ignored when a newer completion batch exists", () => {
+  const command = "node todo.js add 'Task A' && node todo.js add 'Task B' && node todo.js done 1";
+  const resetCommand = `rm -f "$HOME/.config/todo/data.json" && ${command}`;
+  const mismatches = crossReferenceEvidence(
+    [
+      { command, exitCode: 0, verdict: "pass", createdAt: "2026-05-14T11:16:48.588Z" },
+      { command, exitCode: 1, verdict: "fail before reset", createdAt: "2026-05-14T11:28:36.952Z" },
+      { command: resetCommand, exitCode: 0, verdict: "pass after reset", createdAt: "2026-05-14T11:28:36.952Z" },
+    ],
+    [
+      {
+        kind: "bash",
+        toolCallId: "call-1",
+        command,
+        exitCode: 1,
+        outputSnippet: "Task #1 not found",
+        timestamp: 1,
+      },
+      {
+        kind: "bash",
+        toolCallId: "call-2",
+        command: resetCommand,
+        exitCode: 0,
+        outputSnippet: "Marked #1 done.",
+        timestamp: 2,
+      },
+    ] as EvidenceEntry[],
+  );
+
+  assert.deepEqual(mismatches, []);
+});
+
+test("missing recorded bash evidence remains a warning", () => {
+  const mismatches = crossReferenceEvidence(
+    [{ command: "npm test", exitCode: 0, verdict: "passed" }],
+    [],
+  );
+
+  assert.equal(mismatches.length, 1);
+  assert.equal(mismatches[0].severity, "warning");
+});

package/src/resources/extensions/gsd/tests/export-html-enhancements.test.ts

@@ -141,6 +141,14 @@ test("Feature 1: executive summary paragraph is rendered", () => {
   assert.ok(html.includes("$2.50 spent"), "should contain cost");
 });
 
+test("report uses the shared GSD HTML shell", () => {
+  const html = generateHtmlReport(mockData(), mockOpts());
+  assert.ok(html.includes('<span class="logo">GSD</span>'), "should render shared shell logo");
+  assert.ok(html.includes('<span class="kind-chip">Report</span>'), "should render report kind chip");
+  assert.ok(html.includes('<nav class="toc" aria-label="Report sections">'), "should render shared shell TOC");
+  assert.ok(html.includes('<main>'), "should render content inside shared shell main");
+});
+
 test("Feature 1: executive summary includes budget context when set", () => {
   const data = mockData({ health: { ...mockData().health, budgetCeiling: 10.00 } });
   const html = generateHtmlReport(data, mockOpts());

package/src/resources/extensions/gsd/tests/freeform-decisions.test.ts

@@ -14,6 +14,7 @@ import {
 import {
   saveDecisionToDb,
 } from '../db-writer.ts';
+import { getAllDecisionsFromMemories } from '../context-store.ts';
 
 // ═══════════════════════════════════════════════════════════════════════════
 // Helpers
@@ -31,11 +32,14 @@ function cleanupDir(dir: string): void {
   } catch { /* swallow */ }
 }
 
-/** Query all decisions from the DB ordered by seq. */
+/**
+ * Query all decisions. ADR-013 Stage 3 (PR #5755): decisions are written
+ * exclusively to memories; this helper returns the same Decision shape the
+ * previous SELECT * FROM decisions produced so the assertions below stay
+ * one-line lookups.
+ */
 function queryAllDecisions(): Array<Record<string, unknown>> {
-  const adapter = _getAdapter();
-  if (!adapter) return [];
-  return adapter.prepare('SELECT * FROM decisions ORDER BY seq').all();
+  return getAllDecisionsFromMemories().map((d) => ({ ...d }));
 }
 
 // ═══════════════════════════════════════════════════════════════════════════

package/src/resources/extensions/gsd/tests/gsd-db.test.ts

@@ -30,6 +30,7 @@ import {
   insertTask,
   getTask,
   getSliceTasks,
+  getActiveMilestoneFromDb,
   deleteMilestone,
   clearEngineHierarchy,
   recordMilestoneCommitAttribution,
@@ -37,6 +38,7 @@ import {
   checkpointDatabase,
   refreshOpenDatabaseFromDisk,
   tryCreateMemoriesFts,
+  _isLikelyWslDrvFsPathForTest,
 } from '../gsd-db.ts';
 import { _resetLogs, peekLogs, setStderrLoggingEnabled } from '../workflow-logger.ts';
 
@@ -218,6 +220,22 @@ describe('gsd-db', () => {
     closeDatabase();
   });
 
+  test("gsd-db: getActiveMilestoneFromDb excludes closed statuses", () => {
+    openDatabase(":memory:");
+
+    insertMilestone({ id: "M001", title: "Done", status: "complete" });
+    insertMilestone({ id: "M002", title: "Legacy done", status: "done" });
+    insertMilestone({ id: "M003", title: "Skipped", status: "skipped" });
+    insertMilestone({ id: "M004", title: "Closed", status: "closed" });
+    insertMilestone({ id: "M005", title: "Parked", status: "parked" });
+    insertMilestone({ id: "M006", title: "Active", status: "active" });
+
+    const active = getActiveMilestoneFromDb();
+    assert.equal(active?.id, "M006", "closed/complete/done/skipped/parked should be excluded from active milestone selection");
+
+    closeDatabase();
+  });
+
   test('gsd-db: active_decisions view excludes superseded', () => {
     openDatabase(':memory:');
 
@@ -345,6 +363,16 @@ describe('gsd-db', () => {
     });
   });
 
+  test('gsd-db: detects WSL DrvFs mount paths for conservative pragmas', () => {
+    withPlatform('linux', () => {
+      assert.equal(_isLikelyWslDrvFsPathForTest('/mnt/d/code/project/.gsd/gsd.db'), true);
+      assert.equal(_isLikelyWslDrvFsPathForTest('/tmp/gsd.db'), false);
+    });
+    withPlatform('darwin', () => {
+      assert.equal(_isLikelyWslDrvFsPathForTest('/mnt/d/code/project/.gsd/gsd.db'), false);
+    });
+  });
+
   test('gsd-db: transaction rollback on error', () => {
     openDatabase(':memory:');
 

package/src/resources/extensions/gsd/tests/gsd-tools.test.ts

@@ -14,7 +14,6 @@ import {
   isDbAvailable,
   upsertRequirement,
   getRequirementById,
-  getDecisionById,
   _getAdapter,
   insertArtifact,
 } from '../gsd-db.ts';
@@ -26,6 +25,7 @@ import {
   nextDecisionId,
   nextRequirementId,
 } from '../db-writer.ts';
+import { getAllDecisionsFromMemories } from '../context-store.ts';
 import type { Requirement } from '../types.ts';
 
 // ═══════════════════════════════════════════════════════════════════════════
@@ -73,12 +73,16 @@ describe('gsd-tools', () => {
 
       assert.deepStrictEqual(result.id, 'D001', 'First decision should be D001');
 
-      // Verify DB row exists
-      const row = getDecisionById('D001');
-      assert.ok(row !== null, 'Decision D001 should exist in DB');
-      assert.deepStrictEqual(row!.scope, 'architecture', 'Decision scope should match');
-      assert.deepStrictEqual(row!.decision, 'Use SQLite for metadata', 'Decision text should match');
-      assert.deepStrictEqual(row!.choice, 'SQLite', 'Decision choice should match');
+      // ADR-013 Stage 3: decisions land in memories, not the legacy decisions
+      // table. Verify the memory row carries the same content.
+      const memoryDecisions = getAllDecisionsFromMemories();
+      assert.equal(memoryDecisions.length, 1, 'one memory row exists after save');
+      const memDecision = memoryDecisions[0];
+      assert.ok(memDecision, 'memory decision exists after save');
+      assert.equal(memDecision.id, 'D001');
+      assert.deepStrictEqual(memDecision.scope, 'architecture', 'memory decision scope should match');
+      assert.deepStrictEqual(memDecision.decision, 'Use SQLite for metadata', 'memory decision text should match');
+      assert.deepStrictEqual(memDecision.choice, 'SQLite', 'memory decision choice should match');
 
       // Verify DECISIONS.md was generated
       const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');

package/src/resources/extensions/gsd/tests/gsdroot-worktree-detection.test.ts

@@ -3,7 +3,7 @@
  *
  * gsdRoot() must return the canonical project .gsd directory when basePath
  * is inside a .gsd/worktrees/<name>/ structure. Worktree-local .gsd folders
- * are legacy projection roots only; runtime state is DB-authoritative at the
+ * are projection roots; runtime/control state stays DB-authoritative at the
  * project .gsd.
  *
  * The bug: when a git worktree lives at /project/.gsd/worktrees/M008/,
@@ -21,7 +21,7 @@ import { mkdtempSync, realpathSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { spawnSync } from "node:child_process";
 
-import { gsdRoot, resolveGsdPathContract, _clearGsdRootCache } from "../paths.ts";
+import { gsdProjectionRoot, gsdRoot, resolveGsdPathContract, _clearGsdRootCache } from "../paths.ts";
 
 describe("gsdRoot() worktree detection (#2594)", () => {
   let projectRoot: string;
@@ -76,6 +76,7 @@ describe("gsdRoot() worktree detection (#2594)", () => {
       `Expected canonical project .gsd (${projectGsd}), got ${result}.`,
     );
     assert.equal(resolveGsdPathContract(worktreeBase).worktreeGsd, worktreeGsd);
+    assert.equal(gsdProjectionRoot(worktreeBase), worktreeGsd);
   });
 
   test("returns project .gsd when worktree .gsd does not exist yet", () => {
@@ -89,6 +90,7 @@ describe("gsdRoot() worktree detection (#2594)", () => {
       projectGsd,
       `Expected canonical project .gsd (${projectGsd}), got ${result}.`,
     );
+    assert.equal(gsdProjectionRoot(worktreeBase), join(worktreeBase, ".gsd"));
   });
 
   test("returns project .gsd when basePath is a real git worktree inside .gsd/worktrees/", () => {
@@ -116,6 +118,7 @@ describe("gsdRoot() worktree detection (#2594)", () => {
       projectGsd,
       `Expected canonical project .gsd (${projectGsd}), got ${gsdResult}`,
     );
+    assert.equal(gsdProjectionRoot(worktreeBase), join(worktreeBase, ".gsd"));
 
     // Cleanup worktree
     spawnSync("git", ["worktree", "remove", "--force", worktreeBase], {

package/src/resources/extensions/gsd/tests/guided-discuss-project-prompt-rendering.test.ts

@@ -34,6 +34,8 @@ test("guided project prompt renders compact interview and artifact guidance", as
   assert.match(prompt, /depth_verification_project_confirm/);
   assert.match(prompt, /artifact_type: "PROJECT"/);
   assert.match(prompt, /omit `milestone_id`/);
+  assert.match(prompt, /do not write the projection directly/i);
+  assert.doesNotMatch(prompt, /then write `.gsd\/PROJECT\.md`/);
   assert.match(prompt, /Do NOT use `artifact_type: "CONTEXT"` and do NOT pass `milestone_id: "PROJECT"`/);
   assert.match(prompt, /\*\*Complexity:\*\* simple/);
   assert.match(prompt, /\*\*Complexity:\*\* complex/);

package/src/resources/extensions/gsd/tests/guided-dispatch-root.test.ts

@@ -0,0 +1,106 @@
+// GSD-2 — Guided workflow dispatch project-root tests.
+// Verifies smart entry dispatch uses the explicit project root instead of cwd.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+import {
+  _dispatchWorkflowForTest,
+  resolveGuidedDispatchProjectRoot,
+} from "../guided-flow.ts";
+
+test("guided dispatch falls back to cwd only when no project root is supplied", () => {
+  const cwd = process.cwd();
+  assert.equal(resolveGuidedDispatchProjectRoot(), cwd);
+  assert.equal(resolveGuidedDispatchProjectRoot("/tmp/explicit-root"), "/tmp/explicit-root");
+});
+
+test("guided dispatch passes the explicit project root through model and compatibility checks", async () => {
+  const explicitRoot = mkdtempSync(join(tmpdir(), "gsd-guided-root-explicit-"));
+  const otherRoot = mkdtempSync(join(tmpdir(), "gsd-guided-root-cwd-"));
+  const workflowPath = join(explicitRoot, "GSD-WORKFLOW.md");
+  const originalWorkflowPath = process.env.GSD_WORKFLOW_PATH;
+  const originalCwd = process.cwd();
+  const seen = {
+    prefsRoot: "",
+    modelRoot: "",
+    compatibilityRoot: "",
+    sent: false,
+  };
+
+  const ctx = {
+    model: { provider: "local-provider" },
+    modelRegistry: {
+      getProviderAuthMode: () => "apiKey",
+    },
+    ui: {
+      notify: () => {},
+    },
+  };
+
+  const pi = {
+    getActiveTools: () => ["gsd_plan_slice"],
+    setActiveTools: () => {},
+    sendMessage: () => {
+      seen.sent = true;
+    },
+  };
+
+  try {
+    writeFileSync(workflowPath, "# Workflow\n", "utf-8");
+    process.env.GSD_WORKFLOW_PATH = workflowPath;
+    process.chdir(otherRoot);
+
+    await _dispatchWorkflowForTest(
+      pi as any,
+      "Plan the slice.",
+      "gsd-run",
+      ctx as any,
+      "plan-slice",
+      {
+        basePath: explicitRoot,
+        deps: {
+          loadPreferences: (projectRoot?: string) => {
+            seen.prefsRoot = projectRoot ?? "";
+            return { preferences: {} } as any;
+          },
+          selectModel: async (
+            _ctx: unknown,
+            _pi: unknown,
+            _unitType: string,
+            _unitId: string,
+            projectRoot: string,
+          ) => {
+            seen.modelRoot = projectRoot;
+            return { routing: null, appliedModel: null };
+          },
+          getTransportSupportError: (
+            _provider: string | undefined,
+            _requiredTools: string[],
+            options?: { projectRoot?: string },
+          ) => {
+            seen.compatibilityRoot = options?.projectRoot ?? "";
+            return null;
+          },
+        },
+      },
+    );
+
+    assert.equal(seen.prefsRoot, explicitRoot);
+    assert.equal(seen.modelRoot, explicitRoot);
+    assert.equal(seen.compatibilityRoot, explicitRoot);
+    assert.equal(seen.sent, true);
+  } finally {
+    process.chdir(originalCwd);
+    if (originalWorkflowPath === undefined) {
+      delete process.env.GSD_WORKFLOW_PATH;
+    } else {
+      process.env.GSD_WORKFLOW_PATH = originalWorkflowPath;
+    }
+    rmSync(explicitRoot, { recursive: true, force: true });
+    rmSync(otherRoot, { recursive: true, force: true });
+  }
+});

package/src/resources/extensions/gsd/tests/guided-flow-session-isolation.test.ts

@@ -21,6 +21,15 @@ import {
   checkAutoStartAfterDiscuss,
 } from "../guided-flow.ts";
 
+function pendingInput(basePath: string, milestoneId: string) {
+  return {
+    basePath,
+    milestoneId,
+    ctx: { ui: { notify: () => undefined } } as any,
+    pi: { setActiveTools: () => undefined, getActiveTools: () => [] } as any,
+  };
+}
+
 // ─── Tests ─────────────────────────────────────────────────────────────────
 
 describe("#2985 Bug 3 — concurrent discuss sessions must be independent", () => {
@@ -34,13 +43,11 @@ describe("#2985 Bug 3 — concurrent discuss sessions must be independent", () =
     const projectB = "/projects/beta";
 
     setPendingAutoStart(projectA, {
-      basePath: projectA,
-      milestoneId: "M001-aaa111",
+      ...pendingInput(projectA, "M001-aaa111"),
     });
 
     setPendingAutoStart(projectB, {
-      basePath: projectB,
-      milestoneId: "M002-bbb222",
+      ...pendingInput(projectB, "M002-bbb222"),
     });
 
     // Both sessions should be retrievable
@@ -55,8 +62,8 @@ describe("#2985 Bug 3 — concurrent discuss sessions must be independent", () =
     const projectA = "/projects/alpha";
     const projectB = "/projects/beta";
 
-    setPendingAutoStart(projectA, { basePath: projectA, milestoneId: "M001-aaa111" });
-    setPendingAutoStart(projectB, { basePath: projectB, milestoneId: "M002-bbb222" });
+    setPendingAutoStart(projectA, pendingInput(projectA, "M001-aaa111"));
+    setPendingAutoStart(projectB, pendingInput(projectB, "M002-bbb222"));
 
     // Clear only projectA
     clearPendingAutoStart(projectA);
@@ -72,8 +79,8 @@ describe("#2985 Bug 4 — getDiscussionMilestoneId must be keyed by basePath", (
   });
 
   test("getDiscussionMilestoneId(basePath) returns correct milestone for each project", () => {
-    setPendingAutoStart("/proj/a", { basePath: "/proj/a", milestoneId: "M001" });
-    setPendingAutoStart("/proj/b", { basePath: "/proj/b", milestoneId: "M002" });
+    setPendingAutoStart("/proj/a", pendingInput("/proj/a", "M001"));
+    setPendingAutoStart("/proj/b", pendingInput("/proj/b", "M002"));
 
     assert.equal(getDiscussionMilestoneId("/proj/a"), "M001");
     assert.equal(getDiscussionMilestoneId("/proj/b"), "M002");
@@ -81,8 +88,8 @@ describe("#2985 Bug 4 — getDiscussionMilestoneId must be keyed by basePath", (
   });
 
   test("getDiscussionMilestoneId() without basePath returns null when multiple sessions exist", () => {
-    setPendingAutoStart("/proj/a", { basePath: "/proj/a", milestoneId: "M001" });
-    setPendingAutoStart("/proj/b", { basePath: "/proj/b", milestoneId: "M002" });
+    setPendingAutoStart("/proj/a", pendingInput("/proj/a", "M001"));
+    setPendingAutoStart("/proj/b", pendingInput("/proj/b", "M002"));
 
     // Without a key, the function should not blindly return the first entry
     const result = getDiscussionMilestoneId();
@@ -92,7 +99,7 @@ describe("#2985 Bug 4 — getDiscussionMilestoneId must be keyed by basePath", (
   });
 
   test("getDiscussionMilestoneId() without basePath returns the milestone when only one session", () => {
-    setPendingAutoStart("/proj/a", { basePath: "/proj/a", milestoneId: "M001" });
+    setPendingAutoStart("/proj/a", pendingInput("/proj/a", "M001"));
 
     // With only one session, backward compat — return it
     const result = getDiscussionMilestoneId();
@@ -129,3 +136,44 @@ test("checkAutoStartAfterDiscuss ignores missing manifest for single-milestone d
     rmSync(base, { recursive: true, force: true });
   }
 });
+
+test("checkAutoStartAfterDiscuss(basePath) selects the matching pending entry when multiple sessions exist", () => {
+  const projectA = mkdtempSync(join(tmpdir(), "gsd-auto-start-project-a-"));
+  const projectB = mkdtempSync(join(tmpdir(), "gsd-auto-start-project-b-"));
+
+  function writeReadyArtifacts(base: string, milestoneId: string): void {
+    const gsdDir = join(base, ".gsd");
+    const milestoneDir = join(gsdDir, "milestones", milestoneId);
+    mkdirSync(milestoneDir, { recursive: true });
+    writeFileSync(join(gsdDir, "PROJECT.md"), `# Project\n\n| ${milestoneId} | Milestone | active |\n`);
+    writeFileSync(join(gsdDir, "STATE.md"), "# State\n");
+    writeFileSync(join(milestoneDir, `${milestoneId}-CONTEXT.md`), "# Context\n");
+  }
+
+  try {
+    clearPendingAutoStart();
+    writeReadyArtifacts(projectA, "M001");
+    writeReadyArtifacts(projectB, "M002");
+    setPendingAutoStart(projectA, {
+      basePath: projectA,
+      milestoneId: "M001",
+      ctx: { ui: { notify: () => undefined } } as any,
+      pi: { setActiveTools: () => undefined, getActiveTools: () => [] } as any,
+    });
+    setPendingAutoStart(projectB, {
+      basePath: projectB,
+      milestoneId: "M002",
+      ctx: { ui: { notify: () => undefined } } as any,
+      pi: { setActiveTools: () => undefined, getActiveTools: () => [] } as any,
+    });
+
+    assert.equal(checkAutoStartAfterDiscuss(), false, "ambiguous pending sessions should not auto-start");
+    assert.equal(checkAutoStartAfterDiscuss(projectB), true, "explicit basePath should select projectB");
+    assert.equal(getDiscussionMilestoneId(projectA), "M001", "projectA should remain pending");
+    assert.equal(getDiscussionMilestoneId(projectB), null, "projectB should be cleared after start");
+  } finally {
+    clearPendingAutoStart();
+    rmSync(projectA, { recursive: true, force: true });
+    rmSync(projectB, { recursive: true, force: true });
+  }
+});

package/src/resources/extensions/gsd/tests/guided-flow.test.ts

@@ -0,0 +1,21 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+
+test("guided milestone discussion callsites pass workingDirectory to loadPrompt", () => {
+  const source = readFileSync(join(__dirname, "..", "guided-flow.ts"), "utf-8");
+  const calls = [...source.matchAll(/loadPrompt\("guided-discuss-milestone",\s*\{([\s\S]*?)\}\)/g)];
+
+  assert.equal(calls.length, 6, "all guided-flow guided-discuss-milestone callsites should be covered");
+  for (const call of calls) {
+    assert.match(
+      call[1] ?? "",
+      /\bworkingDirectory:\s*basePath\b/,
+      "guided-discuss-milestone prompts need workingDirectory so template validation does not crash",
+    );
+  }
+});

package/src/resources/extensions/gsd/tests/guided-tool-contract.test.ts

@@ -0,0 +1,65 @@
+// GSD-2 — Guided Unit Tool Contract tests.
+// Verifies guided workflow turns use manifest tool policy without auto-mode state.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+import { registerHooks } from "../bootstrap/register-hooks.ts";
+import {
+  clearGuidedUnitContext,
+  getGuidedUnitContext,
+  setGuidedUnitContext,
+} from "../guided-unit-context.ts";
+
+test("guided Unit context applies Tool Contract policy when auto-mode has no current Unit", async () => {
+  const basePath = mkdtempSync(join(tmpdir(), "gsd-guided-tool-contract-"));
+  const handlers = new Map<string, Array<(event: any, ctx?: any) => Promise<any> | any>>();
+  const pi = {
+    on(event: string, handler: (event: any, ctx?: any) => Promise<any> | any) {
+      const existing = handlers.get(event) ?? [];
+      existing.push(handler);
+      handlers.set(event, existing);
+    },
+  };
+
+  try {
+    clearGuidedUnitContext();
+    registerHooks(pi as any, []);
+    setGuidedUnitContext(basePath, "plan-slice");
+
+    let blockResult: { block?: boolean; reason?: string } | undefined;
+    for (const handler of handlers.get("tool_call") ?? []) {
+      const result = await handler({
+        toolName: "edit",
+        input: {
+          path: join(basePath, "src", "main.ts"),
+        },
+      }, { cwd: basePath });
+      if (result?.block) {
+        blockResult = result;
+        break;
+      }
+    }
+
+    assert.equal(blockResult?.block, true);
+    assert.match(blockResult?.reason ?? "", /plan-slice|ToolsPolicy|not allowed|blocked/i);
+  } finally {
+    clearGuidedUnitContext();
+    rmSync(basePath, { recursive: true, force: true });
+  }
+});
+
+test("guided Unit context can be cleared by project root", () => {
+  clearGuidedUnitContext();
+  setGuidedUnitContext("/project/a", "plan-slice");
+  setGuidedUnitContext("/project/b", "complete-slice");
+
+  clearGuidedUnitContext("/project/a");
+
+  assert.equal(getGuidedUnitContext("/project/a"), null);
+  assert.equal(getGuidedUnitContext("/project/b")?.unitType, "complete-slice");
+  clearGuidedUnitContext();
+});