gsd-pi 2.82.0-dev.ed17d078d → 3.0.0-dev.1b44e695b

package/packages/pi-coding-agent/dist/core/agent-session-thinking-level.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=agent-session-thinking-level.test.d.ts.map

package/packages/pi-coding-agent/dist/core/agent-session-thinking-level.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-session-thinking-level.test.d.ts","sourceRoot":"","sources":["../../src/core/agent-session-thinking-level.test.ts"],"names":[],"mappings":""}

package/packages/pi-coding-agent/dist/core/agent-session-thinking-level.test.js

@@ -0,0 +1,66 @@
+// Regression test for #5102: disabling thinking on one reasoning-capable
+// model must not silently persist "off" as the global default.
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, beforeEach, describe, it } from "node:test";
+import { Agent } from "@gsd/pi-agent-core";
+import { getModel } from "@gsd/pi-ai";
+import { AgentSession } from "./agent-session.js";
+import { AuthStorage } from "./auth-storage.js";
+import { ModelRegistry } from "./model-registry.js";
+import { DefaultResourceLoader } from "./resource-loader.js";
+import { SessionManager } from "./session-manager.js";
+import { SettingsManager } from "./settings-manager.js";
+let testDir;
+async function createSession() {
+    const agentDir = join(testDir, "agent-home");
+    const authStorage = AuthStorage.inMemory({});
+    const modelRegistry = new ModelRegistry(authStorage, join(agentDir, "models.json"));
+    const settingsManager = SettingsManager.inMemory({ defaultThinkingLevel: "high" });
+    const resourceLoader = new DefaultResourceLoader({
+        cwd: testDir,
+        agentDir,
+        settingsManager,
+        noExtensions: true,
+        noPromptTemplates: true,
+        noThemes: true,
+    });
+    await resourceLoader.reload();
+    const session = new AgentSession({
+        agent: new Agent({
+            initialState: {
+                model: getModel("zai", "glm-5.1"),
+                thinkingLevel: "high",
+            },
+        }),
+        sessionManager: SessionManager.inMemory(testDir),
+        settingsManager,
+        cwd: testDir,
+        resourceLoader,
+        modelRegistry,
+    });
+    return { session, settingsManager };
+}
+describe("AgentSession thinking level persistence", () => {
+    beforeEach(() => {
+        testDir = mkdtempSync(join(tmpdir(), "agent-session-thinking-level-"));
+    });
+    afterEach(() => {
+        rmSync(testDir, { recursive: true, force: true });
+    });
+    it("does not persist off as the global default for reasoning-capable models", async () => {
+        const { session, settingsManager } = await createSession();
+        session.setThinkingLevel("off");
+        assert.equal(session.thinkingLevel, "off");
+        assert.equal(settingsManager.getDefaultThinkingLevel(), "high");
+    });
+    it("still persists non-off thinking levels as the global default", async () => {
+        const { session, settingsManager } = await createSession();
+        session.setThinkingLevel("low");
+        assert.equal(session.thinkingLevel, "low");
+        assert.equal(settingsManager.getDefaultThinkingLevel(), "low");
+    });
+});
+//# sourceMappingURL=agent-session-thinking-level.test.js.map

package/packages/pi-coding-agent/dist/core/agent-session-thinking-level.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-session-thinking-level.test.js","sourceRoot":"","sources":["../../src/core/agent-session-thinking-level.test.ts"],"names":[],"mappings":"AAAA,yEAAyE;AACzE,+DAA+D;AAE/D,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AAC9C,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AACjC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AAEhE,OAAO,EAAE,KAAK,EAAE,MAAM,oBAAoB,CAAC;AAC3C,OAAO,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;AACtC,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAClD,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAChD,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,qBAAqB,EAAE,MAAM,sBAAsB,CAAC;AAC7D,OAAO,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AACtD,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAExD,IAAI,OAAe,CAAC;AAEpB,KAAK,UAAU,aAAa;IAC3B,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,EAAE,YAAY,CAAC,CAAC;IAC7C,MAAM,WAAW,GAAG,WAAW,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;IAC7C,MAAM,aAAa,GAAG,IAAI,aAAa,CAAC,WAAW,EAAE,IAAI,CAAC,QAAQ,EAAE,aAAa,CAAC,CAAC,CAAC;IACpF,MAAM,eAAe,GAAG,eAAe,CAAC,QAAQ,CAAC,EAAE,oBAAoB,EAAE,MAAM,EAAE,CAAC,CAAC;IACnF,MAAM,cAAc,GAAG,IAAI,qBAAqB,CAAC;QAChD,GAAG,EAAE,OAAO;QACZ,QAAQ;QACR,eAAe;QACf,YAAY,EAAE,IAAI;QAClB,iBAAiB,EAAE,IAAI;QACvB,QAAQ,EAAE,IAAI;KACd,CAAC,CAAC;IACH,MAAM,cAAc,CAAC,MAAM,EAAE,CAAC;IAE9B,MAAM,OAAO,GAAG,IAAI,YAAY,CAAC;QAChC,KAAK,EAAE,IAAI,KAAK,CAAC;YAChB,YAAY,EAAE;gBACb,KAAK,EAAE,QAAQ,CAAC,KAAK,EAAE,SAAgB,CAAC;gBACxC,aAAa,EAAE,MAAM;aACrB;SACD,CAAC;QACF,cAAc,EAAE,cAAc,CAAC,QAAQ,CAAC,OAAO,CAAC;QAChD,eAAe;QACf,GAAG,EAAE,OAAO;QACZ,cAAc;QACd,aAAa;KACb,CAAC,CAAC;IAEH,OAAO,EAAE,OAAO,EAAE,eAAe,EAAE,CAAC;AACrC,CAAC;AAED,QAAQ,CAAC,yCAAyC,EAAE,GAAG,EAAE;IACxD,UAAU,CAAC,GAAG,EAAE;QACf,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,+BAA+B,CAAC,CAAC,CAAC;IACxE,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACd,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yEAAyE,EAAE,KAAK,IAAI,EAAE;QACxF,MAAM,EAAE,OAAO,EAAE,eAAe,EAAE,GAAG,MAAM,aAAa,EAAE,CAAC;QAE3D,OAAO,CAAC,gBAAgB,CAAC,KAAK,CAAC,CAAC;QAEhC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,aAAa,EAAE,KAAK,CAAC,CAAC;QAC3C,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,uBAAuB,EAAE,EAAE,MAAM,CAAC,CAAC;IACjE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;QAC7E,MAAM,EAAE,OAAO,EAAE,eAAe,EAAE,GAAG,MAAM,aAAa,EAAE,CAAC;QAE3D,OAAO,CAAC,gBAAgB,CAAC,KAAK,CAAC,CAAC;QAEhC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,aAAa,EAAE,KAAK,CAAC,CAAC;QAC3C,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,uBAAuB,EAAE,EAAE,KAAK,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["// Regression test for #5102: disabling thinking on one reasoning-capable\n// model must not silently persist \"off\" as the global default.\n\nimport assert from \"node:assert/strict\";\nimport { mkdtempSync, rmSync } from \"node:fs\";\nimport { tmpdir } from \"node:os\";\nimport { join } from \"node:path\";\nimport { afterEach, beforeEach, describe, it } from \"node:test\";\n\nimport { Agent } from \"@gsd/pi-agent-core\";\nimport { getModel } from \"@gsd/pi-ai\";\nimport { AgentSession } from \"./agent-session.js\";\nimport { AuthStorage } from \"./auth-storage.js\";\nimport { ModelRegistry } from \"./model-registry.js\";\nimport { DefaultResourceLoader } from \"./resource-loader.js\";\nimport { SessionManager } from \"./session-manager.js\";\nimport { SettingsManager } from \"./settings-manager.js\";\n\nlet testDir: string;\n\nasync function createSession(): Promise<{ session: AgentSession; settingsManager: SettingsManager }> {\n\tconst agentDir = join(testDir, \"agent-home\");\n\tconst authStorage = AuthStorage.inMemory({});\n\tconst modelRegistry = new ModelRegistry(authStorage, join(agentDir, \"models.json\"));\n\tconst settingsManager = SettingsManager.inMemory({ defaultThinkingLevel: \"high\" });\n\tconst resourceLoader = new DefaultResourceLoader({\n\t\tcwd: testDir,\n\t\tagentDir,\n\t\tsettingsManager,\n\t\tnoExtensions: true,\n\t\tnoPromptTemplates: true,\n\t\tnoThemes: true,\n\t});\n\tawait resourceLoader.reload();\n\n\tconst session = new AgentSession({\n\t\tagent: new Agent({\n\t\t\tinitialState: {\n\t\t\t\tmodel: getModel(\"zai\", \"glm-5.1\" as any),\n\t\t\t\tthinkingLevel: \"high\",\n\t\t\t},\n\t\t}),\n\t\tsessionManager: SessionManager.inMemory(testDir),\n\t\tsettingsManager,\n\t\tcwd: testDir,\n\t\tresourceLoader,\n\t\tmodelRegistry,\n\t});\n\n\treturn { session, settingsManager };\n}\n\ndescribe(\"AgentSession thinking level persistence\", () => {\n\tbeforeEach(() => {\n\t\ttestDir = mkdtempSync(join(tmpdir(), \"agent-session-thinking-level-\"));\n\t});\n\n\tafterEach(() => {\n\t\trmSync(testDir, { recursive: true, force: true });\n\t});\n\n\tit(\"does not persist off as the global default for reasoning-capable models\", async () => {\n\t\tconst { session, settingsManager } = await createSession();\n\n\t\tsession.setThinkingLevel(\"off\");\n\n\t\tassert.equal(session.thinkingLevel, \"off\");\n\t\tassert.equal(settingsManager.getDefaultThinkingLevel(), \"high\");\n\t});\n\n\tit(\"still persists non-off thinking levels as the global default\", async () => {\n\t\tconst { session, settingsManager } = await createSession();\n\n\t\tsession.setThinkingLevel(\"low\");\n\n\t\tassert.equal(session.thinkingLevel, \"low\");\n\t\tassert.equal(settingsManager.getDefaultThinkingLevel(), \"low\");\n\t});\n});\n"]}

package/packages/pi-coding-agent/dist/core/agent-session.js

@@ -1522,7 +1522,7 @@ export class AgentSession {
         this.agent.setThinkingLevel(effectiveLevel);
         if (isChanging) {
             this.sessionManager.appendThinkingLevelChange(effectiveLevel);
-            if (this.supportsThinking() || effectiveLevel !== "off") {
+            if (effectiveLevel !== "off") {
                 this.settingsManager.setDefaultThinkingLevel(effectiveLevel);
             }
             this._emitSessionStateChanged("set_thinking_level");