gsd-pi 2.82.0-dev.3709f22a5 → 2.82.0-dev.57fd453e4

package/packages/pi-coding-agent/dist/core/chat-controller-ordering.test.js

@@ -1,3 +1,5 @@
+// Project/App: GSD-2
+// File Purpose: Regression tests for streamed interactive chat ordering.
 import assert from "node:assert/strict";
 import { test } from "node:test";
 import { handleAgentEvent } from "../modes/interactive/controllers/chat-controller.js";
@@ -91,9 +93,7 @@ function createHost() {
     };
     return host;
 }
-test("chat-controller renders content blocks in content[] index order (tool-first stream)", async () => {
-    // ToolExecutionComponent uses the global theme singleton.
-    // Install a minimal no-op theme implementation for this unit test.
+function installTheme() {
     globalThis[Symbol.for("@gsd/pi-coding-agent:theme")] = {
         fg: (_key, text) => text,
         bg: (_key, text) => text,
@@ -101,6 +101,11 @@ test("chat-controller renders content blocks in content[] index order (tool-firs
         italic: (text) => text,
         truncate: (text) => text,
     };
+}
+test("chat-controller renders content blocks in content[] index order (tool-first stream)", async () => {
+    // ToolExecutionComponent uses the global theme singleton.
+    // Install a minimal no-op theme implementation for this unit test.
+    installTheme();
     const host = createHost();
     const toolId = "mcp-tool-1";
     const toolCall = {
@@ -147,6 +152,42 @@ test("chat-controller renders content blocks in content[] index order (tool-firs
     assert.equal(host.chatContainer.children[0]?.constructor?.name, "ToolExecutionComponent");
     assert.equal(host.chatContainer.children[1]?.constructor?.name, "AssistantMessageComponent");
 });
+test("chat-controller skips empty GPT reasoning blocks before tool-only turns", async () => {
+    installTheme();
+    const host = createHost();
+    host.getMarkdownThemeWithSettings = () => ({});
+    const toolId = "gpt-tool-1";
+    const toolCall = {
+        type: "toolCall",
+        id: toolId,
+        name: "read",
+        arguments: { filePath: "todo.js" },
+    };
+    const content = [
+        { type: "thinking", thinking: "", thinkingSignature: "encrypted" },
+        toolCall,
+    ];
+    await handleAgentEvent(host, { type: "message_start", message: makeAssistant([]) });
+    await handleAgentEvent(host, {
+        type: "message_update",
+        message: makeAssistant(content),
+        assistantMessageEvent: {
+            type: "toolcall_end",
+            contentIndex: 1,
+            toolCall: {
+                ...toolCall,
+                externalResult: {
+                    content: [{ type: "text", text: "todo contents" }],
+                    details: {},
+                    isError: false,
+                },
+            },
+            partial: makeAssistant(content),
+        },
+    });
+    assert.equal(host.chatContainer.children.length, 1, "empty reasoning should not create a blank assistant block");
+    assert.equal(host.chatContainer.children[0]?.constructor?.name, "ToolExecutionComponent");
+});
 test("chat-controller renders serverToolUse before trailing text matching content[] index order", async () => {
     globalThis[Symbol.for("@gsd/pi-coding-agent:theme")] = {
         fg: (_key, text) => text,