gsd-pi 2.80.0-dev.8b3a59f5c → 2.80.0-dev.b2a374d5b

package/packages/pi-coding-agent/src/modes/interactive/components/tool-card-cleanup-and-success-runtime.test.ts

@@ -1,3 +1,4 @@
+// GSD2 TUI Tests - Runtime coverage for tool-card cleanup and success notification rendering.
 // Runtime regression tests for the post-compaction tool-card cleanup and the
 // green-bordered success-notification rendering. Replaces the source-grep
 // `src/tests/tui-running-and-success-box.test.ts` that was deleted in #4875
@@ -74,7 +75,7 @@ function makeMockTUI(): MockTui {
 // ─── Bug 1: tool cards stuck in "Running" after compaction ──────────────
 
 describe("ToolExecutionComponent post-compaction cleanup", () => {
-	it("renders 'Running' status while the tool call has no result", () => {
+	it("renders 'running' status while the tool call has no result", () => {
 		// Baseline: a freshly-constructed component (mid-stream) must show
 		// the running badge — this is the state we need to flip OUT of when
 		// compaction removes the result message.
@@ -88,12 +89,12 @@ describe("ToolExecutionComponent post-compaction cleanup", () => {
 		);
 		const rendered = c.render(60).map(stripAnsi).join("\n");
 		assert.ok(
-			rendered.includes("Running"),
-			"freshly constructed component should render 'Running' badge",
+			rendered.includes("running"),
+			"freshly constructed component should render 'running' badge",
 		);
 	});
 
-	it("markHistoricalNoResult flips a stuck tool card OUT of 'Running'", () => {
+	it("markHistoricalNoResult flips a stuck tool card OUT of 'running'", () => {
 		// Real bug: after session-history replay (post-compaction or session
 		// switch), tool calls without matching tool_result messages stay in
 		// isPartial = true forever. markHistoricalNoResult must produce a
@@ -111,13 +112,13 @@ describe("ToolExecutionComponent post-compaction cleanup", () => {
 
 		const rendered = c.render(60).map(stripAnsi).join("\n");
 		assert.ok(
-			!rendered.includes("Running"),
-			"after markHistoricalNoResult, the tool card must NOT render 'Running' — got:\n" +
+			!rendered.includes("running"),
+			"after markHistoricalNoResult, the tool card must NOT render 'running' -- got:\n" +
 				rendered,
 		);
 		assert.ok(
-			rendered.includes("Done"),
-			"flipped card should render 'Done' status (no-result success)",
+			rendered.includes("success"),
+			"flipped card should render 'success' status (no-result success)",
 		);
 	});
 
@@ -145,7 +146,7 @@ describe("ToolExecutionComponent post-compaction cleanup", () => {
 		);
 
 		const before = c.render(60).map(stripAnsi).join("\n");
-		assert.ok(before.includes("Done"), "after complete(), card shows 'Done'");
+		assert.ok(before.includes("success"), "after complete(), card shows 'success'");
 
 		c.markHistoricalNoResult(); // must early-return
 		const after = c.render(60).map(stripAnsi).join("\n");

package/packages/pi-coding-agent/src/modes/interactive/components/tool-execution.ts

@@ -107,9 +107,9 @@ function renderToolFrame(
 
 	const borderColor = opts.tone === "error" ? "toolError" : opts.tone === "pending" ? "toolRunning" : "toolSuccess";
 	const topColor = borderColor;
-	const labelColor = opts.tone === "error" ? "toolError" : "surfaceTitle";
+	const labelColor = opts.tone === "error" ? "toolError" : opts.tone === "pending" ? "toolRunning" : "toolSuccess";
 	const statusColor = opts.tone === "error" ? "toolError" : opts.tone === "pending" ? "toolRunning" : "toolSuccess";
-	const leftStyled = theme.fg(labelColor, theme.bold(`• ${opts.label}`));
+	const leftStyled = theme.fg(labelColor, theme.bold(opts.label));
 	const rightStyled = theme.fg(statusColor, opts.status);
 	const gap = Math.max(1, outerWidth - visibleWidth(leftStyled) - visibleWidth(rightStyled));
 	const headerRow = `${leftStyled}${" ".repeat(gap)}${rightStyled}`;
@@ -128,6 +128,27 @@ function renderToolFrame(
 		.render(bodyLines, outerWidth);
 }
 
+function renderCollapsedToolRow(
+	label: string,
+	status: string,
+	width: number,
+	tone: Extract<ToolFrameTone, "success">,
+): string[] {
+	const outerWidth = Math.max(20, width);
+	const contentWidth = Math.max(1, outerWidth - 2);
+	const statusColor = tone === "success" ? "toolSuccess" : "toolMuted";
+	const labelStyled = theme.fg(statusColor, label);
+	const statusStyled = theme.fg(statusColor, status);
+	const labelWidth = Math.max(1, contentWidth - visibleWidth(statusStyled) - 1);
+	const clippedLabel = truncateToWidth(labelStyled, labelWidth, "");
+	const gap = Math.max(1, contentWidth - visibleWidth(clippedLabel) - visibleWidth(statusStyled));
+	const line = `${clippedLabel}${" ".repeat(gap)}${statusStyled}`;
+	return style()
+		.border("minimal")
+		.borderColor((text) => theme.fg(statusColor, text))
+		.render([line], outerWidth);
+}
+
 const COMPACT_ARG_VALUE_LIMIT = 60;
 const GENERIC_OUTPUT_PREVIEW_LINES = 10;
 const GENERIC_ARGS_JSON_PREVIEW_LINES = 10;
@@ -559,18 +580,13 @@ export class ToolExecutionComponent extends Container {
 		const frameTone: ToolFrameTone =
 			this.result?.isError ? "error" : this.isPartial || !this.result ? "pending" : "success";
 		const elapsed = formatElapsed((this.endedAt ?? Date.now()) - this.startedAt);
-		const frameStatus = `${this.isPartial || !this.result ? "Running" : this.result.isError ? "Error" : "Done"} · ${elapsed}`;
+		const frameStatus = `${this.isPartial || !this.result ? "running" : this.result.isError ? "failed" : "success"} · ${elapsed}`;
 		const parsed = parseMcpToolName(this.toolName);
 		const frameLabel = parsed
-			? `Tool ${parsed.server}·${parsed.tool}`
-			: `Tool ${prettifyToolName(this.toolName, this.toolDefinition?.label) || "unknown"}`;
+			? `${parsed.server}·${parsed.tool}`
+			: prettifyToolName(this.toolName, this.toolDefinition?.label) || "unknown";
 		if (this.shouldRenderCompactSuccess()) {
-			const availableWidth = Math.max(1, frameWidth - 2);
-			const summaryWidth = Math.max(1, availableWidth - visibleWidth(frameStatus) - 1);
-			const summary = truncateToWidth(this.getCompactSummary(frameLabel), summaryWidth, "");
-			const gap = Math.max(1, availableWidth - visibleWidth(summary) - visibleWidth(frameStatus));
-			const line = `${theme.fg("toolSuccess", summary)}${" ".repeat(gap)}${theme.fg("toolSuccess", frameStatus)}`;
-			return ["", ...style().border("minimal").borderColor((text) => theme.fg("toolSuccess", text)).render([line], frameWidth)];
+			return ["", ...renderCollapsedToolRow(this.getCompactSummary(frameLabel), frameStatus, frameWidth, "success")];
 		}
 		const lines = super.render(contentWidth);
 		const framed = renderToolFrame(lines, frameWidth, {
@@ -584,7 +600,7 @@ export class ToolExecutionComponent extends Container {
 	private shouldRenderCompactSuccess(): boolean {
 		if (this.expanded || this.isPartial || !this.result || this.result.isError) return false;
 		const hasImages = this.result.content?.some((block) => block.type === "image") ?? false;
-		return !hasImages && this.getTextOutput().trim().length === 0;
+		return !hasImages;
 	}
 
 	getRollupPhase(): ToolExecutionPhase | null {
@@ -615,7 +631,7 @@ export class ToolExecutionComponent extends Container {
 	}
 
 	private getCompactSummary(frameLabel: string): string {
-		return `${frameLabel} Completed`;
+		return frameLabel;
 	}
 
 	private updateDisplay(): void {
@@ -1271,6 +1287,10 @@ export class ToolPhaseSummaryComponent extends Container {
 		super();
 	}
 
+	getPhases(): ToolExecutionPhase[] {
+		return this.phases.map((phase) => ({ ...phase }));
+	}
+
 	override render(width: number): string[] {
 		const frameWidth = Math.max(20, width);
 		const rows = this.phases.map((phase) => {

package/packages/pi-coding-agent/src/modes/interactive/controllers/chat-controller.test.ts

@@ -1,5 +1,7 @@
 import assert from "node:assert/strict";
 import test from "node:test";
+import { Container } from "@gsd/pi-tui";
+import stripAnsi from "strip-ansi";
 
 import { findLatestPinnableText, handleAgentEvent } from "./chat-controller.js";
 import { initTheme } from "../theme/theme.js";
@@ -111,3 +113,57 @@ test("handleAgentEvent: agent_start clears stale adaptive blocking error", async
 	assert.equal(cleared, true);
 	assert.equal(requestedRender, true);
 });
+
+test("handleAgentEvent: standalone completed tool events roll up incrementally", async () => {
+	initTheme("dark", false);
+	const chatContainer = new Container();
+	let renderCount = 0;
+	const host = {
+		isInitialized: true,
+		footer: { invalidate() {} },
+		settingsManager: {
+			getTimestampFormat() {
+				return "date-time-iso";
+			},
+			getShowImages() {
+				return false;
+			},
+		},
+		getRegisteredToolDefinition() {
+			return undefined;
+		},
+		chatContainer,
+		pendingTools: new Map(),
+		ui: {
+			requestRender() {
+				renderCount++;
+			},
+		},
+	} as any;
+
+	for (const [toolCallId, toolName] of [
+		["read-1", "read"],
+		["read-2", "read"],
+		["edit-1", "edit"],
+	] as const) {
+		await handleAgentEvent(host, {
+			type: "tool_execution_start",
+			toolCallId,
+			toolName,
+			args: { path: `/tmp/${toolCallId}.txt` },
+		} as any);
+		await handleAgentEvent(host, {
+			type: "tool_execution_end",
+			toolCallId,
+			toolName,
+			result: { content: [], isError: false },
+			isError: false,
+		} as any);
+	}
+
+	const rendered = stripAnsi(chatContainer.render(100).join("\n"));
+	assert.match(rendered, /Context reads 2 actions\s+success · \d+(ms|s)/);
+	assert.match(rendered, /File changes 1 action\s+success · \d+(ms|s)/);
+	assert.doesNotMatch(rendered, /\bread\s+success ·/);
+	assert.ok(renderCount > 0);
+});

package/packages/pi-coding-agent/src/modes/interactive/controllers/chat-controller.ts

@@ -28,7 +28,8 @@ type RenderedSegment =
 		contentType: "text" | "thinking";
 		component: AssistantMessageComponent;
 	}
-	| { kind: "tool"; contentIndex: number; component: ToolExecutionComponent };
+	| { kind: "tool"; contentIndex: number; component: ToolExecutionComponent }
+	| { kind: "tool-summary"; component: ToolPhaseSummaryComponent; phases: ToolExecutionPhase[] };
 
 let renderedSegments: RenderedSegment[] = [];
 // When providers reuse one assistant lifecycle across internal sub-turns,
@@ -124,17 +125,25 @@ function replaceCompactToolRowsWithPhaseSummary(
 ): void {
 	let changed = false;
 	const nextRenderedSegments: RenderedSegment[] = [];
-	let rollupRun: Array<{ seg: Extract<RenderedSegment, { kind: "tool" }>; phase: ToolExecutionPhase }> = [];
+	let rollupRun: Array<{
+		seg: Extract<RenderedSegment, { kind: "tool" | "tool-summary" }>;
+		phases: ToolExecutionPhase[];
+	}> = [];
 
 	const flushRollupRun = () => {
-		if (rollupRun.length < 2) {
+		const actionCount = rollupRun.reduce(
+			(total, item) => total + item.phases.reduce((sum, phase) => sum + phase.count, 0),
+			0,
+		);
+		if (actionCount < 2) {
 			nextRenderedSegments.push(...rollupRun.map((item) => item.seg));
 			rollupRun = [];
 			return;
 		}
 
 		const firstIndex = Math.max(0, host.chatContainer.children.indexOf(rollupRun[0].seg.component));
-		const summary = new ToolPhaseSummaryComponent(mergeToolPhases(rollupRun.map((item) => item.phase)));
+		const phases = mergeToolPhases(rollupRun.flatMap((item) => item.phases));
+		const summary = new ToolPhaseSummaryComponent(phases);
 
 		for (const { seg } of rollupRun) {
 			host.chatContainer.removeChild(seg.component);
@@ -149,13 +158,18 @@ function replaceCompactToolRowsWithPhaseSummary(
 		}
 
 		changed = true;
+		nextRenderedSegments.push({ kind: "tool-summary", component: summary, phases });
 		rollupRun = [];
 	};
 
 	for (const seg of renderedSegments) {
 		const phase = seg.kind === "tool" ? seg.component.getRollupPhase() : null;
 		if (seg.kind === "tool" && phase) {
-			rollupRun.push({ seg, phase });
+			rollupRun.push({ seg, phases: [phase] });
+			continue;
+		}
+		if (seg.kind === "tool-summary") {
+			rollupRun.push({ seg, phases: seg.component.getPhases() });
 			continue;
 		}
 
@@ -409,6 +423,7 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
 							details: externalToolResult.details,
 							isError: externalToolResult.isError,
 						});
+						replaceCompactToolRowsWithPhaseSummary(host);
 					}
 				}
 
@@ -843,7 +858,6 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
 					host.streamingComponent.setShowMetadata(true);
 					host.streamingComponent.updateContent(host.streamingMessage);
 				}
-				replaceCompactToolRowsWithPhaseSummary(host);
 
 				if (host.streamingMessage.stopReason === "aborted" || host.streamingMessage.stopReason === "error") {
 					if (!errorMessage) {
@@ -862,6 +876,7 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
 					for (const [, component] of host.pendingTools.entries()) {
 						component.setArgsComplete();
 					}
+					replaceCompactToolRowsWithPhaseSummary(host);
 				}
 				host.streamingComponent = undefined;
 				host.streamingMessage = undefined;
@@ -894,6 +909,7 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
 				component.setExpanded(host.toolOutputExpanded);
 				host.chatContainer.addChild(component);
 				host.pendingTools.set(event.toolCallId, component);
+				renderedSegments.push({ kind: "tool", contentIndex: Number.MAX_SAFE_INTEGER, component });
 				host.ui.requestRender();
 			}
 			break;
@@ -911,7 +927,7 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
 			const component = host.pendingTools.get(event.toolCallId);
 			if (component) {
 				component.updateResult({ ...event.result, isError: event.isError });
-				host.pendingTools.delete(event.toolCallId);
+				replaceCompactToolRowsWithPhaseSummary(host);
 				host.ui.requestRender();
 			}
 			break;
@@ -927,6 +943,7 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
 				host.streamingComponent.setShowMetadata(true);
 				host.streamingComponent.updateContent(host.streamingMessage);
 			}
+			replaceCompactToolRowsWithPhaseSummary(host);
 			host.streamingComponent = undefined;
 			host.streamingMessage = undefined;
 			renderedSegments = [];

package/packages/pi-coding-agent/src/modes/interactive/interactive-mode.ts

@@ -1378,6 +1378,9 @@ export class InteractiveMode {
 				})();
 			},
 			getSystemPrompt: () => this.session.systemPrompt,
+			setCompactionThresholdOverride: (percent) => {
+				this.session.settingsManager.setCompactionThresholdOverride(percent);
+			},
 		});
 
 		// Set up the extension shortcut handler on the default editor

package/packages/pi-coding-agent/src/modes/interactive/theme/themes.ts

@@ -1,3 +1,4 @@
+// GSD2 TUI - Built-in terminal theme definitions.
 /**
  * Built-in theme definitions.
  *
@@ -18,27 +19,30 @@ import type { ThemeJson } from "./theme-schema.js";
 const dark: ThemeJson = {
 	name: "dark",
 	vars: {
-		cyan: "#22d3ee",
-		blue: "#60a5fa",
-		green: "#34d399",
-		red: "#fb7185",
-		yellow: "#facc15",
-		gray: "#a1a1aa",
-		dimGray: "#8b93a7",
-		darkGray: "#4b5563",
-		accent: "#2dd4bf",
-		selectedBg: "#1f2a44",
-		userMsgBg: "#1e2535",
-		toolPendingBg: "#1f2330",
-		toolSuccessBg: "#1f3128",
-		toolErrorBg: "#3a202a",
-		customMsgBg: "#2a2140",
+		cyan: "#5cc8c8",
+		blue: "#79b8ff",
+		green: "#7ad38b",
+		red: "#f27b7b",
+		yellow: "#d6b85f",
+		gray: "#87949b",
+		dimGray: "#657178",
+		darkGray: "#303a40",
+		line: "#52616a",
+		lineSoft: "#303a40",
+		textSoft: "#cbd6dc",
+		accent: "#5cc8c8",
+		selectedBg: "#1d282a",
+		userMsgBg: "#202a2f",
+		toolPendingBg: "#252721",
+		toolSuccessBg: "#1c251f",
+		toolErrorBg: "#251e20",
+		customMsgBg: "#202a2f",
 	},
 	colors: {
 		accent: "accent",
-		border: "blue",
-		borderAccent: "cyan",
-		borderMuted: "darkGray",
+		border: "line",
+		borderAccent: "accent",
+		borderMuted: "lineSoft",
 		success: "green",
 		error: "red",
 		warning: "yellow",
@@ -49,16 +53,21 @@ const dark: ThemeJson = {
 
 		selectedBg: "selectedBg",
 		userMessageBg: "userMsgBg",
-		userMessageText: "gray",
-		assistantMessageText: "",
+		userMessageText: "textSoft",
+		assistantMessageText: "textSoft",
 		customMessageBg: "customMsgBg",
-		customMessageText: "",
-		customMessageLabel: "#c084fc",
+		customMessageText: "textSoft",
+		customMessageLabel: "blue",
 		toolPendingBg: "toolPendingBg",
 		toolSuccessBg: "toolSuccessBg",
 		toolErrorBg: "toolErrorBg",
-		toolTitle: "#8a8a8a",
-		toolOutput: "#6e6e6e",
+		toolTitle: "gray",
+		toolOutput: "textSoft",
+		surfaceTitle: "accent",
+		surfaceAccent: "accent",
+		toolRunning: "yellow",
+		toolSuccess: "green",
+		toolError: "red",
 
 		mdHeading: "#fbbf24",
 		mdLink: "#93c5fd",
@@ -95,9 +104,9 @@ const dark: ThemeJson = {
 		bashMode: "green",
 	},
 	export: {
-		pageBg: "#101522",
-		cardBg: "#171f33",
-		infoBg: "#3b321d",
+		pageBg: "#111416",
+		cardBg: "#1e2529",
+		infoBg: "#252721",
 	},
 };
 

package/packages/pi-coding-agent/src/modes/interactive/tui-mode.test.ts

@@ -2,9 +2,14 @@
 
 import assert from "node:assert/strict";
 import { describe, test } from "node:test";
+import stripAnsi from "strip-ansi";
 
+import { AdaptiveLayoutComponent } from "./components/adaptive-layout.js";
+import { initTheme } from "./theme/theme.js";
 import { resolveTuiMode } from "./tui-mode.js";
 
+initTheme("dark", false);
+
 describe("resolveTuiMode", () => {
 	test("explicit overrides beat auto selection", () => {
 		assert.equal(
@@ -38,3 +43,23 @@ describe("resolveTuiMode", () => {
 		assert.equal(resolveTuiMode({ terminalWidth: 100 }), "chat");
 	});
 });
+
+describe("AdaptiveLayoutComponent", () => {
+	test("renders workflow layout with prototype rule frames", () => {
+		const layout = new AdaptiveLayoutComponent(() => ({
+			override: "workflow",
+			activeToolCount: 2,
+			gsdPhase: "execute-task",
+			sessionName: "main",
+			cwd: "/Users/example/project",
+		}));
+
+		const plain = layout.render(120).map(stripAnsi);
+
+		assert.match(plain[0], /^─+/, "workflow layout should start with a rule frame");
+		assert.ok(plain.some((line) => line.includes("GSD Command Center")), "workflow title should render");
+		assert.ok(plain.some((line) => line.includes("signals")), "inspector title should render");
+		assert.ok(plain.some((line) => line.includes("│ Active")), "body rows should keep prototype gutter");
+		assert.ok(!plain.some((line) => /[╭╮╰╯]/.test(line)), "workflow layout should not use rounded box corners");
+	});
+});

package/packages/pi-coding-agent/src/resources/extensions/memory/storage-safety-guard.test.ts

@@ -0,0 +1,14 @@
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+import test from "node:test";
+
+test("MemoryStorage persists sql.js snapshots through the atomic DB snapshot writer", () => {
+	const src = readFileSync(
+		join(process.cwd(), "packages", "pi-coding-agent", "src", "resources", "extensions", "memory", "storage.ts"),
+		"utf-8",
+	);
+
+	assert.match(src, /atomicWriteDbSnapshotSync\(/, "storage must use atomic DB snapshot writes");
+	assert.doesNotMatch(src, /writeFileSync\(this\.dbPath/, "direct live DB overwrite is forbidden");
+});

package/packages/pi-coding-agent/src/resources/extensions/memory/storage.ts

@@ -9,8 +9,9 @@
 
 import initSqlJs, { type Database as SqlJsDatabase } from "sql.js";
 import { randomUUID } from "crypto";
-import { existsSync, mkdirSync, readFileSync, writeFileSync } from "fs";
+import { existsSync, mkdirSync, readFileSync } from "fs";
 import { dirname } from "path";
+import { atomicWriteDbSnapshotSync } from "../../../core/db-snapshot.js";
 
 export interface ThreadRow {
 	thread_id: string;
@@ -74,7 +75,7 @@ export class MemoryStorage {
 
 	private persist(): void {
 		const data = this.db.export();
-		writeFileSync(this.dbPath, Buffer.from(data));
+		atomicWriteDbSnapshotSync(this.dbPath, data);
 	}
 
 	private schedulePersist(): void {