gsd-pi 2.8.2 → 2.9.0

package/packages/pi-coding-agent/src/core/tools/index.ts

@@ -65,6 +65,13 @@ export {
 	type WriteToolOptions,
 	writeTool,
 } from "./write.js";
+export {
+	createLspTool,
+	type LspToolDetails,
+	lspSchema,
+	lspTool,
+} from "../lsp/index.js";
+export type { LspServerStatus } from "../lsp/client.js";
 
 import type { AgentTool } from "@gsd/pi-agent-core";
 import { type BashToolOptions, bashTool, createBashTool } from "./bash.js";
@@ -74,6 +81,7 @@ import { createGrepTool, grepTool } from "./grep.js";
 import { createLsTool, lsTool } from "./ls.js";
 import { createReadTool, type ReadToolOptions, readTool } from "./read.js";
 import { createWriteTool, writeTool } from "./write.js";
+import { createLspTool, lspTool } from "../lsp/index.js";
 
 /** Tool type (AgentTool from pi-ai) */
 export type Tool = AgentTool<any>;
@@ -93,6 +101,7 @@ export const allTools = {
 	grep: grepTool,
 	find: findTool,
 	ls: lsTool,
+	lsp: lspTool,
 };
 
 export type ToolName = keyof typeof allTools;
@@ -135,5 +144,6 @@ export function createAllTools(cwd: string, options?: ToolsOptions): Record<Tool
 		grep: createGrepTool(cwd),
 		find: createFindTool(cwd),
 		ls: createLsTool(cwd),
+		lsp: createLspTool(cwd),
 	};
 }

package/packages/pi-coding-agent/src/modes/interactive/components/settings-selector.ts

@@ -13,7 +13,7 @@ import {
 import { getSelectListTheme, getSettingsListTheme, theme } from "../theme/theme.js";
 import { DynamicBorder } from "./dynamic-border.js";
 
-const THINKING_DESCRIPTIONS: Record<ThinkingLevel, string> = {
+export const THINKING_DESCRIPTIONS: Record<ThinkingLevel, string> = {
 	off: "No reasoning",
 	minimal: "Very brief reasoning (~1k tokens)",
 	low: "Light reasoning (~2k tokens)",
@@ -73,7 +73,7 @@ export interface SettingsCallbacks {
 /**
  * A submenu component for selecting from a list of options.
  */
-class SelectSubmenu extends Container {
+export class SelectSubmenu extends Container {
 	private selectList: SelectList;
 
 	constructor(

package/packages/pi-coding-agent/src/modes/interactive/interactive-mode.ts

@@ -7,7 +7,7 @@ import * as crypto from "node:crypto";
 import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
-import type { AgentMessage } from "@gsd/pi-agent-core";
+import type { AgentMessage, ThinkingLevel } from "@gsd/pi-agent-core";
 import type { AssistantMessage, ImageContent, Message, Model, OAuthProviderId } from "@gsd/pi-ai";
 import type {
 	AutocompleteItem,
@@ -85,7 +85,7 @@ import { ModelSelectorComponent } from "./components/model-selector.js";
 import { OAuthSelectorComponent } from "./components/oauth-selector.js";
 import { ScopedModelsSelectorComponent } from "./components/scoped-models-selector.js";
 import { SessionSelectorComponent } from "./components/session-selector.js";
-import { SettingsSelectorComponent } from "./components/settings-selector.js";
+import { SelectSubmenu, SettingsSelectorComponent, THINKING_DESCRIPTIONS } from "./components/settings-selector.js";
 import { SkillInvocationMessageComponent } from "./components/skill-invocation-message.js";
 import { ToolExecutionComponent } from "./components/tool-execution.js";
 import { TreeSelectorComponent } from "./components/tree-selector.js";
@@ -2015,6 +2015,12 @@ export class InteractiveMode {
 				await this.handleReloadCommand();
 				return;
 			}
+			if (text === "/thinking" || text.startsWith("/thinking ")) {
+				const arg = text.startsWith("/thinking ") ? text.slice(10).trim() : undefined;
+				this.editor.setText("");
+				this.handleThinkingCommand(arg);
+				return;
+			}
 			if (text === "/debug") {
 				this.handleDebugCommand();
 				this.editor.setText("");
@@ -2745,6 +2751,57 @@ export class InteractiveMode {
 		}
 	}
 
+	private handleThinkingCommand(arg?: string): void {
+		if (!this.session.supportsThinking()) {
+			this.showStatus("Current model does not support thinking");
+			return;
+		}
+
+		const availableLevels = this.session.getAvailableThinkingLevels();
+
+		if (arg) {
+			const level = arg.toLowerCase();
+			if (!availableLevels.includes(level as ThinkingLevel)) {
+				this.showStatus(`Invalid thinking level "${arg}". Available: ${availableLevels.join(", ")}`);
+				return;
+			}
+			this.session.setThinkingLevel(level as ThinkingLevel);
+			this.footer.invalidate();
+			this.updateEditorBorderColor();
+			this.showStatus(`Thinking level: ${level}`);
+			return;
+		}
+
+		this.showThinkingSelector();
+	}
+
+	private showThinkingSelector(): void {
+		const availableLevels = this.session.getAvailableThinkingLevels();
+		this.showSelector((done) => {
+			const selector = new SelectSubmenu(
+				"Thinking Level",
+				"Select reasoning depth for thinking-capable models",
+				availableLevels.map((level) => ({
+					value: level,
+					label: level,
+					description: THINKING_DESCRIPTIONS[level],
+				})),
+				this.session.thinkingLevel,
+				(value) => {
+					this.session.setThinkingLevel(value as ThinkingLevel);
+					this.footer.invalidate();
+					this.updateEditorBorderColor();
+					done();
+					this.showStatus(`Thinking level: ${value}`);
+				},
+				() => {
+					done();
+				},
+			);
+			return { component: selector, focus: selector };
+		});
+	}
+
 	private async cycleModel(direction: "forward" | "backward"): Promise<void> {
 		try {
 			const result = await this.session.cycleModel(direction);
@@ -3695,6 +3752,21 @@ export class InteractiveMode {
 							this.session.modelRegistry.authStorage.logout(providerId);
 							this.session.modelRegistry.refresh();
 							await this.updateAvailableProviderCount();
+
+							// Auto-switch model if current model belongs to the logged-out provider
+							const currentModel = this.session.model;
+							if (currentModel?.provider === providerId) {
+								try {
+									const available = this.session.modelRegistry.getAvailable();
+									const fallback = available.find((m) => m.provider !== providerId);
+									if (fallback) {
+										await this.session.setModel(fallback);
+									}
+								} catch {
+									// Model switch failed — user can manually switch via /model
+								}
+							}
+
 							this.showStatus(`Logged out of ${providerName}`);
 						} catch (error: unknown) {
 							this.showError(`Logout failed: ${error instanceof Error ? error.message : String(error)}`);
@@ -3789,6 +3861,26 @@ export class InteractiveMode {
 			restoreEditor();
 			this.session.modelRegistry.refresh();
 			await this.updateAvailableProviderCount();
+
+			// Auto-switch model if current model has no valid API key
+			try {
+				const currentModel = this.session.model;
+				if (currentModel) {
+					const currentKey = await this.session.modelRegistry.getApiKey(currentModel);
+					if (!currentKey) {
+						const available = this.session.modelRegistry.getAvailable();
+						const newProviderModel = available.find((m) => m.provider === providerId);
+						if (newProviderModel) {
+							await this.session.setModel(newProviderModel);
+						} else if (available.length > 0) {
+							await this.session.setModel(available[0]);
+						}
+					}
+				}
+			} catch (error: unknown) {
+				// Model switch failed — user can manually switch via /model
+			}
+
 			this.showStatus(`Logged in to ${providerName}. Credentials saved to ${getAuthPath()}`);
 		} catch (error: unknown) {
 			restoreEditor();

package/packages/pi-coding-agent/src/modes/rpc/rpc-mode.ts

@@ -119,8 +119,8 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 	 */
 	const createExtensionUIContext = (): ExtensionUIContext => ({
 		select: (title, options, opts) =>
-			createDialogPromise(opts, undefined, { method: "select", title, options, timeout: opts?.timeout }, (r) =>
-				"cancelled" in r && r.cancelled ? undefined : "value" in r ? r.value : undefined,
+			createDialogPromise(opts, undefined, { method: "select", title, options, timeout: opts?.timeout, allowMultiple: opts?.allowMultiple }, (r) =>
+				"cancelled" in r && r.cancelled ? undefined : "values" in r ? r.values : "value" in r ? r.value : undefined,
 			),
 
 		confirm: (title, message, opts) =>

package/packages/pi-coding-agent/src/modes/rpc/rpc-types.ts

@@ -210,7 +210,7 @@ export type RpcResponse =
 
 /** Emitted when an extension needs user input */
 export type RpcExtensionUIRequest =
-	| { type: "extension_ui_request"; id: string; method: "select"; title: string; options: string[]; timeout?: number }
+	| { type: "extension_ui_request"; id: string; method: "select"; title: string; options: string[]; timeout?: number; allowMultiple?: boolean }
 	| { type: "extension_ui_request"; id: string; method: "confirm"; title: string; message: string; timeout?: number }
 	| {
 			type: "extension_ui_request";
@@ -253,6 +253,7 @@ export type RpcExtensionUIRequest =
 /** Response to an extension UI request */
 export type RpcExtensionUIResponse =
 	| { type: "extension_ui_response"; id: string; value: string }
+	| { type: "extension_ui_response"; id: string; values: string[] }
 	| { type: "extension_ui_response"; id: string; confirmed: boolean }
 	| { type: "extension_ui_response"; id: string; cancelled: true };
 

package/src/resources/extensions/ask-user-questions.ts

@@ -137,12 +137,52 @@ export default function AskUserQuestions(pi: ExtensionAPI) {
 			if (!ctx.hasUI) {
 				const { tryRemoteQuestions } = await import("./remote-questions/manager.js");
 				const remoteResult = await tryRemoteQuestions(params.questions, signal);
-				if (remoteResult) return remoteResult;
+				if (remoteResult) return { ...remoteResult, details: remoteResult.details as unknown };
 				return errorResult("Error: UI not available (non-interactive mode)", params.questions);
 			}
 
 			// Delegate to shared interview UI
-			const result = await showInterviewRound(params.questions, {}, ctx);
+			const result = await showInterviewRound(params.questions, {}, ctx as any);
+
+			// RPC mode fallback: custom() returns undefined, so showInterviewRound
+			// may return undefined. Fall back to sequential ctx.ui.select() calls.
+			if (!result) {
+				const answers: Record<string, { answers: string[] }> = {};
+				for (const q of params.questions) {
+					const options = q.options.map((o) => o.label);
+					if (!q.allowMultiple) {
+						options.push(OTHER_OPTION_LABEL);
+					}
+					const selected = await ctx.ui.select(
+						`${q.header}: ${q.question}`,
+						options,
+						{ signal, ...(q.allowMultiple ? { allowMultiple: true } : {}) },
+					);
+					if (selected === undefined) {
+						return errorResult("ask_user_questions was cancelled", params.questions);
+					}
+					answers[q.id] = {
+						answers: Array.isArray(selected) ? selected : [selected],
+					};
+				}
+				const roundResult: RoundResult = {
+					endInterview: false,
+					answers: Object.fromEntries(
+						Object.entries(answers).map(([id, a]) => [
+							id,
+							{ selected: a.answers.length === 1 ? a.answers[0] : a.answers, notes: "" },
+						]),
+					),
+				};
+				return {
+					content: [{ type: "text" as const, text: JSON.stringify({ answers }) }],
+					details: {
+						questions: params.questions,
+						response: roundResult,
+						cancelled: false,
+					} satisfies LocalResultDetails,
+				};
+			}
 
 			// Check if cancelled (empty answers = user exited)
 			const hasAnswers = Object.keys(result.answers).length > 0;

package/src/resources/extensions/bg-shell/index.ts

@@ -1261,7 +1261,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.command) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'command' is required for start" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1316,7 +1316,7 @@ export default function (pi: ExtensionAPI) {
 						if (!bg) {
 							return {
 								content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-								isError: true,
+								isError: true, details: undefined as unknown,
 							};
 						}
 						const digest = generateDigest(bg, true);
@@ -1356,7 +1356,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for highlights" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1364,7 +1364,7 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1388,7 +1388,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for output" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1396,7 +1396,7 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1429,7 +1429,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for wait_for_ready" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1437,7 +1437,7 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1472,13 +1472,13 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for send" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 					if (params.input === undefined) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'input' is required for send" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1486,14 +1486,14 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
 					if (!bg.alive) {
 						return {
 							content: [{ type: "text" as const, text: `Error: Process ${params.id} has already exited` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1506,7 +1506,7 @@ export default function (pi: ExtensionAPI) {
 					} catch (err) {
 						return {
 							content: [{ type: "text" as const, text: `Error writing to stdin: ${err instanceof Error ? err.message : String(err)}` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 				}
@@ -1516,19 +1516,19 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for send_and_wait" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 					if (params.input === undefined) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'input' is required for send_and_wait" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 					if (!params.wait_pattern) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'wait_pattern' is required for send_and_wait" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1536,14 +1536,14 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
 					if (!bg.alive) {
 						return {
 							content: [{ type: "text" as const, text: `Error: Process ${params.id} has already exited` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1568,7 +1568,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for signal" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1576,7 +1576,7 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1621,7 +1621,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for kill" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1629,7 +1629,7 @@ export default function (pi: ExtensionAPI) {
 					if (!bg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1657,7 +1657,7 @@ export default function (pi: ExtensionAPI) {
 					if (!params.id) {
 						return {
 							content: [{ type: "text" as const, text: "Error: 'id' is required for restart" }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1665,7 +1665,7 @@ export default function (pi: ExtensionAPI) {
 					if (!newBg) {
 						return {
 							content: [{ type: "text" as const, text: `Error: No process found with id '${params.id}'` }],
-							isError: true,
+							isError: true, details: undefined as unknown,
 						};
 					}
 
@@ -1732,7 +1732,7 @@ export default function (pi: ExtensionAPI) {
 				default:
 					return {
 						content: [{ type: "text" as const, text: `Unknown action: ${params.action}` }],
-						isError: true,
+						isError: true, details: undefined as unknown,
 					};
 			}
 		},
@@ -1760,7 +1760,7 @@ export default function (pi: ExtensionAPI) {
 
 			const action = details.action as string;
 
-			if (result.isError) {
+			if ((result as any).isError) {
 				const text = result.content[0];
 				return new Text(
 					theme.fg("error", text?.type === "text" ? text.text : "Error"),
@@ -2338,17 +2338,14 @@ export default function (pi: ExtensionAPI) {
 	}, 2000);
 
 	// Refresh widget after agent actions and session events
-	for (const event of [
-		"turn_end",
-		"agent_end",
-		"session_start",
-		"session_switch",
-	] as const) {
-		pi.on(event, async (_event: unknown, ctx: ExtensionContext) => {
-			latestCtx = ctx;
-			refreshWidget();
-		});
-	}
+	const refreshHandler = async (_event: unknown, ctx: ExtensionContext) => {
+		latestCtx = ctx;
+		refreshWidget();
+	};
+	pi.on("turn_end", refreshHandler as any);
+	pi.on("agent_end", refreshHandler as any);
+	pi.on("session_start", refreshHandler as any);
+	pi.on("session_switch", refreshHandler as any);
 
 	pi.on("tool_execution_end", async (_event, ctx) => {
 		latestCtx = ctx;