gsd-pi 2.8.0 → 2.8.2

package/packages/pi-coding-agent/src/core/tools/bash.ts

@@ -6,8 +6,9 @@ import { join } from "node:path";
 import type { AgentTool } from "@gsd/pi-agent-core";
 import { type Static, Type } from "@sinclair/typebox";
 import { spawn } from "child_process";
-import { getShellConfig, getShellEnv, killProcessTree } from "../../utils/shell.js";
+import { getShellConfig, getShellEnv, killProcessTree, sanitizeCommand } from "../../utils/shell.js";
 import { DEFAULT_MAX_BYTES, DEFAULT_MAX_LINES, formatSize, type TruncationResult, truncateTail } from "./truncate.js";
+import type { ArtifactManager } from "../artifact-manager.js";
 
 // Cached Win32 FFI handles for restoring VT input after child processes
 let _vtHandles: { GetConsoleMode: any; SetConsoleMode: any; handle: any } | null = null;
@@ -51,6 +52,7 @@ export type BashToolInput = Static<typeof bashSchema>;
 export interface BashToolDetails {
 	truncation?: TruncationResult;
 	fullOutputPath?: string;
+	artifactId?: string;
 }
 
 /**
@@ -187,12 +189,15 @@ export interface BashToolOptions {
 	commandPrefix?: string;
 	/** Hook to adjust command, cwd, or env before execution */
 	spawnHook?: BashSpawnHook;
+	/** Session-scoped artifact storage. When provided, spills to artifact files instead of temp files. */
+	artifactManager?: ArtifactManager;
 }
 
 export function createBashTool(cwd: string, options?: BashToolOptions): AgentTool<typeof bashSchema> {
 	const ops = options?.operations ?? defaultBashOperations;
 	const commandPrefix = options?.commandPrefix;
 	const spawnHook = options?.spawnHook;
+	const artifactManager = options?.artifactManager;
 
 	return {
 		name: "bash",
@@ -206,13 +211,14 @@ export function createBashTool(cwd: string, options?: BashToolOptions): AgentToo
 			onUpdate?,
 		) => {
 			// Apply command prefix if configured (e.g., "shopt -s expand_aliases" for alias support)
-			const resolvedCommand = commandPrefix ? `${commandPrefix}\n${command}` : command;
+			const resolvedCommand = sanitizeCommand(commandPrefix ? `${commandPrefix}\n${command}` : command);
 			const spawnContext = resolveSpawnContext(resolvedCommand, cwd, spawnHook);
 
 			return new Promise((resolve, reject) => {
-				// We'll stream to a temp file if output gets large
-				let tempFilePath: string | undefined;
-				let tempFileStream: ReturnType<typeof createWriteStream> | undefined;
+				// We'll stream to a file if output gets large
+				let spillFilePath: string | undefined;
+				let spillArtifactId: string | undefined;
+				let spillFileStream: ReturnType<typeof createWriteStream> | undefined;
 				let totalBytes = 0;
 
 				// Keep a rolling buffer of the last chunk for tail truncation
@@ -224,19 +230,25 @@ export function createBashTool(cwd: string, options?: BashToolOptions): AgentToo
 				const handleData = (data: Buffer) => {
 					totalBytes += data.length;
 
-					// Start writing to temp file once we exceed the threshold
-					if (totalBytes > DEFAULT_MAX_BYTES && !tempFilePath) {
-						tempFilePath = getTempFilePath();
-						tempFileStream = createWriteStream(tempFilePath);
+					// Start writing to file once we exceed the threshold
+					if (totalBytes > DEFAULT_MAX_BYTES && !spillFilePath) {
+						if (artifactManager) {
+							const allocated = artifactManager.allocatePath("bash");
+							spillFilePath = allocated.path;
+							spillArtifactId = allocated.id;
+						} else {
+							spillFilePath = getTempFilePath();
+						}
+						spillFileStream = createWriteStream(spillFilePath);
 						// Write all buffered chunks to the file
 						for (const chunk of chunks) {
-							tempFileStream.write(chunk);
+							spillFileStream.write(chunk);
 						}
 					}
 
 					// Write to temp file if we have one
-					if (tempFileStream) {
-						tempFileStream.write(data);
+					if (spillFileStream) {
+						spillFileStream.write(data);
 					}
 
 					// Keep rolling buffer of recent data
@@ -258,7 +270,7 @@ export function createBashTool(cwd: string, options?: BashToolOptions): AgentToo
 							content: [{ type: "text", text: truncation.content || "" }],
 							details: {
 								truncation: truncation.truncated ? truncation : undefined,
-								fullOutputPath: tempFilePath,
+								fullOutputPath: spillFilePath,
 							},
 						});
 					}
@@ -272,8 +284,8 @@ export function createBashTool(cwd: string, options?: BashToolOptions): AgentToo
 				})
 					.then(({ exitCode }) => {
 						// Close temp file stream
-						if (tempFileStream) {
-							tempFileStream.end();
+						if (spillFileStream) {
+							spillFileStream.end();
 						}
 
 						// Combine all buffered chunks
@@ -290,21 +302,22 @@ export function createBashTool(cwd: string, options?: BashToolOptions): AgentToo
 						if (truncation.truncated) {
 							details = {
 								truncation,
-								fullOutputPath: tempFilePath,
+								fullOutputPath: spillFilePath,
+								...(spillArtifactId ? { artifactId: spillArtifactId } : {}),
 							};
 
 							// Build actionable notice
 							const startLine = truncation.totalLines - truncation.outputLines + 1;
 							const endLine = truncation.totalLines;
+							const outputRef = spillArtifactId ? `artifact://${spillArtifactId}` : spillFilePath;
 
 							if (truncation.lastLinePartial) {
-								// Edge case: last line alone > 30KB
 								const lastLineSize = formatSize(Buffer.byteLength(fullOutput.split("\n").pop() || "", "utf-8"));
-								outputText += `\n\n[Showing last ${formatSize(truncation.outputBytes)} of line ${endLine} (line is ${lastLineSize}). Full output: ${tempFilePath}]`;
+								outputText += `\n\n[Showing last ${formatSize(truncation.outputBytes)} of line ${endLine} (line is ${lastLineSize}). Full output: ${outputRef}]`;
 							} else if (truncation.truncatedBy === "lines") {
-								outputText += `\n\n[Showing lines ${startLine}-${endLine} of ${truncation.totalLines}. Full output: ${tempFilePath}]`;
+								outputText += `\n\n[Showing lines ${startLine}-${endLine} of ${truncation.totalLines}. Full output: ${outputRef}]`;
 							} else {
-								outputText += `\n\n[Showing lines ${startLine}-${endLine} of ${truncation.totalLines} (${formatSize(DEFAULT_MAX_BYTES)} limit). Full output: ${tempFilePath}]`;
+								outputText += `\n\n[Showing lines ${startLine}-${endLine} of ${truncation.totalLines} (${formatSize(DEFAULT_MAX_BYTES)} limit). Full output: ${outputRef}]`;
 							}
 						}
 
@@ -317,8 +330,8 @@ export function createBashTool(cwd: string, options?: BashToolOptions): AgentToo
 					})
 					.catch((err: Error) => {
 						// Close temp file stream
-						if (tempFileStream) {
-							tempFileStream.end();
+						if (spillFileStream) {
+							spillFileStream.end();
 						}
 
 						// Combine all buffered chunks for error output

package/packages/pi-coding-agent/src/core/tools/path-utils.test.ts

@@ -0,0 +1,66 @@
+import { describe, it, mock, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import { resolveToCwd, expandPath } from "./path-utils.js";
+
+describe("resolveToCwd", () => {
+	it("resolves relative paths against cwd", () => {
+		const result = resolveToCwd("foo/bar.txt", "/home/user/project");
+		assert.equal(result, "/home/user/project/foo/bar.txt");
+	});
+
+	it("returns absolute paths unchanged", () => {
+		const result = resolveToCwd("/absolute/path.txt", "/home/user/project");
+		assert.equal(result, "/absolute/path.txt");
+	});
+
+	it("expands ~ to home directory", () => {
+		const result = resolveToCwd("~/file.txt", "/home/user/project");
+		assert.ok(result.endsWith("/file.txt"));
+		assert.ok(!result.includes("~"));
+	});
+});
+
+describe("normalizeMsysPath (via resolveToCwd on win32)", () => {
+	const originalPlatform = process.platform;
+
+	afterEach(() => {
+		Object.defineProperty(process, "platform", { value: originalPlatform });
+	});
+
+	it("converts /c/Users/... to C:\\Users\\... on win32", () => {
+		Object.defineProperty(process, "platform", { value: "win32" });
+		// Re-import to pick up platform change — but since normalizeMsysPath
+		// reads process.platform at call time, we can test directly.
+		// On non-Windows, resolveToCwd treats /c/Users as absolute, so we
+		// test the normalization logic by checking the MSYS regex behavior.
+		const msysPath = "/c/Users/test/project";
+		const msysRegex = /^\/[a-zA-Z]\//;
+		assert.ok(msysRegex.test(msysPath), "MSYS path pattern matches");
+
+		// Simulate the conversion
+		const converted = `${msysPath[1].toUpperCase()}:\\${msysPath.slice(3).replace(/\//g, "\\")}`;
+		assert.equal(converted, "C:\\Users\\test\\project");
+	});
+
+	it("converts /f/Projects to F:\\Projects on win32", () => {
+		const msysPath = "/f/Projects";
+		const converted = `${msysPath[1].toUpperCase()}:\\${msysPath.slice(3).replace(/\//g, "\\")}`;
+		assert.equal(converted, "F:\\Projects");
+	});
+
+	it("does not convert regular Unix paths", () => {
+		const regularPath = "/usr/local/bin";
+		const msysRegex = /^\/[a-zA-Z]\//;
+		// /u/local/bin would match, but /usr/local/bin has 3+ chars before /
+		// Actually /u/ would match — but /usr/ won't because 'us' is 2 chars.
+		// The regex checks single letter after leading slash.
+		assert.ok(!msysRegex.test("/usr/local/bin"), "/usr/... is not an MSYS path");
+		assert.ok(msysRegex.test("/u/local/bin"), "/u/... would match (single letter)");
+	});
+
+	it("does not convert paths without leading slash", () => {
+		const msysRegex = /^\/[a-zA-Z]\//;
+		assert.ok(!msysRegex.test("c/Users/test"), "no leading slash — not MSYS");
+		assert.ok(!msysRegex.test("relative/path"), "relative path — not MSYS");
+	});
+});

package/packages/pi-coding-agent/src/core/tools/path-utils.ts

@@ -47,12 +47,24 @@ export function expandPath(filePath: string): string {
 	return normalized;
 }
 
+/**
+ * On Windows, convert MSYS/MinGW-style paths (/c/Users/...) to native
+ * drive letter paths (C:\Users\...). LLMs often produce these when given
+ * Windows paths in prompts.
+ */
+function normalizeMsysPath(p: string): string {
+	if (process.platform === "win32" && /^\/[a-zA-Z]\//.test(p)) {
+		return `${p[1]!.toUpperCase()}:\\${p.slice(3).replace(/\//g, "\\")}`;
+	}
+	return p;
+}
+
 /**
  * Resolve a path relative to the given cwd.
- * Handles ~ expansion and absolute paths.
+ * Handles ~ expansion, MSYS-style paths on Windows, and absolute paths.
  */
 export function resolveToCwd(filePath: string, cwd: string): string {
-	const expanded = expandPath(filePath);
+	const expanded = normalizeMsysPath(expandPath(filePath));
 	if (isAbsolute(expanded)) {
 		return expanded;
 	}

package/packages/pi-coding-agent/src/index.ts

@@ -198,6 +198,9 @@ export {
 	type SessionMessageEntry,
 	type ThinkingLevelChangeEntry,
 } from "./core/session-manager.js";
+// Blob and artifact storage
+export { BlobStore, isBlobRef, parseBlobRef, externalizeImageData, resolveImageData } from "./core/blob-store.js";
+export { ArtifactManager } from "./core/artifact-manager.js";
 export {
 	type CompactionSettings,
 	type ImageSettings,
@@ -330,4 +333,4 @@ export {
 export { copyToClipboard } from "./utils/clipboard.js";
 export { parseFrontmatter, stripFrontmatter } from "./utils/frontmatter.js";
 // Shell utilities
-export { getShellConfig } from "./utils/shell.js";
+export { getShellConfig, sanitizeCommand } from "./utils/shell.js";

package/packages/pi-coding-agent/src/modes/interactive/interactive-mode.ts

@@ -824,10 +824,12 @@ export class InteractiveMode {
 
 		// Try parent directories (package manager stores directory paths)
 		let current = p;
-		while (current.includes("/")) {
-			current = current.substring(0, current.lastIndexOf("/"));
-			const parent = metadata.get(current);
-			if (parent) return parent;
+		let parent = path.dirname(current);
+		while (parent !== current) {
+			const meta = metadata.get(parent);
+			if (meta) return meta;
+			current = parent;
+			parent = path.dirname(current);
 		}
 
 		return undefined;

package/packages/pi-coding-agent/src/utils/shell.ts

@@ -118,6 +118,17 @@ export function getShellConfig(): { shell: string; args: string[] } {
 	return cachedShellConfig;
 }
 
+/**
+ * On Windows + Git Bash, rewrite Windows-style NUL redirects to /dev/null.
+ * Git Bash doesn't recognize NUL as a device name and creates a literal file
+ * that is undeletable due to NUL being a reserved Windows device name.
+ * No-op on non-Windows platforms.
+ */
+export function sanitizeCommand(command: string): string {
+	if (process.platform !== "win32") return command;
+	return command.replace(/(\d*>>?) *\bNUL\b(?=\s|;|\||&|\)|$)/gi, "$1 /dev/null");
+}
+
 export function getShellEnv(): NodeJS.ProcessEnv {
 	const binDir = getBinDir();
 	const pathKey = Object.keys(process.env).find((key) => key.toLowerCase() === "path") ?? "PATH";

package/src/resources/extensions/bg-shell/index.ts

@@ -34,6 +34,7 @@ import {
 	DEFAULT_MAX_BYTES,
 	DEFAULT_MAX_LINES,
 	getShellConfig,
+	sanitizeCommand,
 } from "@gsd/pi-coding-agent";
 import {
 	Text,
@@ -582,7 +583,7 @@ function startProcess(opts: StartOptions): BgProcess {
 	const env = { ...process.env, ...(opts.env || {}) };
 
 	const { shell, args: shellArgs } = getShellConfig();
-	const proc = spawn(shell, [...shellArgs, opts.command], {
+	const proc = spawn(shell, [...shellArgs, sanitizeCommand(opts.command)], {
 		cwd: opts.cwd,
 		stdio: ["pipe", "pipe", "pipe"],
 		env,

package/src/resources/extensions/browser-tools/lifecycle.ts

@@ -181,7 +181,12 @@ export async function ensureBrowser(): Promise<{ browser: Browser; context: Brow
 	// Lazy import so playwright is only loaded when actually needed
 	const { chromium } = await import("playwright");
 
-	const launchOptions: Record<string, unknown> = { headless: false };
+	// Auto-detect headless environments: Linux without $DISPLAY has no GUI.
+	// All browser tool operations (navigation, screenshots, DOM) work in headless mode.
+	const needsHeadless = process.platform === "linux" && !process.env.DISPLAY;
+	const launchOptions: Record<string, unknown> = {
+		headless: needsHeadless || process.env.FORCE_HEADLESS === "true",
+	};
 	const customPath = process.env.BROWSER_PATH;
 	if (customPath) launchOptions.executablePath = customPath;
 	const browser = await chromium.launch(launchOptions);