gsd-pi 2.79.0-dev.ece5fd8ba → 2.80.0-dev.c5f2443b3

package/src/resources/extensions/gsd/tests/custom-verify-retry-store.test.ts

@@ -0,0 +1,139 @@
+// Project/App: GSD-2
+// File Purpose: Unit tests for custom workflow verification retry persistence.
+
+import assert from "node:assert/strict";
+import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import test from "node:test";
+
+import {
+  customVerifyRetryStatePath,
+  hydrateCustomVerifyRetryCounts,
+  saveCustomVerifyRetryCounts,
+} from "../auto/custom-verify-retry-store.ts";
+
+function makeSession(activeRunDir: string): {
+  activeRunDir: string;
+  basePath: string;
+  verificationRetryCount: Map<string, number>;
+} {
+  return {
+    activeRunDir,
+    basePath: activeRunDir,
+    verificationRetryCount: new Map<string, number>(),
+  };
+}
+
+test("hydrateCustomVerifyRetryCounts loads positive finite counts from disk", () => {
+    const dir = mkdtempSync(join(tmpdir(), "gsd-verify-retries-"));
+  try {
+    const session = makeSession(dir);
+    mkdirSync(join(dir, "runtime"));
+    writeFileSync(customVerifyRetryStatePath(session), JSON.stringify({
+      counts: {
+        "execute-task/M001/S001/T001": 2.8,
+        "execute-task/M001/S001/T002": 1,
+        zero: 0,
+        negative: -1,
+        infinite: Number.POSITIVE_INFINITY,
+        string: "3",
+      },
+    }));
+
+    const logged: unknown[] = [];
+    const counts = hydrateCustomVerifyRetryCounts(session, {
+      logFailure: err => logged.push(err),
+    });
+
+    assert.equal(counts, session.verificationRetryCount);
+    assert.deepEqual([...counts.entries()], [
+      ["execute-task/M001/S001/T001", 2],
+      ["execute-task/M001/S001/T002", 1],
+    ]);
+    assert.deepEqual(logged, []);
+  } finally {
+    rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+test("hydrateCustomVerifyRetryCounts keeps existing in-memory counts", () => {
+  const dir = mkdtempSync(join(tmpdir(), "gsd-verify-retries-"));
+  try {
+    const session = makeSession(dir);
+    session.verificationRetryCount.set("existing", 4);
+
+    const counts = hydrateCustomVerifyRetryCounts(session, {
+      logFailure: () => assert.fail("logFailure should not be called"),
+    });
+
+    assert.deepEqual([...counts.entries()], [["existing", 4]]);
+  } finally {
+    rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+test("hydrateCustomVerifyRetryCounts logs read failures and returns the existing map", () => {
+  const dir = mkdtempSync(join(tmpdir(), "gsd-verify-retries-"));
+  try {
+    const session = makeSession(dir);
+    const logged: unknown[] = [];
+
+    const counts = hydrateCustomVerifyRetryCounts(session, {
+      logFailure: err => logged.push(err),
+    });
+
+    assert.equal(counts, session.verificationRetryCount);
+    assert.equal(counts.size, 0);
+    assert.equal(logged.length, 1);
+  } finally {
+    rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+test("saveCustomVerifyRetryCounts writes counts with an updated timestamp", () => {
+  const dir = mkdtempSync(join(tmpdir(), "gsd-verify-retries-"));
+  try {
+    const session = makeSession(dir);
+    session.verificationRetryCount.set("execute-task/M001/S001/T001", 3);
+
+    saveCustomVerifyRetryCounts(session, {
+      logFailure: () => assert.fail("logFailure should not be called"),
+    });
+
+    const saved = JSON.parse(readFileSync(customVerifyRetryStatePath(session), "utf-8"));
+    assert.deepEqual(saved.counts, {
+      "execute-task/M001/S001/T001": 3,
+    });
+    assert.equal(typeof saved.updatedAt, "string");
+  } finally {
+    rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+test("saveCustomVerifyRetryCounts deletes empty retry files and ignores missing files", () => {
+  const dir = mkdtempSync(join(tmpdir(), "gsd-verify-retries-"));
+  try {
+    const session = makeSession(dir);
+    session.verificationRetryCount.set("execute-task/M001/S001/T001", 1);
+    saveCustomVerifyRetryCounts(session, {
+      logFailure: () => assert.fail("logFailure should not be called"),
+    });
+
+    session.verificationRetryCount.clear();
+    saveCustomVerifyRetryCounts(session, {
+      logFailure: () => assert.fail("logFailure should not be called"),
+    });
+    saveCustomVerifyRetryCounts(session, {
+      logFailure: () => assert.fail("logFailure should not be called"),
+    });
+
+    const logged: unknown[] = [];
+    hydrateCustomVerifyRetryCounts(session, {
+      logFailure: err => logged.push(err),
+    });
+    assert.equal(logged.length, 1);
+  } finally {
+    rmSync(dir, { recursive: true, force: true });
+  }
+});

package/src/resources/extensions/gsd/tests/custom-workflow-engine.test.ts

@@ -193,6 +193,18 @@ describe("CustomWorkflowEngine.resolveDispatch", () => {
     }
   });
 
+  it("returns skip when pending steps are blocked by incomplete dependencies", async () => {
+    const { engine } = setupEngine([
+      makeStep({ id: "a", dependsOn: ["b"] }),
+      makeStep({ id: "b", dependsOn: ["a"] }),
+    ]);
+
+    const state = await engine.deriveState("/unused");
+    const dispatch = await engine.resolveDispatch(state, { basePath: "/unused" });
+
+    assert.deepEqual(dispatch, { action: "skip" });
+  });
+
   it("respects dependency ordering", async () => {
     const { engine } = setupEngine([
       makeStep({ id: "a" }),

package/src/resources/extensions/gsd/tests/dashboard-custom-engine.test.ts

@@ -44,7 +44,7 @@ describe("Dashboard custom-engine: updateProgressWidget in custom engine path",
     const source = readFileSync(loopPath, "utf-8");
 
     // Find the custom engine block
-    const customEngineStart = source.indexOf('s.activeEngineId !== "dev"');
+    const customEngineStart = source.indexOf("shouldUseCustomEnginePath({");
     assert.ok(customEngineStart > -1, "Should find custom engine path in loop.ts");
 
     // The updateProgressWidget call should appear after the custom engine block start
@@ -66,11 +66,11 @@ describe("Dashboard custom-engine: updateProgressWidget in custom engine path",
     const loopPath = resolve(__filename, "../../auto/loop.ts");
     const source = readFileSync(loopPath, "utf-8");
 
-    const customEngineStart = source.indexOf('s.activeEngineId !== "dev"');
+    const customEngineStart = source.indexOf("shouldUseCustomEnginePath({");
     const afterCustomEngine = source.slice(customEngineStart);
 
     // Verify custom engine path has iterData built before the widget call
-    const iterDataIndex = afterCustomEngine.indexOf("iterData = {");
+    const iterDataIndex = afterCustomEngine.indexOf("buildCustomEngineIterationData({");
     const widgetIndex = afterCustomEngine.indexOf("deps.updateProgressWidget");
     assert.ok(iterDataIndex > -1 && widgetIndex > -1, "Both iterData and widget call should exist");
     assert.ok(

package/src/resources/extensions/gsd/tests/db-adapter.test.ts

@@ -0,0 +1,82 @@
+// Project/App: GSD-2
+// File Purpose: Unit tests for the normalized SQLite adapter wrapper.
+
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import {
+  createDbAdapter,
+  normalizeDbRow,
+  normalizeDbRows,
+} from "../db-adapter.ts";
+
+test("normalizeDbRow returns undefined for missing rows", () => {
+  assert.equal(normalizeDbRow(null), undefined);
+  assert.equal(normalizeDbRow(undefined), undefined);
+});
+
+test("normalizeDbRow converts null-prototype rows to plain objects", () => {
+  const raw = Object.create(null) as Record<string, unknown>;
+  raw.id = "M001";
+
+  const normalized = normalizeDbRow(raw);
+
+  assert.deepEqual(normalized, { id: "M001" });
+  assert.equal(Object.getPrototypeOf(normalized), Object.prototype);
+});
+
+test("normalizeDbRows normalizes every row", () => {
+  const first = Object.create(null) as Record<string, unknown>;
+  first.id = "S01";
+  const second = { id: "S02" };
+
+  assert.deepEqual(normalizeDbRows([first, second]), [{ id: "S01" }, { id: "S02" }]);
+});
+
+test("createDbAdapter caches prepared statements and clears cache on close", () => {
+  const calls: unknown[] = [];
+  const rawStatement = {
+    run: (...params: unknown[]) => {
+      calls.push(["run", params]);
+      return { changes: 1 };
+    },
+    get: (...params: unknown[]) => {
+      calls.push(["get", params]);
+      const row = Object.create(null) as Record<string, unknown>;
+      row.id = "T01";
+      return row;
+    },
+    all: (...params: unknown[]) => {
+      calls.push(["all", params]);
+      const row = Object.create(null) as Record<string, unknown>;
+      row.id = "T02";
+      return [row];
+    },
+  };
+  let prepareCount = 0;
+  const rawDb = {
+    exec: (sql: string) => calls.push(["exec", sql]),
+    prepare: (sql: string) => {
+      prepareCount += 1;
+      calls.push(["prepare", sql]);
+      return rawStatement;
+    },
+    close: () => calls.push(["close"]),
+  };
+  const adapter = createDbAdapter(rawDb);
+
+  const first = adapter.prepare("SELECT * FROM tasks WHERE id = ?");
+  const second = adapter.prepare("SELECT * FROM tasks WHERE id = ?");
+
+  assert.equal(first, second);
+  assert.equal(prepareCount, 1);
+  assert.deepEqual(first.get("T01"), { id: "T01" });
+  assert.deepEqual(first.all("T02"), [{ id: "T02" }]);
+  assert.deepEqual(first.run("T01"), { changes: 1 });
+
+  adapter.close();
+  const third = adapter.prepare("SELECT * FROM tasks WHERE id = ?");
+
+  assert.notEqual(third, first);
+  assert.equal(prepareCount, 2);
+});

package/src/resources/extensions/gsd/tests/db-base-schema.test.ts

@@ -0,0 +1,62 @@
+// Project/App: GSD-2
+// File Purpose: Tests for base GSD database schema DDL helper.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createBaseSchemaObjects } from "../db-base-schema.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeStatement implements DbStatement {
+  run(): unknown {
+    return undefined;
+  }
+
+  get(): Record<string, unknown> | undefined {
+    return undefined;
+  }
+
+  all(): Record<string, unknown>[] {
+    return [];
+  }
+}
+
+class FakeAdapter implements DbAdapter {
+  readonly execCalls: string[] = [];
+
+  exec(sql: string): void {
+    this.execCalls.push(sql);
+  }
+
+  prepare(): DbStatement {
+    return new FakeStatement();
+  }
+
+  close(): void {}
+}
+
+describe("db-base-schema", () => {
+  test("creates current base schema tables, indexes, and active views", () => {
+    const db = new FakeAdapter();
+    let ftsCalls = 0;
+    let dedupCalls = 0;
+
+    createBaseSchemaObjects(db, {
+      tryCreateMemoriesFts: () => {
+        ftsCalls += 1;
+        return true;
+      },
+      ensureVerificationEvidenceDedupIndex: () => {
+        dedupCalls += 1;
+      },
+    });
+
+    assert.equal(ftsCalls, 1);
+    assert.equal(dedupCalls, 1);
+    assert.ok(db.execCalls.some((sql) => sql.includes("CREATE TABLE IF NOT EXISTS schema_version")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("CREATE TABLE IF NOT EXISTS tasks")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("CREATE TABLE IF NOT EXISTS quality_gates")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("CREATE INDEX IF NOT EXISTS idx_tasks_active")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("CREATE VIEW IF NOT EXISTS active_decisions")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("CREATE VIEW IF NOT EXISTS active_memories")));
+  });
+});

package/src/resources/extensions/gsd/tests/db-connection-cache.test.ts

@@ -0,0 +1,60 @@
+// Project/App: GSD-2
+// File Purpose: Tests for workspace database connection cache lifecycle helpers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createDbConnectionCache, type DbConnectionCacheEntry } from "../db-connection-cache.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeAdapter implements DbAdapter {
+  readonly calls: string[] = [];
+
+  exec(sql: string): void {
+    this.calls.push(`exec:${sql}`);
+  }
+
+  prepare(): DbStatement {
+    throw new Error("prepare is not used by DbConnectionCache tests");
+  }
+
+  close(): void {
+    this.calls.push("close");
+  }
+}
+
+function entry(path: string, db = new FakeAdapter()): DbConnectionCacheEntry {
+  return { dbPath: path, db };
+}
+
+describe("db-connection-cache", () => {
+  test("stores entries and exposes a readonly cache view", () => {
+    const cache = createDbConnectionCache();
+    const cached = entry("/tmp/a.db");
+
+    cache.set("workspace-a", cached);
+
+    assert.equal(cache.get("workspace-a"), cached);
+    assert.equal(cache.has("workspace-a"), true);
+    assert.equal(cache.asReadonlyMap().size, 1);
+  });
+
+  test("closeNonActive closes and removes only inactive entries", () => {
+    const cache = createDbConnectionCache();
+    const activeDb = new FakeAdapter();
+    const inactiveDb = new FakeAdapter();
+    cache.set("active", entry("/tmp/active.db", activeDb));
+    cache.set("inactive", entry("/tmp/inactive.db", inactiveDb));
+    const closed: string[] = [];
+
+    cache.closeNonActive(activeDb, (cached) => {
+      closed.push(cached.dbPath);
+      cached.db.close();
+    });
+
+    assert.deepEqual(closed, ["/tmp/inactive.db"]);
+    assert.equal(cache.has("active"), true);
+    assert.equal(cache.has("inactive"), false);
+    assert.deepEqual(activeDb.calls, []);
+    assert.deepEqual(inactiveDb.calls, ["close"]);
+  });
+});

package/src/resources/extensions/gsd/tests/db-coordination-schema.test.ts

@@ -0,0 +1,39 @@
+// Project/App: GSD-2
+// File Purpose: Tests for auto-mode coordination schema helper.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createCoordinationTablesV24 } from "../db-coordination-schema.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeAdapter implements DbAdapter {
+  readonly execCalls: string[] = [];
+
+  exec(sql: string): void {
+    this.execCalls.push(sql);
+  }
+
+  prepare(): DbStatement {
+    throw new Error("prepare is not used by coordination schema tests");
+  }
+
+  close(): void {}
+}
+
+describe("db-coordination-schema", () => {
+  test("creates coordination tables and claim indexes", () => {
+    const db = new FakeAdapter();
+
+    createCoordinationTablesV24(db);
+
+    assert.equal(db.execCalls.length, 9);
+    assert.match(db.execCalls[0], /CREATE TABLE IF NOT EXISTS workers/);
+    assert.match(db.execCalls[1], /CREATE TABLE IF NOT EXISTS milestone_leases/);
+    assert.match(db.execCalls[2], /CREATE TABLE IF NOT EXISTS unit_dispatches/);
+    assert.match(db.execCalls[3], /CREATE TABLE IF NOT EXISTS cancellation_requests/);
+    assert.match(db.execCalls[4], /CREATE TABLE IF NOT EXISTS command_queue/);
+    assert.ok(db.execCalls.some((sql) => sql.includes("idx_unit_dispatches_active_per_unit")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("WHERE status IN ('claimed','running')")));
+    assert.ok(db.execCalls.some((sql) => sql.includes("idx_command_queue_pending")));
+  });
+});

package/src/resources/extensions/gsd/tests/db-decision-requirement-rows.test.ts

@@ -0,0 +1,135 @@
+// Project/App: GSD-2
+// File Purpose: Tests for decision and requirement database row mappers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import {
+  rowToActiveDecision,
+  rowToActiveRequirement,
+  rowToDecision,
+  rowToRequirement,
+  rowsToRequirementCounts,
+} from "../db-decision-requirement-rows.ts";
+
+describe("db-decision-requirement-rows", () => {
+  test("maps persisted decision rows with defaults", () => {
+    const decision = rowToDecision({
+      seq: 7,
+      id: "D007",
+      when_context: "during planning",
+      scope: "M001/S01",
+      decision: "keep SQL writes in gsd-db",
+      choice: "facade wrappers",
+      rationale: "preserve the single-writer invariant",
+      revisable: "after repository split",
+      superseded_by: "D008",
+    });
+
+    assert.deepEqual(decision, {
+      seq: 7,
+      id: "D007",
+      when_context: "during planning",
+      scope: "M001/S01",
+      decision: "keep SQL writes in gsd-db",
+      choice: "facade wrappers",
+      rationale: "preserve the single-writer invariant",
+      revisable: "after repository split",
+      made_by: "agent",
+      source: "discussion",
+      superseded_by: "D008",
+    });
+  });
+
+  test("maps active decision rows as non-superseded", () => {
+    const decision = rowToActiveDecision({
+      seq: 1,
+      id: "D001",
+      when_context: "now",
+      scope: "global",
+      decision: "active only",
+      choice: "view row",
+      rationale: "view filters superseded rows",
+      revisable: "yes",
+      made_by: "human",
+      source: "planning",
+      superseded_by: "ignored",
+    });
+
+    assert.equal(decision.made_by, "human");
+    assert.equal(decision.source, "planning");
+    assert.equal(decision.superseded_by, null);
+  });
+
+  test("maps persisted requirement rows", () => {
+    const requirement = rowToRequirement({
+      id: "R001",
+      class: "functional",
+      status: "active",
+      description: "Persist requirements",
+      why: "planning needs durable context",
+      source: "roadmap",
+      primary_owner: "S01",
+      supporting_slices: "S02",
+      validation: "roundtrip",
+      notes: "important",
+      full_content: "Full requirement text",
+      superseded_by: "R002",
+    });
+
+    assert.deepEqual(requirement, {
+      id: "R001",
+      class: "functional",
+      status: "active",
+      description: "Persist requirements",
+      why: "planning needs durable context",
+      source: "roadmap",
+      primary_owner: "S01",
+      supporting_slices: "S02",
+      validation: "roundtrip",
+      notes: "important",
+      full_content: "Full requirement text",
+      superseded_by: "R002",
+    });
+  });
+
+  test("maps active requirement rows as non-superseded", () => {
+    const requirement = rowToActiveRequirement({
+      id: "R001",
+      class: "functional",
+      status: "validated",
+      description: "Validated requirement",
+      why: "done",
+      source: "roadmap",
+      primary_owner: "S01",
+      supporting_slices: "",
+      validation: "tests",
+      notes: "",
+      full_content: "Full requirement text",
+      superseded_by: "ignored",
+    });
+
+    assert.equal(requirement.status, "validated");
+    assert.equal(requirement.superseded_by, null);
+  });
+
+  test("reduces requirement status rows into stable counts", () => {
+    const counts = rowsToRequirementCounts([
+      { status: "active", count: 2 },
+      { status: "validated", count: 3 },
+      { status: "deferred", count: 5 },
+      { status: "out-of-scope", count: 7 },
+      { status: "out_of_scope", count: 11 },
+      { status: "blocked", count: 13 },
+      { status: "unknown", count: 17 },
+    ]);
+
+    assert.deepEqual(counts, {
+      active: 2,
+      validated: 3,
+      deferred: 5,
+      outOfScope: 18,
+      blocked: 13,
+      total: 58,
+    });
+  });
+});

package/src/resources/extensions/gsd/tests/db-gate-rows.test.ts

@@ -0,0 +1,53 @@
+// Project/App: GSD-2
+// File Purpose: Tests for quality gate database row mapper.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { rowToGate } from "../db-gate-rows.ts";
+
+describe("db-gate-rows", () => {
+  test("rowToGate clears verdict for pending gates", () => {
+    const gate = rowToGate({
+      milestone_id: "M001",
+      slice_id: "S01",
+      gate_id: "Q3",
+      scope: "slice",
+      status: "pending",
+      verdict: "pass",
+    });
+
+    assert.equal(gate.task_id, "");
+    assert.equal(gate.verdict, null);
+    assert.equal(gate.rationale, "");
+    assert.equal(gate.findings, "");
+    assert.equal(gate.evaluated_at, null);
+  });
+
+  test("rowToGate preserves completed gate verdict and details", () => {
+    const gate = rowToGate({
+      milestone_id: "M001",
+      slice_id: "S01",
+      gate_id: "Q4",
+      scope: "task",
+      task_id: "T01",
+      status: "complete",
+      verdict: "flag",
+      rationale: "needs review",
+      findings: "minor risk",
+      evaluated_at: "2026-05-04T00:00:00.000Z",
+    });
+
+    assert.deepEqual(gate, {
+      milestone_id: "M001",
+      slice_id: "S01",
+      gate_id: "Q4",
+      scope: "task",
+      task_id: "T01",
+      status: "complete",
+      verdict: "flag",
+      rationale: "needs review",
+      findings: "minor risk",
+      evaluated_at: "2026-05-04T00:00:00.000Z",
+    });
+  });
+});

package/src/resources/extensions/gsd/tests/db-lightweight-query-rows.test.ts

@@ -0,0 +1,45 @@
+// Project/App: GSD-2
+// File Purpose: Tests for lightweight DB query row mappers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import {
+  emptyTaskStatusCounts,
+  rowToActiveTaskSummary,
+  rowToIdStatusSummary,
+  rowToTaskStatusCounts,
+  rowsToStringColumn,
+} from "../db-lightweight-query-rows.ts";
+
+describe("db-lightweight-query-rows", () => {
+  test("maps id and status summaries", () => {
+    assert.deepEqual(rowToIdStatusSummary({ id: "M001", status: "active" }), {
+      id: "M001",
+      status: "active",
+    });
+  });
+
+  test("maps active task summaries", () => {
+    assert.deepEqual(rowToActiveTaskSummary({ id: "T01", status: "pending", title: "Plan task" }), {
+      id: "T01",
+      status: "pending",
+      title: "Plan task",
+    });
+  });
+
+  test("maps task status counts with stable empty defaults", () => {
+    assert.deepEqual(rowToTaskStatusCounts({ total: 3, done: 1, pending: 2 }), {
+      total: 3,
+      done: 1,
+      pending: 2,
+    });
+    assert.deepEqual(rowToTaskStatusCounts(undefined), emptyTaskStatusCounts());
+  });
+
+  test("extracts string columns from rows", () => {
+    assert.deepEqual(rowsToStringColumn([{ slice_id: "S01" }, { slice_id: "S02" }], "slice_id"), [
+      "S01",
+      "S02",
+    ]);
+  });
+});