gsd-pi 2.79.0-dev.ece5fd8ba → 2.80.0-dev.4ea7d80e7

package/src/resources/extensions/gsd/tests/fixtures/pr-body/commands-ship-basic.md

@@ -0,0 +1,52 @@
+## TL;DR
+
+**What:** Ship milestone M001 - Authentication
+**Why:** Users need to authenticate before accessing protected resources.
+**How:** Added password hash check and session token issuance.
+
+## What
+
+### S01
+Implemented login flow.
+
+## Why
+
+Users need to authenticate before accessing protected resources.
+
+## How
+
+Added password hash check and session token issuance.
+
+## Linked Issue
+
+Closes #123
+
+## Roadmap
+
+- [x] **S01: Login**
+
+## Metrics
+
+- **Units executed:** 3
+
+## Tests Run
+
+- npm test
+- npm run typecheck:extensions
+
+## Change Type
+
+- [x] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [ ] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Revert the merge commit.
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/commands-ship-empty-optionals.md

@@ -0,0 +1,42 @@
+## TL;DR
+
+**What:** Ship milestone M001 - Authentication
+**Why:** Milestone work is complete and ready for review.
+**How:** Generated from GSD evidence and local workflow artifacts.
+
+## What
+
+Milestone M001 completed.
+
+## Why
+
+Milestone work is complete and ready for review.
+
+## How
+
+Generated from GSD evidence and local workflow artifacts.
+
+## Linked Issue
+
+Not specified. Add an issue link before marking this PR ready if CONTRIBUTING.md requires one.
+
+## Tests Run
+
+- Not specified. Add exact verification commands before requesting review.
+
+## Change Type
+
+- [x] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [ ] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- No behavior-changing rollback notes recorded.
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/swarm-lane-no-blockers.md

@@ -0,0 +1,55 @@
+## TL;DR
+
+**What:** Ship workflow lane/writer - lane/writer
+**Why:** Workflow work is complete and ready for review.
+**How:** Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## What
+
+### Swarm lane
+**Lane:** `lane/writer`
+**Branch:** `lane/single-writer`
+**Owner:** @owner
+**Latest commit:** `abc1234`
+
+### Impact area
+Single-writer UOK metadata.
+
+### Changed contracts
+- [ ] WriterToken
+
+### Transition risks
+- [ ] Writer token lifecycle regression
+
+## Why
+
+Workflow work is complete and ready for review.
+
+## How
+
+Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## Linked Issue
+
+Closes #123
+
+## Tests Run
+
+- npm run typecheck:extensions
+
+## Change Type
+
+- [ ] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [x] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Disable writer sequence enrichment
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/swarm-lane-with-blockers.md

@@ -0,0 +1,60 @@
+## TL;DR
+
+**What:** Ship workflow lane/writer - lane/writer
+**Why:** Workflow work is complete and ready for review.
+**How:** Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## What
+
+### Swarm lane
+**Lane:** `lane/writer`
+**Branch:** `lane/single-writer`
+**Owner:** @owner
+**Latest commit:** `abc1234`
+
+### Impact area
+Single-writer UOK metadata.
+
+### Changed contracts
+- [ ] WriterToken
+
+### Transition risks
+- [ ] Writer token lifecycle regression
+
+## Blockers
+
+- Awaiting state-lane writer-sequence merge
+- Parity report incomplete
+
+## Why
+
+Workflow work is complete and ready for review.
+
+## How
+
+Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## Linked Issue
+
+Closes #123
+
+## Tests Run
+
+- npm run typecheck:extensions
+
+## Change Type
+
+- [ ] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [x] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Disable writer sequence enrichment
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/forensics-prompt-rendering.test.ts

@@ -0,0 +1,36 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the forensics prompt renders required investigation and issue-routing guidance.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("forensics prompt renders compact investigation and issue routing guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-forensics-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("forensics", {
+    problemDescription: "Auto-mode repeats the same unit.",
+    forensicData: "stuck-detected event for execute-task/M001/S01/T01",
+    gsdSourceDir: process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd(),
+    dedupSection: "No duplicate issue found.",
+  });
+
+  assert.match(prompt, /Investigation Protocol/);
+  assert.match(prompt, /gsd_milestone_status/);
+  assert.match(prompt, /sqlite3 .gsd\/gsd.db/);
+  assert.match(prompt, /gh issue create --repo gsd-build\/gsd-2/);
+  assert.match(prompt, /Do NOT use the `github_issues` tool/);
+  assert.match(prompt, /Redaction Rules/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/graph-operations.test.ts

@@ -233,6 +233,16 @@ describe("getNextPendingStep", () => {
     const next = getNextPendingStep(graph);
     assert.equal(next?.id, "b");
   });
+
+  it("treats expanded dependencies as satisfied", (t) => {
+    const graph = makeGraph([
+      makeStep({ id: "iter", status: "expanded" }),
+      makeStep({ id: "after", dependsOn: ["iter"] }),
+    ]);
+
+    const next = getNextPendingStep(graph);
+    assert.equal(next?.id, "after");
+  });
 });
 
 // ─── markStepComplete ────────────────────────────────────────────────────

package/src/resources/extensions/gsd/tests/gsd-db.test.ts

@@ -1,3 +1,5 @@
+// GSD Extension - Database regression tests.
+
 import { describe, test } from 'node:test';
 import assert from 'node:assert/strict';
 import * as fs from 'node:fs';
@@ -28,8 +30,15 @@ import {
   insertTask,
   getTask,
   getSliceTasks,
+  deleteMilestone,
+  clearEngineHierarchy,
+  recordMilestoneCommitAttribution,
+  getMilestoneCommitAttributionShas,
   checkpointDatabase,
+  refreshOpenDatabaseFromDisk,
+  tryCreateMemoriesFts,
 } from '../gsd-db.ts';
+import { _resetLogs, peekLogs, setStderrLoggingEnabled } from '../workflow-logger.ts';
 
 const _require = createRequire(import.meta.url);
 
@@ -910,6 +919,31 @@ describe('gsd-db', () => {
     closeDatabase();
   });
 
+  test('gsd-db: FTS5 unavailable warning normalizes provider typo', () => {
+    const previousStderr = setStderrLoggingEnabled(false);
+    _resetLogs();
+    try {
+      const ok = tryCreateMemoriesFts({
+        exec(): void {
+          throw new Error('no such moduel : fts5');
+        },
+        prepare(): never {
+          throw new Error('prepare should not be called');
+        },
+        close(): void {},
+      });
+
+      assert.equal(ok, false, 'FTS5 creation should report fallback');
+      const warning = peekLogs().find((entry) => entry.component === 'db' && entry.message.includes('FTS5 unavailable'));
+      assert.ok(warning, 'FTS5 fallback warning should be logged');
+      assert.match(warning!.message, /no such module: fts5/);
+      assert.doesNotMatch(warning!.message, /moduel/);
+    } finally {
+      _resetLogs();
+      setStderrLoggingEnabled(previousStderr);
+    }
+  });
+
   // ─── checkpointDatabase ────────────────────────────────────────────────────
 
   describe('checkpointDatabase', () => {
@@ -952,6 +986,111 @@ describe('gsd-db', () => {
     });
   });
 
+  // ─── refreshOpenDatabaseFromDisk ───────────────────────────────────────────
+
+  describe('refreshOpenDatabaseFromDisk', () => {
+    test('refreshOpenDatabaseFromDisk: reopens the active file-backed database and sees external writes', (t) => {
+      const dbPath = tempDbPath();
+      t.after(() => cleanup(dbPath));
+
+      openDatabase(dbPath);
+      insertMilestone({ id: 'M001', title: 'Test', status: 'active' });
+      insertSlice({
+        id: 'S01',
+        milestoneId: 'M001',
+        title: 'Slice 1',
+        status: 'pending',
+        sequence: 1,
+      });
+      insertTask({
+        id: 'T01',
+        milestoneId: 'M001',
+        sliceId: 'S01',
+        title: 'Task 1',
+        status: 'pending',
+        sequence: 1,
+      });
+
+      const adapterBefore = _getAdapter()!;
+
+      const externalDb = openRawSqliteForTest(dbPath);
+      try {
+        externalDb.exec(`
+          INSERT INTO tasks (milestone_id, slice_id, id, title, status, sequence)
+          VALUES ('M001', 'S01', 'T02', 'Task 2', 'pending', 2)
+        `);
+      } finally {
+        externalDb.close();
+      }
+
+      const visibleBeforeRefresh = getSliceTasks('M001', 'S01').map(task => task.id);
+      assert.ok(visibleBeforeRefresh.includes('T01'));
+
+      assert.equal(refreshOpenDatabaseFromDisk(), true);
+      assert.notEqual(_getAdapter(), adapterBefore, 'refresh must replace the active adapter rather than becoming a no-op');
+      const sliceTaskIds = getSliceTasks('M001', 'S01').map(task => task.id);
+      assert.deepEqual(sliceTaskIds, ['T01', 'T02']);
+      assert.equal(isDbAvailable(), true);
+    });
+
+    test('refreshOpenDatabaseFromDisk: refuses in-memory databases without closing them', () => {
+      openDatabase(':memory:');
+      insertMilestone({ id: 'M001', title: 'Test', status: 'active' });
+
+      assert.equal(refreshOpenDatabaseFromDisk(), false);
+      assert.equal(isDbAvailable(), true);
+      assert.ok(_getAdapter()!.prepare("SELECT 1 FROM milestones WHERE id = 'M001'").get());
+
+      closeDatabase();
+    });
+
+    test('refreshOpenDatabaseFromDisk: is a no-op when no database is open', () => {
+      closeDatabase();
+      assert.equal(refreshOpenDatabaseFromDisk(), false);
+      assert.equal(isDbAvailable(), false);
+    });
+  });
+
+  // ─── milestone_commit_attributions teardown ───────────────────────────────
+
+  describe('milestone commit attribution teardown', () => {
+    test('deleteMilestone removes persisted milestone commit attributions', () => {
+      openDatabase(':memory:');
+      insertMilestone({ id: 'M001', title: 'Milestone', status: 'active' });
+      recordMilestoneCommitAttribution({
+        commitSha: '0123456789abcdef0123456789abcdef01234567',
+        milestoneId: 'M001',
+        source: 'backfill',
+        confidence: 0.8,
+        files: ['app.js'],
+        createdAt: '2026-05-05T00:00:00.000Z',
+      });
+
+      assert.deepEqual(getMilestoneCommitAttributionShas('M001'), ['0123456789abcdef0123456789abcdef01234567']);
+      deleteMilestone('M001');
+      assert.deepEqual(getMilestoneCommitAttributionShas('M001'), []);
+      closeDatabase();
+    });
+
+    test('clearEngineHierarchy removes persisted milestone commit attributions', () => {
+      openDatabase(':memory:');
+      insertMilestone({ id: 'M001', title: 'Milestone', status: 'active' });
+      recordMilestoneCommitAttribution({
+        commitSha: 'fedcba9876543210fedcba9876543210fedcba98',
+        milestoneId: 'M001',
+        source: 'backfill',
+        confidence: 0.8,
+        files: ['app.js'],
+        createdAt: '2026-05-05T00:00:00.000Z',
+      });
+
+      assert.deepEqual(getMilestoneCommitAttributionShas('M001'), ['fedcba9876543210fedcba9876543210fedcba98']);
+      clearEngineHierarchy();
+      assert.deepEqual(getMilestoneCommitAttributionShas('M001'), []);
+      closeDatabase();
+    });
+  });
+
   // ─── getDbStatus ───────────────────────────────────────────────────────────
 
   describe('getDbStatus', () => {

package/src/resources/extensions/gsd/tests/guided-discuss-milestone-prompt-rendering.test.ts

@@ -0,0 +1,43 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the guided milestone discussion prompt renders its core interview and persistence contracts.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("guided milestone prompt renders compact interview and context guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-guided-milestone-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("guided-discuss-milestone", {
+    workingDirectory: process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd(),
+    milestoneId: "M001",
+    milestoneTitle: "Baseline And Safety",
+    structuredQuestionsAvailable: "true",
+    fastPathInstruction: "No fast path in this test.",
+    inlinedTemplates: "## Context\n\n## Decisions\n\n## Open Questions",
+    commitInstruction: "Do not commit during this test.",
+  });
+
+  assert.match(prompt, /M001 context written/);
+  assert.match(prompt, /Project Shape/);
+  assert.match(prompt, /default to `complex`/i);
+  assert.match(prompt, /3 or 4 concrete, researched options/);
+  assert.match(prompt, /"Other — let me discuss"/);
+  assert.match(prompt, /CONTEXT-DRAFT/);
+  assert.match(prompt, /Do NOT mention this save to the user/);
+  assert.match(prompt, /depth_verification_M001_confirm/);
+  assert.match(prompt, /artifact_type: "CONTEXT"/);
+  assert.match(prompt, /milestone_id: M001/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/guided-discuss-project-prompt-rendering.test.ts

@@ -0,0 +1,41 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the guided project discussion prompt renders its core interview and persistence contracts.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("guided project prompt renders compact interview and artifact guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-guided-project-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("guided-discuss-project", {
+    workingDirectory: process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd(),
+    structuredQuestionsAvailable: "true",
+    inlinedTemplates: "## Project\n\n## Project Shape\n\n## Capability Contract\n\n## Milestone Sequence",
+    commitInstruction: "Do not commit during this test.",
+  });
+
+  assert.match(prompt, /What do you want to build\?/);
+  assert.match(prompt, /Project shape: simple/);
+  assert.match(prompt, /Default to `complex` when uncertain/);
+  assert.match(prompt, /3 or 4 concrete, researched options/);
+  assert.match(prompt, /"Other — let me discuss"/);
+  assert.match(prompt, /depth_verification_project_confirm/);
+  assert.match(prompt, /artifact_type: "PROJECT"/);
+  assert.match(prompt, /omit `milestone_id`/);
+  assert.match(prompt, /Do NOT use `artifact_type: "CONTEXT"` and do NOT pass `milestone_id: "PROJECT"`/);
+  assert.match(prompt, /\*\*Complexity:\*\* simple/);
+  assert.match(prompt, /\*\*Complexity:\*\* complex/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/guided-discuss-requirements-prompt-rendering.test.ts

@@ -0,0 +1,45 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the guided requirements discussion prompt renders core requirements and persistence contracts.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("guided requirements prompt renders compact capability and persistence guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-guided-requirements-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("guided-discuss-requirements", {
+    workingDirectory: process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd(),
+    structuredQuestionsAvailable: "true",
+    inlinedTemplates: "## Active\n\n## Validated\n\n## Deferred\n\n## Out of Scope\n\n## Traceability\n\n## Coverage Summary",
+    commitInstruction: "Do not commit during this test.",
+  });
+
+  assert.match(prompt, /PROJECT\.md missing/);
+  assert.match(prompt, /Project Shape/);
+  assert.match(prompt, /R###/);
+  assert.match(prompt, /M###\/none yet/);
+  assert.match(prompt, /never bare `none yet`/);
+  assert.match(prompt, /3 or 4 concrete, researched options/);
+  assert.match(prompt, /"Other — let me discuss"/);
+  assert.match(prompt, /class-assignment and status questions are exempt/);
+  assert.match(prompt, /artifact_type: "REQUIREMENTS-DRAFT"/);
+  assert.match(prompt, /depth_verification_requirements_confirm/);
+  assert.match(prompt, /gsd_requirement_save/);
+  assert.match(prompt, /gsd_summary_save/);
+  assert.match(prompt, /artifact_type: "REQUIREMENTS"/);
+  assert.match(prompt, /Do NOT use `artifact_type: "CONTEXT"`/);
+  assert.match(prompt, /Requirements written\./);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/has-pending-deep-stage.test.ts

@@ -15,7 +15,7 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { randomUUID } from "node:crypto";
 
-import { hasPendingDeepStage } from "../auto-dispatch.ts";
+import { hasPendingDeepStage, shouldRunDeepProjectSetup } from "../auto-dispatch.ts";
 import type { GSDPreferences } from "../preferences.ts";
 import { loadEffectiveGSDPreferences } from "../preferences.ts";
 
@@ -57,6 +57,38 @@ test("hasPendingDeepStage: returns true in deep mode when nothing has been captu
   }
 });
 
+test("shouldRunDeepProjectSetup: complete state wins over pending deep setup", async () => {
+  const base = makeBase();
+  try {
+    assert.equal(hasPendingDeepStage(deepPrefs, base), true);
+    assert.equal(
+      shouldRunDeepProjectSetup({ phase: "complete" }, deepPrefs, base),
+      false,
+      "completed projects must not restart deep setup and loop through auto-mode",
+    );
+  } finally {
+    rmSync(base, { recursive: true, force: true });
+  }
+});
+
+test("shouldRunDeepProjectSetup: only setup phases can trigger pending deep setup", () => {
+  const base = makeBase();
+  try {
+    assert.equal(hasPendingDeepStage(deepPrefs, base), true);
+    assert.equal(shouldRunDeepProjectSetup({ phase: "pre-planning" }, deepPrefs, base), true);
+    assert.equal(shouldRunDeepProjectSetup({ phase: "needs-discussion" }, deepPrefs, base), true);
+    assert.equal(shouldRunDeepProjectSetup({ phase: "planning" }, deepPrefs, base), true);
+    assert.equal(shouldRunDeepProjectSetup({ phase: "executing" }, deepPrefs, base), false);
+    assert.equal(shouldRunDeepProjectSetup({ phase: "blocked" }, deepPrefs, base), false);
+    assert.equal(
+      shouldRunDeepProjectSetup({ phase: "pre-planning" }, deepPrefs, base, { hasSurvivorBranch: true }),
+      false,
+    );
+  } finally {
+    rmSync(base, { recursive: true, force: true });
+  }
+});
+
 test("hasPendingDeepStage: returns true in deep mode when only some gates pass", () => {
   // workflow-preferences captured but PROJECT.md still missing.
   const base = makeBase();