gsd-pi 2.79.0-dev.ece5fd8ba → 2.80.0-dev.0aaa4fc17

package/src/resources/extensions/gsd/tests/db-transaction.test.ts

@@ -0,0 +1,110 @@
+// Project/App: GSD-2
+// File Purpose: Tests for DB transaction depth and rollback helpers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createDbTransactionRunner, type DbTransactionControls } from "../db-transaction.ts";
+
+class FakeTransactionControls implements DbTransactionControls {
+  readonly calls: string[] = [];
+  failCall = new Set<string>();
+
+  begin(): void {
+    this.record("BEGIN");
+  }
+
+  beginRead(): void {
+    this.record("BEGIN DEFERRED");
+  }
+
+  commit(): void {
+    this.record("COMMIT");
+  }
+
+  rollback(): void {
+    this.record("ROLLBACK");
+  }
+
+  private record(call: string): void {
+    this.calls.push(call);
+    if (this.failCall.has(call)) throw new Error(`failed ${call}`);
+  }
+}
+
+describe("db-transaction", () => {
+  test("commits successful write transactions", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+
+    const result = runner.transaction(controls, () => {
+      assert.equal(runner.isInTransaction(), true);
+      return "ok";
+    });
+
+    assert.equal(result, "ok");
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN", "COMMIT"]);
+  });
+
+  test("rolls back failed write transactions and clears depth", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+
+    assert.throws(
+      () => runner.transaction(controls, () => {
+        throw new Error("boom");
+      }),
+      /boom/,
+    );
+
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN", "ROLLBACK"]);
+  });
+
+  test("nested transactions do not issue nested BEGIN or COMMIT", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+
+    runner.transaction(controls, () => {
+      runner.transaction(controls, () => {
+        assert.equal(runner.isInTransaction(), true);
+      });
+    });
+
+    assert.deepEqual(controls.calls, ["BEGIN", "COMMIT"]);
+  });
+
+  test("failed BEGIN does not mark transaction depth active", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+    controls.failCall.add("BEGIN");
+
+    assert.throws(() => runner.transaction(controls, () => undefined), /failed BEGIN/);
+
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN"]);
+  });
+
+  test("read transactions log rollback failures and clear depth", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+    const rollbackErrors: Error[] = [];
+    controls.failCall.add("ROLLBACK");
+
+    assert.throws(
+      () => runner.readTransaction(
+        controls,
+        () => {
+          throw new Error("read failed");
+        },
+        (error) => rollbackErrors.push(error),
+      ),
+      /read failed/,
+    );
+
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN DEFERRED", "ROLLBACK"]);
+    assert.equal(rollbackErrors.length, 1);
+    assert.match(rollbackErrors[0].message, /failed ROLLBACK/);
+  });
+});

package/src/resources/extensions/gsd/tests/db-verification-evidence-schema.test.ts

@@ -0,0 +1,76 @@
+// Project/App: GSD-2
+// File Purpose: Tests for verification evidence schema helpers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import {
+  dedupeVerificationEvidenceRows,
+  ensureVerificationEvidenceDedupIndex,
+} from "../db-verification-evidence-schema.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeStatement implements DbStatement {
+  private readonly row: Record<string, unknown> | undefined;
+
+  constructor(row: Record<string, unknown> | undefined) {
+    this.row = row;
+  }
+
+  run(): unknown {
+    return undefined;
+  }
+
+  get(): Record<string, unknown> | undefined {
+    return this.row;
+  }
+
+  all(): Record<string, unknown>[] {
+    return [];
+  }
+}
+
+class FakeAdapter implements DbAdapter {
+  readonly execCalls: string[] = [];
+  hasDedupIndex = false;
+
+  exec(sql: string): void {
+    this.execCalls.push(sql);
+  }
+
+  prepare(): DbStatement {
+    return new FakeStatement(this.hasDedupIndex ? { present: 1 } : undefined);
+  }
+
+  close(): void {}
+}
+
+describe("db-verification-evidence-schema", () => {
+  test("dedupeVerificationEvidenceRows keeps the first row for each evidence identity", () => {
+    const db = new FakeAdapter();
+
+    dedupeVerificationEvidenceRows(db);
+
+    assert.equal(db.execCalls.length, 1);
+    assert.match(db.execCalls[0], /DELETE FROM verification_evidence/);
+    assert.match(db.execCalls[0], /GROUP BY task_id, slice_id, milestone_id, command, verdict/);
+  });
+
+  test("ensureVerificationEvidenceDedupIndex dedupes before creating the unique index", () => {
+    const db = new FakeAdapter();
+
+    ensureVerificationEvidenceDedupIndex(db);
+
+    assert.equal(db.execCalls.length, 2);
+    assert.match(db.execCalls[0], /DELETE FROM verification_evidence/);
+    assert.match(db.execCalls[1], /CREATE UNIQUE INDEX IF NOT EXISTS idx_verification_evidence_dedup/);
+  });
+
+  test("ensureVerificationEvidenceDedupIndex no-ops when the index already exists", () => {
+    const db = new FakeAdapter();
+    db.hasDedupIndex = true;
+
+    ensureVerificationEvidenceDedupIndex(db);
+
+    assert.deepEqual(db.execCalls, []);
+  });
+});

package/src/resources/extensions/gsd/tests/detection.test.ts

@@ -11,12 +11,14 @@
 import test from "node:test";
 import assert from "node:assert/strict";
 import { mkdirSync, writeFileSync, rmSync, existsSync } from "node:fs";
+import { execFileSync } from "node:child_process";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 import {
   detectProjectState,
   detectV1Planning,
   detectProjectSignals,
+  classifyProject,
   scanProjectFiles,
 } from "../detection.ts";
 
@@ -37,6 +39,18 @@ function cleanup(dir: string): void {
   }
 }
 
+function git(dir: string, args: string[]): void {
+  execFileSync("git", args, { cwd: dir, stdio: "ignore" });
+}
+
+function makeGitRepo(prefix: string): string {
+  const dir = makeTempDir(prefix);
+  git(dir, ["init"]);
+  git(dir, ["config", "user.email", "test@example.com"]);
+  git(dir, ["config", "user.name", "Test User"]);
+  return dir;
+}
+
 // ─── detectProjectState ─────────────────────────────────────────────────────────
 
 test("detectProjectState: empty directory returns state=none", (t) => {
@@ -49,6 +63,132 @@ test("detectProjectState: empty directory returns state=none", (t) => {
   assert.equal(result.v2, undefined);
 });
 
+test("classifyProject: no git repo is invalid", (t) => {
+  const dir = makeTempDir("classify-invalid");
+  t.after(() => cleanup(dir));
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "invalid-repo");
+});
+
+test("classifyProject: empty git repo is greenfield", (t) => {
+  const dir = makeGitRepo("classify-greenfield");
+  t.after(() => cleanup(dir));
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "greenfield");
+});
+
+test("classifyProject: nested empty git repo does not inherit ancestor markers", (t) => {
+  const parent = makeGitRepo("classify-parent-marker");
+  t.after(() => cleanup(parent));
+
+  writeFileSync(join(parent, "package.json"), JSON.stringify({ name: "parent" }), "utf-8");
+  git(parent, ["add", "package.json"]);
+  git(parent, ["commit", "-m", "add parent marker"]);
+  const child = join(parent, "nested");
+  mkdirSync(child, { recursive: true });
+  git(child, ["init"]);
+  git(child, ["config", "user.email", "test@example.com"]);
+  git(child, ["config", "user.name", "Test User"]);
+
+  const classification = classifyProject(child);
+  assert.equal(classification.kind, "greenfield");
+});
+
+test("classifyProject: tracked static HTML is existing untyped content", (t) => {
+  const dir = makeGitRepo("classify-index");
+  t.after(() => cleanup(dir));
+
+  writeFileSync(join(dir, "index.html"), "<main></main>\n", "utf-8");
+  git(dir, ["add", "index.html"]);
+  git(dir, ["commit", "-m", "add static page"]);
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "untyped-existing");
+  assert.deepEqual(classification.contentFiles, ["index.html"]);
+});
+
+test("classifyProject: README-only repo is existing untyped content", (t) => {
+  const dir = makeGitRepo("classify-readme");
+  t.after(() => cleanup(dir));
+
+  writeFileSync(join(dir, "README.md"), "# docs\n", "utf-8");
+  git(dir, ["add", "README.md"]);
+  git(dir, ["commit", "-m", "add docs"]);
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "untyped-existing");
+});
+
+test("classifyProject: src-only content is untyped existing, not typed marker", (t) => {
+  const dir = makeGitRepo("classify-src-only");
+  t.after(() => cleanup(dir));
+
+  mkdirSync(join(dir, "src"), { recursive: true });
+  writeFileSync(join(dir, "src", "index.txt"), "content\n", "utf-8");
+  git(dir, ["add", "src/index.txt"]);
+  git(dir, ["commit", "-m", "add source content"]);
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "untyped-existing");
+  assert.deepEqual(classification.contentFiles, ["src/index.txt"]);
+});
+
+test("classifyProject: nested untracked files count as project content", (t) => {
+  const dir = makeGitRepo("classify-untracked-nested");
+  t.after(() => cleanup(dir));
+
+  mkdirSync(join(dir, "docs"), { recursive: true });
+  writeFileSync(join(dir, "docs", "index.html"), "<main></main>\n", "utf-8");
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "untyped-existing");
+  assert.deepEqual(classification.untrackedFiles, ["docs/index.html"]);
+});
+
+test("classifyProject: known markers produce typed existing project", (t) => {
+  const dir = makeGitRepo("classify-typed");
+  t.after(() => cleanup(dir));
+
+  writeFileSync(join(dir, "package.json"), JSON.stringify({ name: "typed" }), "utf-8");
+  git(dir, ["add", "package.json"]);
+  git(dir, ["commit", "-m", "add package"]);
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "typed-existing");
+  assert.ok(classification.markers.includes("package.json"));
+});
+
+test("classifyProject: ignored build/cache-only files do not count as content", (t) => {
+  const dir = makeGitRepo("classify-ignored");
+  t.after(() => cleanup(dir));
+
+  writeFileSync(join(dir, ".gitignore"), "dist/\n.cache/\n", "utf-8");
+  git(dir, ["add", ".gitignore"]);
+  git(dir, ["commit", "-m", "ignore generated files"]);
+  mkdirSync(join(dir, "dist"), { recursive: true });
+  writeFileSync(join(dir, "dist", "bundle.js"), "generated\n", "utf-8");
+  mkdirSync(join(dir, ".cache"), { recursive: true });
+  writeFileSync(join(dir, ".cache", "x"), "cache\n", "utf-8");
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "greenfield");
+});
+
+test("classifyProject: generated framework/cache dirs do not count as content", (t) => {
+  const dir = makeGitRepo("classify-generated-dirs");
+  t.after(() => cleanup(dir));
+
+  mkdirSync(join(dir, ".next", "server"), { recursive: true });
+  writeFileSync(join(dir, ".next", "server", "page.js"), "generated\n", "utf-8");
+  mkdirSync(join(dir, ".venv", "lib"), { recursive: true });
+  writeFileSync(join(dir, ".venv", "lib", "site.py"), "generated\n", "utf-8");
+
+  const classification = classifyProject(dir);
+  assert.equal(classification.kind, "greenfield");
+});
+
 test("detectProjectState: directory with .gsd/milestones/M001 returns v2-gsd", (t) => {
   const dir = makeTempDir("v2-gsd");
   t.after(() => cleanup(dir));

package/src/resources/extensions/gsd/tests/discuss-headless-rendering.test.ts

@@ -0,0 +1,37 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the headless discussion prompt renders compact required guidance.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("discuss-headless prompt renders compact investigation and audit guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-discuss-headless-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("discuss-headless", {
+    seedContext: "# Spec\n\nBuild the thing.",
+    milestoneId: "M001",
+    contextPath: ".gsd/milestones/M001/M001-CONTEXT.md",
+    commitInstruction: "Commit the created milestone artifacts.",
+    multiMilestoneCommitInstruction: "Commit the created milestone artifacts.",
+    inlinedTemplates: "## Template\n\nUse standard GSD artifacts.",
+  });
+
+  assert.match(prompt, /Investigate before making decisions:/);
+  assert.match(prompt, /Budget searches across investigation and focused research\./);
+  assert.match(prompt, /Resolve all of these from the spec and investigation before writing artifacts:/);
+  assert.match(prompt, /Print a structured depth summary in chat/);
+  assert.match(prompt, /Document every assumption in CONTEXT\.md/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/execute-task-rendering.test.ts

@@ -0,0 +1,59 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the execution prompt renders compact required guidance.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("execute-task prompt renders compact execution and completion gates", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-execute-task-render-"));
+  const fixtureRoot = process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd();
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("execute-task", {
+    taskId: "T01",
+    taskTitle: "Implement compact prompts",
+    sliceId: "S01",
+    sliceTitle: "Prompt reduction",
+    milestoneId: "M001",
+    workingDirectory: fixtureRoot,
+    overridesSection: "",
+    runtimeContext: "Runtime context.",
+    phaseAnchorSection: "",
+    resumeSection: "",
+    carryForwardSection: "",
+    taskPlanInline: "## Task Plan\n\n1. Edit prompt.",
+    slicePlanExcerpt: "## Slice Plan\n\nReduce prompt size.",
+    gatesToClose: "- Gate: prompt markers retained.",
+    planPath: ".gsd/milestones/M001/slices/S01/S01-PLAN.md",
+    taskPlanPath: ".gsd/milestones/M001/slices/S01/tasks/T01-PLAN.md",
+    priorTaskLines: "- None",
+    skillActivation: "Load relevant skills.",
+    templatesDir: join(fixtureRoot, "templates"),
+    taskSummaryTemplatePath: "C:\\Users\\Test\\.gsd\\agent\\extensions\\gsd\\templates\\task-summary.md",
+    verificationBudget: "~10K chars",
+    taskSummaryPath: ".gsd/milestones/M001/slices/S01/tasks/T01-SUMMARY.md",
+  });
+
+  assert.match(prompt, /You execute\./);
+  assert.match(prompt, /Call `memory_query`/);
+  assert.match(prompt, /Before any `Write` that creates an artifact or output file/);
+  assert.match(prompt, /Build real behavior/);
+  assert.match(prompt, /Background process rule/);
+  assert.match(prompt, /blocker_discovered: true/);
+  assert.match(prompt, /C:\\Users\\Test\\.gsd\\agent\\extensions\\gsd\\templates\\task-summary\.md/);
+  assert.doesNotMatch(prompt, /\{\{templatesDir\}\}\/task-summary\.md/);
+  assert.match(prompt, /Call `gsd_task_complete`/);
+  assert.match(prompt, /Do not run git commands/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/fixtures/pr-body/commands-ship-basic.md

@@ -0,0 +1,52 @@
+## TL;DR
+
+**What:** Ship milestone M001 - Authentication
+**Why:** Users need to authenticate before accessing protected resources.
+**How:** Added password hash check and session token issuance.
+
+## What
+
+### S01
+Implemented login flow.
+
+## Why
+
+Users need to authenticate before accessing protected resources.
+
+## How
+
+Added password hash check and session token issuance.
+
+## Linked Issue
+
+Closes #123
+
+## Roadmap
+
+- [x] **S01: Login**
+
+## Metrics
+
+- **Units executed:** 3
+
+## Tests Run
+
+- npm test
+- npm run typecheck:extensions
+
+## Change Type
+
+- [x] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [ ] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Revert the merge commit.
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/commands-ship-empty-optionals.md

@@ -0,0 +1,42 @@
+## TL;DR
+
+**What:** Ship milestone M001 - Authentication
+**Why:** Milestone work is complete and ready for review.
+**How:** Generated from GSD evidence and local workflow artifacts.
+
+## What
+
+Milestone M001 completed.
+
+## Why
+
+Milestone work is complete and ready for review.
+
+## How
+
+Generated from GSD evidence and local workflow artifacts.
+
+## Linked Issue
+
+Not specified. Add an issue link before marking this PR ready if CONTRIBUTING.md requires one.
+
+## Tests Run
+
+- Not specified. Add exact verification commands before requesting review.
+
+## Change Type
+
+- [x] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [ ] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- No behavior-changing rollback notes recorded.
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/swarm-lane-no-blockers.md

@@ -0,0 +1,55 @@
+## TL;DR
+
+**What:** Ship workflow lane/writer - lane/writer
+**Why:** Workflow work is complete and ready for review.
+**How:** Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## What
+
+### Swarm lane
+**Lane:** `lane/writer`
+**Branch:** `lane/single-writer`
+**Owner:** @owner
+**Latest commit:** `abc1234`
+
+### Impact area
+Single-writer UOK metadata.
+
+### Changed contracts
+- [ ] WriterToken
+
+### Transition risks
+- [ ] Writer token lifecycle regression
+
+## Why
+
+Workflow work is complete and ready for review.
+
+## How
+
+Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## Linked Issue
+
+Closes #123
+
+## Tests Run
+
+- npm run typecheck:extensions
+
+## Change Type
+
+- [ ] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [x] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Disable writer sequence enrichment
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/swarm-lane-with-blockers.md

@@ -0,0 +1,60 @@
+## TL;DR
+
+**What:** Ship workflow lane/writer - lane/writer
+**Why:** Workflow work is complete and ready for review.
+**How:** Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## What
+
+### Swarm lane
+**Lane:** `lane/writer`
+**Branch:** `lane/single-writer`
+**Owner:** @owner
+**Latest commit:** `abc1234`
+
+### Impact area
+Single-writer UOK metadata.
+
+### Changed contracts
+- [ ] WriterToken
+
+### Transition risks
+- [ ] Writer token lifecycle regression
+
+## Blockers
+
+- Awaiting state-lane writer-sequence merge
+- Parity report incomplete
+
+## Why
+
+Workflow work is complete and ready for review.
+
+## How
+
+Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## Linked Issue
+
+Closes #123
+
+## Tests Run
+
+- npm run typecheck:extensions
+
+## Change Type
+
+- [ ] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [x] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Disable writer sequence enrichment
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.