gsd-pi 2.78.1-dev.0fdacd524 → 2.78.1-dev.2d3fd6e71

package/src/resources/extensions/gsd/tests/teardown-cleanup-parity.test.ts

@@ -0,0 +1,102 @@
+/**
+ * GSD Auto-Worktree -- teardown-cleanup-parity.test.ts
+ *
+ * Regression test: teardownAutoWorktree (abort path) must call
+ * clearProjectRootStateFiles, removing STATE.md, auto.lock, and
+ * {MID}-META.json from the project root .gsd/ dir.
+ *
+ * Prior to the fix these files were left behind on disk after abort teardown.
+ */
+
+import { describe, test, beforeEach, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import {
+  mkdirSync,
+  mkdtempSync,
+  writeFileSync,
+  existsSync,
+  rmSync,
+  realpathSync,
+} from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { execFileSync } from "node:child_process";
+
+import { teardownAutoWorktree, _resetAutoWorktreeOriginalBaseForTests } from "../auto-worktree.ts";
+
+function git(args: string[], cwd: string): void {
+  execFileSync("git", args, { cwd, stdio: ["ignore", "pipe", "pipe"] });
+}
+
+function createTempRepo(): string {
+  const dir = realpathSync(mkdtempSync(join(tmpdir(), "gsd-teardown-parity-")));
+  git(["init"], dir);
+  git(["config", "user.email", "test@gsd.test"], dir);
+  git(["config", "user.name", "Test"], dir);
+  writeFileSync(join(dir, "README.md"), "# test\n");
+  git(["add", "README.md"], dir);
+  git(["commit", "-m", "init"], dir);
+  git(["branch", "-M", "main"], dir);
+  return dir;
+}
+
+describe("teardownAutoWorktree cleanup parity", () => {
+  let repoDir: string;
+
+  beforeEach(() => {
+    repoDir = createTempRepo();
+    _resetAutoWorktreeOriginalBaseForTests();
+  });
+
+  afterEach(() => {
+    rmSync(repoDir, { recursive: true, force: true });
+    _resetAutoWorktreeOriginalBaseForTests();
+  });
+
+  test("STATE.md, auto.lock, and M001-META.json are removed after abort teardown", () => {
+    const gsdDir = join(repoDir, ".gsd");
+    const milestonesDir = join(gsdDir, "milestones", "M001");
+    mkdirSync(milestonesDir, { recursive: true });
+
+    const stateMd = join(gsdDir, "STATE.md");
+    const autoLock = join(gsdDir, "auto.lock");
+    const metaJson = join(milestonesDir, "M001-META.json");
+
+    writeFileSync(stateMd, "# State\nactive\n");
+    writeFileSync(
+      autoLock,
+      JSON.stringify({ pid: process.pid, unitType: "plan-milestone", unitId: "M001" }),
+    );
+    writeFileSync(metaJson, JSON.stringify({ milestoneId: "M001" }));
+
+    assert.ok(existsSync(stateMd), "STATE.md exists before teardown");
+    assert.ok(existsSync(autoLock), "auto.lock exists before teardown");
+    assert.ok(existsSync(metaJson), "M001-META.json exists before teardown");
+
+    // teardownAutoWorktree may throw when git worktree removal fails
+    // (no actual worktree was created), but clearProjectRootStateFiles
+    // runs before removeWorktree so the state files must be gone regardless.
+    try {
+      teardownAutoWorktree(repoDir, "M001");
+    } catch {
+      // git teardown may fail in a minimal test repo — that is acceptable
+    }
+
+    assert.ok(!existsSync(stateMd), "STATE.md removed by teardownAutoWorktree");
+    assert.ok(!existsSync(autoLock), "auto.lock removed by teardownAutoWorktree");
+    assert.ok(!existsSync(metaJson), "M001-META.json removed by teardownAutoWorktree");
+  });
+
+  test("teardown is non-fatal when state files do not exist", () => {
+    // No state files created — teardown should not throw due to missing files
+    // (clearProjectRootStateFiles tolerates ENOENT).
+    try {
+      teardownAutoWorktree(repoDir, "M001");
+    } catch {
+      // git teardown may fail — acceptable
+    }
+
+    // Reaching here means clearProjectRootStateFiles did not throw for missing files.
+    assert.ok(true, "teardown with missing state files did not throw from clearProjectRootStateFiles");
+  });
+});

package/src/resources/extensions/gsd/tests/teardown-failure-clears-registry.test.ts

@@ -0,0 +1,186 @@
+// GSD-2 + Regression test: teardownAutoWorktree clears activeWorkspace even when removeWorktree fails
+
+/**
+ * Regression: `teardownAutoWorktree` must clear `activeWorkspace` (and therefore
+ * `getAutoWorktreeOriginalBase()` / `getActiveAutoWorktreeContext()`) in a `finally`
+ * block so the registry is reset to null even when `removeWorktree` throws (e.g. a
+ * Windows git failure).
+ *
+ * Prior to the fix, `setActiveWorkspace(null)` was called only AFTER `removeWorktree`
+ * returned normally.  A thrown error would skip it, leaving `activeWorkspace` stale
+ * and causing `getActiveAutoWorktreeContext()` to return wrong data for subsequent ops.
+ *
+ * Note on test strategy: `removeWorktree` is intentionally hardened to absorb git
+ * errors internally (all failure paths use logWarning rather than re-throwing).
+ * Forcing it to throw via the public API is therefore not straightforward.  Instead
+ * these tests verify:
+ *   1. The observable registry invariant on the success path (activeWorkspace = null
+ *      after teardown — the behaviour the finally block preserves).
+ *   2. A seeded-state scenario: workspace is set, then teardownAutoWorktree is invoked
+ *      on a path whose chdir target was deleted to force an early throw, confirming
+ *      that a throw from teardown leaves registry clearing behaviour consistent with
+ *      caller expectations (the finally block protects removeWorktree, so the early
+ *      throw here also resets via _resetAutoWorktreeOriginalBaseForTests in afterEach).
+ *   3. The preserveBranch variant to confirm the finally path works across call shapes.
+ */
+
+import { describe, test, beforeEach, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import {
+  mkdirSync,
+  mkdtempSync,
+  writeFileSync,
+  rmSync,
+  realpathSync,
+  existsSync,
+} from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { execFileSync } from "node:child_process";
+
+import {
+  createAutoWorktree,
+  teardownAutoWorktree,
+  getAutoWorktreeOriginalBase,
+  getActiveAutoWorktreeContext,
+  _resetAutoWorktreeOriginalBaseForTests,
+} from "../auto-worktree.ts";
+
+// ─── Helpers ─────────────────────────────────────────────────────────────────
+
+function git(args: string[], cwd: string): void {
+  execFileSync("git", args, { cwd, stdio: ["ignore", "pipe", "pipe"] });
+}
+
+function createTempRepo(): string {
+  const dir = realpathSync(mkdtempSync(join(tmpdir(), "gsd-teardown-registry-")));
+  git(["init"], dir);
+  git(["config", "user.email", "test@gsd.test"], dir);
+  git(["config", "user.name", "Test"], dir);
+  mkdirSync(join(dir, ".gsd"), { recursive: true });
+  writeFileSync(join(dir, "README.md"), "# test\n");
+  git(["add", "."], dir);
+  git(["commit", "-m", "init"], dir);
+  git(["branch", "-M", "main"], dir);
+  return dir;
+}
+
+function seedMilestone(repoDir: string, milestoneId: string): void {
+  const msDir = join(repoDir, ".gsd", "milestones", milestoneId);
+  mkdirSync(msDir, { recursive: true });
+  writeFileSync(join(msDir, "CONTEXT.md"), `# ${milestoneId} Context\n`);
+  git(["add", "."], repoDir);
+  git(["commit", "-m", `add ${milestoneId}`], repoDir);
+}
+
+// ─── Tests ───────────────────────────────────────────────────────────────────
+
+describe("teardown failure clears registry", () => {
+  const savedCwd = process.cwd();
+  let repoDir: string;
+
+  beforeEach(() => {
+    _resetAutoWorktreeOriginalBaseForTests();
+    process.chdir(savedCwd);
+  });
+
+  afterEach(() => {
+    _resetAutoWorktreeOriginalBaseForTests();
+    process.chdir(savedCwd);
+    if (repoDir && existsSync(repoDir)) {
+      rmSync(repoDir, { recursive: true, force: true });
+    }
+    repoDir = "";
+  });
+
+  // ── Success path ────────────────────────────────────────────────────────────
+
+  test("registry is null after successful teardown (success path)", () => {
+    repoDir = createTempRepo();
+    seedMilestone(repoDir, "M001");
+
+    // Baseline: registry is empty
+    assert.strictEqual(getAutoWorktreeOriginalBase(), null,
+      "originalBase is null before entering worktree");
+    assert.strictEqual(getActiveAutoWorktreeContext(), null,
+      "context is null before entering worktree");
+
+    // Create and enter the worktree — registry is now populated
+    createAutoWorktree(repoDir, "M001");
+
+    assert.strictEqual(getAutoWorktreeOriginalBase(), repoDir,
+      "originalBase equals repoDir after createAutoWorktree");
+    assert.notStrictEqual(getActiveAutoWorktreeContext(), null,
+      "context is non-null after createAutoWorktree");
+
+    // Teardown — finally block must clear registry regardless of removeWorktree outcome
+    teardownAutoWorktree(repoDir, "M001");
+
+    assert.strictEqual(getAutoWorktreeOriginalBase(), null,
+      "originalBase is null after successful teardown");
+    assert.strictEqual(getActiveAutoWorktreeContext(), null,
+      "context is null after successful teardown");
+  });
+
+  test("registry is null after teardown with preserveBranch:true", () => {
+    repoDir = createTempRepo();
+    seedMilestone(repoDir, "M002");
+
+    createAutoWorktree(repoDir, "M002");
+    assert.strictEqual(getAutoWorktreeOriginalBase(), repoDir,
+      "originalBase set after createAutoWorktree");
+
+    teardownAutoWorktree(repoDir, "M002", { preserveBranch: true });
+
+    assert.strictEqual(getAutoWorktreeOriginalBase(), null,
+      "originalBase is null after teardown with preserveBranch:true");
+    assert.strictEqual(getActiveAutoWorktreeContext(), null,
+      "context is null after teardown with preserveBranch:true");
+  });
+
+  // ── Finally-block guarantee ─────────────────────────────────────────────────
+
+  test("registry is null after teardown even when teardown throws (finally path)", () => {
+    // Seed workspace state via a real createAutoWorktree call.
+    repoDir = createTempRepo();
+    seedMilestone(repoDir, "M003");
+    createAutoWorktree(repoDir, "M003");
+
+    // Confirm the registry is populated before attempting the failing teardown.
+    assert.strictEqual(getAutoWorktreeOriginalBase(), repoDir,
+      "originalBase is set before the failing teardown");
+
+    // Tear down cleanly first so the worktree directory is gone from disk.
+    // Then call teardown again on the same ID: the registry was already cleared
+    // by the first call — this test verifies that the idempotent null assignment
+    // in finally does not cause any side-effects on a second call.
+    teardownAutoWorktree(repoDir, "M003");
+    assert.strictEqual(getAutoWorktreeOriginalBase(), null, "registry clear after first teardown");
+
+    // Re-seed by resetting to a state the teardownAutoWorktree call on a fully-torn-down
+    // worktree would exercise. On a minimal repo (worktree already removed), teardown
+    // has no worktree to clean but the finally block must still not throw.
+    // This verifies teardown is safe to call on a non-existent worktree (idempotent).
+    _resetAutoWorktreeOriginalBaseForTests();
+    // teardownAutoWorktree with a non-existent worktree: removeWorktree handles
+    // missing worktrees silently (via nativeWorktreePrune); finally still runs.
+    try {
+      teardownAutoWorktree(repoDir, "M003");
+    } catch {
+      // throw from chdir or git may occur — the important property is the registry
+    }
+
+    assert.strictEqual(getAutoWorktreeOriginalBase(), null,
+      "registry is null after teardown on already-removed worktree");
+    assert.strictEqual(getActiveAutoWorktreeContext(), null,
+      "context is null after teardown on already-removed worktree");
+  });
+
+  test("getAutoWorktreeOriginalBase returns null at baseline (sanity)", () => {
+    assert.strictEqual(getAutoWorktreeOriginalBase(), null);
+  });
+
+  test("getActiveAutoWorktreeContext returns null at baseline (sanity)", () => {
+    assert.strictEqual(getActiveAutoWorktreeContext(), null);
+  });
+});

package/src/resources/extensions/gsd/tests/token-counter.test.ts

@@ -20,6 +20,10 @@ describe("token-counter: getCharsPerToken", () => {
     assert.equal(getCharsPerToken("anthropic"), 3.5);
   });
 
+  it("returns 3.5 for claude-code", () => {
+    assert.equal(getCharsPerToken("claude-code"), 3.5);
+  });
+
   it("returns 4.0 for openai", () => {
     assert.equal(getCharsPerToken("openai"), 4.0);
   });
@@ -51,6 +55,11 @@ describe("token-counter: estimateTokensForProvider", () => {
     assert.equal(tokens, Math.ceil(1000 / 3.5));
   });
 
+  it("estimates tokens for claude-code using 3.5 chars/token ratio", () => {
+    const tokens = estimateTokensForProvider(sampleText, "claude-code");
+    assert.equal(tokens, Math.ceil(1000 / 3.5));
+  });
+
   it("estimates tokens for openai using 4.0 chars/token ratio", () => {
     const tokens = estimateTokensForProvider(sampleText, "openai");
     assert.equal(tokens, Math.ceil(1000 / 4.0));

package/src/resources/extensions/gsd/tests/tool-invocation-error-loop-break.test.ts

@@ -102,7 +102,7 @@ describe("#2883: isToolInvocationError classification", () => {
   });
 
   test("detects raw write-gate CONTEXT failures for non-GSD write tools", () => {
-    resetWriteGateState();
+    resetWriteGateState(process.cwd());
     const result = shouldBlockContextWrite(
       "write",
       "/tmp/project/.gsd/milestones/M001/M001-CONTEXT.md",

package/src/resources/extensions/gsd/tests/tool-param-optionality.test.ts

@@ -15,6 +15,9 @@ import { test } from "node:test";
 import assert from "node:assert/strict";
 import { registerDbTools } from "../bootstrap/db-tools.ts";
 import { Value } from "@sinclair/typebox/value";
+import AjvModule from "ajv";
+
+const Ajv = (AjvModule as any).default || AjvModule;
 
 // ─── Mock PI ──────────────────────────────────────────────────────────────────
 
@@ -47,6 +50,37 @@ function getOptionalProps(tool: any): string[] {
   return allProps.filter((p: string) => !required.has(p));
 }
 
+// ─── gsd_summary_save: OpenAI requires top-level object schema ──────────────
+
+test("gsd_summary_save — parameters are a top-level object schema", () => {
+  const tool = getTool("gsd_summary_save");
+  assert.ok(tool, "gsd_summary_save must be registered");
+
+  assert.strictEqual(tool.parameters.type, "object", "OpenAI function parameters require a top-level object schema");
+  assert.ok(!("anyOf" in tool.parameters), "top-level anyOf is rejected by OpenAI function schema validation");
+
+  const required = new Set(getRequiredProps(tool));
+  assert.ok(required.has("artifact_type"), "artifact_type must be required");
+  assert.ok(required.has("content"), "content must be required");
+  assert.ok(!required.has("milestone_id"), "milestone_id must remain optional for root artifacts");
+});
+
+test("gsd_summary_save — validates UAT assessment params", () => {
+  const tool = getTool("gsd_summary_save");
+  assert.ok(tool, "gsd_summary_save must be registered");
+
+  const ajv = new Ajv({ strict: false });
+  const validate = ajv.compile(tool.parameters);
+  const valid = validate({
+    milestone_id: "M001",
+    slice_id: "S01",
+    artifact_type: "ASSESSMENT",
+    content: "---\nverdict: PASS\n---\n# UAT Assessment\n",
+  });
+
+  assert.strictEqual(valid, true, `UAT assessment params should validate but got errors: ${JSON.stringify(validate.errors)}`);
+});
+
 // ─── gsd_slice_complete: enrichment arrays must be optional ──────────────────
 
 test("gsd_slice_complete — enrichment arrays are optional", () => {

package/src/resources/extensions/gsd/tests/unit-context-manifest.test.ts

@@ -15,6 +15,7 @@ import {
   type SkillsPolicy,
   type UnitContextManifest,
 } from "../unit-context-manifest.ts";
+import { ALLOWED_PLANNING_DISPATCH_AGENTS } from "../bootstrap/write-gate.ts";
 
 // ─── Coverage: every known unit type has a manifest ──────────────────────
 
@@ -231,6 +232,11 @@ test('planning-dispatch mode is reserved for slice-level decomposition and compl
     "refine-slice",
     "complete-slice",
     "complete-milestone",
+    // Deep planning mode: research-project orchestrates 4 parallel research
+    // subagents (stack/features/architecture/pitfalls). Subagent dispatch is
+    // the unit's core mechanism — without it, the unit cannot do its job.
+    "research-project",
+    "validate-milestone",
   ]);
   for (const [unitType, manifest] of Object.entries(UNIT_MANIFESTS)) {
     const mode = (manifest as { tools: { mode: string } }).tools.mode;
@@ -256,6 +262,10 @@ test('planning-dispatch manifests declare non-empty allowedSubagents lists', ()
         typeof agent === "string" && agent.length > 0,
         `manifest "${unitType}" has empty/invalid allowedSubagents entry: ${JSON.stringify(agent)}`,
       );
+      assert.ok(
+        ALLOWED_PLANNING_DISPATCH_AGENTS.has(agent),
+        `manifest "${unitType}" allows "${agent}", but the runtime planning-dispatch registry will hard-block it`,
+      );
     }
   }
 });

package/src/resources/extensions/gsd/tests/unit-runtime.test.ts

@@ -253,5 +253,46 @@ console.log("\n=== must-haves: substring matching (no backtick tokens) ===");
   assert.ok(diag.includes("2 of 3"), "mh-substr: diagnostic includes '2 of 3'");
 }
 
+console.log("\n=== per-record lock: stale .lock is reclaimed, list ignores .lock files ===");
+{
+  const { utimesSync, existsSync: lockExists } = await import("node:fs");
+  const { listUnitRuntimeRecords } = await import("../unit-runtime.ts");
+
+  // (1) Stale .lock should not block a new writer.
+  const lockBase = mkdtempSync(join(tmpdir(), "gsd-runtime-lock-test-"));
+  try {
+    const unitsDir = join(lockBase, ".gsd", "runtime", "units");
+    mkdirSync(unitsDir, { recursive: true });
+    const recordPath = join(unitsDir, "execute-task-M001-S01-T01.json");
+    const lockPath = recordPath + ".lock";
+    writeFileSync(lockPath, "");
+    const staleTime = new Date(Date.now() - 60_000);
+    utimesSync(lockPath, staleTime, staleTime);
+
+    const written = writeUnitRuntimeRecord(lockBase, "execute-task", "M001/S01/T01", 1000, { phase: "dispatched" });
+    assert.deepStrictEqual(written.phase, "dispatched", "stale-lock path should not block writers");
+
+    const readBack = readUnitRuntimeRecord(lockBase, "execute-task", "M001/S01/T01");
+    assert.ok(readBack !== null, "record persisted after stealing stale lock");
+    assert.equal(lockExists(lockPath), false, "lock file released after write completes");
+  } finally {
+    rmSync(lockBase, { recursive: true, force: true });
+  }
+
+  // (2) Orphaned .lock files must not be returned by listUnitRuntimeRecords.
+  const listBase = mkdtempSync(join(tmpdir(), "gsd-runtime-list-test-"));
+  try {
+    writeUnitRuntimeRecord(listBase, "execute-task", "M002/S01/T01", 1000, { phase: "dispatched" });
+    const unitsDir = join(listBase, ".gsd", "runtime", "units");
+    writeFileSync(join(unitsDir, "execute-task-M002-S01-T01.json.lock"), "");
+
+    const records = listUnitRuntimeRecords(listBase);
+    assert.equal(records.length, 1, "listUnitRuntimeRecords filters .lock files (only the .json record)");
+    assert.equal(records[0].unitId, "M002/S01/T01");
+  } finally {
+    rmSync(listBase, { recursive: true, force: true });
+  }
+}
+
 rmSync(mhBase, { recursive: true, force: true });
 rmSync(base, { recursive: true, force: true });

package/src/resources/extensions/gsd/tests/uok-plan-v2-wiring.test.ts

@@ -16,6 +16,7 @@ import type { GSDState, Phase } from "../types.ts";
 import {
   ensurePlanV2Graph,
   hasFinalizedMilestoneContext,
+  isEmptyPlanV2GraphResult,
   isMissingFinalizedContextResult,
 } from "../uok/plan-v2.ts";
 
@@ -113,6 +114,30 @@ test("guided flow routes recoverable missing finalized context to discuss-milest
   );
 });
 
+test("guided flow checks pending deep setup before plan-v2 gate", () => {
+  const source = readFileSync(join(gsdDir, "guided-flow.ts"), "utf-8");
+  const showSmartEntryIdx = source.indexOf("export async function showSmartEntry");
+  assert.notEqual(showSmartEntryIdx, -1);
+  const deepIdx = source.indexOf("hasPendingDeepStage(prefs, basePath)", showSmartEntryIdx);
+  const planIdx = source.indexOf("runPlanV2Gate(ctx, basePath, state)", showSmartEntryIdx);
+  assert.ok(
+    deepIdx > -1 && planIdx > -1 && deepIdx < planIdx,
+    "foreground deep setup must run before plan-v2 can fail-close guided /gsd",
+  );
+  assert.ok(
+    source.includes("loadEffectiveGSDPreferences(basePath)?.preferences"),
+    "guided plan-v2 gate must load preferences from the target project root",
+  );
+});
+
+test("auto pre-dispatch uses resolved plan-v2 defaults", () => {
+  const source = readFileSync(join(gsdDir, "auto", "phases.ts"), "utf-8");
+  assert.ok(
+    source.includes("uokFlags.planV2 && shouldRunPlanV2Gate(state.phase)"),
+    "auto-mode should honor resolveUokFlags defaults, not only explicit uok.plan_v2.enabled",
+  );
+});
+
 test("plan-v2 gate fails closed for execution phase when finalized context is missing", () => {
   const basePath = createBasePath();
   seedGraphRows();
@@ -204,4 +229,27 @@ test("plan-v2 ensure rejects empty executable graph", () => {
   const compiled = ensurePlanV2Graph(basePath, buildState("executing"));
   assert.equal(compiled.ok, false);
   assert.match(compiled.reason ?? "", /compiled graph is empty/i);
+  assert.equal(isEmptyPlanV2GraphResult(compiled), true);
+});
+
+test("plan-v2 allows empty graph for milestone terminal phases", () => {
+  const basePath = createBasePath();
+  writeMilestoneFile(basePath, "CONTEXT", "Finalized context.");
+
+  insertMilestone({ id: MILESTONE_ID, title: "Milestone", status: "active" });
+  insertSlice({
+    id: SLICE_ID,
+    milestoneId: MILESTONE_ID,
+    title: "Slice",
+    status: "complete",
+    sequence: 1,
+  });
+
+  const validating = ensurePlanV2Graph(basePath, buildState("validating-milestone"));
+  assert.equal(validating.ok, true);
+  assert.equal(validating.nodeCount, 0);
+
+  const completing = ensurePlanV2Graph(basePath, buildState("completing-milestone"));
+  assert.equal(completing.ok, true);
+  assert.equal(completing.nodeCount, 0);
 });

package/src/resources/extensions/gsd/tests/validate-milestone-write-order.test.ts

@@ -85,7 +85,7 @@ describe("handleValidateMilestone write ordering (#2725)", () => {
     assert.doesNotMatch(validationMd, /## Verification Class Compliance/);
   });
 
-  it("rolls back DB row when disk write fails", async () => {
+  it("keeps DB row and reports stale projection when disk write fails", async () => {
     base = makeTmpBase();
     const dbPath = join(base, ".gsd", "gsd.db");
     openDatabase(dbPath);
@@ -101,16 +101,15 @@ describe("handleValidateMilestone write ordering (#2725)", () => {
 
     const result = await handleValidateMilestone(VALID_PARAMS, base);
 
-    // Should return error
-    assert.ok("error" in result, "should return error when disk write fails");
-    assert.ok(result.error.includes("disk render failed"));
+    assert.ok(!("error" in result), `unexpected error: ${"error" in result ? result.error : ""}`);
+    assert.equal(result.stale, true, "result should report stale projection");
 
-    // DB row should have been rolled back (deleted)
     const adapter = _getAdapter()!;
     const row = adapter.prepare(
-      `SELECT * FROM assessments WHERE milestone_id = 'M001' AND scope = 'milestone-validation'`,
-    ).get();
-    assert.equal(row, undefined, "assessment row should be deleted after disk-write rollback");
+      `SELECT status FROM assessments WHERE milestone_id = 'M001' AND scope = 'milestone-validation'`,
+    ).get() as { status: string } | undefined;
+    assert.ok(row, "assessment row should remain committed");
+    assert.equal(row!.status, "pass");
   });
 
   it("persists milestone validation gate_runs rows when UOK gates are enabled", async () => {

package/src/resources/extensions/gsd/tests/validate-milestone.test.ts

@@ -394,7 +394,7 @@ test("dispatch rule skips when skip_milestone_validation preference is set", asy
   }
 });
 
-test("dispatch rule fails closed for failure-path SUMMARY when DB milestone is not complete (#4658)", async () => {
+test("dispatch rule ignores failure-path SUMMARY projection when DB milestone is not complete (#4658 superseded)", async () => {
   const state: GSDState = {
     activeMilestone: { id: "M001", title: "Test" },
     activeSlice: null,
@@ -422,17 +422,14 @@ test("dispatch rule fails closed for failure-path SUMMARY when DB milestone is n
       prefs: undefined,
     };
     const result = await resolveDispatch(ctx);
-    assert.equal(result.action, "stop");
-    if (result.action === "stop") {
-      assert.equal(result.level, "warning");
-      assert.match(result.reason, /failure-path SUMMARY/i);
-    }
+    assert.equal(result.action, "dispatch");
+    assert.equal(getMilestone("M001")?.status, "active");
   } finally {
     cleanup(base);
   }
 });
 
-test("dispatch rule reconciles DB for successful stale SUMMARY (#4658)", async () => {
+test("dispatch rule does not reconcile DB from successful stale SUMMARY projection (#4658 superseded)", async () => {
   const state: GSDState = {
     activeMilestone: { id: "M001", title: "Test" },
     activeSlice: null,
@@ -473,15 +470,15 @@ test("dispatch rule reconciles DB for successful stale SUMMARY (#4658)", async (
       prefs: undefined,
     };
     const result = await resolveDispatch(ctx);
-    assert.equal(result.action, "skip");
+    assert.equal(result.action, "dispatch");
     const milestone = getMilestone("M001");
-    assert.equal(milestone?.status, "complete");
+    assert.equal(milestone?.status, "active");
   } finally {
     cleanup(base);
   }
 });
 
-test("dispatch rule fails closed for ambiguous stale SUMMARY (#4658)", async () => {
+test("dispatch rule ignores ambiguous stale SUMMARY projection (#4658 superseded)", async () => {
   const state: GSDState = {
     activeMilestone: { id: "M001", title: "Test" },
     activeSlice: null,
@@ -509,11 +506,8 @@ test("dispatch rule fails closed for ambiguous stale SUMMARY (#4658)", async ()
       prefs: undefined,
     };
     const result = await resolveDispatch(ctx);
-    assert.equal(result.action, "stop");
-    if (result.action === "stop") {
-      assert.equal(result.level, "warning");
-      assert.match(result.reason, /ambiguous SUMMARY/i);
-    }
+    assert.equal(result.action, "dispatch");
+    assert.equal(getMilestone("M001")?.status, "active");
   } finally {
     cleanup(base);
   }