gsd-pi 2.78.0-dev.aeeb2ca00 → 2.78.1-dev.84a383f51

package/src/resources/extensions/gsd/tests/false-degraded-mode-warning.test.ts

@@ -1,104 +1,43 @@
 /**
- * false-degraded-mode-warning.test.ts — Regression tests for #3922.
+ * Behavioural regression tests for #3922.
  *
- * Before this fix, deriveState() logged a "DB unavailable — degraded mode"
- * warning even when the DB simply hadn't been opened yet (e.g. during
- * before_agent_start context injection). The fix introduces wasDbOpenAttempted()
- * to distinguish "not yet initialized" from "genuinely unavailable."
+ * Before this fix, deriveState() logged "DB unavailable — degraded mode"
+ * even when the DB had not been opened yet (e.g. during
+ * before_agent_start context injection). The fix introduced
+ * wasDbOpenAttempted() so the warning fires only after a real open attempt.
  *
- * Two aspects:
- * 1. gsd-db: wasDbOpenAttempted() tracks whether openDatabase() was ever called.
- * 2. state: the degraded-mode warning is gated behind wasDbOpenAttempted().
+ * The earlier tests source-grepped state.ts for the warning string and the
+ * preceding line (POSITIONAL/SOURCE_GREP per #4826/#4829). They are
+ * replaced here with direct calls to the wasDbOpenAttempted flag.
  */
 
-import { describe, test } from "node:test";
+import { describe, test, beforeEach, afterEach } from "node:test";
 import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { dirname, join } from "node:path";
-import { fileURLToPath } from "node:url";
 import {
   openDatabase,
   closeDatabase,
-  isDbAvailable,
   wasDbOpenAttempted,
 } from "../gsd-db.ts";
 
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const stateSource = readFileSync(join(__dirname, "..", "state.ts"), "utf-8");
-
-// ═══════════════════════════════════════════════════════════════════════════
-// 1. gsd-db: wasDbOpenAttempted flag
-// ═══════════════════════════════════════════════════════════════════════════
-
 describe("wasDbOpenAttempted (#3922)", () => {
+  beforeEach(() => { closeDatabase(); });
+  afterEach(() => { closeDatabase(); });
 
-  test("wasDbOpenAttempted returns true after openDatabase is called", () => {
-    // By this point in the test suite, openDatabase may or may not have been
-    // called by other tests. So we call it explicitly and verify it returns true.
+  test("returns true after a successful openDatabase call", () => {
     openDatabase(":memory:");
-    assert.strictEqual(wasDbOpenAttempted(), true,
-      "wasDbOpenAttempted should be true after openDatabase call");
-    closeDatabase();
-  });
-
-  test("openDatabase sets the flag even if it fails on invalid path", () => {
-    // openDatabase with an unreachable path may fail, but the flag should
-    // still be set because the attempt was made.
-    try { openDatabase("/nonexistent/path/that/will/fail.db"); } catch { /* expected */ }
-    assert.strictEqual(wasDbOpenAttempted(), true,
-      "wasDbOpenAttempted should be true even after a failed open attempt");
-  });
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// 2. state.ts: degraded-mode warning is gated behind wasDbOpenAttempted
-// ═══════════════════════════════════════════════════════════════════════════
-
-describe("degraded-mode warning guard (#3922)", () => {
-
-  test("state.ts imports wasDbOpenAttempted from gsd-db", () => {
-    assert.ok(
-      stateSource.includes("wasDbOpenAttempted"),
-      "state.ts must import wasDbOpenAttempted to gate the degraded-mode warning",
+    assert.strictEqual(
+      wasDbOpenAttempted(),
+      true,
+      "wasDbOpenAttempted should report true after openDatabase succeeds",
     );
   });
 
-  test("degraded-mode warning is inside a wasDbOpenAttempted() guard", () => {
-    // Find the degraded-mode warning string
-    const warningStr = 'DB unavailable — using filesystem state derivation (degraded mode)';
-    const warningIdx = stateSource.indexOf(warningStr);
-    assert.ok(warningIdx > 0, "degraded-mode warning string must exist in state.ts");
-
-    // The wasDbOpenAttempted() check must appear BEFORE the warning,
-    // within the same else-branch (i.e. within a reasonable distance).
-    // Look backwards from the warning for the guard.
-    const searchWindow = stateSource.slice(Math.max(0, warningIdx - 300), warningIdx);
-    assert.ok(
-      searchWindow.includes("wasDbOpenAttempted()"),
-      "wasDbOpenAttempted() guard must appear shortly before the degraded-mode warning " +
-      "to prevent false warnings when DB has not been initialized yet",
+  test("remains true after a failed open attempt — the attempt is what matters", () => {
+    try { openDatabase("/nonexistent/path/that/will/fail.db"); } catch { /* expected */ }
+    assert.strictEqual(
+      wasDbOpenAttempted(),
+      true,
+      "wasDbOpenAttempted should be true even when openDatabase throws — the warning gate keys on the attempt, not the outcome",
     );
   });
-
-  test("warning is NOT emitted unconditionally in the else branch", () => {
-    // The old code had `logWarning(...)` directly in the else branch.
-    // The fix wraps it in `if (wasDbOpenAttempted())`.
-    // Verify the logWarning call is inside a conditional, not bare.
-    const lines = stateSource.split("\n");
-    for (let i = 0; i < lines.length; i++) {
-      if (lines[i]!.includes("DB unavailable") && lines[i]!.includes("degraded mode")) {
-        // This line has the warning. Check that the preceding non-empty line
-        // contains an if-condition (wasDbOpenAttempted), not a bare else.
-        let prev = i - 1;
-        while (prev >= 0 && lines[prev]!.trim() === "") prev--;
-        const prevLine = lines[prev]!.trim();
-        assert.ok(
-          prevLine.includes("wasDbOpenAttempted"),
-          `Line ${i + 1} emits degraded-mode warning — preceding line ${prev + 1} must ` +
-          `contain wasDbOpenAttempted guard, but found: "${prevLine}"`,
-        );
-        break;
-      }
-    }
-  });
 });

package/src/resources/extensions/gsd/tests/finalize-timeout-guard.test.ts

@@ -17,12 +17,7 @@
  */
 
 import { createTestContext } from "./test-helpers.ts";
-import {
-  withTimeout,
-  FINALIZE_PRE_TIMEOUT_MS,
-  FINALIZE_POST_TIMEOUT_MS,
-} from "../auto/finalize-timeout.ts";
-import { MAX_FINALIZE_TIMEOUTS } from "../auto/types.ts";
+import { withTimeout } from "../auto/finalize-timeout.ts";
 
 const { assertTrue, assertEq, report } = createTestContext();
 
@@ -80,44 +75,6 @@ const { assertTrue, assertEq, report } = createTestContext();
   assertTrue(caught, "rejection should propagate");
 }
 
-// ═══ Test: FINALIZE_PRE_TIMEOUT_MS is defined and reasonable ═════════════════
-
-{
-  console.log("\n=== #3757: pre-verification timeout constant is defined and reasonable ===");
-
-  assertTrue(
-    typeof FINALIZE_PRE_TIMEOUT_MS === "number",
-    "FINALIZE_PRE_TIMEOUT_MS should be a number",
-  );
-  assertTrue(
-    FINALIZE_PRE_TIMEOUT_MS >= 30_000,
-    `pre timeout should be >= 30s (got ${FINALIZE_PRE_TIMEOUT_MS}ms)`,
-  );
-  assertTrue(
-    FINALIZE_PRE_TIMEOUT_MS <= 120_000,
-    `pre timeout should be <= 120s (got ${FINALIZE_PRE_TIMEOUT_MS}ms)`,
-  );
-}
-
-// ═══ Test: FINALIZE_POST_TIMEOUT_MS is defined and reasonable ═════════════════
-
-{
-  console.log("\n=== #2344: timeout constant is defined and reasonable ===");
-
-  assertTrue(
-    typeof FINALIZE_POST_TIMEOUT_MS === "number",
-    "FINALIZE_POST_TIMEOUT_MS should be a number",
-  );
-  assertTrue(
-    FINALIZE_POST_TIMEOUT_MS >= 30_000,
-    `timeout should be >= 30s (got ${FINALIZE_POST_TIMEOUT_MS}ms)`,
-  );
-  assertTrue(
-    FINALIZE_POST_TIMEOUT_MS <= 120_000,
-    `timeout should be <= 120s (got ${FINALIZE_POST_TIMEOUT_MS}ms)`,
-  );
-}
-
 // ═══ Test: withTimeout cleans up timer on success ════════════════════════════
 
 {
@@ -134,25 +91,6 @@ const { assertTrue, assertEq, report } = createTestContext();
   assertEq(result.timedOut, false, "should not time out");
 }
 
-// ═══ Test: MAX_FINALIZE_TIMEOUTS is defined and reasonable ═══════════════════
-
-{
-  console.log("\n=== #3757: MAX_FINALIZE_TIMEOUTS is defined and reasonable ===");
-
-  assertTrue(
-    typeof MAX_FINALIZE_TIMEOUTS === "number",
-    "MAX_FINALIZE_TIMEOUTS should be a number",
-  );
-  assertTrue(
-    MAX_FINALIZE_TIMEOUTS >= 2,
-    `threshold should be >= 2 (got ${MAX_FINALIZE_TIMEOUTS})`,
-  );
-  assertTrue(
-    MAX_FINALIZE_TIMEOUTS <= 10,
-    `threshold should be <= 10 (got ${MAX_FINALIZE_TIMEOUTS})`,
-  );
-}
-
 // Note: the two previous source-grep blocks that scanned phases.ts for
 // `withTimeout(` / `failClosedOnFinalizeTimeout(` occurrences were removed
 // under #4825 — they encoded implementation shape (Goodhart) and broke on

package/src/resources/extensions/gsd/tests/find-missing-summaries-closed-runtime.test.ts

@@ -0,0 +1,47 @@
+/**
+ * Runtime regression — closed-status omission for missing-summary detection
+ * (#4902).
+ *
+ * `findMissingSummaries` (auto-dispatch.ts) filters out slices in any closed
+ * status before checking for an on-disk SUMMARY. The deleted source-grep
+ * test asserted the literal `CLOSED_STATUSES` Set; this rewrite tests the
+ * exported predicate (`isClosedStatus`) that the inline Set replicates,
+ * so any drift between the predicate and the inline filter surfaces as a
+ * test failure here rather than a runtime miss.
+ */
+
+import { describe, test } from 'node:test';
+import assert from 'node:assert/strict';
+
+import { isClosedStatus, isInactiveStatus } from '../status-guards.ts';
+
+describe('isClosedStatus — closed-status omission contract (#4902)', () => {
+  test('returns true for every status findMissingSummaries skips', () => {
+    // Mirror the inline Set in auto-dispatch.ts:findMissingSummaries.
+    for (const s of ['complete', 'done', 'skipped']) {
+      assert.equal(
+        isClosedStatus(s),
+        true,
+        `${s} must count as a closed status (would-have-summary omission)`,
+      );
+    }
+  });
+
+  test('returns false for live in-flight statuses', () => {
+    for (const s of ['pending', 'active', 'in-progress', 'planning', 'executing']) {
+      assert.equal(
+        isClosedStatus(s),
+        false,
+        `${s} is in-flight and MUST be checked for a missing SUMMARY`,
+      );
+    }
+  });
+
+  test('isInactiveStatus also covers deferred so it is not summary-checked', () => {
+    // Deferred slices likewise never produce a SUMMARY; the active-slice
+    // selector uses isInactiveStatus to skip them. Pin the contract.
+    assert.equal(isInactiveStatus('deferred'), true);
+    assert.equal(isInactiveStatus('complete'), true);
+    assert.equal(isInactiveStatus('pending'), false);
+  });
+});

package/src/resources/extensions/gsd/tests/forensics-stuck-loops.test.ts

@@ -9,7 +9,8 @@
 import test from "node:test";
 import assert from "node:assert/strict";
 import type { UnitMetrics } from "../metrics.js";
-import { detectStuckLoops, type ForensicAnomaly } from "../forensics.js";
+import type { WorktreeTelemetrySummary } from "../worktree-telemetry.js";
+import { detectStuckLoops, detectWorktreeOrphans, type ForensicAnomaly } from "../forensics.js";
 
 // ── Helpers ──────────────────────────────────────────────────────────────────
 
@@ -163,3 +164,27 @@ test("#3760 detectStuckLoops still flags repeated dispatches within one auto ses
     `details should explain the session-aware rule: ${anomalies[0].details}`,
   );
 });
+
+test("#4711 detectWorktreeOrphans suggests doctor fix for completed unmerged branches", () => {
+  const anomalies: ForensicAnomaly[] = [];
+  const summary: WorktreeTelemetrySummary = {
+    worktreesCreated: 0,
+    worktreesMerged: 0,
+    orphansDetected: 1,
+    orphansByReason: { "complete-unmerged": 1 },
+    mergeDurationsMs: [],
+    mergeConflicts: 0,
+    exitsByReason: {},
+    exitsWithUnmergedWork: 0,
+    canonicalRedirects: 0,
+    slicesMerged: 0,
+    sliceMergeConflicts: 0,
+    milestoneResquashes: 0,
+  };
+
+  detectWorktreeOrphans(summary, anomalies);
+
+  assert.equal(anomalies.length, 1);
+  assert.match(anomalies[0]!.details, /\/gsd doctor fix/);
+  assert.doesNotMatch(anomalies[0]!.details, /\/gsd health --fix/);
+});

package/src/resources/extensions/gsd/tests/gitignore-bg-shell-runtime.test.ts

@@ -0,0 +1,63 @@
+/**
+ * Runtime regression — `.bg-shell/` baseline pattern (#4902, prior #2655).
+ *
+ * The deleted `gitignore-bg-shell.test.ts` asserted `.bg-shell/` appeared in
+ * the BASELINE_PATTERNS array via source grep. This rewrite drives
+ * `ensureGitignore()` against a tmp directory and asserts the written
+ * `.gitignore` actually contains the `.bg-shell/` pattern — i.e. tests the
+ * behaviour the constant exists to guarantee, not the spelling of the
+ * constant.
+ */
+
+import { describe, test } from 'node:test';
+import assert from 'node:assert/strict';
+import * as fs from 'node:fs';
+import * as os from 'node:os';
+import * as path from 'node:path';
+
+import { ensureGitignore } from '../gitignore.ts';
+
+function makeTmpRepo(): string {
+  return fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-gitignore-bg-'));
+}
+
+function cleanup(dir: string): void {
+  try { fs.rmSync(dir, { recursive: true, force: true }); } catch { /* swallow */ }
+}
+
+describe('ensureGitignore writes .bg-shell/ baseline (#4902)', () => {
+  test('appends .bg-shell/ to a fresh project .gitignore', () => {
+    const dir = makeTmpRepo();
+    try {
+      const wrote = ensureGitignore(dir);
+      assert.equal(wrote, true, 'ensureGitignore should report it wrote');
+
+      const ignore = fs.readFileSync(path.join(dir, '.gitignore'), 'utf-8');
+      const lines = new Set(
+        ignore.split('\n').map((l) => l.trim()).filter(Boolean),
+      );
+      assert.ok(
+        lines.has('.bg-shell/'),
+        `.gitignore should include .bg-shell/. Got:\n${ignore}`,
+      );
+    } finally {
+      cleanup(dir);
+    }
+  });
+
+  test('preserves .bg-shell/ when it is already present (idempotent)', () => {
+    const dir = makeTmpRepo();
+    try {
+      fs.writeFileSync(
+        path.join(dir, '.gitignore'),
+        '.bg-shell/\nnode_modules/\n',
+      );
+      ensureGitignore(dir); // run once to fill missing baseline
+      const ignore = fs.readFileSync(path.join(dir, '.gitignore'), 'utf-8');
+      const occurrences = ignore.split('\n').filter((l) => l.trim() === '.bg-shell/').length;
+      assert.equal(occurrences, 1, 'should not duplicate an existing .bg-shell/ entry');
+    } finally {
+      cleanup(dir);
+    }
+  });
+});

package/src/resources/extensions/gsd/tests/gsd-db.test.ts

@@ -18,6 +18,8 @@ import {
   getActiveDecisions,
   getActiveRequirements,
   transaction,
+  readTransaction,
+  isInTransaction,
   _getAdapter,
   _resetProvider,
   insertMilestone,
@@ -383,6 +385,34 @@ describe('gsd-db', () => {
     closeDatabase();
   });
 
+  test('gsd-db: failed BEGIN does not poison transaction depth', () => {
+    openDatabase(':memory:');
+    const adapter = _getAdapter()!;
+
+    const assertFailedBeginLeavesDepthClear = (label: string, fn: () => void) => {
+      adapter.exec('BEGIN');
+      try {
+        let threw = false;
+        try {
+          fn();
+        } catch {
+          threw = true;
+        }
+        assert.equal(threw, true, `${label} should surface the SQLite BEGIN failure`);
+        assert.equal(isInTransaction(), false, `${label} failed BEGIN must not leave depth active`);
+      } finally {
+        adapter.exec('ROLLBACK');
+      }
+    };
+
+    try {
+      assertFailedBeginLeavesDepthClear('transaction', () => transaction(() => undefined));
+      assertFailedBeginLeavesDepthClear('readTransaction', () => readTransaction(() => undefined));
+    } finally {
+      closeDatabase();
+    }
+  });
+
   test('gsd-db: recreates missing verification evidence dedup index after removing duplicate rows', () => {
     const dbPath = tempDbPath();
     openDatabase(dbPath);

package/src/resources/extensions/gsd/tests/gsd-no-project-error-runtime.test.ts

@@ -0,0 +1,81 @@
+/**
+ * Runtime regression — `projectRoot()` throws `GSDNoProjectError` when
+ * invoked outside a project directory (#4902).
+ *
+ * The deleted `gsd-no-project-error.test.ts` was a source-grep check.
+ * This rewrite chdirs to $HOME, calls the real `projectRoot()`, and
+ * asserts a `GSDNoProjectError` is thrown with the project-required
+ * message.
+ */
+
+import { describe, test, after } from 'node:test';
+import assert from 'node:assert/strict';
+import * as os from 'node:os';
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+
+import { projectRoot, GSDNoProjectError } from '../commands/context.ts';
+
+const ORIGINAL_CWD = process.cwd();
+
+after(() => {
+  try { process.chdir(ORIGINAL_CWD); } catch { /* swallow */ }
+});
+
+describe('projectRoot() throws GSDNoProjectError outside a project (#4902)', () => {
+  test('throws GSDNoProjectError when cwd is $HOME', () => {
+    const home = os.homedir();
+    process.chdir(home);
+    try {
+      assert.throws(
+        () => projectRoot(),
+        (err: unknown) => {
+          assert.ok(err instanceof GSDNoProjectError, 'should throw GSDNoProjectError');
+          assert.match(
+            (err as Error).message,
+            /home directory|project directory/i,
+            'error message should mention home/project directory',
+          );
+          return true;
+        },
+      );
+    } finally {
+      process.chdir(ORIGINAL_CWD);
+    }
+  });
+
+  test('throws GSDNoProjectError when cwd is the system tmpdir root', () => {
+    // Use realpath to dodge symlinks blocking the cwd
+    const tmpRoot = fs.realpathSync(os.tmpdir());
+    // Some systems make tmpdir a subdirectory; only run when it normalizes
+    // to a known-blocked root. validateDirectory blocks /tmp + /var/folders
+    // tmp roots; build a small subdir under tmp and then assert that the
+    // raw tmpdir root itself blocks. We just use it directly.
+    process.chdir(tmpRoot);
+    try {
+      // Behaviour: either we get a GSDNoProjectError (blocked tmpdir root) or
+      // we don't — but in the case where we don't (tmpdir is somehow allowed
+      // as a project root on this machine), the test is vacuously satisfied
+      // by the prior $HOME case. We assert the type-narrowing path instead:
+      let threw: unknown = null;
+      try { projectRoot(); } catch (err) { threw = err; }
+      if (threw !== null) {
+        assert.ok(
+          threw instanceof GSDNoProjectError,
+          'if projectRoot throws, it must be a GSDNoProjectError (typed)',
+        );
+      }
+    } finally {
+      process.chdir(ORIGINAL_CWD);
+    }
+  });
+});
+
+describe('GSDNoProjectError shape (#4902)', () => {
+  test('GSDNoProjectError extends Error and carries its name', () => {
+    const err = new GSDNoProjectError('test reason');
+    assert.ok(err instanceof Error);
+    assert.equal(err.name, 'GSDNoProjectError');
+    assert.equal(err.message, 'test reason');
+  });
+});

package/src/resources/extensions/gsd/tests/headless-answers.test.ts

@@ -6,7 +6,7 @@
  * secrets, stats, and unused warnings).
  */
 
-import test from 'node:test';
+import test, { mock } from 'node:test';
 import assert from 'node:assert/strict';
 import { mkdirSync, writeFileSync, rmSync } from 'node:fs';
 import { join } from 'node:path';
@@ -164,7 +164,15 @@ test('tryHandle matches by question ID — single select', (t) => {
   assert.strictEqual(injector.getStats().questionsAnswered, 1);
 });
 
-test('tryHandle unknown question deferred — first_option timeout', async (t) => {
+test('tryHandle unknown question deferred — first_option timeout', (t) => {
+  // Use Node's MockTimers instead of a real-time setTimeout race. The
+  // production class schedules an internal setTimeout to default the
+  // answer when no metadata arrives — driving virtual time advances that
+  // timer deterministically, regardless of the literal ms value the
+  // production code chose.
+  mock.timers.enable({ apis: ['setTimeout'] });
+  t.after(() => { mock.timers.reset(); });
+
   const injector = new AnswerInjector({ defaults: { strategy: 'first_option' } });
 
   const captured: string[] = [];
@@ -177,8 +185,10 @@ test('tryHandle unknown question deferred — first_option timeout', async (t) =
   assert.strictEqual(handled, true);
   assert.strictEqual(captured.length, 0, 'nothing sent immediately');
 
-  // Wait for the 500ms deferred timeout to fire
-  await new Promise((resolve) => setTimeout(resolve, 600));
+  // Advance virtual time past any internal defer timeout (well above any
+  // reasonable defer cap). MockTimers fires synchronously, so by the time
+  // tick() returns the deferred handler has run.
+  mock.timers.tick(60_000);
 
   assert.strictEqual(captured.length, 1);
   const response = JSON.parse(captured[0].trim());

package/src/resources/extensions/gsd/tests/health-widget.test.ts

@@ -66,16 +66,22 @@ test("detectHealthWidgetProjectState: milestone without metrics returns active",
   assert.equal(detectHealthWidgetProjectState(dir), "active");
 });
 
-test("buildHealthLines: none state shows onboarding copy", (t) => {
-  assert.deepEqual(buildHealthLines(activeData({ projectState: "none" })), [
-    "  GSD  No project loaded — run /gsd to start",
-  ]);
+test("buildHealthLines: none state shows single onboarding line pointing at /gsd", (t) => {
+  const lines = buildHealthLines(activeData({ projectState: "none" }));
+  assert.equal(lines.length, 1, "renders exactly one line");
+  // Should not show System OK / Budget / Last commit chrome when there's no project.
+  assert.ok(!/System OK|Budget|Last commit/.test(lines[0]!), "no active-project chrome");
+  // Should direct user to bootstrap via /gsd.
+  assert.match(lines[0]!, /\/gsd/);
 });
 
-test("buildHealthLines: initialized state shows continue setup copy", (t) => {
-  assert.deepEqual(buildHealthLines(activeData({ projectState: "initialized" })), [
-    "  GSD  Project initialized — run /gsd to continue setup",
-  ]);
+test("buildHealthLines: initialized state shows single setup line pointing at /gsd", (t) => {
+  const lines = buildHealthLines(activeData({ projectState: "initialized" }));
+  assert.equal(lines.length, 1, "renders exactly one line");
+  assert.ok(!/System OK|Budget|Last commit/.test(lines[0]!), "no active-project chrome");
+  // Distinct from "none" — must mention initialized/setup language and /gsd.
+  assert.match(lines[0]!, /\/gsd/);
+  assert.match(lines[0]!, /initiali[sz]ed|setup/i);
 });
 
 test("buildHealthLines: active state with ledger-driven spend shows spent summary", (t) => {
@@ -115,16 +121,20 @@ test("buildHealthLines: shows last commit with relative time and message", (t) =
   assert.match(lines[0]!, /feat\(widget\): add health display/);
 });
 
-test("buildHealthLines: truncates long commit messages", (t) => {
+test("buildHealthLines: truncates long commit messages with ellipsis", (t) => {
   const epoch = Math.floor(Date.now() / 1000) - 60;
-  const longMsg = "a".repeat(80);
+  const longMsg = "a".repeat(200); // far longer than any reasonable widget cap
   const lines = buildHealthLines(activeData({
     lastCommitEpoch: epoch,
     lastCommitMessage: longMsg,
   }));
   assert.equal(lines.length, 1);
-  assert.match(lines[0]!, /a{49}…/);
-  assert.ok(!lines[0]!.includes("a".repeat(51)), "message is truncated");
+  // Behavioural contract: rendered output is shorter than the input message
+  // and ends the message portion with the ellipsis character.
+  const aRun = lines[0]!.match(/a+…/);
+  assert.ok(aRun, "rendered output contains a run of a-chars terminated by an ellipsis");
+  assert.ok(aRun![0].length - 1 < longMsg.length, "truncated message is shorter than input");
+  assert.ok(!lines[0]!.includes("a".repeat(longMsg.length)), "untruncated message must not appear in output");
 });
 
 test("buildHealthLines: no last commit section when epoch is null", (t) => {

package/src/resources/extensions/gsd/tests/help-menu-coverage.test.ts

@@ -0,0 +1,57 @@
+// GSD-2 — Verify /gsd help menu covers all registered commands
+// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+
+import { TOP_LEVEL_SUBCOMMANDS } from "../commands/catalog.ts";
+
+/**
+ * Extracts command names from the showHelp("full") lines array.
+ * Each help line follows the pattern: "  /gsd <cmd>  ..."
+ */
+function extractHelpCommands(lines: string[]): Set<string> {
+  const cmds = new Set<string>();
+  for (const line of lines) {
+    const m = line.match(/^\s+\/gsd\s+(\S+)/);
+    if (m) cmds.add(m[1]);
+  }
+  return cmds;
+}
+
+describe("help menu coverage", () => {
+  test("every TOP_LEVEL_SUBCOMMAND appears in showHelp(\"full\") output", async () => {
+    // Import showHelp and capture its output via a mock ctx
+    const lines: string[] = [];
+    const mockCtx = {
+      ui: {
+        notify(message: string) {
+          lines.push(...message.split("\n"));
+        },
+        custom: async () => {},
+      },
+    };
+
+    const { showHelp } = await import("../commands/handlers/core.ts");
+    showHelp(mockCtx as any, "full");
+
+    const helpCmds = extractHelpCommands(lines);
+
+    // "help" is the command that shows the menu — it doesn't list itself
+    const SELF_REFERENTIAL = new Set(["help"]);
+
+    const missing: string[] = [];
+    for (const entry of TOP_LEVEL_SUBCOMMANDS) {
+      if (SELF_REFERENTIAL.has(entry.cmd)) continue;
+      if (!helpCmds.has(entry.cmd)) {
+        missing.push(entry.cmd);
+      }
+    }
+
+    assert.deepStrictEqual(
+      missing,
+      [],
+      `Commands registered in TOP_LEVEL_SUBCOMMANDS but missing from /gsd help full:\n  ${missing.join(", ")}`,
+    );
+  });
+});