gsd-pi 2.78.0-dev.aeeb2ca00 → 2.78.1-dev.0fdacd524

package/packages/mcp-server/dist/workflow-tools.js

@@ -5,6 +5,7 @@ import { existsSync, realpathSync } from "node:fs";
 import { isAbsolute, join, relative, resolve } from "node:path";
 import { pathToFileURL } from "node:url";
 import { z } from "zod";
+import { logAliasUsage } from "./alias-telemetry.js";
 let workflowToolExecutorsPromise = null;
 let workflowExecutionQueue = Promise.resolve();
 let workflowWriteGatePromise = null;
@@ -482,6 +483,66 @@ async function ensureMilestoneDbRow(milestoneId) {
         // Ignore pre-existing rows or transient DB availability issues.
     }
 }
+async function findDatabaseMilestoneIds() {
+    try {
+        const { getAllMilestones } = await importLocalModule("../../../src/resources/extensions/gsd/gsd-db.js");
+        return (getAllMilestones?.() ?? [])
+            .map((milestone) => {
+            const id = milestone?.id;
+            return typeof id === "string" ? id : null;
+        })
+            .filter((id) => id !== null);
+    }
+    catch {
+        return [];
+    }
+}
+/**
+ * Fix #4996: Shared helper for both gsd_milestone_generate_id and
+ * gsd_generate_milestone_id. Reuses the lowest reusable ghost milestone ID
+ * (a disk-only stub with no DB row, no worktree, no content files) before
+ * falling back to max+1. Uses the stricter `isReusableGhostMilestone` —
+ * not `isGhostMilestone` — to avoid racing with in-flight queued DB rows
+ * from an earlier call to this same tool.
+ */
+async function generateOrReuseMilestoneId(projectDir) {
+    const { claimReservedId, findMilestoneIds, getReservedMilestoneIds, nextMilestoneId, milestoneIdSort, } = await importLocalModule("../../../src/resources/extensions/gsd/milestone-ids.js");
+    const reserved = claimReservedId();
+    if (reserved) {
+        await ensureMilestoneDbRow(reserved);
+        return reserved;
+    }
+    const allIds = [
+        ...new Set([
+            ...findMilestoneIds(projectDir),
+            ...getReservedMilestoneIds(),
+            ...(await findDatabaseMilestoneIds()),
+        ]),
+    ];
+    // Attempt ghost-ID reuse before falling back to max+1.
+    const { isReusableGhostMilestone } = await importLocalModule("../../../src/resources/extensions/gsd/state.js");
+    const sorted = [...allIds].sort(milestoneIdSort);
+    for (const candidate of sorted) {
+        if (isReusableGhostMilestone(projectDir, candidate)) {
+            await ensureMilestoneDbRow(candidate);
+            return candidate;
+        }
+    }
+    const prefsMod = await importLocalModule("../../../src/resources/extensions/gsd/preferences.js").catch(() => null);
+    // Graceful degradation: a corrupt preferences file should not crash
+    // milestone-id generation. Fall back to non-unique IDs if anything
+    // throws here — matches the pre-fix behavior for missing prefs.
+    let uniqueEnabled = false;
+    try {
+        uniqueEnabled = !!prefsMod?.loadEffectiveGSDPreferences?.(projectDir)?.preferences?.unique_milestone_ids;
+    }
+    catch {
+        uniqueEnabled = false;
+    }
+    const nextId = nextMilestoneId(allIds, uniqueEnabled);
+    await ensureMilestoneDbRow(nextId);
+    return nextId;
+}
 // projectDir is optional. When omitted, the server uses process.cwd(). This
 // prevents the agent from burning tokens reasoning about which absolute path
 // to pass (git root vs worktree vs symlink-resolved external state layout) —
@@ -859,6 +920,7 @@ export function registerWorkflowTools(server) {
         return { content: [{ type: "text", text: `Saved decision ${result.id}` }] };
     });
     server.tool("gsd_save_decision", "Alias for gsd_decision_save. Record a project decision to the GSD database and regenerate DECISIONS.md.", decisionSaveParams, async (args) => {
+        logAliasUsage("gsd_save_decision", "gsd_decision_save");
         const parsed = parseWorkflowArgs(decisionSaveSchema, args);
         const { projectDir, ...params } = parsed;
         await enforceWorkflowWriteGate("gsd_decision_save", projectDir);
@@ -879,6 +941,7 @@ export function registerWorkflowTools(server) {
         return { content: [{ type: "text", text: `Updated requirement ${id}` }] };
     });
     server.tool("gsd_update_requirement", "Alias for gsd_requirement_update. Update an existing requirement in the GSD database and regenerate REQUIREMENTS.md.", requirementUpdateParams, async (args) => {
+        logAliasUsage("gsd_update_requirement", "gsd_requirement_update");
         const parsed = parseWorkflowArgs(requirementUpdateSchema, args);
         const { projectDir, id, ...updates } = parsed;
         await enforceWorkflowWriteGate("gsd_requirement_update", projectDir);
@@ -899,6 +962,7 @@ export function registerWorkflowTools(server) {
         return { content: [{ type: "text", text: `Saved requirement ${result.id}` }] };
     });
     server.tool("gsd_save_requirement", "Alias for gsd_requirement_save. Record a new requirement to the GSD database and regenerate REQUIREMENTS.md.", requirementSaveParams, async (args) => {
+        logAliasUsage("gsd_save_requirement", "gsd_requirement_save");
         const parsed = parseWorkflowArgs(requirementSaveSchema, args);
         const { projectDir, ...params } = parsed;
         await enforceWorkflowWriteGate("gsd_requirement_save", projectDir);
@@ -911,57 +975,14 @@ export function registerWorkflowTools(server) {
     server.tool("gsd_milestone_generate_id", "Generate the next milestone ID for a new GSD milestone.", milestoneGenerateIdParams, async (args) => {
         const { projectDir } = parseWorkflowArgs(milestoneGenerateIdSchema, args);
         await enforceWorkflowWriteGate("gsd_milestone_generate_id", projectDir);
-        const id = await runSerializedWorkflowDbOperation(projectDir, async () => {
-            const { claimReservedId, findMilestoneIds, getReservedMilestoneIds, nextMilestoneId, } = await importLocalModule("../../../src/resources/extensions/gsd/milestone-ids.js");
-            const reserved = claimReservedId();
-            if (reserved) {
-                await ensureMilestoneDbRow(reserved);
-                return reserved;
-            }
-            const allIds = [...new Set([...findMilestoneIds(projectDir), ...getReservedMilestoneIds()])];
-            const prefsMod = await importLocalModule("../../../src/resources/extensions/gsd/preferences.js").catch(() => null);
-            // Graceful degradation: a corrupt preferences file should not crash
-            // milestone-id generation. Fall back to non-unique IDs if anything
-            // throws here — matches the pre-fix behavior for missing prefs.
-            let uniqueEnabled = false;
-            try {
-                uniqueEnabled = !!prefsMod?.loadEffectiveGSDPreferences?.()?.preferences?.unique_milestone_ids;
-            }
-            catch {
-                uniqueEnabled = false;
-            }
-            const nextId = nextMilestoneId(allIds, uniqueEnabled);
-            await ensureMilestoneDbRow(nextId);
-            return nextId;
-        });
+        const id = await runSerializedWorkflowDbOperation(projectDir, () => generateOrReuseMilestoneId(projectDir));
         return { content: [{ type: "text", text: id }] };
     });
     server.tool("gsd_generate_milestone_id", "Alias for gsd_milestone_generate_id. Generate the next milestone ID for a new GSD milestone.", milestoneGenerateIdParams, async (args) => {
+        logAliasUsage("gsd_generate_milestone_id", "gsd_milestone_generate_id");
         const { projectDir } = parseWorkflowArgs(milestoneGenerateIdSchema, args);
         await enforceWorkflowWriteGate("gsd_milestone_generate_id", projectDir);
-        const id = await runSerializedWorkflowDbOperation(projectDir, async () => {
-            const { claimReservedId, findMilestoneIds, getReservedMilestoneIds, nextMilestoneId, } = await importLocalModule("../../../src/resources/extensions/gsd/milestone-ids.js");
-            const reserved = claimReservedId();
-            if (reserved) {
-                await ensureMilestoneDbRow(reserved);
-                return reserved;
-            }
-            const allIds = [...new Set([...findMilestoneIds(projectDir), ...getReservedMilestoneIds()])];
-            const prefsMod = await importLocalModule("../../../src/resources/extensions/gsd/preferences.js").catch(() => null);
-            // Graceful degradation: a corrupt preferences file should not crash
-            // milestone-id generation. Fall back to non-unique IDs if anything
-            // throws here — matches the pre-fix behavior for missing prefs.
-            let uniqueEnabled = false;
-            try {
-                uniqueEnabled = !!prefsMod?.loadEffectiveGSDPreferences?.()?.preferences?.unique_milestone_ids;
-            }
-            catch {
-                uniqueEnabled = false;
-            }
-            const nextId = nextMilestoneId(allIds, uniqueEnabled);
-            await ensureMilestoneDbRow(nextId);
-            return nextId;
-        });
+        const id = await runSerializedWorkflowDbOperation(projectDir, () => generateOrReuseMilestoneId(projectDir));
         return { content: [{ type: "text", text: id }] };
     });
     server.tool("gsd_plan_milestone", "Write milestone planning state to the GSD database and render ROADMAP.md from DB.", planMilestoneParams, async (args) => {
@@ -994,6 +1015,7 @@ export function registerWorkflowTools(server) {
         };
     });
     server.tool("gsd_task_plan", "Alias for gsd_plan_task. Write task planning state to the GSD database and render tasks/T##-PLAN.md from DB.", planTaskParams, async (args) => {
+        logAliasUsage("gsd_task_plan", "gsd_plan_task");
         const parsed = parseWorkflowArgs(planTaskSchema, args);
         const { projectDir, ...params } = parsed;
         await enforceWorkflowWriteGate("gsd_plan_task", projectDir, params.milestoneId);
@@ -1013,6 +1035,7 @@ export function registerWorkflowTools(server) {
         return handleReplanSlice(parsed.projectDir, parsed);
     });
     server.tool("gsd_slice_replan", "Alias for gsd_replan_slice. Replan a slice after a blocker is discovered.", replanSliceParams, async (args) => {
+        logAliasUsage("gsd_slice_replan", "gsd_replan_slice");
         const parsed = parseWorkflowArgs(replanSliceSchema, args);
         return handleReplanSlice(parsed.projectDir, parsed);
     });
@@ -1021,6 +1044,7 @@ export function registerWorkflowTools(server) {
         return handleSliceComplete(parsed.projectDir, parsed);
     });
     server.tool("gsd_complete_slice", "Alias for gsd_slice_complete. Record a completed slice to the GSD database and render summary/UAT artifacts.", sliceCompleteParams, async (args) => {
+        logAliasUsage("gsd_complete_slice", "gsd_slice_complete");
         const parsed = parseWorkflowArgs(sliceCompleteSchema, args);
         return handleSliceComplete(parsed.projectDir, parsed);
     });
@@ -1053,6 +1077,7 @@ export function registerWorkflowTools(server) {
         return handleCompleteMilestone(parsed.projectDir, parsed);
     });
     server.tool("gsd_milestone_complete", "Alias for gsd_complete_milestone. Record a completed milestone to the GSD database and render its SUMMARY.md.", completeMilestoneParams, async (args) => {
+        logAliasUsage("gsd_milestone_complete", "gsd_complete_milestone");
         const parsed = parseWorkflowArgs(completeMilestoneSchema, args);
         return handleCompleteMilestone(parsed.projectDir, parsed);
     });
@@ -1061,6 +1086,7 @@ export function registerWorkflowTools(server) {
         return handleValidateMilestone(parsed.projectDir, parsed);
     });
     server.tool("gsd_milestone_validate", "Alias for gsd_validate_milestone. Validate a milestone and render VALIDATION.md.", validateMilestoneParams, async (args) => {
+        logAliasUsage("gsd_milestone_validate", "gsd_validate_milestone");
         const parsed = parseWorkflowArgs(validateMilestoneSchema, args);
         return handleValidateMilestone(parsed.projectDir, parsed);
     });
@@ -1069,6 +1095,7 @@ export function registerWorkflowTools(server) {
         return handleReassessRoadmap(parsed.projectDir, parsed);
     });
     server.tool("gsd_roadmap_reassess", "Alias for gsd_reassess_roadmap. Reassess a roadmap after slice completion.", reassessRoadmapParams, async (args) => {
+        logAliasUsage("gsd_roadmap_reassess", "gsd_reassess_roadmap");
         const parsed = parseWorkflowArgs(reassessRoadmapSchema, args);
         return handleReassessRoadmap(parsed.projectDir, parsed);
     });
@@ -1093,6 +1120,7 @@ export function registerWorkflowTools(server) {
         return handleTaskComplete(projectDir, taskArgs);
     });
     server.tool("gsd_complete_task", "Alias for gsd_task_complete. Record a completed task to the GSD database and render its SUMMARY.md.", taskCompleteParams, async (args) => {
+        logAliasUsage("gsd_complete_task", "gsd_task_complete");
         const parsed = parseWorkflowArgs(taskCompleteSchema, args);
         const { projectDir, ...taskArgs } = parsed;
         return handleTaskComplete(projectDir, taskArgs);