gsd-pi 2.77.0-dev.c9c8932c6 → 2.77.0-dev.cfd69e714

package/src/resources/extensions/voice/tests/linux-ready.test.ts

@@ -5,120 +5,136 @@
  *   - diagnoseSounddeviceError branch ordering (ModuleNotFoundError must NOT
  *     match the portaudio branch, even though it contains "sounddevice")
  *   - ensureVoiceVenv auto-creation
- *   - linuxPython venv detection
+ *
+ * Previous version used `createTestContext()` + a top-level `main()` call —
+ * those don't register with `node --test`, so the file ran at import time
+ * but the test runner saw zero tests. CI reporter showed no output for
+ * this file. Rewrite uses `node:test` so results are collected properly.
+ * See #4809 / #4784.
  */
 
-import { createTestContext } from "../../gsd/tests/test-helpers.ts";
-import { diagnoseSounddeviceError, ensureVoiceVenv } from "../linux-ready.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-function main(): void {
-	// ── diagnoseSounddeviceError ──────────────────────────────────────────
-
-	// The critical regression: "ModuleNotFoundError: No module named 'sounddevice'"
-	// contains the word "sounddevice", so the old code matched the portaudio branch.
-	console.log("\n=== diagnoseSounddeviceError: ModuleNotFoundError must return missing-module ===");
-	{
-		const stderr = "Traceback (most recent call last):\n  File \"<string>\", line 1, in <module>\nModuleNotFoundError: No module named 'sounddevice'";
-		assertEq(diagnoseSounddeviceError(stderr), "missing-module",
-			"ModuleNotFoundError for sounddevice should be 'missing-module', not 'missing-portaudio'");
-	}
-
-	console.log("\n=== diagnoseSounddeviceError: 'No module named sounddevice' variant ===");
-	{
-		const stderr = "ImportError: No module named sounddevice";
-		assertEq(diagnoseSounddeviceError(stderr), "missing-module",
-			"'No module' substring should return missing-module");
-	}
-
-	console.log("\n=== diagnoseSounddeviceError: actual portaudio error ===");
-	{
-		const stderr = "OSError: PortAudio library not found";
-		assertEq(diagnoseSounddeviceError(stderr), "missing-portaudio",
-			"PortAudio library error should return missing-portaudio");
-	}
-
-	console.log("\n=== diagnoseSounddeviceError: lowercase portaudio error ===");
-	{
-		const stderr = "OSError: libportaudio.so.2: cannot open shared object file: No such file or directory";
-		assertEq(diagnoseSounddeviceError(stderr), "missing-portaudio",
-			"lowercase portaudio error should return missing-portaudio");
-	}
-
-	console.log("\n=== diagnoseSounddeviceError: unrelated error ===");
-	{
-		const stderr = "SyntaxError: invalid syntax";
-		assertEq(diagnoseSounddeviceError(stderr), "unknown",
-			"unrelated error should return unknown");
-	}
-
-	console.log("\n=== diagnoseSounddeviceError: empty stderr ===");
-	{
-		assertEq(diagnoseSounddeviceError(""), "unknown",
-			"empty stderr should return unknown");
-	}
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
 
-	// ── ensureVoiceVenv ──────────────────────────────────────────────────
-
-	console.log("\n=== ensureVoiceVenv: returns true when venv already exists ===");
-	{
-		const notifications: string[] = [];
-		const result = ensureVoiceVenv({
-			notify: (msg) => notifications.push(msg),
-			exists: () => true,
-			execFile: (() => Buffer.from("")) as any,
-		});
-		assertTrue(result, "should return true when venv exists");
-		assertEq(notifications.length, 0, "should not notify when venv exists");
-	}
-
-	console.log("\n=== ensureVoiceVenv: creates venv when missing ===");
-	{
-		const notifications: string[] = [];
-		const commands: string[][] = [];
-		let existsCalled = false;
-
-		const result = ensureVoiceVenv({
-			notify: (msg) => notifications.push(msg),
-			exists: () => { existsCalled = true; return false; },
-			execFile: ((cmd: string, args: string[]) => {
-				commands.push([cmd, ...args]);
-				return Buffer.from("");
-			}) as any,
-		});
-
-		assertTrue(result, "should return true after venv creation");
-		assertTrue(existsCalled, "should check if venv exists");
-		assertEq(commands.length, 2, "should run 2 commands (venv + pip)");
-		assertTrue(commands[0][0] === "python3", "first command is python3");
-		assertTrue(commands[0].includes("-m") && commands[0].includes("venv"),
-			"first command creates venv");
-		assertTrue(commands[1][0].endsWith("bin/pip"), "second command is pip");
-		assertTrue(commands[1].includes("sounddevice"), "pip installs sounddevice");
-		assertTrue(commands[1].includes("requests"), "pip installs requests");
-		assertTrue(notifications[0].includes("one-time setup"),
-			"notifies about one-time setup");
-	}
-
-	console.log("\n=== ensureVoiceVenv: returns false and notifies on failure ===");
-	{
-		const notifications: Array<{ msg: string; level: string }> = [];
-
-		const result = ensureVoiceVenv({
-			notify: (msg, level) => notifications.push({ msg, level }),
-			exists: () => false,
-			execFile: (() => { throw new Error("externally-managed-environment"); }) as any,
-		});
-
-		assertTrue(!result, "should return false on failure");
-		const errorNotif = notifications.find(n => n.level === "error");
-		assertTrue(errorNotif !== undefined, "should emit error notification");
-		assertTrue(errorNotif!.msg.includes("python3 -m venv"),
-			"error message should suggest manual venv creation");
-	}
-
-	report();
-}
+import { diagnoseSounddeviceError, ensureVoiceVenv } from "../linux-ready.ts";
 
-main();
+describe("diagnoseSounddeviceError (#2403 branch ordering)", () => {
+  test("ModuleNotFoundError with 'sounddevice' in message → missing-module", () => {
+    // The critical regression: the stderr string contains "sounddevice",
+    // so a naive branch-order check would match the portaudio branch
+    // first. Correct classification is missing-module.
+    const stderr =
+      "Traceback (most recent call last):\n" +
+      '  File "<string>", line 1, in <module>\n' +
+      "ModuleNotFoundError: No module named 'sounddevice'";
+    assert.equal(diagnoseSounddeviceError(stderr), "missing-module");
+  });
+
+  test("ImportError: No module named sounddevice → missing-module", () => {
+    assert.equal(
+      diagnoseSounddeviceError("ImportError: No module named sounddevice"),
+      "missing-module",
+    );
+  });
+
+  test("PortAudio library not found → missing-portaudio", () => {
+    assert.equal(
+      diagnoseSounddeviceError("OSError: PortAudio library not found"),
+      "missing-portaudio",
+    );
+  });
+
+  test("libportaudio.so.2 cannot open → missing-portaudio (lowercase variant)", () => {
+    assert.equal(
+      diagnoseSounddeviceError(
+        "OSError: libportaudio.so.2: cannot open shared object file: No such file or directory",
+      ),
+      "missing-portaudio",
+    );
+  });
+
+  test("unrelated SyntaxError → unknown", () => {
+    assert.equal(
+      diagnoseSounddeviceError("SyntaxError: invalid syntax"),
+      "unknown",
+    );
+  });
+
+  test("empty stderr → unknown", () => {
+    assert.equal(diagnoseSounddeviceError(""), "unknown");
+  });
+});
+
+describe("ensureVoiceVenv", () => {
+  test("returns true without notifying when venv already exists", () => {
+    const notifications: string[] = [];
+    const result = ensureVoiceVenv({
+      notify: (msg) => notifications.push(msg),
+      exists: () => true,
+      execFile: (() => Buffer.from("")) as never,
+    });
+    assert.equal(result, true);
+    assert.equal(
+      notifications.length,
+      0,
+      "should not notify when venv already exists",
+    );
+  });
+
+  test("creates venv and installs sounddevice+requests when venv missing", () => {
+    const notifications: string[] = [];
+    const commands: string[][] = [];
+    let existsCalled = false;
+
+    const result = ensureVoiceVenv({
+      notify: (msg) => notifications.push(msg),
+      exists: () => {
+        existsCalled = true;
+        return false;
+      },
+      execFile: ((cmd: string, args: string[]) => {
+        commands.push([cmd, ...args]);
+        return Buffer.from("");
+      }) as never,
+    });
+
+    assert.equal(result, true);
+    assert.ok(existsCalled, "should check if venv exists first");
+    assert.equal(commands.length, 2, "should run 2 commands (venv + pip)");
+    assert.equal(commands[0]![0], "python3", "first command is python3");
+    assert.ok(
+      commands[0]!.includes("-m") && commands[0]!.includes("venv"),
+      "first command creates the venv",
+    );
+    assert.ok(
+      commands[1]![0]!.endsWith("bin/pip"),
+      "second command is pip from the new venv",
+    );
+    assert.ok(commands[1]!.includes("sounddevice"), "pip installs sounddevice");
+    assert.ok(commands[1]!.includes("requests"), "pip installs requests");
+    assert.ok(
+      notifications[0]!.includes("one-time setup"),
+      "notifies user this is one-time setup",
+    );
+  });
+
+  test("returns false and emits an error notification when venv creation fails", () => {
+    const notifications: Array<{ msg: string; level?: string }> = [];
+
+    const result = ensureVoiceVenv({
+      notify: (msg, level) => notifications.push({ msg, level }),
+      exists: () => false,
+      execFile: (() => {
+        throw new Error("externally-managed-environment");
+      }) as never,
+    });
+
+    assert.equal(result, false);
+    const errorNotif = notifications.find((n) => n.level === "error");
+    assert.ok(errorNotif, "must emit an error notification on failure");
+    assert.ok(
+      errorNotif!.msg.includes("python3 -m venv"),
+      "error notification suggests manual venv creation",
+    );
+  });
+});

package/src/resources/skills/create-skill/SKILL.md

@@ -88,8 +88,8 @@ Then proceed directly to the workflow.
 ## Skill Structure Quick Reference
 
 **Skill directories:**
-- Global: `~/.gsd/agent/skills/{skill-name}/`
-- Project-local: `.pi/agent/skills/{skill-name}/`
+- Global: `~/.agents/skills/{skill-name}/`
+- Project-local: `.agents/skills/{skill-name}/`
 
 **Simple skill (single file):**
 ```yaml

package/src/resources/skills/create-skill/references/gsd-skill-ecosystem.md

@@ -5,13 +5,13 @@ GSD-specific skill ecosystem details: directory conventions, discovery mechanics
 <skill_directories>
 GSD supports two skill directories, checked in order:
 
-**User-scope (global):** `~/.gsd/agent/skills/`
+**User-scope (global):** `~/.agents/skills/`
 - Available in every GSD session regardless of working directory
-- Installed by default or by the user
+- Installed via [skills.sh](https://skills.sh) or manually
 
-**Project-scope (local):** `.pi/agent/skills/`
+**Project-scope (local):** `.agents/skills/`
 - Available only when GSD runs inside the project directory
-- The project-local directory uses `.pi` (inherited from the pi base), **not** `.gsd`
+- Committable to version control so team members share the same skill set
 - Ideal for project-specific workflows, deploy scripts, or conventions
 
 Skills in both directories follow the same SKILL.md format and router pattern conventions.

package/src/resources/skills/create-skill/workflows/audit-skill.md

@@ -16,22 +16,22 @@
 Enumerate skills from both directories:
 ```bash
 echo "=== Global skills ==="
-ls ~/.gsd/agent/skills/ 2>/dev/null || echo "(none)"
+ls ~/.agents/skills/ 2>/dev/null || echo "(none)"
 
 echo "=== Project-local skills ==="
-ls .pi/agent/skills/ 2>/dev/null || echo "(none)"
+ls .agents/skills/ 2>/dev/null || echo "(none)"
 ```
 
 Present as:
 ```
 Available skills:
 
-Global (~/.gsd/agent/skills/):
+Global (~/.agents/skills/):
 1. create-skill
 2. manage-stripe
 ...
 
-Project-local (.pi/agent/skills/):
+Project-local (.agents/skills/):
 3. project-deploy
 ...
 ```

package/src/resources/skills/create-skill/workflows/create-new-skill.md

@@ -15,8 +15,8 @@
 **Ask the user:**
 "Should this skill be global or project-local?"
 
-1. **Global** (`~/.gsd/agent/skills/`) — Available in all GSD sessions
-2. **Project-local** (`.pi/agent/skills/`) — Available only in this project
+1. **Global** (`~/.agents/skills/`) — Available in all GSD sessions
+2. **Project-local** (`.agents/skills/`) — Available only in this project
 
 ## Step 2: Adaptive Requirements Gathering
 
@@ -99,11 +99,11 @@ See references/recommended-structure.md for templates.
 ## Step 5: Create Directory
 
 Use the scope selected in Step 1 to determine the base path:
-- **Global:** `~/.gsd/agent/skills/{skill-name}`
-- **Project-local:** `.pi/agent/skills/{skill-name}`
+- **Global:** `~/.agents/skills/{skill-name}`
+- **Project-local:** `.agents/skills/{skill-name}`
 
 ```bash
-BASE_PATH="{selected-base}/agent/skills/{skill-name}"
+BASE_PATH="{selected-base}/skills/{skill-name}"
 mkdir -p $BASE_PATH
 # If complex:
 mkdir -p $BASE_PATH/workflows

package/dist/web/standalone/.next/server/chunks/7461.js

@@ -1 +0,0 @@
-"use strict";exports.id=7461,exports.ids=[7461],exports.modules={7461:(a,b,c)=>{c.d(b,{isOnboardingComplete:()=>k,readOnboardingRecord:()=>j});var d=c(3024),e=c(8161),f=c(6760);c(7598),c(1421),process.env.GSD_ENABLE_NATIVE_GSD_PARSER,Symbol("native-unavailable"),c(9134),Object.values({Q3:{id:"Q3",scope:"slice",ownerTurn:"gate-evaluate",question:"How can this be exploited?",guidance:"Identify abuse scenarios: parameter tampering, replay attacks, privilege escalation.\nMap data exposure risks: PII, tokens, secrets accessible through this slice.\nDefine input trust boundaries: untrusted user input reaching DB, API, or filesystem.\nIf none apply, return verdict 'omitted' with rationale explaining why.",promptSection:"Abuse Surface"},Q4:{id:"Q4",scope:"slice",ownerTurn:"gate-evaluate",question:"What existing promises does this break?",guidance:"List which existing requirements (R001, R003, etc.) are touched by this slice.\nIdentify what must be re-tested after shipping.\nFlag decisions that should be revisited given the new scope.\nIf no existing requirements are affected, return verdict 'omitted'.",promptSection:"Broken Promises"},Q5:{id:"Q5",scope:"task",ownerTurn:"execute-task",question:"What breaks when dependencies fail?",guidance:"Enumerate the task's external dependencies (APIs, filesystem, network, subprocesses).\nDescribe the failure path for each: timeout, malformed response, connection loss.\nVerify the implementation handles each failure or explicitly bubbles the error.\nReturn verdict 'omitted' only if the task has no external dependencies.",promptSection:"Failure Modes"},Q6:{id:"Q6",scope:"task",ownerTurn:"execute-task",question:"What is the 10x load breakpoint?",guidance:"Identify the resource that saturates first at 10x the expected load.\nDescribe the protection applied (pool sizing, rate limiting, pagination, caching).\nReturn verdict 'omitted' if the task has no runtime load dimension.",promptSection:"Load Profile"},Q7:{id:"Q7",scope:"task",ownerTurn:"execute-task",question:"What negative tests protect this task?",guidance:"List malformed inputs, error paths, and boundary conditions the tests cover.\nPoint to the specific test files or cases that assert each negative scenario.\nReturn verdict 'omitted' only if the task has no meaningful negative surface.",promptSection:"Negative Tests"},Q8:{id:"Q8",scope:"slice",ownerTurn:"complete-slice",question:"How will ops know this slice is healthy or broken?",guidance:"Describe the health signal (metric, log line, dashboard) that proves the slice works.\nDescribe the failure signal that triggers an alert or paging.\nDocument the recovery procedure and any monitoring gaps.\nReturn verdict 'omitted' only for slices with no runtime behavior at all.",promptSection:"Operational Readiness"},MV01:{id:"MV01",scope:"milestone",ownerTurn:"validate-milestone",question:"Is every success criterion in the milestone roadmap satisfied?",guidance:"Walk the success-criteria checklist from the milestone roadmap.\nFor each criterion, point to the slice / assessment / verification evidence that proves it.\nReturn verdict 'flag' if any criterion is unmet or unverifiable.",promptSection:"Success Criteria Checklist"},MV02:{id:"MV02",scope:"milestone",ownerTurn:"validate-milestone",question:"Does every slice have a SUMMARY.md and a passing assessment?",guidance:"Confirm every slice listed in the roadmap has a SUMMARY.md.\nConfirm each slice has an ASSESSMENT verdict of 'pass' (or justified 'omitted').\nFlag missing artifacts and slices with outstanding follow-ups or known limitations.",promptSection:"Slice Delivery Audit"},MV03:{id:"MV03",scope:"milestone",ownerTurn:"validate-milestone",question:"Do the slices integrate end-to-end?",guidance:"Trace at least one cross-slice flow proving the pieces compose.\nFlag gaps where two slices were built in isolation with no integration evidence.",promptSection:"Cross-Slice Integration"},MV04:{id:"MV04",scope:"milestone",ownerTurn:"validate-milestone",question:"Are all touched requirements covered and still coherent?",guidance:"For each requirement advanced, validated, surfaced, or invalidated across the milestone's slices, confirm the milestone-level evidence matches.\nFlag requirements that slices claim to advance but no artifact proves.",promptSection:"Requirement Coverage"}});let g=process.env.GSD_CODING_AGENT_DIR||(0,f.join)(process.env.GSD_HOME||(0,f.join)((0,e.homedir)(),".gsd"),"agent"),h=(0,f.join)(g,"onboarding.json"),i={version:1,flowVersion:1,completedAt:null,completedSteps:[],skippedSteps:[],lastResumePoint:null};function j(){if(!(0,d.existsSync)(h))return{...i};try{let a=JSON.parse((0,d.readFileSync)(h,"utf-8"));return{version:"number"==typeof a.version?a.version:1,flowVersion:"number"==typeof a.flowVersion?a.flowVersion:0,completedAt:"string"==typeof a.completedAt?a.completedAt:null,completedSteps:Array.isArray(a.completedSteps)?a.completedSteps.filter(a=>"string"==typeof a):[],skippedSteps:Array.isArray(a.skippedSteps)?a.skippedSteps.filter(a=>"string"==typeof a):[],lastResumePoint:"string"==typeof a.lastResumePoint?a.lastResumePoint:null}}catch{return{...i}}}function k(){let a=j();return null!==a.completedAt&&1===a.flowVersion}},9134:(a,b,c)=>{c.d(b,{DZ:()=>e,rs:()=>d});let d="GSD_GIT_ERROR";class e extends Error{constructor(a,b,c){super(b,c),this.name="GSDError",this.code=a}}}};