gsd-pi 2.77.0-dev.1d17f366c → 2.77.0-dev.2daa994b6

package/packages/pi-tui/dist/components/__tests__/input.test.js

@@ -29,10 +29,17 @@ describe("Input", () => {
         const input = new Input();
         input.secure = true;
         input.focused = true;
-        input.handleInput("secret123");
+        const SECRET = "secret123";
+        input.handleInput(SECRET);
         const line = input.render(40)[0] ?? "";
-        assert.ok(!line.includes("secret123"), "rendered line must not expose raw secret text");
-        assert.ok(line.includes("*********"), "rendered line should include masked characters");
+        // Previous assertion was `line.includes("*********")` — a literal
+        // 9-star string that silently goes stale if SECRET is renamed to
+        // a different length (#4796). Match any run of asterisks and
+        // assert its length covers the secret.
+        assert.ok(!line.includes(SECRET), "rendered line must not expose raw secret text");
+        const maskMatch = line.match(/\*+/);
+        assert.ok(maskMatch, `rendered line must include masked characters, got: ${JSON.stringify(line)}`);
+        assert.ok(maskMatch[0].length >= SECRET.length, `mask must cover at least the secret length (${SECRET.length}), got ${maskMatch[0].length} asterisks`);
     });
     it("maps kitty keypad digits to text instead of inserting private-use glyphs", () => {
         const input = new Input();

package/packages/pi-tui/dist/components/__tests__/input.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"input.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/input.test.ts"],"names":[],"mappings":"AAAA,0CAA0C;AAC1C,4DAA4D;AAE5D,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,KAAK,EAAE,MAAM,aAAa,CAAC;AAEpC,QAAQ,CAAC,OAAO,EAAE,GAAG,EAAE;IACtB,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACrD,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,yDAAyD;QACzD,KAAK,CAAC,WAAW,CAAC,kBAAkB,CAAC,CAAC;QAEtC,2BAA2B;QAC3B,KAAK,CAAC,OAAO,GAAG,KAAK,CAAC;QAEtB,mDAAmD;QACnD,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,iEAAiE;QACjE,KAAK,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC;QAC3B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,EAAE,OAAO,CAAC,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAChD,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;QACnC,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QACrB,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;QAClC,KAAK,CAAC,OAAO,GAAG,KAAK,CAAC;QACtB,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QACjE,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,MAAM,GAAG,IAAI,CAAC;QACpB,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QACrB,KAAK,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC;QAE/B,MAAM,IAAI,GAAG,KAAK,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACvC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,+CAA+C,CAAC,CAAC;QACxF,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,gDAAgD,CAAC,CAAC;IACzF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,GAAG,EAAE;QACnF,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,KAAK,CAAC,WAAW,CAAC,iBAAiB,CAAC,CAAC;QAErC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,EAAE,GAAG,CAAC,CAAC;IACrC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC7D,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,KAAK,CAAC,WAAW,CAAC,aAAa,CAAC,CAAC;QAEjC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["// pi-tui Input component regression tests\n// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>\n\nimport { describe, it } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Input } from \"../input.js\";\n\ndescribe(\"Input\", () => {\n\tit(\"paste buffer is cleared when focus is lost\", () => {\n\t\tconst input = new Input();\n\t\tinput.focused = true;\n\n\t\t// Simulate starting a paste (bracket paste start marker)\n\t\tinput.handleInput(\"\\x1b[200~partial\");\n\n\t\t// Now lose focus mid-paste\n\t\tinput.focused = false;\n\n\t\t// Regain focus — should not have stale paste state\n\t\tinput.focused = true;\n\n\t\t// Typing normal text should work without paste buffer corruption\n\t\tinput.handleInput(\"hello\");\n\t\tassert.equal(input.getValue(), \"hello\");\n\t});\n\n\tit(\"focused getter/setter works correctly\", () => {\n\t\tconst input = new Input();\n\t\tassert.equal(input.focused, false);\n\t\tinput.focused = true;\n\t\tassert.equal(input.focused, true);\n\t\tinput.focused = false;\n\t\tassert.equal(input.focused, false);\n\t});\n\n\tit(\"secure mode obscures typed characters in render output\", () => {\n\t\tconst input = new Input();\n\t\tinput.secure = true;\n\t\tinput.focused = true;\n\t\tinput.handleInput(\"secret123\");\n\n\t\tconst line = input.render(40)[0] ?? \"\";\n\t\tassert.ok(!line.includes(\"secret123\"), \"rendered line must not expose raw secret text\");\n\t\tassert.ok(line.includes(\"*********\"), \"rendered line should include masked characters\");\n\t});\n\n\tit(\"maps kitty keypad digits to text instead of inserting private-use glyphs\", () => {\n\t\tconst input = new Input();\n\t\tinput.focused = true;\n\n\t\tinput.handleInput(\"\\x1b[57400;129u\");\n\n\t\tassert.equal(input.getValue(), \"1\");\n\t});\n\n\tit(\"ignores kitty keypad navigation keys in text input\", () => {\n\t\tconst input = new Input();\n\t\tinput.focused = true;\n\n\t\tinput.handleInput(\"\\x1b[57417u\");\n\n\t\tassert.equal(input.getValue(), \"\");\n\t});\n});\n"]}
+{"version":3,"file":"input.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/input.test.ts"],"names":[],"mappings":"AAAA,0CAA0C;AAC1C,4DAA4D;AAE5D,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,KAAK,EAAE,MAAM,aAAa,CAAC;AAEpC,QAAQ,CAAC,OAAO,EAAE,GAAG,EAAE;IACtB,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACrD,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,yDAAyD;QACzD,KAAK,CAAC,WAAW,CAAC,kBAAkB,CAAC,CAAC;QAEtC,2BAA2B;QAC3B,KAAK,CAAC,OAAO,GAAG,KAAK,CAAC;QAEtB,mDAAmD;QACnD,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,iEAAiE;QACjE,KAAK,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC;QAC3B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,EAAE,OAAO,CAAC,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAChD,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;QACnC,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QACrB,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;QAClC,KAAK,CAAC,OAAO,GAAG,KAAK,CAAC;QACtB,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QACjE,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,MAAM,GAAG,IAAI,CAAC;QACpB,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QACrB,MAAM,MAAM,GAAG,WAAW,CAAC;QAC3B,KAAK,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;QAE1B,MAAM,IAAI,GAAG,KAAK,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACvC,kEAAkE;QAClE,iEAAiE;QACjE,6DAA6D;QAC7D,uCAAuC;QACvC,MAAM,CAAC,EAAE,CACR,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,EACtB,+CAA+C,CAC/C,CAAC;QACF,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QACpC,MAAM,CAAC,EAAE,CACR,SAAS,EACT,sDAAsD,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,EAAE,CAC5E,CAAC;QACF,MAAM,CAAC,EAAE,CACR,SAAS,CAAC,CAAC,CAAC,CAAC,MAAM,IAAI,MAAM,CAAC,MAAM,EACpC,+CAA+C,MAAM,CAAC,MAAM,UAAU,SAAS,CAAC,CAAC,CAAC,CAAC,MAAM,YAAY,CACrG,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,GAAG,EAAE;QACnF,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,KAAK,CAAC,WAAW,CAAC,iBAAiB,CAAC,CAAC;QAErC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,EAAE,GAAG,CAAC,CAAC;IACrC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC7D,MAAM,KAAK,GAAG,IAAI,KAAK,EAAE,CAAC;QAC1B,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC;QAErB,KAAK,CAAC,WAAW,CAAC,aAAa,CAAC,CAAC;QAEjC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["// pi-tui Input component regression tests\n// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>\n\nimport { describe, it } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Input } from \"../input.js\";\n\ndescribe(\"Input\", () => {\n\tit(\"paste buffer is cleared when focus is lost\", () => {\n\t\tconst input = new Input();\n\t\tinput.focused = true;\n\n\t\t// Simulate starting a paste (bracket paste start marker)\n\t\tinput.handleInput(\"\\x1b[200~partial\");\n\n\t\t// Now lose focus mid-paste\n\t\tinput.focused = false;\n\n\t\t// Regain focus — should not have stale paste state\n\t\tinput.focused = true;\n\n\t\t// Typing normal text should work without paste buffer corruption\n\t\tinput.handleInput(\"hello\");\n\t\tassert.equal(input.getValue(), \"hello\");\n\t});\n\n\tit(\"focused getter/setter works correctly\", () => {\n\t\tconst input = new Input();\n\t\tassert.equal(input.focused, false);\n\t\tinput.focused = true;\n\t\tassert.equal(input.focused, true);\n\t\tinput.focused = false;\n\t\tassert.equal(input.focused, false);\n\t});\n\n\tit(\"secure mode obscures typed characters in render output\", () => {\n\t\tconst input = new Input();\n\t\tinput.secure = true;\n\t\tinput.focused = true;\n\t\tconst SECRET = \"secret123\";\n\t\tinput.handleInput(SECRET);\n\n\t\tconst line = input.render(40)[0] ?? \"\";\n\t\t// Previous assertion was `line.includes(\"*********\")` — a literal\n\t\t// 9-star string that silently goes stale if SECRET is renamed to\n\t\t// a different length (#4796). Match any run of asterisks and\n\t\t// assert its length covers the secret.\n\t\tassert.ok(\n\t\t\t!line.includes(SECRET),\n\t\t\t\"rendered line must not expose raw secret text\",\n\t\t);\n\t\tconst maskMatch = line.match(/\\*+/);\n\t\tassert.ok(\n\t\t\tmaskMatch,\n\t\t\t`rendered line must include masked characters, got: ${JSON.stringify(line)}`,\n\t\t);\n\t\tassert.ok(\n\t\t\tmaskMatch[0].length >= SECRET.length,\n\t\t\t`mask must cover at least the secret length (${SECRET.length}), got ${maskMatch[0].length} asterisks`,\n\t\t);\n\t});\n\n\tit(\"maps kitty keypad digits to text instead of inserting private-use glyphs\", () => {\n\t\tconst input = new Input();\n\t\tinput.focused = true;\n\n\t\tinput.handleInput(\"\\x1b[57400;129u\");\n\n\t\tassert.equal(input.getValue(), \"1\");\n\t});\n\n\tit(\"ignores kitty keypad navigation keys in text input\", () => {\n\t\tconst input = new Input();\n\t\tinput.focused = true;\n\n\t\tinput.handleInput(\"\\x1b[57417u\");\n\n\t\tassert.equal(input.getValue(), \"\");\n\t});\n});\n"]}

package/packages/pi-tui/dist/components/__tests__/loader.test.js

@@ -1,6 +1,17 @@
 // pi-tui Loader component regression tests
-// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
+//
+// The previous version of this file contained 3 tests that called
+// `start()`/`stop()`/`dispose()` with no assertions at all — the claimed
+// regression ("interval leak") would not have failed any of them. See
+// #4794 / #4784.
+//
+// This rewrite uses Node's `mock.timers` to observe the interval that
+// `Loader` registers internally, and `mock.fn()` on the mock TUI to
+// count render requests. Each test asserts on observable behaviour:
+// how many `requestRender` calls happen per tick, whether the interval
+// is cleared on stop/dispose, and whether post-dispose stop() is safe.
 import { describe, it, mock, beforeEach, afterEach } from "node:test";
+import assert from "node:assert/strict";
 import { Loader } from "../loader.js";
 function makeMockTUI() {
     return { requestRender: mock.fn() };
@@ -10,28 +21,61 @@ describe("Loader", () => {
     let tui;
     beforeEach(() => {
         tui = makeMockTUI();
+        mock.timers.enable({ apis: ["setInterval"] });
     });
     afterEach(() => {
-        loader?.stop();
+        try {
+            loader?.stop();
+        }
+        catch {
+            /* best-effort */
+        }
+        mock.timers.reset();
+    });
+    it("constructor starts a spinner that ticks every 80ms and requests renders", () => {
+        loader = new Loader(tui, (s) => s, (s) => s, "test");
+        // Initial render request from start().
+        const initial = tui.requestRender.mock.callCount();
+        assert.ok(initial >= 1, `constructor should trigger at least one render (got ${initial})`);
+        // Advance 80ms — one interval tick should call requestRender once more.
+        mock.timers.tick(80);
+        assert.equal(tui.requestRender.mock.callCount(), initial + 1, "80ms tick should advance the spinner and call requestRender");
+        // Advance another 240ms — three more ticks.
+        mock.timers.tick(240);
+        assert.equal(tui.requestRender.mock.callCount(), initial + 4, "four total ticks after the initial render");
     });
     it("start() is idempotent — calling twice does not leak intervals", () => {
         loader = new Loader(tui, (s) => s, (s) => s, "test");
-        // Constructor calls start() once, call it again
+        // Constructor already started one interval. Call start() again.
         loader.start();
-        // stop() should clear the interval cleanly without orphaned timers
+        const before = tui.requestRender.mock.callCount();
+        mock.timers.tick(80);
+        const after = tui.requestRender.mock.callCount();
+        // Exactly ONE tick's worth of work should happen — if the second
+        // start() leaked an interval, we'd see two increments per tick.
+        assert.equal(after - before, 1, "double-start must not double-tick (interval leak would show 2 increments)");
+    });
+    it("stop() clears the interval — no more ticks advance requestRender", () => {
+        loader = new Loader(tui, (s) => s, (s) => s, "test");
         loader.stop();
+        const beforeTick = tui.requestRender.mock.callCount();
+        mock.timers.tick(400); // 5 tick intervals
+        assert.equal(tui.requestRender.mock.callCount(), beforeTick, "stopped loader must not advance renders");
     });
     it("dispose() stops the interval and nulls the TUI reference", () => {
         loader = new Loader(tui, (s) => s, (s) => s, "test");
         loader.dispose();
-        // After dispose, calling stop() again should be safe (no-op)
-        loader.stop();
+        const beforeTick = tui.requestRender.mock.callCount();
+        mock.timers.tick(400);
+        assert.equal(tui.requestRender.mock.callCount(), beforeTick, "disposed loader must not advance renders");
+        // Calling stop() after dispose() must not throw.
+        assert.doesNotThrow(() => loader.stop());
     });
-    it("stop() is safe to call multiple times", () => {
+    it("stop() is safe to call multiple times without throwing", () => {
         loader = new Loader(tui, (s) => s, (s) => s, "test");
         loader.stop();
-        loader.stop();
-        loader.stop();
+        assert.doesNotThrow(() => loader.stop());
+        assert.doesNotThrow(() => loader.stop());
     });
 });
 //# sourceMappingURL=loader.test.js.map

package/packages/pi-tui/dist/components/__tests__/loader.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"loader.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/loader.test.ts"],"names":[],"mappings":"AAAA,2CAA2C;AAC3C,4DAA4D;AAE5D,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,WAAW,CAAC;AAEtE,OAAO,EAAE,MAAM,EAAE,MAAM,cAAc,CAAC;AAEtC,SAAS,WAAW;IACnB,OAAO,EAAE,aAAa,EAAE,IAAI,CAAC,EAAE,EAAE,EAAS,CAAC;AAC5C,CAAC;AAED,QAAQ,CAAC,QAAQ,EAAE,GAAG,EAAE;IACvB,IAAI,MAAc,CAAC;IACnB,IAAI,GAAmC,CAAC;IAExC,UAAU,CAAC,GAAG,EAAE;QACf,GAAG,GAAG,WAAW,EAAE,CAAC;IACrB,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACd,MAAM,EAAE,IAAI,EAAE,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACxE,MAAM,GAAG,IAAI,MAAM,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QACrD,gDAAgD;QAChD,MAAM,CAAC,KAAK,EAAE,CAAC;QACf,mEAAmE;QACnE,MAAM,CAAC,IAAI,EAAE,CAAC;IACf,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QACnE,MAAM,GAAG,IAAI,MAAM,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QACrD,MAAM,CAAC,OAAO,EAAE,CAAC;QACjB,6DAA6D;QAC7D,MAAM,CAAC,IAAI,EAAE,CAAC;IACf,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAChD,MAAM,GAAG,IAAI,MAAM,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QACrD,MAAM,CAAC,IAAI,EAAE,CAAC;QACd,MAAM,CAAC,IAAI,EAAE,CAAC;QACd,MAAM,CAAC,IAAI,EAAE,CAAC;IACf,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["// pi-tui Loader component regression tests\n// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>\n\nimport { describe, it, mock, beforeEach, afterEach } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Loader } from \"../loader.js\";\n\nfunction makeMockTUI() {\n\treturn { requestRender: mock.fn() } as any;\n}\n\ndescribe(\"Loader\", () => {\n\tlet loader: Loader;\n\tlet tui: ReturnType<typeof makeMockTUI>;\n\n\tbeforeEach(() => {\n\t\ttui = makeMockTUI();\n\t});\n\n\tafterEach(() => {\n\t\tloader?.stop();\n\t});\n\n\tit(\"start() is idempotent — calling twice does not leak intervals\", () => {\n\t\tloader = new Loader(tui, (s) => s, (s) => s, \"test\");\n\t\t// Constructor calls start() once, call it again\n\t\tloader.start();\n\t\t// stop() should clear the interval cleanly without orphaned timers\n\t\tloader.stop();\n\t});\n\n\tit(\"dispose() stops the interval and nulls the TUI reference\", () => {\n\t\tloader = new Loader(tui, (s) => s, (s) => s, \"test\");\n\t\tloader.dispose();\n\t\t// After dispose, calling stop() again should be safe (no-op)\n\t\tloader.stop();\n\t});\n\n\tit(\"stop() is safe to call multiple times\", () => {\n\t\tloader = new Loader(tui, (s) => s, (s) => s, \"test\");\n\t\tloader.stop();\n\t\tloader.stop();\n\t\tloader.stop();\n\t});\n});\n"]}
+{"version":3,"file":"loader.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/loader.test.ts"],"names":[],"mappings":"AAAA,2CAA2C;AAC3C,EAAE;AACF,kEAAkE;AAClE,yEAAyE;AACzE,sEAAsE;AACtE,iBAAiB;AACjB,EAAE;AACF,sEAAsE;AACtE,oEAAoE;AACpE,oEAAoE;AACpE,uEAAuE;AACvE,uEAAuE;AAEvE,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,WAAW,CAAC;AACtE,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,MAAM,EAAE,MAAM,cAAc,CAAC;AAMtC,SAAS,WAAW;IAClB,OAAO,EAAE,aAAa,EAAE,IAAI,CAAC,EAAE,EAAE,EAAE,CAAC;AACtC,CAAC;AAED,QAAQ,CAAC,QAAQ,EAAE,GAAG,EAAE;IACtB,IAAI,MAAc,CAAC;IACnB,IAAI,GAAY,CAAC;IAEjB,UAAU,CAAC,GAAG,EAAE;QACd,GAAG,GAAG,WAAW,EAAE,CAAC;QACpB,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,CAAC,aAAa,CAAC,EAAE,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,IAAI,CAAC;YACH,MAAM,EAAE,IAAI,EAAE,CAAC;QACjB,CAAC;QAAC,MAAM,CAAC;YACP,iBAAiB;QACnB,CAAC;QACD,IAAI,CAAC,MAAM,CAAC,KAAK,EAAE,CAAC;IACtB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QACjF,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QAC9D,uCAAuC;QACvC,MAAM,OAAO,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;QACnD,MAAM,CAAC,EAAE,CACP,OAAO,IAAI,CAAC,EACZ,uDAAuD,OAAO,GAAG,CAClE,CAAC;QAEF,wEAAwE;QACxE,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACrB,MAAM,CAAC,KAAK,CACV,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,EAClC,OAAO,GAAG,CAAC,EACX,6DAA6D,CAC9D,CAAC;QAEF,4CAA4C;QAC5C,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACtB,MAAM,CAAC,KAAK,CACV,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,EAClC,OAAO,GAAG,CAAC,EACX,2CAA2C,CAC5C,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QAC9D,gEAAgE;QAChE,MAAM,CAAC,KAAK,EAAE,CAAC;QAEf,MAAM,MAAM,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;QAClD,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACrB,MAAM,KAAK,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;QACjD,iEAAiE;QACjE,gEAAgE;QAChE,MAAM,CAAC,KAAK,CACV,KAAK,GAAG,MAAM,EACd,CAAC,EACD,2EAA2E,CAC5E,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;QAC1E,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QAC9D,MAAM,CAAC,IAAI,EAAE,CAAC;QAEd,MAAM,UAAU,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;QACtD,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,mBAAmB;QAC1C,MAAM,CAAC,KAAK,CACV,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,EAClC,UAAU,EACV,yCAAyC,CAC1C,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QAC9D,MAAM,CAAC,OAAO,EAAE,CAAC;QAEjB,MAAM,UAAU,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;QACtD,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACtB,MAAM,CAAC,KAAK,CACV,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,SAAS,EAAE,EAClC,UAAU,EACV,0CAA0C,CAC3C,CAAC;QAEF,iDAAiD;QACjD,MAAM,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QAChE,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QAC9D,MAAM,CAAC,IAAI,EAAE,CAAC;QACd,MAAM,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC;QACzC,MAAM,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["// pi-tui Loader component regression tests\n//\n// The previous version of this file contained 3 tests that called\n// `start()`/`stop()`/`dispose()` with no assertions at all — the claimed\n// regression (\"interval leak\") would not have failed any of them. See\n// #4794 / #4784.\n//\n// This rewrite uses Node's `mock.timers` to observe the interval that\n// `Loader` registers internally, and `mock.fn()` on the mock TUI to\n// count render requests. Each test asserts on observable behaviour:\n// how many `requestRender` calls happen per tick, whether the interval\n// is cleared on stop/dispose, and whether post-dispose stop() is safe.\n\nimport { describe, it, mock, beforeEach, afterEach } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Loader } from \"../loader.js\";\n\ninterface MockTui {\n  requestRender: ReturnType<typeof mock.fn>;\n}\n\nfunction makeMockTUI(): MockTui {\n  return { requestRender: mock.fn() };\n}\n\ndescribe(\"Loader\", () => {\n  let loader: Loader;\n  let tui: MockTui;\n\n  beforeEach(() => {\n    tui = makeMockTUI();\n    mock.timers.enable({ apis: [\"setInterval\"] });\n  });\n\n  afterEach(() => {\n    try {\n      loader?.stop();\n    } catch {\n      /* best-effort */\n    }\n    mock.timers.reset();\n  });\n\n  it(\"constructor starts a spinner that ticks every 80ms and requests renders\", () => {\n    loader = new Loader(tui as never, (s) => s, (s) => s, \"test\");\n    // Initial render request from start().\n    const initial = tui.requestRender.mock.callCount();\n    assert.ok(\n      initial >= 1,\n      `constructor should trigger at least one render (got ${initial})`,\n    );\n\n    // Advance 80ms — one interval tick should call requestRender once more.\n    mock.timers.tick(80);\n    assert.equal(\n      tui.requestRender.mock.callCount(),\n      initial + 1,\n      \"80ms tick should advance the spinner and call requestRender\",\n    );\n\n    // Advance another 240ms — three more ticks.\n    mock.timers.tick(240);\n    assert.equal(\n      tui.requestRender.mock.callCount(),\n      initial + 4,\n      \"four total ticks after the initial render\",\n    );\n  });\n\n  it(\"start() is idempotent — calling twice does not leak intervals\", () => {\n    loader = new Loader(tui as never, (s) => s, (s) => s, \"test\");\n    // Constructor already started one interval. Call start() again.\n    loader.start();\n\n    const before = tui.requestRender.mock.callCount();\n    mock.timers.tick(80);\n    const after = tui.requestRender.mock.callCount();\n    // Exactly ONE tick's worth of work should happen — if the second\n    // start() leaked an interval, we'd see two increments per tick.\n    assert.equal(\n      after - before,\n      1,\n      \"double-start must not double-tick (interval leak would show 2 increments)\",\n    );\n  });\n\n  it(\"stop() clears the interval — no more ticks advance requestRender\", () => {\n    loader = new Loader(tui as never, (s) => s, (s) => s, \"test\");\n    loader.stop();\n\n    const beforeTick = tui.requestRender.mock.callCount();\n    mock.timers.tick(400); // 5 tick intervals\n    assert.equal(\n      tui.requestRender.mock.callCount(),\n      beforeTick,\n      \"stopped loader must not advance renders\",\n    );\n  });\n\n  it(\"dispose() stops the interval and nulls the TUI reference\", () => {\n    loader = new Loader(tui as never, (s) => s, (s) => s, \"test\");\n    loader.dispose();\n\n    const beforeTick = tui.requestRender.mock.callCount();\n    mock.timers.tick(400);\n    assert.equal(\n      tui.requestRender.mock.callCount(),\n      beforeTick,\n      \"disposed loader must not advance renders\",\n    );\n\n    // Calling stop() after dispose() must not throw.\n    assert.doesNotThrow(() => loader.stop());\n  });\n\n  it(\"stop() is safe to call multiple times without throwing\", () => {\n    loader = new Loader(tui as never, (s) => s, (s) => s, \"test\");\n    loader.stop();\n    assert.doesNotThrow(() => loader.stop());\n    assert.doesNotThrow(() => loader.stop());\n  });\n});\n"]}

package/packages/pi-tui/dist/components/__tests__/markdown-maxlines.test.js

@@ -59,8 +59,12 @@ test("Markdown trims trailing empty lines", () => {
     const text = "Some text\n\n";
     const md = new Markdown(text, 0, 0, noopTheme());
     const lines = md.render(80);
-    // Last line should not be empty (trailing empties are trimmed)
+    // Previous assertion was `lastLine.trim().length > 0 || lines.length === 1`
+    // — the `|| lines.length === 1` disjunction trivially passed for any
+    // single-line render, so a regression that returned `['']` still
+    // passed (#4796). Assert the trim invariant directly.
+    assert.ok(lines.length > 0, "render must produce at least one line");
     const lastLine = lines[lines.length - 1];
-    assert.ok(lastLine.trim().length > 0 || lines.length === 1, "trailing empty lines should be trimmed");
+    assert.ok(lastLine.trim().length > 0, `last line must have visible content after trim, got: ${JSON.stringify(lastLine)}`);
 });
 //# sourceMappingURL=markdown-maxlines.test.js.map

package/packages/pi-tui/dist/components/__tests__/markdown-maxlines.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"markdown-maxlines.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/markdown-maxlines.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAEjC,OAAO,EAAE,QAAQ,EAAsB,MAAM,gBAAgB,CAAC;AAE9D,SAAS,SAAS;IACjB,MAAM,QAAQ,GAAG,CAAC,IAAY,EAAE,EAAE,CAAC,IAAI,CAAC;IACxC,OAAO;QACN,OAAO,EAAE,QAAQ;QACjB,IAAI,EAAE,QAAQ;QACd,OAAO,EAAE,QAAQ;QACjB,IAAI,EAAE,QAAQ;QACd,SAAS,EAAE,QAAQ;QACnB,eAAe,EAAE,QAAQ;QACzB,KAAK,EAAE,QAAQ;QACf,WAAW,EAAE,QAAQ;QACrB,EAAE,EAAE,QAAQ;QACZ,UAAU,EAAE,QAAQ;QACpB,IAAI,EAAE,QAAQ;QACd,MAAM,EAAE,QAAQ;QAChB,aAAa,EAAE,QAAQ;QACvB,SAAS,EAAE,QAAQ;KACnB,CAAC;AACH,CAAC;AAED,IAAI,CAAC,qDAAqD,EAAE,GAAG,EAAE;IAChE,MAAM,IAAI,GAAG,gDAAgD,CAAC;IAC9D,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,iEAAiE;IACjE,MAAM,YAAY,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC9D,MAAM,CAAC,EAAE,CAAC,YAAY,CAAC,MAAM,IAAI,CAAC,EAAE,0CAA0C,YAAY,CAAC,MAAM,EAAE,CAAC,CAAC;AACtG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2DAA2D,EAAE,GAAG,EAAE;IACtE,MAAM,IAAI,GAAG,gDAAgD,CAAC;IAC9D,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,EAAE,CAAC,QAAQ,GAAG,CAAC,CAAC;IAChB,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,MAAM,IAAI,CAAC,EAAE,iCAAiC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC;IAC9E,8CAA8C;IAC9C,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,8CAA8C,CAAC,CAAC;IAClF,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,OAAO,CAAC,EAAE,uCAAuC,CAAC,CAAC;AAChF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wDAAwD,EAAE,GAAG,EAAE;IACnE,MAAM,IAAI,GAAG,+FAA+F,CAAC;IAC7G,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,EAAE,CAAC,QAAQ,GAAG,CAAC,CAAC;IAChB,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,oFAAoF;IACpF,MAAM,eAAe,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,CAAC;IAC1E,MAAM,CAAC,EAAE,CACR,eAAe,CAAC,QAAQ,CAAC,iBAAiB,CAAC,EAC3C,iEAAiE,eAAe,GAAG,CACnF,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,8DAA8D,EAAE,GAAG,EAAE;IACzE,MAAM,IAAI,GAAG,YAAY,CAAC;IAC1B,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,EAAE,CAAC,QAAQ,GAAG,EAAE,CAAC;IACjB,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,MAAM,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,+CAA+C,CAAC,CAAC;IAChG,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,EAAE,kCAAkC,CAAC,CAAC;AAC5F,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qCAAqC,EAAE,GAAG,EAAE;IAChD,MAAM,IAAI,GAAG,eAAe,CAAC;IAC7B,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,+DAA+D;IAC/D,MAAM,QAAQ,GAAG,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IACzC,MAAM,CAAC,EAAE,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,wCAAwC,CAAC,CAAC;AACvG,CAAC,CAAC,CAAC","sourcesContent":["import assert from \"node:assert/strict\";\nimport { test } from \"node:test\";\n\nimport { Markdown, type MarkdownTheme } from \"../markdown.js\";\n\nfunction noopTheme(): MarkdownTheme {\n\tconst identity = (text: string) => text;\n\treturn {\n\t\theading: identity,\n\t\tlink: identity,\n\t\tlinkUrl: identity,\n\t\tcode: identity,\n\t\tcodeBlock: identity,\n\t\tcodeBlockBorder: identity,\n\t\tquote: identity,\n\t\tquoteBorder: identity,\n\t\thr: identity,\n\t\tlistBullet: identity,\n\t\tbold: identity,\n\t\titalic: identity,\n\t\tstrikethrough: identity,\n\t\tunderline: identity,\n\t};\n}\n\ntest(\"Markdown renders all lines when maxLines is not set\", () => {\n\tconst text = \"Line 1\\n\\nLine 2\\n\\nLine 3\\n\\nLine 4\\n\\nLine 5\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tconst lines = md.render(80);\n\t// Each paragraph produces a line + an inter-paragraph blank line\n\tconst contentLines = lines.filter((l) => l.trim().length > 0);\n\tassert.ok(contentLines.length >= 5, `expected at least 5 content lines, got ${contentLines.length}`);\n});\n\ntest(\"Markdown truncates from the top when maxLines is exceeded\", () => {\n\tconst text = \"Line 1\\n\\nLine 2\\n\\nLine 3\\n\\nLine 4\\n\\nLine 5\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tmd.maxLines = 3;\n\tconst lines = md.render(80);\n\tassert.ok(lines.length <= 3, `expected at most 3 lines, got ${lines.length}`);\n\t// First line should be the ellipsis indicator\n\tassert.ok(lines[0].includes(\"…\"), \"first line should contain ellipsis indicator\");\n\tassert.ok(lines[0].includes(\"above\"), \"first line should mention lines above\");\n});\n\ntest(\"Markdown preserves most recent content when truncating\", () => {\n\tconst text = \"First paragraph\\n\\nSecond paragraph\\n\\nThird paragraph\\n\\nFourth paragraph\\n\\nFifth paragraph\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tmd.maxLines = 3;\n\tconst lines = md.render(80);\n\t// The last rendered line should contain \"Fifth paragraph\" (the most recent content)\n\tconst lastContentLine = lines.filter((l) => !l.includes(\"…\")).pop() ?? \"\";\n\tassert.ok(\n\t\tlastContentLine.includes(\"Fifth paragraph\"),\n\t\t`expected last content line to contain \"Fifth paragraph\", got \"${lastContentLine}\"`,\n\t);\n});\n\ntest(\"Markdown does not truncate when content fits within maxLines\", () => {\n\tconst text = \"Short text\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tmd.maxLines = 10;\n\tconst lines = md.render(80);\n\tassert.ok(!lines.some((l) => l.includes(\"…\")), \"should not contain ellipsis when content fits\");\n\tassert.ok(lines.some((l) => l.includes(\"Short text\")), \"should contain the original text\");\n});\n\ntest(\"Markdown trims trailing empty lines\", () => {\n\tconst text = \"Some text\\n\\n\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tconst lines = md.render(80);\n\t// Last line should not be empty (trailing empties are trimmed)\n\tconst lastLine = lines[lines.length - 1];\n\tassert.ok(lastLine.trim().length > 0 || lines.length === 1, \"trailing empty lines should be trimmed\");\n});\n"]}
+{"version":3,"file":"markdown-maxlines.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/markdown-maxlines.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAEjC,OAAO,EAAE,QAAQ,EAAsB,MAAM,gBAAgB,CAAC;AAE9D,SAAS,SAAS;IACjB,MAAM,QAAQ,GAAG,CAAC,IAAY,EAAE,EAAE,CAAC,IAAI,CAAC;IACxC,OAAO;QACN,OAAO,EAAE,QAAQ;QACjB,IAAI,EAAE,QAAQ;QACd,OAAO,EAAE,QAAQ;QACjB,IAAI,EAAE,QAAQ;QACd,SAAS,EAAE,QAAQ;QACnB,eAAe,EAAE,QAAQ;QACzB,KAAK,EAAE,QAAQ;QACf,WAAW,EAAE,QAAQ;QACrB,EAAE,EAAE,QAAQ;QACZ,UAAU,EAAE,QAAQ;QACpB,IAAI,EAAE,QAAQ;QACd,MAAM,EAAE,QAAQ;QAChB,aAAa,EAAE,QAAQ;QACvB,SAAS,EAAE,QAAQ;KACnB,CAAC;AACH,CAAC;AAED,IAAI,CAAC,qDAAqD,EAAE,GAAG,EAAE;IAChE,MAAM,IAAI,GAAG,gDAAgD,CAAC;IAC9D,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,iEAAiE;IACjE,MAAM,YAAY,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC9D,MAAM,CAAC,EAAE,CAAC,YAAY,CAAC,MAAM,IAAI,CAAC,EAAE,0CAA0C,YAAY,CAAC,MAAM,EAAE,CAAC,CAAC;AACtG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2DAA2D,EAAE,GAAG,EAAE;IACtE,MAAM,IAAI,GAAG,gDAAgD,CAAC;IAC9D,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,EAAE,CAAC,QAAQ,GAAG,CAAC,CAAC;IAChB,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,MAAM,IAAI,CAAC,EAAE,iCAAiC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC;IAC9E,8CAA8C;IAC9C,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,8CAA8C,CAAC,CAAC;IAClF,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,OAAO,CAAC,EAAE,uCAAuC,CAAC,CAAC;AAChF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wDAAwD,EAAE,GAAG,EAAE;IACnE,MAAM,IAAI,GAAG,+FAA+F,CAAC;IAC7G,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,EAAE,CAAC,QAAQ,GAAG,CAAC,CAAC;IAChB,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,oFAAoF;IACpF,MAAM,eAAe,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,CAAC;IAC1E,MAAM,CAAC,EAAE,CACR,eAAe,CAAC,QAAQ,CAAC,iBAAiB,CAAC,EAC3C,iEAAiE,eAAe,GAAG,CACnF,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,8DAA8D,EAAE,GAAG,EAAE;IACzE,MAAM,IAAI,GAAG,YAAY,CAAC;IAC1B,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,EAAE,CAAC,QAAQ,GAAG,EAAE,CAAC;IACjB,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,MAAM,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,+CAA+C,CAAC,CAAC;IAChG,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,EAAE,kCAAkC,CAAC,CAAC;AAC5F,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qCAAqC,EAAE,GAAG,EAAE;IAChD,MAAM,IAAI,GAAG,eAAe,CAAC;IAC7B,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC;IACjD,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC5B,4EAA4E;IAC5E,qEAAqE;IACrE,iEAAiE;IACjE,sDAAsD;IACtD,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,uCAAuC,CAAC,CAAC;IACrE,MAAM,QAAQ,GAAG,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IACzC,MAAM,CAAC,EAAE,CACR,QAAQ,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAC1B,wDAAwD,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,EAAE,CAClF,CAAC;AACH,CAAC,CAAC,CAAC","sourcesContent":["import assert from \"node:assert/strict\";\nimport { test } from \"node:test\";\n\nimport { Markdown, type MarkdownTheme } from \"../markdown.js\";\n\nfunction noopTheme(): MarkdownTheme {\n\tconst identity = (text: string) => text;\n\treturn {\n\t\theading: identity,\n\t\tlink: identity,\n\t\tlinkUrl: identity,\n\t\tcode: identity,\n\t\tcodeBlock: identity,\n\t\tcodeBlockBorder: identity,\n\t\tquote: identity,\n\t\tquoteBorder: identity,\n\t\thr: identity,\n\t\tlistBullet: identity,\n\t\tbold: identity,\n\t\titalic: identity,\n\t\tstrikethrough: identity,\n\t\tunderline: identity,\n\t};\n}\n\ntest(\"Markdown renders all lines when maxLines is not set\", () => {\n\tconst text = \"Line 1\\n\\nLine 2\\n\\nLine 3\\n\\nLine 4\\n\\nLine 5\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tconst lines = md.render(80);\n\t// Each paragraph produces a line + an inter-paragraph blank line\n\tconst contentLines = lines.filter((l) => l.trim().length > 0);\n\tassert.ok(contentLines.length >= 5, `expected at least 5 content lines, got ${contentLines.length}`);\n});\n\ntest(\"Markdown truncates from the top when maxLines is exceeded\", () => {\n\tconst text = \"Line 1\\n\\nLine 2\\n\\nLine 3\\n\\nLine 4\\n\\nLine 5\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tmd.maxLines = 3;\n\tconst lines = md.render(80);\n\tassert.ok(lines.length <= 3, `expected at most 3 lines, got ${lines.length}`);\n\t// First line should be the ellipsis indicator\n\tassert.ok(lines[0].includes(\"…\"), \"first line should contain ellipsis indicator\");\n\tassert.ok(lines[0].includes(\"above\"), \"first line should mention lines above\");\n});\n\ntest(\"Markdown preserves most recent content when truncating\", () => {\n\tconst text = \"First paragraph\\n\\nSecond paragraph\\n\\nThird paragraph\\n\\nFourth paragraph\\n\\nFifth paragraph\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tmd.maxLines = 3;\n\tconst lines = md.render(80);\n\t// The last rendered line should contain \"Fifth paragraph\" (the most recent content)\n\tconst lastContentLine = lines.filter((l) => !l.includes(\"…\")).pop() ?? \"\";\n\tassert.ok(\n\t\tlastContentLine.includes(\"Fifth paragraph\"),\n\t\t`expected last content line to contain \"Fifth paragraph\", got \"${lastContentLine}\"`,\n\t);\n});\n\ntest(\"Markdown does not truncate when content fits within maxLines\", () => {\n\tconst text = \"Short text\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tmd.maxLines = 10;\n\tconst lines = md.render(80);\n\tassert.ok(!lines.some((l) => l.includes(\"…\")), \"should not contain ellipsis when content fits\");\n\tassert.ok(lines.some((l) => l.includes(\"Short text\")), \"should contain the original text\");\n});\n\ntest(\"Markdown trims trailing empty lines\", () => {\n\tconst text = \"Some text\\n\\n\";\n\tconst md = new Markdown(text, 0, 0, noopTheme());\n\tconst lines = md.render(80);\n\t// Previous assertion was `lastLine.trim().length > 0 || lines.length === 1`\n\t// — the `|| lines.length === 1` disjunction trivially passed for any\n\t// single-line render, so a regression that returned `['']` still\n\t// passed (#4796). Assert the trim invariant directly.\n\tassert.ok(lines.length > 0, \"render must produce at least one line\");\n\tconst lastLine = lines[lines.length - 1];\n\tassert.ok(\n\t\tlastLine.trim().length > 0,\n\t\t`last line must have visible content after trim, got: ${JSON.stringify(lastLine)}`,\n\t);\n});\n"]}

package/packages/pi-tui/dist/components/image.test.js

@@ -7,12 +7,13 @@ import assert from "node:assert/strict";
 import { Image } from "./image.js";
 describe("Image component (#3455)", () => {
     const theme = { fallbackColor: (s) => s };
-    test("getDimensions returns undefined before resolution", () => {
-        // Pass explicit dimensions to avoid async parsing
+    test("getDimensions returns undefined when constructed without explicit dims", () => {
+        // Previously this test was titled "returns undefined before resolution"
+        // but only asserted `typeof getDimensions === 'function'`. The title
+        // and the assertion had nothing to do with each other (#4794).
+        // Now actually assert the undefined return.
         const img = new Image("base64data", "image/png", theme, {});
-        // Without explicit dims, getDimensions should be undefined until async resolve
-        // But we can't easily test async here, so verify the method exists
-        assert.equal(typeof img.getDimensions, "function");
+        assert.equal(img.getDimensions(), undefined, "without pre-resolved dims, getDimensions must return undefined until async resolve");
     });
     test("getDimensions returns dimensions when provided at construction", () => {
         const dims = { widthPx: 100, heightPx: 200 };

package/packages/pi-tui/dist/components/image.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"image.test.js","sourceRoot":"","sources":["../../src/components/image.test.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC3C,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,KAAK,EAAE,MAAM,YAAY,CAAC;AAEnC,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACxC,MAAM,KAAK,GAAG,EAAE,aAAa,EAAE,CAAC,CAAS,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC;IAElD,IAAI,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC9D,kDAAkD;QAClD,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;QAC5D,+EAA+E;QAC/E,mEAAmE;QACnE,MAAM,CAAC,KAAK,CAAC,OAAO,GAAG,CAAC,aAAa,EAAE,UAAU,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;QAC3E,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,MAAM,MAAM,GAAG,GAAG,CAAC,aAAa,EAAE,CAAC;QACnC,MAAM,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,mCAAmC,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,sEAAsE,EAAE,GAAG,EAAE;QACjF,IAAI,SAAS,GAAG,CAAC,CAAC;QAClB,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,GAAG,CAAC,uBAAuB,CAAC,GAAG,EAAE,GAAG,SAAS,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;QACpD,6DAA6D;QAC7D,MAAM,CAAC,KAAK,CAAC,SAAS,EAAE,CAAC,EAAE,sDAAsD,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Regression test for #3455: Image component must not trigger infinite\n * re-render loop when dimensions resolve in cmux sessions.\n */\n\nimport { describe, test } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Image } from \"./image.js\";\n\ndescribe(\"Image component (#3455)\", () => {\n\tconst theme = { fallbackColor: (s: string) => s };\n\n\ttest(\"getDimensions returns undefined before resolution\", () => {\n\t\t// Pass explicit dimensions to avoid async parsing\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {});\n\t\t// Without explicit dims, getDimensions should be undefined until async resolve\n\t\t// But we can't easily test async here, so verify the method exists\n\t\tassert.equal(typeof img.getDimensions, \"function\");\n\t});\n\n\ttest(\"getDimensions returns dimensions when provided at construction\", () => {\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\tconst result = img.getDimensions();\n\t\tassert.deepEqual(result, dims, \"Should return provided dimensions\");\n\t});\n\n\ttest(\"onDimensionsResolved callback is not called when dimensions provided\", () => {\n\t\tlet callCount = 0;\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\timg.setOnDimensionsResolved(() => { callCount++; });\n\t\t// With pre-resolved dims, the async path is skipped entirely\n\t\tassert.equal(callCount, 0, \"Callback should not fire for pre-resolved dimensions\");\n\t});\n});\n"]}
+{"version":3,"file":"image.test.js","sourceRoot":"","sources":["../../src/components/image.test.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC3C,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,KAAK,EAAE,MAAM,YAAY,CAAC;AAEnC,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACxC,MAAM,KAAK,GAAG,EAAE,aAAa,EAAE,CAAC,CAAS,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC;IAElD,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;QACnF,wEAAwE;QACxE,qEAAqE;QACrE,+DAA+D;QAC/D,4CAA4C;QAC5C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;QAC5D,MAAM,CAAC,KAAK,CACX,GAAG,CAAC,aAAa,EAAE,EACnB,SAAS,EACT,oFAAoF,CACpF,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;QAC3E,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,MAAM,MAAM,GAAG,GAAG,CAAC,aAAa,EAAE,CAAC;QACnC,MAAM,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,mCAAmC,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,sEAAsE,EAAE,GAAG,EAAE;QACjF,IAAI,SAAS,GAAG,CAAC,CAAC;QAClB,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,GAAG,CAAC,uBAAuB,CAAC,GAAG,EAAE,GAAG,SAAS,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;QACpD,6DAA6D;QAC7D,MAAM,CAAC,KAAK,CAAC,SAAS,EAAE,CAAC,EAAE,sDAAsD,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Regression test for #3455: Image component must not trigger infinite\n * re-render loop when dimensions resolve in cmux sessions.\n */\n\nimport { describe, test } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Image } from \"./image.js\";\n\ndescribe(\"Image component (#3455)\", () => {\n\tconst theme = { fallbackColor: (s: string) => s };\n\n\ttest(\"getDimensions returns undefined when constructed without explicit dims\", () => {\n\t\t// Previously this test was titled \"returns undefined before resolution\"\n\t\t// but only asserted `typeof getDimensions === 'function'`. The title\n\t\t// and the assertion had nothing to do with each other (#4794).\n\t\t// Now actually assert the undefined return.\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {});\n\t\tassert.equal(\n\t\t\timg.getDimensions(),\n\t\t\tundefined,\n\t\t\t\"without pre-resolved dims, getDimensions must return undefined until async resolve\",\n\t\t);\n\t});\n\n\ttest(\"getDimensions returns dimensions when provided at construction\", () => {\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\tconst result = img.getDimensions();\n\t\tassert.deepEqual(result, dims, \"Should return provided dimensions\");\n\t});\n\n\ttest(\"onDimensionsResolved callback is not called when dimensions provided\", () => {\n\t\tlet callCount = 0;\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\timg.setOnDimensionsResolved(() => { callCount++; });\n\t\t// With pre-resolved dims, the async path is skipped entirely\n\t\tassert.equal(callCount, 0, \"Callback should not fire for pre-resolved dimensions\");\n\t});\n});\n"]}

package/packages/pi-tui/src/__tests__/autocomplete.test.ts

@@ -127,20 +127,36 @@ describe("CombinedAutocompleteProvider — argument completions", () => {
 });
 
 describe("CombinedAutocompleteProvider — @ file prefix extraction", () => {
-	it("detects @ at start of line", () => {
+	it("detects @ at start of line and returns a valid suggestion shape", () => {
 		const provider = makeProvider();
-		// @ triggers fuzzy file search — we can't test the actual file results
-		// but we can test that getSuggestions returns null (no files in /tmp matching)
-		// rather than crashing
 		const result = provider.getSuggestions(["@nonexistent_xyz"], 0, 16);
-		// May return null or empty — the key thing is it doesn't crash
-		assert.ok(result === null || result.items.length >= 0);
+		// Either null (nothing matched) or a well-formed {items: Array, prefix: string}
+		// shape. Previous version's `result.items.length >= 0` was a tautology —
+		// array length is always ≥ 0; the whole expression could never fail.
+		if (result !== null) {
+			assert.ok(Array.isArray(result.items), "result.items must be an array");
+			// The @-prefix extraction strips the leading @ — prefix should be
+			// the raw text without the trigger character.
+			assert.equal(typeof result.prefix, "string", "prefix must be a string");
+			assert.ok(
+				!result.prefix.startsWith("@"),
+				`prefix must have the @ trigger stripped, got: ${JSON.stringify(result.prefix)}`,
+			);
+		}
 	});
 
-	it("detects @ after space", () => {
+	it("detects @ after space and returns a valid suggestion shape", () => {
 		const provider = makeProvider();
 		const result = provider.getSuggestions(["check @nonexistent_xyz"], 0, 22);
-		assert.ok(result === null || result.items.length >= 0);
+		if (result !== null) {
+			assert.ok(Array.isArray(result.items), "result.items must be an array");
+			assert.equal(typeof result.prefix, "string", "prefix must be a string");
+			// The prefix must NOT include the word "check" that came before the @.
+			assert.ok(
+				!result.prefix.includes("check"),
+				`prefix must not include text before the @, got: ${JSON.stringify(result.prefix)}`,
+			);
+		}
 	});
 
 	it("returns null for bare @ with no query to avoid full tree walk (#1824)", () => {

package/packages/pi-tui/src/__tests__/overlay-layout.test.ts

@@ -1,4 +1,16 @@
 // pi-tui — Overlay Layout Tests (backdrop dimming)
+//
+// These tests previously coupled to literal ANSI escape bytes
+// (`\x1b[2m`, `\x1b[38;5;240m`) and would break if the palette index or
+// SGR spelling changed despite identical rendered output — Goodhart's law:
+// the test measures escape codes, not dimming.
+//
+// We now parse the SGR escape codes into a semantic style state and assert
+// on the visible contract: the covered-but-outside-overlay region is dim,
+// has a non-default foreground (so the eye can distinguish foreground from
+// background), and does not paint the terminal background (so user themes
+// are preserved). The overlay content itself is reachable via plain-text
+// lookup after stripping ANSI.
 
 import { describe, it } from "node:test";
 import assert from "node:assert/strict";
@@ -16,8 +28,107 @@ function makeEntry(
 	};
 }
 
+/**
+ * Parse a line's ANSI SGR state immediately before the first occurrence of a
+ * target substring in the rendered (ANSI-stripped) text. Walks `\x1b[...m`
+ * sequences left-to-right, maintaining a running state so we can ask what
+ * the terminal is doing when it reaches the target glyphs.
+ *
+ * Semantic fields:
+ *   - dim:    SGR 2 active and not reset by SGR 22 / 0
+ *   - fg:     foreground: "default" | "set" | the raw numeric parameters
+ *   - bg:     background: "default" | "set"
+ */
+type SgrState = { dim: boolean; fg: "default" | "set"; bg: "default" | "set" };
+
+function sgrStateAtGlyph(line: string, targetGlyph: string): SgrState {
+	const state: SgrState = { dim: false, fg: "default", bg: "default" };
+	// Walk codes and visible chars, tracking visible-glyph position.
+	let visibleSeen = "";
+	let i = 0;
+	while (i < line.length) {
+		if (line[i] === "\x1b" && line[i + 1] === "[") {
+			// Read until final byte in 0x40-0x7E
+			let j = i + 2;
+			while (j < line.length) {
+				const c = line.charCodeAt(j);
+				if (c >= 0x40 && c <= 0x7e) break;
+				j++;
+			}
+			const final = line[j];
+			if (final === "m") {
+				const paramString = line.slice(i + 2, j);
+				applySgr(state, paramString);
+			}
+			i = j + 1;
+			continue;
+		}
+		// Skip other escape sequences (OSC hyperlinks etc) conservatively:
+		// if we ever hit a non-SGR escape, just step past the ESC.
+		if (line[i] === "\x1b") {
+			i++;
+			continue;
+		}
+		visibleSeen += line[i];
+		if (visibleSeen.endsWith(targetGlyph)) {
+			// We've just consumed the last char of targetGlyph — return the
+			// state that was in effect for the whole match.
+			return state;
+		}
+		i++;
+	}
+	throw new Error(`Target glyph ${JSON.stringify(targetGlyph)} not found in line`);
+}
+
+function applySgr(state: SgrState, paramString: string): void {
+	// Empty params == reset
+	const parts = paramString === "" ? ["0"] : paramString.split(";");
+	let k = 0;
+	while (k < parts.length) {
+		const n = parts[k] === "" ? 0 : Number(parts[k]);
+		if (n === 0) {
+			state.dim = false;
+			state.fg = "default";
+			state.bg = "default";
+		} else if (n === 2) {
+			state.dim = true;
+		} else if (n === 22) {
+			state.dim = false;
+		} else if (n === 39) {
+			state.fg = "default";
+		} else if (n === 49) {
+			state.bg = "default";
+		} else if ((n >= 30 && n <= 37) || (n >= 90 && n <= 97)) {
+			state.fg = "set";
+		} else if ((n >= 40 && n <= 47) || (n >= 100 && n <= 107)) {
+			state.bg = "set";
+		} else if (n === 38) {
+			state.fg = "set";
+			// Skip colour-model parameters: 38;5;N or 38;2;R;G;B
+			if (parts[k + 1] === "5") {
+				k += 2;
+			} else if (parts[k + 1] === "2") {
+				k += 4;
+			}
+		} else if (n === 48) {
+			state.bg = "set";
+			if (parts[k + 1] === "5") {
+				k += 2;
+			} else if (parts[k + 1] === "2") {
+				k += 4;
+			}
+		}
+		k++;
+	}
+}
+
+function stripAnsi(line: string): string {
+	// Remove CSI sequences. Good enough for these tests.
+	return line.replace(/\x1b\[[0-?]*[ -/]*[@-~]/g, "");
+}
+
 describe("compositeOverlays — backdrop", () => {
-	it("dims base lines when backdrop is true", () => {
+	it("dims base lines outside the overlay when backdrop is true", () => {
 		const base = ["hello world", "second line"];
 		const overlay = makeEntry(["OVERLAY"], {
 			width: 7,
@@ -27,14 +138,17 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 20, 20, 2);
 
-		// All base lines in viewport should contain dim escape (\x1b[2m)
-		// The overlay line itself is composited on top, but underlying lines get dimmed
-		const dimmedLine = result.find((l) => l.includes("second line"));
-		assert.ok(dimmedLine, "should have a line containing 'second line'");
-		assert.ok(dimmedLine.includes("\x1b[2m"), "base line should be dimmed");
+		// "second line" is below the overlay (which is anchored top-left with
+		// a single visible row), so every glyph of that text should be
+		// rendered with the dim attribute active.
+		const line = result.find((l) => stripAnsi(l).includes("second line"));
+		assert.ok(line, "should have a line containing 'second line'");
+
+		const state = sgrStateAtGlyph(line, "second line");
+		assert.equal(state.dim, true, "base line should be dimmed (SGR 2)");
 	});
 
-	it("backdrop uses gray foreground for dimming", () => {
+	it("backdrop applies a non-default foreground colour and leaves background untouched", () => {
 		const base = ["hello world", "second line"];
 		const overlay = makeEntry(["OV"], {
 			width: 2,
@@ -44,11 +158,16 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 20, 20, 2);
 
-		// Check a non-overlay line for backdrop codes (dim + gray fg, no bg)
-		const line = result.find((l) => l.includes("second line"));
+		const line = result.find((l) => stripAnsi(l).includes("second line"));
 		assert.ok(line, "should have a line containing 'second line'");
-		assert.ok(line.includes("\x1b[38;5;240m"), "backdrop should set gray foreground");
-		assert.ok(!line.includes("\x1b[48;"), "backdrop should not set background color");
+
+		const state = sgrStateAtGlyph(line, "second line");
+		assert.equal(state.fg, "set", "backdrop must set a foreground colour");
+		assert.equal(
+			state.bg,
+			"default",
+			"backdrop must not paint a background (preserves user's terminal theme)",
+		);
 	});
 
 	it("does not dim when backdrop is false/absent", () => {
@@ -60,10 +179,11 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 20, 20, 2);
 
-		// Lines not covered by overlay should remain undimmed
-		const secondLine = result.find((l) => l.includes("second line"));
-		assert.ok(secondLine, "should have a line containing 'second line'");
-		assert.ok(!secondLine.includes("\x1b[2m"), "base line should not be dimmed");
+		const line = result.find((l) => stripAnsi(l).includes("second line"));
+		assert.ok(line, "should have a line containing 'second line'");
+
+		const state = sgrStateAtGlyph(line, "second line");
+		assert.equal(state.dim, false, "base line should not be dimmed when no backdrop");
 	});
 
 	it("overlay content renders on top of dimmed background", () => {
@@ -76,7 +196,10 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 10, 10, 1);
 
-		// The first line should contain the overlay text
-		assert.ok(result[0].includes("XX"), "overlay text should be composited");
+		// Find the row that (after stripping styling) contains the overlay
+		// text. We don't use positional `result[0]` so the test survives if
+		// the row ordering changes.
+		const overlayRow = result.find((l) => stripAnsi(l).includes("XX"));
+		assert.ok(overlayRow, "overlay text should be composited into some rendered row");
 	});
 });

package/packages/pi-tui/src/__tests__/stdin-buffer.test.ts

@@ -1,29 +1,49 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
-import { setTimeout as delay } from "node:timers/promises";
 
 import { StdinBuffer } from "../stdin-buffer.js";
 
+// These tests use node:test's mock.timers to advance virtual time.
+// They previously relied on wall-clock delays (delay(20), delay(150))
+// racing the OS scheduler. On Windows the default setTimeout resolution is
+// ~15.6ms, so a real-time delay of 20ms sometimes fired only one of two
+// pending timers — hence the flake referenced in issue #4795.
+//
+// By mocking setTimeout/clearTimeout we control exactly when the buffer's
+// sequence timeout and stale timeout fire, eliminating scheduler-induced
+// flake and making the tests deterministic on every platform.
+
 describe("StdinBuffer", () => {
-	it("flushes a lone Escape keypress", async () => {
+	it("flushes a lone Escape keypress after the sequence timeout", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 5 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b");
-		await delay(20);
+
+		// Before the timeout fires the lone ESC is still buffered.
+		assert.deepEqual(received, []);
+		assert.equal(buffer.getBuffer(), "\x1b");
+
+		// Advance past the sequence timeout.
+		t.mock.timers.tick(5);
 
 		assert.deepEqual(received, ["\x1b"]);
 		assert.equal(buffer.getBuffer(), "");
 	});
 
-	it("keeps split CSI focus and mouse sequences buffered until completion", async () => {
+	it("keeps split CSI focus and mouse sequences buffered until completion", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 5 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b[");
-		await delay(20);
+		// Even after the normal timeout elapses, an incomplete CSI prefix must
+		// remain buffered (not emitted as literal text) so split escape
+		// sequences stay intact.
+		t.mock.timers.tick(5);
 		assert.deepEqual(received, []);
 		assert.equal(buffer.getBuffer(), "\x1b[");
 
@@ -32,7 +52,7 @@ describe("StdinBuffer", () => {
 		assert.equal(buffer.getBuffer(), "");
 
 		buffer.process("\x1b[<35;20;");
-		await delay(20);
+		t.mock.timers.tick(5);
 		assert.deepEqual(received, ["\x1b[I"]);
 		assert.equal(buffer.getBuffer(), "\x1b[<35;20;");
 
@@ -41,27 +61,36 @@ describe("StdinBuffer", () => {
 		assert.equal(buffer.getBuffer(), "");
 	});
 
-	it("flushes a stale incomplete escape prefix after the stale timeout", async () => {
-		// Timers must exceed Windows setTimeout resolution (~15.6ms) so the
-		// sequence timeout + stale timeout both fire within the delay window.
+	it("flushes a stale incomplete escape prefix after the stale timeout", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 20, staleTimeout: 40 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b[");
-		await delay(150);
+
+		// Sequence timeout: keeps the incomplete prefix buffered and starts
+		// the stale timer.
+		t.mock.timers.tick(20);
+		assert.deepEqual(received, []);
+		assert.equal(buffer.getBuffer(), "\x1b[");
+
+		// Stale timer fires — prefix is emitted as-is.
+		t.mock.timers.tick(40);
 
 		assert.deepEqual(received, ["\x1b["]);
 		assert.equal(buffer.getBuffer(), "");
 	});
 
-	it("still allows an incomplete escape prefix to complete before the stale timeout", async () => {
+	it("still allows an incomplete escape prefix to complete before the stale timeout", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 5, staleTimeout: 30 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b[");
-		await delay(10);
+		// Advance past the sequence timeout (but not the stale timeout).
+		t.mock.timers.tick(10);
 		buffer.process("I");
 
 		assert.deepEqual(received, ["\x1b[I"]);