gsd-pi 2.76.0 → 2.77.0-dev.2daa994b6

package/dist/resources/extensions/gsd/auto-prompts.js

@@ -19,9 +19,11 @@ import { getPendingGatesForTurn } from "./gsd-db.js";
 import { assertGateCoverage, getGatesForTurn, } from "./gate-registry.js";
 import { formatDecisionsCompact, formatRequirementsCompact } from "./structured-data-formatter.js";
 import { readPhaseAnchor, formatAnchorForPrompt } from "./phase-anchor.js";
+import { composeInlinedContext } from "./unit-context-composer.js";
 import { logWarning } from "./workflow-logger.js";
 import { inlineGraphSubgraph } from "./graph-context.js";
 import { buildExtractionStepsBlock } from "./commands-extract-learnings.js";
+import { warnIfManifestHasMissingSkills } from "./skill-manifest.js";
 // ─── Preamble Cap ─────────────────────────────────────────────────────────────
 /**
  * Historical static ceiling for the preamble cap. Kept as an upper bound even
@@ -201,6 +203,87 @@ export async function inlineFileSmart(absPath, relPath, label, query, threshold
     const truncated = truncateAtSectionBoundary(content, threshold).content;
     return `### ${label}\nSource: \`${relPath}\`\n\n${truncated}`;
 }
+/**
+ * Compact slice-summary excerpt for milestone-level closers (#4780).
+ *
+ * Emits the frontmatter fields + short body section heads rather than the
+ * full SUMMARY.md body, and keeps the source path in the header so the
+ * closer agent can Read the full file on demand when drafting LEARNINGS.
+ *
+ * Scope: designed for `buildCompleteMilestonePrompt`, which previously
+ * inlined the full SUMMARY per slice and routinely paid ~300–500K tokens
+ * per close when the narrative was never synthesized. Not used by
+ * `buildValidateMilestonePrompt` yet — validate needs fuller verification
+ * evidence; follow-up PR can extend or parameterize.
+ *
+ * If parsing fails (unrecognizable frontmatter, missing id, etc.) the
+ * function falls back to `inlineFile` so the closer loses no information.
+ */
+export async function buildSliceSummaryExcerpt(absPath, relPath, sid) {
+    const header = `### ${sid} Summary (excerpt)\nSource: \`${relPath}\``;
+    const content = absPath ? await loadFile(absPath) : null;
+    if (!content) {
+        return `${header}\n\n_(not found — file does not exist yet)_`;
+    }
+    try {
+        const s = parseSummary(content);
+        if (!s.frontmatter.id) {
+            // Unrecognizable — fall back to full file so no context is lost.
+            return `### ${sid} Summary\nSource: \`${relPath}\`\n\n${content.trim()}`;
+        }
+        const lines = [header, ""];
+        if (s.title)
+            lines.push(`**Title:** ${s.title}`);
+        if (s.oneLiner)
+            lines.push(`**One-liner:** ${s.oneLiner}`);
+        if (s.frontmatter.verification_result) {
+            lines.push(`**Verification:** \`${s.frontmatter.verification_result}\``);
+        }
+        lines.push(`**Blockers:** ${s.frontmatter.blocker_discovered ? "⚠️ blocker recorded — Read full summary" : "none"}`);
+        if (s.frontmatter.duration)
+            lines.push(`**Duration:** ${s.frontmatter.duration}`);
+        if (s.frontmatter.provides.length > 0)
+            lines.push(`**Provides:** ${s.frontmatter.provides.join("; ")}`);
+        if (s.frontmatter.affects.length > 0)
+            lines.push(`**Affects:** ${s.frontmatter.affects.join("; ")}`);
+        if (s.frontmatter.key_decisions.length > 0)
+            lines.push(`**Key decisions:** ${s.frontmatter.key_decisions.join("; ")}`);
+        if (s.frontmatter.patterns_established.length > 0)
+            lines.push(`**Patterns established:** ${s.frontmatter.patterns_established.join("; ")}`);
+        if (s.frontmatter.key_files.length > 0) {
+            const files = s.frontmatter.key_files.slice(0, 8);
+            const more = s.frontmatter.key_files.length > files.length ? ` (+${s.frontmatter.key_files.length - files.length} more)` : "";
+            lines.push(`**Key files:** ${files.join(", ")}${more}`);
+        }
+        // Cap section bodies (coderabbit review on #4908): if any of these
+        // narrative sections balloon, excerpt mode still inflates and
+        // undermines the token-reduction goal. 800 chars (~200 tokens) is
+        // enough to carry intent; the closer agent Reads the full file when
+        // it needs richer context for LEARNINGS synthesis.
+        const SECTION_CAP_CHARS = 800;
+        const capSection = (body) => {
+            const trimmed = body.trim();
+            if (trimmed.length <= SECTION_CAP_CHARS)
+                return trimmed;
+            return `${trimmed.slice(0, SECTION_CAP_CHARS)}\n… (truncated — see full \`${relPath}\`)`;
+        };
+        if (s.deviations && s.deviations.trim()) {
+            lines.push("", "#### Deviations", capSection(s.deviations));
+        }
+        if (s.knownLimitations && s.knownLimitations.trim()) {
+            lines.push("", "#### Known limitations", capSection(s.knownLimitations));
+        }
+        if (s.followUps && s.followUps.trim()) {
+            lines.push("", "#### Follow-ups", capSection(s.followUps));
+        }
+        lines.push("", `> **On-demand:** read \`${relPath}\` for the full "What Happened" narrative, integration notes, and detailed file-change list when drafting LEARNINGS, the Decision Re-evaluation table, or cross-slice synthesis.`);
+        return lines.join("\n");
+    }
+    catch {
+        // Defensive — any parse failure falls back to full inline.
+        return `### ${sid} Summary\nSource: \`${relPath}\`\n\n${content.trim()}`;
+    }
+}
 /**
  * Load and inline dependency slice summaries (full content, not just paths).
  */
@@ -446,6 +529,40 @@ export async function inlineKnowledgeScoped(base, keywords) {
         return null;
     return `### Project Knowledge (scoped)\nSource: \`${relGsdRootFile("KNOWLEDGE")}\`\n\n${scoped.trim()}`;
 }
+/**
+ * Budget-capped knowledge inline for milestone-level prompt assembly.
+ *
+ * Addresses issue #4719: the six milestone-phase prompts (research-milestone,
+ * plan-milestone, complete-slice, complete-milestone, validate-milestone,
+ * reassess-roadmap) previously injected the full KNOWLEDGE.md (~226KB for a
+ * real project) on every invocation. This helper scopes by caller-supplied
+ * keywords and caps the payload at `maxChars` (default 30,000 chars).
+ *
+ * Returns null when no KNOWLEDGE.md exists or no entries match any keyword.
+ */
+export async function inlineKnowledgeBudgeted(base, keywords, options) {
+    const DEFAULT_MAX_CHARS = 30_000;
+    const HARD_MAX_CHARS = 100_000;
+    const raw = Number(options?.maxChars ?? DEFAULT_MAX_CHARS);
+    const maxChars = Number.isFinite(raw)
+        ? Math.max(0, Math.min(Math.floor(raw), HARD_MAX_CHARS))
+        : DEFAULT_MAX_CHARS;
+    const knowledgePath = resolveGsdRootFile(base, "KNOWLEDGE");
+    if (!existsSync(knowledgePath))
+        return null;
+    const content = await loadFile(knowledgePath);
+    if (!content)
+        return null;
+    const { queryKnowledge } = await import("./context-store.js");
+    const scoped = await queryKnowledge(content, keywords);
+    if (!scoped)
+        return null;
+    const trimmed = scoped.trim();
+    const truncated = trimmed.length > maxChars
+        ? `${trimmed.slice(0, maxChars)}\n\n[...truncated ${trimmed.length - maxChars} chars; rerun with narrower scope if needed]`
+        : trimmed;
+    return `### Project Knowledge (scoped)\nSource: \`${relGsdRootFile("KNOWLEDGE")}\`\n\n${truncated}`;
+}
 /**
  * Inline a roadmap excerpt for a specific slice.
  * Reads full roadmap, extracts minimal excerpt with header + predecessor + target row.
@@ -559,10 +676,23 @@ function formatSkillActivationBlock(skillNames) {
     return `<skill_activation>${calls}.</skill_activation>`;
 }
 export function buildSkillActivationBlock(params) {
-    const prefs = params.preferences ?? loadEffectiveGSDPreferences()?.preferences;
+    const prefs = params.preferences ?? loadEffectiveGSDPreferences(params.base)?.preferences;
     const contextTokens = tokenizeSkillContext(params.milestoneId, params.milestoneTitle, params.sliceId, params.sliceTitle, params.taskId, params.taskTitle);
-    const visibleSkills = (typeof getLoadedSkills === 'function' ? getLoadedSkills() : []).filter(skill => !skill.disableModelInvocation);
+    const loaded = (typeof getLoadedSkills === 'function' ? getLoadedSkills() : []).filter(skill => !skill.disableModelInvocation);
+    // Skill activation here is driven entirely by explicit sources
+    // (always_use_skills, prefer_skills, skill_rules, task-plan skills_used).
+    // Every match is an explicit user/project intent and must not be dropped
+    // by the unit-type manifest — user intent is stronger signal than
+    // defaults. The manifest's real home is the skill catalog rendering
+    // layer (pi-coding-agent `formatSkillsForPrompt`); that wiring is tracked
+    // as the "load-time short-circuit" follow-up to RFC #4779.
+    //
+    // `unitType` stays plumbed so the strict-mode warning can surface
+    // manifest entries that reference uninstalled skills, and so the
+    // activation-block site is ready to opt in once PR B lands.
+    const visibleSkills = loaded;
     const installedNames = new Set(visibleSkills.map(skill => normalizeSkillReference(skill.name)));
+    warnIfManifestHasMissingSkills(params.unitType, installedNames);
     const avoided = new Set(resolvePreferenceSkillNames(prefs?.avoid_skills ?? [], params.base));
     const matched = new Set();
     for (const name of resolvePreferenceSkillNames(prefs?.always_use_skills ?? [], params.base)) {
@@ -945,30 +1075,63 @@ export async function buildDiscussMilestonePrompt(mid, midTitle, base, structure
     return basePrompt;
 }
 export async function buildResearchMilestonePrompt(mid, midTitle, base) {
-    const contextPath = resolveMilestoneFile(base, mid, "CONTEXT");
-    const contextRel = relMilestoneFile(base, mid, "CONTEXT");
-    const inlined = [];
-    inlined.push(await inlineFile(contextPath, contextRel, "Milestone Context"));
-    const projectInline = await inlineProjectFromDb(base);
-    if (projectInline)
-        inlined.push(projectInline);
-    const requirementsInline = await inlineRequirementsFromDb(base, mid);
-    if (requirementsInline)
-        inlined.push(requirementsInline);
-    const decisionsInline = await inlineDecisionsFromDb(base, mid);
-    if (decisionsInline)
-        inlined.push(decisionsInline);
-    const knowledgeInlineRM = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
-    if (knowledgeInlineRM)
-        inlined.push(knowledgeInlineRM);
-    inlined.push(inlineTemplate("research", "Research"));
-    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`);
+    // #4782 phase 3: research-milestone migrated through the composer.
+    // Declared inline order: milestone-context, project, requirements,
+    // decisions, templates. Knowledge stays outside the composer
+    // (budget-driven, scoped by keyword extraction — future phase folds
+    // policy-driven blocks in).
+    const resolveArtifact = async (key) => {
+        switch (key) {
+            case "milestone-context": {
+                const p = resolveMilestoneFile(base, mid, "CONTEXT");
+                const r = relMilestoneFile(base, mid, "CONTEXT");
+                return await inlineFile(p, r, "Milestone Context");
+            }
+            case "project":
+                return await inlineProjectFromDb(base);
+            case "requirements":
+                return await inlineRequirementsFromDb(base, mid);
+            case "decisions":
+                return await inlineDecisionsFromDb(base, mid);
+            case "templates":
+                return inlineTemplate("research", "Research");
+            default:
+                return null;
+        }
+    };
+    const composed = await composeInlinedContext("research-milestone", resolveArtifact);
+    // Knowledge block stays outside the composer — budgeted, scoped via
+    // keyword extraction (#4719). Inserted between decisions and the
+    // templates block to match the pre-migration output order. We split
+    // the composer output around the templates section to preserve that
+    // ordering.
+    const knowledgeInlineRM = await inlineKnowledgeBudgeted(base, extractKeywords(midTitle));
+    const parts = [];
+    if (knowledgeInlineRM && composed) {
+        // Insert knowledge before the template block so the overall order is:
+        //   milestone-context → project → requirements → decisions → KNOWLEDGE → research template
+        const idx = composed.lastIndexOf("### Output Template:");
+        if (idx > 0) {
+            const before = composed.slice(0, idx).replace(/\n\n---\n\n$/, "");
+            const after = composed.slice(idx);
+            parts.push(before, knowledgeInlineRM, after);
+        }
+        else {
+            parts.push(composed, knowledgeInlineRM);
+        }
+    }
+    else if (composed) {
+        parts.push(composed);
+        if (knowledgeInlineRM)
+            parts.push(knowledgeInlineRM);
+    }
+    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${parts.join("\n\n---\n\n")}`);
     const outputRelPath = relMilestoneFile(base, mid, "RESEARCH");
     return loadPrompt("research-milestone", {
         workingDirectory: base,
         milestoneId: mid, milestoneTitle: midTitle,
         milestonePath: relMilestonePath(base, mid),
-        contextPath: contextRel,
+        contextPath: relMilestoneFile(base, mid, "CONTEXT"),
         outputPath: join(base, outputRelPath),
         inlinedContext,
         skillActivation: buildSkillActivationBlock({
@@ -976,6 +1139,7 @@ export async function buildResearchMilestonePrompt(mid, midTitle, base) {
             milestoneId: mid,
             milestoneTitle: midTitle,
             extraContext: [inlinedContext],
+            unitType: "research-milestone",
         }),
         ...buildSkillDiscoveryVars(),
     });
@@ -1015,7 +1179,8 @@ export async function buildPlanMilestonePrompt(mid, midTitle, base, level) {
         const queueInline = await inlineFileSmart(queuePath, relGsdRootFile("QUEUE"), "Project Queue", `${mid} ${midTitle}`);
         inlined.push(queueInline);
     }
-    const knowledgeInlinePM = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
+    // Scoped + budgeted — see issue #4719
+    const knowledgeInlinePM = await inlineKnowledgeBudgeted(base, extractKeywords(midTitle));
     if (knowledgeInlinePM)
         inlined.push(knowledgeInlinePM);
     inlined.push(inlineTemplate("roadmap", "Roadmap"));
@@ -1050,6 +1215,7 @@ export async function buildPlanMilestonePrompt(mid, midTitle, base, level) {
             milestoneId: mid,
             milestoneTitle: midTitle,
             extraContext: [inlinedContext],
+            unitType: "plan-milestone",
         }),
         ...buildSkillDiscoveryVars(),
     });
@@ -1123,6 +1289,7 @@ export async function buildResearchSlicePrompt(mid, _midTitle, sid, sTitle, base
             sliceId: sid,
             sliceTitle: sTitle,
             extraContext: [inlinedContext, depContent],
+            unitType: "research-slice",
         }),
         ...buildSkillDiscoveryVars(),
     });
@@ -1209,6 +1376,7 @@ async function renderSlicePrompt(options) {
             sliceId: sid,
             sliceTitle: sTitle,
             extraContext: [inlinedContext, depContent],
+            unitType: promptTemplate,
         }),
         ...extraVars,
     });
@@ -1223,6 +1391,20 @@ export async function buildPlanSlicePrompt(mid, _midTitle, sid, sTitle, base, le
         prependBlocks.push(`## Prior Sketch Scope (soft hint — non-binding)\n\n${options.softScopeHint.trim()}\n\n` +
             `This scope was captured during an earlier progressive-planning pass that was later disabled. Treat it as context only — you may plan beyond it if the work genuinely requires more scope. Do NOT treat this as a hard boundary.`);
     }
+    // #4551: inject pre-exec failure context so the re-dispatched plan-slice
+    // addresses the exact blocked references rather than reproducing the same plan.
+    if (options?.priorPreExecFailure) {
+        const { blockingFindings, verdictExcerpt } = options.priorPreExecFailure;
+        const findingsList = blockingFindings.length > 0
+            ? blockingFindings.map(f => `- ${f}`).join("\n")
+            : "- (no specific findings recorded)";
+        prependBlocks.push(`## Fix these specific issues from the prior pre-exec check\n\n` +
+            `The previous plan-slice attempt was blocked by pre-execution validation.\n` +
+            `Gate verdict: ${verdictExcerpt}\n\n` +
+            `Blocked references that must be resolved in this plan:\n${findingsList}\n\n` +
+            `Revise the plan so that every reference listed above is satisfied before execution begins. ` +
+            `Do not reproduce the same file paths, package names, or task ordering that caused these failures.`);
+    }
     return renderSlicePrompt({
         mid, sid, sTitle, base,
         level: level ?? resolveInlineLevel(),
@@ -1403,51 +1585,95 @@ export async function buildExecuteTaskPrompt(mid, sid, sTitle, tid, tTitle, base
         }),
     });
 }
-export async function buildCompleteSlicePrompt(mid, _midTitle, sid, sTitle, base, level) {
+export async function buildCompleteSlicePrompt(mid, midTitle, sid, sTitle, base, level) {
     const inlineLevel = level ?? resolveInlineLevel();
-    const roadmapPath = resolveMilestoneFile(base, mid, "ROADMAP");
-    const roadmapRel = relMilestoneFile(base, mid, "ROADMAP");
-    const slicePlanPath = resolveSliceFile(base, mid, sid, "PLAN");
-    const slicePlanRel = relSliceFile(base, mid, sid, "PLAN");
-    const sliceContextPath = resolveSliceFile(base, mid, sid, "CONTEXT");
-    const sliceContextRel = relSliceFile(base, mid, sid, "CONTEXT");
-    const inlined = [];
-    inlined.push(await inlineFile(roadmapPath, roadmapRel, "Milestone Roadmap"));
-    const sliceCtxInline = await inlineFileOptional(sliceContextPath, sliceContextRel, "Slice Context (from discussion)");
-    if (sliceCtxInline)
-        inlined.push(sliceCtxInline);
-    inlined.push(await inlineFile(slicePlanPath, slicePlanRel, "Slice Plan"));
-    if (inlineLevel !== "minimal") {
-        const requirementsInline = await inlineRequirementsFromDb(base, mid, sid, inlineLevel);
-        if (requirementsInline)
-            inlined.push(requirementsInline);
-    }
-    const knowledgeInlineCS = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
-    if (knowledgeInlineCS)
-        inlined.push(knowledgeInlineCS);
-    // Inline all task summaries for this slice
-    const tDir = resolveTasksDir(base, mid, sid);
-    if (tDir) {
-        const summaryFiles = resolveTaskFiles(tDir, "SUMMARY").sort();
-        for (const file of summaryFiles) {
-            const absPath = join(tDir, file);
-            const content = await loadFile(absPath);
-            const sRel = relSlicePath(base, mid, sid);
-            const relPath = `${sRel}/tasks/${file}`;
-            if (content) {
-                inlined.push(`### Task Summary: ${file.replace(/-SUMMARY\.md$/i, "")}\nSource: \`${relPath}\`\n\n${content.trim()}`);
+    // #4782 phase 3: complete-slice migrated through composer. Manifest
+    // declares [roadmap, slice-context, slice-plan, requirements,
+    // prior-task-summaries, templates]. Overrides prepend and knowledge
+    // splice stay imperative — they need the composer v2 contract
+    // (computed + prepend blocks; see RFC #4924).
+    const resolveArtifact = async (key) => {
+        switch (key) {
+            case "roadmap": {
+                const p = resolveMilestoneFile(base, mid, "ROADMAP");
+                const r = relMilestoneFile(base, mid, "ROADMAP");
+                return await inlineFile(p, r, "Milestone Roadmap");
             }
+            case "slice-context": {
+                const p = resolveSliceFile(base, mid, sid, "CONTEXT");
+                const r = relSliceFile(base, mid, sid, "CONTEXT");
+                return await inlineFileOptional(p, r, "Slice Context (from discussion)");
+            }
+            case "slice-plan": {
+                const p = resolveSliceFile(base, mid, sid, "PLAN");
+                const r = relSliceFile(base, mid, sid, "PLAN");
+                return await inlineFile(p, r, "Slice Plan");
+            }
+            case "requirements":
+                if (inlineLevel === "minimal")
+                    return null;
+                return await inlineRequirementsFromDb(base, mid, sid, inlineLevel);
+            case "prior-task-summaries": {
+                const tDir = resolveTasksDir(base, mid, sid);
+                if (!tDir)
+                    return null;
+                const summaryFiles = resolveTaskFiles(tDir, "SUMMARY").sort();
+                const sRel = relSlicePath(base, mid, sid);
+                const blocks = [];
+                for (const file of summaryFiles) {
+                    const absPath = join(tDir, file);
+                    const content = await loadFile(absPath);
+                    if (!content)
+                        continue;
+                    const relPath = `${sRel}/tasks/${file}`;
+                    blocks.push(`### Task Summary: ${file.replace(/-SUMMARY\.md$/i, "")}\nSource: \`${relPath}\`\n\n${content.trim()}`);
+                }
+                return blocks.length > 0 ? blocks.join("\n\n---\n\n") : null;
+            }
+            case "templates": {
+                const parts = [inlineTemplate("slice-summary", "Slice Summary")];
+                if (inlineLevel !== "minimal") {
+                    parts.push(inlineTemplate("uat", "UAT"));
+                }
+                return parts.join("\n\n---\n\n");
+            }
+            default:
+                return null;
+        }
+    };
+    const composed = await composeInlinedContext("complete-slice", resolveArtifact);
+    // Knowledge splices in between requirements and prior-task-summaries
+    // so overall order matches pre-migration: roadmap → slice-context →
+    // slice-plan → requirements → KNOWLEDGE → task summaries → templates.
+    const knowledgeInlineCS = await inlineKnowledgeBudgeted(base, [...extractKeywords(midTitle), ...extractKeywords(sTitle)]);
+    let body = composed;
+    if (knowledgeInlineCS && body) {
+        // Splice knowledge right before the first "### Task Summary:" block
+        // to preserve pre-migration ordering. If no task summaries exist,
+        // splice before the templates block (which inlineTemplate emits as
+        // "### Output Template: Slice Summary").
+        const taskIdx = body.indexOf("### Task Summary:");
+        const templatesIdx = body.lastIndexOf("### Output Template: Slice Summary");
+        const spliceIdx = taskIdx > -1 ? taskIdx : templatesIdx;
+        if (spliceIdx > 0) {
+            const before = body.slice(0, spliceIdx).replace(/\n\n---\n\n$/, "");
+            const after = body.slice(spliceIdx);
+            body = [before, knowledgeInlineCS, after].join("\n\n---\n\n");
+        }
+        else {
+            body = `${body}\n\n---\n\n${knowledgeInlineCS}`;
         }
     }
-    inlined.push(inlineTemplate("slice-summary", "Slice Summary"));
-    if (inlineLevel !== "minimal") {
-        inlined.push(inlineTemplate("uat", "UAT"));
-    }
+    // Overrides section prepends to the top of the inlined context —
+    // standard pattern for slice-level builders (until composer v2 lands
+    // the prepend contract).
     const completeActiveOverrides = await loadActiveOverrides(base);
     const completeOverridesInline = formatOverridesSection(completeActiveOverrides);
-    if (completeOverridesInline)
-        inlined.unshift(completeOverridesInline);
-    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`);
+    const finalBody = completeOverridesInline
+        ? `${completeOverridesInline}\n\n---\n\n${body}`
+        : body;
+    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${finalBody}`);
+    const roadmapRel = relMilestoneFile(base, mid, "ROADMAP");
     const sliceRel = relSlicePath(base, mid, sid);
     const sliceSummaryPath = join(base, `${sliceRel}/${sid}-SUMMARY.md`);
     const sliceUatPath = join(base, `${sliceRel}/${sid}-UAT.md`);
@@ -1498,13 +1724,21 @@ export async function buildCompleteMilestonePrompt(mid, midTitle, base, level) {
         }
     }
     const seenSlices = new Set();
+    const summaryRelPaths = [];
     for (const sid of sliceIds) {
         if (seenSlices.has(sid))
             continue;
         seenSlices.add(sid);
         const summaryPath = resolveSliceFile(base, mid, sid, "SUMMARY");
         const summaryRel = relSliceFile(base, mid, sid, "SUMMARY");
-        inlined.push(await inlineFile(summaryPath, summaryRel, `${sid} Summary`));
+        summaryRelPaths.push(summaryRel);
+        // Compact excerpt instead of full inline (#4780). Closer Reads the
+        // full file on-demand when synthesizing LEARNINGS narrative.
+        inlined.push(await buildSliceSummaryExcerpt(summaryPath, summaryRel, sid));
+    }
+    if (summaryRelPaths.length > 0) {
+        const pathList = summaryRelPaths.map(p => `- \`${p}\``).join("\n");
+        inlined.push(`### On-demand Slice Summaries\n\nExcerpted above. Read the full file for any slice when the excerpt's section heads don't carry enough narrative for the milestone summary you're drafting:\n\n${pathList}`);
     }
     // Inline root GSD files (skip for minimal — completion can read these if needed)
     if (inlineLevel !== "minimal") {
@@ -1518,7 +1752,8 @@ export async function buildCompleteMilestonePrompt(mid, midTitle, base, level) {
         if (projectInline)
             inlined.push(projectInline);
     }
-    const knowledgeInlineCM = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
+    // Scoped + budgeted — see issue #4719
+    const knowledgeInlineCM = await inlineKnowledgeBudgeted(base, extractKeywords(midTitle));
     if (knowledgeInlineCM)
         inlined.push(knowledgeInlineCM);
     // Inline milestone context file (milestone-level, not GSD root)
@@ -1550,6 +1785,7 @@ export async function buildCompleteMilestonePrompt(mid, midTitle, base, level) {
             milestoneId: mid,
             milestoneTitle: midTitle,
             extraContext: [inlinedContext],
+            unitType: "complete-milestone",
         }),
     });
 }
@@ -1657,7 +1893,8 @@ export async function buildValidateMilestonePrompt(mid, midTitle, base, level) {
         if (projectInline)
             inlined.push(projectInline);
     }
-    const knowledgeInline = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
+    // Scoped + budgeted — see issue #4719
+    const knowledgeInline = await inlineKnowledgeBudgeted(base, extractKeywords(midTitle));
     if (knowledgeInline)
         inlined.push(knowledgeInline);
     // Inline milestone context file
@@ -1692,6 +1929,7 @@ export async function buildValidateMilestonePrompt(mid, midTitle, base, level) {
             milestoneId: mid,
             milestoneTitle: midTitle,
             extraContext: [inlinedContext],
+            unitType: "validate-milestone",
         }),
     });
 }
@@ -1767,23 +2005,42 @@ export async function buildReplanSlicePrompt(mid, midTitle, sid, sTitle, base) {
             sliceId: sid,
             sliceTitle: sTitle,
             extraContext: [inlinedContext, captureContext],
+            unitType: "replan-slice",
         }),
     });
 }
 export async function buildRunUatPrompt(mid, sliceId, uatPath, uatContent, base) {
-    const inlined = [];
-    inlined.push(await inlineFile(resolveSliceFile(base, mid, sliceId, "UAT"), uatPath, `${sliceId} UAT`));
-    const summaryPath = resolveSliceFile(base, mid, sliceId, "SUMMARY");
-    const summaryRel = relSliceFile(base, mid, sliceId, "SUMMARY");
-    if (summaryPath) {
-        const summaryInline = await inlineFileOptional(summaryPath, summaryRel, `${sliceId} Summary`);
-        if (summaryInline)
-            inlined.push(summaryInline);
-    }
-    const projectInline = await inlineProjectFromDb(base);
-    if (projectInline)
-        inlined.push(projectInline);
-    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`);
+    // #4782 phase 3: run-uat migrated to compose its inlined context via
+    // the manifest. Behavior-equivalent — resolver dispatches to the same
+    // inline* helpers as the pre-migration builder.
+    const resolveArtifact = async (key) => {
+        switch (key) {
+            case "slice-uat": {
+                // Use the in-memory snapshot the caller already loaded (#4925 review).
+                // Re-reading from disk via inlineFile(p, uatPath, ...) would risk
+                // drift between the inlined body and uatType (computed from
+                // uatContent below) if the file changes mid-dispatch.
+                const trimmed = uatContent.trim();
+                if (!trimmed) {
+                    return `### ${sliceId} UAT\nSource: \`${uatPath}\`\n\n_(not found — file does not exist yet)_`;
+                }
+                return `### ${sliceId} UAT\nSource: \`${uatPath}\`\n\n${trimmed}`;
+            }
+            case "slice-summary": {
+                const p = resolveSliceFile(base, mid, sliceId, "SUMMARY");
+                if (!p)
+                    return null;
+                const r = relSliceFile(base, mid, sliceId, "SUMMARY");
+                return await inlineFileOptional(p, r, `${sliceId} Summary`);
+            }
+            case "project":
+                return await inlineProjectFromDb(base);
+            default:
+                return null;
+        }
+    };
+    const composed = await composeInlinedContext("run-uat", resolveArtifact);
+    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${composed}`);
     const uatResultPath = join(base, relSliceFile(base, mid, sliceId, "ASSESSMENT"));
     const uatType = getUatType(uatContent);
     return loadPrompt("run-uat", {
@@ -1799,38 +2056,62 @@ export async function buildRunUatPrompt(mid, sliceId, uatPath, uatContent, base)
             milestoneId: mid,
             sliceId,
             extraContext: [inlinedContext],
+            unitType: "run-uat",
         }),
     });
 }
 export async function buildReassessRoadmapPrompt(mid, midTitle, completedSliceId, base, level) {
     const inlineLevel = level ?? resolveInlineLevel();
-    const roadmapPath = resolveMilestoneFile(base, mid, "ROADMAP");
-    const roadmapRel = relMilestoneFile(base, mid, "ROADMAP");
-    const summaryPath = resolveSliceFile(base, mid, completedSliceId, "SUMMARY");
-    const summaryRel = relSliceFile(base, mid, completedSliceId, "SUMMARY");
-    const sliceContextPath = resolveSliceFile(base, mid, completedSliceId, "CONTEXT");
-    const sliceContextRel = relSliceFile(base, mid, completedSliceId, "CONTEXT");
-    const inlined = [];
-    inlined.push(await inlineFile(roadmapPath, roadmapRel, "Current Roadmap"));
-    const sliceCtxInline = await inlineFileOptional(sliceContextPath, sliceContextRel, "Slice Context (from discussion)");
-    if (sliceCtxInline)
-        inlined.push(sliceCtxInline);
-    inlined.push(await inlineFile(summaryPath, summaryRel, `${completedSliceId} Summary`));
-    if (inlineLevel !== "minimal") {
-        const projectInline = await inlineProjectFromDb(base);
-        if (projectInline)
-            inlined.push(projectInline);
-        const requirementsInline = await inlineRequirementsFromDb(base, mid, undefined, inlineLevel);
-        if (requirementsInline)
-            inlined.push(requirementsInline);
-        const decisionsInline = await inlineDecisionsFromDb(base, mid, undefined, inlineLevel);
-        if (decisionsInline)
-            inlined.push(decisionsInline);
-    }
-    const knowledgeInlineRA = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
+    // #4782 phase 2 pilot: reassess-roadmap is the first unit type to
+    // compose its inlined context through the manifest-driven composer.
+    // The resolver below dispatches artifact keys to the existing inline*
+    // helpers, preserving identical output so the migration is
+    // observable-equivalent. Knowledge stays outside the composer (it's
+    // budget-driven, not manifest-driven) until a later phase formalizes
+    // knowledge/memory policies as composer inputs.
+    const resolveArtifact = async (key) => {
+        switch (key) {
+            case "roadmap": {
+                const p = resolveMilestoneFile(base, mid, "ROADMAP");
+                const r = relMilestoneFile(base, mid, "ROADMAP");
+                return await inlineFile(p, r, "Current Roadmap");
+            }
+            case "slice-context": {
+                const p = resolveSliceFile(base, mid, completedSliceId, "CONTEXT");
+                const r = relSliceFile(base, mid, completedSliceId, "CONTEXT");
+                return await inlineFileOptional(p, r, "Slice Context (from discussion)");
+            }
+            case "slice-summary": {
+                const p = resolveSliceFile(base, mid, completedSliceId, "SUMMARY");
+                const r = relSliceFile(base, mid, completedSliceId, "SUMMARY");
+                return await inlineFile(p, r, `${completedSliceId} Summary`);
+            }
+            case "project":
+                if (inlineLevel === "minimal")
+                    return null;
+                return await inlineProjectFromDb(base);
+            case "requirements":
+                if (inlineLevel === "minimal")
+                    return null;
+                return await inlineRequirementsFromDb(base, mid, undefined, inlineLevel);
+            case "decisions":
+                if (inlineLevel === "minimal")
+                    return null;
+                return await inlineDecisionsFromDb(base, mid, undefined, inlineLevel);
+            default:
+                return null;
+        }
+    };
+    const composed = await composeInlinedContext("reassess-roadmap", resolveArtifact);
+    const parts = [];
+    if (composed)
+        parts.push(composed);
+    // Knowledge block stays outside the composer — budgeted, scoped via
+    // keyword extraction (#4719). Future phase folds it in.
+    const knowledgeInlineRA = await inlineKnowledgeBudgeted(base, extractKeywords(midTitle));
     if (knowledgeInlineRA)
-        inlined.push(knowledgeInlineRA);
-    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`);
+        parts.push(knowledgeInlineRA);
+    const inlinedContext = capPreamble(`## Inlined Context (preloaded — do not re-read these files)\n\n${parts.join("\n\n---\n\n")}`);
     const assessmentPath = join(base, relSliceFile(base, mid, completedSliceId, "ASSESSMENT"));
     // Build deferred captures context for reassess prompt
     let deferredCaptures = "(none)";
@@ -1850,7 +2131,7 @@ export async function buildReassessRoadmapPrompt(mid, midTitle, completedSliceId
         milestoneId: mid,
         milestoneTitle: midTitle,
         completedSliceId,
-        roadmapPath: roadmapRel,
+        roadmapPath: relMilestoneFile(base, mid, "ROADMAP"),
         assessmentPath,
         inlinedContext,
         deferredCaptures,
@@ -1860,6 +2141,7 @@ export async function buildReassessRoadmapPrompt(mid, midTitle, completedSliceId
             milestoneId: mid,
             milestoneTitle: midTitle,
             extraContext: [inlinedContext, deferredCaptures],
+            unitType: "reassess-roadmap",
         }),
     });
 }