gsd-pi 2.75.0 → 2.76.0-dev.b072ebb73

package/src/resources/extensions/gsd/tests/finalize-timeout-guard.test.ts

@@ -213,25 +213,42 @@ function getRunFinalizeBody(phasesSource: string): string {
 
   const fnBody = getRunFinalizeBody(phasesSource);
 
-  // Both timeout handlers should increment consecutiveFinalizeTimeouts
-  const incrementCount = (fnBody.match(/consecutiveFinalizeTimeouts\+\+/g) || []).length;
+  const helperCallCount = (fnBody.match(/failClosedOnFinalizeTimeout\(/g) || []).length;
   assertTrue(
-    incrementCount >= 2,
-    `should increment consecutiveFinalizeTimeouts in both pre and post handlers (found ${incrementCount})`,
+    helperCallCount >= 2,
+    `runFinalize should route both timeout branches through failClosedOnFinalizeTimeout (found ${helperCallCount})`,
   );
 
-  // Both timeout handlers should check MAX_FINALIZE_TIMEOUTS for escalation
-  const escalationCount = (fnBody.match(/MAX_FINALIZE_TIMEOUTS/g) || []).length;
+  const helperStart = phasesSource.indexOf("async function failClosedOnFinalizeTimeout");
+  assertTrue(helperStart > 0, "failClosedOnFinalizeTimeout helper should exist");
+  const helperEnd = phasesSource.indexOf("// ─── runPreDispatch", helperStart);
+  const helperBody = phasesSource.slice(helperStart, helperEnd > helperStart ? helperEnd : undefined);
+
+  const incrementCount = (helperBody.match(/consecutiveFinalizeTimeouts\+\+/g) || []).length;
   assertTrue(
-    escalationCount >= 2,
-    `should check MAX_FINALIZE_TIMEOUTS in both handlers (found ${escalationCount})`,
+    incrementCount >= 1,
+    `timeout helper should increment consecutiveFinalizeTimeouts (found ${incrementCount})`,
   );
 
-  // Both timeout handlers should null out s.currentUnit to prevent late mutations
-  const detachCount = (fnBody.match(/s\.currentUnit\s*=\s*null/g) || []).length;
+  const detachCount = (helperBody.match(/s\.currentUnit\s*=\s*null/g) || []).length;
+  assertTrue(
+    detachCount >= 1,
+    `timeout helper should detach s.currentUnit (found ${detachCount})`,
+  );
+
+  const pauseCount = (helperBody.match(/pauseAuto\(/g) || []).length;
+  assertTrue(
+    pauseCount >= 1,
+    `timeout helper should pause auto-mode (found ${pauseCount})`,
+  );
+
+  assertTrue(
+    helperBody.includes('eventType: "unit-end"'),
+    "timeout helper should emit a terminal unit-end event",
+  );
   assertTrue(
-    detachCount >= 2,
-    `should detach s.currentUnit in both timeout handlers (found ${detachCount})`,
+    helperBody.includes('phase: "finalize-timeout"'),
+    "timeout helper should persist finalize-timeout runtime state",
   );
 
   // Successful finalize should reset the counter

package/src/resources/extensions/gsd/tests/flat-rate-routing-guard.test.ts

@@ -6,8 +6,14 @@
 
 import { describe, test } from "node:test";
 import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
 import { buildFlatRateContext, isFlatRateProvider, resolvePreferredModelConfig } from "../auto-model-selection.ts";
 
+const __dirname_4386 = dirname(fileURLToPath(import.meta.url));
+
 describe("flat-rate provider routing guard (#3453)", () => {
 
   test("isFlatRateProvider returns true for github-copilot", () => {
@@ -33,19 +39,50 @@ describe("flat-rate provider routing guard (#3453)", () => {
   });
 
   test("resolvePreferredModelConfig returns undefined for copilot start model", () => {
+    const originalCwd = process.cwd();
+    const originalGsdHome = process.env.GSD_HOME;
+    const tempProject = mkdtempSync(join(tmpdir(), "gsd-flat-rate-project-"));
+    const tempGsdHome = mkdtempSync(join(tmpdir(), "gsd-flat-rate-home-"));
+
     // When the user's start model is on a flat-rate provider,
     // resolvePreferredModelConfig should not synthesize a routing
     // config from tier_models — it should return undefined so the
     // user's selected model is preserved.
-    const result = resolvePreferredModelConfig("execute-task", {
-      provider: "github-copilot",
-      id: "claude-sonnet-4",
-    });
+    try {
+      mkdirSync(join(tempProject, ".gsd"), { recursive: true });
+      writeFileSync(
+        join(tempProject, ".gsd", "PREFERENCES.md"),
+        [
+          "---",
+          "dynamic_routing:",
+          "  enabled: true",
+          "  tier_models:",
+          "    light: gpt-4o-mini",
+          "    standard: claude-sonnet-4-6",
+          "    heavy: claude-opus-4-6",
+          "---",
+        ].join("\n"),
+        "utf-8",
+      );
+      process.env.GSD_HOME = tempGsdHome;
+      process.chdir(tempProject);
+
+      const result = resolvePreferredModelConfig("execute-task", {
+        provider: "github-copilot",
+        id: "claude-sonnet-4",
+      });
 
-    // Should be undefined (no routing config created for flat-rate)
-    // Note: this only tests the guard — if explicit per-unit config exists
-    // in preferences, that takes precedence regardless.
-    assert.equal(result, undefined, "Should not create routing config for copilot");
+      // Should be undefined (no routing config created for flat-rate)
+      // Note: this only tests the synthesis guard — explicit per-unit config
+      // still takes precedence when the user configured one.
+      assert.equal(result, undefined, "Should not create routing config for copilot");
+    } finally {
+      process.chdir(originalCwd);
+      if (originalGsdHome === undefined) delete process.env.GSD_HOME;
+      else process.env.GSD_HOME = originalGsdHome;
+      rmSync(tempProject, { recursive: true, force: true });
+      rmSync(tempGsdHome, { recursive: true, force: true });
+    }
   });
 });
 
@@ -184,3 +221,103 @@ describe("buildFlatRateContext()", () => {
     assert.equal(result.authMode, undefined);
   });
 });
+
+// ─── #4386: allow_flat_rate_providers opt-in ────────────────────────────────
+
+describe("flat-rate routing opt-in (#4386)", () => {
+  function withPrefs(prefsYaml: string, fn: () => void): void {
+    const originalCwd = process.cwd();
+    const originalGsdHome = process.env.GSD_HOME;
+    const tempProject = mkdtempSync(join(tmpdir(), "gsd-4386-project-"));
+    const tempGsdHome = mkdtempSync(join(tmpdir(), "gsd-4386-home-"));
+    try {
+      mkdirSync(join(tempProject, ".gsd"), { recursive: true });
+      writeFileSync(
+        join(tempProject, ".gsd", "PREFERENCES.md"),
+        ["---", "version: 1", prefsYaml, "---"].join("\n"),
+        "utf-8",
+      );
+      process.env.GSD_HOME = tempGsdHome;
+      process.chdir(tempProject);
+      fn();
+    } finally {
+      process.chdir(originalCwd);
+      if (originalGsdHome === undefined) delete process.env.GSD_HOME;
+      else process.env.GSD_HOME = originalGsdHome;
+      rmSync(tempProject, { recursive: true, force: true });
+      rmSync(tempGsdHome, { recursive: true, force: true });
+    }
+  }
+
+  test("default (opt-in absent): flat-rate start model still returns undefined", () => {
+    withPrefs(
+      [
+        "dynamic_routing:",
+        "  enabled: true",
+        "  tier_models:",
+        "    heavy: claude-opus-4-6",
+      ].join("\n"),
+      () => {
+        const result = resolvePreferredModelConfig("execute-task", {
+          provider: "claude-code",
+          id: "claude-opus-4-6",
+        });
+        assert.equal(result, undefined, "default must preserve #3453 bypass");
+      },
+    );
+  });
+
+  test("opt-in: synthesizes a routing config for flat-rate start model", () => {
+    withPrefs(
+      [
+        "dynamic_routing:",
+        "  enabled: true",
+        "  allow_flat_rate_providers: true",
+        "  tier_models:",
+        "    heavy: claude-opus-4-6",
+      ].join("\n"),
+      () => {
+        const result = resolvePreferredModelConfig("execute-task", {
+          provider: "claude-code",
+          id: "claude-opus-4-6",
+        });
+        assert.ok(result, "routing config should be synthesized");
+        assert.equal(result!.primary, "claude-opus-4-6");
+      },
+    );
+  });
+
+  test("explicit opt-out: flat-rate bypass still fires", () => {
+    withPrefs(
+      [
+        "dynamic_routing:",
+        "  enabled: true",
+        "  allow_flat_rate_providers: false",
+        "  tier_models:",
+        "    heavy: claude-opus-4-6",
+      ].join("\n"),
+      () => {
+        const result = resolvePreferredModelConfig("execute-task", {
+          provider: "claude-code",
+          id: "claude-opus-4-6",
+        });
+        assert.equal(result, undefined, "explicit opt-out behaves like default");
+      },
+    );
+  });
+});
+
+// ─── Banner transparency: auto-start respects the opt-in (#4386) ────────────
+
+describe("auto-start banner respects allow_flat_rate_providers (#4386)", () => {
+  test("banner expression gates flat-rate disable on allow_flat_rate_providers", () => {
+    const src = readFileSync(
+      join(__dirname_4386, "..", "auto-start.ts"),
+      "utf-8",
+    );
+    assert.ok(
+      src.includes("routingConfig.allow_flat_rate_providers"),
+      "auto-start banner must read allow_flat_rate_providers so the banner reflects the opt-in",
+    );
+  });
+});

package/src/resources/extensions/gsd/tests/forensics-hook-key-parse.test.ts

@@ -0,0 +1,74 @@
+/**
+ * Regression test for #2826: detectMissingArtifacts must parse hook/
+ * compound unit types correctly, not just the first slash segment.
+ *
+ * Keys like "hook/telegram-progress/M007/S01" must yield:
+ *   unitType = "hook/telegram-progress"  (not "hook")
+ *   unitId   = "M007/S01"               (not "telegram-progress/M007/S01")
+ *
+ * The fix extracts a shared splitCompletedKey() helper used by both
+ * forensics.ts and doctor-runtime-checks.ts.
+ */
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { fileURLToPath } from "node:url";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const gsdDir = join(__dirname, "..");
+
+describe("forensics hook compound key parsing (#2826)", () => {
+  const forensicsSrc = readFileSync(join(gsdDir, "forensics.ts"), "utf-8");
+  const doctorSrc = readFileSync(join(gsdDir, "doctor-runtime-checks.ts"), "utf-8");
+
+  it("forensics.ts exports splitCompletedKey helper", () => {
+    assert.ok(
+      forensicsSrc.includes("export function splitCompletedKey("),
+      "forensics.ts must export splitCompletedKey()",
+    );
+  });
+
+  it("splitCompletedKey handles hook/ prefix by splitting on the second slash", () => {
+    assert.ok(
+      forensicsSrc.includes('key.startsWith("hook/")'),
+      'splitCompletedKey must branch on key.startsWith("hook/")',
+    );
+    assert.ok(
+      forensicsSrc.includes('key.indexOf("/", 5)'),
+      'splitCompletedKey must use indexOf("/", 5) to find second slash past "hook/"',
+    );
+  });
+
+  it("detectMissingArtifacts delegates to splitCompletedKey", () => {
+    const fnStart = forensicsSrc.indexOf("function detectMissingArtifacts(");
+    assert.ok(fnStart !== -1, "detectMissingArtifacts must exist in forensics.ts");
+    const fnBody = forensicsSrc.slice(fnStart, fnStart + 1000);
+    assert.ok(
+      fnBody.includes("splitCompletedKey("),
+      "detectMissingArtifacts must call splitCompletedKey() rather than inline the split logic",
+    );
+  });
+
+  it("doctor-runtime-checks.ts imports and uses splitCompletedKey", () => {
+    assert.ok(
+      doctorSrc.includes('from "./forensics.js"'),
+      'doctor-runtime-checks.ts must import from "./forensics.js"',
+    );
+    assert.ok(
+      doctorSrc.includes("splitCompletedKey"),
+      "doctor-runtime-checks.ts must use splitCompletedKey()",
+    );
+  });
+
+  it("splitCompletedKey unit: plain type", () => {
+    // Inline test of the helper logic to guard against future regressions
+    // without needing a filesystem setup.
+    const src = forensicsSrc;
+    // Confirm the plain-type branch also exists
+    assert.ok(
+      src.includes('slashIdx = key.indexOf("/")') || src.includes("key.indexOf(\"/\")"),
+      "splitCompletedKey must handle plain (non-hook) keys via first-slash split",
+    );
+  });
+});

package/src/resources/extensions/gsd/tests/freeform-decisions.test.ts

@@ -6,6 +6,7 @@ import * as fs from 'node:fs';
 import {
   openDatabase,
   closeDatabase,
+  _getAdapter,
 } from '../gsd-db.ts';
 import {
   parseDecisionsTable,
@@ -30,6 +31,13 @@ function cleanupDir(dir: string): void {
   } catch { /* swallow */ }
 }
 
+/** Query all decisions from the DB ordered by seq. */
+function queryAllDecisions(): Array<Record<string, unknown>> {
+  const adapter = _getAdapter();
+  if (!adapter) return [];
+  return adapter.prepare('SELECT * FROM decisions ORDER BY seq').all();
+}
+
 // ═══════════════════════════════════════════════════════════════════════════
 // Bug reproduction: freeform DECISIONS.md content destroyed (#2301)
 // ═══════════════════════════════════════════════════════════════════════════
@@ -87,6 +95,13 @@ describe('freeform-decisions', () => {
 
       assert.deepStrictEqual(result.id, 'D001', 'decision ID assigned correctly');
 
+      // ── Assert DB state ──
+      const dbRows = queryAllDecisions();
+      assert.equal(dbRows.length, 1, 'DB has exactly 1 decision after first save');
+      assert.equal(dbRows[0]['id'], 'D001', 'DB row has correct ID');
+      assert.equal(dbRows[0]['scope'], 'testing', 'DB row has correct scope');
+      assert.equal(dbRows[0]['decision'], 'Use Jest for unit tests', 'DB row has correct decision text');
+
       // Read back the file
       const afterContent = fs.readFileSync(mdPath, 'utf-8');
 
@@ -125,6 +140,13 @@ describe('freeform-decisions', () => {
 
       assert.deepStrictEqual(result2.id, 'D002', 'second decision ID assigned correctly');
 
+      // ── Assert DB state after second save ──
+      const dbRows2 = queryAllDecisions();
+      assert.equal(dbRows2.length, 2, 'DB has exactly 2 decisions after second save');
+      assert.equal(dbRows2[0]['id'], 'D001', 'first DB row still D001');
+      assert.equal(dbRows2[1]['id'], 'D002', 'second DB row is D002');
+      assert.equal(dbRows2[1]['scope'], 'ci', 'second DB row has correct scope');
+
       const afterContent2 = fs.readFileSync(mdPath, 'utf-8');
 
       assert.ok(
@@ -182,6 +204,12 @@ describe('freeform-decisions', () => {
       // But the new decision should be there.
       assert.deepStrictEqual(result.id, 'D001', 'gets D001 since DB was empty');
 
+      // ── Assert DB state ──
+      const dbRows = queryAllDecisions();
+      assert.equal(dbRows.length, 1, 'DB has exactly 1 decision');
+      assert.equal(dbRows[0]['id'], 'D001', 'DB row has correct ID');
+      assert.equal(dbRows[0]['decision'], 'Use Vitest', 'DB row has correct decision text');
+
       const afterContent = fs.readFileSync(mdPath, 'utf-8');
       // Table-format file gets fully regenerated — this is the normal path
       assert.ok(
@@ -218,6 +246,13 @@ describe('freeform-decisions', () => {
       assert.deepStrictEqual(result.id, 'D001', 'first decision gets D001');
       assert.ok(fs.existsSync(mdPath), 'DECISIONS.md created');
 
+      // ── Assert DB state ──
+      const dbRows = queryAllDecisions();
+      assert.equal(dbRows.length, 1, 'DB has exactly 1 decision');
+      assert.equal(dbRows[0]['id'], 'D001', 'DB row ID is D001');
+      assert.equal(dbRows[0]['scope'], 'arch', 'DB row scope is arch');
+      assert.equal(dbRows[0]['decision'], 'Brand new decision', 'DB row decision text matches');
+
       const content = fs.readFileSync(mdPath, 'utf-8');
       assert.ok(content.includes('# Decisions Register'), 'new file has header');
       assert.ok(content.includes('Brand new decision'), 'new file has decision');
@@ -227,6 +262,33 @@ describe('freeform-decisions', () => {
     }
   });
 
+  test('parallel saveDecisionToDb calls assign unique IDs', async () => {
+    const tmpDir = makeTmpDir();
+    const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
+    openDatabase(dbPath);
+
+    try {
+      const [r1, r2, r3] = await Promise.all([
+        saveDecisionToDb({ scope: 'a', decision: 'Decision A', choice: 'A', rationale: 'A' }, tmpDir),
+        saveDecisionToDb({ scope: 'b', decision: 'Decision B', choice: 'B', rationale: 'B' }, tmpDir),
+        saveDecisionToDb({ scope: 'c', decision: 'Decision C', choice: 'C', rationale: 'C' }, tmpDir),
+      ]);
+
+      const ids = new Set([r1.id, r2.id, r3.id]);
+      assert.strictEqual(ids.size, 3, `expected 3 unique IDs but got: ${[r1.id, r2.id, r3.id]}`);
+
+      // Verify all 3 decisions exist in the markdown file
+      const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
+      const content = fs.readFileSync(mdPath, 'utf-8');
+      assert.ok(content.includes('Decision A'), 'Decision A in file');
+      assert.ok(content.includes('Decision B'), 'Decision B in file');
+      assert.ok(content.includes('Decision C'), 'Decision C in file');
+    } finally {
+      closeDatabase();
+      cleanupDir(tmpDir);
+    }
+  });
+
   // ═══════════════════════════════════════════════════════════════════════════
 
 });

package/src/resources/extensions/gsd/tests/graph-operations.test.ts

@@ -19,7 +19,6 @@ import {
   markStepComplete,
   expandIteration,
   initializeGraph,
-  graphFromDefinition,
   type WorkflowGraph,
   type GraphStep,
 } from "../graph.ts";
@@ -459,9 +458,6 @@ describe("initializeGraph", () => {
     assert.deepStrictEqual(graph.steps[2].dependsOn, ["s1", "s2"]);
   });
 
-  it("is also exported as graphFromDefinition (backward compat)", (t) => {
-    assert.equal(graphFromDefinition, initializeGraph);
-  });
 });
 
 // ─── Atomic write safety ─────────────────────────────────────────────────

package/src/resources/extensions/gsd/tests/gsd-db.test.ts

@@ -23,6 +23,7 @@ import {
   insertTask,
   getTask,
   getSliceTasks,
+  checkpointDatabase,
 } from '../gsd-db.ts';
 
 // ═══════════════════════════════════════════════════════════════════════════
@@ -80,7 +81,7 @@ describe('gsd-db', () => {
     // Check schema_version table
     const adapter = _getAdapter()!;
     const version = adapter.prepare('SELECT MAX(version) as version FROM schema_version').get();
-    assert.deepStrictEqual(version?.['version'], 15, 'schema version should be 15');
+    assert.deepStrictEqual(version?.['version'], 21, 'schema version should be 21');
 
     // Check tables exist by querying them
     const dRows = adapter.prepare('SELECT count(*) as cnt FROM decisions').get();
@@ -518,6 +519,48 @@ describe('gsd-db', () => {
     closeDatabase();
   });
 
+  // ─── checkpointDatabase ────────────────────────────────────────────────────
+
+  describe('checkpointDatabase', () => {
+    test('checkpointDatabase: flushes WAL into base file (TRUNCATE)', (t) => {
+      const dbPath = tempDbPath();
+      t.after(() => cleanup(dbPath));
+
+      openDatabase(dbPath);
+
+      // Write enough data to ensure WAL has content
+      transaction(() => {
+        insertDecision({
+          id: 'D001',
+          when_context: 'test',
+          scope: 'global',
+          decision: 'WAL flush test',
+          choice: 'checkpoint',
+          rationale: 'WAL checkpoint regression test — #4418',
+          revisable: 'yes',
+          made_by: 'agent',
+          superseded_by: null,
+        });
+      });
+
+      const walPath = dbPath + '-wal';
+      assert.ok(fs.existsSync(walPath), 'WAL file should exist after write');
+      const walSizeBefore = fs.statSync(walPath).size;
+      assert.ok(walSizeBefore > 0, 'WAL file should be non-empty after write');
+
+      checkpointDatabase();
+
+      const walSizeAfter = fs.existsSync(walPath) ? fs.statSync(walPath).size : 0;
+      assert.equal(walSizeAfter, 0, 'WAL file should be truncated to 0 after checkpoint');
+    });
+
+    test('checkpointDatabase: is a no-op when no database is open', () => {
+      closeDatabase();
+      // Must not throw
+      assert.doesNotThrow(() => checkpointDatabase());
+    });
+  });
+
   // ─── Final Report ──────────────────────────────────────────────────────────
 
 });

package/src/resources/extensions/gsd/tests/health-widget.test.ts

@@ -191,6 +191,7 @@ test("session_start bootstraps the health widget alongside notifications", async
   });
 
   const widgets: string[] = [];
+  const statuses: string[] = [];
   const handlers = new Map<string, (event: unknown, ctx: any) => Promise<void> | void>();
   const pi = {
     on(event: string, handler: (event: unknown, ctx: any) => Promise<void> | void) {
@@ -206,7 +207,9 @@ test("session_start bootstraps the health widget alongside notifications", async
     hasUI: true,
     ui: {
       notify: () => {},
-      setStatus: () => {},
+      setStatus: (key: string) => {
+        statuses.push(key);
+      },
       setWorkingMessage: () => {},
       onTerminalInput: () => () => {},
       setWidget: (key: string) => {
@@ -220,5 +223,8 @@ test("session_start bootstraps the health widget alongside notifications", async
   } as any);
 
   assert.ok(widgets.includes("gsd-health"), "health widget is bootstrapped");
-  assert.ok(widgets.includes("gsd-notifications"), "notification widget still boots");
+  assert.ok(
+    statuses.some((k) => k.includes("notifications")),
+    "notification status chip is registered",
+  );
 });