gsd-pi 2.75.0-dev.063e5a3 → 2.75.0-dev.fd2382b9f

package/src/resources/extensions/gsd/tests/doctor-providers.test.ts

@@ -14,7 +14,7 @@
 
 import test from "node:test";
 import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, realpathSync } from "node:fs";
+import { mkdtempSync, mkdirSync, writeFileSync, rmSync, realpathSync, chmodSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 
@@ -219,6 +219,9 @@ test("runProviderChecks returns error for Anthropic when no key present", () =>
     GH_TOKEN: undefined,
     GITHUB_TOKEN: undefined,
     HOME: tmpHome,
+    // Use a PATH that contains no AI CLI binaries (claude, codex, gemini, etc.)
+    // so the claude-code route is not considered available
+    PATH: tmpHome,
   }, () => {
     try {
       const results = runProviderChecks();
@@ -295,26 +298,33 @@ test("runProviderChecks detects key from auth.json", () => {
 });
 
 test("runProviderChecks ignores empty placeholder keys in auth.json", () => {
-  withEnv({ ANTHROPIC_API_KEY: undefined, ANTHROPIC_OAUTH_TOKEN: undefined, COPILOT_GITHUB_TOKEN: undefined, GH_TOKEN: undefined, GITHUB_TOKEN: undefined }, () => {
-    const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-test-")));
-    const agentDir = join(tmpHome, ".gsd", "agent");
-    mkdirSync(agentDir, { recursive: true });
-
-    // Empty key — what onboarding writes when user skips
-    const authData = {
-      anthropic: { type: "api_key", key: "" },
-    };
-    writeFileSync(join(agentDir, "auth.json"), JSON.stringify(authData));
+  const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-test-")));
+  const agentDir = join(tmpHome, ".gsd", "agent");
+  mkdirSync(agentDir, { recursive: true });
 
-    withEnv({ HOME: tmpHome }, () => {
-      const results = runProviderChecks();
-      const anthropic = results.find(r => r.name === "anthropic");
-      assert.ok(anthropic, "anthropic should be present");
-      assert.equal(anthropic!.status, "error", "empty placeholder key should count as not configured");
-    });
+  // Empty key — what onboarding writes when user skips
+  const authData = {
+    anthropic: { type: "api_key", key: "" },
+  };
+  writeFileSync(join(agentDir, "auth.json"), JSON.stringify(authData));
 
-    rmSync(tmpHome, { recursive: true, force: true });
+  withEnv({
+    ANTHROPIC_API_KEY: undefined,
+    ANTHROPIC_OAUTH_TOKEN: undefined,
+    COPILOT_GITHUB_TOKEN: undefined,
+    GH_TOKEN: undefined,
+    GITHUB_TOKEN: undefined,
+    HOME: tmpHome,
+    // Exclude AI CLI binaries so the claude-code route is not considered available
+    PATH: tmpHome,
+  }, () => {
+    const results = runProviderChecks();
+    const anthropic = results.find(r => r.name === "anthropic");
+    assert.ok(anthropic, "anthropic should be present");
+    assert.equal(anthropic!.status, "error", "empty placeholder key should count as not configured");
   });
+
+  rmSync(tmpHome, { recursive: true, force: true });
 });
 
 // ─── runProviderChecks — cross-provider routing ──────────────────────────────
@@ -610,6 +620,40 @@ test("runProviderChecks reports ok for claude-code without any API key", () => {
   rmSync(tmpHome, { recursive: true, force: true });
 });
 
+test("runProviderChecks reports ok for Anthropic via claude-code binary in PATH", () => {
+  // Simulate a user who has no Anthropic API key but has the claude CLI installed.
+  // Their PREFERENCES use a claude model without an explicit provider, so the doctor
+  // infers "anthropic" — but the claude-code route should satisfy it.
+  const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-cc-route-home-")));
+  const binDir = join(tmpHome, "bin");
+  mkdirSync(binDir, { recursive: true });
+
+  // Create a fake `claude` binary so the PATH scan finds it
+  const fakeClaude = join(binDir, "claude");
+  writeFileSync(fakeClaude, "#!/bin/sh\necho mock\n");
+  chmodSync(fakeClaude, 0o755);
+
+  withEnv({
+    HOME: tmpHome,
+    ANTHROPIC_API_KEY: undefined,
+    ANTHROPIC_OAUTH_TOKEN: undefined,
+    COPILOT_GITHUB_TOKEN: undefined,
+    GH_TOKEN: undefined,
+    GITHUB_TOKEN: undefined,
+    PATH: `${binDir}:${process.env.PATH ?? ""}`,
+  }, () => {
+    try {
+      const results = runProviderChecks();
+      const anthropic = results.find(r => r.name === "anthropic");
+      assert.ok(anthropic, "anthropic result should exist");
+      assert.equal(anthropic!.status, "ok", "should be ok when claude CLI binary is in PATH");
+      assert.ok(anthropic!.message.toLowerCase().includes("claude"), "should mention claude-code as source");
+    } finally {
+      rmSync(tmpHome, { recursive: true, force: true });
+    }
+  });
+});
+
 test("PROVIDER_ROUTES includes google-gemini-cli as route for google (#2922)", async () => {
   const { readFileSync: readFS } = await import("node:fs");
   const { dirname: dirn, join: joinPath } = await import("node:path");

package/src/resources/extensions/gsd/tests/enhanced-verification-integration.test.ts

@@ -70,6 +70,11 @@ function createTask(overrides: Partial<TaskRow> = {}): TaskRow {
     observability_impact: "",
     full_plan_md: "",
     sequence: overrides.sequence ?? 0,
+    blocker_source: "",
+    escalation_pending: 0,
+    escalation_awaiting_review: 0,
+    escalation_artifact_path: null,
+    escalation_override_applied_at: null,
     ...overrides,
   };
 }