gsd-pi 2.74.0 → 2.75.0-dev.2203010a0

package/dist/resources/extensions/gsd/auto-post-unit.js

@@ -1,14 +1,14 @@
 /**
- * Post-unit processing for handleAgentEnd — auto-commit, doctor run,
+ * Post-unit processing for auto-loop — auto-commit, doctor run,
  * state rebuild, worktree sync, DB dual-write, hooks, triage, and
  * quick-task dispatch.
  *
- * Split into two functions called sequentially by handleAgentEnd with
+ * Split into two functions called sequentially by auto-loop with
  * the verification gate between them:
  *   1. postUnitPreVerification() — commit, doctor, state rebuild, worktree sync, artifact verification
  *   2. postUnitPostVerification() — DB dual-write, hooks, triage, quick-tasks
  *
- * Extracted from handleAgentEnd() in auto.ts.
+ * Extracted from the pre-loop agent_end handler in auto.ts.
  */
 import { deriveState } from "./state.js";
 import { logWarning, logError } from "./workflow-logger.js";
@@ -19,7 +19,7 @@ import { invalidateAllCaches } from "./cache.js";
 import { rebuildState } from "./doctor.js";
 import { parseUnitId } from "./unit-id.js";
 import { closeoutUnit } from "./auto-unit-closeout.js";
-import { autoCommitCurrentBranch, } from "./worktree.js";
+import { runTurnGitAction, } from "./git-service.js";
 import { verifyExpectedArtifact, resolveExpectedArtifactPath, writeBlockerPlaceholder, diagnoseExpectedArtifact, } from "./auto-recovery.js";
 import { regenerateIfMissing } from "./workflow-projections.js";
 import { syncStateToProjectRoot } from "./auto-worktree.js";
@@ -42,6 +42,9 @@ import { getSliceTasks } from "./gsd-db.js";
 import { runPreExecutionChecks } from "./pre-execution-checks.js";
 import { writePreExecutionEvidence } from "./verification-evidence.js";
 import { ensureCodebaseMapFresh } from "./codebase-generator.js";
+import { resolveUokFlags } from "./uok/flags.js";
+import { UokGateRunner } from "./uok/gate-runner.js";
+import { writeTurnGitTransaction } from "./uok/gitops.js";
 /** Maximum verification retry attempts before escalating to blocker placeholder (#2653). */
 const MAX_VERIFICATION_RETRIES = 3;
 /** Enqueue a sidecar item (hook, triage, or quick-task) for the main loop to
@@ -63,7 +66,7 @@ function enqueueSidecar(s, ctx, entry, debugExtra, notification) {
  *  next actual task commit via `smartStage()`. */
 const LIFECYCLE_ONLY_UNITS = new Set([
     "research-milestone", "discuss-milestone", "discuss-slice", "plan-milestone",
-    "validate-milestone", "research-slice", "plan-slice",
+    "validate-milestone", "research-slice", "plan-slice", "refine-slice",
     "replan-slice", "complete-slice", "run-uat",
     "reassess-roadmap", "rewrite-docs",
 ]);
@@ -71,6 +74,7 @@ import { describeNextUnit, } from "./auto-dashboard.js";
 import { existsSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
 import { _resetHasChangesCache } from "./native-git-bridge.js";
+import { autoCommitCurrentBranch } from "./worktree.js";
 /**
  * Detect summary files written directly to disk without the LLM calling
  * the completion tool. A "rogue" file is one that exists on disk but has
@@ -135,7 +139,7 @@ export function detectRogueFileWrites(unitType, unitId, basePath) {
             rogues.push({ path: roadmapPath, unitType, unitId });
         }
     }
-    else if (unitType === "plan-slice" || unitType === "replan-slice") {
+    else if (unitType === "plan-slice" || unitType === "refine-slice" || unitType === "replan-slice") {
         if (!mid || !sid)
             return [];
         const planPath = resolveSliceFile(basePath, mid, sid, "PLAN");
@@ -189,6 +193,57 @@ export function buildStepCompleteMessage(nextState) {
     return `Step complete. Next: ${next.label}\n`
         + `Run /clear, then /gsd to continue (or /gsd auto to run continuously).`;
 }
+export async function autoCommitUnit(basePath, unitType, unitId, ctx) {
+    try {
+        let taskContext;
+        if (unitType === "execute-task") {
+            const { milestone: mid, slice: sid, task: tid } = parseUnitId(unitId);
+            if (mid && sid && tid) {
+                const summaryPath = resolveTaskFile(basePath, mid, sid, tid, "SUMMARY");
+                if (summaryPath) {
+                    try {
+                        const summaryContent = await loadFile(summaryPath);
+                        if (summaryContent) {
+                            const summary = parseSummary(summaryContent);
+                            let ghIssueNumber;
+                            try {
+                                const { getTaskIssueNumberForCommit } = await import("../github-sync/sync.js");
+                                ghIssueNumber = getTaskIssueNumberForCommit(basePath, mid, sid, tid) ?? undefined;
+                            }
+                            catch (err) {
+                                logWarning("engine", `GitHub issue lookup failed: ${err instanceof Error ? err.message : String(err)}`);
+                            }
+                            taskContext = {
+                                taskId: `${sid}/${tid}`,
+                                taskTitle: summary.title?.replace(/^T\d+:\s*/, "") || tid,
+                                oneLiner: summary.oneLiner || undefined,
+                                keyFiles: summary.frontmatter.key_files?.filter(f => !f.includes("{{")) || undefined,
+                                issueNumber: ghIssueNumber,
+                            };
+                        }
+                    }
+                    catch (e) {
+                        debugLog("postUnit", { phase: "task-summary-parse", error: String(e) });
+                    }
+                }
+            }
+        }
+        _resetHasChangesCache();
+        if (LIFECYCLE_ONLY_UNITS.has(unitType)) {
+            return null;
+        }
+        const commitMsg = autoCommitCurrentBranch(basePath, unitType, unitId, taskContext);
+        if (commitMsg) {
+            ctx?.ui.notify(`Committed: ${commitMsg.split("\n")[0]}`, "info");
+        }
+        return commitMsg;
+    }
+    catch (e) {
+        debugLog("postUnit", { phase: "auto-commit", error: String(e) });
+        ctx?.ui.notify(`Auto-commit failed: ${String(e).split("\n")[0]}`, "warning");
+        return null;
+    }
+}
 /**
  * Pre-verification processing: parallel worker signal check, cache invalidation,
  * auto-commit, doctor run, state rebuild, worktree sync, artifact verification.
@@ -221,12 +276,19 @@ export async function postUnitPreVerification(pctx, opts) {
     if (!opts?.skipSettleDelay) {
         await new Promise(r => setTimeout(r, 100));
     }
-    // Auto-commit
+    const prefs = loadEffectiveGSDPreferences()?.preferences;
+    const uokFlags = resolveUokFlags(prefs);
+    // Turn-level git action (commit | snapshot | status-only)
     if (s.currentUnit) {
         const unit = s.currentUnit;
+        const turnAction = uokFlags.gitops ? uokFlags.gitopsTurnAction : "commit";
+        const traceId = s.currentTraceId ?? `turn:${unit.startedAt}`;
+        const turnId = s.currentTurnId ?? `${unit.type}/${unit.id}/${unit.startedAt}`;
+        s.lastGitActionFailure = null;
+        s.lastGitActionStatus = null;
         try {
             let taskContext;
-            if (s.currentUnit.type === "execute-task") {
+            if (turnAction === "commit" && s.currentUnit.type === "execute-task") {
                 const { milestone: mid, slice: sid, task: tid } = parseUnitId(s.currentUnit.id);
                 if (mid && sid && tid) {
                     const summaryPath = resolveTaskFile(s.basePath, mid, sid, tid, "SUMMARY");
@@ -266,19 +328,101 @@ export async function postUnitPreVerification(pctx, opts) {
             // code files only in the working tree where they are destroyed by
             // `git worktree remove --force` during teardown.
             _resetHasChangesCache();
-            // Skip auto-commit for lifecycle-only units (#2553) — they only touch
-            // `.gsd/` internal state files. Those files are picked up by the next
-            // actual task commit via smartStage().
-            if (!LIFECYCLE_ONLY_UNITS.has(s.currentUnit.type)) {
-                const commitMsg = autoCommitCurrentBranch(s.basePath, s.currentUnit.type, s.currentUnit.id, taskContext);
-                if (commitMsg) {
-                    ctx.ui.notify(`Committed: ${commitMsg.split("\n")[0]}`, "info");
+            const skipLifecycleCommit = turnAction === "commit" && LIFECYCLE_ONLY_UNITS.has(s.currentUnit.type);
+            if (skipLifecycleCommit) {
+                debugLog("postUnit", {
+                    phase: "git-action-skipped",
+                    reason: "lifecycle-only-unit",
+                    unitType: s.currentUnit.type,
+                    unitId: s.currentUnit.id,
+                });
+            }
+            else {
+                const gitResult = runTurnGitAction({
+                    basePath: s.basePath,
+                    action: turnAction,
+                    unitType: s.currentUnit.type,
+                    unitId: s.currentUnit.id,
+                    taskContext,
+                });
+                if (uokFlags.gitops) {
+                    writeTurnGitTransaction({
+                        basePath: s.basePath,
+                        traceId,
+                        turnId,
+                        unitType: unit.type,
+                        unitId: unit.id,
+                        stage: "publish",
+                        action: turnAction,
+                        push: uokFlags.gitopsTurnPush,
+                        status: gitResult.status,
+                        error: gitResult.error,
+                        metadata: {
+                            dirty: gitResult.dirty,
+                            commitMessage: gitResult.commitMessage,
+                            snapshotLabel: gitResult.snapshotLabel,
+                        },
+                    });
+                }
+                if (gitResult.status === "failed") {
+                    s.lastGitActionFailure = gitResult.error ?? `git ${turnAction} failed`;
+                    s.lastGitActionStatus = "failed";
+                    if (uokFlags.gitops && uokFlags.gates) {
+                        const parsed = parseUnitId(unit.id);
+                        const gateRunner = new UokGateRunner();
+                        gateRunner.register({
+                            id: "closeout-git-action",
+                            type: "closeout",
+                            execute: async () => ({
+                                outcome: "fail",
+                                failureClass: "git",
+                                rationale: `turn git action "${turnAction}" failed`,
+                                findings: gitResult.error ?? "unknown git failure",
+                            }),
+                        });
+                        await gateRunner.run("closeout-git-action", {
+                            basePath: s.basePath,
+                            traceId,
+                            turnId,
+                            milestoneId: parsed.milestone ?? undefined,
+                            sliceId: parsed.slice ?? undefined,
+                            taskId: parsed.task ?? undefined,
+                            unitType: unit.type,
+                            unitId: unit.id,
+                        });
+                    }
+                    const failureMsg = `Git ${turnAction} failed: ${(gitResult.error ?? "unknown error").split("\n")[0]}`;
+                    if (uokFlags.gitops) {
+                        ctx.ui.notify(failureMsg, "error");
+                        await pauseAuto(ctx, pi);
+                        return "dispatched";
+                    }
+                    ctx.ui.notify(failureMsg, "warning");
+                    debugLog("postUnit", {
+                        phase: "git-action-failed-nonblocking",
+                        action: turnAction,
+                        error: gitResult.error ?? "unknown error",
+                    });
+                }
+                s.lastGitActionStatus = "ok";
+                if (turnAction === "commit" && gitResult.commitMessage) {
+                    ctx.ui.notify(`Committed: ${gitResult.commitMessage.split("\n")[0]}`, "info");
+                }
+                else if (turnAction === "snapshot" && gitResult.snapshotLabel) {
+                    ctx.ui.notify(`Snapshot recorded: ${gitResult.snapshotLabel}`, "info");
                 }
             }
         }
         catch (e) {
-            debugLog("postUnit", { phase: "auto-commit", error: String(e) });
-            ctx.ui.notify(`Auto-commit failed: ${String(e).split("\n")[0]}`, "warning");
+            const message = e instanceof Error ? e.message : String(e);
+            s.lastGitActionFailure = message;
+            s.lastGitActionStatus = "failed";
+            debugLog("postUnit", { phase: "git-action", error: message, action: turnAction });
+            ctx.ui.notify(`Git ${turnAction} failed: ${message.split("\n")[0]}`, uokFlags.gitops ? "error" : "warning");
+            if (uokFlags.gitops) {
+                await pauseAuto(ctx, pi);
+                return "dispatched";
+            }
         }
         // GitHub sync (non-blocking, opt-in)
         await runSafely("postUnit", "github-sync", async () => {
@@ -467,7 +611,7 @@ export async function postUnitPreVerification(pctx, opts) {
                 try {
                     const { milestone: mid, slice: sid } = parseUnitId(s.currentUnit.id);
                     if (mid && sid) {
-                        const regenerated = regenerateIfMissing(s.basePath, mid, sid, "PLAN");
+                        const regenerated = await regenerateIfMissing(s.basePath, mid, sid, "PLAN");
                         if (regenerated) {
                             // Re-check after regeneration
                             triggerArtifactVerified = verifyExpectedArtifact(s.currentUnit.type, s.currentUnit.id, s.basePath);
@@ -711,14 +855,18 @@ export async function postUnitPostVerification(pctx) {
             debugLog("postUnit", { phase: "capture-protection-error", error: String(e) });
         }
     }
-    // ── Pre-execution checks (after plan-slice completes) ──
+    // ── Pre-execution checks (after plan-slice or ADR-011 refine-slice completes) ──
+    // Both emit the same PLAN.md + task artifacts via gsd_plan_slice, so the
+    // same structural validation applies to both.
     if (s.currentUnit &&
-        s.currentUnit.type === "plan-slice") {
+        (s.currentUnit.type === "plan-slice" || s.currentUnit.type === "refine-slice")) {
+        const currentUnit = s.currentUnit;
         let preExecPauseNeeded = false;
         await runSafely("postUnitPostVerification", "pre-execution-checks", async () => {
+            const prefs = loadEffectiveGSDPreferences()?.preferences;
+            const uokFlags = resolveUokFlags(prefs);
             try {
                 // Check preferences — respect enhanced_verification and enhanced_verification_pre
-                const prefs = loadEffectiveGSDPreferences()?.preferences;
                 const enhancedEnabled = prefs?.enhanced_verification !== false; // default true
                 const preEnabled = prefs?.enhanced_verification_pre !== false; // default true
                 if (!enhancedEnabled || !preEnabled) {
@@ -730,7 +878,7 @@ export async function postUnitPostVerification(pctx) {
                     return;
                 }
                 // Parse the unit ID to get milestone/slice IDs
-                const { milestone: mid, slice: sid } = parseUnitId(s.currentUnit.id);
+                const { milestone: mid, slice: sid } = parseUnitId(currentUnit.id);
                 if (!mid || !sid) {
                     debugLog("postUnitPostVerification", {
                         phase: "pre-execution-checks",
@@ -749,6 +897,7 @@ export async function postUnitPostVerification(pctx) {
                     });
                     return;
                 }
+                const strictMode = prefs?.enhanced_verification_strict === true;
                 // Run pre-execution checks
                 const result = await runPreExecutionChecks(tasks, s.basePath);
                 // Log summary to stderr in existing verification output format
@@ -764,10 +913,43 @@ export async function postUnitPostVerification(pctx) {
                 if (slicePath) {
                     writePreExecutionEvidence(result, slicePath, mid, sid);
                 }
-                // Notify UI
+                if (uokFlags.gates) {
+                    const failedChecks = result.checks
+                        .filter((check) => !check.passed)
+                        .map((check) => `[${check.category}] ${check.target}: ${check.message}`);
+                    const warnEscalated = result.status === "warn" && strictMode;
+                    const blockingFailure = result.status === "fail" || warnEscalated;
+                    const gateRunner = new UokGateRunner();
+                    gateRunner.register({
+                        id: "pre-execution-checks",
+                        type: "input",
+                        execute: async () => ({
+                            outcome: blockingFailure ? "fail" : "pass",
+                            failureClass: result.status === "fail" ? "input" : warnEscalated ? "policy" : "none",
+                            rationale: blockingFailure
+                                ? `pre-execution checks ${result.status}${warnEscalated ? " (strict)" : ""}`
+                                : "pre-execution checks passed",
+                            findings: failedChecks.join("\n"),
+                        }),
+                    });
+                    await gateRunner.run("pre-execution-checks", {
+                        basePath: s.basePath,
+                        traceId: `pre-execution:${currentUnit.id}`,
+                        turnId: currentUnit.id,
+                        milestoneId: mid,
+                        sliceId: sid,
+                        unitType: currentUnit.type,
+                        unitId: currentUnit.id,
+                    });
+                }
+                // Notify UI — surface actionable details (#4259)
                 if (result.status === "fail") {
-                    const blockingCount = result.checks.filter(c => !c.passed && c.blocking).length;
-                    ctx.ui.notify(`Pre-execution checks failed: ${blockingCount} blocking issue${blockingCount === 1 ? "" : "s"} found`, "error");
+                    const blockingChecks = result.checks.filter(c => !c.passed && c.blocking);
+                    const blockingCount = blockingChecks.length;
+                    const details = blockingChecks.slice(0, 3).map(c => `  \u2022 ${c.message}`).join("\n");
+                    const suffix = blockingChecks.length > 3 ? `\n  \u2022 ...and ${blockingChecks.length - 3} more` : "";
+                    const evidenceNote = `\nSee ${sid}-PRE-EXEC-VERIFY.json for full details.`;
+                    ctx.ui.notify(`Pre-execution checks failed: ${blockingCount} blocking issue${blockingCount === 1 ? "" : "s"} found\n${details}${suffix}${evidenceNote}`, "error");
                     preExecPauseNeeded = true;
                 }
                 else if (result.status === "warn") {
@@ -794,6 +976,29 @@ export async function postUnitPostVerification(pctx) {
                 });
                 logError("engine", `gsd-pre-exec: Pre-execution checks threw an error: ${errorMessage}`);
                 ctx.ui.notify(`Pre-execution checks error: ${errorMessage} — pausing for human review`, "error");
+                if (uokFlags.gates && s.currentUnit) {
+                    const { milestone: mid, slice: sid } = parseUnitId(s.currentUnit.id);
+                    const gateRunner = new UokGateRunner();
+                    gateRunner.register({
+                        id: "pre-execution-checks",
+                        type: "input",
+                        execute: async () => ({
+                            outcome: "manual-attention",
+                            failureClass: "manual-attention",
+                            rationale: "pre-execution checks threw before completion",
+                            findings: errorMessage,
+                        }),
+                    });
+                    await gateRunner.run("pre-execution-checks", {
+                        basePath: s.basePath,
+                        traceId: `pre-execution:${s.currentUnit.id}`,
+                        turnId: s.currentUnit.id,
+                        milestoneId: mid ?? undefined,
+                        sliceId: sid ?? undefined,
+                        unitType: s.currentUnit.type,
+                        unitId: s.currentUnit.id,
+                    });
+                }
                 preExecPauseNeeded = true;
             }
         });