gsd-pi 2.74.0-dev.2b524c3 → 2.74.0-dev.703eabc

package/dist/resources/extensions/gsd/workflow-manifest.js

@@ -1,4 +1,4 @@
-import { _getAdapter, transaction, } from "./gsd-db.js";
+import { _getAdapter, readTransaction, restoreManifest, } from "./gsd-db.js";
 import { atomicWriteSync } from "./atomic-write.js";
 import { readFileSync, existsSync, mkdirSync } from "node:fs";
 import { join } from "node:path";
@@ -41,8 +41,7 @@ export function snapshotState() {
     const db = requireDb();
     // Wrap all reads in a deferred transaction so the snapshot is consistent
     // (all SELECTs see the same DB state even if a concurrent write lands between them).
-    db.exec("BEGIN DEFERRED");
-    try {
+    return readTransaction(() => {
         const rawMilestones = db.prepare("SELECT * FROM milestones ORDER BY id").all();
         const milestones = rawMilestones.map((r) => ({
             id: r["id"],
@@ -146,74 +145,14 @@ export function snapshotState() {
             decisions,
             verification_evidence,
         };
-        db.exec("COMMIT");
         return result;
-    }
-    catch (err) {
-        try {
-            db.exec("ROLLBACK");
-        }
-        catch { /* ignore rollback failure */ }
-        throw err;
-    }
-}
-// ─── restore ─────────────────────────────────────────────────────────────
-/**
- * Atomically replace all workflow state from a manifest.
- * Runs inside a transaction — if any insert fails, no tables are modified.
- * Only touches engine tables + decisions. Does NOT modify artifacts or memories.
- */
-function restore(manifest) {
-    const db = requireDb();
-    transaction(() => {
-        // Clear engine tables (order matters for foreign-key-like consistency)
-        db.exec("DELETE FROM verification_evidence");
-        db.exec("DELETE FROM tasks");
-        db.exec("DELETE FROM slices");
-        db.exec("DELETE FROM milestones");
-        db.exec("DELETE FROM decisions WHERE 1=1");
-        // Restore milestones
-        const msStmt = db.prepare(`INSERT INTO milestones (id, title, status, depends_on, created_at, completed_at,
-        vision, success_criteria, key_risks, proof_strategy,
-        verification_contract, verification_integration, verification_operational, verification_uat,
-        definition_of_done, requirement_coverage, boundary_map_markdown)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`);
-        for (const m of manifest.milestones) {
-            msStmt.run(m.id, m.title, m.status, JSON.stringify(m.depends_on), m.created_at, m.completed_at, m.vision, JSON.stringify(m.success_criteria), JSON.stringify(m.key_risks), JSON.stringify(m.proof_strategy), m.verification_contract, m.verification_integration, m.verification_operational, m.verification_uat, JSON.stringify(m.definition_of_done), m.requirement_coverage, m.boundary_map_markdown);
-        }
-        // Restore slices
-        const slStmt = db.prepare(`INSERT INTO slices (milestone_id, id, title, status, risk, depends, demo,
-        created_at, completed_at, full_summary_md, full_uat_md,
-        goal, success_criteria, proof_level, integration_closure, observability_impact,
-        sequence, replan_triggered_at)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`);
-        for (const s of manifest.slices) {
-            slStmt.run(s.milestone_id, s.id, s.title, s.status, s.risk, JSON.stringify(s.depends), s.demo, s.created_at, s.completed_at, s.full_summary_md, s.full_uat_md, s.goal, s.success_criteria, s.proof_level, s.integration_closure, s.observability_impact, s.sequence, s.replan_triggered_at);
-        }
-        // Restore tasks
-        const tkStmt = db.prepare(`INSERT INTO tasks (milestone_id, slice_id, id, title, status,
-        one_liner, narrative, verification_result, duration, completed_at,
-        blocker_discovered, deviations, known_issues, key_files, key_decisions,
-        full_summary_md, description, estimate, files, verify,
-        inputs, expected_output, observability_impact, sequence)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`);
-        for (const t of manifest.tasks) {
-            tkStmt.run(t.milestone_id, t.slice_id, t.id, t.title, t.status, t.one_liner, t.narrative, t.verification_result, t.duration, t.completed_at, t.blocker_discovered ? 1 : 0, t.deviations, t.known_issues, JSON.stringify(t.key_files), JSON.stringify(t.key_decisions), t.full_summary_md, t.description, t.estimate, JSON.stringify(t.files), t.verify, JSON.stringify(t.inputs), JSON.stringify(t.expected_output), t.observability_impact, t.sequence);
-        }
-        // Restore decisions
-        const dcStmt = db.prepare(`INSERT INTO decisions (seq, id, when_context, scope, decision, choice, rationale, revisable, made_by, superseded_by)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`);
-        for (const d of manifest.decisions) {
-            dcStmt.run(d.seq, d.id, d.when_context, d.scope, d.decision, d.choice, d.rationale, d.revisable, d.made_by, d.superseded_by);
-        }
-        // Restore verification evidence
-        const evStmt = db.prepare(`INSERT INTO verification_evidence (task_id, slice_id, milestone_id, command, exit_code, verdict, duration_ms, created_at)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?)`);
-        for (const e of manifest.verification_evidence) {
-            evStmt.run(e.task_id, e.slice_id, e.milestone_id, e.command, e.exit_code, e.verdict, e.duration_ms, e.created_at);
-        }
     });
 }
+// ─── restore ─────────────────────────────────────────────────────────────
+//
+// The actual restore() implementation lives in gsd-db.ts (single-writer
+// invariant). This module only orchestrates reading the manifest file
+// and handing it to the writer.
 // ─── writeManifest ───────────────────────────────────────────────────────
 /**
  * Write current DB state to .gsd/state-manifest.json via atomicWriteSync.
@@ -258,6 +197,6 @@ export function bootstrapFromManifest(basePath) {
     if (!manifest) {
         return false;
     }
-    restore(manifest);
+    restoreManifest(manifest);
     return true;
 }

package/dist/resources/extensions/gsd/workflow-migration.js

@@ -4,7 +4,7 @@
 // Populates data into the already-existing v10 schema tables.
 import { existsSync, readdirSync, readFileSync } from "node:fs";
 import { join } from "node:path";
-import { _getAdapter, transaction } from "./gsd-db.js";
+import { _getAdapter, bulkInsertLegacyHierarchy } from "./gsd-db.js";
 import { parseRoadmap, parsePlan } from "./parsers-legacy.js";
 import { logWarning } from "./workflow-logger.js";
 // ─── needsAutoMigration ───────────────────────────────────────────────────
@@ -174,27 +174,26 @@ export function migrateFromMarkdown(basePath) {
         process.stderr.write("workflow-migration: no milestones collected, nothing to insert\n");
         return;
     }
-    const placeholders = migratedMilestoneIds.map(() => "?").join(",");
-    transaction(() => {
-        // Clear existing data to handle stale DB shape (DELETE ... IN (...))
-        db.prepare(`DELETE FROM tasks WHERE milestone_id IN (${placeholders})`).run(...migratedMilestoneIds);
-        db.prepare(`DELETE FROM slices WHERE milestone_id IN (${placeholders})`).run(...migratedMilestoneIds);
-        db.prepare(`DELETE FROM milestones WHERE id IN (${placeholders})`).run(...migratedMilestoneIds);
-        // Insert milestones
-        const insertMilestone = db.prepare("INSERT INTO milestones (id, title, status, created_at) VALUES (?, ?, ?, ?)");
-        for (const m of milestoneInserts) {
-            insertMilestone.run(m.id, m.title, m.status, now);
-        }
-        // Insert slices (using v10 column names: depends, sequence)
-        const insertSlice = db.prepare("INSERT INTO slices (id, milestone_id, title, status, risk, depends, sequence, created_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?)");
-        for (const s of sliceInserts) {
-            insertSlice.run(s.id, s.milestoneId, s.title, s.status, s.risk, "[]", s.sequence, now);
-        }
-        // Insert tasks (using v10 column names: sequence, blocker_discovered, full_summary_md)
-        const insertTask = db.prepare("INSERT INTO tasks (id, slice_id, milestone_id, title, description, status, estimate, files, sequence) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)");
-        for (const t of taskInserts) {
-            insertTask.run(t.id, t.sliceId, t.milestoneId, t.title, "", t.status, "", "[]", t.sequence);
-        }
+    bulkInsertLegacyHierarchy({
+        milestones: milestoneInserts,
+        slices: sliceInserts.map(s => ({
+            id: s.id,
+            milestoneId: s.milestoneId,
+            title: s.title,
+            status: s.status,
+            risk: s.risk,
+            sequence: s.sequence,
+        })),
+        tasks: taskInserts.map(t => ({
+            id: t.id,
+            sliceId: t.sliceId,
+            milestoneId: t.milestoneId,
+            title: t.title,
+            status: t.status,
+            sequence: t.sequence,
+        })),
+        clearMilestoneIds: migratedMilestoneIds,
+        createdAt: now,
     });
 }
 // ─── validateMigration ────────────────────────────────────────────────────

package/dist/resources/extensions/gsd/workflow-projections.js

@@ -303,7 +303,10 @@ export async function renderStateProjection(basePath) {
         try {
             adapter.prepare("SELECT 1").get();
         }
-        catch {
+        catch (err) {
+            logWarning("projection", "renderStateProjection: DB handle probe failed, skipping render", {
+                error: err.message,
+            });
             return;
         }
         const state = await deriveState(basePath);

package/dist/resources/extensions/gsd/workflow-reconcile.js

@@ -2,7 +2,7 @@ import { join } from "node:path";
 import { mkdirSync, existsSync, readFileSync, unlinkSync } from "node:fs";
 import { logWarning, logError } from "./workflow-logger.js";
 import { readEvents, findForkPoint, getSessionId } from "./workflow-events.js";
-import { transaction, updateTaskStatus, updateSliceStatus, updateMilestoneStatus, getSliceTasks, insertMilestone, _getAdapter, getMilestoneSlices, insertVerificationEvidence, upsertDecision, openDatabase, setTaskBlockerDiscovered, } from "./gsd-db.js";
+import { transaction, updateTaskStatus, updateSliceStatus, updateMilestoneStatus, getSliceTasks, insertMilestone, getMilestoneSlices, insertVerificationEvidence, upsertDecision, openDatabase, setTaskBlockerDiscovered, insertOrIgnoreSlice, insertOrIgnoreTask, } from "./gsd-db.js";
 import { isClosedStatus } from "./status-guards.js";
 import { invalidateStateCache } from "./state.js";
 import { clearPathCache } from "./paths.js";
@@ -132,11 +132,12 @@ function replayEvents(events) {
                     const milestoneId = p["milestoneId"];
                     const sliceId = p["sliceId"];
                     if (milestoneId && sliceId) {
-                        const adapter = _getAdapter();
-                        if (adapter) {
-                            adapter.prepare(`INSERT OR IGNORE INTO slices (milestone_id, id, title, status, created_at)
-               VALUES (:mid, :sid, :title, 'pending', :ts)`).run({ ":mid": milestoneId, ":sid": sliceId, ":title": p["title"] ?? sliceId, ":ts": event.ts });
-                        }
+                        insertOrIgnoreSlice({
+                            milestoneId,
+                            sliceId,
+                            title: p["title"] ?? sliceId,
+                            createdAt: event.ts,
+                        });
                     }
                     break;
                 }
@@ -148,11 +149,13 @@ function replayEvents(events) {
                     const sliceId = p["sliceId"];
                     const taskId = p["taskId"];
                     if (milestoneId && sliceId && taskId) {
-                        const adapter = _getAdapter();
-                        if (adapter) {
-                            adapter.prepare(`INSERT OR IGNORE INTO tasks (milestone_id, slice_id, id, title, status, created_at)
-               VALUES (:mid, :sid, :tid, :title, 'pending', :ts)`).run({ ":mid": milestoneId, ":sid": sliceId, ":tid": taskId, ":title": p["title"] ?? taskId, ":ts": event.ts });
-                        }
+                        insertOrIgnoreTask({
+                            milestoneId,
+                            sliceId,
+                            taskId,
+                            title: p["title"] ?? taskId,
+                            createdAt: event.ts,
+                        });
                     }
                     break;
                 }

package/dist/resources/extensions/ttsr/ttsr-manager.js

@@ -9,8 +9,10 @@
  * available, testing all patterns in a single DFA pass. Falls back to
  * per-rule JS RegExp iteration when the native module is not loaded.
  */
-import picomatch from "picomatch";
+import { createRequire } from "node:module";
 import { debugTime, debugCount, debugPeak } from "../gsd/debug-logger.js";
+const _require = createRequire(import.meta.url);
+const picomatch = _require("picomatch");
 // ── Native TTSR engine (optional) ─────────────────────────────────────
 let nativeTtsr = null;
 try {