gsd-pi 2.73.1-dev.d987996 → 2.74.0-dev.14c45ac

package/src/resources/extensions/gsd/uok/plan-v2.ts

@@ -0,0 +1,156 @@
+import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+import type { GSDState, Phase } from "../types.js";
+import { gsdRoot, resolveMilestoneFile, resolveSliceFile } from "../paths.js";
+import { isDbAvailable, getMilestoneSlices, getSliceTasks, type SliceRow } from "../gsd-db.js";
+import type { UokGraphNode } from "./contracts.js";
+
+const PLAN_V2_CLARIFY_ROUND_LIMIT = 3;
+const EXECUTION_ENTRY_PHASES: ReadonlySet<Phase> = new Set([
+  "executing",
+  "summarizing",
+  "validating-milestone",
+  "completing-milestone",
+]);
+
+export interface PlanV2CompileResult {
+  ok: boolean;
+  reason?: string;
+  graphPath?: string;
+  nodeCount?: number;
+  clarifyRoundLimit?: number;
+  researchSynthesized?: boolean;
+  draftContextIncluded?: boolean;
+  finalizedContextIncluded?: boolean;
+}
+
+function graphOutputPath(basePath: string): string {
+  return join(gsdRoot(basePath), "runtime", "uok-plan-v2-graph.json");
+}
+
+function hasFileContent(path: string | null): boolean {
+  if (!path || !existsSync(path)) return false;
+  try {
+    return readFileSync(path, "utf-8").trim().length > 0;
+  } catch {
+    return false;
+  }
+}
+
+function countSliceResearchArtifacts(basePath: string, milestoneId: string, slices: SliceRow[]): number {
+  let count = 0;
+  for (const slice of slices) {
+    if (hasFileContent(resolveSliceFile(basePath, milestoneId, slice.id, "RESEARCH"))) {
+      count += 1;
+    }
+  }
+  return count;
+}
+
+function isExecutionEntryPhase(phase: Phase): boolean {
+  return EXECUTION_ENTRY_PHASES.has(phase);
+}
+
+export function compileUnitGraphFromState(basePath: string, state: GSDState): PlanV2CompileResult {
+  const mid = state.activeMilestone?.id;
+  if (!mid) return { ok: false, reason: "no active milestone" };
+  if (!isDbAvailable()) return { ok: false, reason: "database not available" };
+
+  const slices = getMilestoneSlices(mid).sort((a, b) => Number(a.sequence ?? 0) - Number(b.sequence ?? 0));
+  const nodes: UokGraphNode[] = [];
+  const clarifyRoundLimit = PLAN_V2_CLARIFY_ROUND_LIMIT;
+  const draftContextIncluded = hasFileContent(resolveMilestoneFile(basePath, mid, "CONTEXT-DRAFT"));
+  const finalizedContextIncluded = hasFileContent(resolveMilestoneFile(basePath, mid, "CONTEXT"));
+  const researchSynthesized = hasFileContent(resolveMilestoneFile(basePath, mid, "RESEARCH"))
+    || countSliceResearchArtifacts(basePath, mid, slices) > 0;
+
+  if (isExecutionEntryPhase(state.phase) && !finalizedContextIncluded) {
+    const reason = draftContextIncluded
+      ? "milestone context draft exists but finalized CONTEXT.md is missing"
+      : "missing milestone CONTEXT.md";
+    return {
+      ok: false,
+      reason,
+      clarifyRoundLimit,
+      researchSynthesized,
+      draftContextIncluded,
+      finalizedContextIncluded,
+    };
+  }
+
+  for (const slice of slices) {
+    const sid = slice.id;
+    const tasks = getSliceTasks(mid, sid)
+      .sort((a, b) => Number(a.sequence ?? 0) - Number(b.sequence ?? 0));
+
+    let previousTaskNodeId: string | null = null;
+    for (const task of tasks) {
+      const nodeId = `execute-task:${mid}:${sid}:${task.id}`;
+      const dependsOn = previousTaskNodeId ? [previousTaskNodeId] : [];
+      nodes.push({
+        id: nodeId,
+        kind: "unit",
+        dependsOn,
+        writes: task.key_files,
+        metadata: {
+          unitType: "execute-task",
+          unitId: `${mid}.${sid}.${task.id}`,
+          title: task.title,
+          status: task.status,
+        },
+      });
+      previousTaskNodeId = nodeId;
+    }
+
+    if (previousTaskNodeId) {
+      nodes.push({
+        id: `complete-slice:${mid}:${sid}`,
+        kind: "verification",
+        dependsOn: [previousTaskNodeId],
+        metadata: {
+          unitType: "complete-slice",
+          unitId: `${mid}.${sid}`,
+          title: slice.title,
+          status: slice.status,
+        },
+      });
+    }
+  }
+
+  const output = {
+    compiledAt: new Date().toISOString(),
+    milestoneId: mid,
+    pipeline: {
+      clarifyRoundLimit,
+      researchSynthesized,
+      draftContextIncluded,
+      finalizedContextIncluded,
+      sourcePhase: state.phase,
+    },
+    nodes,
+  };
+
+  const outPath = graphOutputPath(basePath);
+  mkdirSync(join(gsdRoot(basePath), "runtime"), { recursive: true });
+  writeFileSync(outPath, JSON.stringify(output, null, 2) + "\n", "utf-8");
+
+  return {
+    ok: true,
+    graphPath: outPath,
+    nodeCount: nodes.length,
+    clarifyRoundLimit,
+    researchSynthesized: output.pipeline.researchSynthesized,
+    draftContextIncluded: output.pipeline.draftContextIncluded,
+    finalizedContextIncluded: output.pipeline.finalizedContextIncluded,
+  };
+}
+
+export function ensurePlanV2Graph(basePath: string, state: GSDState): PlanV2CompileResult {
+  const compiled = compileUnitGraphFromState(basePath, state);
+  if (!compiled.ok) return compiled;
+  if ((compiled.nodeCount ?? 0) <= 0) {
+    return { ok: false, reason: "compiled graph is empty" };
+  }
+  return compiled;
+}

package/src/resources/extensions/gsd/workflow-logger.ts

@@ -20,6 +20,8 @@ import { appendFileSync, readFileSync, existsSync, mkdirSync } from "node:fs";
 import { join } from "node:path";
 
 import { appendNotification } from "./notification-store.js";
+import { buildAuditEnvelope, emitUokAuditEvent } from "./uok/audit.js";
+import { isUnifiedAuditEnabled } from "./uok/audit-toggle.js";
 
 // ─── Types ──────────────────────────────────────────────────────────────
 
@@ -275,6 +277,29 @@ function _push(
     _buffer.shift();
   }
 
+  if (_auditBasePath && isUnifiedAuditEnabled()) {
+    try {
+      emitUokAuditEvent(
+        _auditBasePath,
+        buildAuditEnvelope({
+          traceId: `workflow-log:${component}`,
+          turnId: context?.id,
+          causedBy: context?.fn ?? context?.tool,
+          category: "orchestration",
+          type: severity === "error" ? "workflow-log-error" : "workflow-log-warn",
+          payload: {
+            component,
+            message,
+            context: context ?? {},
+          },
+        }),
+      );
+    } catch (auditEmitErr) {
+      // Best-effort: unified audit projection must never block workflow logger.
+      _writeStderr(`[gsd:workflow-logger] unified-audit emit failed: ${(auditEmitErr as Error).message}\n`);
+    }
+  }
+
   // Persist errors to .gsd/audit-log.jsonl so they survive context resets.
   // Only error-severity entries are persisted — warnings are ephemeral (stderr + buffer)
   // to avoid log amplification from expected-control-flow catch paths.

package/src/resources/extensions/gsd/workflow-manifest.ts

@@ -1,6 +1,7 @@
 import {
   _getAdapter,
-  transaction,
+  readTransaction,
+  restoreManifest,
   type MilestoneRow,
   type SliceRow,
   type TaskRow,
@@ -74,9 +75,7 @@ export function snapshotState(): StateManifest {
 
   // Wrap all reads in a deferred transaction so the snapshot is consistent
   // (all SELECTs see the same DB state even if a concurrent write lands between them).
-  db.exec("BEGIN DEFERRED");
-
-  try {
+  return readTransaction(() => {
   const rawMilestones = db.prepare("SELECT * FROM milestones ORDER BY id").all() as Record<string, unknown>[];
   const milestones: MilestoneRow[] = rawMilestones.map((r) => ({
     id: r["id"] as string,
@@ -186,109 +185,15 @@ export function snapshotState(): StateManifest {
     verification_evidence,
   };
 
-  db.exec("COMMIT");
   return result;
-  } catch (err) {
-    try { db.exec("ROLLBACK"); } catch { /* ignore rollback failure */ }
-    throw err;
-  }
+  });
 }
 
 // ─── restore ─────────────────────────────────────────────────────────────
-
-/**
- * Atomically replace all workflow state from a manifest.
- * Runs inside a transaction — if any insert fails, no tables are modified.
- * Only touches engine tables + decisions. Does NOT modify artifacts or memories.
- */
-function restore(manifest: StateManifest): void {
-  const db = requireDb();
-
-  transaction(() => {
-    // Clear engine tables (order matters for foreign-key-like consistency)
-    db.exec("DELETE FROM verification_evidence");
-    db.exec("DELETE FROM tasks");
-    db.exec("DELETE FROM slices");
-    db.exec("DELETE FROM milestones");
-    db.exec("DELETE FROM decisions WHERE 1=1");
-
-    // Restore milestones
-    const msStmt = db.prepare(
-      `INSERT INTO milestones (id, title, status, depends_on, created_at, completed_at,
-        vision, success_criteria, key_risks, proof_strategy,
-        verification_contract, verification_integration, verification_operational, verification_uat,
-        definition_of_done, requirement_coverage, boundary_map_markdown)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
-    );
-    for (const m of manifest.milestones) {
-      msStmt.run(
-        m.id, m.title, m.status,
-        JSON.stringify(m.depends_on), m.created_at, m.completed_at,
-        m.vision, JSON.stringify(m.success_criteria), JSON.stringify(m.key_risks),
-        JSON.stringify(m.proof_strategy),
-        m.verification_contract, m.verification_integration, m.verification_operational, m.verification_uat,
-        JSON.stringify(m.definition_of_done), m.requirement_coverage, m.boundary_map_markdown,
-      );
-    }
-
-    // Restore slices
-    const slStmt = db.prepare(
-      `INSERT INTO slices (milestone_id, id, title, status, risk, depends, demo,
-        created_at, completed_at, full_summary_md, full_uat_md,
-        goal, success_criteria, proof_level, integration_closure, observability_impact,
-        sequence, replan_triggered_at)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
-    );
-    for (const s of manifest.slices) {
-      slStmt.run(
-        s.milestone_id, s.id, s.title, s.status, s.risk,
-        JSON.stringify(s.depends), s.demo,
-        s.created_at, s.completed_at, s.full_summary_md, s.full_uat_md,
-        s.goal, s.success_criteria, s.proof_level, s.integration_closure, s.observability_impact,
-        s.sequence, s.replan_triggered_at,
-      );
-    }
-
-    // Restore tasks
-    const tkStmt = db.prepare(
-      `INSERT INTO tasks (milestone_id, slice_id, id, title, status,
-        one_liner, narrative, verification_result, duration, completed_at,
-        blocker_discovered, deviations, known_issues, key_files, key_decisions,
-        full_summary_md, description, estimate, files, verify,
-        inputs, expected_output, observability_impact, sequence)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
-    );
-    for (const t of manifest.tasks) {
-      tkStmt.run(
-        t.milestone_id, t.slice_id, t.id, t.title, t.status,
-        t.one_liner, t.narrative, t.verification_result, t.duration, t.completed_at,
-        t.blocker_discovered ? 1 : 0, t.deviations, t.known_issues,
-        JSON.stringify(t.key_files), JSON.stringify(t.key_decisions),
-        t.full_summary_md, t.description, t.estimate, JSON.stringify(t.files), t.verify,
-        JSON.stringify(t.inputs), JSON.stringify(t.expected_output),
-        t.observability_impact, t.sequence,
-      );
-    }
-
-    // Restore decisions
-    const dcStmt = db.prepare(
-      `INSERT INTO decisions (seq, id, when_context, scope, decision, choice, rationale, revisable, made_by, superseded_by)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
-    );
-    for (const d of manifest.decisions) {
-      dcStmt.run(d.seq, d.id, d.when_context, d.scope, d.decision, d.choice, d.rationale, d.revisable, d.made_by, d.superseded_by);
-    }
-
-    // Restore verification evidence
-    const evStmt = db.prepare(
-      `INSERT INTO verification_evidence (task_id, slice_id, milestone_id, command, exit_code, verdict, duration_ms, created_at)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?)`,
-    );
-    for (const e of manifest.verification_evidence) {
-      evStmt.run(e.task_id, e.slice_id, e.milestone_id, e.command, e.exit_code, e.verdict, e.duration_ms, e.created_at);
-    }
-  });
-}
+//
+// The actual restore() implementation lives in gsd-db.ts (single-writer
+// invariant). This module only orchestrates reading the manifest file
+// and handing it to the writer.
 
 // ─── writeManifest ───────────────────────────────────────────────────────
 
@@ -346,6 +251,6 @@ export function bootstrapFromManifest(basePath: string): boolean {
     return false;
   }
 
-  restore(manifest);
+  restoreManifest(manifest);
   return true;
 }

package/src/resources/extensions/gsd/workflow-migration.ts

@@ -5,7 +5,7 @@
 
 import { existsSync, readdirSync, readFileSync } from "node:fs";
 import { join } from "node:path";
-import { _getAdapter, transaction } from "./gsd-db.js";
+import { _getAdapter, bulkInsertLegacyHierarchy } from "./gsd-db.js";
 import { parseRoadmap, parsePlan } from "./parsers-legacy.js";
 import { logWarning } from "./workflow-logger.js";
 
@@ -219,34 +219,26 @@ export function migrateFromMarkdown(basePath: string): void {
     return;
   }
 
-  const placeholders = migratedMilestoneIds.map(() => "?").join(",");
-  transaction(() => {
-    // Clear existing data to handle stale DB shape (DELETE ... IN (...))
-    db.prepare(`DELETE FROM tasks WHERE milestone_id IN (${placeholders})`).run(...migratedMilestoneIds);
-    db.prepare(`DELETE FROM slices WHERE milestone_id IN (${placeholders})`).run(...migratedMilestoneIds);
-    db.prepare(`DELETE FROM milestones WHERE id IN (${placeholders})`).run(...migratedMilestoneIds);
-
-    // Insert milestones
-    const insertMilestone = db.prepare("INSERT INTO milestones (id, title, status, created_at) VALUES (?, ?, ?, ?)");
-    for (const m of milestoneInserts) {
-      insertMilestone.run(m.id, m.title, m.status, now);
-    }
-
-    // Insert slices (using v10 column names: depends, sequence)
-    const insertSlice = db.prepare(
-      "INSERT INTO slices (id, milestone_id, title, status, risk, depends, sequence, created_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?)"
-    );
-    for (const s of sliceInserts) {
-      insertSlice.run(s.id, s.milestoneId, s.title, s.status, s.risk, "[]", s.sequence, now);
-    }
-
-    // Insert tasks (using v10 column names: sequence, blocker_discovered, full_summary_md)
-    const insertTask = db.prepare(
-      "INSERT INTO tasks (id, slice_id, milestone_id, title, description, status, estimate, files, sequence) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)"
-    );
-    for (const t of taskInserts) {
-      insertTask.run(t.id, t.sliceId, t.milestoneId, t.title, "", t.status, "", "[]", t.sequence);
-    }
+  bulkInsertLegacyHierarchy({
+    milestones: milestoneInserts,
+    slices: sliceInserts.map(s => ({
+      id: s.id,
+      milestoneId: s.milestoneId,
+      title: s.title,
+      status: s.status,
+      risk: s.risk,
+      sequence: s.sequence,
+    })),
+    tasks: taskInserts.map(t => ({
+      id: t.id,
+      sliceId: t.sliceId,
+      milestoneId: t.milestoneId,
+      title: t.title,
+      status: t.status,
+      sequence: t.sequence,
+    })),
+    clearMilestoneIds: migratedMilestoneIds,
+    createdAt: now,
   });
 }
 

package/src/resources/extensions/gsd/workflow-projections.ts

@@ -350,7 +350,14 @@ export async function renderStateProjection(basePath: string): Promise<void> {
     // Probe DB handle — adapter may be set but underlying handle closed
     const adapter = _getAdapter();
     if (!adapter) return;
-    try { adapter.prepare("SELECT 1").get(); } catch { return; }
+    try {
+      adapter.prepare("SELECT 1").get();
+    } catch (err) {
+      logWarning("projection", "renderStateProjection: DB handle probe failed, skipping render", {
+        error: (err as Error).message,
+      });
+      return;
+    }
     const state = await deriveState(basePath);
     const content = renderStateContent(state);
     const dir = join(basePath, ".gsd");

package/src/resources/extensions/gsd/workflow-reconcile.ts

@@ -10,12 +10,13 @@ import {
   updateMilestoneStatus,
   getSliceTasks,
   insertMilestone,
-  _getAdapter,
   getMilestoneSlices,
   insertVerificationEvidence,
   upsertDecision,
   openDatabase,
   setTaskBlockerDiscovered,
+  insertOrIgnoreSlice,
+  insertOrIgnoreTask,
 } from "./gsd-db.js";
 import { isClosedStatus } from "./status-guards.js";
 import { invalidateStateCache } from "./state.js";
@@ -164,13 +165,12 @@ function replayEvents(events: WorkflowEvent[]): void {
         const milestoneId = p["milestoneId"] as string;
         const sliceId = p["sliceId"] as string;
         if (milestoneId && sliceId) {
-          const adapter = _getAdapter();
-          if (adapter) {
-            adapter.prepare(
-              `INSERT OR IGNORE INTO slices (milestone_id, id, title, status, created_at)
-               VALUES (:mid, :sid, :title, 'pending', :ts)`,
-            ).run({ ":mid": milestoneId, ":sid": sliceId, ":title": (p["title"] as string) ?? sliceId, ":ts": event.ts });
-          }
+          insertOrIgnoreSlice({
+            milestoneId,
+            sliceId,
+            title: (p["title"] as string) ?? sliceId,
+            createdAt: event.ts,
+          });
         }
         break;
       }
@@ -182,13 +182,13 @@ function replayEvents(events: WorkflowEvent[]): void {
         const sliceId = p["sliceId"] as string;
         const taskId = p["taskId"] as string;
         if (milestoneId && sliceId && taskId) {
-          const adapter = _getAdapter();
-          if (adapter) {
-            adapter.prepare(
-              `INSERT OR IGNORE INTO tasks (milestone_id, slice_id, id, title, status, created_at)
-               VALUES (:mid, :sid, :tid, :title, 'pending', :ts)`,
-            ).run({ ":mid": milestoneId, ":sid": sliceId, ":tid": taskId, ":title": (p["title"] as string) ?? taskId, ":ts": event.ts });
-          }
+          insertOrIgnoreTask({
+            milestoneId,
+            sliceId,
+            taskId,
+            title: (p["title"] as string) ?? taskId,
+            createdAt: event.ts,
+          });
         }
         break;
       }

package/src/resources/extensions/ttsr/ttsr-manager.ts

@@ -9,9 +9,14 @@
  * available, testing all patterns in a single DFA pass. Falls back to
  * per-rule JS RegExp iteration when the native module is not loaded.
  */
-import picomatch from "picomatch";
+import { createRequire } from "node:module";
 import { debugTime, debugCount, debugPeak } from "../gsd/debug-logger.js";
 
+const _require = createRequire(import.meta.url);
+type PicomatchMatcher = (input: string) => boolean;
+type PicomatchFn = (pattern: string) => PicomatchMatcher;
+const picomatch = _require("picomatch") as PicomatchFn;
+
 // ── Native TTSR engine (optional) ─────────────────────────────────────
 let nativeTtsr: {
 	ttsrCompileRules: (rules: { name: string; conditions: string[] }[]) => number;
@@ -65,7 +70,7 @@ export interface TtsrSettings {
 
 interface ToolScope {
 	toolName?: string;
-	pathMatcher?: picomatch.Matcher;
+	pathMatcher?: PicomatchMatcher;
 	pathPattern?: string;
 }
 
@@ -80,7 +85,7 @@ interface TtsrEntry {
 	rule: Rule;
 	conditions: RegExp[];
 	scope: TtsrScope;
-	globalPathMatchers?: picomatch.Matcher[];
+	globalPathMatchers?: PicomatchMatcher[];
 }
 
 /** Tracks when a rule was last injected (for repeat gating). */
@@ -147,7 +152,7 @@ export class TtsrManager {
 		return compiled;
 	}
 
-	#compileGlobalPathMatchers(globs: Rule["globs"]): picomatch.Matcher[] | undefined {
+	#compileGlobalPathMatchers(globs: Rule["globs"]): PicomatchMatcher[] | undefined {
 		if (!globs || globs.length === 0) return undefined;
 		const matchers = globs
 			.map((g) => g.trim())
@@ -239,7 +244,7 @@ export class TtsrManager {
 		return pathValue.replaceAll("\\", "/");
 	}
 
-	#matchesGlob(matcher: picomatch.Matcher, filePaths: string[] | undefined): boolean {
+	#matchesGlob(matcher: PicomatchMatcher, filePaths: string[] | undefined): boolean {
 		if (!filePaths || filePaths.length === 0) return false;
 		for (const filePath of filePaths) {
 			const normalized = this.#normalizePath(filePath);